Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

On Wed, Dec 14, 2022 at 08:56:57AM +0100, Jan Beulich wrote: > On 14.12.2022 08:29, Jan Beulich wrote: > > On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: > >> +static int stats_vcpu_alloc_mfn(struct domain *d) > >> +{ > >> +struct page_info *pg; > >> + > >> +pg = alloc_domheap_page

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

On 17.02.2023 09:50, Matias Ezequiel Vara Larsen wrote: > On Wed, Dec 14, 2022 at 08:56:57AM +0100, Jan Beulich wrote: >> On 14.12.2022 08:29, Jan Beulich wrote: >>> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: +static int stats_vcpu_alloc_mfn(struct domain *d) +{ +str

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

On Fri, Feb 17, 2023 at 09:57:43AM +0100, Jan Beulich wrote: > On 17.02.2023 09:50, Matias Ezequiel Vara Larsen wrote: > > On Wed, Dec 14, 2022 at 08:56:57AM +0100, Jan Beulich wrote: > >> On 14.12.2022 08:29, Jan Beulich wrote: > >>> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: > +

Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

On Fri, 2023-02-17 at 08:12 +0100, Jan Beulich wrote: > On 16.02.2023 21:44, Oleksii wrote: > > On Thu, 2023-02-16 at 12:19 +, Andrew Cooper wrote: > > > On 16/02/2023 12:09 pm, Oleksii wrote: > > > > On Thu, 2023-02-16 at 12:44 +0200, Oleksii wrote: > > > > > On Thu, 2023-02-16 at 08:31 +0100,

[xen-unstable test] 177538: regressions - trouble: fail/pass/starved

flight 177538 xen-unstable real [real] flight 177584 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177538/ http://logs.test-lab.xenproject.org/osstest/logs/177584/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

Re: [PATCH] tools: Remove the use of K&R functions

On Thu, Feb 16, 2023 at 11:16:36PM +, Andrew Cooper wrote: > Clang-15 (as seen in the FreeBSD 14 tests) complains: > > xg_main.c:1248 error: a function declaration without a > prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] > xg_init() > ^ >

Re: [PATCH RFC] xen: Work around Clang-IAS macro expansion bug.

On 17/02/2023 12:19 am, Andrew Cooper wrote: > https://github.com/llvm/llvm-project/issues/60792 > > RFC. I very much dislike this patch, but it does work for me. > > Why the parameter name of foo? Turns out I found a different Clang-IAS > bug/misfeature when trying to name the parameter uniq. >

Re: [PATCH] tools: Remove the use of K&R functions

On Thu, Feb 16, 2023 at 11:16 PM Andrew Cooper wrote: > Clang-15 (as seen in the FreeBSD 14 tests) complains: > > xg_main.c:1248 error: a function declaration without a > prototype is deprecated in all versions of C > [-Werror,-Wstrict-prototypes] > xg_init() > ^ > void >

Re: [PATCH] tools: Remove the use of K&R functions

On 17/02/2023 11:10 am, George Dunlap wrote: > > > On Thu, Feb 16, 2023 at 11:16 PM Andrew Cooper > wrote: > > Clang-15 (as seen in the FreeBSD 14 tests) complains: > >   xg_main.c:1248 error: a function declaration without a >   prototype is deprecated in all versions of C > [-Wer

[PATCH] cirrus: Update FreeBSD to 13.1

Also print the compiler version before starting. It's not easy to find otherwise, and does change from time to time. Signed-off-by: Andrew Cooper --- CC: Stefano Stabellini CC: Anthony PERARD CC: Roger Pau Monné CC: Michal Orzel Example run: https://cirrus-ci.com/task/6205638091472896 b

Re: [PATCH] cirrus: Update FreeBSD to 13.1

On Fri, Feb 17, 2023 at 11:36:47AM +, Andrew Cooper wrote: > Also print the compiler version before starting. It's not easy to find > otherwise, and does change from time to time. > > Signed-off-by: Andrew Cooper Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

[PATCH v1] xen: Work around Clang-IAS macro expansion bug

https://github.com/llvm/llvm-project/issues/60792 It turns out that Clang-IAS does not expand \@ uniquely in a translaition unit, and the XSA-426 change tickles this bug: :4:1: error: invalid symbol redefinition .L1_fill_rsb_loop: ^ make[3]: *** [Rules.mk:247: arch/x86/acpi/cpu_idle.o] Er

[libvirt test] 177565: regressions - trouble: fail/pass/starved

flight 177565 libvirt real [real] flight 177606 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177565/ http://logs.test-lab.xenproject.org/osstest/logs/177606/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-

[xen-unstable-smoke test] 177603: tolerable trouble: pass/starved - PUSHED

flight 177603 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/177603/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

On 17.02.2023 10:29, Matias Ezequiel Vara Larsen wrote: > On Fri, Feb 17, 2023 at 09:57:43AM +0100, Jan Beulich wrote: >> On 17.02.2023 09:50, Matias Ezequiel Vara Larsen wrote: >>> On Wed, Dec 14, 2022 at 08:56:57AM +0100, Jan Beulich wrote: On 14.12.2022 08:29, Jan Beulich wrote: > On 07

Re: [PATCH v2 1/3] automation: move yocto jobs to build stage

Hi Stefano, On 15/02/2023 23:09, Stefano Stabellini wrote: > > > From: Stefano Stabellini > > We are going to use artifacts produced by the Yocto builds in test jobs. > > Signed-off-by: Stefano Stabellini > --- > automation/gitlab-ci/build.yaml | 51 + > auto

Re: [PATCH v2 2/3] automation: add binaries/ to artifacts for Yocto arm32 job

Hi Stefano, On 15/02/2023 23:09, Stefano Stabellini wrote: > > > From: Stefano Stabellini > > Copy the build output of Yocto builds to binaries/ for the arm32 target, > and export binaries/ among the jobs artifacts so that they can be reused > by other jobs. > > Signed-off-by: Stefano Stabell

Re: [PATCH v2 3/3] automation: expand arm32 dom0 test adding xl domain creation

Hi Stefano, On 15/02/2023 23:09, Stefano Stabellini wrote: > > > From: Stefano Stabellini > > As part of the arm32 dom0 test, also create a simple domU using xl. To > do that, we need the toolstack installed in the dom0 rootfs. We switch > to using the kernel and rootfs built by the Yocto arm3

RE : Weekly meeting - Xen Gitlab Issues Review

📝 2023-02-17 Report minutes Xen Gitlab Issues review meeting: https://cryptpad.fr/pad/#/2/pad/edit/fRRWiCN07eq4oa6q31w5HLOx/ For next Week 2023-02-24 : https://cryptpad.fr/pad/#/2/pad/edit/PhI0GK3pNtbm80GI+mqUDXs9/ Marc Ungeschikts (Vates) *De : *Marc Ungeschikts

[PATCH 0/3] x86/kexec: ASM improvements

Mostly to get ELF metadata, but some other easy improvements too. Andrew Cooper (3): x86/kexec: Drop compatibility_mode_far x86/kexec: Simplify the relocation of compat_mode_gdt_desc x86/kexec: Annotate functions with ELF metadata xen/arch/x86/x86_64/kexec_reloc.S | 40 +---

[PATCH 3/3] x86/kexec: Annotate functions with ELF metadata

All of kexec_reloc(), relocate_pages() and compatibility_mode() are function-like. Annotate them appropriately. Furthermore, move the data into a different cacheline from the code, so the relocation of compat_mode_gdt_desc doesn't trigger self-modifying safety logic in the pipeline. No functiona

[PATCH 1/3] x86/kexec: Drop compatibility_mode_far

ljmp is (famously?) incompatible between Intel and AMD CPUs, and while we're using one of the compatible forms, we've got a good stack and lret is the far more common way of doing this. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu ---

[PATCH 2/3] x86/kexec: Simplify the relocation of compat_mode_gdt_desc

Assemble the GDT base relative to kexec_reloc, and simply add the identity map base address to relocate. Adjust a stale comment, and drop the unused matching label. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/x86_64

[linux-linus test] 177574: regressions - trouble: fail/pass/starved

flight 177574 linux-linus real [real] flight 177631 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177574/ http://logs.test-lab.xenproject.org/osstest/logs/177631/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

[PATCH 1/4] x86/svm: cleanup svm.c

Do not include the headers: xen/irq.h asm/hvm/svm/intr.h asm/io.h asm/mem_sharing.h asm/regs.h because none of the declarations and macro definitions in them is used. Sort alphabetically the rest of the headers. Remove the forward declaration of svm_function_table and place start_svm() a

[PATCH 0/4] x86/hvm: {svm,vmx}.{c,h} cleanup

This patch series attempts a cleanup of files {svm,vmx}.{c,h} by removing redundant headers and sorting the rest, removing forward declarations for static functions, reducing the scope of declarations and definitions, removing redundant new lines and trailing spaces etc Xenia Ragiadakou (4): x86

[PATCH 2/4] x86/svm: cleanup svm.h

Remove the forward declaration of struct vcpu because it is not used. Move the forward declaration of struct cpu_user_regs just above the function that needs it (to remind that it will need to be removed along with the function). Move the definitions of NPT_PFEC_with_gla and NPT_PFEC_in_gpt in sv

[PATCH 4/4] x86/vmx: cleanup vmx.h

Do not include the headers: asm/i387.h asm/hvm/trace.h asm/processor.h asm/regs.h because none of the declarations and macro definitions in them is used in this file. Sort alphabetically the rest of the headers. Fix build by including asm/i387.h in vmx.c, needed for vcpu_restore_fpu_lazy().

Re: [PATCH v2 02/13] tools/xenstore: manage per-transaction domain accounting data in an array

Hi Juergen, On 20/01/2023 10:00, Juergen Gross wrote: In order to prepare keeping accounting data in an array instead of using independent fields, switch the struct changed_domain accounting data to that scheme, for now only using an array with one element. In order to be able to extend this sc

Re: [PATCH v2 03/13] tools/xenstore: introduce accounting data array for per-domain values

Hi Juergen, On 20/01/2023 10:00, Juergen Gross wrote: Introduce the scheme of an accounting data array for per-domain accounting data and use it initially for the number of nodes owned by a domain. Make the accounting data type to be unsigned int, as no data is allowed to be negative at any tim

[PATCH v3 0/4] Stop using insecure transports

Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. Changes since v2: - Drop patches 5 and 6, which changed links not used by automated tools. These patches are the least urgent

[PATCH v3 1/4] Use HTTPS for all xenbits.xen.org Git repos

Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports for all xenbits.xen.org Git repositories. It was generated with the following

[PATCH v3 2/4] Build system: Replace git:// and http:// with https://

Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in the build system. Some URLs returned 301 or 302 redirects, so I replaced the

[PATCH v3 3/4] Automation and CI: Replace git:// and http:// with https://

Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in automation and CI. All URLs are known to work. Signed-off-by: Demi Marie Ob

[PATCH v3 4/4] Rip out HyperTransport

It is not used and the website is gone. Signed-off-by: Demi Marie Obenour --- xen/include/xen/pci_regs.h | 37 - 1 file changed, 37 deletions(-) diff --git a/xen/include/xen/pci_regs.h b/xen/include/xen/pci_regs.h index a90aff1712bafc6ed87296858803d16c253e7b

[xen-unstable test] 177591: tolerable trouble: fail/pass/starved - PUSHED

flight 177591 xen-unstable real [real] flight 177653 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177591/ http://logs.test-lab.xenproject.org/osstest/logs/177653/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

[PATCH v3 2/3] automation: add binaries/ to artifacts for Yocto arm32 job

From: Stefano Stabellini Copy the build output of Yocto builds to binaries/ for the arm32 target, and export binaries/ among the jobs artifacts so that they can be reused by other jobs. Signed-off-by: Stefano Stabellini --- Changes in v2: - add --copy-output so that whether the binaries get cop

[PATCH v3 0/3] automation: add arm32 xl domU creation test

Hi all, This patch series add a domU creation test based on xl for arm32. To do that, it reuses the existing arm32 dom0 test, and also reuses the Yocto qemuarm build output. Pipeline (with reduced amount of jobs): https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/781740574 Cheers

[PATCH v3 1/3] automation: move yocto jobs to build stage

From: Stefano Stabellini We are going to use artifacts produced by the Yocto builds in test jobs. Signed-off-by: Stefano Stabellini Reviewed-by: Michal Orzel --- automation/gitlab-ci/build.yaml | 51 + automation/gitlab-ci/test.yaml | 45 --

[PATCH v3 3/3] automation: expand arm32 dom0 test adding xl domain creation

From: Stefano Stabellini As part of the arm32 dom0 test, also create a simple domU using xl. To do that, we need the toolstack installed in the dom0 rootfs. We switch to using the kernel and rootfs built by the Yocto arm32 job. Remove the PCI node from the host device tree: it is unused but caus

[linux-linus test] 177638: regressions - trouble: fail/pass/starved

flight 177638 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/177638/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail REGR. vs. 177531 Tests which are