Re: [RFC PATCH 04/21] xen/arm: vIOMMU: add generic vIOMMU framework

2022-12-05 Thread Michal Orzel
Hi Rahul, On 01/12/2022 17:02, Rahul Singh wrote: > > > This patch adds basic framework for vIOMMU. > > Signed-off-by: Rahul Singh > --- > xen/arch/arm/domain.c| 17 +++ > xen/arch/arm/domain_build.c | 3 ++ > xen/arch/arm/include/asm/viommu.h| 70 +++

Re: [RFC PATCH 05/21] xen/arm: vsmmuv3: Add dummy support for virtual SMMUv3 for guests

2022-12-05 Thread Michal Orzel
Hi Rahul, On 01/12/2022 17:02, Rahul Singh wrote: > > > domain_viommu_init() will be called during domain creation and will add > the dummy trap handler for virtual IOMMUs for guests. > > A host IOMMU list will be created when host IOMMU devices are probed > and this list will be used to create

[ovmf test] 175047: all pass - PUSHED

2022-12-05 Thread osstest service owner
flight 175047 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175047/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7bee2498910a9034faaf90802c49188afb7582dc baseline version: ovmf 735a7496cb35e48ccad51

Re: [PATCH V6 3/3] docs: Add documentation for generic virtio devices

2022-12-05 Thread Viresh Kumar
On 04-12-22, 20:52, Oleksandr Tyshchenko wrote: > So as I understand current series adds support for two virtio devices > (i2c/gpio) that require specific device-tree sub node with specific > compatible in it [1]. Those backends are standalone userspace applications > (daemons) that do not require

[xen-unstable test] 175044: tolerable FAIL

2022-12-05 Thread osstest service owner
flight 175044 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175044/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-pair 11 xen-install/dst_host fail in 175040 pass in 175044 test-amd64-amd64-xl-credit1 20 g

[XEN v4] xen/page_alloc: Relax the BUILD_BUG_ON() in xenheap_max_mfn()

2022-12-05 Thread Ayan Kumar Halder
In the near future, we are considering to use a common xen/domain heap for Arm 32-bit V8-R. In this setup, both PADDR_BITS and BITS_PER_LONG will be 32. Therefore, the condition PADDR_BITS >= BITS_PER_LONG will become true. Looking at the commit that introduce the BUILD_BUG_ON (88e3ed61642b "x86/N

Re: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform

2022-12-05 Thread Wei Chen
Hi Julien, I thought I had replied to your email, but when I am checking to see if I have addressed all your comments, I didn't find my reply on the mailing list. Maybe there is something wrong with my mail system, I didn't find it sooner. Sorry about it. Hope my reply is not too late. On 2

Re: [XEN v4 09/11] xen/Arm: GICv3: Define remaining GIC registers for AArch32

2022-12-05 Thread Ayan Kumar Halder
On 29/11/2022 14:57, Michal Orzel wrote: Hi Ayan, On 28/11/2022 16:56, Ayan Kumar Halder wrote: Define missing assembly aliases for GIC registers on arm32, taking the ones defined already for arm64 as a base. Aliases are defined according to the GIC Architecture Specification ARM IHI 0069H.

Re: [PATCH 1/2] Reduce hard-coding of PAT value

2022-12-05 Thread Jan Beulich
On 04.12.2022 18:13, Demi Marie Obenour wrote: > This makes the code easier to read and more robust against any future > changes to this value. No change in behavior (modulo bugs). > > To: Xen developer discussion Looks like you mean to send this to the list, but you actually sent it to yoursel

Re: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform

2022-12-05 Thread Julien Grall
Hi, On 05/12/2022 10:17, Wei Chen wrote: On 2022/11/10 2:24, Julien Grall wrote: diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig index c93a6b2756..0904793a0b 100644 --- a/xen/arch/arm/platforms/Kconfig +++ b/xen/arch/arm/platforms/Kconfig @@ -1,6 +1,7 @@    choice

Re: [PATCH 1/2] Reduce hard-coding of PAT value

2022-12-05 Thread George Dunlap
On Sun, Dec 4, 2022 at 5:14 PM Demi Marie Obenour < d...@invisiblethingslab.com> wrote: > This makes the code easier to read and more robust against any future > changes to this value. No change in behavior (modulo bugs). > Minor tweak: We generally say something like "No functional change inten

Re: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated

2022-12-05 Thread Julien Grall
Hi Jan, On 25/11/2022 09:17, Jan Beulich wrote: On 24.11.2022 20:08, Julien Grall wrote: From: Julien Grall Explain how the banner in README is generated and take the opportunity to mention what it should look like for RC. Signed-off-by: Julien Grall Acked-by: Jan Beulich albeit with a c

Re: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated

2022-12-05 Thread Julien Grall
On 05/12/2022 11:16, Julien Grall wrote: Hi Jan, On 25/11/2022 09:17, Jan Beulich wrote: On 24.11.2022 20:08, Julien Grall wrote: From: Julien Grall Explain how the banner in README is generated and take the opportunity to mention what it should look like for RC. Signed-off-by: Julien Gr

Re: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated

2022-12-05 Thread Julien Grall
On 01/12/2022 10:50, Henry Wang wrote: Hi, Hi Henry, -Original Message- Subject: Re: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated On 24.11.2022 20:08, Julien Grall wrote: From: Julien Grall Explain how the banner in README is ge

RE: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated

2022-12-05 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v2] process/release-technician-checklist: Explain how the > banner in README is generated > >> Acked-by: Jan Beulich > > > > Release-acked-by: Henry Wang > > Thanks for the release-acked-by. However, I have no p

Re: [PATCH V6 1/3] libxl: Add support for generic virtio device

2022-12-05 Thread Viresh Kumar
On 05-12-22, 11:45, Viresh Kumar wrote: > > > +rc = libxl__backendpath_parse_domid(gc, be_path, > > > &virtio->backend_domid); > > > +if (rc) goto out; > > > + > > > +rc = libxl__parse_backend_path(gc, be_path, &dev); > > > +if (rc) goto out; > > > > The same question for dev vari

Re: [PATCH net] xen-netfront: Fix NULL sring after live migration

2022-12-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 2 Dec 2022 08:52:48 + you wrote: > A NAPI is setup for each network sring to poll data to kernel > The sring with source host is destroyed before live migration and > new sring with target host is setup afte

Re: [XEN v4] xen/page_alloc: Relax the BUILD_BUG_ON() in xenheap_max_mfn()

2022-12-05 Thread Jan Beulich
On 05.12.2022 10:48, Ayan Kumar Halder wrote: > In the near future, we are considering to use a common xen/domain heap for > Arm 32-bit V8-R. In this setup, both PADDR_BITS and BITS_PER_LONG will be > 32. Therefore, the condition PADDR_BITS >= BITS_PER_LONG will become true. > > Looking at the com

Re: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated

2022-12-05 Thread Julien Grall
On 05/12/2022 11:28, Henry Wang wrote: Hi Julien, Hi Henry, -Original Message- From: Julien Grall Subject: Re: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated Acked-by: Jan Beulich Release-acked-by: Henry Wang Thanks for the

RE: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated

2022-12-05 Thread Henry Wang
Hi Julien, > > Speaking of the checklist and maybe it is slightly off topic: Will it bother > > you or other maintainers if I send a patch to remove the "qemu-iwj" > > section in the branch list? According to the discussion with Ian [1], I > > think > > this can be safely dropped, and I am asking

Re: [PATCH v8 2/3] freezer: refactor pm_freezing into a function.

2022-12-05 Thread Ricardo Ribalda
Hi Rafael On Fri, 2 Dec 2022 at 18:48, Rafael J. Wysocki wrote: > > On Thu, Dec 1, 2022 at 12:08 PM Ricardo Ribalda wrote: > > > > Add a way to let the drivers know if the processes are frozen. > > > > This is needed by drivers that are waiting for processes to end on their > > shutdown path. >

Re: [PATCH v5 1/2] xen/arm: vpl011: emulate non-SBSA registers as WI/RAZ

2022-12-05 Thread Michal Orzel
Hi Jiamei, On 05/12/2022 08:26, Jiamei Xie wrote: > > > When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", > Linux SBSA PL011 driver will access PL011 DMACR register in some > functions. As chapter "B Generic UART" in "ARM Server Base System > Architecture"[1] documentation des

Re: [PATCH 1/5] x86/platform: introduce hypercall to get initial video console settings

2022-12-05 Thread Jan Beulich
On 23.11.2022 16:45, Roger Pau Monne wrote: > This is required so PVH dom0 can get the initial video console state > as handled by Xen. PV dom0 will get this as part of the start_info, > but it doesn't seem necessary to place such information in the > HVM start info. > > Signed-off-by: Roger Pau

[XEN v5 00/11] Arm: Enable GICv3 for AArch32

2022-12-05 Thread Ayan Kumar Halder
Hi All, Please find the following patches to enable GICv3 for AArch32. This is a pre-requisite to support Xen on Cortex-R52 (AArch32-v8R system) Let me know your thoughts. Changes from - v1 :- 1. Updated in the changelog for each of the patches. v2 :- 1. Dropped "xen/Arm: GICv3: Move the macr

[XEN v5 01/11] xen/Arm: vGICv3: Sysreg emulation is applicable for AArch64 only

2022-12-05 Thread Ayan Kumar Halder
Sysreg emulation is 64-bit specific, so guard the calls to vgic_v3_emulate_sysreg() as well as the function itself with "#ifdef CONFIG_ARM_64". Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel Acked-by: Julien Grall --- Changes from - v1 - 1. Updated the commit message. v2 - 1. Updat

[XEN v5 02/11] xen/Arm: GICv3: Do not calculate affinity level 3 for AArch32

2022-12-05 Thread Ayan Kumar Halder
Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169 Affinity level 3 is not present in AArch32. Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106, Affinity level 3 is not present in Armv7 (ie arm32). Thus, any access to affinity level 3 needs to be guarded within "ifdef CONFIG_ARM_64". Signed-

Re: [RFC PATCH 04/21] xen/arm: vIOMMU: add generic vIOMMU framework

2022-12-05 Thread Rahul Singh
Hi Jan, > On 2 Dec 2022, at 8:39 am, Jan Beulich wrote: > > On 01.12.2022 17:02, Rahul Singh wrote: >> --- a/xen/drivers/passthrough/Kconfig >> +++ b/xen/drivers/passthrough/Kconfig >> @@ -35,6 +35,12 @@ config IPMMU_VMSA >> (H3 ES3.0, M3-W+, etc) or Gen4 SoCs which IPMMU hardware supports stag

[XEN v5 09/11] xen/Arm: GICv3: Define remaining GIC registers for AArch32

2022-12-05 Thread Ayan Kumar Halder
Define missing assembly aliases for GIC registers on arm32, taking the ones defined already for arm64 as a base. Aliases are defined according to the GIC Architecture Specification ARM IHI 0069H. Defined the following registers:- 1. Interrupt Controller Interrupt Priority Mask Register 2. Interrup

[XEN v5 08/11] xen/Arm: GICv3: Define ICH_AP0R and ICH_AP1R for AArch32

2022-12-05 Thread Ayan Kumar Halder
Adapt save_aprn_regs()/restore_aprn_regs() for AArch32. For which we have defined the following registers:- 1. Interrupt Controller Hyp Active Priorities Group0 Registers 0-3 2. Interrupt Controller Hyp Active Priorities Group1 Registers 0-3 Signed-off-by: Ayan Kumar Halder --- Changes from :- v

Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled

2022-12-05 Thread Jan Beulich
On 21.11.2022 13:23, Andrew Cooper wrote: > On 21/11/2022 08:56, Jan Beulich wrote: >> On 18.11.2022 15:27, Andrew Cooper wrote: >>> On 18/11/2022 12:54, Jan Beulich wrote: On 18.11.2022 13:33, Andrew Cooper wrote: > On 18/11/2022 10:31, Jan Beulich wrote: >> Linux'es relatively new us

Re: [RFC PATCH 04/21] xen/arm: vIOMMU: add generic vIOMMU framework

2022-12-05 Thread Rahul Singh
Hi Julien, > On 3 Dec 2022, at 9:54 pm, Julien Grall wrote: > > Hi Rahul, > > On 01/12/2022 16:02, Rahul Singh wrote: >> This patch adds basic framework for vIOMMU. >> Signed-off-by: Rahul Singh >> --- >> xen/arch/arm/domain.c| 17 +++ >> xen/arch/arm/domain_build.c

Re: [RFC PATCH 04/21] xen/arm: vIOMMU: add generic vIOMMU framework

2022-12-05 Thread Rahul Singh
Hi Michal, > On 5 Dec 2022, at 8:26 am, Michal Orzel wrote: > > Hi Rahul, > > On 01/12/2022 17:02, Rahul Singh wrote: >> >> >> This patch adds basic framework for vIOMMU. >> >> Signed-off-by: Rahul Singh >> --- >> xen/arch/arm/domain.c| 17 +++ >> xen/arch/arm/domain_buil

Re: [RFC PATCH 05/21] xen/arm: vsmmuv3: Add dummy support for virtual SMMUv3 for guests

2022-12-05 Thread Rahul Singh
Hi Michal, > On 5 Dec 2022, at 8:33 am, Michal Orzel wrote: > > Hi Rahul, > > On 01/12/2022 17:02, Rahul Singh wrote: >> >> >> domain_viommu_init() will be called during domain creation and will add >> the dummy trap handler for virtual IOMMUs for guests. >> >> A host IOMMU list will be crea

Re: [RFC PATCH 04/21] xen/arm: vIOMMU: add generic vIOMMU framework

2022-12-05 Thread Julien Grall
On 05/12/2022 13:48, Rahul Singh wrote: Hi Julien, On 3 Dec 2022, at 9:54 pm, Julien Grall wrote: Hi Rahul, On 01/12/2022 16:02, Rahul Singh wrote: This patch adds basic framework for vIOMMU. Signed-off-by: Rahul Singh --- xen/arch/arm/domain.c| 17 +++ xen/arch/a

[PATCH net] xen/netback: don't call kfree_skb() under spin_lock_irqsave()

2022-12-05 Thread Yang Yingliang
It is not allowed to call kfree_skb() from hardware interrupt context or with interrupts being disabled. So replace kfree_skb() with dev_kfree_skb_irq() under spin_lock_irqsave(). Fixes: be81992f9086 ("xen/netback: don't queue unlimited number of packages") Signed-off-by: Yang Yingliang --- driv

Re: [PATCH 2/5] efi: only set a console mode if the current one is invalid

2022-12-05 Thread Jan Beulich
On 23.11.2022 16:45, Roger Pau Monne wrote: > Do not unconditionally set a mode in efi_console_set_mode(), do so > only if the currently set mode is not valid. You don't say why you want to do so. Furthermore ... > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -799,6 +799,11 @@ s

Re: [RFC PATCH 04/21] xen/arm: vIOMMU: add generic vIOMMU framework

2022-12-05 Thread Michal Orzel
Hi Rahul, On 05/12/2022 14:53, Rahul Singh wrote: > > > Hi Michal, > >> On 5 Dec 2022, at 8:26 am, Michal Orzel wrote: >> >> Hi Rahul, >> >> On 01/12/2022 17:02, Rahul Singh wrote: >>> >>> >>> This patch adds basic framework for vIOMMU. >>> >>> Signed-off-by: Rahul Singh >>> --- >>> xen/arch/

Re: [PATCH 3/5] efi: try to use the currently set GOP mode

2022-12-05 Thread Jan Beulich
On 23.11.2022 16:45, Roger Pau Monne wrote: > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -864,6 +864,26 @@ static UINTN __init > efi_find_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, > UINTN gop_mode = ~0, info_size, size; > unsigned int i; > > +if ( (!cols || !r

Re: [PATCH net] xen/netback: don't call kfree_skb() under spin_lock_irqsave()

2022-12-05 Thread Paul Durrant
On 05/12/2022 14:13, Yang Yingliang wrote: It is not allowed to call kfree_skb() from hardware interrupt context or with interrupts being disabled. So replace kfree_skb() with dev_kfree_skb_irq() under spin_lock_irqsave(). Fixes: be81992f9086 ("xen/netback: don't queue unlimited number of packag

[xen-unstable-smoke test] 175048: tolerable all pass - PUSHED

2022-12-05 Thread osstest service owner
flight 175048 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175048/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [RFC PATCH 06/21] xen/domctl: Add XEN_DOMCTL_CONFIG_VIOMMU_* and viommu config param

2022-12-05 Thread Rahul Singh
Hi Jan, > On 2 Dec 2022, at 8:45 am, Jan Beulich wrote: > > On 01.12.2022 17:02, Rahul Singh wrote: >> Add new viommu_type field and field values XEN_DOMCTL_CONFIG_VIOMMU_NONE >> XEN_DOMCTL_CONFIG_VIOMMU_SMMUV3 in xen_arch_domainconfig to >> enable/disable vIOMMU support for domains. >> >> Also

[XEN v5 04/11] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32

2022-12-05 Thread Ayan Kumar Halder
Refer ARM DDI 0487I.a ID081822, G8-9650, G8.2.113 Aff3 does not exist on AArch32. Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106 Aff3 does not exist on Armv7 (ie arm32). Thus, access to aff3 has been protected with "#ifdef CONFIG_ARM_64". Also, v->arch.vmpidr is a 32 bit register on AArch

[XEN v5 03/11] xen/Arm: vreg: Support vreg_reg64_* helpers on AArch32

2022-12-05 Thread Ayan Kumar Halder
In some situations (e.g. GICR_TYPER), the hypervior may need to emulate 64bit registers in AArch32 mode. In such situations, the hypervisor may need to read/modify the lower or upper 32 bits of the 64 bit register. In AArch32, 'unsigned long' is 32 bits. Thus, we cannot use it for 64 bit registers

[XEN v5 05/11] xen/Arm: GICv3: Fix GICR_{PENDBASER, PROPBASER} emulation on 32-bit host

2022-12-05 Thread Ayan Kumar Halder
'unsigned long long' is defined as 64 bit across both AArch32 and AArch64. So, use 'ULL' for 64 bit word instead of UL which is 32 bits for AArch32. GICR_PENDBASER and GICR_PROPBASER both are 64 bit registers. Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel Acked-by: Julien Grall ---

[XEN v5 06/11] xen/Arm: vGICv3: Fix emulation of ICC_SGI1R on AArch32

2022-12-05 Thread Ayan Kumar Halder
Refer Arm IHI 0069H ID020922, 12.5.23, ICC_SGI1R is a 64 bit register on AArch32 systems. Thus, the function needs to change to reflect this. The reason being 'register_t' is defined as 'u32' on AArch32. Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel Acked-by: Julien Grall --- Chang

Re: [RFC PATCH 06/21] xen/domctl: Add XEN_DOMCTL_CONFIG_VIOMMU_* and viommu config param

2022-12-05 Thread Michal Orzel
Hi Rahul, On 01/12/2022 17:02, Rahul Singh wrote: > > > Add new viommu_type field and field values XEN_DOMCTL_CONFIG_VIOMMU_NONE > XEN_DOMCTL_CONFIG_VIOMMU_SMMUV3 in xen_arch_domainconfig to > enable/disable vIOMMU support for domains. > > Also add viommu="N" parameter to xl domain configuratio

[XEN v5 10/11] xen/Arm: GICv3: Define macros to read/write 64 bit

2022-12-05 Thread Ayan Kumar Halder
On AArch32, ldrd/strd instructions are not atomic when used to access MMIO. Furthermore, ldrd/strd instructions are not decoded by Arm when running as a guest to access emulated MMIO region. Thus, we have defined readq_relaxed_non_atomic()/writeq_relaxed_non_atomic() which in turn calls readl_relax

[XEN v5 11/11] xen/Arm: GICv3: Enable GICv3 for AArch32

2022-12-05 Thread Ayan Kumar Halder
One can now use GICv3 on AArch32 systems. However, ITS is not supported. The reason being currently we are trying to validate GICv3 on an AArch32_v8R system. Refer ARM DDI 0568A.c ID110520, B1.3.1, "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE must not implement LPI support."

[XEN v5 07/11] xen/Arm: GICv3: Define ICH_LR_EL2 on AArch32

2022-12-05 Thread Ayan Kumar Halder
Refer "Arm IHI 0069H ID020922", 12.4.6, Interrupt Controller List Registers AArch64 System register ICH_LR_EL2 bits [31:0] are architecturally mapped to AArch32 System register ICH_LR[31:0]. AArch64 System register ICH_LR_EL2 bits [63:32] are architecturally mapped to AArch32 System register ICH_L

Re: [RFC PATCH 08/21] xen/arm: vsmmuv3: Add support for registers emulation

2022-12-05 Thread Rahul Singh
Hi Julien, > On 3 Dec 2022, at 9:16 pm, Julien Grall wrote: > > Hi Rahul, > > I have only skimmed through the patch so far. > > On 01/12/2022 16:02, Rahul Singh wrote: >> static int vsmmuv3_mmio_write(struct vcpu *v, mmio_info_t *info, >>register_t r, void *pri

Re: [PATCH 4/5] multiboot2: parse console= option when setting GOP mode

2022-12-05 Thread Jan Beulich
On 23.11.2022 16:45, Roger Pau Monne wrote: > Only set the GOP mode if vga is selected in the console option, > otherwise just fetch the information from the current mode in order to > make it available to dom0. > > Introduce support for passing the command line to the efi_multiboot2() > helper, a

Re: [RFC PATCH 04/21] xen/arm: vIOMMU: add generic vIOMMU framework

2022-12-05 Thread Julien Grall
On 05/12/2022 14:25, Michal Orzel wrote: diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index 1528ced509..33d32835e7 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -297,10 +297,14 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); #def

[PATCH 4/6] xen: make remove callback of xen driver void returned

2022-12-05 Thread Dawei Li
Since commit fc7a6209d571 ("bus: Make remove callback return void") forces bus_type::remove be void-returned, it doesn't make much sense for any bus based driver implementing remove callbalk to return non-void to its caller. This change is for xen bus based drivers. Signed-off-by: Dawei Li ---

[PATCH 6/6] soundbus: make remove callback of soundbus driver void returned

2022-12-05 Thread Dawei Li
Since commit fc7a6209d571 ("bus: Make remove callback return void") forces bus_type::remove be void-returned, it doesn't make much sense for any bus based driver implementing remove callbalk to return non-void to its caller. This change is for soundbus based drivers. Signed-off-by: Dawei Li ---

[PATCH 1/6] hyperv: Make remove callback of hyperv driver void returned

2022-12-05 Thread Dawei Li
Since commit fc7a6209d571 ("bus: Make remove callback return void") forces bus_type::remove be void-returned, it doesn't make much sense for any bus based driver implementing remove callbalk to return non-void to its caller. This change is for hyperv bus based drivers. Signed-off-by: Dawei Li --

[PATCH 5/6] ac97: make remove callback of ac97 driver void returned

2022-12-05 Thread Dawei Li
Since commit fc7a6209d571 ("bus: Make remove callback return void") forces bus_type::remove be void-returned, it doesn't make much sense for any bus based driver implementing remove callbalk to return non-void to its caller. This change is for ac97 bus based drivers. Signed-off-by: Dawei Li ---

[PATCH 3/6] apr: make remove callback of apr driver void returned

2022-12-05 Thread Dawei Li
Since commit fc7a6209d571 ("bus: Make remove callback return void") forces bus_type::remove be void-returned, it doesn't make much sense for any bus based driver implementing remove callbalk to return non-void to its caller. This change is for apr bus based drivers. Signed-off-by: Dawei Li ---

[PATCH 0/6] Make remove() of any bus based driver void returned

2022-12-05 Thread Dawei Li
For bus-based driver, device removal is implemented as: device_remove() => bus->remove() => driver->remove() Driver core needs no feedback from bus driver about the result of remove callback. In which case, commit fc7a6209d571 ("bus: Make remove callback return void") forces bus_type::remove be vo

[PATCH 2/6] macio: Make remove callback of macio driver void returned

2022-12-05 Thread Dawei Li
Commit fc7a6209d571 ("bus: Make remove callback return void") forces bus_type::remove be void-returned, it doesn't make much sense for any bus based driver implementing remove callbalk to return non-void to its caller. This change is for macio bus based drivers. Signed-off-by: Dawei Li --- arch

[PATCH v2 3/5] xen/Makefile: remove Cppcheck invocation from the Makefile

2022-12-05 Thread Luca Fancellu
The script xen-analysis.py is going to be used for the analysis with cppcheck, so remove the rules from the Makefile The python script xen/tools/merge_cppcheck_reports.py was used by the makefile rules, but its functionality is integrated in the xen-analysis.py script now, so it can be removed. R

[PATCH v2 0/5] Static analyser finding deviation

2022-12-05 Thread Luca Fancellu
This serie introduces a way to suppress a static analyser finding providing a proper justification for it. The process is explained in the docs/misra/documenting-violations.rst document that this serie will provide. The tools currently supported are eclair, coverity and cppcheck, but the design is

[PATCH v2 5/5] xen: Justify linker script defined symbols in include/xen/kernel.h

2022-12-05 Thread Luca Fancellu
Eclair and Coverity found violation of the MISRA rule 8.6 for the symbols _start, _end, start, _stext, _etext, _srodata, _erodata, _sinittext, _einittext which are declared in xen/include/xen/kernel.h. All those symbols are defined by the liker script so we can deviate from the rule 8.6 for these c

[PATCH v2 1/5] xen/scripts: add xen-analysis.py for coverity and eclair analysis

2022-12-05 Thread Luca Fancellu
Add new script for coverity/eclair analysis tool that will enable the procedure to suppress findings when these tool are used. The procedure is documented in docs/misra/documenting-violations.rst and the script is documented in docs/misra/xen-static-analysis.rst. Add in docs/misra/ the files safe.

[PATCH v2 4/5] tools/misra: fix skipped rule numbers

2022-12-05 Thread Luca Fancellu
MISRA rules are in the format Rule X.Y, currently the script convert_misra_doc.py is using two nested loop through range(1,22) to enumerate rules that needs to be skipped, using combination of X.Y in that range, however there are two issues in the code: - rule 22 is never included because the rang

[PATCH v2 2/5] xen/scripts: add cppcheck tool to the xen-analysis.py script

2022-12-05 Thread Luca Fancellu
Add Cppcheck analysis to the xen-analysis.py script using the arguments --run-cppcheck. Now cppcheck analysis will build Xen while the analysis is performed on the source files, it will produce a text report and an additional html output when the script is called with --cppcheck-html. With this p

Re: [PATCH 4/6] xen: make remove callback of xen driver void returned

2022-12-05 Thread Juergen Gross
On 05.12.22 16:36, Dawei Li wrote: Since commit fc7a6209d571 ("bus: Make remove callback return void") forces bus_type::remove be void-returned, it doesn't make much sense for any bus based driver implementing remove callbalk to return non-void to its caller. This change is for xen bus based dri

Re: [PATCH v2 3/5] xen/Makefile: remove Cppcheck invocation from the Makefile

2022-12-05 Thread Jan Beulich
On 05.12.2022 16:40, Luca Fancellu wrote: > The script xen-analysis.py is going to be used for the analysis with > cppcheck, so remove the rules from the Makefile > > The python script xen/tools/merge_cppcheck_reports.py was used by the > makefile rules, but its functionality is integrated in the

Re: [PATCH 0/6] Make remove() of any bus based driver void returned

2022-12-05 Thread Greg KH
On Mon, Dec 05, 2022 at 11:36:38PM +0800, Dawei Li wrote: > For bus-based driver, device removal is implemented as: > device_remove() => bus->remove() => driver->remove() > > Driver core needs no feedback from bus driver about the result of > remove callback. In which case, commit fc7a6209d571 ("b

Re: [PATCH 4/5] multiboot2: parse console= option when setting GOP mode

2022-12-05 Thread Jan Beulich
On 05.12.2022 16:10, Jan Beulich wrote: > On 23.11.2022 16:45, Roger Pau Monne wrote: >> @@ -807,7 +822,21 @@ void __init efi_multiboot2(EFI_HANDLE ImageHandle, >> EFI_SYSTEM_TABLE *SystemTable >> >> if ( gop ) >> { >> -gop_mode = efi_find_gop_mode(gop, 0, 0, 0); >> +co

Re: [PATCH 4/6] xen: make remove callback of xen driver void returned

2022-12-05 Thread Greg KH
On Mon, Dec 05, 2022 at 11:36:42PM +0800, Dawei Li wrote: > Since commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. Please

Re: [PATCH 5/6] ac97: make remove callback of ac97 driver void returned

2022-12-05 Thread Greg KH
On Mon, Dec 05, 2022 at 11:36:43PM +0800, Dawei Li wrote: > Since commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. > > Thi

Re: [PATCH 6/6] soundbus: make remove callback of soundbus driver void returned

2022-12-05 Thread Greg KH
On Mon, Dec 05, 2022 at 11:36:44PM +0800, Dawei Li wrote: > Since commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. > > Thi

Re: [PATCH 2/6] macio: Make remove callback of macio driver void returned

2022-12-05 Thread Greg KH
On Mon, Dec 05, 2022 at 11:36:40PM +0800, Dawei Li wrote: > Commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. > > This chan

[linux-linus test] 175046: regressions - FAIL

2022-12-05 Thread osstest service owner
flight 175046 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175046/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl

Re: [PATCH 5/5] multiboot2: parse vga= option when setting GOP mode

2022-12-05 Thread Jan Beulich
On 23.11.2022 16:45, Roger Pau Monne wrote: > Currently the vga command line gfx- option is ignored when booted > using multboot2 and EFI, as the setting of the GOP mode is done way > before the command line is processed. > > Add support for parsing the vga gfx- selection if present in order to >

[xen-unstable-smoke test] 175049: tolerable all pass - PUSHED

2022-12-05 Thread osstest service owner
flight 175049 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175049/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [RFC PATCH 00/21] Add SMMUv3 Stage 1 Support for XEN guests

2022-12-05 Thread Stefano Stabellini
On Sat, 3 Dec 2022, Julien Grall wrote: > On 01/12/2022 16:02, Rahul Singh wrote: > > This patch series is sent as RFC to get the initial feedback from the > > community. This patch series consists of 21 patches which is a big number > > for > > the reviewer to review the patches but to understand 

[xen-unstable test] 175050: tolerable FAIL - PUSHED

2022-12-05 Thread osstest service owner
flight 175050 xen-unstable real [real] flight 175053 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175050/ http://logs.test-lab.xenproject.org/osstest/logs/175053/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

[qemu-mainline test] 175051: tolerable FAIL - PUSHED

2022-12-05 Thread osstest service owner
flight 175051 qemu-mainline real [real] flight 175054 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175051/ http://logs.test-lab.xenproject.org/osstest/logs/175054/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-am

Re: [PATCH v2 1/5] xen/scripts: add xen-analysis.py for coverity and eclair analysis

2022-12-05 Thread Stefano Stabellini
On Mon, 5 Dec 2022, Luca Fancellu wrote: > Add new script for coverity/eclair analysis tool that will enable > the procedure to suppress findings when these tool are used. > The procedure is documented in docs/misra/documenting-violations.rst > and the script is documented in docs/misra/xen-static-

Re: [PATCH v2 2/5] xen/scripts: add cppcheck tool to the xen-analysis.py script

2022-12-05 Thread Stefano Stabellini
On Mon, 5 Dec 2022, Luca Fancellu wrote: > Add Cppcheck analysis to the xen-analysis.py script using the > arguments --run-cppcheck. > > Now cppcheck analysis will build Xen while the analysis is performed > on the source files, it will produce a text report and an additional > html output when th

[PATCH 3/8] x86/mm/shadow: avoid assuming a specific Xen PAT

2022-12-05 Thread Demi Marie Obenour
This makes the code easier to understand and more robust if Xen's PAT ever changes. Signed-off-by: Demi Marie Obenour --- xen/arch/x86/mm/shadow/multi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c index

[PATCH 5/8] x86/mm/shadow: do not open-code PAGE_CACHE_ATTRS

2022-12-05 Thread Demi Marie Obenour
This makes the code easier to understand. Signed-off-by: Demi Marie Obenour --- xen/arch/x86/mm/shadow/multi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c index 4e94fec3d50cde0e5a26ecb62ff4d00dd00f759d..

[PATCH 4/8] efi: Avoid hard-coding the various PAT constants

2022-12-05 Thread Demi Marie Obenour
This makes the code much easier to understand, and avoids problems if Xen's PAT ever changes in the future. Signed-off-by: Demi Marie Obenour --- xen/common/efi/boot.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c ind

[PATCH 2/8] p2m-pt: Avoid hard-coding Xen's PAT

2022-12-05 Thread Demi Marie Obenour
This makes the code much easier to understand. Signed-off-by: Demi Marie Obenour --- xen/arch/x86/mm/p2m-pt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c index eaba2b0fb4e6830f52b7d112fba8175dfe6d2770..cd1af33b677

[PATCH 1/8] x86/mm: Avoid hard-coding PAT in get_page_from_l1e()

2022-12-05 Thread Demi Marie Obenour
This still hard-codes the assumption that the two spare values are mapped to UC. Removing this assumption would require a more complex patch. Signed-off-by: Demi Marie Obenour --- xen/arch/x86/mm.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/mm.c

[PATCH 0/8] Make PAT handling less brittle

2022-12-05 Thread Demi Marie Obenour
While working on Qubes OS Marek found out that there were some PAT hacks in the Linux i915 driver. I decided to make Xen use Linux’s PAT to see if it solved the graphics glitches that were observed; it did. This required a substantial amount of preliminary work that is useful even without using L

[PATCH 7/8] x86/mm: make code robust to future PAT changes

2022-12-05 Thread Demi Marie Obenour
It may be desirable to change Xen's PAT for various reasons. This requires changes to several _PAGE_* macros as well. Add static assertions to check that XEN_MSR_PAT is consistent with the _PAGE_* macros. Additionally, Xen has two unused entries in the PAT. Currently these are UC, but this will

[RFC PATCH 8/8] Use Linux's PAT

2022-12-05 Thread Demi Marie Obenour
This is purely for testing, to see if it works around a bug in i915. It is not intended to be merged. NOT-signed-off-by: DO NOT MERGE --- xen/arch/x86/include/asm/page.h | 4 ++-- xen/arch/x86/include/asm/processor.h | 12 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff

[PATCH 6/8] x86: Derive XEN_MSR_PAT from its individual entries

2022-12-05 Thread Demi Marie Obenour
This avoids it being a magic constant that is difficult for humans to decode. Use a _Static_assert to check that the old and new values are identical. Signed-off-by: Demi Marie Obenour --- xen/arch/x86/include/asm/processor.h | 22 +- 1 file changed, 21 insertions(+), 1 dele

[linux-linus test] 175052: regressions - FAIL

2022-12-05 Thread osstest service owner
flight 175052 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175052/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl

RE: information and training on Xen Hypervisor

2022-12-05 Thread Sandeep Gupta(UST,IN)
Hi All, We are planning to use xen hypervisor for one of our in-house development of project. Since this is in-house project we have limited budget. We are facing some difficulties to bring-up drivers since we are new to the hypervisor. Can you please suggest me some sought of training or suppo

[xen-unstable test] 175055: tolerable FAIL - PUSHED

2022-12-05 Thread osstest service owner
flight 175055 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175055/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 175050 test-armhf-armhf-libvirt 16 save

[PATCH] tools: Fix removal of COPYING and .gitignore

2022-12-05 Thread Viresh Kumar
The Makefile continues to remove the entire tools/include/xen/ directory on "make clean", which isn't the right thing to do anymore since this file contains files like COPYING and .gitignore now. Since there are only two files at the moment, use "xen/[a-z]*" regex to remove everything else. Fixes

Re: [PATCH] tools: Fix removal of COPYING and .gitignore

2022-12-05 Thread Juergen Gross
On 06.12.22 08:25, Viresh Kumar wrote: The Makefile continues to remove the entire tools/include/xen/ directory on "make clean", which isn't the right thing to do anymore since this file contains files like COPYING and .gitignore now. I don't see a .gitignore file in tools/include/xen, and the