Re: [PATCH 2/2] Changelog: Add __ro_after_init and CET

2022-11-22 Thread Julien Grall
Hi Andrew, On 09/03/2022 12:39, Andrew Cooper wrote: Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- CHANGELOG.md | 6 ++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 83d85fad5bbc..577517383ec9 100644 --- a/CHANGE

Re: EFI's -mapbs option may cause Linux to panic()

2022-11-22 Thread Roger Pau Monné
On Mon, Nov 21, 2022 at 06:01:00PM +0100, Jan Beulich wrote: > On 21.11.2022 17:48, Roger Pau Monné wrote: > > On Mon, Nov 21, 2022 at 05:27:16PM +0100, Jan Beulich wrote: > >> Hello, > >> > >> on a system with these first two EFI memory map entries > >> > >> (XEN) 0-9dfff type

Re: [PATCH 2/2] Changelog: Add __ro_after_init and CET

2022-11-22 Thread Andrew Cooper
On 22/11/2022 08:49, Julien Grall wrote: > Hi Andrew, > > On 09/03/2022 12:39, Andrew Cooper wrote: >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> CC: Roger Pau Monné >> CC: Wei Liu >> --- >>   CHANGELOG.md | 6 ++ >>   1 file changed, 6 insertions(+) >> >> diff --git a/CHANGEL

RE: [PATCH 2/2] Changelog: Add __ro_after_init and CET

2022-11-22 Thread Henry Wang
Hi Both, > -Original Message- > Subject: Re: [PATCH 2/2] Changelog: Add __ro_after_init and CET > > On 22/11/2022 08:49, Julien Grall wrote: > > Hi Andrew, > > > > On 09/03/2022 12:39, Andrew Cooper wrote: > >> Signed-off-by: Andrew Cooper > >> --- > >> CC: Jan Beulich > >> CC: Roger Pa

[PATCH v3 0/3] Populate entries for 4.17

2022-11-22 Thread Henry Wang
Hello, The following changes are preparation work for the 4.17 release. Also collecting the changelog changes happened during the 4.17 dev phase. This is my first pass at the log for the release, it's likely missing more entries. I'm Ccing all maintainers in this cover letter and also in patch #1

[PATCH v3 2/3] Changelog: Add __ro_after_init and CET

2022-11-22 Thread Henry Wang
From: Andrew Cooper Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné --- v2 -> v3: - Remove the "on x86" for __ro_after_init, as Arm also supports the __ro_after_init. v1 -> v2: - Include this patch in the series --- CHANGELOG.md | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v3 1/3] CHANGELOG: Add missing entries for work during the 4.17 release

2022-11-22 Thread Henry Wang
Signed-off-by: Henry Wang --- v2 -> v3: - Move the uncertain release date to patch #3. v1 -> v2: - Correct wording for two x86 entries (clock frequency calibration and SPR & ADL support) following Jan's suggestion. - Add missing Arm entries from Oleksandr. - Add missing i.MX entry following Stefan

[PATCH v3 3/3] CHANGELOG: Start new "unstable" section

2022-11-22 Thread Henry Wang
Signed-off-by: Henry Wang --- v2 -> v3: - Take the opportunity to also adjust the 4.17 entry since this patch will be applied only after branching. - Add 4.17 release date. - Drop Julien's Acked-by because of the change of the patch. v1 -> v2: - Add Julien's Acked-by. --- CHANGELOG.md | 4 +++-

Re: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during the 4.17 release

2022-11-22 Thread Julien Grall
(Reducing the CC-list) Hi, On 22/11/2022 11:26, Henry Wang wrote: Signed-off-by: Henry Wang --- v2 -> v3: - Move the uncertain release date to patch #3. v1 -> v2: - Correct wording for two x86 entries (clock frequency calibration and SPR & ADL support) following Jan's suggestion. - Add missing

Re: [PATCH v3 2/3] Changelog: Add __ro_after_init and CET

2022-11-22 Thread Julien Grall
Hi Henry, On 22/11/2022 11:26, Henry Wang wrote: From: Andrew Cooper Signed-off-by: Andrew Cooper Your signed-off-by is missing. Reviewed-by: Roger Pau Monné --- v2 -> v3: - Remove the "on x86" for __ro_after_init, as Arm also supports the __ro_after_init. > v1 -> v2: - Include this p

Re: [PATCH v3 3/3] CHANGELOG: Start new "unstable" section

2022-11-22 Thread Julien Grall
On 22/11/2022 11:26, Henry Wang wrote: Signed-off-by: Henry Wang --- v2 -> v3: - Take the opportunity to also adjust the 4.17 entry since this patch will be applied only after branching. Does this means the date will not be updated in the CHANGELOG.md for 4.17? Cheers, -- Julien Grall

Re: [PATCH v2] xen/arm: vpl011: Make access to DMACR write-ignore

2022-11-22 Thread Julien Grall
Hi, On 22/11/2022 05:46, Jiamei Xie wrote: When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", Linux SBSA PL011 driver will access PL011 DMACR register in some functions. As chapter "B Generic UART" in "ARM Server Base System Architecture"[1] documentation describes, SBSA UART d

RE: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during the 4.17 release

2022-11-22 Thread Henry Wang
Hi Julien, Thanks for your review as always! > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during > the 4.17 release > > (Reducing the CC-list) Thanks, I will use this CC-list in v4. > > Hi, > > On 22/11/2022 11:26, H

Re: [PATCH v2 0/5] x86: Switch X86_FEATURE_XENPV to cpu_feature_enabled() use

2022-11-22 Thread Juergen Gross
On 04.11.22 08:26, Juergen Gross wrote: Make especially kernels without CONFIG_XEN_PV more efficient by using cpu_feature_enabled(X86_FEATURE_XENPV) instead of boot_cpu_has() and friends. Changes in V2: - new patch 4 Juergen Gross (5): x86: add X86_FEATURE_XENPV to disabled-features.h x86

RE: [PATCH v3 2/3] Changelog: Add __ro_after_init and CET

2022-11-22 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v3 2/3] Changelog: Add __ro_after_init and CET > > Hi Henry, > > On 22/11/2022 11:26, Henry Wang wrote: > > From: Andrew Cooper > > > > Signed-off-by: Andrew Cooper > > Your signed-off-by is missing. Sorry I

RE: [PATCH v3 3/3] CHANGELOG: Start new "unstable" section

2022-11-22 Thread Henry Wang
Hi Julien, (+George since this is about the release date) > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v3 3/3] CHANGELOG: Start new "unstable" section > On 22/11/2022 11:26, Henry Wang wrote: > > Signed-off-by: Henry Wang > > --- > > v2 -> v3: > > - Take the opportuni

[libvirt test] 174907: tolerable all pass - PUSHED

2022-11-22 Thread osstest service owner
flight 174907 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174907/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 174824 test-armhf-armhf-libvirt-qcow2 15 saveres

[linux-linus test] 174903: regressions - FAIL

2022-11-22 Thread osstest service owner
flight 174903 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174903/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-seattle broken in 174890 test-arm64-arm64-examine 8

Re: [PATCH v3 3/3] CHANGELOG: Start new "unstable" section

2022-11-22 Thread Jan Beulich
On 22.11.2022 14:01, Henry Wang wrote: >> -Original Message- >> From: Julien Grall >> Subject: Re: [PATCH v3 3/3] CHANGELOG: Start new "unstable" section >> On 22/11/2022 11:26, Henry Wang wrote: >>> Signed-off-by: Henry Wang >>> --- >>> v2 -> v3: >>> - Take the opportunity to also adjust

[xen-unstable test] 174906: trouble: broken/fail/pass

2022-11-22 Thread osstest service owner
flight 174906 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174906/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvhv2-amd broken test-amd64-amd64-ex

[xen-unstable bisection] complete test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm

2022-11-22 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm testid debian-hvm-install Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tr

Re: [PATCH v2] xen/arm: vpl011: Make access to DMACR write-ignore

2022-11-22 Thread Michal Orzel
Hi, On 22/11/2022 13:25, Julien Grall wrote: > > > Hi, > > On 22/11/2022 05:46, Jiamei Xie wrote: >> When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", >> Linux SBSA PL011 driver will access PL011 DMACR register in some >> functions. As chapter "B Generic UART" in "ARM Server

[PATCH 4/8] tools/ocaml/evtchn: Extend the init() binding with a cloexec flag

2022-11-22 Thread Andrew Cooper
From: Edwin Török For live update, oxenstored wants to clear CLOEXEC on the evtchn handle, so it survives the execve() into the new oxenstored. Have the new interface match how cloexec works in other Ocaml standard libraries. Signed-off-by: Edwin Török Signed-off-by: Andrew Cooper Acked-by: C

[PATCH 2/8] tools/ocaml/evtchn: OCaml 5 support, fix potential resource leak

2022-11-22 Thread Andrew Cooper
From: Edwin Török There is no binding for xenevtchn_close(). In principle, this is a resource leak, but the typical usage is as a singleton that lives for the lifetime of the program. Ocaml 5 no longer permits storing a naked C pointer in an Ocaml value. Therefore, use a Custom block. This al

[PATCH 1/8] tools/oxenstored: Fix incorrect scope after an if statement

2022-11-22 Thread Andrew Cooper
A debug statement got inserted into a single-expression if statement. Insert brackets to give the intended meaning, rather than the actual meaning where the "let con = Connections..." is outside and executed unconditionally. This results in some unnecessary ring checks for domains which otherwise

[PATCH 5/8] tools/oxenstored: Keep /dev/xen/evtchn open across live update

2022-11-22 Thread Andrew Cooper
From: Edwin Török Closing the evtchn handle will unbind and free all local ports. The new xenstored would need to rebind all evtchns, which is work that we don't want or need to be doing during the critical handover period. However, it turns out that the Windows PV drivers also rebind their loc

[PATCH 0/8] Oxenstored live update fixes

2022-11-22 Thread Andrew Cooper
First set of Ocaml fixes, cleaned up from series posted previously. Patch 1 fixes a logical error introduced in the xenstore live update support. Patches 2-5 fix oxenstored to keep /dev/xen/evtchn open across live update. Patches 6-8 fix various issues with diagnostics. All previous feedback ap

[PATCH 6/8] tools/oxenstored: Log live update issues at warning level

2022-11-22 Thread Andrew Cooper
From: Edwin Török During live update, oxenstored tries a best effort approach to recover as many domains and information as possible even if it encounters errors restoring some domains. However, logging about misunderstood input is more severe than simply info. Log it at warning instead. Signed

[PATCH 3/8] tools/ocaml/evtchn: Add binding for xenevtchn_fdopen()

2022-11-22 Thread Andrew Cooper
From: Edwin Török For live update, the new oxenstored needs to reconstruct an evtchn object around an existing file descriptor. Signed-off-by: Edwin Török Signed-off-by: Andrew Cooper Acked-by: Christian Lindig --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes Split o

[PATCH 7/8] tools/oxenstored: Set uncaught exception handler

2022-11-22 Thread Andrew Cooper
From: Edwin Török Unhandled exceptions go to stderr by default, but this doesn't typically work for oxenstored because: * daemonize reopens stderr as /dev/null * systemd redirects stderr to /dev/null too Debugging an unhandled exception requires reproducing the issue locally when using --no-fo

[PATCH 8/8] tools/oxenstored/syslog: Avoid potential NULL dereference

2022-11-22 Thread Andrew Cooper
From: Edwin Török strdup() may return NULL. Check for this before passing to syslog(). Drop const from c_msg. It is bogus, as demonstrated by the need to cast to void * in order to free the memory. Signed-off-by: Edwin Török Acked-by: Christian Lindig --- CC: Christian Lindig CC: David Sco

[PATCH v2 3/3] x86/xen: add a dummy trampoline for Xen PV guests

2022-11-22 Thread Juergen Gross
When running as a Xen PV guest there is no need for setting up the realmode trampoline, as realmode isn't supported in this environment. Trying to setup the trampoline has been proven to be problematic in some cases, especially when trying to debug early boot problems with Xen requiring to keep th

[PATCH v2 0/3] x86/realmode: use a dummy trampoline for Xen PV guests

2022-11-22 Thread Juergen Gross
A Xen PV guests can't run in realmode, so the realmode trampoline can omitted. Changes in V2: - complete new approach Juergen Gross (3): x86/realmode: test real_mode_header outside of real_mode_size_needed() x86/realmode: add trampoline reference structure x86/xen: add a dummy trampoline fo

Re: [PATCH 1/2] hw/xen/xen_pt: Call default handler only if no custom one is set

2022-11-22 Thread Anthony PERARD
On Mon, Nov 14, 2022 at 08:20:10PM +0100, Marek Marczykowski-Górecki wrote: > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > index 0ec7e52183..269bd26109 100644 > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -255,6 +255,7 @@ static void xen_pt_pci_write_config(PCIDevice *d, > uint32_t addr

Re: [PATCH v3 2/9] xen/arm: add cache coloring initialization for domains

2022-11-22 Thread Julien Grall
Hi Jan, On 21/11/2022 16:40, Jan Beulich wrote: On 21.11.2022 17:23, Carlo Nonato wrote: On Mon, Nov 21, 2022 at 4:14 PM Jan Beulich wrote: On 21.11.2022 15:50, Carlo Nonato wrote: I want to ask you some questions about this patch because in the previous version me and Julien have discussed

Re: [PATCH] docs/misc/arm: Update references to Linux kernel docs

2022-11-22 Thread Julien Grall
(+ Henry) Hi, On 18/11/2022 13:10, Bertrand Marquis wrote: Hi Michal, On 18 Nov 2022, at 11:45, Michal Orzel wrote: Some time ago, Linux switched the format of docs to ReST and the format of device-tree bindings to json-schema. Signed-off-by: Michal Orzel Reviewed-by: Bertrand Marquis

Re: [PATCH 1/3] xen/arm: Drop early_uart_init macro from debug-meson.inc

2022-11-22 Thread Julien Grall
Hi Michal, On 18/11/2022 11:46, Michal Orzel wrote: early_uart_init macro is only used if CONFIG_EARLY_UART_INIT is set. This config option depends on EARLY_UART_PL011, so there is no point in defining it for MESON, especially if it is empty. Remove it and adapt the existing comment. Signed-off

Re: [PATCH 3/3] xen/arm: Define WLEN_8 macro and use it in debug-pl011

2022-11-22 Thread Julien Grall
Hi Michal, On 18/11/2022 11:46, Michal Orzel wrote: At the moment, early printk code for pl011 uses a hardcoded value for 8n1 LCR configuration. Define and use macro WLEN_8 for that purpose (no parity and 1 stop bit are defined as 0). Signed-off-by: Michal Orzel Acked-by: Julien Grall Chee

Re: [XEN v3 01/12] xen/Arm: vGICv3: Sysreg emulation is applicable for AArch64 only

2022-11-22 Thread Julien Grall
On 17/11/2022 13:05, Michal Orzel wrote: Hi Ayan, On 11/11/2022 15:17, Ayan Kumar Halder wrote: Sysreg emulation is 64-bit specific, so guard the calls to vgic_v3_emulate_sysreg() as well as the function itself with "#ifdef CONFIG_ARM_64". Signed-off-by: Ayan Kumar Halder Reviewed-by: Mic

Re: [XEN v3 02/12] xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32

2022-11-22 Thread Julien Grall
On 17/11/2022 13:39, Michal Orzel wrote: Hi Ayan, On 11/11/2022 15:17, Ayan Kumar Halder wrote: Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169 Affinity level 3 is not present in AArch32. Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106, Affinity level 3 is not present in Armv7 (ie

Re: [XEN v3 03/12] xen/Arm: vreg: Support vreg_reg64_* helpers on AArch32

2022-11-22 Thread Julien Grall
Hi Michal, On 17/11/2022 13:11, Michal Orzel wrote: On 11/11/2022 15:17, Ayan Kumar Halder wrote: In some situations (e.g. GICR_TYPER), the hypervior may need to emulate 64bit registers in AArch32 mode. In such situations, the hypervisor may need to read/modify the lower or upper 32 bits of the

Re: [XEN v3 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32

2022-11-22 Thread Julien Grall
Hi Ayan, On 11/11/2022 14:17, Ayan Kumar Halder wrote: Refer ARM DDI 0487I.a ID081822, G8-9650, G8.2.113 Aff3 does not exist on AArch32. Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106 Aff3 does not exist on Armv7 (ie arm32). Thus, access to aff3 have been contained within "#ifdef CONFI

[linux-linus test] 174918: regressions - FAIL

2022-11-22 Thread osstest service owner
flight 174918 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174918/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-seattle broken in 174890 test-arm64-arm64-examine 8

[xen-unstable test] 174920: trouble: broken/fail/pass

2022-11-22 Thread osstest service owner
flight 174920 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174920/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-pvshimbroken test-amd64-amd64-xl-

[seabios test] 174925: tolerable FAIL - PUSHED

2022-11-22 Thread osstest service owner
flight 174925 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/174925/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 171687 test-amd64-i386-xl-qemuu-win7-amd64 19 gu

Re: Porting Xen in raspberry pi4B

2022-11-22 Thread Stefano Stabellini
Hi Vipul, I cannot spot any issue in the configuration, in particual you have: CONFIG_XEN_FBDEV_FRONTEND=y which is what you need. The only thing I can suggest is to add printks to the Linux frontend driver (the one running in the domU) which is drivers/video/fbdev/xen-fbfront.c and printfs to

RE: [PATCH] docs/misc/arm: Update references to Linux kernel docs

2022-11-22 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH] docs/misc/arm: Update references to Linux kernel docs > > (+ Henry) Thanks. > > Hi, > > On 18/11/2022 13:10, Bertrand Marquis wrote: > > Hi Michal, > > > >> On 18 Nov 2022, at 11:45, Michal Orzel wrote: > >>

[qemu-mainline test] 174923: tolerable FAIL - PUSHED

2022-11-22 Thread osstest service owner
flight 174923 qemu-mainline real [real] flight 174933 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174923/ http://logs.test-lab.xenproject.org/osstest/logs/174933/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-am

[PATCH v4 0/3] Populate entries for 4.17

2022-11-22 Thread Henry Wang
Hello, The following changes are preparation work for the 4.17 release. Also collecting the changelog changes happened during the 4.17 dev phase. This is my first pass at the log for the release, it's likely missing more entries. Thanks, Henry v3 -> v4: - Use the corrected sentence for VIRT_SSBD

[PATCH v4 1/3] CHANGELOG: Add missing entries for work during the 4.17 release

2022-11-22 Thread Henry Wang
Signed-off-by: Henry Wang --- v3 -> v4: - Use the corrected sentence for VIRT_SSBD and MSR_SPEC_CTRL - Clarify that the virtio-mmio toolstack for ARM is only creating the device-tree binding. - Remove the "initial" in i.MX entry. v2 -> v3: - Move the uncertain release date to patch #3. v1 -> v2:

[PATCH v4 2/3] Changelog: Add __ro_after_init and CET

2022-11-22 Thread Henry Wang
From: Andrew Cooper Signed-off-by: Andrew Cooper Signed-off-by: Henry Wang Reviewed-by: Roger Pau Monné --- v3 -> v4: - Add my own sign-off because I changed the original wording. v2 -> v3: - Remove the "on x86" for __ro_after_init, as Arm also supports the __ro_after_init. v1 -> v2: - Inclu

[PATCH v4 3/3] CHANGELOG: Start new "unstable" section

2022-11-22 Thread Henry Wang
Signed-off-by: Henry Wang --- v3 -> v4: - No change. v2 -> v3: - Take the opportunity to also adjust the 4.17 entry since this patch will be applied only after branching. - Add 4.17 release date. - Drop Julien's acked-by because of the content change. v1 -> v2: - Add Julien's Acked-by. --- CHAN

RE: [PATCH v2] xen/arm: vpl011: Make access to DMACR write-ignore

2022-11-22 Thread Jiamei Xie
Hi Julien, > -Original Message- > From: Julien Grall > Sent: Tuesday, November 22, 2022 8:26 PM > To: Jiamei Xie ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk > Subject: Re: [PATCH v2] xen/arm: vpl011: Make access to DMACR

RE: [PATCH v2] xen/arm: vpl011: Make access to DMACR write-ignore

2022-11-22 Thread Jiamei Xie
Hi Michal, > -Original Message- > From: Michal Orzel > Sent: Tuesday, November 22, 2022 11:17 PM > To: Julien Grall ; Jiamei Xie ; xen- > de...@lists.xenproject.org > Cc: Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk > Subject: Re: [PATCH v2] xen/arm: vpl011: M

Re: EFI's -mapbs option may cause Linux to panic()

2022-11-22 Thread Juergen Gross
On 22.11.22 10:47, Roger Pau Monné wrote: On Mon, Nov 21, 2022 at 06:01:00PM +0100, Jan Beulich wrote: On 21.11.2022 17:48, Roger Pau Monné wrote: On Mon, Nov 21, 2022 at 05:27:16PM +0100, Jan Beulich wrote: Hello, on a system with these first two EFI memory map entries (XEN) 0-