Re: Design session "grant v3"

2022-09-26 Thread Juergen Gross
On 26.09.22 08:57, Jan Beulich wrote: On 23.09.2022 11:31, Juergen Gross wrote: On 22.09.22 20:43, Jan Beulich wrote: On 22.09.2022 15:42, Marek Marczykowski-Górecki wrote: Yann: can backend refuse revoking? Jürgen: it shouldn't be this way, but revoke could be controlled by feature flag; r

Re: Design session "grant v3"

2022-09-26 Thread Jan Beulich
On 26.09.2022 09:04, Juergen Gross wrote: > On 26.09.22 08:57, Jan Beulich wrote: >> On 23.09.2022 11:31, Juergen Gross wrote: >>> On 22.09.22 20:43, Jan Beulich wrote: On 22.09.2022 15:42, Marek Marczykowski-Górecki wrote: > Yann: can backend refuse revoking? > Jürgen: it shouldn't

Re: [PATCH] x86/ept: limit calls to memory_type_changed()

2022-09-26 Thread Jan Beulich
On 23.09.2022 10:35, Roger Pau Monné wrote: > On Thu, Sep 22, 2022 at 09:21:59PM +0200, Jan Beulich wrote: >> On 22.09.2022 18:05, Roger Pau Monne wrote: >>> memory_type_changed() is currently only implemented for Intel EPT, and >>> results in the invalidation of EMT attributes on all the entries i

Re: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series

2022-09-26 Thread Jan Beulich
On 23.09.2022 14:10, Ayan Kumar Halder wrote: > On 23/09/2022 12:02, Rahul Singh wrote: >> --- a/xen/arch/arm/setup.c >> +++ b/xen/arch/arm/setup.c >> @@ -1166,9 +1166,10 @@ void __init start_xen(unsigned long boot_phys_offset, >> printk(XENLOG_INFO "Xen dom0less mode detected\n"); >> >>

Re: [PATCH 01/12] xen/arm: add cache coloring initialization

2022-09-26 Thread Jan Beulich
On 26.09.2022 08:20, Wei Chen wrote: > On 2022/8/26 20:51, Carlo Nonato wrote: >> --- a/xen/arch/arm/Kconfig >> +++ b/xen/arch/arm/Kconfig >> @@ -131,6 +131,22 @@ config ARM64_BTI >>Branch Target Identification support. >>This feature is not supported in Xen. >> >> +config CACHE_

Re: Design session PVH dom0

2022-09-26 Thread Jan Beulich
On 23.09.2022 10:20, Juergen Gross wrote: > On 21.09.22 17:53, Marek Marczykowski-Górecki wrote: >> Session description (by Jan): >> In the course of working on an XSA I had to finally get PVH Dom0 work on at >> least one of my systems, in a minimal fashion. This had turned up a number >> of issu

Re: Design session PVH dom0

2022-09-26 Thread Juergen Gross
On 26.09.22 09:53, Jan Beulich wrote: On 23.09.2022 10:20, Juergen Gross wrote: On 21.09.22 17:53, Marek Marczykowski-Górecki wrote: Session description (by Jan): In the course of working on an XSA I had to finally get PVH Dom0 work on at least one of my systems, in a minimal fashion. This had

Re: [PATCH] x86/ept: simplify detection of special pages for EMT calculation

2022-09-26 Thread Jan Beulich
On 23.09.2022 12:56, Roger Pau Monne wrote: > The current way to detect whether a page handled to > epte_get_entry_emt() is special and needs a forced write-back cache > attribute involves iterating over all the smaller 4K pages for > superpages. > > Such loop consumes a high amount of CPU time fo

Re: [PATCH 2/2] xen/arm: fix booting ACPI based system after static evtchn series

2022-09-26 Thread Ayan Kumar Halder
On 26/09/2022 08:38, Jan Beulich wrote: On 23.09.2022 14:10, Ayan Kumar Halder wrote: On 23/09/2022 12:02, Rahul Singh wrote: --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -1166,9 +1166,10 @@ void __init start_xen(unsigned long boot_phys_offset, printk(XENLOG_INFO "Xen d

Re: [PATCH 1/2] xen: Add static event channel in SUPPORT.md on ARM

2022-09-26 Thread Ayan Kumar Halder
On 23/09/2022 12:02, Rahul Singh wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. Static event channel support is tech preview, which shall be documented in SUPP

Re: [PATCH 0/7] Fix MISRA C 2012 Rule 20.7 violations

2022-09-26 Thread Xenia Ragiadakou
Hi Roberto, On 9/18/22 16:02, Roberto Bagnara wrote: On 03/09/22 02:52, Stefano Stabellini wrote: +Roberto I think we need Roberto's advice on Rule 20.7. (Full thread below.) Hi there, sorry for the delay: I missed this message. Please see below, where I took the freedom of rearranging the c

[xen-unstable test] 173313: tolerable FAIL

2022-09-26 Thread osstest service owner
flight 173313 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173313/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail pass in 173306 test-amd64-i386-examine

Re: [PATCH v2] MAINTAINERS: ARINC 653 scheduler maintainer updates

2022-09-26 Thread Jan Beulich
On 19.09.2022 04:10, Stewart Hildebrand wrote: > From: Stewart Hildebrand > > Add Nathan Studer as co-maintainer. > > I am departing DornerWorks. I will still be working with Xen in my next > role, and I still have an interest in co-maintaining the ARINC 653 > scheduler, so change to my personal

[ovmf test] 173314: all pass - PUSHED

2022-09-26 Thread osstest service owner
flight 173314 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173314/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d97ee3244d806d324a22ea530215a9f10d2b23e2 baseline version: ovmf 0e7aa6bf9e0a7a9113635

Re: Design session "grant v3"

2022-09-26 Thread Juergen Gross
On 26.09.22 09:23, Jan Beulich wrote: On 26.09.2022 09:04, Juergen Gross wrote: On 26.09.22 08:57, Jan Beulich wrote: On 23.09.2022 11:31, Juergen Gross wrote: On 22.09.22 20:43, Jan Beulich wrote: On 22.09.2022 15:42, Marek Marczykowski-Górecki wrote: Yann: can backend refuse revoking? Jü

Re: Design session PVH dom0

2022-09-26 Thread Jan Beulich
On 26.09.2022 10:33, Juergen Gross wrote: > On 26.09.22 09:53, Jan Beulich wrote: >> On 23.09.2022 10:20, Juergen Gross wrote: >>> On 21.09.22 17:53, Marek Marczykowski-Górecki wrote: Session description (by Jan): In the course of working on an XSA I had to finally get PVH Dom0 work on >

[PATCH v2] x86/PVH: restore VMX APIC assist for Dom0

2022-09-26 Thread Jan Beulich
I don't expect it was intended to default PVH Dom0 to "no assist" mode. Introduce command line (sub-)options allowing to suppress enabling of the assists, paralleling the guest config settings for DomU, but restore the defaulting to "enabled". Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage

Re: Design session PVH dom0

2022-09-26 Thread Juergen Gross
On 26.09.22 11:30, Jan Beulich wrote: On 26.09.2022 10:33, Juergen Gross wrote: On 26.09.22 09:53, Jan Beulich wrote: On 23.09.2022 10:20, Juergen Gross wrote: On 21.09.22 17:53, Marek Marczykowski-Górecki wrote: Session description (by Jan): In the course of working on an XSA I had to finall

[PATCH v2 05/10] automation: Add Arm containers to containerize script

2022-09-26 Thread Michal Orzel
Script automation/scripts/containerize makes it easy to build Xen within predefined containers from gitlab container registry. This script is currently missing the helpers to select Arm containers, so populate the necessary entries. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini --- Ch

[PATCH v2 00/10] GitLab CI cleanup & improvements for Arm

2022-09-26 Thread Michal Orzel
This patch series performs necessary cleanup and improvements in our GitLab CI automation for Arm. This is crucial so that in the future we can focus on adding new tests instead of spending time to fix issues, making the behavior consistent, removing ambiguity, etc. With the increased interest in

[PATCH v2 01/10] automation: Use custom build jobs when extra config options are needed

2022-09-26 Thread Michal Orzel
Currently, all the arm64 defconfig build jobs, regardless of the container used, end up building Xen with the extra config options specified in the main build script (e.g. CONFIG_EXPERT, CONFIG_STATIC_MEMORY). Because these options are only needed for specific test jobs, the current behavior of the

[PATCH v2 02/10] automation: Add randconfig build jobs for arm64 alpine container

2022-09-26 Thread Michal Orzel
For arm64 we perform builds using debian and alpine containers. We are missing the randconfig build jobs for the latter, so add them. This way for each container we have 4 fundamental build jobs: - defconfig non-debug/debug - randconfig non-debug/debug Signed-off-by: Michal Orzel --- Changes in v

[PATCH v2 03/10] automation: qemu-smoke-arm64.sh: Increase RAM size

2022-09-26 Thread Michal Orzel
In the follow-up patch we will add new jobs using debug Xen builds. Because the debug builds take more space and we might end up in a situation when there is not enough free space (especially during a static memory test that reserves some region in the middle), increase RAM size for QEMU from 1GB t

[PATCH v2 04/10] automation: Add debug versions of Arm tests

2022-09-26 Thread Michal Orzel
At the moment, all the tests are executed on non-debug Xen builds. To improve the coverage (e.g. we might catch some asserts), add new test jobs using debug Xen builds. Signed-off-by: Michal Orzel --- Changes in v2: - carve out the RAM size change to a separate patch [v2 03/10] --- automation/gi

[PATCH v2 10/10] automation: Rename qemu-smoke-arm32.sh to qemu-smoke-dom0-arm32.sh

2022-09-26 Thread Michal Orzel
After qemu arm64 test scripts had been renamed to reflect their usage, do the same for the qemu arm32 test script. Currently it only boots dom0, so we can assume that this script will be used to perform dom0 based testing. In the future we will be able to create corresponding script qemu-smoke-dom0

[PATCH v2 08/10] automation: Rename qemu-smoke-arm64.sh to qemu-smoke-dom0less-arm64.sh

2022-09-26 Thread Michal Orzel
Testing arm64 is done using the qemu-alpine-arm64.sh and qemu-smoke-arm64.sh scripts. These scripts are executed with exactly the same artifacts (container, rootfs, kernel, qemu) and the only difference is that the former is used to perform dom0 based testing and the latter - dom0less based testing

[PATCH v2 09/10] automation: Rename qemu-alpine-arm64.sh to qemu-smoke-dom0-arm64.sh

2022-09-26 Thread Michal Orzel
qemu-alpine-arm64.sh script is used to perform dom0 based testing. Rename this script to qemu-smoke-dom0-arm64.sh to reflect its usage. Also rename the corresponding test jobs. Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini --- Changes in v2: - none --- automation/gitlab-ci/test.yaml

[PATCH] drivers/char: Fix build when CET-IBT is enabled

2022-09-26 Thread Andrew Cooper
https://gitlab.com/xen-project/xen/-/jobs/3083068950#L1763 Signed-off-by: Andrew Cooper Fixes: 022e40edd4dc ("drivers/char: allow using both dbgp=xhci and dbgp=ehci") --- CC: Jan Beulich CC: Marek Marczykowski-Górecki CC: Henry Wang --- xen/drivers/char/ehci-dbgp.c | 2 +- xen/drivers/char/xh

[For 4.17] Re: [PATCH] drivers/char: Fix build when CET-IBT is enabled

2022-09-26 Thread Andrew Cooper
On 26/09/2022 12:05, Andrew Cooper wrote: > https://gitlab.com/xen-project/xen/-/jobs/3083068950#L1763 > > Signed-off-by: Andrew Cooper > Fixes: 022e40edd4dc ("drivers/char: allow using both dbgp=xhci and dbgp=ehci") > --- > CC: Jan Beulich > CC: Marek Marczykowski-Górecki > CC: Henry Wang Sor

[PATCH v2 07/10] automation: qemu-alpine-arm64: Cleanup and fixes

2022-09-26 Thread Michal Orzel
Perform the following cleanup: - rename the device tree from virt-gicv3 to virt-gicv2 as the GIC version used in this test is v2, - use fdtput to perform modifications on the dtb, - use DEBIAN_FRONTENT=noninteractive to prevent interactive prompt being stuck waiting for answer other than "yes",

[PATCH v2 06/10] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder

2022-09-26 Thread Michal Orzel
Take an example from arm64 qemu test scripts and use ImageBuilder to generate u-boot script automatically. Calculating the addresses manually is quite error prone and also we will be able to benefit from using ImageBuilder when adding domUs to this test in the future. Install and use u-boot from t

Re: [PATCH v2 02/10] automation: Add randconfig build jobs for arm64 alpine container

2022-09-26 Thread Luca Fancellu
> On 26 Sep 2022, at 12:04, Michal Orzel wrote: > > For arm64 we perform builds using debian and alpine containers. > We are missing the randconfig build jobs for the latter, so add them. > This way for each container we have 4 fundamental build jobs: > - defconfig non-debug/debug > - randconf

Re: [PATCH v2 03/10] automation: qemu-smoke-arm64.sh: Increase RAM size

2022-09-26 Thread Luca Fancellu
> On 26 Sep 2022, at 12:04, Michal Orzel wrote: > > In the follow-up patch we will add new jobs using debug Xen builds. > Because the debug builds take more space and we might end up in > a situation when there is not enough free space (especially during > a static memory test that reserves so

Re: [PATCH v2 06/10] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder

2022-09-26 Thread Luca Fancellu
> On 26 Sep 2022, at 12:04, Michal Orzel wrote: > > Take an example from arm64 qemu test scripts and use ImageBuilder > to generate u-boot script automatically. Calculating the addresses > manually is quite error prone and also we will be able to benefit > from using ImageBuilder when adding d

Re: [PATCH v2 01/10] automation: Use custom build jobs when extra config options are needed

2022-09-26 Thread Luca Fancellu
> On 26 Sep 2022, at 12:04, Michal Orzel wrote: > > Currently, all the arm64 defconfig build jobs, regardless of the > container used, end up building Xen with the extra config options > specified in the main build script (e.g. CONFIG_EXPERT, > CONFIG_STATIC_MEMORY). Because these options are

Re: [PATCH v2 04/10] automation: Add debug versions of Arm tests

2022-09-26 Thread Luca Fancellu
> On 26 Sep 2022, at 12:04, Michal Orzel wrote: > > At the moment, all the tests are executed on non-debug Xen builds. > To improve the coverage (e.g. we might catch some asserts), add new > test jobs using debug Xen builds. > > Signed-off-by: Michal Orzel > --- > Changes in v2: > - carve ou

Re: [PATCH] drivers/char: Fix build when CET-IBT is enabled

2022-09-26 Thread Luca Fancellu
> On 26 Sep 2022, at 12:05, Andrew Cooper wrote: > > https://gitlab.com/xen-project/xen/-/jobs/3083068950#L1763 Is this link permanent? Otherwise I think we should put just the reason of failure as commit message. Cheers, Luca

Re: [PATCH 0/2] xen/arm: static event channel

2022-09-26 Thread Bertrand Marquis
Hi Rahul, Please give the necessary justification for inclusion in 4.17: - severity of the bug fixed - probability and impact of potential issues that the patch could add. thanks Bertrand > On 23 Sep 2022, at 13:02, Rahul Singh wrote: > > This patch series fix issues related to static event ch

Re: [PATCH] drivers/char: Fix build when CET-IBT is enabled

2022-09-26 Thread Jan Beulich
On 26.09.2022 13:05, Andrew Cooper wrote: > https://gitlab.com/xen-project/xen/-/jobs/3083068950#L1763 > > Signed-off-by: Andrew Cooper > Fixes: 022e40edd4dc ("drivers/char: allow using both dbgp=xhci and dbgp=ehci") Reviewed-by: Jan Beulich I'm sorry for having missed this during review - we

Re: Design session "MSI-X support with Linux stubdomain" notes

2022-09-26 Thread Marek Marczykowski-Górecki
On Thu, Sep 22, 2022 at 08:00:00PM +0200, Jan Beulich wrote: > On 22.09.2022 18:05, Anthony PERARD wrote: > > WARNING: Notes missing at the beginning of the meeting. > > > > session description: > >> Currently a HVM with PCI passthrough and Qemu Linux stubdomain doesn’t > >> support MSI-X. For the

Re: Design session "MSI-X support with Linux stubdomain" notes

2022-09-26 Thread Jan Beulich
On 26.09.2022 14:43, Marek Marczykowski-Górecki wrote: > On Thu, Sep 22, 2022 at 08:00:00PM +0200, Jan Beulich wrote: >> On 22.09.2022 18:05, Anthony PERARD wrote: >>> WARNING: Notes missing at the beginning of the meeting. >>> >>> session description: Currently a HVM with PCI passthrough and

[PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test

2022-09-26 Thread Andrew Cooper
buster-gcc-ibt is a dedicated test to run a not-yet-upstreamed compiler patch which is relevant to CONFIG_XEN_IBT in 4.17 and later. Force it on, rather than having 50% of the jobs not testing what they're supposed to be testing. Fixes: 5d59421815d5 ("x86: Use control flow typechecking where poss

RE: [PATCH v2] MAINTAINERS: ARINC 653 scheduler maintainer updates

2022-09-26 Thread Nathan Studer
> On 19.09.2022 04:10, Stewart Hildebrand wrote: > > From: Stewart Hildebrand > > > > Add Nathan Studer as co-maintainer. > > > > I am departing DornerWorks. I will still be working with Xen in my next > > role, and I still have an interest in co-maintaining the ARINC 653 > > scheduler, so change

Re: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test

2022-09-26 Thread Marek Marczykowski-Górecki
On Mon, Sep 26, 2022 at 02:02:13PM +0100, Andrew Cooper wrote: > buster-gcc-ibt is a dedicated test to run a not-yet-upstreamed compiler patch > which is relevant to CONFIG_XEN_IBT in 4.17 and later. > > Force it on, rather than having 50% of the jobs not testing what they're > supposed to be test

[xen-unstable-smoke test] 173315: tolerable all pass - PUSHED

2022-09-26 Thread osstest service owner
flight 173315 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173315/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test

2022-09-26 Thread Andrew Cooper
On 26/09/2022 14:19, Marek Marczykowski-Górecki wrote: > On Mon, Sep 26, 2022 at 02:02:13PM +0100, Andrew Cooper wrote: >> buster-gcc-ibt is a dedicated test to run a not-yet-upstreamed compiler patch >> which is relevant to CONFIG_XEN_IBT in 4.17 and later. >> >> Force it on, rather than having 50

Re: [PATCH 4/9] automation: Add Arm containers to containerize script

2022-09-26 Thread Anthony PERARD
On Fri, Sep 23, 2022 at 03:23:26PM -0700, Stefano Stabellini wrote: > On Fri, 23 Sep 2022, Michal Orzel wrote: > > Hi Anthony, > > > > On 23/09/2022 15:56, Anthony PERARD wrote: > > > > > > > > > On Thu, Sep 22, 2022 at 03:40:53PM +0200, Michal Orzel wrote: > > >> Script automation/scripts/conta

[XEN PATCH] automation: Information about running containers for a different arch

2022-09-26 Thread Anthony PERARD
Adding pointer to 'qemu-user-static'. Signed-off-by: Anthony PERARD --- automation/build/README.md | 11 +++ 1 file changed, 11 insertions(+) diff --git a/automation/build/README.md b/automation/build/README.md index 00305eed03..5d4734bc77 100644 --- a/automation/build/README.md +++ b/a

Re: [XEN PATCH] automation: Information about running containers for a different arch

2022-09-26 Thread Michal Orzel
Hi Anthony, On 26/09/2022 15:58, Anthony PERARD wrote: > > > Adding pointer to 'qemu-user-static'. > > Signed-off-by: Anthony PERARD > --- > automation/build/README.md | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/automation/build/README.md b/automation/build/README.m

Re: [PATCH v2] x86/vpmu: Fix race-condition in vpmu_load

2022-09-26 Thread Jan Beulich
On 22.09.2022 22:48, Tamas K Lengyel wrote: > --- a/xen/arch/x86/cpu/vpmu.c > +++ b/xen/arch/x86/cpu/vpmu.c > @@ -376,57 +376,24 @@ void vpmu_save(struct vcpu *v) > vpmu->last_pcpu = pcpu; > per_cpu(last_vcpu, pcpu) = v; > > +vpmu_set(vpmu, VPMU_CONTEXT_SAVE); > + > if ( altern

[PATCH 0/3] xen/pv: sanitize xen pv guest msr accesses

2022-09-26 Thread Juergen Gross
Historically when running as Xen PV guest all MSR accesses have been silently swallowing any GP faults, even when the kernel was using not the *msr_safe() access functions. Change that by making the behavior controllable via kernel config and via a boot parameter. This will help finding paths whe

[PATCH 1/3] xen/pv: allow pmu msr accesses to cause GP

2022-09-26 Thread Juergen Gross
Today pmu_msr_read() and pmu_msr_write() fall back to the safe variants of read/write MSR in case the MSR access isn't emulated via Xen. Allow the caller to select the potentially faulting variant by passing NULL for the error pointer. Remove one level of indentation by restructuring the code a li

[PATCH 2/3] xen/pv: refactor msr access functions to support safe and unsafe accesses

2022-09-26 Thread Juergen Gross
Refactor and rename xen_read_msr_safe() and xen_write_msr_safe() to support both cases of MSR accesses, safe ones and potentially GP-fault generating ones. This will prepare to no longer swallow GPs silently in xen_read_msr() and xen_write_msr(). Signed-off-by: Juergen Gross --- arch/x86/xen/en

[PATCH 3/3] xen/pv: support selecting safe/unsafe msr accesses

2022-09-26 Thread Juergen Gross
Instead of always doing the safe variants for reading and writing MSRs in Xen PV guests, make the behavior controllable via Kconfig option and a boot parameter. The default will be the current behavior, which is to always use the safe variant. Signed-off-by: Juergen Gross --- .../admin-guide/ke

Re: [PATCH v2] x86/vpmu: Fix race-condition in vpmu_load

2022-09-26 Thread Tamas K Lengyel
On Mon, Sep 26, 2022 at 10:12 AM Jan Beulich wrote: > On 22.09.2022 22:48, Tamas K Lengyel wrote: > > --- a/xen/arch/x86/cpu/vpmu.c > > +++ b/xen/arch/x86/cpu/vpmu.c > > @@ -376,57 +376,24 @@ void vpmu_save(struct vcpu *v) > > vpmu->last_pcpu = pcpu; > > per_cpu(last_vcpu, pcpu) = v; >

Re: [PATCH] x86/ept: simplify detection of special pages for EMT calculation

2022-09-26 Thread Roger Pau Monné
On Mon, Sep 26, 2022 at 10:38:40AM +0200, Jan Beulich wrote: > On 23.09.2022 12:56, Roger Pau Monne wrote: > > The current way to detect whether a page handled to > > epte_get_entry_emt() is special and needs a forced write-back cache > > attribute involves iterating over all the smaller 4K pages f

Re: [PATCH v2 01/10] automation: Use custom build jobs when extra config options are needed

2022-09-26 Thread Ayan Kumar Halder
On 26/09/2022 12:04, Michal Orzel wrote: Currently, all the arm64 defconfig build jobs, regardless of the container used, end up building Xen with the extra config options specified in the main build script (e.g. CONFIG_EXPERT, CONFIG_STATIC_MEMORY). Because these options are only needed for sp

Re: [PATCH v2 06/10] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder

2022-09-26 Thread Stewart Hildebrand
On 9/26/22 07:04, Michal Orzel wrote: Take an example from arm64 qemu test scripts and use ImageBuilder to generate u-boot script automatically. Calculating the addresses manually is quite error prone and also we will be able to benefit from using ImageBuilder when adding domUs to this test in th

Re: [PATCH] x86/ept: limit calls to memory_type_changed()

2022-09-26 Thread Roger Pau Monné
On Mon, Sep 26, 2022 at 09:33:10AM +0200, Jan Beulich wrote: > On 23.09.2022 10:35, Roger Pau Monné wrote: > > On Thu, Sep 22, 2022 at 09:21:59PM +0200, Jan Beulich wrote: > >> On 22.09.2022 18:05, Roger Pau Monne wrote: > >>> memory_type_changed() is currently only implemented for Intel EPT, and >

Re: [PATCH v2 06/10] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder

2022-09-26 Thread Michal Orzel
Hi Stewart, On 26/09/2022 16:46, Stewart Hildebrand wrote: > > > On 9/26/22 07:04, Michal Orzel wrote: >> Take an example from arm64 qemu test scripts and use ImageBuilder >> to generate u-boot script automatically. Calculating the addresses >> manually is quite error prone and also we will be a

Re: [PATCH] drivers/char: Fix build when CET-IBT is enabled

2022-09-26 Thread Andrew Cooper
On 26/09/2022 13:22, Jan Beulich wrote: > On 26.09.2022 13:05, Andrew Cooper wrote: >> https://gitlab.com/xen-project/xen/-/jobs/3083068950#L1763 >> >> Signed-off-by: Andrew Cooper >> Fixes: 022e40edd4dc ("drivers/char: allow using both dbgp=xhci and >> dbgp=ehci") > Reviewed-by: Jan Beulich Th

Re: [PATCH] drivers/char: Fix build when CET-IBT is enabled

2022-09-26 Thread Andrew Cooper
On 26/09/2022 13:09, Luca Fancellu wrote: > >> On 26 Sep 2022, at 12:05, Andrew Cooper wrote: >> >> https://gitlab.com/xen-project/xen/-/jobs/3083068950#L1763 > Is this link permanent? Otherwise I think we should put just the reason of > failure > as commit message. The link is stable, yes. ~An

Re: [PATCH v2 08/10] automation: Rename qemu-smoke-arm64.sh to qemu-smoke-dom0less-arm64.sh

2022-09-26 Thread Andrew Cooper
On 26/09/2022 12:04, Michal Orzel wrote: > Testing arm64 is done using the qemu-alpine-arm64.sh and > qemu-smoke-arm64.sh scripts. These scripts are executed with exactly > the same artifacts (container, rootfs, kernel, qemu) and the only > difference is that the former is used to perform dom0 base

Re: [PATCH 3/3] xen/pv: support selecting safe/unsafe msr accesses

2022-09-26 Thread Jan Beulich
On 26.09.2022 16:18, Juergen Gross wrote: > --- a/arch/x86/xen/Kconfig > +++ b/arch/x86/xen/Kconfig > @@ -92,3 +92,12 @@ config XEN_DOM0 > select X86_X2APIC if XEN_PVH && X86_64 > help > Support running as a Xen Dom0 guest. > + > +config XEN_PV_MSR_SAFE > + bool "Always use

Re: [PATCH] x86/ept: limit calls to memory_type_changed()

2022-09-26 Thread Roger Pau Monné
On Mon, Sep 26, 2022 at 04:50:22PM +0200, Roger Pau Monné wrote: > On Mon, Sep 26, 2022 at 09:33:10AM +0200, Jan Beulich wrote: > > On 23.09.2022 10:35, Roger Pau Monné wrote: > > > On Thu, Sep 22, 2022 at 09:21:59PM +0200, Jan Beulich wrote: > > >> On 22.09.2022 18:05, Roger Pau Monne wrote: > > >

Re: [PATCH 1/3] xen/pv: allow pmu msr accesses to cause GP

2022-09-26 Thread Jan Beulich
On 26.09.2022 16:18, Juergen Gross wrote: > Today pmu_msr_read() and pmu_msr_write() fall back to the safe variants > of read/write MSR in case the MSR access isn't emulated via Xen. Allow > the caller to select the potentially faulting variant by passing NULL > for the error pointer. Maybe make t

Re: [PATCH 1/3] xen/pv: allow pmu msr accesses to cause GP

2022-09-26 Thread Juergen Gross
On 26.09.22 17:29, Jan Beulich wrote: On 26.09.2022 16:18, Juergen Gross wrote: Today pmu_msr_read() and pmu_msr_write() fall back to the safe variants of read/write MSR in case the MSR access isn't emulated via Xen. Allow the caller to select the potentially faulting variant by passing NULL for

Re: [PATCH 3/3] xen/pv: support selecting safe/unsafe msr accesses

2022-09-26 Thread Juergen Gross
On 26.09.22 17:23, Jan Beulich wrote: On 26.09.2022 16:18, Juergen Gross wrote: --- a/arch/x86/xen/Kconfig +++ b/arch/x86/xen/Kconfig @@ -92,3 +92,12 @@ config XEN_DOM0 select X86_X2APIC if XEN_PVH && X86_64 help Support running as a Xen Dom0 guest. + +config XEN_PV_MSR

Re: [PATCH] x86/ept: limit calls to memory_type_changed()

2022-09-26 Thread Jan Beulich
On 26.09.2022 17:25, Roger Pau Monné wrote: > On Mon, Sep 26, 2022 at 04:50:22PM +0200, Roger Pau Monné wrote: >> On Mon, Sep 26, 2022 at 09:33:10AM +0200, Jan Beulich wrote: >>> On 23.09.2022 10:35, Roger Pau Monné wrote: On Thu, Sep 22, 2022 at 09:21:59PM +0200, Jan Beulich wrote: > On 2

Re: [PATCH] x86/ept: simplify detection of special pages for EMT calculation

2022-09-26 Thread Jan Beulich
On 26.09.2022 16:27, Roger Pau Monné wrote: > On Mon, Sep 26, 2022 at 10:38:40AM +0200, Jan Beulich wrote: >> On 23.09.2022 12:56, Roger Pau Monne wrote: >>> The current way to detect whether a page handled to >>> epte_get_entry_emt() is special and needs a forced write-back cache >>> attribute inv

Re: Design session PVH dom0

2022-09-26 Thread Jan Beulich
On 26.09.2022 10:33, Juergen Gross wrote: > On 26.09.22 09:53, Jan Beulich wrote: >> On 23.09.2022 10:20, Juergen Gross wrote: >>> My favorite solution would be some kind of buffer address qualifier for each >>> buffer (e.g. virtual, physical, SG-list, maybe nested SG-list). So the new >>> hypercal

Re: [PATCH] x86/ept: limit calls to memory_type_changed()

2022-09-26 Thread Roger Pau Monné
On Mon, Sep 26, 2022 at 05:36:41PM +0200, Jan Beulich wrote: > On 26.09.2022 17:25, Roger Pau Monné wrote: > > On Mon, Sep 26, 2022 at 04:50:22PM +0200, Roger Pau Monné wrote: > >> On Mon, Sep 26, 2022 at 09:33:10AM +0200, Jan Beulich wrote: > >>> On 23.09.2022 10:35, Roger Pau Monné wrote: >

Re: [PATCH] x86/ept: limit calls to memory_type_changed()

2022-09-26 Thread Andrew Cooper
On 22/09/2022 17:05, Roger Pau Monne wrote: > memory_type_changed() is currently only implemented for Intel EPT, and > results in the invalidation of EMT attributes on all the entries in > the EPT page tables. Such invalidation causes EPT_MISCONFIG vmexits > when the guest tries to access any gfns

Re: [PATCH v3 07/10] x86/mtrr: simplify mtrr_bp_init()

2022-09-26 Thread Borislav Petkov
On Thu, Sep 08, 2022 at 10:49:11AM +0200, Juergen Gross wrote: > diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c > index 9609a0d235f8..956838bb4481 100644 > --- a/arch/x86/kernel/cpu/mtrr/mtrr.c > +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c > @@ -761,13 +761,10 @@ void __in

[xen-unstable test] 173316: tolerable FAIL - PUSHED

2022-09-26 Thread osstest service owner
flight 173316 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173316/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail like 173273 test-armhf-armhf-xl-rtds 18 gues

Re: [PATCH 1/3] xen/pv: allow pmu msr accesses to cause GP

2022-09-26 Thread Boris Ostrovsky
On 9/26/22 10:18 AM, Juergen Gross wrote: bool pmu_msr_read(unsigned int msr, uint64_t *val, int *err) { if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) { - if (is_amd_pmu_msr(msr)) { - if (!xen_amd_pmu_emulate(msr, val, 1)) -

Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init

2022-09-26 Thread Borislav Petkov
On Thu, Sep 08, 2022 at 10:49:12AM +0200, Juergen Gross wrote: > -void set_mtrr_aps_delayed_init(void) > -{ > - if (!cache_generic) > - return; > - > - mtrr_aps_delayed_init = true; > -} > - Except that you've removed the accessors and made that bool global. Which is less prett

Re: [PATCH v2 03/10] automation: qemu-smoke-arm64.sh: Increase RAM size

2022-09-26 Thread Stefano Stabellini
On Mon, 26 Sep 2022, Michal Orzel wrote: > In the follow-up patch we will add new jobs using debug Xen builds. > Because the debug builds take more space and we might end up in > a situation when there is not enough free space (especially during > a static memory test that reserves some region in t

Re: [PATCH v2 02/10] automation: Add randconfig build jobs for arm64 alpine container

2022-09-26 Thread Stefano Stabellini
On Mon, 26 Sep 2022, Michal Orzel wrote: > For arm64 we perform builds using debian and alpine containers. > We are missing the randconfig build jobs for the latter, so add them. > This way for each container we have 4 fundamental build jobs: > - defconfig non-debug/debug > - randconfig non-debug/d

Re: [PATCH v2 04/10] automation: Add debug versions of Arm tests

2022-09-26 Thread Stefano Stabellini
On Mon, 26 Sep 2022, Michal Orzel wrote: > At the moment, all the tests are executed on non-debug Xen builds. > To improve the coverage (e.g. we might catch some asserts), add new > test jobs using debug Xen builds. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > Chan

Re: [PATCH v2 06/10] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder

2022-09-26 Thread Stefano Stabellini
On Mon, 26 Sep 2022, Michal Orzel wrote: > Hi Stewart, > > On 26/09/2022 16:46, Stewart Hildebrand wrote: > > > > > > On 9/26/22 07:04, Michal Orzel wrote: > >> Take an example from arm64 qemu test scripts and use ImageBuilder > >> to generate u-boot script automatically. Calculating the address

Re: [PATCH v2 01/10] automation: Use custom build jobs when extra config options are needed

2022-09-26 Thread Stefano Stabellini
On Mon, 26 Sep 2022, Michal Orzel wrote: > Currently, all the arm64 defconfig build jobs, regardless of the > container used, end up building Xen with the extra config options > specified in the main build script (e.g. CONFIG_EXPERT, > CONFIG_STATIC_MEMORY). Because these options are only needed fo

[ovmf test] 173318: all pass - PUSHED

2022-09-26 Thread osstest service owner
flight 173318 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173318/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 96f3efbd991db83c608909c1c861a77fe26982f1 baseline version: ovmf d97ee3244d806d324a22e

Re: [PATCH v7 08/11] IOMMU/VT-d: wire common device reserved memory API

2022-09-26 Thread Marczykowski, Marek
On Fri, Sep 23, 2022 at 07:21:04AM +, Tian, Kevin wrote: > > From: Marek Marczykowski-Górecki > > Sent: Saturday, September 17, 2022 10:51 AM > > > > Re-use rmrr= parameter handling code to handle common device reserved > > memory. > > > > Signed-off-by: Marek Marczykowski-Górecki > > > > --

RE: [PATCH] drivers/char: Fix build when CET-IBT is enabled

2022-09-26 Thread Henry Wang
Hi Jan and Andrew, > -Original Message- > From: Andrew Cooper > Subject: Re: [PATCH] drivers/char: Fix build when CET-IBT is enabled > > On 26/09/2022 13:22, Jan Beulich wrote: > > On 26.09.2022 13:05, Andrew Cooper wrote: > >> https://gitlab.com/xen-project/xen/-/jobs/3083068950#L1763 >

RE: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test

2022-09-26 Thread Henry Wang
Hi Andrew, > -Original Message- > From: Andrew Cooper > Subject: [PATCH for-4.17] CI: Force CONFIG_XEN_IBT in the buster-gcc-ibt test > > buster-gcc-ibt is a dedicated test to run a not-yet-upstreamed compiler patch > which is relevant to CONFIG_XEN_IBT in 4.17 and later. > > Force it o

[xen-unstable-smoke test] 173320: tolerable all pass - PUSHED

2022-09-26 Thread osstest service owner
flight 173320 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173320/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[qemu-mainline test] 173317: tolerable FAIL - PUSHED

2022-09-26 Thread osstest service owner
flight 173317 qemu-mainline real [real] flight 173321 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173317/ http://logs.test-lab.xenproject.org/osstest/logs/173321/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-ar

[PATCH 3/5] libxl: Properly suspend stubdomains

2022-09-26 Thread Demi Marie Obenour
Currently, libxl neither pauses nor suspends a stubdomain when suspending the domain it serves. Qubes OS has an out-of-tree patch that just pauses the stubdomain, but that is also insufficient: sys-net (an HVM with an attached PCI device) does not properly resume from suspend on some systems, and

[PATCH 4/5] libxl: Fix race condition in domain suspension

2022-09-26 Thread Demi Marie Obenour
Check if the domain has suspended after setting the XenStore watch to prevent race conditions. Also check if a guest has suspended when the timeout handler is called, and do not consider this to be a timeout. Signed-off-by: Demi Marie Obenour --- tools/libs/light/libxl_dom_suspend.c | 15 ++

[PATCH 0/5] Suspend and resume stubdomains

2022-09-26 Thread Demi Marie Obenour
Currently, libxl neither pauses nor suspends a stubdomain when suspending the domain it serves. Qubes OS has an out-of-tree patch that just pauses the stubdomain, but that is also insufficient: sys-net (an HVM with an attached PCI device) does not properly resume from suspend on some systems, and

[PATCH 1/5] libxl: Add a utility function for domain resume

2022-09-26 Thread Demi Marie Obenour
It is necessary to all xs_resume_domain after any successful call to xc_domain_resume, so that XenStore is notified of the resumption. However, it is also very easy to forget to call this. This took me several days to debug. Fix this by adding a utility function to resume a domain and then notify

[PATCH 2/5] libxl: Add utility function to check guest status

2022-09-26 Thread Demi Marie Obenour
This is used to check that a guest has not been destroyed and to obtain information about it. It will be used in subsequent patches. Signed-off-by: Demi Marie Obenour --- tools/libs/light/libxl_dom_suspend.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-)

[PATCH 5/5] libxl: Add additional domain suspend/resume logs

2022-09-26 Thread Demi Marie Obenour
This was useful when debugging, but is not required. Signed-off-by: Demi Marie Obenour --- tools/libs/light/libxl_dom_suspend.c | 20 ++-- tools/libs/light/libxl_domain.c | 1 + 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/tools/libs/light/libxl_dom_suspe

[ovmf test] 173323: all pass - PUSHED

2022-09-26 Thread osstest service owner
flight 173323 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173323/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b3dd9cb836e2aed68198aa79a1ca6afdb25adf80 baseline version: ovmf 96f3efbd991db83c60890

Re: [PATCH 1/3] xen/pv: allow pmu msr accesses to cause GP

2022-09-26 Thread Juergen Gross
On 26.09.22 22:09, Boris Ostrovsky wrote: On 9/26/22 10:18 AM, Juergen Gross wrote:   bool pmu_msr_read(unsigned int msr, uint64_t *val, int *err)   {   if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) { -    if (is_amd_pmu_msr(msr)) { -    if (!xen_amd_pmu_emulate(msr, val, 1)

[linux-linus test] 173319: tolerable FAIL - PUSHED

2022-09-26 Thread osstest service owner
flight 173319 linux-linus real [real] flight 173324 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/173319/ http://logs.test-lab.xenproject.org/osstest/logs/173324/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-

Re: [PATCH] x86/ept: limit calls to memory_type_changed()

2022-09-26 Thread Jan Beulich
On 26.09.2022 17:58, Roger Pau Monné wrote: > On Mon, Sep 26, 2022 at 05:36:41PM +0200, Jan Beulich wrote: >> On 26.09.2022 17:25, Roger Pau Monné wrote: >>> Correction: the Arm memory_type_changed() needs to stay, as >>> iomem_{permit,deny}_access() is common code. >> >> Right, or we'd need some o