Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-08 Thread Kent Overstreet
On Wed, Sep 07, 2022 at 11:49:37PM -0700, Suren Baghdasaryan wrote: > I would really appreciate if everyone could please stick to the > technical side of the conversation. That way we can get some > constructive feedback. Everything else is not helpful and at best is a > distraction. > Maintenance

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-08 Thread Michal Hocko
On Thu 08-09-22 02:35:48, Kent Overstreet wrote: > On Wed, Sep 07, 2022 at 09:45:18AM -0400, Steven Rostedt wrote: > > On Wed, 7 Sep 2022 09:04:28 -0400 > > Kent Overstreet wrote: > > > > > On Wed, Sep 07, 2022 at 01:00:09PM +0200, Michal Hocko wrote: > > > > Hmm, it seems that further discussion

Re: Unaligned access on arm32

2022-09-08 Thread Jan Beulich
On 07.09.2022 19:21, Andrew Cooper wrote: > On 07/09/2022 16:30, Julien Grall wrote: >> Hi all, >> >> I think mentioned it privately a while a go, but never sent an e-mail >> about it. >> >> While testing arm32 with IOREQ, I noticed Xen is crashing because an >> alignment fault: >> >> (XEN) Data Ab

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-08 Thread Kent Overstreet
On Thu, Sep 08, 2022 at 09:12:45AM +0200, Michal Hocko wrote: > Then you have probably missed a huge part of my emails. Please > re-read. If those arguments are not clear, feel free to ask for > clarification. Reducing the whole my reasoning and objections to the > sentence above and calling that v

[qemu-mainline test] 173051: regressions - FAIL

2022-09-08 Thread osstest service owner
flight 173051 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173051/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 172123 build-i386-libvir

[PATCH] xen/locks: add dynamic lock recursion checks

2022-09-08 Thread Juergen Gross
Add checking of lock recursion to the hypervisor. This is done by using a percpu data array for storing the address of each taken lock. Any attempt to take a lock twice (with the exception of recursive spinlocks) will result in a crash. This is especially meant for detecting attempts to take a rwlo

[ovmf test] 173057: regressions - FAIL

2022-09-08 Thread osstest service owner
flight 173057 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173057/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-08 Thread Michal Hocko
On Thu 08-09-22 03:29:50, Kent Overstreet wrote: > On Thu, Sep 08, 2022 at 09:12:45AM +0200, Michal Hocko wrote: > > Then you have probably missed a huge part of my emails. Please > > re-read. If those arguments are not clear, feel free to ask for > > clarification. Reducing the whole my reasoning

Re: [PATCH v5 2/4] docs, xen/arm: Introduce static heap memory

2022-09-08 Thread Michal Orzel
Hi Henry, On 08/09/2022 06:25, Henry Wang wrote: > > This commit introduces the static heap memory, which is parts of RAM > reserved in the beginning of the boot time for heap. > > Firstly, since a new type of memory bank is needed for marking the > memory bank solely as the heap, this commit de

[PATCH v5] tools/xenstore: add migration stream extensions for new features

2022-09-08 Thread Juergen Gross
Extend the definition of the Xenstore migration stream to cover new features: - per domain features - extended watches (watch depth) - per domain quota Some of those additions (per domain features and extended watches) require bumping the migration stream version to "2", as usage of those feature

Re: [PATCH v4 1/6] xen/x86: Provide helpers for common code to access acpi_numa

2022-09-08 Thread Jan Beulich
On 02.09.2022 05:31, Wei Chen wrote: > acpi_numa is a specific NUMA switch for ACPI NUMA implementation. > Other NUMA implementation may not need this switch. But this switch is > not only used by ACPI code, it is also used directly in some general > NUMA logic code. So far this hasn't caused any p

[PATCH v3 00/10] x86: make pat and mtrr independent from each other

2022-09-08 Thread Juergen Gross
Today PAT can't be used without MTRR being available, unless MTRR is at least configured via CONFIG_MTRR and the system is running as Xen PV guest. In this case PAT is automatically available via the hypervisor, but the PAT MSR can't be modified by the kernel and MTRR is disabled. The same applies

[PATCH v3 02/10] x86/mtrr: remove unused cyrix_set_all() function

2022-09-08 Thread Juergen Gross
The Cyrix CPU specific MTRR function cyrix_set_all() will never be called, as the struct mtrr_ops set_all() callback will only be called in the use_intel() case, which would require the use_intel_if member of struct mtrr_ops to be set, which isn't the case for Cyrix. Signed-off-by: Juergen Gross

[PATCH v3 04/10] x86: move some code out of arch/x86/kernel/cpu/mtrr

2022-09-08 Thread Juergen Gross
Prepare making PAT and MTRR support independent from each other by moving some code needed by both out of the MTRR specific sources. Signed-off-by: Juergen Gross --- V2: - move code from cpu/common.c to cpu/cacheinfo.c (Boris Petkov) --- arch/x86/include/asm/cacheinfo.h | 3 ++ arch/x86/inclu

[PATCH v3 06/10] x86/mtrr: remove set_all callback from struct mtrr_ops

2022-09-08 Thread Juergen Gross
Instead of using an indirect call to mtrr_if->set_all just call the only possible target cache_cpu_init() directly. This enables to remove the set_all callback from struct mtrr_ops. Signed-off-by: Juergen Gross --- arch/x86/kernel/cpu/mtrr/generic.c | 1 - arch/x86/kernel/cpu/mtrr/mtrr.c| 1

[PATCH v3 05/10] x86/mtrr: split generic_set_all()

2022-09-08 Thread Juergen Gross
Split generic_set_all() into multiple parts, while moving the main function body into cacheinfo.c. This prepares the support of PAT without needing MTRR support by moving the main function body of generic_set_all() into cacheinfo.c while renaming it to cache_cpu_init(). The MTRR specific parts are

[PATCH v3 01/10] x86/mtrr: add comment for set_mtrr_state() serialization

2022-09-08 Thread Juergen Gross
Add a comment how set_mtrr_state() is needing serialization. Suggested-by: Borislav Petkov Signed-off-by: Juergen Gross --- V3: - new patch instead of old patch 1 --- arch/x86/kernel/cpu/mtrr/generic.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/m

[PATCH v3 03/10] x86/mtrr: replace use_intel() with a local flag

2022-09-08 Thread Juergen Gross
In MTRR code use_intel() is only used in one source file, and the relevant use_intel_if member of struct mtrr_ops is set only in generic_mtrr_ops. Replace use_intel() with a single flag in cacheinfo.c, which can be set when assigning generic_mtrr_ops to mtrr_if. This allows to drop use_intel_if fr

[PATCH v3 07/10] x86/mtrr: simplify mtrr_bp_init()

2022-09-08 Thread Juergen Gross
In case of the generic cache interface being used (Intel CPUs or a 64-bit system), the initialization sequence of the boot CPU is more complicated as necessary: - check if MTRR enabled, if yes, call mtrr_bp_pat_init() which will disable caching, set the PAT MSR, and reenable caching - call mtrr

[PATCH V6 0/3] libxl: arm: Make generic code independent of disk device

2022-09-08 Thread Viresh Kumar
Hello, This was earlier sent as part of a patch series [1] adding support for GPIO/I2C virtio devices. The device specific patches would require some rework and possibly several versions, and so this series separates out the generic independent patches into a series of their own. This series make

[PATCH V6 1/3] libxl: arm: Create alloc_virtio_mmio_params()

2022-09-08 Thread Viresh Kumar
In order to prepare for adding support for more device types, create a separate routine to allocate base and irq for a device as the same code will be required for other device types too. Also move updates to virtio_irq and virtio_enabled out of the disk device specific block, as they will depend

[PATCH V6 2/3] libxl: arm: Split make_virtio_mmio_node()

2022-09-08 Thread Viresh Kumar
make_virtio_mmio_node() creates the DT node for simple MMIO devices currently, i.e. the ones that don't require any additional properties. In order to allow using it for other complex device types, split the functionality into two, one where the fdt node isn't closed and the other one to create a

[PATCH V6 3/3] libxl: arm: make creation of iommu node independent of disk device

2022-09-08 Thread Viresh Kumar
The iommu node will be required for other virtio device types too, not just disk device. Move the call to make_xen_iommu_node(), out of the disk device specific block and rename "iommu_created" variable to "iommu_needed", and set it to true for virtio disk device. Signed-off-by: Viresh Kumar ---

[PATCH v3 09/10] x86/mtrr: add a stop_machine() handler calling only cache_cpu_init()

2022-09-08 Thread Juergen Gross
Instead of having a stop_machine() handler for either a specific MTRR register or all state at once, add a handler just for calling cache_cpu_init() if appropriate. Add functions for calling stop_machine() with this handler as well. Add a generic replacements for mtrr_bp_restore() and a wrapper f

[PATCH v3 10/10] x86: decouple pat and mtrr handling

2022-09-08 Thread Juergen Gross
Today PAT is usable only with MTRR being active, with some nasty tweaks to make PAT usable when running as Xen PV guest, which doesn't support MTRR. The reason for this coupling is, that both, PAT MSR changes and MTRR changes, require a similar sequence and so full PAT support was added using the

[PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init

2022-09-08 Thread Juergen Gross
In order to prepare decoupling MTRR and PAT replace the MTRR specific mtrr_aps_delayed_init flag with a more generic cache_aps_delayed_init one. Signed-off-by: Juergen Gross --- V2: - new patch --- arch/x86/include/asm/cacheinfo.h | 2 ++ arch/x86/include/asm/mtrr.h | 2 -- arch/x86/kerne

Re: [for-4.17 1/3] automation: qemu-alpine-arm64-gcc: Use kernel 5.19

2022-09-08 Thread Ayan Kumar Halder
Hi Michal, On 02/09/2022 08:09, Michal Orzel wrote: After qemu-smoke-arm64 was changed to use kernel 5.19 we end up having two kernel configurations. This is something not needed and maintaining a single kernel version is always easier. Modify qemu-alpine-arm64-gcc to use kernel 5.19 and remove

RE: [PATCH v5 2/4] docs, xen/arm: Introduce static heap memory

2022-09-08 Thread Henry Wang
Hi Michal, > -Original Message- > From: Michal Orzel > > +- #address-cells and #size-cells > > + > > +Specify the number of cells used for the address and size of the > > +"xen,static-heap" property. Note that according to the device tree > > +specification, the number of addr

Re: [PATCH v4 2/6] xen/x86: move generically usable NUMA code from x86 to common

2022-09-08 Thread Jan Beulich
On 02.09.2022 05:31, Wei Chen wrote: > --- /dev/null > +++ b/xen/common/numa.c > @@ -0,0 +1,442 @@ > +/* > + * Generic VM initialization for NUMA setups. > + * Copyright 2002,2003 Andi Kleen, SuSE Labs. > + * Adapted for Xen: Ryan Harper > + */ > + > +#include > +#include > +#include > +#includ

Re: [for-4.17 2/3] automation: qemu-smoke-arm64: Silence ifconfig error messages

2022-09-08 Thread Ayan Kumar Halder
On 02/09/2022 08:09, Michal Orzel wrote: During the ping test, dom1 tries to assign an ip to eth0 in a loop. Before setting up the network interface by dom0, this results in printing the following error message several times: (XEN) DOM1: ifconfig: SIOCSIFADDR: No such device Silence this by re

Re: [for-4.17 1/3] automation: qemu-alpine-arm64-gcc: Use kernel 5.19

2022-09-08 Thread Michal Orzel
Hi Ayan, On 08/09/2022 11:07, Ayan Kumar Halder wrote: > Hi Michal, > > On 02/09/2022 08:09, Michal Orzel wrote: >> After qemu-smoke-arm64 was changed to use kernel 5.19 we end up having >> two kernel configurations. This is something not needed and maintaining >> a single kernel version is alway

[for-4.17 v2 0/3] GitLab CI cleanup and boot time cpupools test

2022-09-08 Thread Michal Orzel
This patch series performs a small cleanup before the release and adds a test for validating boot time cpupools feature introduced in 4.17. Notes for the release manager: Benefits: - improved dom0less test coverage - tested feature that is introduced in 4.17 Risks: - CI pipeline failure Michal

[for-4.17 v2 1/3] automation: qemu-alpine-arm64-gcc: Use kernel 5.19

2022-09-08 Thread Michal Orzel
After qemu-smoke-arm64 was changed to use kernel 5.19 we end up having two kernel configurations. This is something not needed and maintaining a single kernel version is always easier. Modify qemu-alpine-arm64-gcc to use kernel 5.19 and remove kernel 5.9 from tests-artifacts. Signed-off-by: Michal

[for-4.17 v2 3/3] automation: Add a new job for testing boot time cpupools on arm64

2022-09-08 Thread Michal Orzel
Add a new test job qemu-smoke-arm64-gcc-boot-cpupools that will execute script qemu-smoke-arm64.sh to test boot time cpupools feature. Enable CONFIG_BOOT_TIME_CPUPOOLS for the arm64 build and add a new test case in qemu-smoke-arm64.sh that if selected will make use of the ImageBuilder feature to cr

[for-4.17 v2 2/3] automation: qemu-smoke-arm64: Silence ifconfig error messages

2022-09-08 Thread Michal Orzel
During the ping test, dom1 tries to assign an ip to eth0 in a loop. Before setting up the network interface by dom0, this results in printing the following error message several times: (XEN) DOM1: ifconfig: SIOCSIFADDR: No such device Silence this by redirecting stderr/stdout to /dev/null as we do

Re: [PATCH v2 2/2] live migration: use superpages for physmap population on restore when possible

2022-09-08 Thread Julien Grall
Hi Olaf, On 07/09/2022 08:45, Olaf Hering wrote: Wed, 7 Sep 2022 09:40:41 +0200 Jan Beulich : Olaf - I recall you've done some similar work before. Do you have any thoughts here, perhaps going as far as merging your and Andrei's work? > My variant is in the archives, for reference. You are

[PATCH] xen/arm, device-tree: Make static-mem use #{address,size}-cells

2022-09-08 Thread Henry Wang
In order to keep consistency in the device tree binding, there is no need for static memory allocation feature to define a specific set of address and size cells for "xen,static-mem" property. Therefore, this commit reuses the regular #{address,size}-cells for parsing the device tree "xen,static-m

[xen-unstable test] 173054: tolerable FAIL

2022-09-08 Thread osstest service owner
flight 173054 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173054/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-migrupgrade 11 xen-install/dst_host fail pass in 173044 Tests which did not succeed, but

Re: [PATCH v5] tools/xenstore: add migration stream extensions for new features

2022-09-08 Thread Julien Grall
Hi Juergen, On 08/09/2022 09:15, Juergen Gross wrote: Extend the definition of the Xenstore migration stream to cover new features: - per domain features - extended watches (watch depth) - per domain quota Some of those additions (per domain features and extended watches) require bumping the m

Re: [PATCH v5 2/4] docs, xen/arm: Introduce static heap memory

2022-09-08 Thread Julien Grall
Hi Henry, On 08/09/2022 05:25, Henry Wang wrote: This commit introduces the static heap memory, which is parts of RAM reserved in the beginning of the boot time for heap. Firstly, since a new type of memory bank is needed for marking the memory bank solely as the heap, this commit defines `enum

Re: [PATCH v4 2/6] xen/x86: move generically usable NUMA code from x86 to common

2022-09-08 Thread Wei Chen
Hi Jan, On 2022/9/8 17:09, Jan Beulich wrote: On 02.09.2022 05:31, Wei Chen wrote: --- /dev/null +++ b/xen/common/numa.c @@ -0,0 +1,442 @@ +/* + * Generic VM initialization for NUMA setups. + * Copyright 2002,2003 Andi Kleen, SuSE Labs. + * Adapted for Xen: Ryan Harper + */ + +#include +#incl

Re: [PATCH] Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS

2022-09-08 Thread Andrew Cooper
On 08/09/2022 07:10, Jan Beulich wrote: > On 07.09.2022 16:33, Julien Grall wrote: >> On 25/08/2022 08:17, Jan Beulich wrote: >>> I haven't been able to find evidence of "-nopie" ever having been a >>> supported compiler option. The correct spelling is "-no-pie". >>> Furthermore like "-pie" this is

Re: [PATCH] xen/arm, device-tree: Make static-mem use #{address,size}-cells

2022-09-08 Thread Michal Orzel
Hi Henry, On 08/09/2022 11:31, Henry Wang wrote: > > In order to keep consistency in the device tree binding, there is > no need for static memory allocation feature to define a specific > set of address and size cells for "xen,static-mem" property. > > Therefore, this commit reuses the regular

[xen-unstable-smoke test] 173061: tolerable FAIL - PUSHED

2022-09-08 Thread osstest service owner
flight 173061 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173061/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 lib

Re: [PATCH v7 7/9] xen/arm: create shared memory nodes in guest device tree

2022-09-08 Thread Julien Grall
Hi, Replying to Penny and Stefano answer in the same e-mail. On 08/09/2022 04:21, Penny Zheng wrote: -Original Message- From: Stefano Stabellini Sent: Thursday, September 8, 2022 8:16 AM To: Julien Grall Cc: Penny Zheng ; xen-devel@lists.xenproject.org; Wei Chen ; Stefano Stabellin

RE: [PATCH] xen/arm, device-tree: Make static-mem use #{address,size}-cells

2022-09-08 Thread Henry Wang
Hi Michal, Thank you very much for your review, as always :)) > -Original Message- > From: Michal Orzel > > @@ -362,14 +362,13 @@ device-tree: > > > > / { > > chosen { > > +#address-cells = <0x1>; > > +#size-cells = <0x1>; > > +... > >

[PATCH v6 1/4] xen/arm: bootfdt: Make process_chosen_node() return int

2022-09-08 Thread Henry Wang
At the boot time, it is saner to stop booting early if an error occurs when parsing the device tree chosen node, rather than seeing random behavior afterwards. Therefore, this commit changes the return type of the process_chosen_node() from void to int, and return correct errno based on the error t

[PATCH v6 0/4] Introduce static heap

2022-09-08 Thread Henry Wang
The static heap, or statically configured heap, refers to parts of RAM reserved in the beginning for heap. Like the static memory allocation, such static heap regions are reserved by configuration in the device tree using physical address ranges. This feature is useful to run Xen on Arm MPU system

[PATCH v6 2/4] docs, xen/arm: Introduce static heap memory

2022-09-08 Thread Henry Wang
This commit introduces the static heap memory, which is parts of RAM reserved in the beginning of the boot time for heap. Firstly, since a new type of memory bank is needed for marking the memory bank solely as the heap, this commit defines `enum membank_type` and use this enum in function device_

[PATCH v6 4/4] xen/arm: Handle static heap pages in boot and heap allocator

2022-09-08 Thread Henry Wang
This commit firstly adds a bool field `static_heap` to bootinfo. This newly introduced field is set at the device tree parsing time if the static heap ranges are defined in the device tree chosen node. For Arm32, In `setup_mm`, if the static heap is enabled, we use the static heap region for both

[PATCH v6 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*

2022-09-08 Thread Henry Wang
With the static heap setup, keep using xenheap_* in the function setup_xenheap_mappings() will make the code confusing to read, because we always need to map the full RAM on Arm64. Therefore, renaming all "xenheap_*" variables to "directmap_*" to make clear the area is used to access the RAM easily

Re: [PATCH v5] tools/xenstore: add migration stream extensions for new features

2022-09-08 Thread Julien Grall
On 08/09/2022 11:12, Julien Grall wrote: Hi Juergen, On 08/09/2022 09:15, Juergen Gross wrote: Extend the definition of the Xenstore migration stream to cover new features: - per domain features - extended watches (watch depth) - per domain quota Some of those additions (per domain feature

Re: [PATCH v5 7/7] xen/arm: introduce xen-evtchn dom0less property

2022-09-08 Thread Julien Grall
Hi, On 08/09/2022 01:04, Stefano Stabellini wrote: On Wed, 7 Sep 2022, Rahul Singh wrote: Introduce a new sub-node under /chosen node to establish static event channel communication between domains on dom0less systems. An event channel will be created beforehand to allow the domains to send no

Re: [PATCH v6 0/4] Introduce static heap

2022-09-08 Thread Julien Grall
Hi Henry, On 08/09/2022 12:09, Henry Wang wrote: The static heap, or statically configured heap, refers to parts of RAM reserved in the beginning for heap. Like the static memory allocation, such static heap regions are reserved by configuration in the device tree using physical address ranges.

Re: [PATCH v4 2/6] xen/x86: move generically usable NUMA code from x86 to common

2022-09-08 Thread Jan Beulich
On 08.09.2022 12:32, Wei Chen wrote: > On 2022/9/8 17:09, Jan Beulich wrote: >> On 02.09.2022 05:31, Wei Chen wrote: >>> --- /dev/null >>> +++ b/xen/common/numa.c >>> @@ -0,0 +1,442 @@ >>> +/* >>> + * Generic VM initialization for NUMA setups. >>> + * Copyright 2002,2003 Andi Kleen, SuSE Labs. >>>

[linux-linus test] 173055: regressions - FAIL

2022-09-08 Thread osstest service owner
flight 173055 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173055/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 172133 build-i386-libvirt

[PATCH v5 0/2] xen/pci: implement is_memory_hole for ARM

2022-09-08 Thread Rahul Singh
This patch series is to implement something like is_memory_hole function for ARM. Rahul Singh (2): xen/arm: pci: modify pci_find_host_bridge_node argument to const pdev xen/pci: replace call to is_memory_hole to pci_check_bar xen/arch/arm/include/asm/pci.h | 5 ++- xen/arch/arm/pci/pci-

Re: [PATCH for-stable-5.10.y] xen-blkfront: Cache feature_persistent value before advertisement

2022-09-08 Thread Greg KH
On Tue, Sep 06, 2022 at 04:24:14PM +, SeongJae Park wrote: > commit fe8f65b018effbf473f53af3538d0c1878b8b329 upstream. > > Xen blkfront advertises its support of the persistent grants feature > when it first setting up and when resuming in 'talk_to_blkback()'. > Then, blkback reads the adverti

[PATCH v5 1/2] xen/arm: pci: modify pci_find_host_bridge_node argument to const pdev

2022-09-08 Thread Rahul Singh
Modify pci_find_host_bridge_node argument to const pdev to avoid converting the dev to pdev in pci_find_host_bridge_node and also constify the return. Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini Reviewed-by: Oleksandr Tyshchenko --- Changes in v5: - no changes Changes in v4: - no

Re: [PATCH] xen/arm, device-tree: Make static-mem use #{address,size}-cells

2022-09-08 Thread Julien Grall
Hi, On 08/09/2022 11:54, Henry Wang wrote: -Original Message- From: Michal Orzel @@ -362,14 +362,13 @@ device-tree: / { chosen { +#address-cells = <0x1>; +#size-cells = <0x1>; +... domU1 { compatible =

[PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-08 Thread Rahul Singh
is_memory_hole was implemented for x86 and not for ARM when introduced. Replace is_memory_hole call to pci_check_bar as function should check if device BAR is in defined memory range. Also, add an implementation for ARM which is required for PCI passthrough. On x86, pci_check_bar will call is_memo

Re: [PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-08 Thread Jan Beulich
On 08.09.2022 13:49, Rahul Singh wrote: > is_memory_hole was implemented for x86 and not for ARM when introduced. > Replace is_memory_hole call to pci_check_bar as function should check > if device BAR is in defined memory range. Also, add an implementation > for ARM which is required for PCI passt

[PATCH] docs/device-tree: Place the static-heap dt-binding in proper place

2022-09-08 Thread Henry Wang
The static-heap dt-binding should be placed after the last feature, namely static-evtchn. Fixes: 4596329291f5 ("docs, xen/arm: Introduce static heap memory") Signed-off-by: Henry Wang --- docs/misc/arm/device-tree/booting.txt | 86 +-- 1 file changed, 43 insertions(+), 43

Re: [PATCH v4 4/6] xen/x86: use arch_get_ram_range to get information from E820 map

2022-09-08 Thread Jan Beulich
On 02.09.2022 05:31, Wei Chen wrote: > The sanity check of nodes_cover_memory is also a requirement of > other architectures that support NUMA. But now, the code of > nodes_cover_memory is tied to the x86 E820. In this case, we > introduce arch_get_ram_range to decouple architecture specific > memo

RE: [PATCH] xen/arm, device-tree: Make static-mem use #{address,size}-cells

2022-09-08 Thread Henry Wang
Hi Julien and Michal, > -Original Message- > From: Julien Grall > >>> / { > >>> chosen { > >>> +#address-cells = <0x1>; > >>> +#size-cells = <0x1>; > >>> +... > >>> domU1 { > >>> compatible = "xen,domain";

Re: [PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-08 Thread Rahul Singh
Hi Jan, > On 8 Sep 2022, at 1:03 pm, Jan Beulich wrote: > > On 08.09.2022 13:49, Rahul Singh wrote: >> is_memory_hole was implemented for x86 and not for ARM when introduced. >> Replace is_memory_hole call to pci_check_bar as function should check >> if device BAR is in defined memory range. Als

Re: [PATCH 2/3] xl/libxl: Add ability to specify SMBIOS strings

2022-09-08 Thread Anthony PERARD
On Wed, Aug 10, 2022 at 03:48:26PM -0400, Jason Andryuk wrote: > hvm_xs_strings.h specifies xenstore entries which can be used to set or > override smbios strings. hvmloader has support for reading them, but > xl/libxl support is not wired up. > > Allow specifying the strings with the new xl.cfg

[ovmf test] 173062: regressions - FAIL

2022-09-08 Thread osstest service owner
flight 173062 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173062/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [PATCH v4 5/6] xen/x86: move NUMA scan nodes codes from x86 to common

2022-09-08 Thread Jan Beulich
On 02.09.2022 05:31, Wei Chen wrote: > --- a/xen/arch/x86/numa.c > +++ b/xen/arch/x86/numa.c > @@ -41,9 +41,12 @@ int __init arch_numa_setup(const char *opt) > return -EINVAL; > } > > -bool arch_numa_disabled(void) > +bool arch_numa_disabled(bool init_as_disable) I'm afraid my question as

Re: [PATCH] docs/device-tree: Place the static-heap dt-binding in proper place

2022-09-08 Thread Julien Grall
Hi Henry, On 08/09/2022 13:07, Henry Wang wrote: The static-heap dt-binding should be placed after the last feature, namely static-evtchn. Fixes: 4596329291f5 ("docs, xen/arm: Introduce static heap memory") Signed-off-by: Henry Wang Thanks for fixing the mistake I did while committing the pa

Re: [PATCH] xen/locks: add dynamic lock recursion checks

2022-09-08 Thread Jan Beulich
On 08.09.2022 09:46, Juergen Gross wrote: > Add checking of lock recursion to the hypervisor. This is done by using > a percpu data array for storing the address of each taken lock. Any > attempt to take a lock twice (with the exception of recursive > spinlocks) will result in a crash. This is espe

Re: [PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-08 Thread Julien Grall
Hi Jan, On 08/09/2022 13:03, Jan Beulich wrote: On 08.09.2022 13:49, Rahul Singh wrote: is_memory_hole was implemented for x86 and not for ARM when introduced. Replace is_memory_hole call to pci_check_bar as function should check if device BAR is in defined memory range. Also, add an implementa

Re: [PATCH 3/3] xl/libxl: Add OEM string support to smbios

2022-09-08 Thread Anthony PERARD
On Wed, Aug 10, 2022 at 03:48:27PM -0400, Jason Andryuk wrote: > Add support for OEM strings in the SMBIOS type 11. > > hvmloader checks them sequentially, so hide the implementation detail. > Allow multiple plain oem= items and assign the numeric values > internally. > > Signed-off-by: Jason And

Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device

2022-09-08 Thread Anthony PERARD
On Wed, Sep 07, 2022 at 06:02:24PM +0530, Viresh Kumar wrote: > Hi Anthony, > > Thanks a lot for the in-depth review, it is really helpful. > > I don't have much knowledge of the Xen code and wanted this code for I2C and > GPIO to be tested on Xen for the work we are doing around hypervisor agnos

[PATCH v8 0/9] static shared memory on dom0less system

2022-09-08 Thread Penny Zheng
**This series is based on the "Introduce static heap" series[1]** In safety-critical environment, it is not considered safe to dynamically change important configurations at runtime. Everything should be statically defined and statically verified. In this case, if the system configuration knows a

[PATCH v8 5/9] xen/arm: Add additional reference to owner domain when the owner is allocated

2022-09-08 Thread Penny Zheng
Borrower domain will fail to get a page ref using the owner domain during allocation, when the owner is created after borrower. So here, we decide to get and add the right amount of reference, which is the number of borrowers, when the owner is allocated. Signed-off-by: Penny Zheng Reviewed-by:

[PATCH v8 6/9] xen/arm: set up shared memory foreign mapping for borrower domain

2022-09-08 Thread Penny Zheng
This commit sets up shared memory foreign mapping for borrower domain. If owner domain is the default dom_io, all shared domain are treated as borrower domain. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v8 changes: - no change --- v7 change: - no changes --- v6 change: - no

[PATCH v8 4/9] xen/arm: introduce put_page_nr and get_page_nr

2022-09-08 Thread Penny Zheng
Later, we need to add the right amount of references, which should be the number of borrower domains, to the owner domain. Since we only have get_page() to increment the page reference by 1, a loop is needed per page, which is inefficient and time-consuming. To save the loop time, this commit intr

[PATCH v8 8/9] xen/arm: enable statically shared memory on Dom0

2022-09-08 Thread Penny Zheng
From: Penny Zheng To add statically shared memory nodes in Dom0, user shall put according static shared memory configuration under /chosen node. This commit adds shm-processing function process_shm in construct_dom0 to enable statically shared memory on Dom0. Signed-off-by: Penny Zheng Reviewe

RE: [PATCH v4 4/6] xen/x86: use arch_get_ram_range to get information from E820 map

2022-09-08 Thread Wei Chen
Hi Jan, > -Original Message- > From: Jan Beulich > Sent: 2022年9月8日 20:14 > To: Wei Chen > Cc: nd ; Andrew Cooper ; Roger Pau > Monné ; Wei Liu ; George Dunlap > ; Julien Grall ; Stefano > Stabellini ; xen-devel@lists.xenproject.org > Subject: Re: [PATCH v4 4/6] xen/x86: use arch_get_ram_

[linux-5.4 test] 173056: regressions - FAIL

2022-09-08 Thread osstest service owner
flight 173056 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/173056/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-vhd broken in 173048 build-i386-libvirt6 l

[xen-unstable-smoke test] 173064: tolerable FAIL - PUSHED

2022-09-08 Thread osstest service owner
flight 173064 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/173064/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 lib

RE: [PATCH v4 5/6] xen/x86: move NUMA scan nodes codes from x86 to common

2022-09-08 Thread Wei Chen
Hi Jan, > -Original Message- > From: Jan Beulich > Sent: 2022年9月8日 21:03 > To: Wei Chen > Cc: nd ; Andrew Cooper ; Roger Pau > Monné ; Wei Liu ; George Dunlap > ; Julien Grall ; Stefano > Stabellini ; xen-devel@lists.xenproject.org > Subject: Re: [PATCH v4 5/6] xen/x86: move NUMA scan no

Re: [PATCH v4 5/6] xen/x86: move NUMA scan nodes codes from x86 to common

2022-09-08 Thread Jan Beulich
On 08.09.2022 17:26, Wei Chen wrote: >> -Original Message- >> From: Jan Beulich >> Sent: 2022年9月8日 21:03 >> >> On 02.09.2022 05:31, Wei Chen wrote: >>> --- a/xen/arch/x86/numa.c >>> +++ b/xen/arch/x86/numa.c >>> @@ -41,9 +41,12 @@ int __init arch_numa_setup(const char *opt) >>> return

[ovmf test] 173066: regressions - FAIL

2022-09-08 Thread osstest service owner
flight 173066 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173066/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[PATCH v8 9/9] xen: Add static memory sharing in SUPPORT.md

2022-09-08 Thread Penny Zheng
on ARM, static memory sharing is tech preview, which shall be documented in SUPPORT.md Signed-off-by: Penny Zheng Reviewed-by: Michal Orzel Acked-by: Julien Grall --- v8 changes: - no change --- v7 changes: - doc refinement --- v6 change: - new commit --- SUPPORT.md | 7 +++ 1 file changed

[PATCH v8 3/9] xen/arm: allocate static shared memory to a specific owner domain

2022-09-08 Thread Penny Zheng
If owner property is defined, then owner domain of a static shared memory region is not the default dom_io anymore, but a specific domain. This commit implements allocating static shared memory to a specific domain when owner property is defined. Coding flow for dealing borrower domain will be in

[PATCH v8 1/9] xen/arm: introduce static shared memory

2022-09-08 Thread Penny Zheng
This patch series introduces a new feature: setting up static shared memory on a dom0less system, through device tree configuration. This commit parses shared memory node at boot-time, and reserve it in bootinfo.reserved_mem to avoid other use. This commits proposes a new Kconfig CONFIG_STATIC_SH

Re: [PATCH 2/3] xl/libxl: Add ability to specify SMBIOS strings

2022-09-08 Thread Jason Andryuk
On Thu, Sep 8, 2022 at 8:40 AM Anthony PERARD wrote: > > --- > > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c > > index 2abaab439c..9034933ea8 100644 > > --- a/tools/libs/light/libxl_dom.c > > +++ b/tools/libs/light/libxl_dom.c > > @@ -771,6 +771,26 @@ static int hvm_b

RE: [PATCH v4 2/6] xen/x86: move generically usable NUMA code from x86 to common

2022-09-08 Thread Wei Chen
Hi Jan, > -Original Message- > From: Jan Beulich > Sent: 2022年9月8日 19:42 > To: Wei Chen > Cc: nd ; Andrew Cooper ; Roger Pau > Monné ; Wei Liu ; George Dunlap > ; Julien Grall ; Stefano > Stabellini ; xen-devel@lists.xenproject.org > Subject: Re: [PATCH v4 2/6] xen/x86: move generically

[PATCH v8 2/9] xen/arm: assign static shared memory to the default owner dom_io

2022-09-08 Thread Penny Zheng
From: Penny Zheng This commit introduces process_shm to cope with static shared memory in domain construction. DOMID_IO will be the default owner of memory pre-shared among multiple domains at boot time, when no explicit owner is specified. And DOMID_IO is a fake domain and is not described in t

[PATCH v8 7/9] xen/arm: create shared memory nodes in guest device tree

2022-09-08 Thread Penny Zheng
We expose the shared memory to the domU using the "xen,shared-memory-v1" reserved-memory binding. See Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt in Linux for the corresponding device tree binding. To save the cost of re-parsing shared memory device tree configuration w

Re: [PATCH 3/3] xl/libxl: Add OEM string support to smbios

2022-09-08 Thread Jason Andryuk
On Thu, Sep 8, 2022 at 9:14 AM Anthony PERARD wrote: > > On Wed, Aug 10, 2022 at 03:48:27PM -0400, Jason Andryuk wrote: > > Add support for OEM strings in the SMBIOS type 11. > > > > hvmloader checks them sequentially, so hide the implementation detail. > > Allow multiple plain oem= items and assi

[libvirt test] 173058: regressions - FAIL

2022-09-08 Thread osstest service owner
flight 173058 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173058/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-armhf-libvirt

[ovmf test] 173068: regressions - FAIL

2022-09-08 Thread osstest service owner
flight 173068 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173068/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[PATCH v2 1/3] golang/xenlight: Extend KeyedUnion to support Arrays

2022-09-08 Thread Jason Andryuk
Generation for KeyedUnion types doesn't support Arrays. The smbios support will place an smbios array inside the hvm KeyedUnion, and gentotypes doesn't generate buildable Go code. Have KeyedUnion add an idl.Array check and issue the approriate xenlight_golang_array_to_C and xenlight_golang_array_

[PATCH v2 0/3] libxl smbios support

2022-09-08 Thread Jason Andryuk
hvm_xs_strings.h specifies xenstore entries which can be used to set or override smbios strings. hvmloader has support for reading them, but xl/libxl support is not wired up. This patches adds a new xl.cfg option and libxl support to write the xenstore strings. The xl syntax looks like: smbios=[

[PATCH v2 3/3] xl/libxl: Add OEM string support to smbios

2022-09-08 Thread Jason Andryuk
Add support for OEM strings in the SMBIOS type 11. hvmloader checks them sequentially, so hide the implementation detail. Allow multiple plain oem= items and assign the numeric values internally. Signed-off-by: Jason Andryuk --- v2: Move oem= description to be indented in docs Re-work oem= descr

[PATCH v2 2/3] xl/libxl: Add ability to specify SMBIOS strings

2022-09-08 Thread Jason Andryuk
hvm_xs_strings.h specifies xenstore entries which can be used to set or override smbios strings. hvmloader has support for reading them, but xl/libxl support is not wired up. Allow specifying the strings with the new xl.cfg option: smbios=["bios_vendor=Xen Project","system_version=1.0"] In terms

Re: [PATCH v5 7/7] xen/arm: introduce xen-evtchn dom0less property

2022-09-08 Thread Stefano Stabellini
On Thu, 8 Sep 2022, Julien Grall wrote: > On 08/09/2022 01:04, Stefano Stabellini wrote: > > On Wed, 7 Sep 2022, Rahul Singh wrote: > > > Introduce a new sub-node under /chosen node to establish static event > > > channel communication between domains on dom0less systems. > > > > > > An event chan

  1   2   >