Re: [PATCH v2 2/3] Add licenses under LICENSES

2022-08-19 Thread Julien Grall
Hi Stefano, On 18/08/2022 23:03, Stefano Stabellini wrote: Add the individual licenses under a new top-level directory named "LICENSES". Each license file includes its related SPDX tags. We already have a copy of the licenses in COPYING/CONTRIBUTING. I don't particularly mind where you want t

Re: [PATCH v2 1/3] Add SPDX to CODING_STYLE

2022-08-19 Thread Julien Grall
Hi Stefano, On 18/08/2022 23:03, Stefano Stabellini wrote: Signed-off-by: Stefano Stabellini --- CODING_STYLE | 10 ++ 1 file changed, 10 insertions(+) diff --git a/CODING_STYLE b/CODING_STYLE index 3386ee1d90..5faf274b3a 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -14,6 +14,16

[linux-linus test] 172628: regressions - FAIL

2022-08-19 Thread osstest service owner
flight 172628 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172628/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172133 build-amd64-libvirt

[PATCH 0/2] Arm32: memset() & friends

2022-08-19 Thread Jan Beulich
Note that while the original Linux code has the same issue, I don't really fancy sending there a patch similar to patch 1. That's because my XSA-307 related "make find_next_{,zero_}bit() have well defined behavior" was entirely ignored, so I would expect nothing better here. 1: correct string.h fu

[PATCH 1/2] Arm32: correct string.h functions for "int" -> "unsigned char" conversion

2022-08-19 Thread Jan Beulich
While Arm64 does so uniformly, for Arm32 only strchr() currently handles this properly. Add the necessary conversion also to strrchr(), memchr(), and memset(). As to the placement in memset(): Putting the new insn at the beginning of the function could perhaps be deemed more "obvious", but the cod

[PATCH 2/2] Arm32: tidy the memset() macro

2022-08-19 Thread Jan Beulich
- add parentheses where they were missing (MISRA) - make sure to evaluate also v exactly once (MISRA) - remove excess parentheses - rename local variables to not have leading underscores - apply Xen coding style Signed-off-by: Jan Beulich --- I wonder whether "if ( n_ )" is really helpful: It's e

Re: [PATCH v2 3/3] add SPDX to arch/arm/*.c

2022-08-19 Thread Julien Grall
Hi Stefano, On 18/08/2022 23:03, Stefano Stabellini wrote: Add SPDX license information to all the *.c files under arch/arm. There are some of the files below that didn't have copyright. It would be worth explaining in the commit message which license you selected and how. AFAICT you assumed

Re: [PATCH v2 1/3] Add SPDX to CODING_STYLE

2022-08-19 Thread Jan Beulich
On 19.08.2022 00:03, Stefano Stabellini wrote: > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -14,6 +14,16 @@ explicitly (e.g. tools/libxl/CODING_STYLE) but often > implicitly (Linux > coding style is fairly common). In general you should copy the style > of the surrounding code. If you are unsu

Re: [PATCH 2/2] Arm32: tidy the memset() macro

2022-08-19 Thread Julien Grall
Hi Jan, On 19/08/2022 08:50, Jan Beulich wrote: - add parentheses where they were missing (MISRA) - make sure to evaluate also v exactly once (MISRA) - remove excess parentheses - rename local variables to not have leading underscores - apply Xen coding style This code has been taken from Linu

[PATCH v2] xenbaked: properly use time_t in dump_stats()

2022-08-19 Thread Jan Beulich
"int" is not a suitable type to convert time()'s return value to. Avoid casts and other extra fiddling by using difftime(), on the assumption that the overhead of using "double" doesn't matter here. Coverity ID: 1509374 Signed-off-by: Jan Beulich --- v2: Properly use %.0f everywhere. --- a/tools

RE: [PATCH 2/2] Arm32: tidy the memset() macro

2022-08-19 Thread Wei Chen
Hi Jan, > -Original Message- > From: Xen-devel On Behalf Of Jan > Beulich > Sent: 2022年8月19日 15:50 > To: xen-devel@lists.xenproject.org > Cc: Julien Grall ; Stefano Stabellini > ; Volodymyr Babchuk ; > Bertrand Marquis > Subject: [PATCH 2/2] Arm32: tidy the memset() macro > > - add pare

Re: [PATCH 2/2] Arm32: tidy the memset() macro

2022-08-19 Thread Jan Beulich
On 19.08.2022 09:58, Julien Grall wrote: > On 19/08/2022 08:50, Jan Beulich wrote: >> - add parentheses where they were missing (MISRA) >> - make sure to evaluate also v exactly once (MISRA) >> - remove excess parentheses >> - rename local variables to not have leading underscores >> - apply Xen co

Re: [PATCH 2/2] Arm32: tidy the memset() macro

2022-08-19 Thread Jan Beulich
On 19.08.2022 09:59, Wei Chen wrote: >> -Original Message- >> From: Xen-devel On Behalf Of Jan >> Beulich >> Sent: 2022年8月19日 15:50 >> >> - add parentheses where they were missing (MISRA) >> - make sure to evaluate also v exactly once (MISRA) >> - remove excess parentheses >> - rename loca

Re: [PATCH 2/2] Arm32: tidy the memset() macro

2022-08-19 Thread Julien Grall
Hi Jan, On 19/08/2022 09:02, Jan Beulich wrote: On 19.08.2022 09:58, Julien Grall wrote: On 19/08/2022 08:50, Jan Beulich wrote: - add parentheses where they were missing (MISRA) - make sure to evaluate also v exactly once (MISRA) - remove excess parentheses - rename local variables to not hav

Re: [PATCH 2/2] Arm32: tidy the memset() macro

2022-08-19 Thread Jan Beulich
On 19.08.2022 10:06, Julien Grall wrote: > On 19/08/2022 09:02, Jan Beulich wrote: >> On 19.08.2022 09:58, Julien Grall wrote: >>> On 19/08/2022 08:50, Jan Beulich wrote: - add parentheses where they were missing (MISRA) - make sure to evaluate also v exactly once (MISRA) - remove ex

Re: [PATCH 2/2] Arm32: tidy the memset() macro

2022-08-19 Thread Julien Grall
Hi Jan, On 19/08/2022 09:11, Jan Beulich wrote: On 19.08.2022 10:06, Julien Grall wrote: On 19/08/2022 09:02, Jan Beulich wrote: On 19.08.2022 09:58, Julien Grall wrote: On 19/08/2022 08:50, Jan Beulich wrote: - add parentheses where they were missing (MISRA) - make sure to evaluate also v e

Re: [PATCH v2] xenbaked: properly use time_t in dump_stats()

2022-08-19 Thread Anthony PERARD
On Fri, Aug 19, 2022 at 09:59:26AM +0200, Jan Beulich wrote: > "int" is not a suitable type to convert time()'s return value to. Avoid > casts and other extra fiddling by using difftime(), on the assumption > that the overhead of using "double" doesn't matter here. > > Coverity ID: 1509374 > Signe

Re: [PATCH 1/2] Arm32: correct string.h functions for "int" -> "unsigned char" conversion

2022-08-19 Thread Julien Grall
Hi Jan, On 19/08/2022 08:49, Jan Beulich wrote: While Arm64 does so uniformly, for Arm32 only strchr() currently handles this properly. Add the necessary conversion also to strrchr(), memchr(), and memset(). As to the placement in memset(): Putting the new insn at the beginning of the function

Re: [PATCH 2/2] Arm32: tidy the memset() macro

2022-08-19 Thread Jan Beulich
On 19.08.2022 10:24, Julien Grall wrote: > On 19/08/2022 09:11, Jan Beulich wrote: >> On 19.08.2022 10:06, Julien Grall wrote: >>> On 19/08/2022 09:02, Jan Beulich wrote: On 19.08.2022 09:58, Julien Grall wrote: > On 19/08/2022 08:50, Jan Beulich wrote: >> - add parentheses where they

Re: [PATCH 0/2] Arm32: memset() & friends

2022-08-19 Thread Julien Grall
On 19/08/2022 08:48, Jan Beulich wrote: Note that while the original Linux code has the same issue, I don't really fancy sending there a patch similar to patch 1. That's because my XSA-307 related "make find_next_{,zero_}bit() have well defined behavior" was entirely ignored, so I would expect

Re: [PATCH 2/2] Arm32: tidy the memset() macro

2022-08-19 Thread Julien Grall
Hi Jan, On 19/08/2022 09:31, Jan Beulich wrote: On 19.08.2022 10:24, Julien Grall wrote: On 19/08/2022 09:11, Jan Beulich wrote: On 19.08.2022 10:06, Julien Grall wrote: On 19/08/2022 09:02, Jan Beulich wrote: On 19.08.2022 09:58, Julien Grall wrote: On 19/08/2022 08:50, Jan Beulich wrote:

Re: [PATCH 0/2] Arm32: memset() & friends

2022-08-19 Thread Jan Beulich
On 19.08.2022 10:32, Julien Grall wrote: > On 19/08/2022 08:48, Jan Beulich wrote: >> Note that while the original Linux code has the same issue, I don't >> really fancy sending there a patch similar to patch 1. That's because >> my XSA-307 related "make find_next_{,zero_}bit() have well defined >>

RE: [PATCH 2/2] Arm32: tidy the memset() macro

2022-08-19 Thread Wei Chen
Hi Jan, > -Original Message- > From: Jan Beulich > Sent: 2022年8月19日 16:04 > To: Wei Chen > Cc: Julien Grall ; Stefano Stabellini > ; Volodymyr Babchuk ; > Bertrand Marquis ; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH 2/2] Arm32: tidy the memset() macro > > On 19.08.2022 09:

[ovmf test] 172639: regressions - FAIL

2022-08-19 Thread osstest service owner
flight 172639 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172639/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [libvirt PATCH] libxl: Fix build with recent Xen that introduces new disk backend type

2022-08-19 Thread Anthony PERARD
On Mon, Aug 01, 2022 at 10:23:48AM +0200, Michal Prívozník wrote: > Ah, I couldn't find the commit in master, and it's simply because it's > not there yet. It's in staging: > > https://xenbits.xen.org/gitweb/?p=xen.git;a=commit;f=tools/libs/light/libxl_types.idl;h=66dd1c62b2a3c707bd5c55750d10a8223

[PATCH v2 0/7] xen/evtchn: implement static event channel signaling

2022-08-19 Thread Rahul Singh
The purpose of this patch series is to add static event channel signaling support to Xen on Arm based on design doc [1]. [1] https://lists.xenproject.org/archives/html/xen-devel/2022-05/msg01160.html Julien Grall (1): xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated Rahul

[PATCH v2 1/7] xen/evtchn: Make sure all buckets below d->valid_evtchns are allocated

2022-08-19 Thread Rahul Singh
From: Julien Grall Since commit 01280dc19cf3 "evtchn: simplify port_is_valid()", the event channels code assumes that all the buckets below d->valid_evtchns are always allocated. This assumption hold in most of the situation because a guest is not allowed to chose the port. Instead, it will be t

[PATCH v2 2/7] xen/evtchn: Add an helper to reserve/allocate a port

2022-08-19 Thread Rahul Singh
In a follow-up patch we will be able to either reserve or allocate a port for various event channel helpers. A new wrapper is introduced to either reserved a given port or allocate an empty one if zero. Take the opportunity to replace the open-coded version in evtchn_bind_virq(). Signed-off-by:

[PATCH v2 3/7] xen/evtchn: restrict the maximum number of evtchn supported for domUs

2022-08-19 Thread Rahul Singh
Static event channel support will be added for dom0less domains. Restrict the maximum number of evtchn supported for domUs to avoid allocating a large amount of memory in Xen. Signed-off-by: Rahul Singh --- Changes in v2: - new patch in the version --- --- xen/arch/arm/domain_build.c | 2 +- xe

[PATCH v2 4/7] xen/evtchn: modify evtchn_bind_interdomain to support static evtchn

2022-08-19 Thread Rahul Singh
Static event channel support will be added for dom0less domains. Modify evtchn_bind_interdomain to support static evtchn. It is necessary to have access to the evtchn_bind_interdomain function to do that, so make evtchn_bind_interdomain global and also make it __must_check. evtchn_bind_interdomai

[PATCH v2 5/7] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port

2022-08-19 Thread Rahul Singh
evtchn_alloc_unbound() always allocates the next available port. Static event channel support for dom0less domains requires allocating a specified port. Modify the evtchn_alloc_unbound() to accept the port number as an argument and allocate the specified port if available. If the port number argum

[PATCH v2 6/7] xen: introduce xen-evtchn dom0less property

2022-08-19 Thread Rahul Singh
Introduce a new sub-node under /chosen node to establish static event channel communication between domains on dom0less systems. An event channel will be created beforehand to allow the domains to send notifications to each other. Signed-off-by: Rahul Singh --- Changes in v2: - no change --- --

[PATCH v2 7/7] xen/arm: introduce new xen,enhanced property value

2022-08-19 Thread Rahul Singh
Introduce a new "xen,enhanced" dom0less property value "evtchn" to enable/disable event-channel interfaces for dom0less guests. The configurable option is for domUs only. For dom0 we always set the corresponding property in the Xen code to true. Signed-off-by: Rahul Singh --- Changes in v2: - n

Re: [PATCH v2 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-08-19 Thread Rahul Singh
Hi Jan, > On 19 Aug 2022, at 7:07 am, Jan Beulich wrote: > > On 18.08.2022 16:58, Rahul Singh wrote: >>> On 17 Aug 2022, at 4:18 pm, Jan Beulich wrote: >>> On 17.08.2022 16:45, Rahul Singh wrote: @@ -363,6 +373,42 @@ int __init pci_host_bridge_mappings(struct domain *d) return 0; >

[xen-unstable-smoke test] 172641: tolerable FAIL - PUSHED

2022-08-19 Thread osstest service owner
flight 172641 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172641/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 lib

[ovmf test] 172642: regressions - FAIL

2022-08-19 Thread osstest service owner
flight 172642 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172642/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [PATCH] xen/arm: acpi: Support memory reserve configuration table

2022-08-19 Thread Marc Zyngier
On Thu, 18 Aug 2022 17:24:31 +0100, Ard Biesheuvel wrote: > > On Thu, 18 Aug 2022 at 17:49, Leo Yan wrote: > > > > On Thu, Aug 18, 2022 at 11:04:48AM +0100, Julien Grall wrote: > > > > [...] > > > > > > > Seems it's broken for kdump/kexec if kernel boots with using DT? > > > > > > > > > > > > >

[xen-unstable test] 172632: tolerable FAIL - PUSHED

2022-08-19 Thread osstest service owner
flight 172632 xen-unstable real [real] flight 172643 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/172632/ http://logs.test-lab.xenproject.org/osstest/logs/172643/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

Re: [PATCH 2/2] Arm32: tidy the memset() macro

2022-08-19 Thread Jan Beulich
On 19.08.2022 11:41, Wei Chen wrote: > Hi Jan, > >> -Original Message- >> From: Jan Beulich >> Sent: 2022年8月19日 16:04 >> To: Wei Chen >> Cc: Julien Grall ; Stefano Stabellini >> ; Volodymyr Babchuk ; >> Bertrand Marquis ; xen- >> de...@lists.xenproject.org >> Subject: Re: [PATCH 2/2] Arm

Ping: [XEN PATCH v4 01/32] tools/debugger/gdbsx: Fix and cleanup makefiles

2022-08-19 Thread Anthony PERARD
Hi Elena, Could you give a ack or review this patch? Thanks, On Thu, Aug 11, 2022 at 05:48:14PM +0100, Anthony PERARD wrote: > gdbsx/: > - Make use of subdir facility for the "clean" target. > - No need to remove the *.a, they aren't in this dir. > - Avoid calling "distclean" in subdirs as

Ping: [XEN PATCH v4 08/32] tools/xentrace: rework Makefile

2022-08-19 Thread Anthony PERARD
Hi George Could you give a ack or review this patch? Thanks, On Thu, Aug 11, 2022 at 05:48:21PM +0100, Anthony PERARD wrote: > Remove "build" targets. > > Use "$(TARGETS)" to list binary to be built. > > Cleanup "clean" rule. > > Also drop conditional install of $(BIN) and $(LIBBIN) as those

Ping: [XEN PATCH v4 17/32] tools: Introduce $(xenlibs-ldflags, ) macro

2022-08-19 Thread Anthony PERARD
Hi Nick, George, Could you give a ack or review this patch? Also sorry George, it seems that the use of "--remove-duplicates" with `get_maintainer.pl` have removed your email from CC the list. Thanks, On Thu, Aug 11, 2022 at 05:48:30PM +0100, Anthony PERARD wrote: > This avoid the need to open-

Ping: [XEN PATCH v4 21/32] tools: Remove -Werror everywhere else

2022-08-19 Thread Anthony PERARD
Hi Elena, Tim, Jan, Andrew, Roger, George, Elena, could you give a ack or review this patch, for the change in "tools/debugger/gdbsx/Rules.mk" ? Tim, could you give a ack or review this patch, for the change in "tools/debugger/kdd/Makefile" ? Jan, Andrew, Roger, could you give a ack or review th

Re: [XEN PATCH v4 00/32] Toolstack build system improvement, toward non-recursive makefiles

2022-08-19 Thread Anthony PERARD
On Mon, Aug 15, 2022 at 09:01:12AM +0200, Jan Beulich wrote: > I've committed a non-contiguous initial part of this series, omitting > patches where acks still look to be missing, and hence only up to a > point where I could be reasonably certain that the skipped patches > won't interact with later

[linux-5.4 test] 172634: regressions - FAIL

2022-08-19 Thread osstest service owner
flight 172634 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172634/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172128 build-amd64-libvirt

[ovmf test] 172644: regressions - FAIL

2022-08-19 Thread osstest service owner
flight 172644 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172644/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [XEN PATCH v4 21/32] tools: Remove -Werror everywhere else

2022-08-19 Thread Jan Beulich
On 11.08.2022 18:48, Anthony PERARD wrote: > Patch "tools: Add -Werror by default to all tools/" have added > "-Werror" to CFLAGS in tools/Rules.mk, remove it from every other > makefiles as it is now duplicated. > > Signed-off-by: Anthony PERARD > Acked-by: Christian Lindig Acked-by: Jan Beuli

[libvirt test] 172638: regressions - FAIL

2022-08-19 Thread osstest service owner
flight 172638 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/172638/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-armhf-libvirt

Re: [XEN PATCH v4 21/32] tools: Remove -Werror everywhere else

2022-08-19 Thread Anthony PERARD
On Fri, Aug 19, 2022 at 04:56:05PM +0200, Jan Beulich wrote: > On 11.08.2022 18:48, Anthony PERARD wrote: > > tools/console/client/Makefile | 1 - > > tools/console/daemon/Makefile | 1 - > > tools/debugger/kdd/Makefile | 1 - > > tools/flask/utils/Makefile | 1 - > > tools/fuzz/cpu-p

Re: [PATCH v2 1/2] xen/arm: pci: modify pci_find_host_bridge_node argument to const pdev

2022-08-19 Thread Oleksandr
On 17.08.22 17:45, Rahul Singh wrote: Hello Rahul Modify pci_find_host_bridge_node argument to const pdev to avoid converting the dev to pdev in pci_find_host_bridge_node and also constify the return. Signed-off-by: Rahul Singh Reviewed-by: Oleksandr Tyshchenko --- Changes in v2:

[ovmf test] 172647: regressions - FAIL

2022-08-19 Thread osstest service owner
flight 172647 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172647/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[qemu-mainline test] 172636: regressions - FAIL

2022-08-19 Thread osstest service owner
flight 172636 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172636/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 172123 build-i386-libvir

[ovmf test] 172648: regressions - FAIL

2022-08-19 Thread osstest service owner
flight 172648 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172648/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Revert-and-reapply due to unwanted tag

2022-08-19 Thread George Dunlap
Hello all, It’s come to my attention that the commits below are tagged as “Suggested-by” someone, and that person doesn’t believe the tag to be accurate. Having talked to most of the other committers, we decided to revert the commits and re-apply them with the offending tag removed; this will

[PATCH 2/7] xsm/flask: sidtab: Fix MISRA C 2012 Rule 20.7 violations

2022-08-19 Thread Xenia Ragiadakou
In macros SIDTAB_HASH(), INIT_SIDTAB_LOCK(), SIDTAB_LOCK() and SIDTAB_UNLOCK(), add parentheses around the macro parameter to prevent against unintended expansions. Signed-off-by: Xenia Ragiadakou --- xen/xsm/flask/ss/sidtab.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff -

[PATCH 3/7] xen/elf: Fix MISRA C 2012 Rule 20.7 violations

2022-08-19 Thread Xenia Ragiadakou
In macros ELF32_ST_TYPE() and ELF64_ST_TYPE(), add parentheses around the macro parameter to prevent against unintended expansions. Signed-off-by: Xenia Ragiadakou --- xen/include/xen/elfstructs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/elfstructs.

[PATCH 5/7] xen/rbtree: Fix MISRA C 2012 Rule 20.7 violation

2022-08-19 Thread Xenia Ragiadakou
In macro __rb_parent(), add parentheses around the macro parameter to prevent against unintended expansions. Signed-off-by: Xenia Ragiadakou --- xen/lib/rbtree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/lib/rbtree.c b/xen/lib/rbtree.c index 85a4f20313..eb418baabb 1

[PATCH 4/7] xen/vgic: Fix MISRA C 2012 Rule 20.7 violation

2022-08-19 Thread Xenia Ragiadakou
In macro VGIC_V3_LR_INDEX(), add parentheses around the macro parameter to prevent against unintended expansions. Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/include/asm/new_vgic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/new_vgic.h b/xen

[PATCH 1/7] xen/arm: gic_v3_its: Fix MISRA C 2012 Rule 20.7 violations

2022-08-19 Thread Xenia Ragiadakou
In macros GITS_TYPER_DEVICE_ID_BITS(), GITS_TYPER_EVENT_ID_BITS() and GITS_BASER_ENTRY_SIZE(), add parentheses around the macro parameter to prevent against unintended expansions. Realign subsequent lines, if any. Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/include/asm/gic_v3_its.h | 10 +++

[PATCH 7/7] xen/device_tree: Fix MISRA C 2012 Rule 20.7 violations

2022-08-19 Thread Xenia Ragiadakou
In macros dt_for_each_property_node(), dt_for_each_device_node() and dt_for_each_child_node(), add parentheses around the macro parameters that have the arrow operator applied, to prevent against unintended expansions. Signed-off-by: Xenia Ragiadakou --- xen/include/xen/device_tree.h | 6 +++---

[PATCH 6/7] xen/arm: processor: Fix MISRA C 2012 Rule 20.7 violations

2022-08-19 Thread Xenia Ragiadakou
In macros MPIDR_LEVEL_SHIFT() and MPIDR_AFFINITY_LEVEL(), add parentheses around the macro parameters 'level' and 'mpidr', respectively, to prevent against unintended expansions. Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/include/asm/processor.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 0/7] Fix MISRA C 2012 Rule 20.7 violations

2022-08-19 Thread Xenia Ragiadakou
Xenia Ragiadakou (7): xen/arm: gic_v3_its: Fix MISRA C 2012 Rule 20.7 violations xsm/flask: sidtab: Fix MISRA C 2012 Rule 20.7 violations xen/elf: Fix MISRA C 2012 Rule 20.7 violations xen/vgic: Fix MISRA C 2012 Rule 20.7 violation xen/rbtree: Fix MISRA C 2012 Rule 20.7 violation xen/ar

Re: [PATCH 1/7] xen/arm: gic_v3_its: Fix MISRA C 2012 Rule 20.7 violations

2022-08-19 Thread Stefano Stabellini
On Fri, 19 Aug 2022, Xenia Ragiadakou wrote: > In macros GITS_TYPER_DEVICE_ID_BITS(), GITS_TYPER_EVENT_ID_BITS() and > GITS_BASER_ENTRY_SIZE(), add parentheses around the macro parameter to > prevent against unintended expansions. > Realign subsequent lines, if any. > > Signed-off-by: Xenia Ragiad

Re: [PATCH 2/7] xsm/flask: sidtab: Fix MISRA C 2012 Rule 20.7 violations

2022-08-19 Thread Stefano Stabellini
On Fri, 19 Aug 2022, Xenia Ragiadakou wrote: > In macros SIDTAB_HASH(), INIT_SIDTAB_LOCK(), SIDTAB_LOCK() and > SIDTAB_UNLOCK(), > add parentheses around the macro parameter to prevent against unintended > expansions. > > Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini > ---

Re: [PATCH 3/7] xen/elf: Fix MISRA C 2012 Rule 20.7 violations

2022-08-19 Thread Stefano Stabellini
On Fri, 19 Aug 2022, Xenia Ragiadakou wrote: > In macros ELF32_ST_TYPE() and ELF64_ST_TYPE(), add parentheses around the > macro parameter to prevent against unintended expansions. > > Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini > --- > xen/include/xen/elfstructs.h | 4 ++

Re: [PATCH 4/7] xen/vgic: Fix MISRA C 2012 Rule 20.7 violation

2022-08-19 Thread Stefano Stabellini
On Fri, 19 Aug 2022, Xenia Ragiadakou wrote: > In macro VGIC_V3_LR_INDEX(), add parentheses around the macro parameter > to prevent against unintended expansions. > > Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/include/asm/new_vgic.h | 2 +- > 1 file

Re: [PATCH 5/7] xen/rbtree: Fix MISRA C 2012 Rule 20.7 violation

2022-08-19 Thread Stefano Stabellini
On Fri, 19 Aug 2022, Xenia Ragiadakou wrote: > In macro __rb_parent(), add parentheses around the macro parameter to prevent > against unintended expansions. > > Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini > --- > xen/lib/rbtree.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [PATCH 6/7] xen/arm: processor: Fix MISRA C 2012 Rule 20.7 violations

2022-08-19 Thread Stefano Stabellini
On Fri, 19 Aug 2022, Xenia Ragiadakou wrote: > In macros MPIDR_LEVEL_SHIFT() and MPIDR_AFFINITY_LEVEL(), add parentheses > around the macro parameters 'level' and 'mpidr', respectively, to prevent > against unintended expansions. > > Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellin

Re: [PATCH 7/7] xen/device_tree: Fix MISRA C 2012 Rule 20.7 violations

2022-08-19 Thread Stefano Stabellini
On Fri, 19 Aug 2022, Xenia Ragiadakou wrote: > In macros dt_for_each_property_node(), dt_for_each_device_node() and > dt_for_each_child_node(), add parentheses around the macro parameters that > have the arrow operator applied, to prevent against unintended expansions. > > Signed-off-by: Xenia Rag

Re: [PATCH v2 1/3] Add SPDX to CODING_STYLE

2022-08-19 Thread Stefano Stabellini
On Fri, 19 Aug 2022, Julien Grall wrote: > Hi Stefano, > > On 18/08/2022 23:03, Stefano Stabellini wrote: > > Signed-off-by: Stefano Stabellini > > --- > > CODING_STYLE | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/CODING_STYLE b/CODING_STYLE > > index 3386ee1d90.

Re: [PATCH v2 2/3] Add licenses under LICENSES

2022-08-19 Thread Stefano Stabellini
On Fri, 19 Aug 2022, Julien Grall wrote: > Hi Stefano, > > On 18/08/2022 23:03, Stefano Stabellini wrote: > > Add the individual licenses under a new top-level directory named > > "LICENSES". Each license file includes its related SPDX tags. > > We already have a copy of the licenses in COPYING/C

Re: [PATCH v2 3/3] add SPDX to arch/arm/*.c

2022-08-19 Thread Stefano Stabellini
On Fri, 19 Aug 2022, Julien Grall wrote: > On 18/08/2022 23:03, Stefano Stabellini wrote: > > Add SPDX license information to all the *.c files under arch/arm. > > There are some of the files below that didn't have copyright. It would be > worth explaining in the commit message which license you s

[xen-unstable-smoke test] 172652: tolerable FAIL - PUSHED

2022-08-19 Thread osstest service owner
flight 172652 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172652/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 lib

[ovmf test] 172651: regressions - FAIL

2022-08-19 Thread osstest service owner
flight 172651 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172651/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[linux-linus test] 172640: regressions - FAIL

2022-08-19 Thread osstest service owner
flight 172640 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172640/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172133 build-amd64-libvirt

[ovmf test] 172653: regressions - FAIL

2022-08-19 Thread osstest service owner
flight 172653 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172653/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[xen-unstable test] 172645: tolerable FAIL - PUSHED

2022-08-19 Thread osstest service owner
flight 172645 xen-unstable real [real] flight 172655 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/172645/ http://logs.test-lab.xenproject.org/osstest/logs/172655/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm6

[qemu-mainline test] 172649: regressions - FAIL

2022-08-19 Thread osstest service owner
flight 172649 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172649/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 172123 build-i386-libvir

[linux-5.4 test] 172646: regressions - FAIL

2022-08-19 Thread osstest service owner
flight 172646 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172646/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172128 build-amd64-libvirt

[ovmf test] 172656: regressions - FAIL

2022-08-19 Thread osstest service owner
flight 172656 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172656/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt