Re: [PATCH V7 03/11] vpci/header: implement guest BAR register handlers

2022-07-28 Thread Jan Beulich
On 27.07.2022 18:17, Oleksandr wrote: > On 27.07.22 13:15, Jan Beulich wrote: >> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>> @@ -527,6 +592,17 @@ static int cf_check init_bars(struct pci_dev *pdev) >>> if ( (val & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_IO ) >>>

Re: [PATCH V7 06/11] vpci/header: program p2m with guest BAR view

2022-07-28 Thread Jan Beulich
On 27.07.2022 19:06, Oleksandr wrote: > On 27.07.22 13:19, Jan Beulich wrote: >> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> Take into account guest's BAR view and program its p2m accordingly: >>> gfn is guest's view of the BAR and mfn is the physical

Re: [PATCH V7 10/11] xen/arm: translate virtual PCI bus topology for guests

2022-07-28 Thread Jan Beulich
On 27.07.2022 21:39, Oleksandr wrote: > On 27.07.22 20:54, Oleksandr wrote: >> On 26.07.22 18:16, Jan Beulich wrote: >>> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: --- a/xen/arch/arm/vpci.c +++ b/xen/arch/arm/vpci.c @@ -41,6 +41,16 @@ static int vpci_mmio_read(struct vcpu *v,

Re: Question to mem-path support at QEMU for Xen

2022-07-28 Thread Huang Rui
Hi Igor, Appreciate you for the reply! On Wed, Jul 27, 2022 at 04:19:30PM +0800, Igor Mammedov wrote: > On Tue, 26 Jul 2022 15:27:07 +0800 > Huang Rui wrote: > > > Hi Anthony and other Qemu/Xen guys, > > > > We are trying to enable venus on Xen virtualization platform. And we would > > like to

Re: [PATCH] xen/xsm: dummy.h: Fix MISRA C 2012 Directive 4.10 violation

2022-07-28 Thread Luca Fancellu
> On 27 Jul 2022, at 16:19, Xenia Ragiadakou wrote: > > Protect header file from being included more than once by adding ifndef guard. > > Signed-off-by: Xenia Ragiadakou It makes sense! Reviewed-by: Luca Fancellu

[PATCH v2] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

2022-07-28 Thread Xenia Ragiadakou
The function idle_loop() is referenced only in domain.c. Change its linkage from external to internal by adding the storage-class specifier static to its definitions. Add the function as a 'fake' input operand to the inline assembly statement, to make the compiler aware that the function is used.

Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation

2022-07-28 Thread Bertrand Marquis
Hi Julien, > On 27 Jul 2022, at 16:46, Julien Grall wrote: > > Hi Xenia, > > On 27/07/2022 16:32, Xenia Ragiadakou wrote: >> Remove unused macro atomic_xchg(). >> Signed-off-by: Xenia Ragiadakou >> --- >> xen/arch/arm/include/asm/atomic.h | 2 -- >> 1 file changed, 2 deletions(-) >> diff --git

[PATCH v3 0/2] Create a test job for testing static memory on qemu

2022-07-28 Thread Xenia Ragiadakou
This patch series - removes all the references to the XEN_CONFIG_EXPERT environmental variable which is not used anymore - creates a trivial arm64 test job that boots xen on qemu with dom0 and a direct mapped dom0less domu with static memory and verifies that domu's memory ranges are the same as th

[PATCH v3 2/2] automation: arm64: Create a test job for testing static allocation on qemu

2022-07-28 Thread Xenia Ragiadakou
Enable CONFIG_STATIC_MEMORY in the existing arm64 build. Create a new test job, called qemu-smoke-arm64-gcc-staticmem. Adjust qemu-smoke-arm64.sh script to accomodate the static memory test as a new test variant. The test variant is determined based on the first argument passed to the script. For

[PATCH v3 1/2] automation: Remove XEN_CONFIG_EXPERT leftovers

2022-07-28 Thread Xenia Ragiadakou
The EXPERT config option cannot anymore be selected via the environmental variable XEN_CONFIG_EXPERT. Remove stale references to XEN_CONFIG_EXPERT from the automation code. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini --- Changes in v2: - add Stefano's R-b tag Changes in v3:

[xen-unstable test] 171887: tolerable FAIL - PUSHED

2022-07-28 Thread osstest service owner
flight 171887 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171887/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail blocked in 171873 test-amd64-amd64-xl-qemut-win7-amd64

[PATCH v1] xen: add late init call in start_xen

2022-07-28 Thread Boyoun Park
Hello,   This patch added late_initcall to deal with some init functions which should be called after other init functions in start_xen.   If this patch is added, then the original initcall in xen will be treated as early_initcall and the late_initcall which is added by this patch wi

Re: [PATCH v2] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

2022-07-28 Thread Jan Beulich
On 28.07.2022 09:57, Xenia Ragiadakou wrote: > --- a/xen/arch/arm/include/asm/current.h > +++ b/xen/arch/arm/include/asm/current.h > @@ -44,8 +44,11 @@ static inline struct cpu_info *get_cpu_info(void) > > #define guest_cpu_user_regs() (&get_cpu_info()->guest_cpu_user_regs) > > +extern void re

Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation

2022-07-28 Thread Julien Grall
On 28/07/2022 08:57, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 27 Jul 2022, at 16:46, Julien Grall wrote: Hi Xenia, On 27/07/2022 16:32, Xenia Ragiadakou wrote: Remove unused macro atomic_xchg(). Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/include/asm/atomic.h | 2 -- 1

Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation

2022-07-28 Thread Bertrand Marquis
Hi Julien, > On 28 Jul 2022, at 10:35, Julien Grall wrote: > > > > On 28/07/2022 08:57, Bertrand Marquis wrote: >> Hi Julien, > > Hi Bertrand, > >>> On 27 Jul 2022, at 16:46, Julien Grall wrote: >>> >>> Hi Xenia, >>> >>> On 27/07/2022 16:32, Xenia Ragiadakou wrote: Remove unused macr

[linux-linus test] 171891: tolerable FAIL - PUSHED

2022-07-28 Thread osstest service owner
flight 171891 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171891/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 171882 test-armhf-armhf-libvirt 16 saver

Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation

2022-07-28 Thread Julien Grall
On 28/07/2022 10:45, Bertrand Marquis wrote: On 28 Jul 2022, at 10:35, Julien Grall wrote: On 28/07/2022 08:57, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 27 Jul 2022, at 16:46, Julien Grall wrote: Hi Xenia, On 27/07/2022 16:32, Xenia Ragiadakou wrote: Remove unused macro

Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation

2022-07-28 Thread Bertrand Marquis
Hi Julien, > On 28 Jul 2022, at 11:21, Julien Grall wrote: > > > > On 28/07/2022 10:45, Bertrand Marquis wrote: >>> On 28 Jul 2022, at 10:35, Julien Grall wrote: >>> >>> >>> >>> On 28/07/2022 08:57, Bertrand Marquis wrote: Hi Julien, >>> >>> Hi Bertrand, >>> > On 27 Jul 2022, at

[libvirt test] 171895: regressions - FAIL

2022-07-28 Thread osstest service owner
flight 171895 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171895/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH v1] xen: add late init call in start_xen

2022-07-28 Thread Jan Beulich
On 28.07.2022 11:22, Boyoun Park wrote: > Hello, > > This patch added late_initcall to deal with > > some init functions which should be called > > after other init functions in start_xen. > > If this patch is added, > > then the original initcall in xen will be treated > > as early_initcall

[PATCH v3] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector

2022-07-28 Thread Jane Malalane
Implement support for the HVMOP_set_evtchn_upcall_vector hypercall in order to set the per-vCPU event channel vector callback on Linux and use it in preference of HVM_PARAM_CALLBACK_IRQ. If the per-VCPU vector setup is successful on BSP, use this method for the APs. If not, fallback to the global

Re: [PATCH v2] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

2022-07-28 Thread Xenia Ragiadakou
Hi Jan, On 7/28/22 12:26, Jan Beulich wrote: On 28.07.2022 09:57, Xenia Ragiadakou wrote: --- a/xen/arch/arm/include/asm/current.h +++ b/xen/arch/arm/include/asm/current.h @@ -44,8 +44,11 @@ static inline struct cpu_info *get_cpu_info(void) #define guest_cpu_user_regs() (&get_cpu_info()->g

Re: [PATCH v2] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

2022-07-28 Thread Julien Grall
Hi, On 28/07/2022 10:26, Jan Beulich wrote: On 28.07.2022 09:57, Xenia Ragiadakou wrote: --- a/xen/arch/arm/include/asm/current.h +++ b/xen/arch/arm/include/asm/current.h @@ -44,8 +44,11 @@ static inline struct cpu_info *get_cpu_info(void) #define guest_cpu_user_regs() (&get_cpu_info()->gu

Re: [PATCH v2] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

2022-07-28 Thread Xenia Ragiadakou
On 7/28/22 16:05, Julien Grall wrote: Hi, On 28/07/2022 10:26, Jan Beulich wrote: On 28.07.2022 09:57, Xenia Ragiadakou wrote: --- a/xen/arch/arm/include/asm/current.h +++ b/xen/arch/arm/include/asm/current.h @@ -44,8 +44,11 @@ static inline struct cpu_info *get_cpu_info(void)   #define gues

Re: [PATCH v7] evtchn: convert domain event lock to an r/w one

2022-07-28 Thread Daniel P. Smith
On 7/27/22 11:56, Jan Beulich wrote: Especially for the use in evtchn_move_pirqs() (called when moving a vCPU across pCPU-s) and the ones in EOI handling in PCI pass-through code, serializing perhaps an entire domain isn't helpful when no state (which isn't e.g. further protected by the per-chann

Re: [PATCH] xen/xsm: dummy.h: Fix MISRA C 2012 Directive 4.10 violation

2022-07-28 Thread Daniel P. Smith
On 7/27/22 11:19, Xenia Ragiadakou wrote: Protect header file from being included more than once by adding ifndef guard. Signed-off-by: Xenia Ragiadakou --- xen/include/xsm/dummy.h | 5 + 1 file changed, 5 insertions(+) diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h inde

[PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-28 Thread Xenia Ragiadakou
The macro parameter 'v' is used as an expression and needs to be enclosed in parentheses. Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/include/asm/arm64/sysregs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/incl

Re: Question to mem-path support at QEMU for Xen

2022-07-28 Thread Igor Mammedov
On Thu, 28 Jul 2022 15:17:49 +0800 Huang Rui wrote: > Hi Igor, > > Appreciate you for the reply! > > On Wed, Jul 27, 2022 at 04:19:30PM +0800, Igor Mammedov wrote: > > On Tue, 26 Jul 2022 15:27:07 +0800 > > Huang Rui wrote: > > > > > Hi Anthony and other Qemu/Xen guys, > > > > > > We are t

Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-28 Thread Julien Grall
Hi, On 28/07/2022 14:49, Xenia Ragiadakou wrote: The macro parameter 'v' is used as an expression and needs to be enclosed in parentheses. Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/include/asm/arm64/sysregs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arc

Re: [PATCH V7 09/11] vpci: add initial support for virtual PCI bus topology

2022-07-28 Thread Oleksandr
On 27.07.22 13:32, Jan Beulich wrote: Hello Jan On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: From: Oleksandr Andrushchenko Assign SBDF to the PCI devices being passed through with bus 0. The resulting topology is where PCIe devices reside on the bus 0 of the root complex itself (embe

Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-28 Thread Jan Beulich
On 28.07.2022 15:49, Xenia Ragiadakou wrote: > --- a/xen/arch/arm/include/asm/arm64/sysregs.h > +++ b/xen/arch/arm/include/asm/arm64/sysregs.h > @@ -461,7 +461,7 @@ > /* Access to system registers */ > > #define WRITE_SYSREG64(v, name) do {\ > -uint64_t _r = v;

Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-28 Thread Jan Beulich
On 28.07.2022 15:56, Julien Grall wrote: > On 28/07/2022 14:49, Xenia Ragiadakou wrote: >> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >> @@ -461,7 +461,7 @@ >> /* Access to system registers */ >> >> #define WRITE_SYSREG64(v, name) do {

Re: [PATCH V7 09/11] vpci: add initial support for virtual PCI bus topology

2022-07-28 Thread Jan Beulich
On 28.07.2022 16:16, Oleksandr wrote: > On 27.07.22 13:32, Jan Beulich wrote: >> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> Assign SBDF to the PCI devices being passed through with bus 0. >>> The resulting topology is where PCIe devices reside on the

Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-28 Thread Julien Grall
Hi, On 28/07/2022 15:20, Jan Beulich wrote: On 28.07.2022 15:56, Julien Grall wrote: On 28/07/2022 14:49, Xenia Ragiadakou wrote: --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -461,7 +461,7 @@ /* Access to system registers */ #define

Re: [PATCH V7 09/11] vpci: add initial support for virtual PCI bus topology

2022-07-28 Thread Oleksandr
On 28.07.22 17:26, Jan Beulich wrote: Hello Jan On 28.07.2022 16:16, Oleksandr wrote: On 27.07.22 13:32, Jan Beulich wrote: On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: From: Oleksandr Andrushchenko Assign SBDF to the PCI devices being passed through with bus 0. The resulting topolog

Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-28 Thread Julien Grall
Hi Jan, On 28/07/2022 15:17, Jan Beulich wrote: On 28.07.2022 15:49, Xenia Ragiadakou wrote: --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -461,7 +461,7 @@ /* Access to system registers */ #define WRITE_SYSREG64(v, name) do {

Re: [PATCH V7 03/11] vpci/header: implement guest BAR register handlers

2022-07-28 Thread Oleksandr
On 28.07.22 10:01, Jan Beulich wrote: Hello Jan On 27.07.2022 18:17, Oleksandr wrote: On 27.07.22 13:15, Jan Beulich wrote: On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: @@ -527,6 +592,17 @@ static int cf_check init_bars(struct pci_dev *pdev) if ( (val & PCI_BASE_ADDRESS_SPA

Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-28 Thread Xenia Ragiadakou
Hi Julien, On 7/28/22 16:56, Julien Grall wrote: Hi, On 28/07/2022 14:49, Xenia Ragiadakou wrote: The macro parameter 'v' is used as an expression and needs to be enclosed in parentheses. Signed-off-by: Xenia Ragiadakou ---   xen/arch/arm/include/asm/arm64/sysregs.h | 2 +-   1 file changed,

Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-28 Thread Xenia Ragiadakou
On 7/28/22 17:34, Julien Grall wrote: Hi, On 28/07/2022 15:20, Jan Beulich wrote: On 28.07.2022 15:56, Julien Grall wrote: On 28/07/2022 14:49, Xenia Ragiadakou wrote: --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -461,7 +461,7 @@    /* Acc

[xen-unstable test] 171896: tolerable FAIL

2022-07-28 Thread osstest service owner
flight 171896 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171896/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 171887 test-armhf-armhf-libvirt 16 save

Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-28 Thread Julien Grall
On 28/07/2022 16:15, Xenia Ragiadakou wrote: On 7/28/22 16:56, Julien Grall wrote: Hi, On 28/07/2022 14:49, Xenia Ragiadakou wrote: The macro parameter 'v' is used as an expression and needs to be enclosed in parentheses. Signed-off-by: Xenia Ragiadakou ---   xen/arch/arm/include/asm/arm

Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port

2022-07-28 Thread Rahul Singh
Hi Julien > On 26 Jul 2022, at 6:37 pm, Julien Grall wrote: > > > > On 21/07/2022 16:37, Rahul Singh wrote: >> Hi Julien, > > Hi Rahul, > >>> On 21 Jul 2022, at 2:29 pm, Julien Grall wrote: >>> >>> On 21/07/2022 13:50, Rahul Singh wrote: Hi Julien, >>> >>> Hi Rahul, >>> > On 20

Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port

2022-07-28 Thread Jan Beulich
On 28.07.2022 17:37, Rahul Singh wrote: >> On 26 Jul 2022, at 6:37 pm, Julien Grall wrote: >> On 21/07/2022 16:37, Rahul Singh wrote: >>> Ok. I will not add the warning. Just to confirm again is that okay If I add >>> new command line option "max_event_channels” in >>> next version for dom0 to re

[PATCH v3] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

2022-07-28 Thread Xenia Ragiadakou
The function idle_loop() is referenced only in domain.c. Change its linkage from external to internal by adding the storage-class specifier static to its definitions. Add the function as a 'fake' input operand to the inline assembly statement, to make the compiler aware that the function is used.

Re: [PATCH V7 10/11] xen/arm: translate virtual PCI bus topology for guests

2022-07-28 Thread Oleksandr
On 28.07.22 10:15, Jan Beulich wrote: Hello Jan On 27.07.2022 21:39, Oleksandr wrote: On 27.07.22 20:54, Oleksandr wrote: On 26.07.22 18:16, Jan Beulich wrote: On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: --- a/xen/arch/arm/vpci.c +++ b/xen/arch/arm/vpci.c @@ -41,6 +41,16 @@ static in

Re: [PATCH] arm/domain: fix comment for arch_set_info_guest

2022-07-28 Thread Julien Grall
Hi Luca, On 25/07/2022 15:46, Luca Fancellu wrote: The function arch_set_info_guest is not reached anymore through VCPUOP_initialise on arm, update the comment. Signed-off-by: Luca Fancellu --- xen/arch/arm/domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/x

Re: [PATCH] arm/domain: fix comment for arch_set_info_guest

2022-07-28 Thread Luca Fancellu
> On 28 Jul 2022, at 19:07, Julien Grall wrote: > > Hi Luca, > > On 25/07/2022 15:46, Luca Fancellu wrote: >> The function arch_set_info_guest is not reached anymore through >> VCPUOP_initialise on arm, update the comment. >> Signed-off-by: Luca Fancellu >> --- >> xen/arch/arm/domain.c | 6 ++

Re: [PATCH V11.1 1/3] libxl: Add support for Virtio disk configuration

2022-07-28 Thread Julien Grall
Hi Oleksandr, On 16/07/2022 17:37, Oleksandr Tyshchenko wrote: Changes V10.1 -> V11: - Anthony already gave his Reviewed-by, I dropped it due to the changes - George already gave his Acked-by, I dropped it due to the changes - s/other/standalone for the backendtype As discussed wit

Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE

2022-07-28 Thread Paul E. McKenney
On Mon, Jul 25, 2022 at 12:43:06PM -0700, Michel Lespinasse wrote: > On Wed, Jun 08, 2022 at 04:27:27PM +0200, Peter Zijlstra wrote: > > Commit c227233ad64c ("intel_idle: enable interrupts before C1 on > > Xeons") wrecked intel_idle in two ways: > > > > - must not have tracing in idle functions >

Re: [PATCH V11.1 1/3] libxl: Add support for Virtio disk configuration

2022-07-28 Thread Oleksandr Tyshchenko
чт, 28 июл. 2022 г., 21:28 Julien Grall : > Hi Oleksandr, > Hello Julien (sorry for the possible format issues) > On 16/07/2022 17:37, Oleksandr Tyshchenko wrote: > > Changes V10.1 -> V11: > > - Anthony already gave his Reviewed-by, I dropped it due to the > changes > > - George alrea

RE: Enable audio virtualization in Xen

2022-07-28 Thread SHARMA, JYOTIRMOY
[AMD Official Use Only - General] Hi all, Can anyone please help here? Also, how can I make use of the xen front end drivers in a HVM guest? Regards, Jyotirmoy -Original Message- From: SHARMA, JYOTIRMOY Sent: Tuesday, July 26, 2022 4:27 PM To: Christopher Clark Cc: xen-devel@lists.x

[ovmf test] 171898: all pass - PUSHED

2022-07-28 Thread osstest service owner
flight 171898 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171898/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3eca64f157c340f9bbf552d89a69698a3090c080 baseline version: ovmf 0e7add1d75fc75762208a

Re: [PATCH v4 2/2] xen/arm: add FF-A mediator

2022-07-28 Thread Julien Grall
Hi, On 26/07/2022 07:17, Jens Wiklander wrote: On Fri, Jul 8, 2022 at 3:41 PM Julien Grall wrote: Hi Jens, I haven't checked whether the FFA driver is complaint with the spec. I mainly checked whether the code makes sense from Xen PoV. This is a fairly long patch to review. So I will split

Re: [PATCH v4 2/2] xen/arm: add FF-A mediator

2022-07-28 Thread Julien Grall
Hi, On 27/07/2022 07:33, Jens Wiklander wrote: On Fri, Jul 8, 2022 at 9:54 PM Julien Grall wrote: +unsigned int n; +unsigned int m; +p2m_type_t t; +uint64_t addr; + +for ( n = 0; n < range_count; n++ ) +{ +for ( m = 0; m < range[n].page_count; m++ ) +{ +

[qemu-mainline test] 171897: tolerable FAIL - PUSHED

2022-07-28 Thread osstest service owner
flight 171897 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171897/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds18 guest-start/debian.repeat fail REGR. vs. 171885 Tests which did not succee

Re: [PATCH v1] xen: add late init call in start_xen

2022-07-28 Thread Stefano Stabellini
Hi Boyoun, Thanks for your interest in Xen and thanks for your contribution! On Thu, 28 Jul 2022, Jan Beulich wrote: > On 28.07.2022 11:22, Boyoun Park wrote: > > Hello, > > > > This patch added late_initcall to deal with > > > > some init functions which should be called > > > > after other

Re: Proposal for Porting Xen to Armv8-R64 - DraftC (Archive for Day1)

2022-07-28 Thread Stefano Stabellini
Hi Wei, I am really sorry I didn't manage to read this proposal before now. Too many things :-) Is it still valid? Do you want me to read it in the next days, or do you have another update you would rather send first? Cheers, Stefano On Sun, 8 May 2022, Wei Chen wrote: > # Proposal for Porti

Re: Enable audio virtualization in Xen

2022-07-28 Thread Christopher Clark
On Thu, Jul 28, 2022 at 12:05 PM SHARMA, JYOTIRMOY wrote: > > [AMD Official Use Only - General] > > Hi all, > > Can anyone please help here? Hello I have now been able to reproduce the HVM guest audio failure that you reported, with the same versions of Ubuntu, Xen and Qemu that you indicated. I

Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port

2022-07-28 Thread Julien Grall
Hi Rahul, On 28/07/2022 16:37, Rahul Singh wrote: As you mentioned, if we don’t restrict the number of events channel for the dom0 system will boot slower. This is a good reason to restrict the number of event channels for dom0. Let me start that I am still fine if you want to push for a new p

Re: Question to mem-path support at QEMU for Xen

2022-07-28 Thread Stefano Stabellini
On Thu, 28 Jul 2022, Igor Mammedov wrote: > On Thu, 28 Jul 2022 15:17:49 +0800 > Huang Rui wrote: > > > Hi Igor, > > > > Appreciate you for the reply! > > > > On Wed, Jul 27, 2022 at 04:19:30PM +0800, Igor Mammedov wrote: > > > On Tue, 26 Jul 2022 15:27:07 +0800 > > > Huang Rui wrote: > > >

[xen-unstable-smoke test] 171899: regressions - FAIL

2022-07-28 Thread osstest service owner
flight 171899 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171899/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 171884 Tests which

Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-28 Thread Stefano Stabellini
On Thu, 28 Jul 2022, Julien Grall wrote: > On 28/07/2022 15:20, Jan Beulich wrote: > > On 28.07.2022 15:56, Julien Grall wrote: > > > On 28/07/2022 14:49, Xenia Ragiadakou wrote: > > > > --- a/xen/arch/arm/include/asm/arm64/sysregs.h > > > > +++ b/xen/arch/arm/include/asm/arm64/sysregs.h > > > > @@

Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation

2022-07-28 Thread Stefano Stabellini
On Thu, 28 Jul 2022, Bertrand Marquis wrote: > > On 28 Jul 2022, at 11:21, Julien Grall wrote: > > On 28/07/2022 10:45, Bertrand Marquis wrote: > >>> On 28 Jul 2022, at 10:35, Julien Grall wrote: > >>> On 28/07/2022 08:57, Bertrand Marquis wrote: > Hi Julien, > >>> > >>> Hi Bertrand, > >>>

Re: [PATCH v3] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector

2022-07-28 Thread Boris Ostrovsky
On 7/28/22 8:52 AM, Jane Malalane wrote: +/* + * Setup per-vCPU vector-type callbacks and trick toolstack to think The comment should be adjusted -- no need to mention toolstack now that that code has been factored out. Other than that Reviewed-by: Boris Ostrovsky + * we are enli

Re: [PATCH v3 2/2] automation: arm64: Create a test job for testing static allocation on qemu

2022-07-28 Thread Stefano Stabellini
On Thu, 28 Jul 2022, Xenia Ragiadakou wrote: > Enable CONFIG_STATIC_MEMORY in the existing arm64 build. > > Create a new test job, called qemu-smoke-arm64-gcc-staticmem. > > Adjust qemu-smoke-arm64.sh script to accomodate the static memory test as a > new test variant. The test variant is determi

[PATCH] automation: disable xen,enhanced in qemu-smoke-arm64

2022-07-28 Thread Stefano Stabellini
Disable xen,enhanced because we don't use PV drivers in this test and also because the kernel used for testing is old and unpatched and would break if xen,enhanced is passed. This patch unbreaks gitlab-ci. Signed-off-by: Stefano Stabellini --- automation/scripts/qemu-smoke-arm64.sh | 1 + 1 fil

[xen-unstable-smoke bisection] complete build-amd64-libvirt

2022-07-28 Thread osstest service owner
branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-amd64-libvirt testid libvirt-build Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://

RE: Proposal for Porting Xen to Armv8-R64 - DraftC (Archive for Day1)

2022-07-28 Thread Wei Chen
Hi Stefano, > -Original Message- > From: Stefano Stabellini > Sent: 2022年7月29日 4:14 > To: Wei Chen > Cc: xen-devel@lists.xenproject.org; jul...@xen.org; Stefano Stabellini > ; Bertrand Marquis ; > Penny Zheng > Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftC (Archive for > D

[xen-unstable-smoke test] 171903: regressions - FAIL

2022-07-28 Thread osstest service owner
flight 171903 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171903/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 171884 Tests which

[qemu-mainline test] 171900: tolerable FAIL - PUSHED

2022-07-28 Thread osstest service owner
flight 171900 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171900/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 171897 test-amd64-amd64-xl-qemuu-win7-amd6

[xen-unstable-smoke test] 171911: regressions - FAIL

2022-07-28 Thread osstest service owner
flight 171911 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171911/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 171884 Tests which

Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-28 Thread Xenia Ragiadakou
Hi Stefano, On 7/29/22 01:56, Stefano Stabellini wrote: On Thu, 28 Jul 2022, Julien Grall wrote: On 28/07/2022 15:20, Jan Beulich wrote: On 28.07.2022 15:56, Julien Grall wrote: On 28/07/2022 14:49, Xenia Ragiadakou wrote: --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/inc

Re: [PATCH V7 10/11] xen/arm: translate virtual PCI bus topology for guests

2022-07-28 Thread Jan Beulich
On 28.07.2022 18:35, Oleksandr wrote: > On 28.07.22 10:15, Jan Beulich wrote: >> On 27.07.2022 21:39, Oleksandr wrote: >>> On 27.07.22 20:54, Oleksandr wrote: On 26.07.22 18:16, Jan Beulich wrote: > On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >> --- a/xen/arch/arm/vpci.c >> ++

Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation

2022-07-28 Thread Jan Beulich
On 29.07.2022 07:23, Xenia Ragiadakou wrote: > Hi Stefano, > > On 7/29/22 01:56, Stefano Stabellini wrote: >> On Thu, 28 Jul 2022, Julien Grall wrote: >>> On 28/07/2022 15:20, Jan Beulich wrote: On 28.07.2022 15:56, Julien Grall wrote: > On 28/07/2022 14:49, Xenia Ragiadakou wrote: >>

Re: [xen-unstable-smoke bisection] complete build-amd64-libvirt

2022-07-28 Thread Jan Beulich
On 29.07.2022 03:04, osstest service owner wrote: > branch xen-unstable-smoke > xenbranch xen-unstable-smoke > job build-amd64-libvirt > testid libvirt-build > > Tree: libvirt git://xenbits.xen.org/libvirt.git > Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git > Tree: qemu

Re: [PATCH v3] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

2022-07-28 Thread Jan Beulich
On 28.07.2022 18:21, Xenia Ragiadakou wrote: > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -63,7 +63,7 @@ static void do_idle(void) > rcu_idle_exit(cpu); > } > > -void idle_loop(void) > +static void idle_loop(void) While you're adding "noreturn" below, shouldn't this one

Re: [PATCH v3] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

2022-07-28 Thread Xenia Ragiadakou
Hi Jan, On 7/29/22 09:26, Jan Beulich wrote: On 28.07.2022 18:21, Xenia Ragiadakou wrote: --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -63,7 +63,7 @@ static void do_idle(void) rcu_idle_exit(cpu); } -void idle_loop(void) +static void idle_loop(void) While you're addin

[linux-linus test] 171901: trouble: broken/fail/pass

2022-07-28 Thread osstest service owner
flight 171901 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171901/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-amd64 broken test-amd64

Re: [xen-unstable-smoke bisection] complete build-amd64-libvirt

2022-07-28 Thread Oleksandr Tyshchenko
On 29.07.22 09:22, Jan Beulich wrote: Hello Jan > On 29.07.2022 03:04, osstest service owner wrote: >> branch xen-unstable-smoke >> xenbranch xen-unstable-smoke >> job build-amd64-libvirt >> testid libvirt-build >> >> Tree: libvirt git://xenbits.xen.org/libvirt.git >> Tree: libvirt_keycodemapdb