[PATCH v2 3/9] xen/arm: allocate static shared memory to a specific owner domain

2022-05-06 Thread Penny Zheng
If owner property is defined, then owner domain of a static shared memory region is not the default dom_io anymore, but a specific domain. This commit implements allocating static shared memory to a specific domain when owner property is defined. Coding flow for dealing borrower domain will be in

[PATCH v2 1/9] xen/arm: introduce static shared memory

2022-05-06 Thread Penny Zheng
From: Penny Zheng This patch serie introduces a new feature: setting up static shared memory on a dom0less system, through device tree configuration. This commit parses shared memory node at boot-time, and reserve it in bootinfo.reserved_mem to avoid other use. This commits proposes a new Kconf

[PATCH v2 0/9] static shared memory on dom0less system

2022-05-06 Thread Penny Zheng
In safety-critical environment, it is not considered safe to dynamically change important configurations at runtime. Everything should be statically defined and statically verified. In this case, if the system configuration knows a priori that there are only 2 VMs and they need to communicate over

[PATCH v2 2/9] xen/arm: allocate static shared memory to the default owner dom_io

2022-05-06 Thread Penny Zheng
From: Penny Zheng This commit introduces process_shm to cope with static shared memory in domain construction. DOMID_IO will be the default owner of memory pre-shared among multiple domains at boot time, when no explicit owner is specified. This commit only considers allocating static shared me

[PATCH v2 5/9] xen/arm: Add additional reference to owner domain when the owner is allocated

2022-05-06 Thread Penny Zheng
Borrower domain will fail to get a page ref using the owner domain during allocation, when the owner is created after borrower. So here, we decide to get and add the right amount of reference, which is the number of borrowers, when the owner is allocated. Signed-off-by: Penny Zheng --- v2 change

[PATCH v2 4/9] xen/arm: introduce put_page_nr and get_page_nr

2022-05-06 Thread Penny Zheng
Later, we need to add the right amount of references, which should be the number of borrower domains, to the owner domain. Since we only have get_page() to increment the page reference by 1, a loop is needed per page, which is inefficient and time-consuming. To save the loop time, this commit intr

[PATCH v2 6/9] xen/arm: add P2M type parameter in guest_physmap_add_pages

2022-05-06 Thread Penny Zheng
In order to cover the scenario where users intend to set up guest p2m foreign mapping with nr_pages, this commit adds a new P2M type parameter in guest_physmap_add_pages. Signed-off-by: Penny Zheng --- v2 change: - no change --- xen/arch/arm/domain_build.c| 5 +++-- xen/arch/arm/include/asm/

[PATCH v2 7/9] xen/arm: set up shared memory foreign mapping for borrower domain

2022-05-06 Thread Penny Zheng
This commit sets up shared memory foreign mapping for borrower domain. If owner domain is the default dom_io, all shared domain are treated as borrower domain. Signed-off-by: Penny Zheng --- v2 change: - remove guest_physmap_add_shm, since for borrower domain, we only do P2M foreign memory mappi

[PATCH v2 9/9] xen/arm: enable statically shared memory on Dom0

2022-05-06 Thread Penny Zheng
From: Penny Zheng To add statically shared memory nodes in Dom0, user shall put according static shared memory configuration under /chosen node. This commit adds shm-processing function process_shm in construct_dom0 to enable statically shared memory on Dom0. Signed-off-by: Penny Zheng --- v2

[PATCH v2 8/9] xen/arm: create shared memory nodes in guest device tree

2022-05-06 Thread Penny Zheng
We expose the shared memory to the domU using the "xen,shared-memory-v1" reserved-memory binding. See Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt in Linux for the corresponding device tree binding. To save the cost of re-parsing shared memory device tree configuration w

[ovmf test] 170174: regressions - FAIL

2022-05-06 Thread osstest service owner
flight 170174 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170174/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping*

2022-05-06 Thread Michal Orzel
On 05.05.2022 13:13, Jan Beulich wrote: > On 05.05.2022 12:36, Michal Orzel wrote: >> --- a/xen/arch/arm/include/asm/grant_table.h >> +++ b/xen/arch/arm/include/asm/grant_table.h >> @@ -29,12 +29,21 @@ static inline void gnttab_mark_dirty(struct domain *d, >> mfn_t mfn) >> #endif >> } >> >>

RE: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap

2022-05-06 Thread Penny Zheng
Hi jan and julien > -Original Message- > From: Jan Beulich > Sent: Friday, May 6, 2022 2:14 PM > To: Penny Zheng > Cc: Wei Chen ; Henry Wang ; > Andrew Cooper ; George Dunlap > ; Julien Grall ; Stefano Stabellini > ; Wei Liu ; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH v3 6/

[ovmf test] 170175: regressions - FAIL

2022-05-06 Thread osstest service owner
flight 170175 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170175/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH v4 12/21] IOMMU: fold flush-all hook into "flush one"

2022-05-06 Thread Roger Pau Monné
On Mon, Apr 25, 2022 at 10:40:06AM +0200, Jan Beulich wrote: > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -772,18 +772,21 @@ static int __must_check cf_check iommu_f > struct domain *d, dfn_t dfn, unsigned long page_count, > unsigned int flu

[ovmf test] 170177: regressions - FAIL

2022-05-06 Thread osstest service owner
flight 170177 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170177/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[PATCH v2 0/2] xen/arm: gnttab: macros modifications

2022-05-06 Thread Michal Orzel
This patch series modifies macros inside xen/arch/arm/include/asm/grant_table.h to be resistant to static analyzer/compiler warnings about unused-but-set variables. The first patch acts as a fix for a gcc warning when -Wunused-but-set-variable flag is enabled by converting the macro to static inli

[PATCH v2 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping*

2022-05-06 Thread Michal Orzel
Function unmap_common_complete (common/grant_table.c) defines and sets a variable ld that is later on passed to a macro: gnttab_host_mapping_get_page_type(). On Arm this macro does not make use of any arguments causing a compiler to warn about unused-but-set variable (when -Wunused-but-set-variable

[PATCH v2 2/2] xen/arm: gnttab: modify macros to evaluate all arguments and only once

2022-05-06 Thread Michal Orzel
Modify macros to evaluate all the arguments and make sure the arguments are evaluated only once. Introduce following intermediate macros: gnttab_status_gfn_, gnttab_shared_gfn_ that do not take domain as a parameter. These are to be used locally and allow us to avoid passing NULL from gnttab_get_fr

[xen-unstable test] 170164: tolerable FAIL - PUSHED

2022-05-06 Thread osstest service owner
flight 170164 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170164/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 170152 test-armhf-armhf-libvirt 16 save

Re: [PATCH 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping*

2022-05-06 Thread Julien Grall
On 06/05/2022 08:27, Michal Orzel wrote: On 05.05.2022 13:13, Jan Beulich wrote: On 05.05.2022 12:36, Michal Orzel wrote: --- a/xen/arch/arm/include/asm/grant_table.h +++ b/xen/arch/arm/include/asm/grant_table.h @@ -29,12 +29,21 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_

Re: [PATCH 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping*

2022-05-06 Thread Jan Beulich
On 06.05.2022 09:27, Michal Orzel wrote: > > > On 05.05.2022 13:13, Jan Beulich wrote: >> On 05.05.2022 12:36, Michal Orzel wrote: >>> --- a/xen/arch/arm/include/asm/grant_table.h >>> +++ b/xen/arch/arm/include/asm/grant_table.h >>> @@ -29,12 +29,21 @@ static inline void gnttab_mark_dirty(struct

Re: [PATCH v4 12/21] IOMMU: fold flush-all hook into "flush one"

2022-05-06 Thread Jan Beulich
On 06.05.2022 10:38, Roger Pau Monné wrote: > On Mon, Apr 25, 2022 at 10:40:06AM +0200, Jan Beulich wrote: >> --- a/xen/drivers/passthrough/vtd/iommu.c >> +++ b/xen/drivers/passthrough/vtd/iommu.c >> @@ -772,18 +772,21 @@ static int __must_check cf_check iommu_f >> struct domain *d, dfn_t dfn,

[ovmf test] 170178: regressions - FAIL

2022-05-06 Thread osstest service owner
flight 170178 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170178/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping*

2022-05-06 Thread Michal Orzel
On 06.05.2022 11:56, Julien Grall wrote: > > > On 06/05/2022 08:27, Michal Orzel wrote: >> On 05.05.2022 13:13, Jan Beulich wrote: >>> On 05.05.2022 12:36, Michal Orzel wrote: --- a/xen/arch/arm/include/asm/grant_table.h +++ b/xen/arch/arm/include/asm/grant_table.h @@ -29,12 +29

Re: [PATCH v2 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping*

2022-05-06 Thread Jan Beulich
On 06.05.2022 11:42, Michal Orzel wrote: > Function unmap_common_complete (common/grant_table.c) defines and sets > a variable ld that is later on passed to a macro: > gnttab_host_mapping_get_page_type(). > On Arm this macro does not make use of any arguments causing a compiler > to warn about unus

Re: [PATCH v2 2/9] xen/arm: allocate static shared memory to the default owner dom_io

2022-05-06 Thread Jan Beulich
On 06.05.2022 09:24, Penny Zheng wrote: > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -777,8 +777,22 @@ void __init setup_system_domains(void) > > /* > * Initialise our DOMID_IO domain. > - * This domain owns I/O pages that are within the range of the page_info > -

[qemu-mainline test] 170162: tolerable FAIL - PUSHED

2022-05-06 Thread osstest service owner
flight 170162 qemu-mainline real [real] flight 170176 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170162/ http://logs.test-lab.xenproject.org/osstest/logs/170176/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-am

Re: [PATCH] build/xen: fix symbol generation with LLVM LD

2022-05-06 Thread Jan Beulich
On 05.05.2022 16:21, Roger Pau Monne wrote: > Current LLVM LD implementation will turn global hidden symbols in > object files into local ones when generating the .symtab of the Xen > binary image. > > This is different from GNU ld implementation, that will only do the > conversion (or remove the

Re: [PATCH v2 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc()

2022-05-06 Thread Jan Beulich
On 06.05.2022 07:52, Henry Wang wrote: > --- a/xen/common/xmalloc_tlsf.c > +++ b/xen/common/xmalloc_tlsf.c > @@ -594,7 +594,7 @@ void *_xmalloc(unsigned long size, unsigned long align) > { > void *p = NULL; > > -ASSERT(!in_irq()); > +ASSERT_ALLOC_CONTEXT(); For one - what about xfr

Re: [PATCH v4] Preserve the EFI System Resource Table for dom0

2022-05-06 Thread Jan Beulich
On 05.05.2022 07:38, Demi Marie Obenour wrote: > @@ -1056,13 +1091,11 @@ static void __init efi_exit_boot(EFI_HANDLE > ImageHandle, EFI_SYSTEM_TABLE *Syste > EFI_STATUS status; > UINTN info_size = 0, map_key; > bool retry; > -#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP > unsigned

[libvirt test] 170168: regressions - FAIL

2022-05-06 Thread osstest service owner
flight 170168 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170168/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-i386-libvirt

[ovmf test] 170180: regressions - FAIL

2022-05-06 Thread osstest service owner
flight 170180 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170180/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH v4 13/21] IOMMU/x86: prefill newly allocate page tables

2022-05-06 Thread Roger Pau Monné
On Mon, Apr 25, 2022 at 10:40:55AM +0200, Jan Beulich wrote: > Page tables are used for two purposes after allocation: They either > start out all empty, or they get filled to replace a superpage. > Subsequently, to replace all empty or fully contiguous page tables, > contiguous sub-regions will be

RE: [PATCH 02/32] Introduce flexible array struct memcpy() helpers

2022-05-06 Thread David Laight
From: Johannes Berg > Sent: 05 May 2022 21:13 > On Thu, 2022-05-05 at 13:08 -0700, Keith Packard wrote: > > > > I bet you've already considered the simpler form: > > > > struct something *instance = mem_to_flex_dup(byte_array, count, > > GFP_KERNEL); > > if (IS_ERR(instance)) > >

Re: [PATCH v8 0/7] Boot time cpupools

2022-05-06 Thread Luca Fancellu
> The example DT is instructing Xen to have two cpu pools, one having two > phisical > cpus and the one having 4 phisical cpus, the last mentioned cpu pool uses the > null scheduler and from the /chosen node we can see that a dom0less guest will > be started on that cpu pool. > > In this partic

Re: [PATCH v2] arm/its: enable LPIs before mapping the collection table

2022-05-06 Thread Bertrand Marquis
Hi Rahul, > On 4 May 2022, at 18:15, Rahul Singh wrote: > > When Xen boots on the platform that implements the GIC 600, ITS > MAPC_LPI_OFF uncorrectable command error issue is observed. > > As per the GIC-600 TRM (Revision: r1p6) MAPC_LPI_OFF command error can > be reported if the MAPC command

Re: [PATCH v8 0/7] Boot time cpupools

2022-05-06 Thread Julien Grall
Hi Luca, On 06/05/2022 12:25, Luca Fancellu wrote: The example DT is instructing Xen to have two cpu pools, one having two phisical cpus and the one having 4 phisical cpus, the last mentioned cpu pool uses the null scheduler and from the /chosen node we can see that a dom0less guest will be st

Re: [PATCH v8 0/7] Boot time cpupools

2022-05-06 Thread Luca Fancellu
>>> >>> Luca Fancellu (7): >>> tools/cpupools: Give a name to unnamed cpupools >>> xen/sched: create public function for cpupools creation >>> xen/sched: retrieve scheduler id by name >>> xen/cpupool: Create different cpupools at boot time >>> xen/cpupool: Don't allow removing cpu0 from cpupool0 >

Re: [PATCH v4] Preserve the EFI System Resource Table for dom0

2022-05-06 Thread Jan Beulich
On 06.05.2022 12:59, Jan Beulich wrote: > On 05.05.2022 07:38, Demi Marie Obenour wrote: >> @@ -1077,6 +1110,35 @@ static void __init efi_exit_boot(EFI_HANDLE >> ImageHandle, EFI_SYSTEM_TABLE *Syste >> if ( EFI_ERROR(status) ) >> PrintErrMesg(L"Cannot obtain memory map", stat

[PATCH v8 0/7] Boot time cpupools

2022-05-06 Thread Luca Fancellu
*** Resending the serie adding the maintainers *** *** Patches #4 and #6 needs a review from the maintainer of that area *** This serie introduces a feature for Xen to create cpu pools at boot time, the feature is enabled using a configurable that is disabled by default. The boot time cpupool feat

[PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools

2022-05-06 Thread Luca Fancellu
Introduce domain-cpupool property of a xen,domain device tree node, that specifies the cpupool device tree handle of a xen,cpupool node that identifies a cpupool created at boot time where the guest will be assigned on creation. Add member to the xen_domctl_createdomain public interface so the XEN

[PATCH v8 1/7] tools/cpupools: Give a name to unnamed cpupools

2022-05-06 Thread Luca Fancellu
With the introduction of boot time cpupools, Xen can create many different cpupools at boot time other than cpupool with id 0. Since these newly created cpupools can't have an entry in Xenstore, create the entry using xen-init-dom0 helper with the usual convention: Pool-. Given the change, remove

[PATCH v8 2/7] xen/sched: create public function for cpupools creation

2022-05-06 Thread Luca Fancellu
Create new public function to create cpupools, can take as parameter the scheduler id or a negative value that means the default Xen scheduler will be used. Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v8: - no changes Changes in v7: - no changes Changes in v6: - add R-

[PATCH v8 4/7] xen/cpupool: Create different cpupools at boot time

2022-05-06 Thread Luca Fancellu
Introduce a way to create different cpupools at boot time, this is particularly useful on ARM big.LITTLE system where there might be the need to have different cpupools for each type of core, but also systems using NUMA can have different cpu pools for each node. The feature on arm relies on a spe

[PATCH v8 7/7] xen/cpupool: Allow cpupool0 to use different scheduler

2022-05-06 Thread Luca Fancellu
Currently cpupool0 can use only the default scheduler, and cpupool_create has an hardcoded behavior when creating the pool 0 that doesn't allocate new memory for the scheduler, but uses the default scheduler structure in memory. With this commit it is possible to allocate a different scheduler for

[PATCH v8 5/7] xen/cpupool: Don't allow removing cpu0 from cpupool0

2022-05-06 Thread Luca Fancellu
Cpu0 must remain in cpupool0, otherwise some operations like moving cpus between cpupools, cpu hotplug, destroying cpupools, shutdown of the host, might not work in a sane way. Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v8: - Add R-by (Juergen) Changes in v7: - new pa

[PATCH v8 3/7] xen/sched: retrieve scheduler id by name

2022-05-06 Thread Luca Fancellu
Add a static function to retrieve the scheduler pointer using the scheduler name. Add a public function to retrieve the scheduler id by the scheduler name that makes use of the new static function. Take the occasion to replace open coded scheduler search with the new static function in scheduler_

RE: [PATCH v2 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc()

2022-05-06 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Sent: Friday, May 6, 2022 6:33 PM > To: Henry Wang > Cc: Stefano Stabellini ; Julien Grall > ; > Bertrand Marquis ; Volodymyr Babchuk > ; Andrew Cooper > ; George Dunlap ; > Wei Liu ; Wei Chen ; Julien Grall > ; xen-devel@lists.xenproje

Re: [PATCH v5 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests

2022-05-06 Thread Jan Beulich
On 03.05.2022 10:26, Roger Pau Monne wrote: > --- a/xen/arch/x86/cpuid.c > +++ b/xen/arch/x86/cpuid.c > @@ -541,6 +541,9 @@ static void __init calculate_hvm_max_policy(void) > raw_cpuid_policy.basic.sep ) > __set_bit(X86_FEATURE_SEP, hvm_featureset); > > +if ( boot_cpu_has(

Re: [PATCH v2 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc()

2022-05-06 Thread Jan Beulich
On 06.05.2022 14:03, Henry Wang wrote: >> -Original Message- >> From: Jan Beulich >> Sent: Friday, May 6, 2022 6:33 PM >> >> On 06.05.2022 07:52, Henry Wang wrote: >>> --- a/xen/common/xmalloc_tlsf.c >>> +++ b/xen/common/xmalloc_tlsf.c >>> @@ -594,7 +594,7 @@ void *_xmalloc(unsigned long s

RE: [PATCH v2 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc()

2022-05-06 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > > On 06.05.2022 14:03, Henry Wang wrote: > >> -Original Message- > >> From: Jan Beulich > >> Sent: Friday, May 6, 2022 6:33 PM > >> > >> On 06.05.2022 07:52, Henry Wang wrote: > >>> --- a/xen/common/xmalloc_tlsf.c > >>> +++ b/xe

Re: [PATCH v5 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD

2022-05-06 Thread Jan Beulich
On 03.05.2022 10:26, Roger Pau Monne wrote: > Expose VIRT_SSBD to guests if the hardware supports setting SSBD in > the LS_CFG MSR (a.k.a. non-architectural way). Different AMD CPU > families use different bits in LS_CFG, so exposing VIRT_SPEC_CTRL.SSBD > allows for an unified way of exposing SSBD

[ovmf test] 170182: regressions - FAIL

2022-05-06 Thread osstest service owner
flight 170182 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170182/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH] MAINTAINERS: add myself as reviewer for IOMMU vendor independent code

2022-05-06 Thread Jan Beulich
On 05.05.2022 17:15, Jan Beulich wrote: > On 05.05.2022 17:04, Roger Pau Monne wrote: >> That also covers the PCI bits which I'm interested on. >> >> Signed-off-by: Roger Pau Monné > > Acked-by: Jan Beulich > > And thanks for volunteering. Or should I have said thanks for formalizing what you

Re: [PATCH] build/xen: fix symbol generation with LLVM LD

2022-05-06 Thread Jan Beulich
On 05.05.2022 16:21, Roger Pau Monne wrote: > --- a/xen/include/xen/compiler.h > +++ b/xen/include/xen/compiler.h > @@ -125,10 +125,11 @@ > #define __must_be_array(a) \ >BUILD_BUG_ON_ZERO(__builtin_types_compatible_p(typeof(a), typeof(&a[0]))) > > -#ifdef CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE >

Re: [PATCH 07/11] dasd: don't set the discard_alignment queue limit

2022-05-06 Thread Jan Höppner
On 18/04/2022 06:53, Christoph Hellwig wrote: > The discard_alignment queue limit is named a bit misleading means the > offset into the block device at which the discard granularity starts. > Setting it to PAGE_SIZE while the discard granularity is the block size > that is smaller or the same as PA

Re: [PATCH v8 4/7] xen/cpupool: Create different cpupools at boot time

2022-05-06 Thread Juergen Gross
On 06.05.22 14:00, Luca Fancellu wrote: Introduce a way to create different cpupools at boot time, this is particularly useful on ARM big.LITTLE system where there might be the need to have different cpupools for each type of core, but also systems using NUMA can have different cpu pools for each

Re: [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools

2022-05-06 Thread Juergen Gross
On 06.05.22 14:00, Luca Fancellu wrote: Introduce domain-cpupool property of a xen,domain device tree node, that specifies the cpupool device tree handle of a xen,cpupool node that identifies a cpupool created at boot time where the guest will be assigned on creation. Add member to the xen_domct

Re: [PATCH v4 14/21] x86: introduce helper for recording degree of contiguity in page tables

2022-05-06 Thread Roger Pau Monné
On Mon, Apr 25, 2022 at 10:41:23AM +0200, Jan Beulich wrote: > This is a re-usable helper (kind of a template) which gets introduced > without users so that the individual subsequent patches introducing such > users can get committed independently of one another. > > See the comment at the top of

Re: [PATCH] build/xen: fix symbol generation with LLVM LD

2022-05-06 Thread Roger Pau Monné
On Fri, May 06, 2022 at 02:56:56PM +0200, Jan Beulich wrote: > On 05.05.2022 16:21, Roger Pau Monne wrote: > > --- a/xen/include/xen/compiler.h > > +++ b/xen/include/xen/compiler.h > > @@ -125,10 +125,11 @@ > > #define __must_be_array(a) \ > >BUILD_BUG_ON_ZERO(__builtin_types_compatible_p(type

[PATCH 0/2] build: deal with future GNU ld warnings

2022-05-06 Thread Jan Beulich
1: suppress future GNU ld warning about RWX load segments 2: silence future GNU ld warning about executable stacks Jan

[PATCH 1/2] build: suppress future GNU ld warning about RWX load segments

2022-05-06 Thread Jan Beulich
We cannot really avoid such and we're also not really at risk because of them, as we control page table permissions ourselves rather than relying on a loader of some sort. Signed-off-by: Jan Beulich --- a/xen/Makefile +++ b/xen/Makefile @@ -397,6 +397,8 @@ endif AFLAGS += -D__ASSEMBLY__ +LD

[PATCH 2/2] build: silence future GNU ld warning about executable stacks

2022-05-06 Thread Jan Beulich
While for C files the compiler is supposed to arrange for emitting respective information, for assembly sources we're responsible ourselves. Signed-off-by: Jan Beulich --- a/xen/Makefile +++ b/xen/Makefile @@ -397,6 +397,8 @@ endif AFLAGS += -D__ASSEMBLY__ +$(call cc-option-add,AFLAGS,CC,-W

Re: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments

2022-05-06 Thread Julien Grall
Hi, You say future, has this option been merged or still in discussion on the ML? On 06/05/2022 14:37, Jan Beulich wrote: We cannot really avoid such and we're also not really at risk because of them, as we control page table permissions ourselves rather than relying on a loader of some sort.

Re: [PATCH 2/2] build: silence future GNU ld warning about executable stacks

2022-05-06 Thread Julien Grall
Hi, You say future, has this option been merged or still in discussion on the ML? On 06/05/2022 14:38, Jan Beulich wrote: While for C files the compiler is supposed to arrange for emitting respective information, for assembly sources we're responsible ourselves. Is this a preventive measure

Re: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments

2022-05-06 Thread Jan Beulich
On 06.05.2022 15:43, Julien Grall wrote: > You say future, has this option been merged or still in discussion on > the ML? "future" as in "no released version yet". The change is present on the binutils master branch. > On 06/05/2022 14:37, Jan Beulich wrote: >> We cannot really avoid such and w

Re: [PATCH 2/2] build: silence future GNU ld warning about executable stacks

2022-05-06 Thread Jan Beulich
On 06.05.2022 15:44, Julien Grall wrote: > You say future, has this option been merged or still in discussion on > the ML? > > On 06/05/2022 14:38, Jan Beulich wrote: >> While for C files the compiler is supposed to arrange for emitting >> respective information, for assembly sources we're respon

Re: [PATCH] xen: io: Fix race between sending an I/O and domain shutdown

2022-05-06 Thread Durrant, Paul
On 05/05/2022 18:51, Julien Grall wrote: From: Julien Grall Xen provides hypercalls to shutdown (SCHEDOP_shutdown{,_code}) and resume a domain (XEN_DOMCTL_resumedomain). They can be used for checkpoint where the expectation is the domain should continue as nothing happened afterwards. hvmemul_

Re: [PATCH v7 04/20] kernel: Add combined power-off+restart handler call chain API

2022-05-06 Thread Dmitry Osipenko
On 4/20/22 21:47, Rafael J. Wysocki wrote: + POWEROFF_PREPARE, +}; + +/** + * struct power_off_data - Power-off callback argument + * + * @cb_data: Callback data. + */ +struct power_off_data { + void *cb_data; +}; + +/** >

Re: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments

2022-05-06 Thread Andrew Cooper
On 06/05/2022 14:46, Jan Beulich wrote: > On 06.05.2022 15:43, Julien Grall wrote: >> You say future, has this option been merged or still in discussion on >> the ML? > "future" as in "no released version yet". The change is present on the > binutils master branch. In which case, I'd recommend sa

Re: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments

2022-05-06 Thread Andrew Cooper
On 06/05/2022 15:18, Andrew Cooper wrote: > On 06/05/2022 14:46, Jan Beulich wrote: >> On 06.05.2022 15:43, Julien Grall wrote: >>> You say future, has this option been merged or still in discussion on >>> the ML? >> "future" as in "no released version yet". The change is present on the >> binutil

Re: [PATCH v7 04/20] kernel: Add combined power-off+restart handler call chain API

2022-05-06 Thread Dmitry Osipenko
On 4/20/22 21:47, Rafael J. Wysocki wrote: +/** + * devm_register_prioritized_power_off_handler - Register prioritized power-off callback + * @dev: Device that registers callback + * @priority: Callback's priority + * @callback: Callback function

Re: [PATCH v7 04/20] kernel: Add combined power-off+restart handler call chain API

2022-05-06 Thread Dmitry Osipenko
On 4/20/22 21:47, Rafael J. Wysocki wrote: + void (*platform_power_off_cb)(void); + void (*simple_power_off_cb)(void *data); + void *simple_power_off_cb_data; >>> Is there any particular reason to put these callbacks here and not >>> directly into struct sys_off_han

Re: [PATCH v7 04/20] kernel: Add combined power-off+restart handler call chain API

2022-05-06 Thread Dmitry Osipenko
On 4/20/22 21:47, Rafael J. Wysocki wrote: + spin_unlock(&platform_power_off_lock); + + if (ret) + return ret; + + ret = register_power_off_handler(&priv->power_off_nb); + if (ret) + priv->platform_power_off

Re: [PATCH] build/xen: fix symbol generation with LLVM LD

2022-05-06 Thread Roger Pau Monné
On Fri, May 06, 2022 at 03:31:12PM +0200, Roger Pau Monné wrote: > On Fri, May 06, 2022 at 02:56:56PM +0200, Jan Beulich wrote: > > On 05.05.2022 16:21, Roger Pau Monne wrote: > > > --- a/xen/include/xen/compiler.h > > > +++ b/xen/include/xen/compiler.h > > > @@ -125,10 +125,11 @@ > > > #define __

Re: [PATCH] xen: io: Fix race between sending an I/O and domain shutdown

2022-05-06 Thread Julien Grall
Hi, On 06/05/2022 15:09, Durrant, Paul wrote: On 05/05/2022 18:51, Julien Grall wrote: From: Julien Grall Xen provides hypercalls to shutdown (SCHEDOP_shutdown{,_code}) and resume a domain (XEN_DOMCTL_resumedomain). They can be used for checkpoint where the expectation is the domain should

ECLAIR Xen x86 results and progress

2022-05-06 Thread Stefano Stabellini
Hi all, Roberto kindly provided the ECLAIR x86 results: https://eclairit.com:8443/job/XEN/Target=X86_64,agent=public/lastSuccessfulBuild/eclair/ Click on "See ECLAIR in action", then you can select "Show 100 entries" and see all the results in one page. As an example MC3R1.R1.3 corresponds to Ru

[ovmf test] 170184: regressions - FAIL

2022-05-06 Thread osstest service owner
flight 170184 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170184/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[xen-unstable-smoke test] 170183: tolerable all pass - PUSHED

2022-05-06 Thread osstest service owner
flight 170183 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170183/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[ovmf test] 170185: regressions - FAIL

2022-05-06 Thread osstest service owner
flight 170185 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170185/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH v8 4/7] xen/cpupool: Create different cpupools at boot time

2022-05-06 Thread Stefano Stabellini
On Fri, 6 May 2022, Juergen Gross wrote: > On 06.05.22 14:00, Luca Fancellu wrote: > > Introduce a way to create different cpupools at boot time, this is > > particularly useful on ARM big.LITTLE system where there might be the > > need to have different cpupools for each type of core, but also > >

[ovmf test] 170187: regressions - FAIL

2022-05-06 Thread osstest service owner
flight 170187 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170187/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[linux-linus test] 170173: tolerable FAIL - PUSHED

2022-05-06 Thread osstest service owner
flight 170173 linux-linus real [real] flight 170188 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170173/ http://logs.test-lab.xenproject.org/osstest/logs/170188/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-

[ovmf test] 170189: regressions - FAIL

2022-05-06 Thread osstest service owner
flight 170189 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170189/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[xen-unstable test] 170179: tolerable FAIL

2022-05-06 Thread osstest service owner
flight 170179 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170179/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 22 guests-nbd-mirror/debian fail pass in 170164 test-amd64-coresched-i386-xl 22

[ovmf test] 170191: regressions - FAIL

2022-05-06 Thread osstest service owner
flight 170191 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170191/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[xen-unstable-smoke test] 170186: tolerable all pass - PUSHED

2022-05-06 Thread osstest service owner
flight 170186 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170186/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[ovmf test] 170193: regressions - FAIL

2022-05-06 Thread osstest service owner
flight 170193 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170193/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[ovmf test] 170194: regressions - FAIL

2022-05-06 Thread osstest service owner
flight 170194 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170194/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: ECLAIR Xen x86 results and progress

2022-05-06 Thread Stefano Stabellini
On Fri, 6 May 2022, Andrew Cooper wrote: > On 06/05/2022 17:31, Stefano Stabellini wrote: > > Hi all, > > > > Roberto kindly provided the ECLAIR x86 results: > > > > https://eclairit.com:8443/job/XEN/Target=X86_64,agent=public/lastSuccessfulBuild/eclair/ > > > > Click on "See ECLAIR in action", the

[qemu-mainline test] 170181: tolerable FAIL - PUSHED

2022-05-06 Thread osstest service owner
flight 170181 qemu-mainline real [real] flight 170195 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170181/ http://logs.test-lab.xenproject.org/osstest/logs/170195/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-am

Re: [PATCH v2 1/9] xen/arm: introduce static shared memory

2022-05-06 Thread Stefano Stabellini
On Fri, 6 May 2022, Penny Zheng wrote: > From: Penny Zheng > > This patch serie introduces a new feature: setting up static > shared memory on a dom0less system, through device tree configuration. > > This commit parses shared memory node at boot-time, and reserve it in > bootinfo.reserved_mem t

Re: [PATCH v2 2/9] xen/arm: allocate static shared memory to the default owner dom_io

2022-05-06 Thread Stefano Stabellini
On Fri, 6 May 2022, Penny Zheng wrote: > From: Penny Zheng > > This commit introduces process_shm to cope with static shared memory in > domain construction. > > DOMID_IO will be the default owner of memory pre-shared among multiple domains > at boot time, when no explicit owner is specified. >

Re: [PATCH v2 3/9] xen/arm: allocate static shared memory to a specific owner domain

2022-05-06 Thread Stefano Stabellini
On Fri, 6 May 2022, Penny Zheng wrote: > If owner property is defined, then owner domain of a static shared memory > region is not the default dom_io anymore, but a specific domain. > > This commit implements allocating static shared memory to a specific domain > when owner property is defined. >

Re: [PATCH v2 5/9] xen/arm: Add additional reference to owner domain when the owner is allocated

2022-05-06 Thread Stefano Stabellini
On Fri, 6 May 2022, Penny Zheng wrote: > Borrower domain will fail to get a page ref using the owner domain > during allocation, when the owner is created after borrower. > > So here, we decide to get and add the right amount of reference, which > is the number of borrowers, when the owner is allo

Re: [PATCH v2 4/9] xen/arm: introduce put_page_nr and get_page_nr

2022-05-06 Thread Stefano Stabellini
On Fri, 6 May 2022, Penny Zheng wrote: > Later, we need to add the right amount of references, which should be > the number of borrower domains, to the owner domain. Since we only have > get_page() to increment the page reference by 1, a loop is needed per > page, which is inefficient and time-cons

Re: [PATCH v2 6/9] xen/arm: add P2M type parameter in guest_physmap_add_pages

2022-05-06 Thread Stefano Stabellini
On Fri, 6 May 2022, Penny Zheng wrote: > In order to cover the scenario where users intend to set up guest > p2m foreign mapping with nr_pages, this commit adds a new P2M type > parameter in guest_physmap_add_pages. > > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini > --- > v2 cha

[linux-linus test] 170190: tolerable FAIL - PUSHED

2022-05-06 Thread osstest service owner
flight 170190 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170190/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 170173 test-armhf-armhf-libvirt 16 saver

Re: [PATCH v2 7/9] xen/arm: set up shared memory foreign mapping for borrower domain

2022-05-06 Thread Stefano Stabellini
On Fri, 6 May 2022, Penny Zheng wrote: > This commit sets up shared memory foreign mapping for borrower domain. > > If owner domain is the default dom_io, all shared domain are treated as > borrower domain. > > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini > --- > v2 change: > -

  1   2   >