Re: [PATCH 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc()

2022-05-05 Thread Jan Beulich
On 05.05.2022 04:54, Henry Wang wrote: > xmalloc() will use a pool for allocation smaller than a page. > The pool is extended only when there are no more space. At which > point, alloc_xenheap_pages() is called to add more memory. > > xmalloc() must be protected by ASSERT_ALLOC_CONTEXT. It should

Re: [PATCH 1/2] xen/arm: Defer request_irq on secondary CPUs after local_irq_enable

2022-05-05 Thread Julien Grall
Hi Henry, The CC list doesn't seem to contain the other maintainers. Please use the scripts provided in the repo (such scripts/add_maintainers.pl) to generate the CC. On 05/05/2022 03:54, Henry Wang wrote: With the enhanced ASSERT_ALLOC_CONTEXT, calling request_irq before local_irq_enable on

Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot

2022-05-05 Thread Jan Beulich
On 05.05.2022 02:16, Stefano Stabellini wrote: > From: Luca Miccio > > Export evtchn_alloc_unbound and make it __must_check. > > If "xen,enhanced" is enabled, then add to dom0less domains: > > - the hypervisor node in device tree > - the xenstore event channel > > The xenstore event channel is

RE: [PATCH 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc()

2022-05-05 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > > Change-Id: Ia463d2241e80e8a78d7dbb5b2318694d3ca5ed67 > > Just two formal remarks for starters: What's this last tag? And why am > I on the To: list of this patch, when ... I forgot to remove the Change-Id before sending the patch, sor

[qemu-mainline test] 170130: tolerable FAIL - PUSHED

2022-05-05 Thread osstest service owner
flight 170130 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170130/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds18 guest-start/debian.repeat fail REGR. vs. 170110 Tests which did not succee

RE: [PATCH 1/2] xen/arm: Defer request_irq on secondary CPUs after local_irq_enable

2022-05-05 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Hi Henry, > > The CC list doesn't seem to contain the other maintainers. Please use > the scripts provided in the repo (such scripts/add_maintainers.pl) to > generate the CC. > > On 05/05/2022 03:54, Henry Wang wrote: > > With the e

Re: [PATCH v6 5/7] xenstored: send an evtchn notification on introduce_domain

2022-05-05 Thread Juergen Gross
On 05.05.22 02:16, Stefano Stabellini wrote: From: Luca Miccio When xs_introduce_domain is called, send out a notification on the xenstore event channel so that any (dom0less) domain waiting for the xenstore interface to be ready can continue with the initialization. Before sending the notifica

[ovmf test] 170140: regressions - FAIL

2022-05-05 Thread osstest service owner
flight 170140 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170140/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[PATCH 0/4] Virtio toolstack support for I2C and GPIO on Arm

2022-05-05 Thread Viresh Kumar
Hello, This patchset adds toolstack support for I2C and GPIO virtio devices. This is inspired from the work done by Oleksandr for the Disk device [1]. The first two patches can be applied right away, but the last two need Oleksandr's series [1] to be applied first. This is developed as part of L

[PATCH 2/4] libxl: Add support for Virtio GPIO device

2022-05-05 Thread Viresh Kumar
This patch adds basic support for configuring and assisting virtio-mmio based virtio-gpio backend (emualator) which is intended to run out of Qemu and could be run in any domain. An example of domain configuration for Virtio Gpio: gpio = [ "" ] Please note, this patch is not enough for virtio-gpi

[PATCH 3/4] libxl: Allocate MMIO params for I2c device and update DT

2022-05-05 Thread Viresh Kumar
This patch allocates Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. Signed-off-by: Viresh Kumar --- tools/libs/light/libxl_arm.c | 57 ++-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/tool

[PATCH 1/4] libxl: Add support for Virtio I2C device

2022-05-05 Thread Viresh Kumar
This patch adds basic support for configuring and assisting virtio-mmio based virtio-i2c backend (emualator) which is intended to run out of Qemu and could be run in any domain. An example of domain configuration for Virtio I2c: i2c = [ "" ] Please note, this patch is not enough for virtio-i2c to

[PATCH 4/4] libxl: Allocate MMIO params for GPIO device and update DT

2022-05-05 Thread Viresh Kumar
This patch allocates Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. Signed-off-by: Viresh Kumar --- tools/libs/light/libxl_arm.c | 60 1 file changed, 60 insertions(+) diff --git a/tools/libs/light/lib

Re: Virtio on Xen with Rust

2022-05-05 Thread Viresh Kumar
On 29-04-22, 13:44, Oleksandr wrote: > On 29.04.22 06:48, Viresh Kumar wrote: > > What should I do about these patches ? Send them to xen list ? I can at > > least > > send the stuff which doesn't depend on your series ? > > Below my understanding, which might be wrong) > > > I think, the best

Re: [PATCH 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc()

2022-05-05 Thread Jan Beulich
On 05.05.2022 09:26, Henry Wang wrote: >> -Original Message- >> From: Jan Beulich >>> Change-Id: Ia463d2241e80e8a78d7dbb5b2318694d3ca5ed67 >> >> Just two formal remarks for starters: What's this last tag? And why am >> I on the To: list of this patch, when ... > > I forgot to remove the C

Re: [PATCH v3 1/6] xen: do not free reserved memory into heap

2022-05-05 Thread Jan Beulich
On 05.05.2022 07:12, Penny Zheng wrote: > Hi jan > >> -Original Message- >> From: Jan Beulich >> Sent: Wednesday, May 4, 2022 9:27 PM >> To: Penny Zheng >> Cc: Wei Chen ; Andrew Cooper >> ; George Dunlap ; >> Julien Grall ; Stefano Stabellini ; >> Wei >> Liu ; xen-devel@lists.xenproject

Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap

2022-05-05 Thread Jan Beulich
On 05.05.2022 08:24, Penny Zheng wrote: >> From: Jan Beulich >> Sent: Wednesday, May 4, 2022 9:45 PM >> >> On 27.04.2022 11:27, Penny Zheng wrote: >>> #else >>> void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, >>>bool need_scrub) { >>> ASSE

Re: [PATCH v6 6/7] tools: add example application to initialize dom0less PV drivers

2022-05-05 Thread Juergen Gross
On 05.05.22 02:16, Stefano Stabellini wrote: From: Luca Miccio Add an example application that can be run in dom0 to complete the dom0less domains initialization so that they can get access to xenstore and use PV drivers. The application sets "connection" to XENSTORE_RECONNECT on the xenstore

[libvirt test] 170138: regressions - FAIL

2022-05-05 Thread osstest service owner
flight 170138 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170138/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-i386-libvirt

[ovmf test] 170141: regressions - FAIL

2022-05-05 Thread osstest service owner
flight 170141 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170141/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[PATCH v3 01/21] xen: update grant_table.h

2022-05-05 Thread Juergen Gross
Update include/xen/interface/grant_table.h to its newest version. This allows to drop some private definitions in grant-table.c and include/xen/grant_table.h. Signed-off-by: Juergen Gross --- V3: - new patch --- drivers/xen/grant-table.c | 8 +- include/xen/grant_table.h |

[PATCH v3 10/21] xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF

2022-05-05 Thread Juergen Gross
Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- V3: - terminate grant ref list with 0 (Oleksandr Tyshchenko) --- drivers/xen/xen-front-pgdir-shbuf.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) dif

[PATCH v3 00/21] xen: simplify frontend side ring setup

2022-05-05 Thread Juergen Gross
Many Xen PV frontends share similar code for setting up a ring page (allocating and granting access for the backend) and for tearing it down. Create new service functions doing all needed steps in one go. This requires all frontends to use a common value for an invalid grant reference in order to

[PATCH v3 11/21] xen: update ring.h

2022-05-05 Thread Juergen Gross
Update include/xen/interface/io/ring.h to its newest version. Switch the two improper use cases of RING_HAS_UNCONSUMED_RESPONSES() to XEN_RING_NR_UNCONSUMED_RESPONSES() in order to avoid the nasty XEN_RING_HAS_UNCONSUMED_IS_BOOL #define. Signed-off-by: Juergen Gross --- V2: - new patch --- driv

[PATCH v3 06/21] xen/usb: switch xen-hcd to use INVALID_GRANT_REF

2022-05-05 Thread Juergen Gross
Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross Acked-by: Greg Kroah-Hartman --- drivers/usb/host/xen-hcd.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/xen-hcd.c b/drivers/us

[PATCH v3 07/21] xen/drm: switch xen_drm_front to use INVALID_GRANT_REF

2022-05-05 Thread Juergen Gross
Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- drivers/gpu/drm/xen/xen_drm_front.h | 9 - drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 4 ++-- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/dr

[PATCH v3 02/21] xen/grant-table: never put a reserved grant on the free list

2022-05-05 Thread Juergen Gross
Make sure a reserved grant is never put on the free list, as this could cause hard to debug errors. Signed-off-by: Juergen Gross --- V3: - new patch --- drivers/xen/grant-table.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 6

[PATCH v3 03/21] xen/blkfront: switch blkfront to use INVALID_GRANT_REF

2022-05-05 Thread Juergen Gross
Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- drivers/block/xen-blkfront.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkf

[PATCH v3 20/21] xen/sndfront: use xenbus_setup_ring() and xenbus_teardown_ring()

2022-05-05 Thread Juergen Gross
Simplify sndfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- sound/xen/xen_snd_front_evtchnl.c | 44 +++ 1 file changed, 10 insertions(+), 34 deletions(-) diff --git a/sound/xen/xen_snd_front_evtch

[PATCH v3 04/21] xen/netfront: switch netfront to use INVALID_GRANT_REF

2022-05-05 Thread Juergen Gross
Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- drivers/net/xen-netfront.c | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-

[PATCH v3 08/21] xen/sound: switch xen_snd_front to use INVALID_GRANT_REF

2022-05-05 Thread Juergen Gross
Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- sound/xen/xen_snd_front_evtchnl.c | 4 ++-- sound/xen/xen_snd_front_evtchnl.h | 9 - 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/sound/xen/xen_snd_fron

[PATCH v3 05/21] xen/scsifront: remove unused GRANT_INVALID_REF definition

2022-05-05 Thread Juergen Gross
GRANT_INVALID_REF isn't used in scsifront, so remove it. Signed-off-by: Juergen Gross --- drivers/scsi/xen-scsifront.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c index 56173beecbc6..4c55e479fc36 100644 --- a/drivers/scsi/xen-

[PATCH v3 14/21] xen/netfront: use xenbus_setup_ring() and xenbus_teardown_ring()

2022-05-05 Thread Juergen Gross
Simplify netfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/net/xen-netfront.c | 53 +- 1 file changed, 12 insertions(+), 41 deletions(-) diff --git a/drivers/net/xen-netfront.c b/

[PATCH v3 09/21] xen/dmabuf: switch gntdev-dmabuf to use INVALID_GRANT_REF

2022-05-05 Thread Juergen Gross
Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- drivers/xen/gntdev-dmabuf.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/xen/gntdev-dmabuf.c b/drivers/xen/gntdev-dmabuf.c index d5bf

[PATCH v3 17/21] xen/pcifront: use xenbus_setup_ring() and xenbus_teardown_ring()

2022-05-05 Thread Juergen Gross
Simplify pcifront's shared page creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/pci/xen-pcifront.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/x

[PATCH v3 13/21] xen/blkfront: use xenbus_setup_ring() and xenbus_teardown_ring()

2022-05-05 Thread Juergen Gross
Simplify blkfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/block/xen-blkfront.c | 37 1 file changed, 8 insertions(+), 29 deletions(-) diff --git a/drivers/block/xen-blkfront.c b

[PATCH v3 18/21] xen/scsifront: use xenbus_setup_ring() and xenbus_teardown_ring()

2022-05-05 Thread Juergen Gross
Simplify scsifront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/scsi/xen-scsifront.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/drivers/scsi/xen-scsifront.c b/driver

[PATCH v3 15/21] xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring()

2022-05-05 Thread Juergen Gross
Simplify tpmfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/char/tpm/xen-tpmfront.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/cha

[PATCH v3 12/21] xen/xenbus: add xenbus_setup_ring() service function

2022-05-05 Thread Juergen Gross
Most PV device frontends share very similar code for setting up shared ring buffers: - allocate page(s) - init the ring admin data - give the backend access to the ring via grants Tearing down the ring requires similar actions in all frontends again: - remove grants - free the page(s) Provide s

[PATCH v3 19/21] xen/usbfront: use xenbus_setup_ring() and xenbus_teardown_ring()

2022-05-05 Thread Juergen Gross
Simplify xen-hcd's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross Acked-by: Greg Kroah-Hartman --- drivers/usb/host/xen-hcd.c | 61 ++ 1 file changed, 15 insertions(+), 46 deletions(-) diff --git a/

Re: [PATCH v4 07/21] IOMMU/x86: support freeing of pagetables

2022-05-05 Thread Jan Beulich
On 04.05.2022 17:06, Roger Pau Monné wrote: > On Wed, May 04, 2022 at 03:07:24PM +0200, Jan Beulich wrote: >> On 03.05.2022 18:20, Roger Pau Monné wrote: >>> On Mon, Apr 25, 2022 at 10:35:45AM +0200, Jan Beulich wrote: For vendor specific code to support superpages we need to be able to d

Re: [PATCH 2/3] tools/libxc: change xc_memshr_fork_reset API to match hypervisor

2022-05-05 Thread Roger Pau Monné
On Wed, Apr 27, 2022 at 11:34:19AM -0400, Tamas K Lengyel wrote: > Need to separately specify if the reset is for the memory or for the VM state, > or both. > > Signed-off-by: Tamas K Lengyel Reviewed-by: Roger Pau Monné Thanks.

[ovmf test] 170142: regressions - FAIL

2022-05-05 Thread osstest service owner
flight 170142 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170142/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[PATCH v3 16/21] xen/drmfront: use xenbus_setup_ring() and xenbus_teardown_ring()

2022-05-05 Thread Juergen Gross
Simplify drmfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 43 ++--- 1 file changed, 11 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/xen/xen_drm_f

[PATCH v3 21/21] xen/xenbus: eliminate xenbus_grant_ring()

2022-05-05 Thread Juergen Gross
There is no external user of xenbus_grant_ring() left, so merge it into the only caller xenbus_setup_ring(). Signed-off-by: Juergen Gross Reviewed-by: Oleksandr Tyshchenko --- V2: - make error message more precise (Andrew Cooper) --- drivers/xen/xenbus/xenbus_client.c | 65 +

Re: [PATCH RFC] x86/lld: fix symbol map generation

2022-05-05 Thread Roger Pau Monné
On Tue, May 03, 2022 at 10:17:44AM +0200, Jan Beulich wrote: > On 02.05.2022 17:20, Roger Pau Monne wrote: > > The symbol map generation (and thus the debug info attached to Xen) is > > partially broken when using LLVM LD. That's due to LLD converting > > almost all symbols from global to local in

RE: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap

2022-05-05 Thread Penny Zheng
Hi jan > -Original Message- > From: Jan Beulich > Sent: Thursday, May 5, 2022 3:47 PM > To: Penny Zheng > Cc: Wei Chen ; Henry Wang ; > Andrew Cooper ; George Dunlap > ; Julien Grall ; Stefano > Stabellini ; Wei Liu ; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH v3 6/6] xen: r

Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap

2022-05-05 Thread Jan Beulich
On 05.05.2022 10:44, Penny Zheng wrote: > Hi jan > >> -Original Message- >> From: Jan Beulich >> Sent: Thursday, May 5, 2022 3:47 PM >> To: Penny Zheng >> Cc: Wei Chen ; Henry Wang ; >> Andrew Cooper ; George Dunlap >> ; Julien Grall ; Stefano >> Stabellini ; Wei Liu ; xen- >> de...@list

[ovmf test] 170143: regressions - FAIL

2022-05-05 Thread osstest service owner
flight 170143 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170143/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

RE: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap

2022-05-05 Thread Penny Zheng
Hi jan > -Original Message- > From: Jan Beulich > Sent: Thursday, May 5, 2022 4:51 PM > To: Penny Zheng > Cc: Wei Chen ; Henry Wang ; > Andrew Cooper ; George Dunlap > ; Julien Grall ; Stefano > Stabellini ; Wei Liu ; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH v3 6/6] xen: r

[xen-unstable test] 170133: tolerable FAIL - PUSHED

2022-05-05 Thread osstest service owner
flight 170133 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170133/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 170071 Tests which did not succeed

Re: [PATCH v6 2/7] xen/arm: implement domU extended regions

2022-05-05 Thread Oleksandr
On 05.05.22 03:16, Stefano Stabellini wrote: Hello Stefano From: Stefano Stabellini Implement extended regions for dom0less domUs. The implementation is based on the libxl implementation. Also update docs for the ext_regions command line option. Signed-off-by: Stefano Stabellini Reviewe

Re: [PATCH v4 07/21] IOMMU/x86: support freeing of pagetables

2022-05-05 Thread Roger Pau Monné
On Thu, May 05, 2022 at 10:20:36AM +0200, Jan Beulich wrote: > On 04.05.2022 17:06, Roger Pau Monné wrote: > > On Wed, May 04, 2022 at 03:07:24PM +0200, Jan Beulich wrote: > >> On 03.05.2022 18:20, Roger Pau Monné wrote: > >>> On Mon, Apr 25, 2022 at 10:35:45AM +0200, Jan Beulich wrote: > For

Re: [PATCH V1 4/6] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops

2022-05-05 Thread Oleksandr
On 04.05.22 03:02, Rob Herring wrote: Hello Rob On Tue, May 03, 2022 at 08:09:32PM +0300, Oleksandr wrote: On 03.05.22 00:59, Rob Herring wrote: Hello Rob On Fri, Apr 22, 2022 at 07:51:01PM +0300, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Introduce Xen specific binding fo

[ovmf test] 170144: regressions - FAIL

2022-05-05 Thread osstest service owner
flight 170144 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170144/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[PATCH 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping*

2022-05-05 Thread Michal Orzel
Function unmap_common_complete (common/grant_table.c) defines and sets a variable ld that is later on passed to a macro: gnttab_host_mapping_get_page_type(). On Arm this macro does not make use of any arguments causing a compiler to warn about unused-but-set variable (when -Wunused-but-set-variable

[PATCH 0/2] xen/arm: gnttab: macros modifications

2022-05-05 Thread Michal Orzel
This patch series modifies macros inside xen/arch/arm/include/asm/grant_table.h to be resistant to static analyzer/compiler warnings about unused-but-set variables. The first patch acts as a fix for a gcc warning when -Wunused-but-set-variable flag is enabled by converting the macro to static inli

[PATCH 2/2] xen/arm: gnttab: modify macros to evaluate all arguments and only once

2022-05-05 Thread Michal Orzel
Modify macros to evaluate all the arguments and make sure the arguments are evaluated only once. While doing so, use typeof for basic types and use const qualifier when applicable. Signed-off-by: Michal Orzel --- xen/arch/arm/include/asm/grant_table.h | 67 ++ 1 file chan

Re: [PATCH] SUPPORT.MD: Correct the amount of physical memory supported for Arm

2022-05-05 Thread Julien Grall
On 27/04/2022 14:51, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 27 Apr 2022, at 14:22, Julien Grall wrote: From: Julien Grall As part of XSA-385, SUPPORT.MD gained a statement regarding the amount of physical memory supported. However, booting Xen on a Arm platform with that amou

Re: [PATCH 2/3] xen/arm: Advertise workaround 1 if we apply 3

2022-05-05 Thread Julien Grall
On 04/05/2022 08:25, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 3 May 2022, at 19:17, Julien Grall wrote: Hi Bertrand, On 03/05/2022 10:38, Bertrand Marquis wrote: SMCC_WORKAROUND_3 is handling both Spectre v2 and spectre BHB. So when a guest is asking if we support workaround 1,

Re: [PATCH v2] tools/xenstore: don't let special watches be children of /

2022-05-05 Thread Julien Grall
Hi Juergen, On 02/05/2022 11:07, Juergen Gross wrote: When firing special watches (e.g. "@releaseDomain"), they will be regarded to be valid children of the "/" node. So a domain having registered a watch for "/" and having the privilege to receive the special watches will receive those special

[ovmf test] 170145: regressions - FAIL

2022-05-05 Thread osstest service owner
flight 170145 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170145/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping*

2022-05-05 Thread Jan Beulich
On 05.05.2022 12:36, Michal Orzel wrote: > --- a/xen/arch/arm/include/asm/grant_table.h > +++ b/xen/arch/arm/include/asm/grant_table.h > @@ -29,12 +29,21 @@ static inline void gnttab_mark_dirty(struct domain *d, > mfn_t mfn) > #endif > } > > +static inline bool gnttab_host_mapping_get_page_typ

Re: [PATCH 2/2] xen/arm: gnttab: modify macros to evaluate all arguments and only once

2022-05-05 Thread Jan Beulich
On 05.05.2022 12:36, Michal Orzel wrote: > Modify macros to evaluate all the arguments and make sure the arguments > are evaluated only once. While doing so, use typeof for basic types > and use const qualifier when applicable. Why only for basic types? To take an example, passing void * into gntt

Re: [PATCH 2/2] xen/arm: gnttab: modify macros to evaluate all arguments and only once

2022-05-05 Thread Michal Orzel
Hi Jan, On 05.05.2022 13:20, Jan Beulich wrote: > On 05.05.2022 12:36, Michal Orzel wrote: >> Modify macros to evaluate all the arguments and make sure the arguments >> are evaluated only once. While doing so, use typeof for basic types >> and use const qualifier when applicable. > > Why only for

Re: [PATCH RFC] x86/lld: fix symbol map generation

2022-05-05 Thread Jan Beulich
On 05.05.2022 10:39, Roger Pau Monné wrote: > On Tue, May 03, 2022 at 10:17:44AM +0200, Jan Beulich wrote: >> On 02.05.2022 17:20, Roger Pau Monne wrote: >>> The symbol map generation (and thus the debug info attached to Xen) is >>> partially broken when using LLVM LD. That's due to LLD converting

Re: [PATCH 2/2] xen/arm: gnttab: modify macros to evaluate all arguments and only once

2022-05-05 Thread Jan Beulich
On 05.05.2022 13:25, Michal Orzel wrote: > On 05.05.2022 13:20, Jan Beulich wrote: >> On 05.05.2022 12:36, Michal Orzel wrote: >>> Modify macros to evaluate all the arguments and make sure the arguments >>> are evaluated only once. While doing so, use typeof for basic types >>> and use const qualif

[PATCH v2] xen/arm: Avoid overflow using MIDR_IMPLEMENTOR_MASK

2022-05-05 Thread Michal Orzel
Value of macro MIDR_IMPLEMENTOR_MASK exceeds the range of integer and can lead to overflow. Currently there is no issue as it is used in an expression implicitly casted to u32 in MIDR_IS_CPU_MODEL_RANGE. To avoid possible problems, fix the macro. Signed-off-by: Michal Orzel Link: https://lore.ker

[ovmf test] 170147: regressions - FAIL

2022-05-05 Thread osstest service owner
flight 170147 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170147/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap

2022-05-05 Thread Jan Beulich
On 05.05.2022 11:29, Penny Zheng wrote: >> -Original Message- >> From: Jan Beulich >> Sent: Thursday, May 5, 2022 4:51 PM >> >> On 05.05.2022 10:44, Penny Zheng wrote: -Original Message- From: Jan Beulich Sent: Thursday, May 5, 2022 3:47 PM On 05.05.2022 0

Re: [PATCH v2] xen/arm: Avoid overflow using MIDR_IMPLEMENTOR_MASK

2022-05-05 Thread Catalin Marinas
On Thu, May 05, 2022 at 01:59:06PM +0200, Michal Orzel wrote: > Value of macro MIDR_IMPLEMENTOR_MASK exceeds the range of integer > and can lead to overflow. Currently there is no issue as it is used > in an expression implicitly casted to u32 in MIDR_IS_CPU_MODEL_RANGE. > To avoid possible problem

Re: [PATCH v4 2/2] xen: add support for initializing xenstore later as HVM domain

2022-05-05 Thread Michal Orzel
Hi Luca, On 05.05.2022 02:23, Stefano Stabellini wrote: > From: Luca Miccio > > When running as dom0less guest (HVM domain on ARM) the xenstore event > channel is available at domain creation but the shared xenstore > interface page only becomes available later on. > > In that case, wait for a

Re: [PATCH v4 2/2] xen: add support for initializing xenstore later as HVM domain

2022-05-05 Thread Juergen Gross
On 05.05.22 14:26, Michal Orzel wrote: Hi Luca, On 05.05.2022 02:23, Stefano Stabellini wrote: From: Luca Miccio When running as dom0less guest (HVM domain on ARM) the xenstore event channel is available at domain creation but the shared xenstore interface page only becomes available later on

Re: [PATCH v4 2/2] xen: add support for initializing xenstore later as HVM domain

2022-05-05 Thread Michal Orzel
On 05.05.2022 14:29, Juergen Gross wrote: >>> -    /* Avoid truncation on 32-bit. */ >>> +    if (v == ~0ULL) { >> No need for brackets for a single instruction. > > The coding style says otherwise: > >   This does not apply if only one branch of a conditional statement is a > single >

[ovmf test] 170148: regressions - FAIL

2022-05-05 Thread osstest service owner
flight 170148 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170148/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH v4 10/21] AMD/IOMMU: allow use of superpage mappings

2022-05-05 Thread Roger Pau Monné
On Mon, Apr 25, 2022 at 10:38:06AM +0200, Jan Beulich wrote: > No separate feature flags exist which would control availability of > these; the only restriction is HATS (establishing the maximum number of > page table levels in general), and even that has a lower bound of 4. > Thus we can unconditi

Re: [PATCH 02/32] Introduce flexible array struct memcpy() helpers

2022-05-05 Thread Johannes Berg
On Wed, 2022-05-04 at 08:38 -0700, Kees Cook wrote: > > It seemed like requiring a structure be rearranged to take advantage of > the "automatic layout introspection" wasn't very friendly. On the other > hand, looking at the examples, most of them are already neighboring > members. Hmmm. A lot of

[ovmf test] 170149: regressions - FAIL

2022-05-05 Thread osstest service owner
flight 170149 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170149/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

RE: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap

2022-05-05 Thread Penny Zheng
Hi Jan > -Original Message- > From: Jan Beulich > Sent: Thursday, May 5, 2022 8:07 PM > To: Penny Zheng > Cc: Wei Chen ; Henry Wang ; > Andrew Cooper ; George Dunlap > ; Julien Grall ; Stefano Stabellini > ; Wei Liu ; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH v3 6/6] xen: r

[xen-unstable-smoke test] 170146: tolerable all pass - PUSHED

2022-05-05 Thread osstest service owner
flight 170146 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170146/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH] build/xen: fix symbol generation with LLVM LD

2022-05-05 Thread Roger Pau Monne
Current LLVM LD implementation will turn global hidden symbols in object files into local ones when generating the .symtab of the Xen binary image. This is different from GNU ld implementation, that will only do the conversion (or remove the symbols) when generation .dynsym but not .symtab. Such

Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap

2022-05-05 Thread Jan Beulich
On 05.05.2022 15:44, Penny Zheng wrote: > I misunderstand what you suggested here, I thought you were suggesting a way > of stub function > which could bring some optimization. > The reason I introduced free_staticmem_pages and acquire_reserved_page here > is that > we now used them in common cod

Re: [PATCH v4 10/21] AMD/IOMMU: allow use of superpage mappings

2022-05-05 Thread Jan Beulich
On 05.05.2022 15:19, Roger Pau Monné wrote: > On Mon, Apr 25, 2022 at 10:38:06AM +0200, Jan Beulich wrote: >> No separate feature flags exist which would control availability of >> these; the only restriction is HATS (establishing the maximum number of >> page table levels in general), and even tha

Re: [PATCH] PCI: don't allow "pci-phantom=" to mark real devices as phantom functions

2022-05-05 Thread Roger Pau Monné
On Fri, Apr 29, 2022 at 03:05:32PM +0200, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > IOMMU code mapping / unmapping devices and interrupts will misbehave if > a wrong comman

[PATCH] MAINTAINERS: add myself as reviewer for IOMMU vendor independent code

2022-05-05 Thread Roger Pau Monne
That also covers the PCI bits which I'm interested on. Signed-off-by: Roger Pau Monné --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ba0d1c0c1b..96866f626e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -346,6 +346,7 @@ F: xen/arch/x86/mm/p2m-

[ovmf test] 170151: regressions - FAIL

2022-05-05 Thread osstest service owner
flight 170151 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170151/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH] PCI: don't allow "pci-phantom=" to mark real devices as phantom functions

2022-05-05 Thread Jan Beulich
On 05.05.2022 17:00, Roger Pau Monné wrote: > On Fri, Apr 29, 2022 at 03:05:32PM +0200, Jan Beulich wrote: >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments >> unless you have verified the sender and know the content is safe. >> >> IOMMU code mapping / unmapping devices

Re: [PATCH] MAINTAINERS: add myself as reviewer for IOMMU vendor independent code

2022-05-05 Thread Jan Beulich
On 05.05.2022 17:04, Roger Pau Monne wrote: > That also covers the PCI bits which I'm interested on. > > Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich And thanks for volunteering. Jan > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -346,6 +346,7 @@ F:xen/arch/x86/mm/p2m-ept.c >

Re: [PATCH 3/3] xen/arm: Add sb instruction support

2022-05-05 Thread Julien Grall
Hi, On 04/05/2022 09:06, Julien Grall wrote: On 04/05/2022 08:24, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 3 May 2022, at 19:47, Julien Grall wrote: A new cpuerrata capability is introduced to enable the alternative 'sb' is definitely not an erratum. Errata are for stuff t

Re: [PATCH v4 10/21] AMD/IOMMU: allow use of superpage mappings

2022-05-05 Thread Roger Pau Monné
On Thu, May 05, 2022 at 04:34:54PM +0200, Jan Beulich wrote: > On 05.05.2022 15:19, Roger Pau Monné wrote: > > On Mon, Apr 25, 2022 at 10:38:06AM +0200, Jan Beulich wrote: > >> No separate feature flags exist which would control availability of > >> these; the only restriction is HATS (establishing

Re: [PATCH] PCI: don't allow "pci-phantom=" to mark real devices as phantom functions

2022-05-05 Thread Roger Pau Monné
On Thu, May 05, 2022 at 05:14:14PM +0200, Jan Beulich wrote: > On 05.05.2022 17:00, Roger Pau Monné wrote: > > On Fri, Apr 29, 2022 at 03:05:32PM +0200, Jan Beulich wrote: > >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > >> unless you have verified the sender and kn

[ovmf test] 170154: regressions - FAIL

2022-05-05 Thread osstest service owner
flight 170154 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170154/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH v2] arm/its: enable LPIs before mapping the collection table

2022-05-05 Thread Julien Grall
Hi Rahul, On 04/05/2022 18:15, Rahul Singh wrote: When Xen boots on the platform that implements the GIC 600, ITS MAPC_LPI_OFF uncorrectable command error issue is observed. As per the GIC-600 TRM (Revision: r1p6) MAPC_LPI_OFF command error can be reported if the MAPC command has tried to map a

Re: [PATCH 02/32] Introduce flexible array struct memcpy() helpers

2022-05-05 Thread Keith Packard
Johannes Berg writes: > Yeah, dunno, I guess I'm slightly more on the side of not requiring it, > since we don't do the same for kmalloc() etc. and probably really > wouldn't want to add kmalloc_s() that does it ;-) I suspect the number of bugs this catches will be small, but they'll be in place

Re: [PATCH v3 0/2] kernel: add new infrastructure for platform_has() support

2022-05-05 Thread Oleksandr
On 04.05.22 18:57, Juergen Gross wrote: Hello Juergen In another patch series [1] the need has come up to have support for a generic feature flag infrastructure. This patch series is introducing that infrastructure and adds the first use case. I have decided to use a similar interface as t

Re: [PATCH v4 11/21] VT-d: allow use of superpage mappings

2022-05-05 Thread Roger Pau Monné
On Mon, Apr 25, 2022 at 10:38:37AM +0200, Jan Beulich wrote: > ... depending on feature availability (and absence of quirks). > > Also make the page table dumping function aware of superpages. > > Signed-off-by: Jan Beulich > Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monné Might be inte

[ovmf test] 170155: regressions - FAIL

2022-05-05 Thread osstest service owner
flight 170155 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170155/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH] bump default SeaBIOS version to 1.16.0

2022-05-05 Thread Julien Grall
Hi Jan, On 27/04/2022 11:55, Jan Beulich wrote: Signed-off-by: Jan Beulich Acked-by: Julien Grall Cheers, -- Julien Grall

[PATCH] xen: io: Fix race between sending an I/O and domain shutdown

2022-05-05 Thread Julien Grall
From: Julien Grall Xen provides hypercalls to shutdown (SCHEDOP_shutdown{,_code}) and resume a domain (XEN_DOMCTL_resumedomain). They can be used for checkpoint where the expectation is the domain should continue as nothing happened afterwards. hvmemul_do_io() and handle_pio() will act different

[ovmf test] 170156: regressions - FAIL

2022-05-05 Thread osstest service owner
flight 170156 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170156/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

  1   2   >