Re: [PATCH 2/4] xen/scsiback: use new command result macros

On 21.04.22 22:56, Boris Ostrovsky wrote: On 4/21/22 4:40 AM, Juergen Gross wrote: On 20.04.22 18:12, Boris Ostrovsky wrote: And also looking at invocations of scsiback_do_resp_with_sense() I think those may need to be adjusted as well. No, the invocations are fine, but scsiback_result() nee

Re: [PATCH 3/8] gnttab: Remove unused-but-set variable

Hi Andrew, Jan On 27.04.2022 14:33, Andrew Cooper wrote: > On 27/04/2022 12:06, Michal Orzel wrote: >> Hi Jan, >> >> On 27.04.2022 11:59, Jan Beulich wrote: >>> On 27.04.2022 11:49, Michal Orzel wrote: Function unmap_common_complete defines and sets a variable ld that is later on passed

Re: [PATCH 3/8] gnttab: Remove unused-but-set variable

On 28.04.2022 09:16, Michal Orzel wrote: > Hi Andrew, Jan > > On 27.04.2022 14:33, Andrew Cooper wrote: >> On 27/04/2022 12:06, Michal Orzel wrote: >>> Hi Jan, >>> >>> On 27.04.2022 11:59, Jan Beulich wrote: On 27.04.2022 11:49, Michal Orzel wrote: > Function unmap_common_complete defines

Re: [PATCH 3/8] gnttab: Remove unused-but-set variable

On 28.04.2022 09:27, Jan Beulich wrote: >>> diff --git a/xen/arch/arm/include/asm/grant_table.h >>> b/xen/arch/arm/include/asm/grant_table.h >>> index d31a4d6805d6..9f68c2a37eb6 100644 >>> --- a/xen/arch/arm/include/asm/grant_table.h >>> +++ b/xen/arch/arm/include/asm/grant_table.h >>> @@ -31,10

Re: [PATCH 3/8] gnttab: Remove unused-but-set variable

On 28.04.2022 09:32, Michal Orzel wrote: > > > On 28.04.2022 09:27, Jan Beulich wrote: diff --git a/xen/arch/arm/include/asm/grant_table.h b/xen/arch/arm/include/asm/grant_table.h index d31a4d6805d6..9f68c2a37eb6 100644 --- a/xen/arch/arm/include/asm/grant_table.h +++ b/x

Re: Regression with CET: [PATCH v1] x86/mm: avoid inadvertently degrading a TLB flush to local only

On 27.04.2022 20:44, David Vrabel wrote: > > > On 27/04/2022 19:03, Andrew Cooper wrote: >> On 19/04/2022 16:03, David Vrabel wrote: >>> From: David Vrabel >>> >>> If the direct map is incorrectly modified with interrupts disabled, >>> the required TLB flushes are degraded to flushing the local

Re: Regression with CET: [PATCH v1] x86/mm: avoid inadvertently degrading a TLB flush to local only

On 28.04.2022 09:37, Jan Beulich wrote: > On 27.04.2022 20:44, David Vrabel wrote: >> >> >> On 27/04/2022 19:03, Andrew Cooper wrote: >>> On 19/04/2022 16:03, David Vrabel wrote: From: David Vrabel If the direct map is incorrectly modified with interrupts disabled, the required

[ovmf test] 169804: regressions - FAIL

flight 169804 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169804/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [xen-unstable-smoke test] 169781: regressions - FAIL

On 27.04.2022 19:10, Julien Grall wrote: > Hi, > > On 27/04/2022 17:38, osstest service owner wrote: >> flight 169781 xen-unstable-smoke real [real] >> flight 169785 xen-unstable-smoke real-retest [real] >> http://logs.test-lab.xenproject.org/osstest/logs/169781/ >> http://logs.test-lab.xenproject

[PATCH v2 2/4] xen/scsiback: use new command result macros

Instead of using the kernel's values for the result of PV scsi operations use the values of the interface definition. Signed-off-by: Juergen Gross --- V2: - fix scsiback_result() to pass through lowest 16 bits of result - use XEN_VSCSIIF_RSLT_HOST() instead of open coding it (Boris Ostrovsky) ---

[PATCH v2 0/4] xen/pv-scsi: update header and harden frontend

Update the Xen PV-scsi interface from the Xen tree and adapt the related drivers to use the new definitions. Harden the frontend driver to be no longer vulnerable to a malicious backend. Juergen Gross (4): xen: update vscsiif.h xen/scsiback: use new command result macros xen/scsifront: use

[PATCH v2 4/4] xen/scsifront: harden driver against malicious backend

Instead of relying on a well behaved PV scsi backend verify all meta data received from the backend and avoid multiple reads of the same data from the shared ring page. In case any illegal data from the backend is detected switch the PV device to a new "error" state and deactivate it for further u

[PATCH v2 1/4] xen: update vscsiif.h

Update include/xen/interface/io/vscsiif.h to its newest version. Signed-off-by: Juergen Gross --- include/xen/interface/io/vscsiif.h | 133 - 1 file changed, 129 insertions(+), 4 deletions(-) diff --git a/include/xen/interface/io/vscsiif.h b/include/xen/interface/io

[PATCH v2 3/4] xen/scsifront: use new command result macros

Add a translation layer for the command result values. Signed-off-by: Juergen Gross --- drivers/scsi/xen-scsifront.c | 64 +++- 1 file changed, 56 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c index 12109e4

Re: [PATCH] x86/msr: handle reads to MSR_P5_MC_ADDR

On 27.04.2022 17:47, Roger Pau Monne wrote: > I've added it for CENTAUR and SHANGHAI because the MSR is there since > Pentium, so likely to be implemented by those vendors also, but have > no way to check. I think that's fine. > I wonder how long it will take for Windows to also start poking at >

Re: [PATCH v2 1/2] PCI: replace stray uses of PCI_{DEVFN,BDF}2()

On 21.04.2022 16:26, Jan Beulich wrote: > There's no good reason to use these when we already have a pci_sbdf_t > type object available. This extends to the use of PCI_BUS() in > pci_ecam_map_bus() as well. > > No change to generated code (with gcc11 at least, and I have to admit > that I didn't e

Re: [PATCH 3/4] mwait-idle: add 'preferred_cstates' module argument

On Thu, Apr 28, 2022 at 08:37:58AM +0200, Jan Beulich wrote: > On 27.04.2022 18:12, Roger Pau Monné wrote: > > On Wed, Apr 27, 2022 at 05:25:35PM +0200, Jan Beulich wrote: > >> On 27.04.2022 17:06, Roger Pau Monné wrote: > >>> On Wed, Apr 27, 2022 at 03:41:24PM +0200, Jan Beulich wrote: > On 2

Re: [PATCH 3/4] mwait-idle: add 'preferred_cstates' module argument

On 28.04.2022 10:06, Roger Pau Monné wrote: > On Thu, Apr 28, 2022 at 08:37:58AM +0200, Jan Beulich wrote: >> On 27.04.2022 18:12, Roger Pau Monné wrote: >>> On Wed, Apr 27, 2022 at 05:25:35PM +0200, Jan Beulich wrote: On 27.04.2022 17:06, Roger Pau Monné wrote: > On Wed, Apr 27, 2022 at 0

Re: [PATCH 09/30] coresight: cpu-debug: Replace mutex with mutex_trylock on panic notifier

Hi Guilherme, On 27/04/2022 23:49, Guilherme G. Piccoli wrote: The panic notifier infrastructure executes registered callbacks when a panic event happens - such callbacks are executed in atomic context, with interrupts and preemption disabled in the running CPU and all other CPUs disabled. That

Re: [PATCH 20/30] panic: Add the panic informational notifier list

On 27/04/2022 23:49, Guilherme G. Piccoli wrote: The goal of this new panic notifier is to allow its users to register callbacks to run earlier in the panic path than they currently do. This aims at informational mechanisms, like dumping kernel offsets and showing device error data (in case it's

[PATCH v2 00/19] xen: simplify frontend side ring setup

Many Xen PV frontends share similar code for setting up a ring page (allocating and granting access for the backend) and for tearing it down. Create new service functions doing all needed steps in one go. This requires all frontends to use a common value for an invalid grant reference in order to

[PATCH v2 02/19] xen/netfront: switch netfront to use INVALID_GRANT_REF

Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- drivers/net/xen-netfront.c | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-

[PATCH v2 04/19] xen/usb: switch xen-hcd to use INVALID_GRANT_REF

Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross Acked-by: Greg Kroah-Hartman --- drivers/usb/host/xen-hcd.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/xen-hcd.c b/drivers/us

[PATCH v2 06/19] xen/sound: switch xen_snd_front to use INVALID_GRANT_REF

Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- sound/xen/xen_snd_front_evtchnl.c | 4 ++-- sound/xen/xen_snd_front_evtchnl.h | 9 - 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/sound/xen/xen_snd_fron

[PATCH v2 08/19] xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF

Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- drivers/xen/xen-front-pgdir-shbuf.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/xen/xen-front-pgdir-shbuf.c b/drivers/xen/xen-f

[PATCH v2 11/19] xen/blkfront: use xenbus_setup_ring() and xenbus_teardown_ring()

Simplify blkfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/block/xen-blkfront.c | 37 1 file changed, 8 insertions(+), 29 deletions(-) diff --git a/drivers/block/xen-blkfront.c b

[PATCH v2 10/19] xen/xenbus: add xenbus_setup_ring() service function

Most PV device frontends share very similar code for setting up shared ring buffers: - allocate page(s) - init the ring admin data - give the backend access to the ring via grants Tearing down the ring requires similar actions in all frontends again: - remove grants - free the page(s) Provide s

[PATCH v2 13/19] xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring()

Simplify tpmfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/char/tpm/xen-tpmfront.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/cha

[PATCH v2 15/19] xen/pcifront: use xenbus_setup_ring() and xenbus_teardown_ring()

Simplify pcifront's shared page creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/pci/xen-pcifront.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/x

[PATCH v2 14/19] xen/drmfront: use xenbus_setup_ring() and xenbus_teardown_ring()

Simplify drmfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 43 ++--- 1 file changed, 11 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/xen/xen_drm_f

[PATCH v2 03/19] xen/scsifront: remove unused GRANT_INVALID_REF definition

GRANT_INVALID_REF isn't used in scsifront, so remove it. Signed-off-by: Juergen Gross --- drivers/scsi/xen-scsifront.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c index 56173beecbc6..4c55e479fc36 100644 --- a/drivers/scsi/xen-

[PATCH v2 01/19] xen/blkfront: switch blkfront to use INVALID_GRANT_REF

Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- drivers/block/xen-blkfront.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkf

[PATCH v2 07/19] xen/dmabuf: switch gntdev-dmabuf to use INVALID_GRANT_REF

Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- drivers/xen/gntdev-dmabuf.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/xen/gntdev-dmabuf.c b/drivers/xen/gntdev-dmabuf.c index d5bf

[PATCH v2 12/19] xen/netfront: use xenbus_setup_ring() and xenbus_teardown_ring()

Simplify netfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/net/xen-netfront.c | 53 +- 1 file changed, 12 insertions(+), 41 deletions(-) diff --git a/drivers/net/xen-netfront.c b/

[PATCH v2 09/19] xen: update ring.h

Update include/xen/interface/io/ring.h to its newest version. Switch the two improper use cases of RING_HAS_UNCONSUMED_RESPONSES() to XEN_RING_NR_UNCONSUMED_RESPONSES() in order to avoid the nasty XEN_RING_HAS_UNCONSUMED_IS_BOOL #define. Signed-off-by: Juergen Gross --- V2: - new patch --- driv

[PATCH v2 16/19] xen/scsifront: use xenbus_setup_ring() and xenbus_teardown_ring()

Simplify scsifront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/scsi/xen-scsifront.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/drivers/scsi/xen-scsifront.c b/driver

[PATCH v2 17/19] xen/usbfront: use xenbus_setup_ring() and xenbus_teardown_ring()

Simplify xen-hcd's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross Acked-by: Greg Kroah-Hartman --- drivers/usb/host/xen-hcd.c | 61 ++ 1 file changed, 15 insertions(+), 46 deletions(-) diff --git a/

[PATCH v2 05/19] xen/drm: switch xen_drm_front to use INVALID_GRANT_REF

Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- drivers/gpu/drm/xen/xen_drm_front.h | 9 - drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 4 ++-- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/dr

[PATCH v2 19/19] xen/xenbus: eliminate xenbus_grant_ring()

There is no external user of xenbus_grant_ring() left, so merge it into the only caller xenbus_setup_ring(). Signed-off-by: Juergen Gross --- V2: - make error message more precise (Andrew Cooper) --- drivers/xen/xenbus/xenbus_client.c | 65 +- include/xen/xenbus.h

[PATCH v2 18/19] xen/sndfront: use xenbus_setup_ring() and xenbus_teardown_ring()

Simplify sndfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- sound/xen/xen_snd_front_evtchnl.c | 44 +++ 1 file changed, 10 insertions(+), 34 deletions(-) diff --git a/sound/xen/xen_snd_front_evtch

[ovmf test] 169806: regressions - FAIL

flight 169806 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169806/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [xen-unstable-smoke test] 169781: regressions - FAIL

Hi Jan, On 28/04/2022 08:45, Jan Beulich wrote: On 27.04.2022 19:10, Julien Grall wrote: Hi, On 27/04/2022 17:38, osstest service owner wrote: flight 169781 xen-unstable-smoke real [real] flight 169785 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/1697

[PATCH] x86/cet: Support cet= on the command line

... as a shorthand for setting both suboptions at once. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu I think this wants backporting. cet=0 is "so obviously" the way to turn off both that I tried using it to debug a problem. It's absence was an oversight o

Re: [PATCH v2 1/2] PCI: replace stray uses of PCI_{DEVFN,BDF}2()

Hi Jan, > On 21 Apr 2022, at 15:26, Jan Beulich wrote: > > There's no good reason to use these when we already have a pci_sbdf_t > type object available. This extends to the use of PCI_BUS() in > pci_ecam_map_bus() as well. > > No change to generated code (with gcc11 at least, and I have to adm

[PATCH v2] x86/msr: handle reads to MSR_P5_MC_{ADDR,TYPE}

Windows Server 2019 Essentials will unconditionally attempt to read P5_MC_ADDR MSR at boot and throw a BSOD if injected a #GP. Fix this by mapping MSR_P5_MC_{ADDR,TYPE} to MSR_IA32_MCi_{ADDR,STATUS}, as reported also done by hardware in Intel SDM "Mapping of the Pentium Processor Machine-Check Err

Re: [PATCH] x86/cet: Support cet= on the command line

On Thu, Apr 28, 2022 at 09:52:09AM +0100, Andrew Cooper wrote: > ... as a shorthand for setting both suboptions at once. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné >From the implementation below we would support settings like: cet=true,shstk=false Which I think it's indent

[linux-linus test] 169792: tolerable FAIL - PUSHED

flight 169792 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/169792/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 169767 test-armhf-armhf-libvirt 16 saver

Re: [PATCH v3] codeql: add support for analyzing C, Python and Go

Ping? On Wed, Mar 23, 2022 at 11:18:56AM +0100, Roger Pau Monne wrote: > Introduce CodeQL support for Xen and analyze the C, Python and Go > files. > > Note than when analyzing Python or Go we avoid building the hypervisor > and only build the tools. > > Requested-by: Andrew Cooper > Signed-off

[PATCH v2] xen/arm: gnttab: cast unused macro arguments to void

Function unmap_common_complete (common/grant_table.c) defines and sets a variable ld that is later on passed to a macro: gnttab_host_mapping_get_page_type(). On Arm this macro does not make use of any arguments causing a compiler to warn about unused-but-set variable (when -Wunused-but-set-variable

[ovmf test] 169808: regressions - FAIL

flight 169808 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169808/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH] cirrus-ci: add FreeBSD 14 task

On Wed, Apr 27, 2022 at 03:13:13PM -0700, Stefano Stabellini wrote: > On Wed, 27 Apr 2022, Roger Pau Monne wrote: > > Introduce a task that uses a FreeBSD 14 (HEAD) snapshot. > > > > Signed-off-by: Roger Pau Monné > > Acked-by: Stefano Stabellini > > > Roger, should you add an entry to MAINTA

[PATCH] cirrus-ci: add myself as maintainer

Given the testing done by Cirrus-CI is FreeBSD only introduce a new section in the MAINTAINERS file to cover it and add myself as the maintainer. Requested-by: Stefano Stabellini Signed-off-by: Roger Pau Monné --- FWIW, I wouldn't mind it being part of the "Continuous Integration (CI)" section,

Re: [PATCH] arm/its: enable LPIs before mapping the collection table

Hi Julien, > On 27 Apr 2022, at 6:59 pm, Julien Grall wrote: > > Hi Rahul, > > On 27/04/2022 17:14, Rahul Singh wrote: >> MAPC_LPI_OFF ITS command error can be reported to software if LPIs are > > Looking at the spec (ARM IHI 0069H), I can't find a command error named > MAPC_LPI_OFF. Is it so

Re: [PATCH v2] xen/arm: gnttab: cast unused macro arguments to void

On 28.04.2022 11:46, Michal Orzel wrote: > @@ -89,10 +90,12 @@ int replace_grant_host_mapping(unsigned long gpaddr, > mfn_t mfn, > }) > > #define gnttab_shared_gfn(d, t, i) \ > -(((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) > +

Re: [PATCH] x86/cet: Support cet= on the command line

On 28.04.2022 10:52, Andrew Cooper wrote: > @@ -283,6 +283,8 @@ CET is incompatible with 32bit PV guests. If any CET > sub-options are active, > they will override the `pv=32` boolean to `false`. Backwards compatibility > can be maintained with the pv-shim mechanism. > > +* An unqualified

[PATCH v2] xen/arm: p2m don't fall over on FEAT_LPA enabled hw

When we introduced FEAT_LPA to QEMU's -cpu max we discovered older kernels had a bug where the physical address was copied directly from ID_AA64MMFR0_EL1.PARange field. The early cpu_init code of Xen commits the same error by blindly copying across the max supported range. Unsurprisingly when the

Re: [PATCH v2] x86/msr: handle reads to MSR_P5_MC_{ADDR,TYPE}

On 28.04.2022 11:13, Roger Pau Monne wrote: > --- a/xen/arch/x86/cpu/mcheck/mce.h > +++ b/xen/arch/x86/cpu/mcheck/mce.h > @@ -169,6 +169,11 @@ static inline int mce_vendor_bank_msr(const struct vcpu > *v, uint32_t msr) > if (msr >= MSR_IA32_MC0_CTL2 && > msr < MSR_IA32_MCx_CT

Re: [PATCH v2] x86/msr: handle reads to MSR_P5_MC_{ADDR,TYPE}

On Thu, Apr 28, 2022 at 12:39:19PM +0200, Jan Beulich wrote: > On 28.04.2022 11:13, Roger Pau Monne wrote: > > --- a/xen/arch/x86/cpu/mcheck/mce_intel.c > > +++ b/xen/arch/x86/cpu/mcheck/mce_intel.c > > @@ -1008,8 +1008,24 @@ int vmce_intel_wrmsr(struct vcpu *v, uint32_t msr, > > uint64_t val) > >

[ovmf test] 169810: regressions - FAIL

flight 169810 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169810/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [xen-unstable-smoke test] 169781: regressions - FAIL

Hi Stefano, On 28/04/2022 01:47, Stefano Stabellini wrote: On Thu, 28 Apr 2022, Julien Grall wrote: Hi Stefano, On Thu, 28 Apr 2022, 00:02 Stefano Stabellini, wrote It seems to me that it is acceptable to allocate memory with interrupt disabled during __init. I cannot see any dr

[PATCH v3] x86/msr: handle reads to MSR_P5_MC_{ADDR,TYPE}

Windows Server 2019 Essentials will unconditionally attempt to read P5_MC_ADDR MSR at boot and throw a BSOD if injected a #GP. Fix this by mapping MSR_P5_MC_{ADDR,TYPE} to MSR_IA32_MCi_{ADDR,STATUS}, as reported also done by hardware in Intel SDM "Mapping of the Pentium Processor Machine-Check Err

Re: [PATCH v3] x86/msr: handle reads to MSR_P5_MC_{ADDR,TYPE}

On 28.04.2022 13:20, Roger Pau Monne wrote: > Windows Server 2019 Essentials will unconditionally attempt to read > P5_MC_ADDR MSR at boot and throw a BSOD if injected a #GP. > > Fix this by mapping MSR_P5_MC_{ADDR,TYPE} to > MSR_IA32_MCi_{ADDR,STATUS}, as reported also done by hardware in Intel >

[ovmf test] 169811: regressions - FAIL

flight 169811 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169811/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[ovmf test] 169812: regressions - FAIL

flight 169812 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169812/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH] arm/its: enable LPIs before mapping the collection table

On 28/04/2022 11:00, Rahul Singh wrote: Hi Julien, On 27 Apr 2022, at 6:59 pm, Julien Grall wrote: Hi Rahul, On 27/04/2022 17:14, Rahul Singh wrote: MAPC_LPI_OFF ITS command error can be reported to software if LPIs are Looking at the spec (ARM IHI 0069H), I can't find a command error

Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm

On Tue, Apr 26, 2022 at 04:07:45PM -0700, Stefano Stabellini wrote: > > Reported-by: Rahul Singh > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Stefano Stabellini Do you want to take this through the Xen tree or should I pick it up? Either way I'd love to see some testing on x86 as well

[ovmf test] 169814: regressions - FAIL

flight 169814 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169814/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: Virtio on Xen with Rust

On Thu, Apr 14, 2022 at 12:15 PM Viresh Kumar wrote: > Hello, > Hello Viresh [Cc Juergen and Julien] [sorry for the possible format issues and for the late response] > > We verified our hypervisor-agnostic Rust based vhost-user backends with > Qemu > based setup earlier, and there was growi

Re: [PATCH 3/3] x86/monitor: Add new monitor event to catch all vmexits

On Wed, Apr 27, 2022 at 11:34:20AM -0400, Tamas K Lengyel wrote: > Add monitor event that hooks the vmexit handler allowing for both sync and > async monitoring of events. With async monitoring an event is placed on the > monitor ring for each exit and the rest of the vmexit handler resumes > norm

Re: [PATCH 3/3] x86/monitor: Add new monitor event to catch all vmexits

On Thu, Apr 28, 2022 at 9:56 AM Roger Pau Monné wrote: > > On Wed, Apr 27, 2022 at 11:34:20AM -0400, Tamas K Lengyel wrote: > > Add monitor event that hooks the vmexit handler allowing for both sync and > > async monitoring of events. With async monitoring an event is placed on the > > monitor rin

Re: [PATCH] arm/its: enable LPIs before mapping the collection table

Hi Julien, > On 28 Apr 2022, at 1:59 pm, Julien Grall wrote: > > > > On 28/04/2022 11:00, Rahul Singh wrote: >> Hi Julien, >>> On 27 Apr 2022, at 6:59 pm, Julien Grall wrote: >>> >>> Hi Rahul, >>> >>> On 27/04/2022 17:14, Rahul Singh wrote: MAPC_LPI_OFF ITS command error can be reporte

[ovmf test] 169815: regressions - FAIL

flight 169815 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169815/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list

On 4/27/22 5:49 PM, Guilherme G. Piccoli wrote: This patch renames the panic_notifier_list to panic_pre_reboot_list; the idea is that a subsequent patch will refactor the panic path in order to better split the notifiers, running some of them very early, some of them not so early [but still befor

[libvirt test] 169805: regressions - FAIL

flight 169805 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/169805/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-i386-libvirt

[PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen

The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") pat_enabled() returning false (because of PAT initialization being suppressed in the absence of MTRRs being announced to be available) has become a problem: The i915 driver now fails to initialize when runn

Re: [PATCH] cirrus-ci: add myself as maintainer

On 28/04/2022 10:55, Roger Pau Monne wrote: > Given the testing done by Cirrus-CI is FreeBSD only introduce a new > section in the MAINTAINERS file to cover it and add myself as the > maintainer. > > Requested-by: Stefano Stabellini > Signed-off-by: Roger Pau Monné > --- > FWIW, I wouldn't mind i

Re: [PATCH v3 1/2] xsm: create idle domain privileged and demote after setup

On 4/26/22 03:12, Roger Pau Monné wrote: > On Mon, Apr 25, 2022 at 12:39:17PM -0400, Daniel P. Smith wrote: >> On 4/25/22 05:44, Roger Pau Monné wrote: >>> On Fri, Apr 22, 2022 at 12:34:57PM -0400, Daniel P. Smith wrote: diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index d5d07

[xen-unstable test] 169798: regressions - FAIL

flight 169798 xen-unstable real [real] flight 169813 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169798/ http://logs.test-lab.xenproject.org/osstest/logs/169813/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

[ovmf test] 169816: regressions - FAIL

flight 169816 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169816/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[xen-unstable-smoke test] 169807: regressions - FAIL

flight 169807 xen-unstable-smoke real [real] flight 169817 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169807/ http://logs.test-lab.xenproject.org/osstest/logs/169817/ Regressions :-( Tests which did not succeed and are blocking, including tests which co

x86/PV: (lack of) MTRR exposure

Hello, in the course of analyzing the i915 driver causing boot to fail in Linux 5.18 I found that Linux, for all the years, has been running in PV mode as if PAT was (mostly) disabled. This is a result of them tying PAT initialization to MTRR initialization, while we offer PAT but not MTRR in CPUI

Re: [PATCH v4 1/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL

On 27.04.2022 12:47, Roger Pau Monne wrote: > Use the logic to set shadow SPEC_CTRL values in order to implement > support for VIRT_SPEC_CTRL (signaled by VIRT_SSBD CPUID flag) for HVM > guests. This includes using the spec_ctrl vCPU MSR variable to store > the guest set value of VIRT_SPEC_CTRL.SSB

Re: [PATCH] MAINTAINERS: add Rahul as SMMU maintainer

Hi, On 26/04/2022 21:27, Stefano Stabellini wrote: Add Rahul as ARM SMMU maintainer. Create a new explicit entry for "ARM SMMU" also with Julien which is the original contributor of the code and continues to maintain it. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall Cheers, --

Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list

On Wed, Apr 27, 2022 at 07:49:15PM -0300, Guilherme G. Piccoli wrote: > This patch renames the panic_notifier_list to panic_pre_reboot_list; > the idea is that a subsequent patch will refactor the panic path > in order to better split the notifiers, running some of them very > early, some of them n

[qemu-mainline test] 169801: tolerable FAIL - PUSHED

flight 169801 qemu-mainline real [real] flight 169825 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169801/ http://logs.test-lab.xenproject.org/osstest/logs/169825/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-am

Re: [PATCH 12/30] parisc: Replace regular spinlock with spin_trylock on panic path

On 4/28/22 00:49, Guilherme G. Piccoli wrote: > The panic notifiers' callbacks execute in an atomic context, with > interrupts/preemption disabled, and all CPUs not running the panic > function are off, so it's very dangerous to wait on a regular > spinlock, there's a risk of deadlock. > > This pat

[ovmf test] 169821: regressions - FAIL

flight 169821 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169821/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH v2 08/19] xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF

On Thu, Apr 28, 2022 at 11:28 AM Juergen Gross wrote: Hello Juergen [sorry for the possible format issue] Instead of using a private macro for an invalid grant reference use > the common one. > > Signed-off-by: Juergen Gross > --- > drivers/xen/xen-front-pgdir-shbuf.c | 17 - >

[ovmf test] 169828: regressions - FAIL

flight 169828 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169828/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[xen-unstable-smoke test] 169824: tolerable all pass - PUSHED

flight 169824 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/169824/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[ovmf test] 169832: regressions - FAIL

flight 169832 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169832/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[PATCH net-next v2 01/15] eth: remove copies of the NAPI_POLL_WEIGHT define

Defining local versions of NAPI_POLL_WEIGHT with the same values in the drivers just makes refactoring harder. Drop the special defines in a bunch of drivers where the removal is relatively simple so grouping into one patch does not impact reviewability. Signed-off-by: Jakub Kicinski --- CC: ull

Re: x86/PV: (lack of) MTRR exposure

On 4/28/22 11:53 AM, Jan Beulich wrote: Hello, in the course of analyzing the i915 driver causing boot to fail in Linux 5.18 I found that Linux, for all the years, has been running in PV mode as if PAT was (mostly) disabled. This is a result of them tying PAT initialization to MTRR initializat

[linux-linus test] 169809: tolerable FAIL - PUSHED

flight 169809 linux-linus real [real] flight 169833 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169809/ http://logs.test-lab.xenproject.org/osstest/logs/169833/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-

Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm

On Thu, 28 Apr 2022, Christoph Hellwig wrote: > On Tue, Apr 26, 2022 at 04:07:45PM -0700, Stefano Stabellini wrote: > > > Reported-by: Rahul Singh > > > Signed-off-by: Christoph Hellwig > > > > Reviewed-by: Stefano Stabellini > > Do you want to take this through the Xen tree or should I pick i

[ovmf test] 169835: regressions - FAIL

flight 169835 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169835/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm

On 4/28/22 5:49 PM, Stefano Stabellini wrote: On Thu, 28 Apr 2022, Christoph Hellwig wrote: On Tue, Apr 26, 2022 at 04:07:45PM -0700, Stefano Stabellini wrote: Reported-by: Rahul Singh Signed-off-by: Christoph Hellwig Reviewed-by: Stefano Stabellini Do you want to take this through the X

Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm

On Thu, 28 Apr 2022, Boris Ostrovsky wrote: > On 4/28/22 5:49 PM, Stefano Stabellini wrote: > > On Thu, 28 Apr 2022, Christoph Hellwig wrote: > > > On Tue, Apr 26, 2022 at 04:07:45PM -0700, Stefano Stabellini wrote: > > > > > Reported-by: Rahul Singh > > > > > Signed-off-by: Christoph Hellwig > >

Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT

On Thu, Apr 28, 2022 at 08:47:49AM +0200, Jan Beulich wrote: > On 27.04.2022 21:08, Demi Marie Obenour wrote: > > On Wed, Apr 27, 2022 at 10:56:34AM +0200, Jan Beulich wrote: > >> On 19.04.2022 17:49, Demi Marie Obenour wrote: > >>> This hypercall can be used to get the ESRT from the hypervisor. I

[ovmf test] 169837: regressions - FAIL

flight 169837 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169837/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

  1   2   >