[PATCH v2] xen/public: add new macro to ring.h

2022-04-27 Thread Juergen Gross
For the initialization of a ring page by the frontend two macros are available in ring.h: SHARED_RING_INIT() and FRONT_RING_INIT(). All known users use always both of them in direct sequence. Add another macro XEN_FRONT_RING_INIT() combining the two macros. Signed-off-by: Juergen Gross --- V2:

Re: [PATCH v5] x86/vmx: add hvm functions to get/set non-register state

2022-04-27 Thread Jan Beulich
On 27.04.2022 05:46, Tian, Kevin wrote: >> From: Lengyel, Tamas >> Sent: Friday, March 25, 2022 9:33 PM >> >> During VM forking and resetting a failed vmentry has been observed due >> to the guest non-register state going out-of-sync with the guest register >> state. For example, a VM fork reset r

Re: [PATCH v2] xen/public: add new macro to ring.h

2022-04-27 Thread Jan Beulich
On 27.04.2022 09:03, Juergen Gross wrote: > For the initialization of a ring page by the frontend two macros are > available in ring.h: SHARED_RING_INIT() and FRONT_RING_INIT(). > > All known users use always both of them in direct sequence. > > Add another macro XEN_FRONT_RING_INIT() combining t

[ovmf test] 169770: regressions - FAIL

2022-04-27 Thread osstest service owner
flight 169770 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169770/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH v2] xen/public: add new macro to ring.h

2022-04-27 Thread Juergen Gross
On 27.04.22 09:11, Jan Beulich wrote: On 27.04.2022 09:03, Juergen Gross wrote: For the initialization of a ring page by the frontend two macros are available in ring.h: SHARED_RING_INIT() and FRONT_RING_INIT(). All known users use always both of them in direct sequence. Add another macro XEN_

Re: [cxenstored] Potential bug in special watch event firing

2022-04-27 Thread Juergen Gross
Hi Raphael, On 26.04.22 19:02, Raphael Ning wrote: While reading C xenstored code, I noticed that it may send special events like @releaseDomain to (privileged) clients that only watch the root node (/). That's probably not the intended behaviour. For example, when firing @releaseDomain, fire

Re: RMRRs and Phantom Functions

2022-04-27 Thread Roger Pau Monné
On Tue, Apr 26, 2022 at 05:51:32PM +, Andrew Cooper wrote: > Hello, > > Edvin has found a machine with some very weird properties.  It is an HP > ProLiant BL460c Gen8 with: > >  \-[:00]-+-00.0  Intel Corporation Xeon E5/Core i7 DMI2 > +-01.0-[11]-- > +-01.1-[02]-

[xen-unstable test] 169756: regressions - FAIL

2022-04-27 Thread osstest service owner
flight 169756 xen-unstable real [real] flight 169771 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169756/ http://logs.test-lab.xenproject.org/osstest/logs/169771/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

Re: [PATCH] MAINTAINERS: add Rahul as SMMU maintainer

2022-04-27 Thread Bertrand Marquis
Hi, > On 26 Apr 2022, at 21:27, Stefano Stabellini wrote: > > Add Rahul as ARM SMMU maintainer. Create a new explicit entry for "ARM > SMMU" also with Julien which is the original contributor of the code and > continues to maintain it. > Thanks Rahul to step up to handle this :-) > Signed-of

Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration

2022-04-27 Thread Oleksandr
On 25.04.22 16:12, Roger Pau Monné wrote: Hello Roger On Sat, Apr 23, 2022 at 10:39:14AM +0300, Oleksandr wrote: On 22.04.22 12:41, Roger Pau Monné wrote: Hello Roger On Fri, Apr 08, 2022 at 09:21:04PM +0300, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko This patch adds bas

Re: [PATCH v3 1/4] Grab the EFI System Resource Table and check it

2022-04-27 Thread Jan Beulich
On 19.04.2022 17:40, Demi Marie Obenour wrote: > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > @@ -171,7 +171,7 @@ static void __init > efi_arch_process_memory_map(EFI_SYSTEM_TABLE *SystemTable, > { > case EfiBootServicesCode: > case EfiBootServ

Re: [PATCH] MAINTAINERS: add Rahul as SMMU maintainer

2022-04-27 Thread Rahul Singh
Hi, > On 26 Apr 2022, at 9:27 pm, Stefano Stabellini wrote: > > Add Rahul as ARM SMMU maintainer. Create a new explicit entry for "ARM > SMMU" also with Julien which is the original contributor of the code and > continues to maintain it. > > Signed-off-by: Stefano Stabellini Acked-by: Rahul

Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration

2022-04-27 Thread Roger Pau Monné
On Wed, Apr 27, 2022 at 11:20:04AM +0300, Oleksandr wrote: > > On 25.04.22 16:12, Roger Pau Monné wrote: > > > Hello Roger > > > > On Sat, Apr 23, 2022 at 10:39:14AM +0300, Oleksandr wrote: > > > On 22.04.22 12:41, Roger Pau Monné wrote: > > > > > > > > > Hello Roger > > > > > > > On Fri, A

Re: [PATCH V7 1/2] libxl: Add support for Virtio disk configuration

2022-04-27 Thread Juergen Gross
On 27.04.22 10:27, Roger Pau Monné wrote: On Wed, Apr 27, 2022 at 11:20:04AM +0300, Oleksandr wrote: On 25.04.22 16:12, Roger Pau Monné wrote: Hello Roger On Sat, Apr 23, 2022 at 10:39:14AM +0300, Oleksandr wrote: On 22.04.22 12:41, Roger Pau Monné wrote: Hello Roger On Fri, Apr 08, 2

Re: [PATCH v3 2/4] Add a dedicated memory region for the ESRT

2022-04-27 Thread Jan Beulich
On 19.04.2022 17:40, Demi Marie Obenour wrote: > This allows the ESRT to be marked as reserved without having to waste a > potentially large amount of memory. This patch assumes that Xen can > handle memory regions that are not page-aligned. If it cannot, > additional code will need to be added t

Re: [PATCH v3 1/4] Grab the EFI System Resource Table and check it

2022-04-27 Thread Jan Beulich
On 19.04.2022 17:40, Demi Marie Obenour wrote: > @@ -1056,19 +1091,19 @@ static void __init efi_exit_boot(EFI_HANDLE > ImageHandle, EFI_SYSTEM_TABLE *Syste > EFI_STATUS status; > UINTN info_size = 0, map_key; > bool retry; > -#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP > unsigned

[ovmf test] 169772: regressions - FAIL

2022-04-27 Thread osstest service owner
flight 169772 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169772/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH] xen/arm: alternative: Don't call vmap() within stop_machine_run()

2022-04-27 Thread Julien Grall
Hi Jan, On 27/04/2022 07:42, Jan Beulich wrote: On 26.04.2022 22:06, Julien Grall wrote: From: Julien Grall Commit 88a037e2cfe1 "page_alloc: assert IRQs are enabled in heap alloc/free" extended the checks in the buddy allocator to catch any use of the helpers from context with interrupts disa

Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT

2022-04-27 Thread Jan Beulich
On 19.04.2022 17:49, Demi Marie Obenour wrote: > This hypercall can be used to get the ESRT from the hypervisor. It > returning successfully also indicates that Xen has reserved the ESRT and > it can safely be parsed by dom0. I'm not convinced of the need, and I view such an addition as inconsist

Re: [PATCH v3 1/4] Grab the EFI System Resource Table and check it

2022-04-27 Thread Jan Beulich
On 19.04.2022 17:40, Demi Marie Obenour wrote: > --- a/xen/include/efi/efiapi.h > +++ b/xen/include/efi/efiapi.h > @@ -882,6 +882,9 @@ typedef struct _EFI_BOOT_SERVICES { > #define SAL_SYSTEM_TABLE_GUID\ > { 0xeb9d2d32, 0x2d88, 0x11d3, {0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1, > 0x4d} }

Re: [PATCH] fix invalid frontend path for set_mtu

2022-04-27 Thread Anthony PERARD
On Tue, Apr 19, 2022 at 01:04:18PM +0100, James Dingwall wrote: > Thank you for your feedback. I've updated the patch as suggested. I've also > incorporated two other changes, one is a simple style change for consistency, > the other is to change a the test for a valid mtu from > 0 to >= 68. I c

Re: [PATCH v4 2/2] x86/monitor: Add new monitor event to catch all vmexits

2022-04-27 Thread Roger Pau Monné
On Tue, Apr 26, 2022 at 02:53:54PM -0400, Tamas K Lengyel wrote: > On Tue, Apr 26, 2022 at 4:50 AM Roger Pau Monné wrote: > > > > On Mon, Apr 25, 2022 at 11:40:11AM -0400, Tamas K Lengyel wrote: > > > On Mon, Apr 25, 2022 at 10:41 AM Roger Pau Monné > > > wrote: > > > > > > > > On Wed, Apr 13, 2

[PATCH V3 0/6] populate/unpopulate memory when domain on static

2022-04-27 Thread Penny Zheng
Today when a domain unpopulates the memory on runtime, they will always hand the memory over to the heap allocator. And it will be a problem if it is a static domain. Pages used as guest RAM for static domain shall always be reserved to this domain only, and not be used for any other purposes, so t

[PATCH v3 2/6] xen: do not merge reserved pages in free_heap_pages()

2022-04-27 Thread Penny Zheng
There is a slim chance that free_heap_pages() may decide to merge a chunk from the static region(PGC_reserved) with the about-to-be-free chunk. So in order to avoid the above scenario, this commit updates free_heap_pages() to check whether the predecessor and/or successor has PGC_reserved set, whe

[PATCH v3 3/6] xen: add field "flags" to cover all internal CDF_XXX

2022-04-27 Thread Penny Zheng
With more and more CDF_xxx internal flags in and to save the space, this commit introduces a new field "flags" in struct domain to store CDF_* internal flags directly. Another new CDF_xxx will be introduced in the next patch. Signed-off-by: Penny Zheng --- v3 changes: - change fixed width type u

[PATCH v3 4/6] xen/arm: introduce CDF_staticmem

2022-04-27 Thread Penny Zheng
In order to have an easy and quick way to find out whether this domain memory is statically configured, this commit introduces a new flag CDF_staticmem and a new helper is_domain_using_staticmem() to tell. Reviewed-by: Stefano Stabellini Signed-off-by: Penny Zheng --- v3 changes: - change name f

[PATCH v3 5/6] xen/arm: unpopulate memory when domain is static

2022-04-27 Thread Penny Zheng
Today when a domain unpopulates the memory on runtime, they will always hand the memory back to the heap allocator. And it will be a problem if domain is static. Pages as guest RAM for static domain shall be reserved to only this domain and not be used for any other purposes, so they shall never g

[PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap

2022-04-27 Thread Penny Zheng
When static domain populates memory through populate_physmap on runtime, other than allocating from heap, it shall retrieve reserved pages from resv_page_list to make sure that guest RAM is still restricted in statically configured memory regions. And this commit introduces a new helper acquire_res

Re: [PATCH v3 2/6] xen: do not merge reserved pages in free_heap_pages()

2022-04-27 Thread Julien Grall
Hi, On 27/04/2022 10:27, Penny Zheng wrote: There is a slim chance that free_heap_pages() may decide to merge a chunk from the static region(PGC_reserved) with the about-to-be-free chunk. This sentence tells me that the merge can happen but it doesn't tell me the cases. I think the second part

Re: [cxenstored] Potential bug in special watch event firing

2022-04-27 Thread Raphael Ning
Hi Juergen, On 27/04/2022 08:30, Juergen Gross wrote: > [...] >> The xenstore documentation is not clear about whether @ should be >> considered children of /. But I find it counterintuitive that clients may be >> notified about a special event without explicitly subscribing to it. Is it a >> b

Re: [PATCH v3 3/6] xen: add field "flags" to cover all internal CDF_XXX

2022-04-27 Thread Julien Grall
Hi, On 27/04/2022 10:27, Penny Zheng wrote: With more and more CDF_xxx internal flags in and to save the space, this commit introduces a new field "flags" in struct domain to store CDF_* internal flags directly. Another new CDF_xxx will be introduced in the next patch. Signed-off-by: Penny Zhe

[PATCH 1/8] xen/arm: bootfdt.c: Remove unused-but-set variable

2022-04-27 Thread Michal Orzel
Function device_tree_node_compatible defines and sets a variable mlen but does not make use of it. Remove this variable. Signed-off-by: Michal Orzel --- xen/arch/arm/bootfdt.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index e318ef9603..

[PATCH 0/8] xen: Remove unused-but-set variables

2022-04-27 Thread Michal Orzel
Fix all the gcc findings related to unused-but-set variables when performing Xen compilation using target allyesconfig on arm32 and arm64. This is done by temporarily removing flag -Wno-unused-but-set-variable set in Config.mk. This series acts as a prerequisite to get rid of this flag one day. M

[PATCH 2/8] efi/boot.c: Remove unused-but-set variable

2022-04-27 Thread Michal Orzel
Function efi_start defines and sets a variable size but does not make use of it. Remove this variable. Signed-off-by: Michal Orzel --- xen/common/efi/boot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index ac1b235372..a25

[PATCH 3/8] gnttab: Remove unused-but-set variable

2022-04-27 Thread Michal Orzel
Function unmap_common_complete defines and sets a variable ld that is later on passed to a macro gnttab_host_mapping_get_page_type. On arm this macro does not make use of any arguments causing a compiler to warn about unused-but-set variable (when -Wunused-but-set-variable is enabled). Fix this by

[PATCH 5/8] xen/sched: Remove unused-but-set variable

2022-04-27 Thread Michal Orzel
Function schedule_cpu_add defines and sets a variable old_unit but does not make use of it. Remove this variable. Signed-off-by: Michal Orzel --- xen/common/sched/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index

[PATCH 6/8] platforms/xgene: Make use of dt_device_get_address return value

2022-04-27 Thread Michal Orzel
Currently function xgene_check_pirq_eoi assignes a return value of dt_device_get_address to a variable res but does not make use of it. Fix it by making use of res in a condition checking the result of a call to dt_device_get_address instead of checking the address stored in dbase. Signed-off-by:

[PATCH 8/8] drivers/exynos4210: Remove unused-but-set variable

2022-04-27 Thread Michal Orzel
Function exynos4210_uart_init_preirq defines and sets a variable divisor but does not make use of it. Remove the definition and comment out the assignment as this function already has some TODOs. Signed-off-by: Michal Orzel --- Commenting out a code is a bad practise as well as using TODOs. Howev

[PATCH 4/8] xen/arm: smmu.c: Remove unused-but-set variable

2022-04-27 Thread Michal Orzel
Function arm_smmu_init_context_bank defines and sets a variable gr0_base but does not make use of it. Remove this variable. Signed-off-by: Michal Orzel --- xen/drivers/passthrough/arm/smmu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c

[PATCH 7/8] platforms/omap: Remove unused-but-set variable

2022-04-27 Thread Michal Orzel
Function omap5_init_time defines and sets a variable den but does not make use of it. Remove this variable. Signed-off-by: Michal Orzel --- xen/arch/arm/platforms/omap5.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/arm/platforms/omap5.c b/xen/arch/arm/platforms

Re: [PATCH v3 4/6] xen/arm: introduce CDF_staticmem

2022-04-27 Thread Julien Grall
Hi Penny, On 27/04/2022 10:27, Penny Zheng wrote: In order to have an easy and quick way to find out whether this domain memory is statically configured, this commit introduces a new flag CDF_staticmem and a new helper is_domain_using_staticmem() to tell. Reviewed-by: Stefano Stabellini The

Re: [PATCH 2/8] efi/boot.c: Remove unused-but-set variable

2022-04-27 Thread Jan Beulich
On 27.04.2022 11:49, Michal Orzel wrote: > Function efi_start defines and sets a variable size but does not > make use of it. Remove this variable. > > Signed-off-by: Michal Orzel Reviewed-by: Jan Beulich

Re: [PATCH 3/8] gnttab: Remove unused-but-set variable

2022-04-27 Thread Jan Beulich
On 27.04.2022 11:49, Michal Orzel wrote: > Function unmap_common_complete defines and sets a variable ld that is > later on passed to a macro gnttab_host_mapping_get_page_type. On arm > this macro does not make use of any arguments causing a compiler to > warn about unused-but-set variable (when -W

[ovmf test] 169776: regressions - FAIL

2022-04-27 Thread osstest service owner
flight 169776 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169776/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: RMRRs and Phantom Functions

2022-04-27 Thread Andrew Cooper
On 27/04/2022 07:59, Jan Beulich wrote: > On 26.04.2022 19:51, Andrew Cooper wrote: >> Hello, >> >> Edvin has found a machine with some very weird properties.  It is an HP >> ProLiant BL460c Gen8 with: >> >>  \-[:00]-+-00.0  Intel Corporation Xeon E5/Core i7 DMI2 >> +-01.0-[11]-- >

Re: [PATCH 5/8] xen/sched: Remove unused-but-set variable

2022-04-27 Thread Juergen Gross
On 27.04.22 11:49, Michal Orzel wrote: Function schedule_cpu_add defines and sets a variable old_unit but does not make use of it. Remove this variable. Signed-off-by: Michal Orzel Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP

Re: [PATCH v3 5/6] xen/arm: unpopulate memory when domain is static

2022-04-27 Thread Julien Grall
Hi Penny, On 27/04/2022 10:27, Penny Zheng wrote: Today when a domain unpopulates the memory on runtime, they will always hand the memory back to the heap allocator. And it will be a problem if domain is static. Pages as guest RAM for static domain shall be reserved to only this domain and not

Re: RMRRs and Phantom Functions

2022-04-27 Thread Andrew Cooper
On 27/04/2022 09:03, Roger Pau Monne wrote: > On Tue, Apr 26, 2022 at 05:51:32PM +, Andrew Cooper wrote: >> Hello, >> >> Edvin has found a machine with some very weird properties.  It is an HP >> ProLiant BL460c Gen8 with: >> >>  \-[:00]-+-00.0  Intel Corporation Xeon E5/Core i7 DMI2 >>    

Re: RMRRs and Phantom Functions

2022-04-27 Thread Roger Pau Monné
On Wed, Apr 27, 2022 at 10:05:54AM +, Andrew Cooper wrote: > On 27/04/2022 07:59, Jan Beulich wrote: > > On 26.04.2022 19:51, Andrew Cooper wrote: > >> Hello, > >> > >> Edvin has found a machine with some very weird properties.  It is an HP > >> ProLiant BL460c Gen8 with: > >> > >>  \-[:00]

Re: RMRRs and Phantom Functions

2022-04-27 Thread Jan Beulich
On 27.04.2022 12:05, Andrew Cooper wrote: > On 27/04/2022 07:59, Jan Beulich wrote: >> On 26.04.2022 19:51, Andrew Cooper wrote: >>> Hello, >>> >>> Edvin has found a machine with some very weird properties.  It is an HP >>> ProLiant BL460c Gen8 with: >>> >>>  \-[:00]-+-00.0  Intel Corporation X

RE: [PATCH v3 5/6] xen/arm: unpopulate memory when domain is static

2022-04-27 Thread Penny Zheng
Hi julien > -Original Message- > From: Julien Grall > Sent: Wednesday, April 27, 2022 6:11 PM > To: Penny Zheng ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Henry Wang ; > Stefano Stabellini ; Bertrand Marquis > ; Volodymyr Babchuk > ; Andrew Cooper > ; George Dunlap ; > Jan Beulich

Re: [PATCH v3 5/6] xen/arm: unpopulate memory when domain is static

2022-04-27 Thread Julien Grall
Hi Penny, On 27/04/2022 11:19, Penny Zheng wrote: +/* + * Put free pages on the resv page list after having taken them + * off the "normal" page list, when pages from static memory */ +#ifdef CONFIG_STATIC_MEMORY +#define arch_free_heap_page(d, pg) ({ \ +page_list_del(pg,

[qemu-mainline test] 169762: tolerable FAIL - PUSHED

2022-04-27 Thread osstest service owner
flight 169762 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/169762/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds18 guest-start/debian.repeat fail REGR. vs. 169749 Tests which did not succee

RE: [PATCH v3 5/6] xen/arm: unpopulate memory when domain is static

2022-04-27 Thread Penny Zheng
Hi julien > -Original Message- > From: Julien Grall > Sent: Wednesday, April 27, 2022 6:23 PM > To: Penny Zheng ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Henry Wang ; > Stefano Stabellini ; Bertrand Marquis > ; Volodymyr Babchuk > ; Andrew Cooper > ; George Dunlap ; > Jan Beulich

[PATCH v4 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests

2022-04-27 Thread Roger Pau Monne
Hello, The following series implements support for MSR_VIRT_SPEC_CTRL (VIRT_SSBD) on different AMD CPU families. Note that the support is added backwards, starting with the newer CPUs that support MSR_SPEC_CTRL and moving to the older ones either using MSR_VIRT_SPEC_CTRL or the SSBD bit in LS_CFG

[PATCH v4 1/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL

2022-04-27 Thread Roger Pau Monne
Use the logic to set shadow SPEC_CTRL values in order to implement support for VIRT_SPEC_CTRL (signaled by VIRT_SSBD CPUID flag) for HVM guests. This includes using the spec_ctrl vCPU MSR variable to store the guest set value of VIRT_SPEC_CTRL.SSBD, which will be OR'ed with any SPEC_CTRL values bei

[PATCH v4 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests

2022-04-27 Thread Roger Pau Monne
Allow HVM guests access to MSR_VIRT_SPEC_CTRL if the platform Xen is running on has support for it. This requires adding logic in the vm{entry,exit} paths for SVM in order to context switch between the hypervisor value and the guest one. The added handlers for context switch will also be used for

[PATCH v4 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD

2022-04-27 Thread Roger Pau Monne
Expose VIRT_SSBD to guests if the hardware supports setting SSBD in the LS_CFG MSR (a.k.a. non-architectural way). Different AMD CPU families use different bits in LS_CFG, so exposing VIRT_SPEC_CTRL.SSBD allows for an unified way of exposing SSBD support to guests on AMD hardware that's compatible

Re: RMRRs and Phantom Functions

2022-04-27 Thread Roger Pau Monné
On Wed, Apr 27, 2022 at 10:17:49AM +, Andrew Cooper wrote: > On 27/04/2022 09:03, Roger Pau Monne wrote: > > On Tue, Apr 26, 2022 at 05:51:32PM +, Andrew Cooper wrote: > >> Specifying pci-phantom=04:00,1 does appear to work around the faults, > >> but it's not right, because functions 1 thr

[PATCH] bump default SeaBIOS version to 1.16.0

2022-04-27 Thread Jan Beulich
Signed-off-by: Jan Beulich --- a/Config.mk +++ b/Config.mk @@ -232,7 +232,7 @@ OVMF_UPSTREAM_REVISION ?= 7b4a99be8a39c1 QEMU_UPSTREAM_REVISION ?= master MINIOS_UPSTREAM_REVISION ?= 83ff43bff4bdd6879539fcb2b3d6ba5e61a64135 -SEABIOS_UPSTREAM_REVISION ?= rel-1.15.0 +SEABIOS_UPSTREAM_REVISION ?=

[PATCH v3] x86+libxl: correct p2m (shadow) memory pool size calculation

2022-04-27 Thread Jan Beulich
The reference "to shadow the resident processes" is applicable to domains (potentially) running in shadow mode only. Adjust the calculations accordingly. This, however, requires further parameters. Since the original function is deprecated anyway, and since it can't be changed (for being part of a

Re: [PATCH 3/8] gnttab: Remove unused-but-set variable

2022-04-27 Thread Michal Orzel
Hi Jan, On 27.04.2022 11:59, Jan Beulich wrote: > On 27.04.2022 11:49, Michal Orzel wrote: >> Function unmap_common_complete defines and sets a variable ld that is >> later on passed to a macro gnttab_host_mapping_get_page_type. On arm >> this macro does not make use of any arguments causing a com

Re: [PATCH v3] x86+libxl: correct p2m (shadow) memory pool size calculation

2022-04-27 Thread Roger Pau Monné
On Wed, Apr 27, 2022 at 12:57:17PM +0200, Jan Beulich wrote: > The reference "to shadow the resident processes" is applicable to > domains (potentially) running in shadow mode only. Adjust the > calculations accordingly. This, however, requires further parameters. > Since the original function is d

Re: [PATCH 1/4] x86/mwait-idle: switch to asm/intel-family.h naming

2022-04-27 Thread Roger Pau Monné
On Tue, Apr 26, 2022 at 12:04:45PM +0200, Jan Beulich wrote: > This brings us (back) closer to the original Linux source. > > While touching mwait_idle_state_table_update() also drop a stray leading > blank. > > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Thanks, Roger.

[ovmf test] 169778: regressions - FAIL

2022-04-27 Thread osstest service owner
flight 169778 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169778/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH 2/4] mwait-idle: add SPR support

2022-04-27 Thread Roger Pau Monné
On Tue, Apr 26, 2022 at 12:05:07PM +0200, Jan Beulich wrote: > From: Artem Bityutskiy > > Add Sapphire Rapids Xeon support. > > Up until very recently, the C1 and C1E C-states were independent, but this > has changed in some new chips, including Sapphire Rapids Xeon (SPR). In these > chips the C

[xen-unstable-smoke test] 169773: tolerable all pass - PUSHED

2022-04-27 Thread osstest service owner
flight 169773 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/169773/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH] softmmu/vl: Fence 'xenfb' if Xen support is not compiled in

2022-04-27 Thread Thomas Huth
The 'xenfb' parameter for the '-vga' command line option is currently always enabled unconditionally (since the xenfb is not a proper QOM device that could be tested via its class name). That means it also shows up if Xen is not enabled at all, e.g. like this: $ ./qemu-system-sparc -vga help non

Re: [PATCH 3/8] gnttab: Remove unused-but-set variable

2022-04-27 Thread Andrew Cooper
On 27/04/2022 12:06, Michal Orzel wrote: > Hi Jan, > > On 27.04.2022 11:59, Jan Beulich wrote: >> On 27.04.2022 11:49, Michal Orzel wrote: >>> Function unmap_common_complete defines and sets a variable ld that is >>> later on passed to a macro gnttab_host_mapping_get_page_type. On arm >>> this macr

Re: [PATCH 3/4] mwait-idle: add 'preferred_cstates' module argument

2022-04-27 Thread Roger Pau Monné
On Tue, Apr 26, 2022 at 12:05:28PM +0200, Jan Beulich wrote: > From: Artem Bityutskiy > > On Sapphire Rapids Xeon (SPR) the C1 and C1E states are basically mutually > exclusive - only one of them can be enabled. By default, 'intel_idle' driver > enables C1 and disables C1E. However, some users pr

Re: [PATCH 3/8] gnttab: Remove unused-but-set variable

2022-04-27 Thread Michal Orzel
Hi Andrew, On 27.04.2022 14:33, Andrew Cooper wrote: > On 27/04/2022 12:06, Michal Orzel wrote: >> Hi Jan, >> >> On 27.04.2022 11:59, Jan Beulich wrote: >>> On 27.04.2022 11:49, Michal Orzel wrote: Function unmap_common_complete defines and sets a variable ld that is later on passed to a

[ovmf test] 169780: regressions - FAIL

2022-04-27 Thread osstest service owner
flight 169780 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169780/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH 4/4] mwait-idle: add core C6 optimization for SPR

2022-04-27 Thread Roger Pau Monné
On Tue, Apr 26, 2022 at 12:06:14PM +0200, Jan Beulich wrote: > From: Artem Bityutskiy > > Add a Sapphire Rapids Xeon C6 optimization, similar to what we have for Sky > Lake > Xeon: if package C6 is disabled, adjust C6 exit latency and target residency > to > match core C6 values, instead of usi

Re: [PATCH v4 01/21] AMD/IOMMU: correct potentially-UB shifts

2022-04-27 Thread Andrew Cooper
On 25/04/2022 09:30, Jan Beulich wrote: > Recent changes (likely 5fafa6cf529a ["AMD/IOMMU: have callers specify > the target level for page table walks"]) have made Coverity notice a > shift count in iommu_pde_from_dfn() which might in theory grow too > large. While this isn't a problem in practice

Re: [PATCH v4 02/21] IOMMU: simplify unmap-on-error in iommu_map()

2022-04-27 Thread Andrew Cooper
On 25/04/2022 09:32, Jan Beulich wrote: > As of 68a8aa5d7264 ("iommu: make map and unmap take a page count, > similar to flush") there's no need anymore to have a loop here. > > Suggested-by: Roger Pau Monné > Signed-off-by: Jan Beulich > --- > v3: New. > > --- a/xen/drivers/passthrough/iommu.c >

Re: [PATCH] fix invalid frontend path for set_mtu

2022-04-27 Thread James Dingwall
On 2022-04-27 10:17, Anthony PERARD wrote: On Tue, Apr 19, 2022 at 01:04:18PM +0100, James Dingwall wrote: Thank you for your feedback. I've updated the patch as suggested. I've also incorporated two other changes, one is a simple style change for consistency, the other is to change a the tes

[PATCH] SUPPORT.MD: Correct the amount of physical memory supported for Arm

2022-04-27 Thread Julien Grall
From: Julien Grall As part of XSA-385, SUPPORT.MD gained a statement regarding the amount of physical memory supported. However, booting Xen on a Arm platform with that amount of memory would result to a breakage because the frametable area is too small. The wiki [1] (as of April 2022) claims w

Re: [PATCH] SUPPORT.md: extend security support for hosts to 12 TiB of memory

2022-04-27 Thread Julien Grall
Hi, On 06/04/2022 16:23, Julien Grall wrote: On 06/04/2022 16:22, Jan Beulich wrote: On 06.04.2022 17:15, Julien Grall wrote: On 06/04/2022 15:44, Jan Beulich wrote: c49ee0329ff3 ("SUPPORT.md: limit security support for hosts with very much memory"), as a result of XSA-385, restricted securit

[PATCH] qemu-options: Limit the -xen options to x86 and arm

2022-04-27 Thread Thomas Huth
The Xen hypervisor is only available on x86 and arm - thus let's limit the related options to these targets. Signed-off-by: Thomas Huth --- qemu-options.hx | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 1764eebfaf..cc3a39d21a 10

Re: [PATCH] fix invalid frontend path for set_mtu

2022-04-27 Thread Anthony PERARD
On Wed, Apr 27, 2022 at 02:20:53PM +0100, James Dingwall wrote: > commit f6ec92717522e74b4cc3aa4160b8ad6884e0b50c > Author: James Dingwall > Date: Tue Apr 19 12:45:31 2022 +0100 > > The set_mtu() function of xen-network-common.sh currently has this code: > > if [ ${type_if}

Re: [PATCH] SUPPORT.MD: Correct the amount of physical memory supported for Arm

2022-04-27 Thread Jan Beulich
On 27.04.2022 15:22, Julien Grall wrote: > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -50,9 +50,10 @@ For the Cortex A57 r0p0 - r1p1, see Errata 832075. > > ### Physical Memory > > -Status: Supported up to 8 TiB > - > -Hosts with more memory are supported, but not security supported. > +

Re: [PATCH] softmmu/vl: Fence 'xenfb' if Xen support is not compiled in

2022-04-27 Thread Anthony PERARD
On Wed, Apr 27, 2022 at 02:33:16PM +0200, Thomas Huth wrote: > The 'xenfb' parameter for the '-vga' command line option is currently > always enabled unconditionally (since the xenfb is not a proper QOM > device that could be tested via its class name). That means it also > shows up if Xen is not e

Re: [PATCH] SUPPORT.MD: Correct the amount of physical memory supported for Arm

2022-04-27 Thread Julien Grall
Hi Jan, On 27/04/2022 14:34, Jan Beulich wrote: On 27.04.2022 15:22, Julien Grall wrote: --- a/SUPPORT.md +++ b/SUPPORT.md @@ -50,9 +50,10 @@ For the Cortex A57 r0p0 - r1p1, see Errata 832075. ### Physical Memory -Status: Supported up to 8 TiB - -Hosts with more memory are supporte

Re: [PATCH 3/4] mwait-idle: add 'preferred_cstates' module argument

2022-04-27 Thread Jan Beulich
On 27.04.2022 14:45, Roger Pau Monné wrote: > On Tue, Apr 26, 2022 at 12:05:28PM +0200, Jan Beulich wrote: >> From: Artem Bityutskiy >> >> On Sapphire Rapids Xeon (SPR) the C1 and C1E states are basically mutually >> exclusive - only one of them can be enabled. By default, 'intel_idle' driver >> e

Re: [PATCH] qemu-options: Limit the -xen options to x86 and arm

2022-04-27 Thread Anthony PERARD
On Wed, Apr 27, 2022 at 03:31:56PM +0200, Thomas Huth wrote: > The Xen hypervisor is only available on x86 and arm - thus let's > limit the related options to these targets. > > Signed-off-by: Thomas Huth Acked-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH] SUPPORT.MD: Correct the amount of physical memory supported for Arm

2022-04-27 Thread Bertrand Marquis
Hi Julien, > On 27 Apr 2022, at 14:22, Julien Grall wrote: > > From: Julien Grall > > As part of XSA-385, SUPPORT.MD gained a statement regarding the amount > of physical memory supported. > > However, booting Xen on a Arm platform with that amount of memory would > result to a breakage becau

[PATCH] tools/xenstore: don't let special watches be children of /

2022-04-27 Thread Juergen Gross
When firing special watches (e.g. "@releaseDomain"), they will be regarded to be valid children of the "/" node. So a domain having registered a watch for "/" and having the privilege to receive the special watches will receive those special watch events for the registered "/" watch. Fix that by c

Re: [PATCH v4 01/21] AMD/IOMMU: correct potentially-UB shifts

2022-04-27 Thread Jan Beulich
On 27.04.2022 15:08, Andrew Cooper wrote: > On 25/04/2022 09:30, Jan Beulich wrote: >> Recent changes (likely 5fafa6cf529a ["AMD/IOMMU: have callers specify >> the target level for page table walks"]) have made Coverity notice a >> shift count in iommu_pde_from_dfn() which might in theory grow too

[PATCH] x86/mm: Remove unnecessary mfn_valid() call from get_page_from_l1e()

2022-04-27 Thread Andrew Cooper
mfn_valid() is not a trivially simple, and contains an evaluate_nospec() for speculative defence. Avoid calling it redundantly, and just store the result of the first call. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/mm.c | 8 +--- 1

Re: [PATCH v4 02/21] IOMMU: simplify unmap-on-error in iommu_map()

2022-04-27 Thread Jan Beulich
On 27.04.2022 15:16, Andrew Cooper wrote: > On 25/04/2022 09:32, Jan Beulich wrote: >> --- a/xen/drivers/passthrough/iommu.c >> +++ b/xen/drivers/passthrough/iommu.c >> @@ -308,11 +308,9 @@ int iommu_map(struct domain *d, dfn_t df >> d->domain_id, dfn_x(dfn_add(dfn, i)), >>

Re: [PATCH] x86/mm: Remove unnecessary mfn_valid() call from get_page_from_l1e()

2022-04-27 Thread Jan Beulich
On 27.04.2022 16:04, Andrew Cooper wrote: > mfn_valid() is not a trivially simple, and contains an evaluate_nospec() for > speculative defence. Avoid calling it redundantly, and just store the result > of the first call. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

Re: [PATCH] tools/xenstore: don't let special watches be children of /

2022-04-27 Thread Raphael Ning
Hi Juergen, On 27/04/2022 14:51, Juergen Gross wrote: > When firing special watches (e.g. "@releaseDomain"), they will be > regarded to be valid children of the "/" node. So a domain having > registered a watch for "/" and having the privilege to receive > the special watches will receive those s

Re: [PATCH] tools/xenstore: don't let special watches be children of /

2022-04-27 Thread Juergen Gross
On 27.04.22 16:25, Raphael Ning wrote: Hi Juergen, On 27/04/2022 14:51, Juergen Gross wrote: When firing special watches (e.g. "@releaseDomain"), they will be regarded to be valid children of the "/" node. So a domain having registered a watch for "/" and having the privilege to receive the sp

[ovmf test] 169783: regressions - FAIL

2022-04-27 Thread osstest service owner
flight 169783 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169783/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH 3/4] mwait-idle: add 'preferred_cstates' module argument

2022-04-27 Thread Roger Pau Monné
On Wed, Apr 27, 2022 at 03:41:24PM +0200, Jan Beulich wrote: > On 27.04.2022 14:45, Roger Pau Monné wrote: > > On Tue, Apr 26, 2022 at 12:05:28PM +0200, Jan Beulich wrote: > >> From: Artem Bityutskiy > >> > >> On Sapphire Rapids Xeon (SPR) the C1 and C1E states are basically mutually > >> exclusiv

Re: [PATCH 3/4] mwait-idle: add 'preferred_cstates' module argument

2022-04-27 Thread Jan Beulich
On 27.04.2022 17:06, Roger Pau Monné wrote: > On Wed, Apr 27, 2022 at 03:41:24PM +0200, Jan Beulich wrote: >> On 27.04.2022 14:45, Roger Pau Monné wrote: >>> On Tue, Apr 26, 2022 at 12:05:28PM +0200, Jan Beulich wrote: --- unstable.orig/xen/arch/x86/cpu/mwait-idle.c +++ unstable/xen/arch/

Re: [PATCH v12] xen/arm64: io: Handle data abort due to cache maintenance instructions

2022-04-27 Thread Julien Grall
Hi, On 18/04/2022 22:02, Stefano Stabellini wrote: On Fri, 1 Apr 2022, Julien Grall wrote: On 24/03/2022 13:37, Ayan Kumar Halder wrote: /* * At this point, we know that the instruction is either valid or has been * decoded successfully. Thus, Xen should be allowed to ex

Re: [PATCH v5] x86/vmx: add hvm functions to get/set non-register state

2022-04-27 Thread Tamas K Lengyel
On Wed, Apr 27, 2022 at 3:07 AM Jan Beulich wrote: > > On 27.04.2022 05:46, Tian, Kevin wrote: > >> From: Lengyel, Tamas > >> Sent: Friday, March 25, 2022 9:33 PM > >> > >> During VM forking and resetting a failed vmentry has been observed due > >> to the guest non-register state going out-of-syn

[PATCH net-next 01/14] eth: remove copies of the NAPI_POLL_WEIGHT define

2022-04-27 Thread Jakub Kicinski
Defining local versions of NAPI_POLL_WEIGHT with the same values in the drivers just makes refactoring harder. Drop the special defines in a bunch of drivers where the removal is relatively simple so grouping into one patch does not impact reviewability. Signed-off-by: Jakub Kicinski --- CC: ull

[libvirt test] 169768: regressions - FAIL

2022-04-27 Thread osstest service owner
flight 169768 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/169768/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

  1   2   >