Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration

On 21.12.21 17:46, Anthony PERARD wrote: On Fri, Dec 17, 2021 at 06:50:02PM +0200, Oleksandr wrote: On 17.12.21 17:26, Juergen Gross wrote: On 15.12.21 22:36, Oleksandr wrote: On 15.12.21 17:58, Juergen Gross wrote: In practice we are having something like the "protocol" already today: the di

[linux-linus test] 167614: tolerable FAIL - PUSHED

flight 167614 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/167614/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 167592 test-amd64-amd64-qemuu-nested-amd 20

[PATCH] xen, blkback: fix persistent grants negotiation

Given dom0 supports persistent grants but the guest does not. Then, when attaching a block device during runtime of the guest, dom0 will enable persistent grants for this newly attached block device: $ xenstore-ls -f | grep 20674 | grep persistent /local/domain/0/backend/vbd/20674/768/feature-

Re: sched=null vwfi=native and call_rcu()

On 06/01/2022 00:40, Stefano Stabellini wrote: Hi all, Hi, As you might remember, we have an outstanding issue with call_rcu() when sched=null vwfi=native are used. That is because in that configuration the CPU never goes idle so rcu_idle_enter() never gets called. The issue was caught on

[libvirt test] 167617: regressions - FAIL

flight 167617 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/167617/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-i386-libvirt

Re: [PATCH] xen, blkback: fix persistent grants negotiation

From: SeongJae Park On Thu, 6 Jan 2022 09:10:13 + Maximilian Heyne wrote: > Given dom0 supports persistent grants but the guest does not. > Then, when attaching a block device during runtime of the guest, dom0 > will enable persistent grants for this newly attached block device: > > $ xe

Re: scheduler credit capture

On Wed, Jan 5, 2022 at 2:45 PM amir masoud noohi wrote: > Hi Everyone, > > Today I'm looking for capturing vCPU credit for both credit1 and credit2. > How can I do that? > Can you explain what you mean by "capture vCPU credit"? Do you mean you want to log or sample changes to it? -George

[qemu-mainline test] 167615: tolerable FAIL - PUSHED

flight 167615 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/167615/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 167611 test-armhf-armhf-libvirt 16 sav

[PATCH 01/15] mini-os: split struct file definition from its usage

Make the struct file definition standalone and use it for the declaration of the files array. Signed-off-by: Juergen Gross --- include/lib.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/lib.h b/include/lib.h index 39d6a18..a638bc9 100644 --- a/include/lib.h +

[PATCH 09/15] mini-os: eliminate kbdfront union member in struct file

Replace the kbdfront specific union member in struct file with the common dev pointer. Signed-off-by: Juergen Gross --- fbfront.c | 2 +- include/lib.h | 3 --- lib/sys.c | 4 ++-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/fbfront.c b/fbfront.c index c8410af..1e055fb

[PATCH 06/15] mini-os: eliminate blkfront union member in struct file

Replace the blkfront specific union member in struct file with the common dev pointer. Signed-off-by: Juergen Gross --- blkfront.c| 6 +++--- include/lib.h | 3 --- lib/sys.c | 2 +- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/blkfront.c b/blkfront.c index 8137106..e3f

[PATCH 05/15] mini-os: introduce a common dev pointer in struct file

There are many dev pointers in a union in struct file. Prepare to switch to a single one by introducing a new common one. Signed-off-by: Juergen Gross --- include/lib.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/lib.h b/include/lib.h index dc56f52..60aaf1c 100644 --- a/include/l

[PATCH 04/15] mini-os: replace multiple fd elements in struct file by common one

The type specific union in struct files contains two instances of "int fd". Replace them by a common one. Signed-off-by: Juergen Gross --- include/lib.h | 9 + lib/sys.c | 28 ++-- 2 files changed, 15 insertions(+), 22 deletions(-) diff --git a/include/lib.h

[PATCH 12/15] mini-os: eliminate tpmfront union member in struct file

Replace the tpmfront specific union member in struct file with the common dev pointer. Signed-off-by: Juergen Gross --- include/lib.h | 5 - lib/sys.c | 2 +- tpmfront.c| 8 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/include/lib.h b/include/lib.h index d

[PATCH 00/15] mini-os: remove struct file dependency from config

Today the layout of struct file is depending on the Mini-OS configuration. This is especially bad as the layout is exported to external users like the Xen libraries built for Mini-OS, and those are being built only once for multiple stubdom configurations. Today there is no direct problem resultin

[PATCH 10/15] mini-os: eliminate netfront union member in struct file

Replace the netfront specific union member in struct file with the common dev pointer. Signed-off-by: Juergen Gross --- include/lib.h | 3 --- lib/sys.c | 6 +++--- netfront.c| 2 +- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/include/lib.h b/include/lib.h index 5201ed

[PATCH 14/15] mini-os: eliminate xenbus union member in struct file

Replace the xenbus specific union member in struct file with the common dev pointer. Signed-off-by: Juergen Gross --- include/lib.h | 7 --- lib/sys.c | 2 +- lib/xs.c | 13 +++-- 3 files changed, 8 insertions(+), 14 deletions(-) diff --git a/include/lib.h b/include/lib.h

[PATCH 08/15] mini-os: eliminate fbfront union member in struct file

Replace the fbfront specific union member in struct file with the common dev pointer. Signed-off-by: Juergen Gross --- fbfront.c | 2 +- include/lib.h | 3 --- lib/sys.c | 4 ++-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/fbfront.c b/fbfront.c index 6725da1..c8410af

[PATCH 03/15] mini-os: make offset a common struct file member for all types

Currently 4 file types have an offset member in their private struct file part. Make offset a common struct member shared by all file types. Signed-off-by: Juergen Gross --- blkfront.c| 5 ++--- include/lib.h | 5 + lib/sys.c | 14 +- tpm_tis.c | 11 +-- tpm

[PATCH 02/15] mini-os: makes file.read bool and move it ahead of device specific part

The read member of struct file should be bool. In order to have the device specific part at the end of the structure move "read" ahead of that. Signed-off-by: Juergen Gross --- blkfront.c | 4 ++-- console/xencons_ring.c | 2 +- fbfront.c | 12 ++-- include/li

[PATCH 11/15] mini-os: move tpm respgot member of struct file to device specific data

Tpmfront has a "respgot" flag in struct file, which can be moved to the device specific data. While at it make it a bool. The respgot flag of the tpm_tis member of struct file can be removed, as it is never read. Signed-off-by: Juergen Gross --- include/lib.h | 2 -- include/tpmfront.h |

[PATCH 15/15] mini-os: introduce get_file_from_fd()

Exporting the files[] array especially for components outside the mini-os source tree is limiting the ability to change any file handling in mini-os. Introduce a new function get_file_from_fd() to return the struct file pointer (or NULL) for a given file descriptor. Signed-off-by: Juergen Gross

[PATCH 07/15] mini-os: eliminate consfront union member in struct file

Replace the consfront specific union member in struct file with the common dev pointer. Signed-off-by: Juergen Gross --- include/lib.h | 3 --- lib/sys.c | 31 +-- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/include/lib.h b/include/lib.h inde

[PATCH 13/15] mini-os: eliminate tpmtis union member in struct file

Replace the tpmtis specific union member in struct file with the common dev pointer. Signed-off-by: Juergen Gross --- include/lib.h | 5 - lib/sys.c | 2 +- tpm_tis.c | 8 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/include/lib.h b/include/lib.h index 2dd

Re: [PATCH RFC v2 3/3] x86/altp2m: p2m_altp2m_propagate_change() should honor present page order

On 05.01.2022 17:25, Tamas K Lengyel wrote: > On Wed, Jan 5, 2022 at 3:59 AM Jan Beulich wrote: >> >> On 04.01.2022 18:48, Tamas K Lengyel wrote: I may be entirely wrong and hence that part of the change may also be wrong, but I'm having trouble seeing why the original "!mfn_eq(m, I

Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver

Hi Julien, On Mon, Jan 03, 2022 at 01:14:17PM +, Julien Grall wrote: > Hi, > > On 24/12/2021 17:02, Oleksii Moisieiev wrote: > > On Fri, Dec 24, 2021 at 03:42:42PM +0100, Julien Grall wrote: > > > On 20/12/2021 16:41, Oleksii Moisieiev wrote: > > > > > 2) What are the expected memory attr

Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver

On 06/01/2022 13:53, Oleksii Moisieiev wrote: Hi Julien, Hi, On Mon, Jan 03, 2022 at 01:14:17PM +, Julien Grall wrote: Hi, On 24/12/2021 17:02, Oleksii Moisieiev wrote: On Fri, Dec 24, 2021 at 03:42:42PM +0100, Julien Grall wrote: On 20/12/2021 16:41, Oleksii Moisieiev wrote:

Re: request for feedback on a Xen/Linux compatibility issue

On 06.01.2022 08:13, Juergen Gross wrote: > On 06.01.22 01:40, Stefano Stabellini wrote: >> Hi all, >> >> Today Xen dom0less guests are not "Xen aware": the hypervisor node >> (compatible = "xen,xen") is missing from dom0less domUs device trees and >> as a consequence Linux initializes as if Xen is

Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm

On 06.01.2022 00:11, Oleksandr Tyshchenko wrote: > --- a/xen/arch/x86/include/asm/mm.h > +++ b/xen/arch/x86/include/asm/mm.h > @@ -57,6 +57,9 @@ > #define PGT_count_width PG_shift(8) > #define PGT_count_mask((1UL< > +/* No arch-specific initialization pattern is needed for the type_info

Re: request for feedback on a Xen/Linux compatibility issue

Hi, On 06/01/2022 14:03, Jan Beulich wrote: On 06.01.2022 08:13, Juergen Gross wrote: On 06.01.22 01:40, Stefano Stabellini wrote: Hi all, Today Xen dom0less guests are not "Xen aware": the hypervisor node (compatible = "xen,xen") is missing from dom0less domUs device trees and as a consequen

Live update of Xenstore-stubdom

I'm currently thinking how to implement live update of Xenstore-stubdom. I should note that my plan is to support live update for a Xenstore PVH stubdom only, as kexec functionality is much easier to implement for that case. The main problem is to transfer the Xenstore state to the new instance.

Re: scheduler credit capture

[Adding back in xen-devel to the cc' list] On Thu, Jan 6, 2022 at 1:41 PM amir masoud noohi wrote: > yes exactly, I want to see the changes of a credit for each vCPU > (FYI we respond in-line on the Xen mailing lists rather than top posting.) Your best bet is to look into xentrace & xenalyze,

Re: [PATCH RFC v2 3/3] x86/altp2m: p2m_altp2m_propagate_change() should honor present page order

> Hmm, I continue to be puzzled. Let's take the XSA-304 workaround as an > example. Suppose an introspection agent has removed X from a 4k page > in an altp2m of a guest. Suppose one of the vCPU-s of this guest runs > on the host p2m. If this vCPU hits the (presumably) 2M or 1G mapping > covering s

Re: [PATCH RFC v2 3/3] x86/altp2m: p2m_altp2m_propagate_change() should honor present page order

On Thu, Jan 6, 2022 at 8:50 AM Jan Beulich wrote: > > On 05.01.2022 17:25, Tamas K Lengyel wrote: > > On Wed, Jan 5, 2022 at 3:59 AM Jan Beulich wrote: > >> > >> On 04.01.2022 18:48, Tamas K Lengyel wrote: > I may be entirely wrong and hence that part of the change may also be > wrong,

Re: xen 4.14.3 incorrect (~3x) cpu frequency reported

Hi Jan, > > On Wed, Jul 21, 2021 at 12:59:11PM +0200, Jan Beulich wrote: > > > >> On 21.07.2021 11:29, James Dingwall wrote: > >>

Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver

On Mon, Jan 03, 2022 at 02:23:01PM +, Julien Grall wrote: > Hi, > > On 24/12/2021 16:49, Oleksii Moisieiev wrote: > > On Fri, Dec 24, 2021 at 03:28:56PM +0100, Julien Grall wrote: > > > On 24/12/2021 14:59, Oleksii Moisieiev wrote: > > > > Hi Julien, > > > > > > Hello, > > > > > > > On Fri,

Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing instructions

On Wed, 5 Jan 2022 16:55:11 + Ayan Kumar Halder wrote: Hi, > Thank you so much for your feedback. > > I need a couple of clarifications before I can start with the v3 patch. > > On 08/12/2021 12:00, Andre Przywara wrote: > > On Mon, 6 Dec 2021 19:31:06 + > > Julien Grall wrote: > > >

[xen-unstable test] 167618: tolerable FAIL

flight 167618 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/167618/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail in 167612 pass in 167618 test-amd64-amd64-xl

Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver

On Thu, Jan 06, 2022 at 02:02:10PM +, Julien Grall wrote: > > > On 06/01/2022 13:53, Oleksii Moisieiev wrote: > > Hi Julien, > > Hi, > > > > > On Mon, Jan 03, 2022 at 01:14:17PM +, Julien Grall wrote: > > > Hi, > > > > > > On 24/12/2021 17:02, Oleksii Moisieiev wrote: > > > > On Fri,

[PATCH] x86/hvm: add more callback/upcall info to 'I' debug key

Include the type of the callback via and the per-VCPU upcall vector. Signed-off-by: David Vrabel --- xen/arch/x86/hvm/irq.c | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c index 52aae4565f..6a1ed

[PATCH] x86/hvm: save/restore per-VCPU event channel upcall vector

The Windows XENBUS driver sets the per-VCPU LAPIC vector for event channel interrupts using the HVMOP_set_evtchn_upcall_vector hypercall (rather than using a vector-type callback in the CALLBACK_IRQ HVM parameter since the vectors might be different for different VCPUs). This state needs to be sav

Re: xen 4.14.3 incorrect (~3x) cpu frequency reported

On 06.01.2022 16:08, James Dingwall wrote: >>> On Wed, Jul 21, 2021 at 12:59:11PM +0200, Jan Beulich wrote: >>> On 21.07.2021 11:29, James Dingwall wrote:

Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver

Hi, On 06/01/2022 15:43, Oleksii Moisieiev wrote: On Thu, Jan 06, 2022 at 02:02:10PM +, Julien Grall wrote: On 06/01/2022 13:53, Oleksii Moisieiev wrote: Hi Julien, Hi, On Mon, Jan 03, 2022 at 01:14:17PM +, Julien Grall wrote: Hi, On 24/12/2021 17:02, Oleksii Moisieiev wrote:

Re: [PATCH] x86/hvm: add more callback/upcall info to 'I' debug key

On 06.01.2022 16:46, David Vrabel wrote: > Include the type of the callback via and the per-VCPU upcall vector. > > Signed-off-by: David Vrabel Welcome back! A couple of stylistic / cosmetic remarks: > --- a/xen/arch/x86/hvm/irq.c > +++ b/xen/arch/x86/hvm/irq.c > @@ -598,7 +598,9 @@ int hvm_lo

Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver

Hi Julien, On Thu, Jan 06, 2022 at 04:04:34PM +, Julien Grall wrote: > Hi, > > On 06/01/2022 15:43, Oleksii Moisieiev wrote: > > On Thu, Jan 06, 2022 at 02:02:10PM +, Julien Grall wrote: > > > > > > > > > On 06/01/2022 13:53, Oleksii Moisieiev wrote: > > > > Hi Julien, > > > > > > Hi,

Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm

On 06.01.22 16:20, Jan Beulich wrote: Hi Jan On 06.01.2022 00:11, Oleksandr Tyshchenko wrote: --- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -57,6 +57,9 @@ #define PGT_count_width PG_shift(8) #define PGT_count_mask((1UL< +/* No arch-specific initializ

Re: [PATCH] x86/hvm: save/restore per-VCPU event channel upcall vector

On 06.01.2022 16:54, David Vrabel wrote: > The Windows XENBUS driver sets the per-VCPU LAPIC vector for event > channel interrupts using the HVMOP_set_evtchn_upcall_vector hypercall > (rather than using a vector-type callback in the CALLBACK_IRQ HVM > parameter since the vectors might be different

Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm

On 06.01.2022 17:30, Oleksandr wrote: > In case you don't have any other objections shall I re-push v5.1 with > proposed adjustments now? I'd suggest you wait for feedback by others. After all there may also be opposition to what I have said (in which case you'd go back and forth). Jan

Re: Live update of Xenstore-stubdom

On Thu, Jan 06, 2022 at 03:33:49PM +0100, Juergen Gross wrote: > I'm currently thinking how to implement live update of Xenstore-stubdom. > > I should note that my plan is to support live update for a Xenstore PVH > stubdom only, as kexec functionality is much easier to implement for > that case.

Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm

On 06.01.22 18:50, Jan Beulich wrote: Hi Jan On 06.01.2022 17:30, Oleksandr wrote: In case you don't have any other objections shall I re-push v5.1 with proposed adjustments now? I'd suggest you wait for feedback by others. After all there may also be opposition to what I have said (in whic

[xen-unstable-smoke test] 167621: tolerable all pass - PUSHED

flight 167621 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/167621/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: scheduler credit capture

> > It looks like you can get the info you want for credit2 How? On Thu, Jan 6, 2022 at 6:12 PM George Dunlap wrote: > [Adding back in xen-devel to the cc' list] > > On Thu, Jan 6, 2022 at 1:41 PM amir masoud noohi > wrote: > >> yes exactly, I want to see the changes of a credit for each vCPU

[linux-linus test] 167619: tolerable FAIL - PUSHED

flight 167619 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/167619/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 167614 test-amd64-amd64-qemuu-nested-amd 20

Re: request for feedback on a Xen/Linux compatibility issue

On Thu, 6 Jan 2022, Julien Grall wrote: > On 06/01/2022 14:03, Jan Beulich wrote: > > On 06.01.2022 08:13, Juergen Gross wrote: > > > On 06.01.22 01:40, Stefano Stabellini wrote: > > > > Hi all, > > > > > > > > Today Xen dom0less guests are not "Xen aware": the hypervisor node > > > > (compatible

[xen-4.16-testing test] 167620: tolerable FAIL - PUSHED

flight 167620 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/167620/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 167401 test-armhf-armhf-libvirt 16

Re: sched=null vwfi=native and call_rcu()

On Thu, 6 Jan 2022, Julien Grall wrote: > On 06/01/2022 00:40, Stefano Stabellini wrote: > > As you might remember, we have an outstanding issue with call_rcu() when > > sched=null vwfi=native are used. That is because in that configuration > > the CPU never goes idle so rcu_idle_enter() never gets

Re: [PATCH 00/15] mini-os: remove struct file dependency from config

Hello, I had a glimpse at the changes, this looks good to me! Acked-by: Samuel Thibault on the whole series. I'll see when I'll be able to find time to review the changes, unless somebody beats me to it :) Samuel Juergen Gross, le jeu. 06 janv. 2022 12:57:26 +0100, a ecrit: > Today the layout

Re: Live update of Xenstore-stubdom

On 06.01.22 17:59, Marek Marczykowski-Górecki wrote: On Thu, Jan 06, 2022 at 03:33:49PM +0100, Juergen Gross wrote: I'm currently thinking how to implement live update of Xenstore-stubdom. I should note that my plan is to support live update for a Xenstore PVH stubdom only, as kexec functionali