[xen-unstable test] 166031: tolerable FAIL - PUSHED

2021-11-04 Thread osstest service owner
flight 166031 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/166031/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 166022 test-armhf-armhf-libvirt 16 save

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-04 Thread Jan Beulich
On 03.11.2021 17:13, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH] x86/passthrough: Fix hvm_gsi_eoi() build > with GCC 12"): >> On 27.10.2021 22:07, Andrew Cooper wrote: >>> if ( !((pirq) ? &(pirq)->arch.hvm.dpci : NULL) ) >> >> I disagree with the compiler's analysis: While &(pirq)->arc

Re: [PATCH v2 0/3][4.16] x86/IOMMU: enabled / intremap handling

2021-11-04 Thread Jan Beulich
On 03.11.2021 17:19, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH v2 0/3][4.16] x86/IOMMU: enabled / intremap > handling"): >> On 02.11.2021 11:17, Jan Beulich wrote: >>> On 21.10.2021 11:57, Jan Beulich wrote: In the course of reading the response to v1 (patch 1 only) I realized

Re: [PATCH for-4.16 v5] gnttab: allow setting max version per-domain

2021-11-04 Thread Jan Beulich
On 03.11.2021 15:57, Roger Pau Monne wrote: > --- a/tools/libs/light/libxl_create.c > +++ b/tools/libs/light/libxl_create.c > @@ -454,6 +454,28 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, > libxl_defbool_setdefault(&b_info->nested_hvm, false); > } > > +

Re: [PATCH] PCI/MSI: Move non-mask check back into low level accessors

2021-11-04 Thread Josef Johansson
On 11/4/21 00:45, Thomas Gleixner wrote: > On Wed, Oct 27 2021 at 17:29, Josef Johansson wrote: > > CC+: EFIFB and scheduler folks > >> On 10/27/21 14:01, Josef Johansson wrote: >> When I suspend I get errors from Xen, including stacktraces below >> if anyone has any clue, if this might be related.

[qemu-mainline test] 166033: tolerable FAIL - PUSHED

2021-11-04 Thread osstest service owner
flight 166033 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/166033/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail like 166025 test-armhf-armhf-libvirt 16 sav

Re: [PATCH v2 09/15] x86/pv-shim: don't modify hypercall table

2021-11-04 Thread Jan Beulich
On 01.11.2021 16:20, Juergen Gross wrote: > When running as pv-shim the hypercall is modified today in order to > replace the functions for __HYPERVISOR_event_channel_op and > __HYPERVISOR_grant_table_op hypercalls. > > Change this to call the related functions from the normal handlers > instead w

Re: [PATCH for-4.16 v5] gnttab: allow setting max version per-domain

2021-11-04 Thread Roger Pau Monné
On Thu, Nov 04, 2021 at 09:55:03AM +0100, Jan Beulich wrote: > On 03.11.2021 15:57, Roger Pau Monne wrote: > > --- a/tools/libs/light/libxl_create.c > > +++ b/tools/libs/light/libxl_create.c > > @@ -454,6 +454,28 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, > > libxl_defbool_s

Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock

2021-11-04 Thread Michal Orzel
Hello, On 01.11.2021 21:51, Stefano Stabellini wrote: > On Mon, 1 Nov 2021, Ian Jackson wrote: >> Stefano Stabellini writes ("Re: [patch-4.16] arm/smmuv1,v2: Protect smmu >> master list with a lock"): >>> In regards to this specific patch and also the conversation about 4.16 >>> or 4.17: I think

Re: [PATCH v2 11/15] xen/x86: call hypercall handlers via generated macro

2021-11-04 Thread Jan Beulich
On 01.11.2021 16:20, Juergen Gross wrote: > Instead of using a function table use the generated macros for calling > the appropriate hypercall handlers. > > This is beneficial to performance and avoids speculation issues. > > With calling the handlers using the correct number of parameters now >

Re: [PATCH for-4.16 v5] gnttab: allow setting max version per-domain

2021-11-04 Thread Jan Beulich
On 04.11.2021 10:16, Roger Pau Monné wrote: > On Thu, Nov 04, 2021 at 09:55:03AM +0100, Jan Beulich wrote: >> On 03.11.2021 15:57, Roger Pau Monne wrote: >>> @@ -69,7 +69,8 @@ int gnttab_acquire_resource( >>> >>> static inline int grant_table_init(struct domain *d, >>>

Re: Arch-neutral name for hardware interrupt support

2021-11-04 Thread Roger Pau Monné
On Wed, Nov 03, 2021 at 10:16:26AM +, Jane Malalane wrote: > On 02/11/2021 08:51, Roger Pau Monné wrote: > > On Mon, Nov 01, 2021 at 10:47:26AM +, Andrew Cooper wrote: > > > Hello, > > > > > > On ARM, the GIC is a hard prerequisite for VMs. > > > > > > I can't remember what the state of R

[4.16?] Re: [PATCH v2 13/15] xen/x86: add hypercall performance counters for hvm, correct pv

2021-11-04 Thread Jan Beulich
Ian, On 01.11.2021 16:20, Juergen Gross wrote: > The HVM hypercall handler is missing incrementing the per hypercall > counters. Add that. > > The counters for PV are handled wrong, as they are not using > perf_incra() with the number of the hypercall as index, but are > incrementing the first hy

Re: [PATCH v2 14/15] xen: drop calls_to_multicall performance counter

2021-11-04 Thread Jan Beulich
On 01.11.2021 16:20, Juergen Gross wrote: > The calls_to_multicall performance counter is basically redundant to > the multicall hypercall counter. The only difference is the counting > of continuation calls, which isn't really that interesting. > > Drop the calls_to_multicall performance counter.

Re: [PATCH v3 01/16] perf: Ensure perf_guest_cbs aren't reloaded between !NULL check and deref

2021-11-04 Thread Like Xu
On 22/9/2021 8:05 am, Sean Christopherson wrote: Protect perf_guest_cbs with READ_ONCE/WRITE_ONCE to ensure it's not reloaded between a !NULL check and a dereference, and wait for all readers via syncrhonize_rcu() to prevent use-after-free, e.g. if the callbacks are being unregistered during modu

Re: [PATCH v2 15/15] tools/xenperf: update hypercall names

2021-11-04 Thread Jan Beulich
On 01.11.2021 16:20, Juergen Gross wrote: > The hypercall names need some update. > > Signed-off-by: Juergen Gross In the context of reviewing v1 of this series I came to make an almost identical patch (sole difference being that I took the opportunity and also switched the table itself to "stat

Re: Ping: [PATCH v4 3/3] unzstd: make helper symbols static

2021-11-04 Thread Jan Beulich
On 30.06.2021 09:43, Jan Beulich wrote: > On 05.05.2021 19:35, Julien Grall wrote: >> >> >> On 29/04/2021 14:26, Jan Beulich wrote: >>> On 29.04.2021 13:27, Julien Grall wrote: On 21/04/2021 11:22, Jan Beulich wrote: > While for the original library's purposes these functions of course wan

[libvirt test] 166040: regressions - FAIL

2021-11-04 Thread osstest service owner
flight 166040 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/166040/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-04 Thread Andrew Cooper
On 04/11/2021 08:07, Jan Beulich wrote: > On 03.11.2021 17:13, Ian Jackson wrote: >> Jan Beulich writes ("Re: [PATCH] x86/passthrough: Fix hvm_gsi_eoi() build >> with GCC 12"): >>> On 27.10.2021 22:07, Andrew Cooper wrote: if ( !((pirq) ? &(pirq)->arch.hvm.dpci : NULL) ) >>> I disagree with

[PATCH for-4.16 v6] gnttab: allow setting max version per-domain

2021-11-04 Thread Roger Pau Monne
Introduce a new domain create field so that toolstack can specify the maximum grant table version usable by the domain. This is plumbed into xl and settable by the user as max_grant_version. Previously this was only settable on a per host basis using the gnttab command line option. Note the versi

Re: [PATCH for-4.16 v6] gnttab: allow setting max version per-domain

2021-11-04 Thread Christian Lindig
On 4 Nov 2021, at 10:48, Roger Pau Monne mailto:roger@citrix.com>> wrote: Introduce a new domain create field so that toolstack can specify the maximum grant table version usable by the domain. This is plumbed into xl and settable by the user as max_grant_version. Acked-by: Christian Lindi

Re: [PATCH v2 0/3][4.16] x86/IOMMU: enabled / intremap handling

2021-11-04 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH v2 0/3][4.16] x86/IOMMU: enabled / intremap handling"): > > Reviewed-by: Ian Jackson > > > >> Patch 2 corrects an (unlikely but not impossible to be taken) error > >> path, supposedly making systems functional again in case they would > >> in fact cause that error

[ovmf test] 166042: all pass - PUSHED

2021-11-04 Thread osstest service owner
flight 166042 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/166042/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b258f12889c09555e99c9cebf56dba45190c5dc2 baseline version: ovmf 6f9e83f757ed7c5c78d07

[PATCH-for-4.16 2/2] tools: disable building qemu-trad per default

2021-11-04 Thread Juergen Gross
Using qemu-traditional as device model is deprecated for some time now. So change the default for building it to "disable". This will affect ioemu-stubdom, too, as there is a direct dependency between the two. Today it is possible to use a PVH/HVM Linux-based stubdom as device model. Additionally

[PATCH-for-4.16 0/2] next try for disabling build of qemu-trad

2021-11-04 Thread Juergen Gross
Another try to disable building qemu-traditional per default. Juergen Gross (2): configure: modify default of building rombios tools: disable building qemu-trad per default CHANGELOG.md | 3 + stubdom/configure| 8 --- stubdom/configure.ac | 8 +-- tools/configure | 13

[PATCH-for-4.16 1/2] configure: modify default of building rombios

2021-11-04 Thread Juergen Gross
The tools/configure script will default to build rombios if qemu traditional is enabled. If rombios is being built, ipxe will be built per default, too. This results in rombios and ipxe no longer being built per default when disabling qemu traditional. Fix that be rearranging the dependencies: -

Re: [PATCH for-4.16 v6] gnttab: allow setting max version per-domain

2021-11-04 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH for-4.16 v6] gnttab: allow setting max version per-domain"): > Introduce a new domain create field so that toolstack can specify the > maximum grant table version usable by the domain. This is plumbed into > xl and settable by the user as max_grant_version. > > Pre

Re: [PATCH for-4.16 2/2] xen: Report grant table v1/v2 capabilities to the toolstack

2021-11-04 Thread Ian Jackson
Andrew Cooper writes ("[PATCH for-4.16 2/2] xen: Report grant table v1/v2 capabilities to the toolstack"): > In order to let the toolstack be able to set the gnttab version on a > per-domain basis, it needs to know which ABIs Xen supports. Introduce > XEN_SYSCTL_PHYSCAP_gnttab_v{1,2} for the purp

Re: [PATCH for-4.16 v6] gnttab: allow setting max version per-domain

2021-11-04 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH for-4.16 v6] gnttab: allow setting max version per-domain"): > Introduce a new domain create field so that toolstack can specify the > maximum grant table version usable by the domain. This is plumbed into > xl and settable by the user as max_grant_version. > > Pre

xenstore stubdom broken

2021-11-04 Thread Juergen Gross
Probably due to commit 1787cc167906f3 ("libs/guest: Move the guest ABI check earlier into xc_dom_parse_image()") Xenstore stubdom is broken: Nov 04 13:08:03 localhost systemd[1]: Starting The Xen xenstore... Nov 04 13:08:05 localhost launch-xenstore[699]: Starting /usr/lib/xen/boot/xenstore-stub

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-04 Thread Jan Beulich
On 04.11.2021 11:48, Andrew Cooper wrote: > On 04/11/2021 08:07, Jan Beulich wrote: >> On 03.11.2021 17:13, Ian Jackson wrote: >>> Jan Beulich writes ("Re: [PATCH] x86/passthrough: Fix hvm_gsi_eoi() build >>> with GCC 12"): On 27.10.2021 22:07, Andrew Cooper wrote: > if ( !((pirq) ? &(p

Re: [PATCH for-4.16 v6] gnttab: allow setting max version per-domain

2021-11-04 Thread Jan Beulich
On 04.11.2021 13:09, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH for-4.16 v6] gnttab: allow setting max > version per-domain"): >> Introduce a new domain create field so that toolstack can specify the >> maximum grant table version usable by the domain. This is plumbed into >> xl and sett

Re: [PATCH for-4.16 v6] gnttab: allow setting max version per-domain

2021-11-04 Thread Andrew Cooper
On 04/11/2021 10:48, Roger Pau Monne wrote: > Introduce a new domain create field so that toolstack can specify the > maximum grant table version usable by the domain. This is plumbed into > xl and settable by the user as max_grant_version. > > Previously this was only settable on a per host basis

Re: [PATCH for-4.16 v6] gnttab: allow setting max version per-domain

2021-11-04 Thread Roger Pau Monné
On Thu, Nov 04, 2021 at 01:25:31PM +0100, Jan Beulich wrote: > On 04.11.2021 13:09, Ian Jackson wrote: > > Roger Pau Monne writes ("[PATCH for-4.16 v6] gnttab: allow setting max > > version per-domain"): > >> Introduce a new domain create field so that toolstack can specify the > >> maximum grant

Re: [PATCH for-4.16 2/2] xen: Report grant table v1/v2 capabilities to the toolstack

2021-11-04 Thread Roger Pau Monné
On Fri, Oct 29, 2021 at 06:38:13PM +0100, Andrew Cooper wrote: > In order to let the toolstack be able to set the gnttab version on a > per-domain basis, it needs to know which ABIs Xen supports. Introduce > XEN_SYSCTL_PHYSCAP_gnttab_v{1,2} for the purpose, and plumb in down into > userspace. > >

[PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

2021-11-04 Thread Luca Fancellu
The code introduced by commit a1743fc3a9fe9b68c265c45264dddf214fd9b882 ("arm/efi: Use dom0less configuration when using EFI boot") is introducing a problem to boot Xen using Grub2 on ARM machine using EDK2. Despite UEFI specification, EDK2+Grub2 is returning a NULL DeviceHandle inside the interfac

Re: [PATCH v3 01/16] perf: Ensure perf_guest_cbs aren't reloaded between !NULL check and deref

2021-11-04 Thread Sean Christopherson
On Thu, Nov 04, 2021, Like Xu wrote: > On 22/9/2021 8:05 am, Sean Christopherson wrote: > > diff --git a/kernel/events/core.c b/kernel/events/core.c > > index 464917096e73..80ff050a7b55 100644 > > --- a/kernel/events/core.c > > +++ b/kernel/events/core.c > > @@ -6491,14 +6491,21 @@ struct perf_gues

Re: [PATCH][4.16] x86/x2APIC: defer probe until after IOMMU ACPI table parsing

2021-11-04 Thread Roger Pau Monné
On Wed, Nov 03, 2021 at 03:40:55PM +0100, Jan Beulich wrote: > While commit ("x86/IOMMU: mark IOMMU / intremap not in use > when ACPI tables are missing") deals with apic_x2apic_probe() as called > from x2apic_bsp_setup(), the check_x2apic_preenabled() path is similarly > affected: The

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

2021-11-04 Thread Bertrand Marquis
Hi Luca, > On 4 Nov 2021, at 14:12, Luca Fancellu wrote: > > The code introduced by commit a1743fc3a9fe9b68c265c45264dddf214fd9b882 > ("arm/efi: Use dom0less configuration when using EFI boot") is > introducing a problem to boot Xen using Grub2 on ARM machine using EDK2. > > Despite UEFI specif

[PATCH-for-4.16] tools/helpers: fix broken xenstore stubdom init

2021-11-04 Thread Juergen Gross
Commit 1787cc167906f3f ("libs/guest: Move the guest ABI check earlier into xc_dom_parse_image()") broke starting the xenstore stubdom. This is due to a rather special way the xenstore stubdom domain config is being initialized: in order to support both, PV and PVH stubdom, init-xenstore-domain is u

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

2021-11-04 Thread Ian Jackson
Bertrand Marquis writes ("Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64"): > > On 4 Nov 2021, at 14:12, Luca Fancellu wrote: > > Fixes: a1743fc3a9 ("arm/efi: Use dom0less configuration when using EFI > > boot") > > Signed-off-by: Luca Fancellu > > Reviewed-by: Bertrand Marquis > > Than

[PATCH-for-4.16 1/2] configure: modify default of building rombios

2021-11-04 Thread Ian Jackson
Juergen Gross writes ("[PATCH-for-4.16 1/2] configure: modify default of building rombios"): > The tools/configure script will default to build rombios if qemu > traditional is enabled. If rombios is being built, ipxe will be built > per default, too. > > This results in rombios and ipxe no longe

Re: [PATCH-for-4.16] tools/helpers: fix broken xenstore stubdom init

2021-11-04 Thread Andrew Cooper
On 04/11/2021 14:42, Juergen Gross wrote: > Commit 1787cc167906f3f ("libs/guest: Move the guest ABI check earlier > into xc_dom_parse_image()") broke starting the xenstore stubdom. This > is due to a rather special way the xenstore stubdom domain config is > being initialized: in order to support b

Re: [PATCH][4.16] x86/x2APIC: defer probe until after IOMMU ACPI table parsing [and 1 more messages]

2021-11-04 Thread Ian Jackson
Jan Beulich writes ("[PATCH][4.16] x86/x2APIC: defer probe until after IOMMU ACPI table parsing"): > While commit ("x86/IOMMU: mark IOMMU / intremap not in use > when ACPI tables are missing") deals with apic_x2apic_probe() as called > from x2apic_bsp_setup(), the check_x2apic_preenab

Re: [PATCH][4.16] x86/x2APIC: defer probe until after IOMMU ACPI table parsing [and 1 more messages]

2021-11-04 Thread Jan Beulich
On 04.11.2021 15:59, Ian Jackson wrote: > Jan Beulich writes ("[PATCH][4.16] x86/x2APIC: defer probe until after IOMMU > ACPI table parsing"): >> While commit ("x86/IOMMU: mark IOMMU / intremap not in use >> when ACPI tables are missing") deals with apic_x2apic_probe() as called >> fr

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-04 Thread Roger Pau Monné
On Thu, Nov 04, 2021 at 01:17:53PM +0100, Jan Beulich wrote: > On 04.11.2021 11:48, Andrew Cooper wrote: > > On 04/11/2021 08:07, Jan Beulich wrote: > >> On 03.11.2021 17:13, Ian Jackson wrote: > >>> Jan Beulich writes ("Re: [PATCH] x86/passthrough: Fix hvm_gsi_eoi() build > >>> with GCC 12"): > >

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-04 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12"): > I honestly don't think we expect any property of pirq_dpci, it just > tells whether a pirq has a dpci associated with it or not. As I said > on my previous replies I think GCC is not correct in

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-04 Thread Jan Beulich
On 04.11.2021 16:24, Roger Pau Monné wrote: > It might be appropriate to switch pirq_dpci to: > > #define pirq_dpci(d, pirq) \ > ((is_hvm_domain(d) && (pirq)) ? &(pirq)->arch.hvm.dpci : NULL) I don't see how this would help suppress the warning. > Or to an inline helper. I expect it's a mac

Re: [PATCH][4.16] x86/x2APIC: defer probe until after IOMMU ACPI table parsing

2021-11-04 Thread Jan Beulich
On 04.11.2021 15:21, Roger Pau Monné wrote: > On Wed, Nov 03, 2021 at 03:40:55PM +0100, Jan Beulich wrote: >> While commit ("x86/IOMMU: mark IOMMU / intremap not in use >> when ACPI tables are missing") deals with apic_x2apic_probe() as called >> from x2apic_bsp_setup(), the check_x2ap

Re: [PATCH v4] xen/balloon: add late_initcall_sync() for initial ballooning done

2021-11-04 Thread Boris Ostrovsky
On 11/3/21 9:55 PM, Boris Ostrovsky wrote: On 11/2/21 5:19 AM, Juergen Gross wrote: When running as PVH or HVM guest with actual memory < max memory the hypervisor is using "populate on demand" in order to allow the guest to balloon down from its maximum memory size. For this to work correctl

Re: [PATCH-for-4.16 1/2] configure: modify default of building rombios

2021-11-04 Thread Andrew Cooper
On 04/11/2021 14:52, Ian Jackson wrote: > Juergen Gross writes ("[PATCH-for-4.16 1/2] configure: modify default of > building rombios"): >> The tools/configure script will default to build rombios if qemu >> traditional is enabled. If rombios is being built, ipxe will be built >> per default, too.

Re: [XEN PATCH v7 00/51] xen: Build system improvements, now with out-of-tree build!

2021-11-04 Thread Alex Bennée
Anthony PERARD writes: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git > br.build-system-xen-v7 > > v7: > Out-of-tree build! > > This mean many more patches. Everything after patch 27 is new. > > There's a few new patc

[PATCH-for-4.16 v2 2/2] tools: disable building qemu-trad per default

2021-11-04 Thread Juergen Gross
Using qemu-traditional as device model is deprecated for some time now. So change the default for building it to "disable". This will affect ioemu-stubdom, too, as there is a direct dependency between the two. Today it is possible to use a PVH/HVM Linux-based stubdom as device model. Additionally

[PATCH-for-4.16 v2 0/2] next try for disabling build of qemu-trad

2021-11-04 Thread Juergen Gross
Another try to disable building qemu-traditional per default. Juergen Gross (2): configure: modify default of building rombios tools: disable building qemu-trad per default CHANGELOG.md | 3 + stubdom/configure| 8 --- stubdom/configure.ac | 8 +-- tools/configure | 13

[PATCH-for-4.16 v2 1/2] configure: modify default of building rombios

2021-11-04 Thread Juergen Gross
The tools/configure script will default to build rombios if qemu traditional is enabled. If rombios is being built, ipxe will be built per default, too. This results in rombios and ipxe no longer being built by default when disabling qemu traditional. Fix that be rearranging the dependencies: -

Re: [XEN PATCH v7 00/51] xen: Build system improvements, now with out-of-tree build!

2021-11-04 Thread Alex Bennée
Alex Bennée writes: > Anthony PERARD writes: > >> Patch series available in this git branch: >> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git >> br.build-system-xen-v7 >> >> v7: >> Out-of-tree build! >> >> This mean many more patches. Everything after patch 27 is ne

Re: [PATCH v4] xen/balloon: add late_initcall_sync() for initial ballooning done

2021-11-04 Thread Juergen Gross
On 04.11.21 16:55, Boris Ostrovsky wrote: On 11/3/21 9:55 PM, Boris Ostrovsky wrote: On 11/2/21 5:19 AM, Juergen Gross wrote: When running as PVH or HVM guest with actual memory < max memory the hypervisor is using "populate on demand" in order to allow the guest to balloon down from its maxi

Re: [PATCH v4] xen/balloon: add late_initcall_sync() for initial ballooning done

2021-11-04 Thread Marek Marczykowski-Górecki
On Thu, Nov 04, 2021 at 11:55:34AM -0400, Boris Ostrovsky wrote: > This appears to have noticeable effect on boot time (and boot experience in > general). Yes, this is kind of intentional. It avoids killing the domain ("out of PoD memory") for the price of increased boot time. I still wonder why

[PATCH-for-4.16 v2 1/2] configure: modify default of building rombios

2021-11-04 Thread Ian Jackson
Juergen Gross writes ("[PATCH-for-4.16 v2 1/2] configure: modify default of building rombios"): > The tools/configure script will default to build rombios if qemu > traditional is enabled. If rombios is being built, ipxe will be built > per default, too. > > This results in rombios and ipxe no lo

Re: [PATCH-for-4.16 v2 0/2] next try for disabling build of qemu-trad

2021-11-04 Thread Ian Jackson
Juergen Gross writes ("[PATCH-for-4.16 v2 0/2] next try for disabling build of qemu-trad"): > Another try to disable building qemu-traditional per default. > > Juergen Gross (2): > configure: modify default of building rombios > tools: disable building qemu-trad per default Both patches. Re

Re: [PATCH-for-4.16] tools/helpers: fix broken xenstore stubdom init

2021-11-04 Thread Jason Andryuk
On Thu, Nov 4, 2021 at 11:00 AM Andrew Cooper wrote: > > On 04/11/2021 14:42, Juergen Gross wrote: > > Commit 1787cc167906f3f ("libs/guest: Move the guest ABI check earlier > > into xc_dom_parse_image()") broke starting the xenstore stubdom. This > > is due to a rather special way the xenstore stu

Re: [XEN PATCH v7 00/51] xen: Build system improvements, now with out-of-tree build!

2021-11-04 Thread Anthony PERARD
On Thu, Nov 04, 2021 at 03:49:36PM +, Alex Bennée wrote: > > Anthony PERARD writes: > > > Patch series available in this git branch: > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fxenbits.xen.org%2Fgit-http%2Fpeople%2Faperard%2Fxen-unstable.git&data=04%7C01%7Canthony.p

Re: [PATCH v4] xen/balloon: add late_initcall_sync() for initial ballooning done

2021-11-04 Thread Boris Ostrovsky
On 11/4/21 12:21 PM, Juergen Gross wrote: On 04.11.21 16:55, Boris Ostrovsky wrote: On 11/3/21 9:55 PM, Boris Ostrovsky wrote: On 11/2/21 5:19 AM, Juergen Gross wrote: When running as PVH or HVM guest with actual memory < max memory the hypervisor is using "populate on demand" in order to

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

2021-11-04 Thread Jan Beulich
On 04.11.2021 15:12, Luca Fancellu wrote: > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -449,6 +449,15 @@ static EFI_FILE_HANDLE __init > get_parent_handle(EFI_LOADED_IMAGE *loaded_image, > CHAR16 *pathend, *ptr; > EFI_STATUS ret; > > +/* > + * Grub2 running

Re: [PATCH v4] xen/balloon: add late_initcall_sync() for initial ballooning done

2021-11-04 Thread Juergen Gross
On 04.11.21 17:34, Boris Ostrovsky wrote: On 11/4/21 12:21 PM, Juergen Gross wrote: On 04.11.21 16:55, Boris Ostrovsky wrote: On 11/3/21 9:55 PM, Boris Ostrovsky wrote: On 11/2/21 5:19 AM, Juergen Gross wrote: When running as PVH or HVM guest with actual memory < max memory the hypervisor

Re: [PATCH-for-4.16] tools/helpers: fix broken xenstore stubdom init

2021-11-04 Thread Juergen Gross
On 04.11.21 17:33, Jason Andryuk wrote: On Thu, Nov 4, 2021 at 11:00 AM Andrew Cooper wrote: On 04/11/2021 14:42, Juergen Gross wrote: Commit 1787cc167906f3f ("libs/guest: Move the guest ABI check earlier into xc_dom_parse_image()") broke starting the xenstore stubdom. This is due to a rather

Re: [XEN PATCH v7 00/51] xen: Build system improvements, now with out-of-tree build!

2021-11-04 Thread Alex Bennée
Anthony PERARD writes: > On Thu, Nov 04, 2021 at 03:49:36PM +, Alex Bennée wrote: >> >> Anthony PERARD writes: >> >> > Patch series available in this git branch: >> > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fxenbits.xen.org%2Fgit-http%2Fpeople%2Faperard%2Fxen-uns

Re: [PATCH v4] xen/balloon: add late_initcall_sync() for initial ballooning done

2021-11-04 Thread Boris Ostrovsky
And if so, would you mind doing this while committing (I have one day off tomorrow)? Yes, of course. Thanks. So I'll change this to pr_notice, even though it's not the best solution. -boris

Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock

2021-11-04 Thread Julien Grall
On 04/11/2021 09:18, Michal Orzel wrote: Hello, Hi Michal, On 01.11.2021 21:51, Stefano Stabellini wrote: On Mon, 1 Nov 2021, Ian Jackson wrote: Stefano Stabellini writes ("Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock"): In regards to this specific patch and al

Re: [PATCH] PCI/MSI: Move non-mask check back into low level accessors

2021-11-04 Thread Peter Zijlstra
On Thu, Nov 04, 2021 at 12:45:29AM +0100, Thomas Gleixner wrote: > On Wed, Oct 27 2021 at 17:29, Josef Johansson wrote: > > [ cut here ] > > cfs_rq->avg.load_avg || cfs_rq->avg.util_avg || cfs_rq->avg.runnable_avg > > installing Xen timer for CPU 4 > > WARNING: CPU: 3 PID: 4

[xen-unstable-smoke test] 166045: tolerable all pass - PUSHED

2021-11-04 Thread osstest service owner
flight 166045 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/166045/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock

2021-11-04 Thread Ian Jackson
Julien Grall writes ("Re: [patch-4.16] arm/smmuv1,v2: Protect smmu master list with a lock"): > On 04/11/2021 09:18, Michal Orzel wrote: > > On 01.11.2021 21:51, Stefano Stabellini wrote: > >> On Mon, 1 Nov 2021, Ian Jackson wrote: > >>> It sounds like this is a possible latent bug, or at least a

Re: [PATCH v2 1/1] xen: delay xen_hvm_init_time_ops() if kdump is boot on vcpu>=32

2021-11-04 Thread Dongli Zhang
Hi Boris, On 11/1/21 10:34 AM, Boris Ostrovsky wrote: > > On 10/27/21 9:25 PM, Dongli Zhang wrote: >> The sched_clock() can be used very early since >> commit 857baa87b642 ("sched/clock: Enable sched clock early"). In addition, >> with commit 38669ba205d1 ("x86/xen/time: Output xen sched_clock ti

Re: [PATCH-for-4.16 v2 1/2] configure: modify default of building rombios

2021-11-04 Thread Andrew Cooper
On 04/11/2021 16:27, Ian Jackson wrote: > Juergen Gross writes ("[PATCH-for-4.16 v2 1/2] configure: modify default of > building rombios"): >> The tools/configure script will default to build rombios if qemu >> traditional is enabled. If rombios is being built, ipxe will be built >> per default, t

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

2021-11-04 Thread Stefano Stabellini
On Thu, 4 Nov 2021, Luca Fancellu wrote: > The code introduced by commit a1743fc3a9fe9b68c265c45264dddf214fd9b882 > ("arm/efi: Use dom0less configuration when using EFI boot") is > introducing a problem to boot Xen using Grub2 on ARM machine using EDK2. > > Despite UEFI specification, EDK2+Grub2 i

Re: [PULL 04/20] migration/dirtyrate: introduce struct and adjust DirtyRateStat

2021-11-04 Thread Eric Blake
On Mon, Nov 01, 2021 at 11:08:56PM +0100, Juan Quintela wrote: > From: Hyman Huang(黄勇) > > introduce "DirtyRateMeasureMode" to specify what method should be > used to calculate dirty rate, introduce "DirtyRateVcpu" to store > dirty rate for each vcpu. > > use union to store stat data of spec

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

2021-11-04 Thread Stefano Stabellini
On Thu, 4 Nov 2021, Jan Beulich wrote: > On 04.11.2021 15:12, Luca Fancellu wrote: > > --- a/xen/common/efi/boot.c > > +++ b/xen/common/efi/boot.c > > @@ -449,6 +449,15 @@ static EFI_FILE_HANDLE __init > > get_parent_handle(EFI_LOADED_IMAGE *loaded_image, > > CHAR16 *pathend, *ptr; > > E

[PATCH] MAINTAINERS: add Bertrand to the ARM reviewers

2021-11-04 Thread Stefano Stabellini
Acked-by: Bertrand Marquis Acked-by: Stefano Stabellini diff --git a/MAINTAINERS b/MAINTAINERS index 9be4ad653a..4956db1011 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -232,6 +232,7 @@ ARM (W/ VIRTUALISATION EXTENSIONS) ARCHITECTURE M: Stefano Stabellini M: Julien Grall R: V

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

2021-11-04 Thread Luca Fancellu
> On 4 Nov 2021, at 20:56, Stefano Stabellini wrote: > > On Thu, 4 Nov 2021, Jan Beulich wrote: >> On 04.11.2021 15:12, Luca Fancellu wrote: >>> --- a/xen/common/efi/boot.c >>> +++ b/xen/common/efi/boot.c >>> @@ -449,6 +449,15 @@ static EFI_FILE_HANDLE __init >>> get_parent_handle(EFI_LOADED_

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

2021-11-04 Thread Stefano Stabellini
On Thu, 4 Nov 2021, Luca Fancellu wrote: > > On 4 Nov 2021, at 20:56, Stefano Stabellini wrote: > > > > On Thu, 4 Nov 2021, Jan Beulich wrote: > >> On 04.11.2021 15:12, Luca Fancellu wrote: > >>> --- a/xen/common/efi/boot.c > >>> +++ b/xen/common/efi/boot.c > >>> @@ -449,6 +449,15 @@ static EFI_F

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

2021-11-04 Thread Luca Fancellu
> On 4 Nov 2021, at 21:35, Stefano Stabellini wrote: > > On Thu, 4 Nov 2021, Luca Fancellu wrote: >>> On 4 Nov 2021, at 20:56, Stefano Stabellini wrote: >>> >>> On Thu, 4 Nov 2021, Jan Beulich wrote: On 04.11.2021 15:12, Luca Fancellu wrote: > --- a/xen/common/efi/boot.c > +++ b

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

2021-11-04 Thread Stefano Stabellini
On Thu, 4 Nov 2021, Luca Fancellu wrote: > > On 4 Nov 2021, at 21:35, Stefano Stabellini wrote: > > > > On Thu, 4 Nov 2021, Luca Fancellu wrote: > >>> On 4 Nov 2021, at 20:56, Stefano Stabellini > >>> wrote: > >>> > >>> On Thu, 4 Nov 2021, Jan Beulich wrote: > On 04.11.2021 15:12, Luca Fa

Re: [PULL 07/20] migration/dirtyrate: implement dirty-ring dirtyrate calculation

2021-11-04 Thread Philippe Mathieu-Daudé
Hi Juan, On 11/1/21 23:08, Juan Quintela wrote: > From: Hyman Huang(黄勇) > > use dirty ring feature to implement dirtyrate calculation. > > introduce mode option in qmp calc_dirty_rate to specify what > method should be used when calculating dirtyrate, either > page-sampling or dirty-ring sh

Re: [XEN][PATCH v2 1/1] Update libfdt to v1.6.1

2021-11-04 Thread Stefano Stabellini
On Wed, 3 Nov 2021, Vikram Garhwal wrote: > Update libfdt to v1.6.1 of libfdt taken from git://github.com/dgibson/dtc. > This update is done to support device tree overlays. > > A few minor changes are done to make it compatible with Xen: > fdt_overlay.c: overlay_fixup_phandle() > Replace str

Re: [PATCH] MAINTAINERS: add Bertrand to the ARM reviewers

2021-11-04 Thread Julien Grall
Hi Stefano, On 04/11/2021 21:00, Stefano Stabellini wrote: Acked-by: Bertrand Marquis I am not sure where the Acked-by is coming from. Can Bertrand confirm on the ML that the is happy to be a reviewer? Acked-by: Stefano Stabellini There is a missing signed-off-by on the patch. I am h

Re: [PATCH] MAINTAINERS: add Bertrand to the ARM reviewers

2021-11-04 Thread Stefano Stabellini
On Thu, 4 Nov 2021, Julien Grall wrote: > Hi Stefano, > > On 04/11/2021 21:00, Stefano Stabellini wrote: > > > > Acked-by: Bertrand Marquis > > I am not sure where the Acked-by is coming from. Can Bertrand confirm on the > ML that the is happy to be a reviewer? Yes, he gave it to me verbally b

[xen-unstable-smoke test] 166047: tolerable all pass - PUSHED

2021-11-04 Thread osstest service owner
flight 166047 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/166047/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

static-mem preventing dom0 from booting

2021-11-04 Thread Stefano Stabellini
Hi Penny, I am trying to test the static-mem feature in Xen 4.16 but I am having some issues. I can boot a dom0less domU with static-mem configured correctly, but when I do so, dom0 doesn't boot any longer. In the same configuration, if I remove the static-mem related lines from the domU node on

[xen-unstable test] 166043: tolerable FAIL - PUSHED

2021-11-04 Thread osstest service owner
flight 166043 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/166043/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 166031 test-armhf-armhf-libvirt 16 save

RE: static-mem preventing dom0 from booting

2021-11-04 Thread Penny Zheng
Hi Stefano > -Original Message- > From: Stefano Stabellini > Sent: Friday, November 5, 2021 9:36 AM > To: Penny Zheng > Cc: sstabell...@kernel.org; xen-devel@lists.xenproject.org > Subject: static-mem preventing dom0 from booting > > Hi Penny, > > I am trying to test the static-mem fea

[linux-linus test] 166041: regressions - FAIL

2021-11-04 Thread osstest service owner
flight 166041 linux-linus real [real] flight 166048 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/166041/ http://logs.test-lab.xenproject.org/osstest/logs/166048/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

[qemu-mainline test] 166044: tolerable FAIL - PUSHED

2021-11-04 Thread osstest service owner
flight 166044 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/166044/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 166033 test-amd64-amd64-xl-qemuu-win7-amd6

Re: [PATCH] PCI/MSI: Move non-mask check back into low level accessors

2021-11-04 Thread Vincent Guittot
On Thu, 4 Nov 2021 at 00:45, Thomas Gleixner wrote: > > On Wed, Oct 27 2021 at 17:29, Josef Johansson wrote: > > CC+: EFIFB and scheduler folks > > > On 10/27/21 14:01, Josef Johansson wrote: > > When I suspend I get errors from Xen, including stacktraces below > > if anyone has any clue, if this

[PATCH v6 1/7] xen/arm: rename DEVICE_PCI to DEVICE_PCI_HOSTBRIDGE

2021-11-04 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko To better reflect the nature of the device type and not to make any confusion rename DEVICE_PCI to DEVICE_PCI_HOSTBRIDGE which it really is. Signed-off-by: Oleksandr Andrushchenko Suggested-by: Julien Grall --- New in v6 --- xen/arch/arm/pci/pci-host-generic.c |

[PATCH v6 3/7] xen/arm: setup MMIO range trap handlers for hardware domain

2021-11-04 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko In order for vPCI to work it needs to maintain guest and hardware domain's views of the configuration space. For example, BARs and COMMAND registers require emulation for guests and the guest view of the registers needs to be in sync with the real contents of the rel

[PATCH v6 2/7] xen/arm: add pci-domain for disabled devices

2021-11-04 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko If a PCI host bridge device is present in the device tree, but is disabled, then its PCI host bridge driver was not instantiated. This results in the failure of the pci_get_host_bridge_segment() and the following panic during Xen start: (XEN) Device tree generation

[PATCH v6 0/7] PCI devices passthrough on Arm, part 2

2021-11-04 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Hi, all! This is an assorted series of patches which aim is to make some further basis for PCI passthrough on Arm support. The series continues the work published earlier by Arm [1] and adds new helpers and clears the way for vPCI changes which will follow. RFC is

[PATCH v6 6/7] xen/arm: process pending vPCI map/unmap operations

2021-11-04 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko vPCI may map and unmap PCI device memory (BARs) being passed through which may take a lot of time. For this those operations may be deferred to be performed later, so that they can be safely preempted. Currently this deferred processing is happening in common IOREQ

[PATCH v6 4/7] xen/arm: do not map PCI ECAM and MMIO space to Domain-0's p2m

2021-11-04 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko PCI host bridges are special devices in terms of implementing PCI passthrough. According to [1] the current implementation depends on Domain-0 to perform the initialization of the relevant PCI host bridge hardware and perform PCI device enumeration. In order to achie

[PATCH v6 5/7] xen/arm: do not map IRQs and memory for disabled devices

2021-11-04 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Currently Xen maps all IRQs and memory ranges for all devices except those marked for passthrough, e.g. it doesn't pay attention to the "status" property of the node. According to the device tree specification [1]: - "okay" Indicates the device is operational.

  1   2   >