[PATCH] arm/efi: Fix null pointer dereference

2021-10-11 Thread Luca Fancellu
Fix for commit 60649d443dc395243e74d2b3e05594ac0c43cfe3 that introduces a null pointer dereference when the fdt_node_offset_by_compatible is called with "fdt" argument null. Reported-by: Julien Grall Fixes: 60649d443d ("arm/efi: Introduce xen,uefi-cfg-load DT property") Signed-off-by: Luca Fancel

[PATCH v5 0/2] arm/efi: Add dom0less support to UEFI boot

2021-10-11 Thread Luca Fancellu
This serie introduces a way to start a dom0less setup when Xen is booting as EFI application. Using the device tree it's now possible to fetch from the disk and load in memory all the modules needed to start any domU defined in the DT. Dom0less for now is supported only by the arm architecture. Th

[PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI boot

2021-10-11 Thread Luca Fancellu
This patch introduces the support for dom0less configuration when using UEFI boot on ARM, it permits the EFI boot to continue if no dom0 kernel is specified but at least one domU is found. Introduce the new property "xen,uefi-binary" for device tree boot module nodes that are subnode of "xen,domai

[PATCH v5 2/2] arm/efi: load dom0 modules from DT using UEFI

2021-10-11 Thread Luca Fancellu
Add support to load Dom0 boot modules from the device tree using the xen,uefi-binary property. Update documentation about that. Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich --- Changes in v5: - renamed missing uefi,binary str

Ping: [PATCH v2 3/3] AMD/IOMMU: consider hidden devices when flushing device I/O TLBs

2021-10-11 Thread Jan Beulich
On 17.09.2021 13:00, Jan Beulich wrote: > Hidden devices are associated with DomXEN but usable by the > hardware domain. Hence they need flushing as well when all devices are > to have flushes invoked. > > While there drop a redundant ATS-enabled check and constify the first > parameter of the inv

Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI boot

2021-10-11 Thread Jan Beulich
On 11.10.2021 10:03, Luca Fancellu wrote: > This patch introduces the support for dom0less configuration > when using UEFI boot on ARM, it permits the EFI boot to > continue if no dom0 kernel is specified but at least one domU > is found. > > Introduce the new property "xen,uefi-binary" for device

[PATCH] x86/PoD: defer nested P2M flushes

2021-10-11 Thread Jan Beulich
With NPT or shadow in use, the p2m_set_entry() -> p2m_pt_set_entry() -> write_p2m_entry() -> p2m_flush_nestedp2m() call sequence triggers a lock order violation when the PoD lock is held around it. Hence such flushing needs to be deferred. Steal the approach from p2m_change_type_range(). Similarly

[PATCH v2] x86/PV32: fix physdev_op_compat handling

2021-10-11 Thread Jan Beulich
The conversion of the original code failed to recognize that the 32-bit compat variant of this (sorry, two different meanings of "compat" here) needs to continue to invoke the compat handler, not the native one. Arrange for this by adding yet another #define. Affected functions (having existed pri

[PATCH 0/2] VT-d: correct / extend workaround(s) leaving an IOMMU disabled

2021-10-11 Thread Jan Beulich
This gets us closer to what Linux does, which hopefully improves the experience for people running Xen on affected hardware. Ian - I'm also Cc-ing you since this feels like being on the edge between a new feature and a bug fix. 1: generalize and correct "iommu=no-igfx" handling 2: Tylersburg isoc

[PATCH 1/2] VT-d: generalize and correct "iommu=no-igfx" handling

2021-10-11 Thread Jan Beulich
Linux'es supposedly equivalent "intel_iommu=igfx_off" deals with any graphics devices (not just Intel ones) while at the same time limiting the effect to IOMMUs covering only graphics devices. Keying the decision to leave translation disabled for an IOMMU to merely a magic SBDF tuple was wrong in t

[PATCH 2/2] VT-d: Tylersburg isoch DMAR unit with no TLB space

2021-10-11 Thread Jan Beulich
BIOSes, when enabling the dedicated DMAR unit for the sound device, need to also set a non-zero number of TLB entries in a respective system management register (VTISOCHCTRL). At least one BIOS is known to fail to do so, causing the VT-d engine to deadlock when used. Vaguely based on Linux'es e0fc

Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI boot

2021-10-11 Thread Luca Fancellu
> On 11 Oct 2021, at 09:11, Jan Beulich wrote: > > On 11.10.2021 10:03, Luca Fancellu wrote: >> This patch introduces the support for dom0less configuration >> when using UEFI boot on ARM, it permits the EFI boot to >> continue if no dom0 kernel is specified but at least one domU >> is found.

Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI boot

2021-10-11 Thread Jan Beulich
On 11.10.2021 10:50, Luca Fancellu wrote: >> On 11 Oct 2021, at 09:11, Jan Beulich wrote: >> On 11.10.2021 10:03, Luca Fancellu wrote: >>> This patch introduces the support for dom0less configuration >>> when using UEFI boot on ARM, it permits the EFI boot to >>> continue if no dom0 kernel is spec

Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI boot

2021-10-11 Thread Bertrand Marquis
Hi Jan, > On 11 Oct 2021, at 09:52, Jan Beulich wrote: > > On 11.10.2021 10:50, Luca Fancellu wrote: >>> On 11 Oct 2021, at 09:11, Jan Beulich wrote: >>> On 11.10.2021 10:03, Luca Fancellu wrote: This patch introduces the support for dom0less configuration when using UEFI boot on ARM,

[PATCH v4 0/3] Expose PMU to the guests

2021-10-11 Thread Michal Orzel
This patch series is a rework of an already pushed patch exposing PMU to the guests. Since the second version the vpmu parameter is common and prework in the form of reporting availability of vPMU on the hardware is added. The third version of the patch series removes the redundant check from x86

[PATCH v4 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu

2021-10-11 Thread Michal Orzel
Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which indicates whether the platform supports vPMU functionality. Modify Xen and tools accordingly. Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace definition in sysctl.h which wrongly use (1 << 6) instead of (1u << 6). Signed-off-by: Michal Orzel R

[PATCH v4 2/3] xen/arm: Check for PMU platform support

2021-10-11 Thread Michal Orzel
ID_AA64DFR0_EL1/ID_DFR0_EL1 registers provide information about PMU support. Replace structure dbg64/dbg32 with a union and fill in all the register fields according to document: ARM Architecture Registers(DDI 0595, 2021-06). Add macros boot_dbg_feature64/boot_dbg_feature32 to check for a debug fe

[PATCH v4 3/3] xen: Expose the PMU to the guests

2021-10-11 Thread Michal Orzel
Add parameter vpmu to xl domain configuration syntax to enable the access to PMU registers by disabling the PMU traps(currently only for ARM). The current status is that the PMU registers are not virtualized and the physical registers are directly accessible when this parameter is enabled. There i

[linux-linus test] 165459: tolerable FAIL - PUSHED

2021-10-11 Thread osstest service owner
flight 165459 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/165459/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds18 guest-start/debian.repeat fail REGR. vs. 165457 Tests which did not succeed,

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-11 Thread Julien Grall
Hi Stefano, On 08/10/2021 22:46, Stefano Stabellini wrote: On Fri, 8 Oct 2021, Julien Grall wrote: Hi Andrew, On Fri, 8 Oct 2021, 20:07 Andrew Cooper, wrote: On 06/10/2021 18:40, Rahul Singh wrote: > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. > Reje

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-11 Thread Roger Pau Monné
On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote: > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. > Reject the use of this new flag for x86 as VPCI is not supported for > DOMU guests for x86. I don't like this approach, XEN_DOMCTL_CDF_vpci should be set for x86 PVH d

Re: [PATCH v5 2/2] tools/xenstore: set open file descriptor limit for xenstored

2021-10-11 Thread Ian Jackson
Juergen Gross writes ("Re: [PATCH v5 2/2] tools/xenstore: set open file descriptor limit for xenstored"): > On 28.09.21 17:26, Ian Jackson wrote: > > Juergen Gross writes ("Re: [PATCH v5 2/2] tools/xenstore: set open file > > descriptor limit for xenstored"): > >> Hmm, maybe I should just use: >

Re: [PATCH v3 12/16] KVM: Move x86's perf guest info callbacks to generic KVM

2021-10-11 Thread Marc Zyngier
On Wed, 22 Sep 2021 01:05:29 +0100, Sean Christopherson wrote: > > Move x86's perf guest callbacks into common KVM, as they are semantically > identical to arm64's callbacks (the only other such KVM callbacks). > arm64 will convert to the common versions in a future patch. > > Implement the nece

Re: [PATCH v2 0/6] gnttab: add per-domain controls

2021-10-11 Thread Roger Pau Monné
On Wed, Sep 22, 2021 at 10:21:17AM +0200, Roger Pau Monne wrote: > Hello, > > First patch on the series is a trivial change to xenconsoled in order to > use xenforeignmemory stable library in order to map the shared console > ring instead of the unstable libxc interface. It's reviewed and ready to

Re: [PATCH] arm/efi: Fix null pointer dereference

2021-10-11 Thread Bertrand Marquis
Hi Luca, > On 11 Oct 2021, at 08:56, Luca Fancellu wrote: > > Fix for commit 60649d443dc395243e74d2b3e05594ac0c43cfe3 > that introduces a null pointer dereference when the > fdt_node_offset_by_compatible is called with "fdt" > argument null. > > Reported-by: Julien Grall > Fixes: 60649d443d ("

Re: [PATCH v3 14/16] KVM: arm64: Convert to the generic perf callbacks

2021-10-11 Thread Marc Zyngier
On Wed, 22 Sep 2021 01:05:31 +0100, Sean Christopherson wrote: > > Drop arm64's version of the callbacks in favor of the callbacks provided > by generic KVM, which are semantically identical. > > Signed-off-by: Sean Christopherson > --- > arch/arm64/kvm/perf.c | 34 ++--

Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI boot

2021-10-11 Thread Julien Grall
Hi Luca, On 11/10/2021 09:03, Luca Fancellu wrote: +static bool __init is_boot_module(int dt_module_offset) +{ +if ( (fdt_node_check_compatible(fdt, dt_module_offset, +"multiboot,kernel") == 0) || + (fdt_node_check_compatible(fdt, dt_module_offset,

Re: [PATCH v3 15/16] KVM: arm64: Drop perf.c and fold its tiny bits of code into arm.c / pmu.c

2021-10-11 Thread Marc Zyngier
On Wed, 22 Sep 2021 01:05:32 +0100, Sean Christopherson wrote: > > Call KVM's (un)register perf callbacks helpers directly from arm.c, and > move the PMU bits into pmu.c and rename the related helper accordingly. > > Signed-off-by: Sean Christopherson > --- > arch/arm64/include/asm/kvm_host.h

Re: Ping: [PATCH v2 3/3] AMD/IOMMU: consider hidden devices when flushing device I/O TLBs

2021-10-11 Thread Durrant, Paul
On 11/10/2021 09:04, Jan Beulich wrote: On 17.09.2021 13:00, Jan Beulich wrote: Hidden devices are associated with DomXEN but usable by the hardware domain. Hence they need flushing as well when all devices are to have flushes invoked. While there drop a redundant ATS-enabled check and constify

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-11 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag"): > Ian, for the 4.16 release, this series either needs completing with the > additional flag implemented, or this patch needs reverting to avoid us > shipping a broken interface. I have caught up on this

Re: [PATCH v2 0/6] gnttab: add per-domain controls

2021-10-11 Thread Christian Lindig
On 11 Oct 2021, at 10:36, Roger Pau Monne mailto:roger@citrix.com>> wrote: Ping? The two patches above didn't get any review in either v1 or v2. Patch #1 should be ready to go in AFAICT. Acked-by: Christian Lindig mailto:christian.lin...@citrix.com>>

[libvirt test] 165461: regressions - FAIL

2021-10-11 Thread osstest service owner
flight 165461 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/165461/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH v2] x86/PV32: fix physdev_op_compat handling

2021-10-11 Thread Roger Pau Monné
On Mon, Oct 11, 2021 at 10:20:41AM +0200, Jan Beulich wrote: > The conversion of the original code failed to recognize that the 32-bit > compat variant of this (sorry, two different meanings of "compat" here) > needs to continue to invoke the compat handler, not the native one. > Arrange for this b

Re: [PATCH v4 2/3] xen/arm: Check for PMU platform support

2021-10-11 Thread Julien Grall
Hi Michal, On 11/10/2021 10:00, Michal Orzel wrote: ID_AA64DFR0_EL1/ID_DFR0_EL1 registers provide information about PMU support. Replace structure dbg64/dbg32 with a union and fill in all the register fields according to document: ARM Architecture Registers(DDI 0595, 2021-06). Add macros boot_d

Re: [PATCH v4 3/3] xen: Expose the PMU to the guests

2021-10-11 Thread Julien Grall
Hi Michal, On 11/10/2021 10:00, Michal Orzel wrote: Add parameter vpmu to xl domain configuration syntax to enable the access to PMU registers by disabling the PMU traps(currently only for ARM). The current status is that the PMU registers are not virtualized and the physical registers are dire

Re: [XEN PATCH v7 18/51] build: fix $(TARGET).efi creation in arch/arm

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > There is no need to try to guess a relative path to the "xen.efi" file, > we can simply use $@. Also, there's no need to use `notdir`, make > already do that work via $(@F). > > Signed-off-by: Anthony PERARD Reviewed-by: Jan Beulich As to the subjec

Re: [PATCH 01/11] xen: reserve flags for internal usage in xen_domctl_createdomain

2021-10-11 Thread Julien Grall
Hi Jan, On 28/09/2021 13:05, Jan Beulich wrote: On 23.09.2021 11:54, Julien Grall wrote: On 23/09/2021 08:11, Penny Zheng wrote: From: Stefano Stabellini We are passing an extra special boolean flag at domain creation to specify whether we want to the domain to be privileged (i.e. dom0) or n

Re: [PATCH 09/11] xen/arm: if 1:1 direct-map domain use native UART address and IRQ number for vPL011

2021-10-11 Thread Julien Grall
On 09/10/2021 09:47, Penny Zheng wrote: Hi Julien Hi Penny, -Original Message- From: Julien Grall Sent: Thursday, September 23, 2021 7:14 PM To: Penny Zheng ; xen-devel@lists.xenproject.org; sstabell...@kernel.org Cc: Bertrand Marquis ; Wei Chen Subject: Re: [PATCH 09/11] xen/arm: i

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Roger Pau Monné
On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote: > The existing VPCI support available for X86 is adapted for Arm. > When the device is added to XEN via the hyper call > “PHYSDEVOP_pci_device_add”, VPCI handler for the config space > access is added to the Xen to emulate the PCI devices

Re: [PATCH 0/2] VT-d: correct / extend workaround(s) leaving an IOMMU disabled [and 1 more messages]

2021-10-11 Thread Ian Jackson
Jan Beulich writes ("[PATCH 0/2] VT-d: correct / extend workaround(s) leaving an IOMMU disabled"): > Ian - I'm also Cc-ing you since this feels like being on the edge > between a new feature and a bug fix. Thanks. I think 2/ is a new quirk (or, new behaviour for an existing quirk). I think I am

Re: [XEN PATCH v7 20/51] build: avoid re-executing the main Makefile by introducing build.mk

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > Currently, the xen/Makefile is re-parsed several times: once to start > the build process, and several more time with Rules.mk including it. > This makes it difficult to reason with a Makefile used for several > purpose, and it actually slow down the bui

Re: [PATCH v4 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu

2021-10-11 Thread Ian Jackson
Michal Orzel writes ("[PATCH v4 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu"): > Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which > indicates whether the platform supports vPMU > functionality. Modify Xen and tools accordingly. > > Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace > defin

Re: [PATCH 0/2] VT-d: correct / extend workaround(s) leaving an IOMMU disabled [and 1 more messages]

2021-10-11 Thread Jan Beulich
On 11.10.2021 12:56, Ian Jackson wrote: > Jan Beulich writes ("[PATCH 0/2] VT-d: correct / extend workaround(s) leaving > an IOMMU disabled"): >> Ian - I'm also Cc-ing you since this feels like being on the edge >> between a new feature and a bug fix. > > Thanks. > > I think 2/ is a new quirk (o

Re: [PATCH 01/11] xen: reserve flags for internal usage in xen_domctl_createdomain

2021-10-11 Thread Jan Beulich
On 11.10.2021 12:45, Julien Grall wrote: > Hi Jan, > > On 28/09/2021 13:05, Jan Beulich wrote: >> On 23.09.2021 11:54, Julien Grall wrote: >>> On 23/09/2021 08:11, Penny Zheng wrote: From: Stefano Stabellini We are passing an extra special boolean flag at domain creation to sp

Re: [PATCH 10/11] xen/arm: device assignment on 1:1 direct-map domain

2021-10-11 Thread Julien Grall
On 09/10/2021 10:40, Penny Zheng wrote: Hi Julien Hi Penny, -Original Message- From: Julien Grall Sent: Thursday, September 23, 2021 7:27 PM To: Penny Zheng ; xen-devel@lists.xenproject.org; sstabell...@kernel.org Cc: Bertrand Marquis ; Wei Chen Subject: Re: [PATCH 10/11] xen/a

Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI boot

2021-10-11 Thread Luca Fancellu
> On 11 Oct 2021, at 10:39, Julien Grall wrote: > > Hi Luca, > Hi Julien, > On 11/10/2021 09:03, Luca Fancellu wrote: >> +static bool __init is_boot_module(int dt_module_offset) >> +{ >> +if ( (fdt_node_check_compatible(fdt, dt_module_offset, >> +"mul

Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support

2021-10-11 Thread Julien Grall
Hi Oleksandr, On 07/10/2021 21:29, Oleksandr wrote: @@ -1193,8 +1215,8 @@ static int __init make_hypervisor_node(struct domain *d,    u64 start = ext_regions->bank[i].start;    u64 size = ext_regions->bank[i].size;    -    dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx6

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-11 Thread Michal Orzel
Hi Stefano, On 08.10.2021 23:46, Stefano Stabellini wrote: > On Fri, 8 Oct 2021, Julien Grall wrote: >> Hi Andrew, >> >> On Fri, 8 Oct 2021, 20:07 Andrew Cooper, wrote: >> On 06/10/2021 18:40, Rahul Singh wrote: >> > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. >>

Re: [XEN PATCH v7 21/51] build: set ALL_OBJS to main Makefile; move prelink.o to main Makefile

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -271,8 +271,21 @@ CFLAGS += -flto > LDFLAGS-$(CONFIG_CC_IS_CLANG) += -plugin LLVMgold.so > endif > > +# Note that link order matters! > +ALL_OBJS-y:= common/built_in.o > +ALL_OBJS-y

Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI boot

2021-10-11 Thread Julien Grall
Hi Luca, On 11/10/2021 12:23, Luca Fancellu wrote: On 11 Oct 2021, at 10:39, Julien Grall wrote: Hi Luca, Hi Julien, On 11/10/2021 09:03, Luca Fancellu wrote: +static bool __init is_boot_module(int dt_module_offset) +{ +if ( (fdt_node_check_compatible(fdt, dt_module_offset, +

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-11 Thread Jan Beulich
On 11.10.2021 13:29, Michal Orzel wrote: > On 08.10.2021 23:46, Stefano Stabellini wrote: >> On Fri, 8 Oct 2021, Julien Grall wrote: >>> On Fri, 8 Oct 2021, 20:07 Andrew Cooper, wrote: >>> On 06/10/2021 18:40, Rahul Singh wrote: >>> > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI s

Re: [XEN PATCH v7 22/51] build: clean common temporary files from root makefile

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD Trying to synthesize a description: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -382,6 +382,7 @@ _clean: > $(MAKE) $(clean) test > $(MAKE) $(kconfig) clean > find . \( -name "*.o" -o -name ".*.d" -o -

Re: [PATCH v5 09/11] xen/arm: Transitional change to build HAS_VPCI on ARM.

2021-10-11 Thread Roger Pau Monné
On Wed, Oct 06, 2021 at 06:40:35PM +0100, Rahul Singh wrote: > This patch will be reverted once we add support for VPCI MSI/MSIX > support on ARM. > > Signed-off-by: Rahul Singh > Acked-by: Stefano Stabellini > Reviewed-by: Bertrand Marquis Reviewed-by: Roger Pau Monné > --- > Change in v5:

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Roger Pau Monné
On Wed, Oct 06, 2021 at 06:40:27PM +0100, Rahul Singh wrote: > ARM architecture does not implement I/O ports. Ignore this call on ARM > to avoid the overhead of making a hypercall just for Xen to return > -ENOSYS. What is the cal trace of this function actually on Arm? AFAICT libxl will only call

Re: [XEN PATCH v7 23/51] build,include: remove arch-*/*.h public header listing from headers*.chk

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > $(public-y) contains "public/arch-%" but when used by > $(PUBLIC_HEADERS) $(public-y) is filtered-out by the pattern > "public/arch-%". So $(public-y) content is never used. It has been this way from its very introduction, and iirc $(public-y) was meant

Re: [PATCH v4 2/3] xen/arm: Check for PMU platform support

2021-10-11 Thread Michal Orzel
Hi Julien, On 11.10.2021 12:17, Julien Grall wrote: > Hi Michal, > > On 11/10/2021 10:00, Michal Orzel wrote: >> ID_AA64DFR0_EL1/ID_DFR0_EL1 registers provide >> information about PMU support. Replace structure >> dbg64/dbg32 with a union and fill in all the >> register fields according to docume

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-11 Thread Michal Orzel
Hi Roger, On 11.10.2021 11:27, Roger Pau Monné wrote: > On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote: >> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. >> Reject the use of this new flag for x86 as VPCI is not supported for >> DOMU guests for x86. > > I don't lik

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Bertrand Marquis
Hi Roger, > On 11 Oct 2021, at 12:47, Roger Pau Monné wrote: > > On Wed, Oct 06, 2021 at 06:40:27PM +0100, Rahul Singh wrote: >> ARM architecture does not implement I/O ports. Ignore this call on ARM >> to avoid the overhead of making a hypercall just for Xen to return >> -ENOSYS. > > What is t

[ovmf test] 165462: all pass - PUSHED

2021-10-11 Thread osstest service owner
flight 165462 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/165462/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 19ee56c4b33faa33078894a6c8495c81c660b8be baseline version: ovmf 769e63999ff5c786d5aac

Re: [PATCH v5 09/11] xen/arm: Transitional change to build HAS_VPCI on ARM.

2021-10-11 Thread Bertrand Marquis
Hi Roger, > On 11 Oct 2021, at 12:43, Roger Pau Monné wrote: > > On Wed, Oct 06, 2021 at 06:40:35PM +0100, Rahul Singh wrote: >> This patch will be reverted once we add support for VPCI MSI/MSIX >> support on ARM. >> >> Signed-off-by: Rahul Singh >> Acked-by: Stefano Stabellini >> Reviewed-by

Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct xen_arch_domainconfig

2021-10-11 Thread Oleksandr
On 09.10.21 01:14, Stefano Stabellini wrote: Hi Stefano On Fri, 8 Oct 2021, Oleksandr wrote: On 08.10.21 15:36, Jan Beulich wrote: On 08.10.2021 12:25, Oleksandr wrote: Just a quick question. What do you think can XEN_DOMCTL_getdomaininfo be reused to retrieve gpaddr_bits? I don't see why

Re: [XEN PATCH v7 24/51] build: prepare to always invoke $(MAKE) from xen/, use $(obj)

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > In a future patch, when building a subdirectory, we will set > "obj=$subdir" rather than change directory. > > Before that, we add "$(obj)" and "$(src)" in as many places as > possible where we will need to know which subdirectory is been built. > "$(ob

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Bertrand Marquis
Hi Jan, As Rahul is on leave, I will answer you and make the changes needed. > On 7 Oct 2021, at 14:43, Jan Beulich wrote: > > On 06.10.2021 19:40, Rahul Singh wrote: >> --- /dev/null >> +++ b/xen/arch/arm/vpci.c >> @@ -0,0 +1,102 @@ >> +/* >> + * xen/arch/arm/vpci.c >> + * >> + * This program

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Jan Beulich
On 11.10.2021 14:41, Bertrand Marquis wrote: >> On 7 Oct 2021, at 14:43, Jan Beulich wrote: >> On 06.10.2021 19:40, Rahul Singh wrote: >>> --- /dev/null >>> +++ b/xen/arch/arm/vpci.c >>> @@ -0,0 +1,102 @@ >>> +/* >>> + * xen/arch/arm/vpci.c >>> + * >>> + * This program is free software; you can re

Re: [PATCH 0/2] VT-d: correct / extend workaround(s) leaving an IOMMU disabled [and 1 more messages]

2021-10-11 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH 0/2] VT-d: correct / extend workaround(s) leaving an IOMMU disabled [and 1 more messages]"): > On 11.10.2021 12:56, Ian Jackson wrote: > > I think 2/ is a new quirk (or, new behaviour for an existing quirk). > > I think I am happy to treat that as a bugfix, assuming

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-11 Thread Roger Pau Monné
On Mon, Oct 11, 2021 at 01:35:18PM +0200, Jan Beulich wrote: > On 11.10.2021 13:29, Michal Orzel wrote: > > On 08.10.2021 23:46, Stefano Stabellini wrote: > >> On Fri, 8 Oct 2021, Julien Grall wrote: > >>> On Fri, 8 Oct 2021, 20:07 Andrew Cooper, > >>> wrote: > >>> On 06/10/2021 18:40, Rahu

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Roger Pau Monné
On Mon, Oct 11, 2021 at 12:11:04PM +, Bertrand Marquis wrote: > Hi Roger, > > > On 11 Oct 2021, at 12:47, Roger Pau Monné wrote: > > > > On Wed, Oct 06, 2021 at 06:40:27PM +0100, Rahul Singh wrote: > >> ARM architecture does not implement I/O ports. Ignore this call on ARM > >> to avoid the

Re: [XEN PATCH v7 25/51] build: rework test/livepatch/Makefile

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > This rework the livepatch/Makefile to make it less repetitive and make > use of the facilities. All the targets to be built are now listed in > $(extra-y) which will allow Rules.mk to build them without the need of > a local target in a future patch. >

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Bertrand Marquis
Hi Jan, > On 11 Oct 2021, at 14:09, Jan Beulich wrote: > > On 11.10.2021 14:41, Bertrand Marquis wrote: >>> On 7 Oct 2021, at 14:43, Jan Beulich wrote: >>> On 06.10.2021 19:40, Rahul Singh wrote: --- /dev/null +++ b/xen/arch/arm/vpci.c @@ -0,0 +1,102 @@ +/* + * xen/arch

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Bertrand Marquis
Hi Roger, + Oleksandr to have a better PCI expert then me. > On 11 Oct 2021, at 14:20, Roger Pau Monné wrote: > > On Mon, Oct 11, 2021 at 12:11:04PM +, Bertrand Marquis wrote: >> Hi Roger, >> >>> On 11 Oct 2021, at 12:47, Roger Pau Monné wrote: >>> >>> On Wed, Oct 06, 2021 at 06:40:27PM

Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl

2021-10-11 Thread Roger Pau Monné
On Thu, Oct 07, 2021 at 05:11:47PM +0100, Ian Jackson wrote: > Rahul Singh writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree > node in libxl"): > > As Stefano suggested in another email that we can remove the vpci > > option, if we reach to conclusion that we need vpci option I wil

Re: [XEN PATCH v7 14/51] xen: move include/asm-* to arch/*/include/asm

2021-10-11 Thread Anthony PERARD
On Thu, Oct 07, 2021 at 04:17:28PM +0200, Jan Beulich wrote: > On 24.08.2021 12:50, Anthony PERARD wrote: > > --- a/tools/include/Makefile > > +++ b/tools/include/Makefile > > @@ -30,7 +30,7 @@ xen-dir: > > ln -s $(XEN_ROOT)/xen/include/acpi/platform acpi/ > > ln -s $(XEN_ROOT)/xen/include/

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Roger Pau Monné
On Mon, Oct 11, 2021 at 01:40:30PM +, Bertrand Marquis wrote: > Hi Roger, > > + Oleksandr to have a better PCI expert then me. > > > On 11 Oct 2021, at 14:20, Roger Pau Monné wrote: > > > > On Mon, Oct 11, 2021 at 12:11:04PM +, Bertrand Marquis wrote: > >> Hi Roger, > >> > >>> On 11 Oc

Re: [XEN PATCH v7 26/51] build: build everything from the root dir, use obj=$subdir

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > A subdirectory is now built by setting "$(obj)" instead of changing > directory. "$(obj)" should always be set when using "Rules.mk" and > thus a shortcut "$(build)" is introduced and should be used. > > A new variable "$(need-builtin)" is introduce. It

Re: [PATCH v2] x86/PV32: fix physdev_op_compat handling

2021-10-11 Thread Andrew Cooper
On 11/10/2021 11:06, Roger Pau Monné wrote: > On Mon, Oct 11, 2021 at 10:20:41AM +0200, Jan Beulich wrote: >> The conversion of the original code failed to recognize that the 32-bit >> compat variant of this (sorry, two different meanings of "compat" here) >> needs to continue to invoke the compat

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Jan Beulich
On 11.10.2021 15:34, Bertrand Marquis wrote: >> On 11 Oct 2021, at 14:09, Jan Beulich wrote: >> On 11.10.2021 14:41, Bertrand Marquis wrote: On 7 Oct 2021, at 14:43, Jan Beulich wrote: On 06.10.2021 19:40, Rahul Singh wrote: > --- /dev/null > +++ b/xen/arch/arm/vpci.c > @@ -

Re: [PATCH v4 3/3] xen: Expose the PMU to the guests

2021-10-11 Thread Bertrand Marquis
Hi Julien, > On 11 Oct 2021, at 11:21, Julien Grall wrote: > > Hi Michal, > > On 11/10/2021 10:00, Michal Orzel wrote: >> Add parameter vpmu to xl domain configuration syntax >> to enable the access to PMU registers by disabling >> the PMU traps(currently only for ARM). >> The current status is

Re: [XEN PATCH v7 16/51] build: generate "include/xen/compile.h" with if_changed

2021-10-11 Thread Anthony PERARD
On Thu, Oct 07, 2021 at 04:55:01PM +0200, Jan Beulich wrote: > On 24.08.2021 12:50, Anthony PERARD wrote: > > --- a/.gitignore > > +++ b/.gitignore > > @@ -332,7 +332,6 @@ xen/include/compat/* > > xen/include/config/ > > xen/include/generated/ > > xen/include/public/public > > -xen/include/xen/*

Re: [XEN PATCH v7 05/51] x86/mm: avoid building multiple .o from a single .c file

2021-10-11 Thread Andrew Cooper
On 08/09/2021 12:44, Ian Jackson wrote: > Anthony PERARD writes ("Re: [XEN PATCH v7 05/51] x86/mm: avoid building > multiple .o from a single .c file"): >> On Tue, Sep 07, 2021 at 08:14:14AM +0200, Jan Beulich wrote: >>> Hmm, when replying to 00/51 I didn't recall I gave an R-b for this one >>> al

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Oleksandr Andrushchenko
Hi, all On 11.10.21 16:40, Bertrand Marquis wrote: > Hi Roger, > > + Oleksandr to have a better PCI expert then me. > >> On 11 Oct 2021, at 14:20, Roger Pau Monné wrote: >> >> On Mon, Oct 11, 2021 at 12:11:04PM +, Bertrand Marquis wrote: >>> Hi Roger, >>> On 11 Oct 2021, at 12:47, Roger

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Bertrand Marquis
Hi Roger, > On 11 Oct 2021, at 14:57, Roger Pau Monné wrote: > > On Mon, Oct 11, 2021 at 01:40:30PM +, Bertrand Marquis wrote: >> Hi Roger, >> >> + Oleksandr to have a better PCI expert then me. >> >>> On 11 Oct 2021, at 14:20, Roger Pau Monné wrote: >>> >>> On Mon, Oct 11, 2021 at 12:11

Re: [XEN PATCH v7 27/51] build: introduce if_changed_deps

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > This macro does compare command line like if_changed, but it also > rewrite the dependencies generated by $(CC) in order to depend on a > CONFIG_* as generated by kconfig instead of depending on autoconf.h. > This allow to make a change in kconfig option

[xen-unstable-smoke test] 165465: tolerable all pass - PUSHED

2021-10-11 Thread osstest service owner
flight 165465 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/165465/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [XEN PATCH v7 17/51] build: set XEN_BUILD_EFI earlier

2021-10-11 Thread Anthony PERARD
On Thu, Oct 07, 2021 at 06:14:33PM +0200, Jan Beulich wrote: > On 24.08.2021 12:50, Anthony PERARD wrote: > > $(nr-fixups) is renamed to $(efi-check-relocs) as the former might be > > a bit too generic. > > While I don't mind the prefix addition, may I please ask that the rest > of the name remain

Re: [XEN PATCH v7 18/51] build: fix $(TARGET).efi creation in arch/arm

2021-10-11 Thread Anthony PERARD
On Mon, Oct 11, 2021 at 12:37:55PM +0200, Jan Beulich wrote: > On 24.08.2021 12:50, Anthony PERARD wrote: > > There is no need to try to guess a relative path to the "xen.efi" file, > > we can simply use $@. Also, there's no need to use `notdir`, make > > already do that work via $(@F). > > > > Si

Re: [XEN PATCH v7 28/51] build: rename __LINKER__ to LINKER_SCRIPT

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > For two reasons: this macro is used to generate a "linker script" and > is not by the linker, and name starting with an underscore '_' are > supposed to be reserved, so better avoid them when not needed. > > Signed-off-by: Anthony PERARD Reviewed-by:

Re: [XEN PATCH v7 29/51] build: add an other explicite rules to not build $(XEN_ROOT)/.config

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > GNU Make will try to rebuild every Makefile included with the > "include" directive, so everytime Config.mk is used, make will try to > build ".config". This would normally not be an issue, unless we happen > to have a rules which match. This is the case

Re: [PATCH v3 12/16] KVM: Move x86's perf guest info callbacks to generic KVM

2021-10-11 Thread Sean Christopherson
On Mon, Oct 11, 2021, Marc Zyngier wrote: > On Wed, 22 Sep 2021 01:05:29 +0100, Sean Christopherson > wrote: > > diff --git a/arch/arm64/include/asm/kvm_host.h > > b/arch/arm64/include/asm/kvm_host.h > > index ed940aec89e0..828b6eaa2c56 100644 > > --- a/arch/arm64/include/asm/kvm_host.h > > +++

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Bertrand Marquis
Hi Jan, > On 11 Oct 2021, at 15:10, Jan Beulich wrote: > > On 11.10.2021 15:34, Bertrand Marquis wrote: >>> On 11 Oct 2021, at 14:09, Jan Beulich wrote: >>> On 11.10.2021 14:41, Bertrand Marquis wrote: > On 7 Oct 2021, at 14:43, Jan Beulich wrote: > On 06.10.2021 19:40, Rahul Singh wro

[xen-unstable test] 165460: tolerable FAIL

2021-10-11 Thread osstest service owner
flight 165460 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/165460/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 165452 test-armhf-armhf-libvirt 16 save

Re: [XEN PATCH v7 20/51] build: avoid re-executing the main Makefile by introducing build.mk

2021-10-11 Thread Anthony PERARD
On Mon, Oct 11, 2021 at 12:56:54PM +0200, Jan Beulich wrote: > On 24.08.2021 12:50, Anthony PERARD wrote: > > Currently, the xen/Makefile is re-parsed several times: once to start > > the build process, and several more time with Rules.mk including it. > > This makes it difficult to reason with a M

Re: [XEN PATCH v7 20/51] build: avoid re-executing the main Makefile by introducing build.mk

2021-10-11 Thread Jan Beulich
On 11.10.2021 16:58, Anthony PERARD wrote: > On Mon, Oct 11, 2021 at 12:56:54PM +0200, Jan Beulich wrote: >> On 24.08.2021 12:50, Anthony PERARD wrote: >>> Currently, the xen/Makefile is re-parsed several times: once to start >>> the build process, and several more time with Rules.mk including it.

Re: [PATCH v3 12/16] KVM: Move x86's perf guest info callbacks to generic KVM

2021-10-11 Thread Marc Zyngier
On Mon, 11 Oct 2021 15:46:25 +0100, Sean Christopherson wrote: > > On Mon, Oct 11, 2021, Marc Zyngier wrote: > > On Wed, 22 Sep 2021 01:05:29 +0100, Sean Christopherson > > wrote: > > > diff --git a/arch/arm64/include/asm/kvm_host.h > > > b/arch/arm64/include/asm/kvm_host.h > > > index ed940ae

Re: [XEN PATCH v7 30/51] build: hook kconfig into xen build system

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > Now that xen's build system is very close to Linux's ones, we can hook > "Makefile.host" into Xen's build system, and we can build Kconfig with > that. > > Signed-off-by: Anthony PERARD Reviewed-by: Jan Beulich

Re: [XEN PATCH v7 32/51] build: Remove KBUILD_ specific from Makefile.host

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > This will allow $(HOSTCFLAGS) to actually be used when building > programmes for the build-host. > > The other variable don't exist in our build system. > > Also remove $(KBUILD_EXTMOD) since it should always be empty. > > Signed-off-by: Anthony PERAR

Re: [XEN PATCH v7 33/51] build: handle always-y and hostprogs-always-y

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > This will be used for xen/tools/. > > Signed-off-by: Anthony PERARD Acked-by: Jan Beulich

Re: [XEN PATCH v7 34/51] build: start building the tools with the main makefiles

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > This will make out-of-tree build easier. > > Signed-off-by: Anthony PERARD Acked-by: Jan Beulich

Re: [XEN PATCH v7 35/51] build: Add headers path to CFLAGS once for all archs

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > This just remove duplication. > > Signed-off-by: Anthony PERARD Ah, here we go. Reviewed-by: Jan Beulich

Re: [XEN PATCH v7 36/51] build: generate x86's asm-macros.h with filechk

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > When we will build out-of-tree, make is going to try to generate > "asm-macros.h" before the directories "arch/x86/include/asm" exist, > thus we would need to call `mkdir` explicitly. We will use "filechk" > for that as it does everything that the curren

Re: [XEN PATCH v7 37/51] build: clean-up "clean" rules of duplication

2021-10-11 Thread Jan Beulich
On 24.08.2021 12:50, Anthony PERARD wrote: > All those files to be removed are already done in the main Makefile, > either by the "find" command or directly (for $(TARGET).efi). > > Signed-off-by: Anthony PERARD Acked-by: Jan Beulich

  1   2   >