Re: [PATCH] xen/bitmap: Make bitmap_long_to_byte() and bitmap_byte_to_long() static

2021-08-10 Thread Jan Beulich
On 09.08.2021 16:41, Jane Malalane wrote: > Functions made static as there are no external callers. > > Suggested-by: Andrew Cooper > Signed-off-by: Jane Malalane Acked-by: Jan Beulich

Re: [XEN PATCH v6 21/31] build: set XEN_BUILD_EFI earlier

2021-08-10 Thread Jan Beulich
On 09.08.2021 17:59, Anthony PERARD wrote: > On Thu, Aug 05, 2021 at 09:27:18AM +0200, Jan Beulich wrote: >> On 01.07.2021 16:10, Anthony PERARD wrote: >>> We are going to need the variable XEN_BUILD_EFI earlier. >>> >>> This early check is using "try-run" to allow to have a temporary >>> output fi

Re: [PATCH] x86: work around build issue with GNU ld 2.37

2021-08-10 Thread Andrew Cooper
On 03/08/2021 07:37, Jan Beulich wrote: > On 27.07.2021 14:33, Andrew Cooper wrote: >> On 22/07/2021 10:20, Jan Beulich wrote: >>> I suspect it is commit 40726f16a8d7 ("ld script expression parsing") >>> which broke the hypervisor build, by no longer accepting section names >>> with a dash in them

Re: [PATCH v2 08/10] xsm: remove xsm_default_t from hook definitions

2021-08-10 Thread Jan Beulich
On 06.08.2021 23:41, Daniel P. Smith wrote: > My concerns/issues: > B1. The irony that XSM is unsupported but XSM + SILO is supported (for > Arm) Just one remark here: Prior to SILO introduction (and to some perhaps ever afterwards), just like !XSM stood for "XSM dummy module", XSM stood for "

Re: [PATCH] x86: work around build issue with GNU ld 2.37

2021-08-10 Thread Jan Beulich
On 10.08.2021 10:33, Andrew Cooper wrote: > On 03/08/2021 07:37, Jan Beulich wrote: >> On 27.07.2021 14:33, Andrew Cooper wrote: >>> On 22/07/2021 10:20, Jan Beulich wrote: I suspect it is commit 40726f16a8d7 ("ld script expression parsing") which broke the hypervisor build, by no longer

[PATCH] tools: ROUNDUP() related adjustments

2021-08-10 Thread Jan Beulich
For one xc_private.h needlessly repeats xen-tools/libs.h's definition. And then there are two suspicious uses (resulting from the inconsistency with the respective 2nd parameter of DIV_ROUNDUP()): While the one in tools/console/daemon/io.c - as per the code comment - intentionally uses 8 as the se

Re: [PATCH V3 01/13] x86/HV: Initialize GHCB page in Isolation VM

2021-08-10 Thread Wei Liu
On Mon, Aug 09, 2021 at 01:56:05PM -0400, Tianyu Lan wrote: [...] > static int hv_cpu_init(unsigned int cpu) > { > union hv_vp_assist_msr_contents msr = { 0 }; > @@ -85,6 +111,8 @@ static int hv_cpu_init(unsigned int cpu) > } > } > > + hyperv_init_ghcb(); > + Why

Re: [PATCH V3 03/13] x86/HV: Add new hvcall guest address host visibility support

2021-08-10 Thread Wei Liu
On Mon, Aug 09, 2021 at 01:56:07PM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > Add new hvcall guest address host visibility support to mark > memory visible to host. Call it inside set_memory_decrypted > /encrypted(). Add HYPERVISOR feature check in the > hv_is_isolation_supported() to optimi

[xen-unstable test] 164145: FAIL

2021-08-10 Thread osstest service owner
flight 164145 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/164145/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm broken in 164137 Tests whi

[libvirt test] 164147: regressions - FAIL

2021-08-10 Thread osstest service owner
flight 164147 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/164147/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

Re: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space

2021-08-10 Thread Oleksandr
On 10.08.21 09:34, Wei Chen wrote: Hi Oleksandr, Hi Wei, Julien. -Original Message- From: Oleksandr Sent: 2021年8月10日 2:25 To: Julien Grall Cc: Stefano Stabellini ; Andrew Cooper ; xen-devel@lists.xenproject.org; Oleksandr Tyshchenko ; Daniel De Graaf ; Daniel P. Smith ; Ian Jac

[xen-unstable-smoke test] 164148: tolerable all pass - PUSHED

2021-08-10 Thread osstest service owner
flight 164148 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/164148/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH V3 01/13] x86/HV: Initialize GHCB page in Isolation VM

2021-08-10 Thread Tianyu Lan
Hi Wei: Thanks for review. On 8/10/2021 6:56 PM, Wei Liu wrote: On Mon, Aug 09, 2021 at 01:56:05PM -0400, Tianyu Lan wrote: [...] static int hv_cpu_init(unsigned int cpu) { union hv_vp_assist_msr_contents msr = { 0 }; @@ -85,6 +111,8 @@ static int hv_cpu_init(unsigned int cpu)

Re: [PATCH V3 03/13] x86/HV: Add new hvcall guest address host visibility support

2021-08-10 Thread Tianyu Lan
On 8/10/2021 7:03 PM, Wei Liu wrote: diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c index 0bb4d9ca7a55..b3683083208a 100644 --- a/arch/x86/hyperv/hv_init.c +++ b/arch/x86/hyperv/hv_init.c @@ -607,6 +607,12 @@ EXPORT_SYMBOL_GPL(hv_get_isolation_type); bool hv_is_isolation_

[linux-linus test] 164146: regressions - FAIL

2021-08-10 Thread osstest service owner
flight 164146 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164146/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

Re: [PATCH V3 03/13] x86/HV: Add new hvcall guest address host visibility support

2021-08-10 Thread Tianyu Lan
On 8/10/2021 6:12 AM, Dave Hansen wrote: On 8/9/21 10:56 AM, Tianyu Lan wrote: From: Tianyu Lan Add new hvcall guest address host visibility support to mark memory visible to host. Call it inside set_memory_decrypted /encrypted(). Add HYPERVISOR feature check in the hv_is_isolation_supported()

IOMMU page table freeing

2021-08-10 Thread Jan Beulich
Hello, while I don't expect this case to occur often in practice, for superpage support we will need to be able to correctly free a page table (hierarchy) after replacing its mapping range by a superpage. Following P2M by carrying out an immediate iotlb flush prior to synchronously freeing the mem

Disable swiotlb for Dom0

2021-08-10 Thread Roman Skakun
Hi, Stefano! I have observed your patch here: https://patchwork.kernel.org/project/xen-devel/patch/alpine.DEB.2.21.2102161333090.3234@sstabellini-ThinkPad-T480s/ And I collided with the same issue, when Dom0 device trying to use swiotlb fops for devices which are controlled by IOMMU. Prerequisit

Re: Disable swiotlb for Dom0

2021-08-10 Thread Julien Grall
On 10/08/2021 16:38, Roman Skakun wrote: Hi, Stefano! Hi, I have observed your patch here: https://patchwork.kernel.org/project/xen-devel/patch/alpine.DEB.2.21.2102161333090.3234@sstabellini-ThinkPad-T480s/ And I collided with the same issue, when Dom0 device trying to use swiotlb fops fo

Re: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space

2021-08-10 Thread Julien Grall
On 10/08/2021 12:58, Oleksandr wrote: On 10.08.21 09:34, Wei Chen wrote: Hi Oleksandr, Hi Wei, Julien. Hi, -Original Message- From: Oleksandr Sent: 2021年8月10日 2:25 To: Julien Grall Cc: Stefano Stabellini ; Andrew Cooper ; xen-devel@lists.xenproject.org; Oleksandr Tyshchenko ;

Re: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space

2021-08-10 Thread Julien Grall
On 09/08/2021 22:18, Oleksandr wrote: On 09.08.21 23:45, Julien Grall wrote: Hi Julien Hi Oleksandr, On 09/08/2021 19:24, Oleksandr wrote: On 09.08.21 18:42, Julien Grall wrote: 1. If IOMMU is enabled for Dom0 -> provide holes found in Host DT as safe ranges I would take into the

Re: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space

2021-08-10 Thread Oleksandr
On 10.08.21 19:21, Julien Grall wrote: Hi Julien On 10/08/2021 12:58, Oleksandr wrote: On 10.08.21 09:34, Wei Chen wrote: Hi Oleksandr, Hi Wei, Julien. Hi, -Original Message- From: Oleksandr Sent: 2021年8月10日 2:25 To: Julien Grall Cc: Stefano Stabellini ; Andrew Cooper ; xe

Re: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space

2021-08-10 Thread Oleksandr
On 10.08.21 19:28, Julien Grall wrote: Hi Julien. On 09/08/2021 22:18, Oleksandr wrote: On 09.08.21 23:45, Julien Grall wrote: Hi Julien Hi Oleksandr, On 09/08/2021 19:24, Oleksandr wrote: On 09.08.21 18:42, Julien Grall wrote: 1. If IOMMU is enabled for Dom0 -> provide holes fou

[PATCH 1/2] xen/kexec: Remove use of TRUE/FALSE

2021-08-10 Thread Kevin Stefanov
Whilst fixing this, also changed bool_t to bool. Suggested-by: Andrew Cooper Signed-off-by: Kevin Stefanov --- CC: Andrew Cooper --- xen/common/kexec.c | 6 +++--- xen/include/xen/kexec.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/common/kexec.c b/xen/common

[PATCH 0/2] xen: Remove use of TRUE/FALSE

2021-08-10 Thread Kevin Stefanov
Kevin Stefanov (2): xen/kexec: Remove use of TRUE/FALSE x86/ioapic: Remove use of TRUE/FALSE xen/arch/x86/io_apic.c | 12 ++-- xen/common/kexec.c | 6 +++--- xen/drivers/passthrough/vtd/utils.c | 2 +- xen/include/xen/kexec.h | 2 +- 4 file

[PATCH 2/2] x86/ioapic: Remove use of TRUE/FALSE

2021-08-10 Thread Kevin Stefanov
Also fix stray usage in VT-d. Suggested-by: Andrew Cooper Signed-off-by: Kevin Stefanov --- CC: Jan Beulich CC: Andrew Cooper CC: "Roger Pau Monné" CC: Wei Liu CC: Kevin Tian --- xen/arch/x86/io_apic.c | 12 ++-- xen/drivers/passthrough/vtd/utils.c | 2 +- 2 files cha

Re: [PATCH 1/2] xen/kexec: Remove use of TRUE/FALSE

2021-08-10 Thread Andrew Cooper
On 10/08/2021 18:47, Kevin Stefanov wrote: > Whilst fixing this, also changed bool_t to bool. > > Suggested-by: Andrew Cooper > Signed-off-by: Kevin Stefanov > --- > CC: Andrew Cooper In terms of kexec maintainership, Acked-by: Andrew Cooper , but it really ought to have some other ack/review.

[xen-unstable test] 164149: tolerable FAIL - PUSHED

2021-08-10 Thread osstest service owner
flight 164149 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/164149/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds18 guest-start/debian.repeat fail REGR. vs. 164145 Tests which did not succeed

[linux-linus test] 164150: regressions - FAIL

2021-08-10 Thread osstest service owner
flight 164150 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164150/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

[ovmf test] 164151: all pass - PUSHED

2021-08-10 Thread osstest service owner
flight 164151 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164151/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a7ddc7847cb4afa3534da8f296aafadb959d baseline version: ovmf d02dbb53cd78de799e6af

[qemu-mainline test] 164152: tolerable FAIL - PUSHED

2021-08-10 Thread osstest service owner
flight 164152 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/164152/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 164134 Tests which did not succee

Re: [PATCH 1/2] xen/kexec: Remove use of TRUE/FALSE

2021-08-10 Thread Jan Beulich
On 10.08.2021 19:47, Kevin Stefanov wrote: > --- a/xen/common/kexec.c > +++ b/xen/common/kexec.c > @@ -35,7 +35,7 @@ > #include > #endif > > -bool_t kexecing = FALSE; > +bool kexecing; While not overly important for either of the two present readers, I nevertheless wonder whether at this occa

Re: [PATCH 2/2] x86/ioapic: Remove use of TRUE/FALSE

2021-08-10 Thread Jan Beulich
On 10.08.2021 19:49, Kevin Stefanov wrote: > Also fix stray usage in VT-d. > > Suggested-by: Andrew Cooper > Signed-off-by: Kevin Stefanov May I ask that along with replacing TRUE (there's no instance of FALSE that you replace, so you may want to adjust the title) you also replace the uses of l

Re: Enabling hypervisor agnosticism for VirtIO backends

2021-08-10 Thread AKASHI Takahiro
On Wed, Aug 04, 2021 at 12:20:01PM -0700, Stefano Stabellini wrote: > CCing people working on Xen+VirtIO and IOREQs. Not trimming the original > email to let them read the full context. > > My comments below are related to a potential Xen implementation, not > because it is the only implementation

[linux-linus test] 164153: regressions - FAIL

2021-08-10 Thread osstest service owner
flight 164153 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164153/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-