RE: [PATCH V3 08/10] xen/arm: introduce acquire_staticmem_pages and acquire_domstatic_pages

2021-07-21 Thread Penny Zheng
Hi Jan > -Original Message- > From: Jan Beulich > Sent: Monday, July 19, 2021 5:26 PM > To: Penny Zheng > Cc: Bertrand Marquis ; Wei Chen > ; nd ; xen-devel@lists.xenproject.org; > sstabell...@kernel.org; jul...@xen.org > Subject: Re: [PATCH V3 08/10] xen/arm: introduce acquire_staticmem

[linux-linus test] 163856: regressions - FAIL

2021-07-21 Thread osstest service owner
flight 163856 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163856/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qem

RE: [PATCH V3 08/10] xen/arm: introduce acquire_staticmem_pages and acquire_domstatic_pages

2021-07-21 Thread Penny Zheng
Hi Julien > -Original Message- > From: Julien Grall > Sent: Monday, July 19, 2021 6:00 PM > To: Jan Beulich ; Penny Zheng > Cc: Bertrand Marquis ; Wei Chen > ; nd ; xen-devel@lists.xenproject.org; > sstabell...@kernel.org > Subject: Re: [PATCH V3 08/10] xen/arm: introduce acquire_static

Re: 5.10.40 dom0 kernel - nvme: Invalid SGL for payload:131072 nents:13

2021-07-21 Thread Jan Beulich
On 21.07.2021 00:32, Andy Smith wrote: > I have a Debian 10 (buster/stable) dom0 running hypervisor 4.14.2. > For almost 2 years it's been using the packaged Debian stable kernel > which is 4.19.x. > > Last night I upgraded the kernel to the buster-backports package > which is based on 5.10.40 and

Re: [PATCH V3 05/10] xen/arm: static memory initialization

2021-07-21 Thread Jan Beulich
On 21.07.2021 05:07, Penny Zheng wrote: >> -Original Message- >> From: Jan Beulich >> Sent: Monday, July 19, 2021 4:20 PM >> To: Penny Zheng >> Cc: Bertrand Marquis ; Wei Chen >> ; nd ; xen-devel@lists.xenproject.org; >> sstabell...@kernel.org; jul...@xen.org >> Subject: Re: [PATCH V3 05/

[libvirt test] 163862: regressions - FAIL

2021-07-21 Thread osstest service owner
flight 163862 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/163862/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-armhf-libvirt

Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg

2021-07-21 Thread Julien Grall
Hi Scott, On 20/07/2021 18:56, Scott Davis wrote: This adds an option to the xl domain configuration file syntax for specifying a kernel command line for device-model stubdomains. It is intended for use with Linux-based stubdomains. May I ask why embedding the command line in the kernel would

Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg

2021-07-21 Thread Juergen Gross
On 21.07.21 10:21, Julien Grall wrote: Hi Scott, On 20/07/2021 18:56, Scott Davis wrote: This adds an option to the xl domain configuration file syntax for specifying a kernel command line for device-model stubdomains. It is intended for use with Linux-based stubdomains. May I ask why embed

Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg

2021-07-21 Thread Andrew Cooper
On 21/07/2021 09:21, Julien Grall wrote: > Hi Scott, > > On 20/07/2021 18:56, Scott Davis wrote: >> This adds an option to the xl domain configuration file syntax for >> specifying >> a kernel command line for device-model stubdomains. It is intended >> for use with >> Linux-based stubdomains. > >

Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg

2021-07-21 Thread Julien Grall
Hi, On 21/07/2021 10:06, Andrew Cooper wrote: On 21/07/2021 09:21, Julien Grall wrote: Hi Scott, On 20/07/2021 18:56, Scott Davis wrote: This adds an option to the xl domain configuration file syntax for specifying a kernel command line for device-model stubdomains. It is intended for use wit

xen 4.11.4 incorrect (~3x) cpu frequency reported

2021-07-21 Thread James Dingwall
Hi, We have a system which intermittently starts up and reports an incorrect cpu frequency: # grep -i mhz /var/log/kern.log Jul 14 17:47:47 dom0 kernel: [0.000475] tsc: Detected 2194.846 MHz processor Jul 14 22:03:37 dom0 kernel: [0.000476] tsc: Detected 2194.878 MHz processor Jul 14 23

[xen-unstable-coverity test] 163870: all pass - PUSHED

2021-07-21 Thread osstest service owner
flight 163870 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/163870/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 57e761b60dc92e210caf3429b8956d908ba04ae9 baseline version: xen 3a98

Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg

2021-07-21 Thread Ian Jackson
Julien Grall writes ("Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg"): > Everyone has a different perspective. I don't see the problem of asking > the question... Maybe I should have add "OOI" to make clear with wasn't > a complain. Yes, I think asking questions is fine, but we

Re: [PATCH v4 0/5] bus: Make remove callback return void

2021-07-21 Thread Greg Kroah-Hartman
On Tue, Jul 13, 2021 at 09:35:17PM +0200, Uwe Kleine-König wrote: > Hello, > > this is v4 of the final patch set for my effort to make struct > bus_type::remove return void. > > The first four patches contain cleanups that make some of these > callbacks (more obviously) always return 0. They are

Re: [Resend RFC PATCH V4 09/13] x86/Swiotlb/HV: Add Swiotlb bounce buffer remap function for HV IVM

2021-07-21 Thread Tianyu Lan
Thanks for review. On 7/20/2021 9:54 PM, Christoph Hellwig wrote: Please split the swiotlb changes into a separate patch from the consumer. OK. Will update. } + +/* + * hv_map_memory - map memory to extra space in the AMD SEV-SNP Isolation VM. + */ +unsigned long hv_map_memory(unsigned

Re: xen 4.11.4 incorrect (~3x) cpu frequency reported

2021-07-21 Thread Jan Beulich
On 21.07.2021 11:29, James Dingwall wrote: > We have a system which intermittently starts up and reports an incorrect cpu > frequency: > > # grep -i mhz /var/log/kern.log > Jul 14 17:47:47 dom0 kernel: [0.000475] tsc: Detected 2194.846 MHz > processor > Jul 14 22:03:37 dom0 kernel: [0.0

[PATCH] xen/events: remove redundant initialization of variable irq

2021-07-21 Thread Colin King
From: Colin Ian King The variable irq is being initialized with a value that is never read, it is being updated later on. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/xen/events/events_base.c | 2 +- 1 file chang

Re: [PATCH V8 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks

2021-07-21 Thread Like Xu
On 16/7/2021 4:53 pm, Zhu Lingshan wrote: + } else if (xenpmu_data->pmu.r.regs.cpl & 3) Lingshan, serious for this version ? arch/x86/xen/pmu.c:438:9: error: expected identifier or ‘(’ before ‘return’ 438 | return state; | ^~ arch/x86/xen/pmu.c:439:1: error: e

Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg

2021-07-21 Thread Jason Andryuk
On Tue, Jul 20, 2021 at 1:57 PM Scott Davis wrote: > > This adds an option to the xl domain configuration file syntax for specifying > a kernel command line for device-model stubdomains. It is intended for use > with > Linux-based stubdomains. > > Signed-off-by: Scott Davis > --- > docs/man/xl.

[ovmf test] 163864: regressions - FAIL

2021-07-21 Thread osstest service owner
flight 163864 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163864/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu

Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg

2021-07-21 Thread Ian Jackson
Jason Andryuk writes ("Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg"): > I think this option actually sets the string, so you want "Set > B as the device-model stubdomain kernel command line." or > something equivalent? > > With a suitable change, > Reviewed-by: Jason Andryuk D

[qemu-mainline bisection] complete test-amd64-i386-xl-qemuu-debianhvm-amd64

2021-07-21 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-qemuu-debianhvm-amd64 testid debian-hvm-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git:

Re: Dom0 hangs after enable KROBE_EVENTS and/or UPROBE_EVENTS in kernel config

2021-07-21 Thread Julien Grall
(+ Stefano) On 21/07/2021 12:44, Oleksii Moisieiev wrote: Hello, Hi, Thanks for the report. I nearly miss this e-mail because the title doesn't suggest this is an Arm and I wasn't CCed. In future, would you be able to CC the Arm maintainers (you can find them in MAINTAINERS) and mention ar

Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg

2021-07-21 Thread Jason Andryuk
On Wed, Jul 21, 2021 at 8:50 AM Ian Jackson wrote: > > Jason Andryuk writes ("Re: [PATCH] tools/xl: Add stubdomain_cmdline option to > xl.cfg"): > > I think this option actually sets the string, so you want "Set > > B as the device-model stubdomain kernel command line." or > > something equivalen

Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg

2021-07-21 Thread Ian Jackson
Jason Andryuk writes ("Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg"): > Yes, they can both be useful. Append is sufficient until you want to > override or remove an option that is already included. Set can be > tedious since you have to copy the existing options before appendin

Xen DomUs with empty state

2021-07-21 Thread Neil Sikka
Hello, I am running xen 4.13.0 hosting many DomUs started in a short amount of time, but not all of them are accounted for by xentop: 183 domains: 2 running, 0 blocked, 92 paused, 0 crashed, 0 dying, 0 shutdown Only 94 of the 183 VMs are accounted for, and the STATE column for many of the VMs s

Re: 5.10.40 dom0 kernel - nvme: Invalid SGL for payload:131072 nents:13

2021-07-21 Thread Andy Smith
Hi Jan, On Wed, Jul 21, 2021 at 10:10:13AM +0200, Jan Beulich wrote: > Since xen-blkback only talks in terms of bio-s, I don't think it is > the party responsible for honoring such driver restrictions. Instead > I'd expect the block layer's bio merging to be where this needs to be > observed. Perh

[xen-unstable test] 163859: tolerable FAIL - PUSHED

2021-07-21 Thread osstest service owner
flight 163859 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/163859/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 163832 test-amd64-amd64-qemuu-nested-amd 20

Re: [Resend RFC PATCH V4 09/13] x86/Swiotlb/HV: Add Swiotlb bounce buffer remap function for HV IVM

2021-07-21 Thread Christoph Hellwig
On Wed, Jul 21, 2021 at 06:28:48PM +0800, Tianyu Lan wrote: > dma_mmap_attrs() and dma_get_sgtable_attrs() get input virtual address > belonging to backing memory with struct page and returns bounce buffer > dma physical address which is below shared_gpa_boundary(vTOM) and passed > to Hyper-V via v

Re:[arm] Dom0 hangs after enable KROBE_EVENTS and/or UPROBE_EVENTS in kernel config

2021-07-21 Thread Oleksii Moisieiev
Hello Julien, Thank you for the quick response. Please answers below. From: Julien Grall Sent: Wednesday, July 21, 2021 4:09 PM To: Oleksii Moisieiev ; xen-devel@lists.xenproject.org Cc: Andrii Anisov ; Stefano Stabellini Subject: Re: Dom0 hangs after enable

Re: [PATCH RESEND 2/2] gitlab-ci: add an ARM32 qemu-based smoke test

2021-07-21 Thread Julien Grall
Hi Stefano, On 14/07/2021 01:48, Stefano Stabellini wrote: Add a minimal ARM32 smoke test based on qemu-system-arm, as provided by the test-artifacts qemu container. The minimal test simply boots Xen (built from previous build stages) and Dom0. The test is fetching the Dom0 kernel and initrd fro

Re: 5.10.40 dom0 kernel - nvme: Invalid SGL for payload:131072 nents:13

2021-07-21 Thread Jan Beulich
On 21.07.2021 16:19, Andy Smith wrote: > On Wed, Jul 21, 2021 at 10:10:13AM +0200, Jan Beulich wrote: >> Since xen-blkback only talks in terms of bio-s, I don't think it is >> the party responsible for honoring such driver restrictions. Instead >> I'd expect the block layer's bio merging to be wher

Re: [PATCH RESEND 0/2] gitlab-ci: add a qemu-based arm32 test

2021-07-21 Thread Julien Grall
Hi Stefano, On 20/07/2021 20:48, Stefano Stabellini wrote: Re-ping? Interestingly the patches were not threaded (in-reply-to seems to be missing in the headers), so I had to look them up by subject to find them. Anyway, I have looked at patch #2 and provided some feebdack. The first patch

Re: [Resend RFC PATCH V4 09/13] x86/Swiotlb/HV: Add Swiotlb bounce buffer remap function for HV IVM

2021-07-21 Thread Tianyu Lan
On 7/21/2021 10:33 PM, Christoph Hellwig wrote: On Wed, Jul 21, 2021 at 06:28:48PM +0800, Tianyu Lan wrote: dma_mmap_attrs() and dma_get_sgtable_attrs() get input virtual address belonging to backing memory with struct page and returns bounce buffer dma physical address which is below shared_

Re: [PATCH] xen/events: remove redundant initialization of variable irq

2021-07-21 Thread Juergen Gross
On 21.07.21 13:40, Colin King wrote: From: Colin Ian King The variable irq is being initialized with a value that is never read, it is being updated later on. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King Reviewed-by: Juer

your change "iommu: make map and unmap take a page count, similar to flush"

2021-07-21 Thread Jan Beulich
Paul, the description of this says "At the moment iommu_map() and iommu_unmap() take a page order rather than a count, whereas iommu_iotlb_flush() takes a page count rather than an order. This patch makes them consistent with each other, opting for a page count since CPU page orders are not ne

Re: [arm] Dom0 hangs after enable KROBE_EVENTS and/or UPROBE_EVENTS in kernel config

2021-07-21 Thread Julien Grall
On 21/07/2021 15:40, Oleksii Moisieiev wrote: Hello Julien, Hello, My setup: Board: H3ULCB Kinfisher board Xen: revision dba774896f7dd74773c14d537643b7d7477fefcd (stable-4.15) https://urldefense.com/v3/__https://github.com/xen-project/xen.git__;!!GF_29dbcQIUBPA!m4NHC2XbbSHWWZjQ7CX1ZZhaET6

Re: your change "iommu: make map and unmap take a page count, similar to flush"

2021-07-21 Thread Paul Durrant
On 21/07/2021 16:58, Jan Beulich wrote: Paul, the description of this says "At the moment iommu_map() and iommu_unmap() take a page order rather than a count, whereas iommu_iotlb_flush() takes a page count rather than an order. This patch makes them consistent with each other, opting for a

[qemu-mainline test] 163865: regressions - FAIL

2021-07-21 Thread osstest service owner
flight 163865 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/163865/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 163321

[ovmf test] 163875: regressions - FAIL

2021-07-21 Thread osstest service owner
flight 163875 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163875/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu

Re: [arm] Dom0 hangs after enable KROBE_EVENTS and/or UPROBE_EVENTS in kernel config

2021-07-21 Thread Oleksii Moisieiev
Please see my answers below. From: Julien Grall Sent: Wednesday, July 21, 2021 7:39 PM To: Oleksii Moisieiev ; xen-devel@lists.xenproject.org Cc: Andrii Anisov ; Stefano Stabellini Subject: Re: [arm] Dom0 hangs after enable KROBE_EVENTS and/or UPROBE_EVENTS in

Re: [PATCH v2] dma-mapping: use vmalloc_to_page for vmalloc addresses

2021-07-21 Thread Roman Skakun
> Fine with. I've queued up the modified patch. Good. Thanks! > > On Sat, Jul 17, 2021 at 11:39:21AM +0300, Roman Skakun wrote: > > > We can merge this patch and create a new one for > > > xen_swiotlb_free_coherent() later. > > > Yeah, no worries, I didn't know that exposing dma_common_vaddr_to_

[linux-linus test] 163868: regressions - FAIL

2021-07-21 Thread osstest service owner
flight 163868 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163868/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

Re: [PATCH] xen/events: remove redundant initialization of variable irq

2021-07-21 Thread Boris Ostrovsky
On 7/21/21 11:36 AM, Juergen Gross wrote: > On 21.07.21 13:40, Colin King wrote: >> From: Colin Ian King >> >> The variable irq is being initialized with a value that is never >> read, it is being updated later on. The assignment is redundant and >> can be removed. >> >> Addresses-Coverity: ("Un

Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg

2021-07-21 Thread Scott Davis
Thanks for the feedback, all. On 7/21/21, 4:21 AM, Julien Grall wrote: > May I ask why embedding the command line in the kernel would not be a > solution? Do you expect it to change from stubdom to stubdom? Of course. For Crucible, we're using a common kernel and initramfs for stubdomains and dr

[xen-unstable test] 163877: tolerable FAIL

2021-07-21 Thread osstest service owner
flight 163877 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/163877/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 163859 Tests which did not succeed, but

Re: [arm] Dom0 hangs after enable KROBE_EVENTS and/or UPROBE_EVENTS in kernel config

2021-07-21 Thread Stefano Stabellini
On Wed, 21 Jul 2021, Oleksii Moisieiev wrote: > Please see my answers below. > > ___ > From: Julien Grall > Sent: Wednesday, July 21, 2021 7:39 PM > To: Oleksii

[ovmf test] 163882: regressions - FAIL

2021-07-21 Thread osstest service owner
flight 163882 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163882/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu

[qemu-mainline test] 163880: regressions - FAIL

2021-07-21 Thread osstest service owner
flight 163880 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/163880/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 163321

Re: [PATCH V8 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks

2021-07-21 Thread Zhu, Lingshan
On 7/21/2021 7:57 PM, Like Xu wrote: On 16/7/2021 4:53 pm, Zhu Lingshan wrote: +    } else if (xenpmu_data->pmu.r.regs.cpl & 3) oh, my typo, will fix in V9 Thanks Lingshan, serious for this version ? arch/x86/xen/pmu.c:438:9: error: expected identifier or ‘(’ before ‘return’   438 |   

Re: [PATCH V8 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks

2021-07-21 Thread Zhu, Lingshan
On 7/21/2021 7:57 PM, Like Xu wrote: On 16/7/2021 4:53 pm, Zhu Lingshan wrote: +    } else if (xenpmu_data->pmu.r.regs.cpl & 3) Lingshan, serious for this version ? arch/x86/xen/pmu.c:438:9: error: expected identifier or ‘(’ before ‘return’   438 | return state;   | ^

[PATCH V9 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks

2021-07-21 Thread Zhu Lingshan
From: Like Xu For "struct perf_guest_info_callbacks", the two fields "is_in_guest" and "is_user_mode" are replaced with a new multiplexed member named "state", and the "get_guest_ip" field will be renamed to "get_ip". For arm64, xen and kvm/x86, the application of DEFINE_STATIC_CALL_RET0 could m

[linux-linus test] 163884: regressions - FAIL

2021-07-21 Thread osstest service owner
flight 163884 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163884/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-