[libvirt test] 160740: regressions - FAIL

flight 160740 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160740/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

[xen-unstable test] 160733: regressions - FAIL

flight 160733 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160733/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken in 160665 test-armhf-armhf-libvirt-raw

[qemu-mainline test] 160736: regressions - FAIL

flight 160736 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160736/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i3

Re: [PATCH v3 0/3] Generic SMMU Bindings

On 26/01/2021 22:58, Stefano Stabellini wrote: Hi all, Hi Stefano, This series introduces support for the generic SMMU bindings to xen/drivers/passthrough/arm/smmu.c. The last version of the series was https://marc.info/?l=xen-devel&m=159539053406643 Some changes in the SMMU drivers went in

[PATCH 02/14] xen/sched: Constify name and opt_name in struct scheduler

From: Julien Grall Both name and opt_name are pointing to literal string. So mark both of the fields as const. Signed-off-by: Julien Grall --- xen/common/sched/private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/sched/private.h b/xen/common/sched/privat

[PATCH 01/14] xen: Constify the second parameter of rangeset_new()

From: Julien Grall The string 'name' will never get modified by the function, so mark it as const. Signed-off-by: Julien Grall --- xen/common/rangeset.c | 2 +- xen/include/xen/rangeset.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/rangeset.c b/xen/co

[PATCH 05/14] tools/libs: guest: Use const whenever we point to literal strings

From: Julien Grall literal strings are not meant to be modified. So we should use const *char rather than char * when we want to store a pointer to them. Signed-off-by: Julien Grall --- tools/include/xenguest.h| 10 +- tools/libs/guest/xg_dom_core.c | 8 tool

[PATCH 06/14] tools/libs: stat: Use const whenever we point to literal strings

From: Julien Grall literal strings are not meant to be modified. So we should use const char * rather than char * when we want to store a pointer to them. Signed-off-by: Julien Grall --- tools/libs/stat/xenstat_linux.c | 4 ++-- tools/libs/stat/xenstat_qmp.c | 12 ++-- 2 files chang

[PATCH 03/14] xen/x86: shadow: The return type of sh_audit_flags() should be const

From: Julien Grall The function sh_audit_flags() is returning pointer to literal strings. They should not be modified, so the return is now const and this is propagated to the callers. Take the opportunity to fix the coding style in the declaration of sh_audit_flags. Signed-off-by: Julien Grall

[PATCH 04/14] xen/char: console: Use const whenever we point to literal strings

From: Julien Grall literal strings are not meant to be modified. So we should use const char * rather than char * when we want to store a pointer to them. Signed-off-by: Julien Grall --- xen/drivers/char/console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/driv

[PATCH 07/14] tools/xl: Use const whenever we point to literal strings

From: Julien Grall literal strings are not meant to be modified. So we should use const char * rather than char * when we want to store a pointer to them. Signed-off-by: Julien Grall --- tools/xl/xl.h | 8 tools/xl/xl_console.c | 2 +- tools/xl/xl_utils.c | 4 ++-- tools/xl/

[PATCH 00/14] Use const whether we point to literal strings (take 1)

From: Julien Grall Hi all, By default, both Clang and GCC will happily compile C code where non-const char * point to literal strings. This means the following code will be accepted: char *str = "test"; str[0] = 'a'; Literal strings will reside in rodata, so they are not modifiable. T

[PATCH 08/14] tools/firmware: hvmloader: Use const in __bug() and __assert_failed()

From: Julien Grall __bug() and __assert_failed() are not meant to modify the string parameters. So mark them as const. Signed-off-by: Julien Grall --- tools/firmware/hvmloader/util.c | 4 ++-- tools/firmware/hvmloader/util.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --gi

[PATCH 09/14] tools/console: Use const whenever we point to literal strings

From: Julien Grall literal strings are not meant to be modified. So we should use const char * rather than char * when we want to store a pointer to them. Signed-off-by: Julien Grall --- tools/console/client/main.c | 4 ++-- tools/console/daemon/io.c | 10 +- 2 files changed, 7 inse

[PATCH 10/14] tools/kdd: Use const whenever we point to literal strings

From: Julien Grall literal strings are not meant to be modified. So we should use const char * rather than char * when we want to shore a pointer to them. Signed-off-by: Julien Grall --- tools/debugger/kdd/kdd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/too

[PATCH 11/14] tools/misc: Use const whenever we point to literal strings

From: Julien Grall literal strings are not meant to be modified. So we should use const char * rather than char * when we we to store a pointer to them. Signed-off-by: Julien Grall --- tools/misc/xen-detect.c | 2 +- tools/misc/xenhypfs.c | 6 +++--- 2 files changed, 4 insertions(+), 4 delet

[PATCH 12/14] tools/top: The string parameter in set_prompt() and set_delay() should be const

From: Julien Grall Neither string parameter in set_prompt() and set_delay() are meant to be modified. In particular, new_prompt can point to a literal string. So mark the two parameters as const and propagate it. Signed-off-by: Julien Grall --- tools/xentop/xentop.c | 12 ++-- 1 file

[PATCH 14/14] tools/xentrace: Use const whenever we point to literal strings

From: Julien Grall literal strings are not meant to be modified. So we should use const char * rather than char * when we want to store a pointer to them. Signed-off-by: Julien Grall --- tools/xentrace/xenalyze.c | 71 --- tools/xentrace/xenctx.c | 4 +--

[PATCH 13/14] tools/xenmon: xenbaked: Mark const the field text in stat_map_t

From: Julien Grall The field text in stat_map_t will point to string literals. So mark it as const to allow the compiler to catch any modified of the string. Signed-off-by: Julien Grall --- tools/xenmon/xenbaked.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenmon

[PATCH] xen/arm: guest_walk: Only generate necessary offsets/masks

From: Julien Grall At the moment, we are computing offsets/masks for each level and granularity. This is a bit of waste given that we only need to know the offsets/masks for the granularity used by the guest. All the LPAE information can easily be inferred with just the page shift for a given gr

Re: [PATCH 00/14] Use const whether we point to literal strings (take 1)

On Mon, Apr 05, 2021 at 04:56:59PM +0100, Julien Grall wrote: > I am not aware of code trying to modify literal strings in Xen. > However, there is a frequent use of non-const char * to point to > literal strings. Given the size of the codebase, there is a risk > to involuntarily introduce code tha

[xen-4.12-testing test] 160738: regressions - FAIL

flight 160738 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160738/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken in 160709 build-armhf

[linux-linus test] 160742: regressions - FAIL

flight 160742 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160742/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

[xen-unstable test] 160745: regressions - FAIL

flight 160745 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160745/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken in 160665 test-armhf-armhf-xl

[qemu-mainline test] 160748: regressions - FAIL

flight 160748 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160748/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i3