[PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface

2021-03-24 Thread Juergen Gross
There are some internals in the libxenstore interface which should be removed. Move those functions into xs_lib.c and the related definitions into xs_lib.h. Remove the functions from the mapfile. Add xs_lib.o to xenstore_client as some of the internal functions are needed there. Signed-off-by: Ju

Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document

2021-03-24 Thread Roger Pau Monné
On Tue, Mar 23, 2021 at 10:39:53AM -0700, Christopher Clark wrote: > On Thu, Mar 18, 2021 at 9:43 AM Roger Pau Monné wrote: > > > > Just took a quick look at it. > > > > On Mon, Mar 15, 2021 at 11:18:13PM -0400, Daniel P. Smith wrote: > > > + > > > +---+---++--

[xen-unstable-coverity test] 160385: all pass - PUSHED

2021-03-24 Thread osstest service owner
flight 160385 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/160385/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen b9b3082002cac68726fb303e0abd2ff0113d4657 baseline version: xen 1b47

[PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally

2021-03-24 Thread Jan Beulich
Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating") was reported to cause boot failures on certain AMD Ryzen systems. Until we can figure out what the actual issue there is, skip this new part of HPET setup by default. Introduce a "hpet" command line o

Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10

2021-03-24 Thread Luca Fancellu
> On 23 Mar 2021, at 19:26, Julien Grall wrote: > > > > On 23/03/2021 17:06, Luca Fancellu wrote: >> Hi all, > > Hi, > > Please avoid top posting when answering to a comment. This makes more > difficult to follow. > >> I have an update, changing the lock introduced by the serie from spin

Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally

2021-03-24 Thread Ian Jackson
Jan Beulich writes ("[PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally"): > Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC > static PIT clock gating") was reported to cause boot failures on certain > AMD Ryzen systems. Until we can figure out wh

[PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface

2021-03-24 Thread Ian Jackson
Juergen Gross writes ("[PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface"): > There are some internals in the libxenstore interface which should be > removed. > > Move those functions into xs_lib.c and the related definitions into > xs_lib.h. Remove the functions from the mapfile.

Re: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface

2021-03-24 Thread Jürgen Groß
On 24.03.21 12:02, Ian Jackson wrote: Juergen Gross writes ("[PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface"): There are some internals in the libxenstore interface which should be removed. Move those functions into xs_lib.c and the related definitions into xs_lib.h. Remove t

Re: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface

2021-03-24 Thread Ian Jackson
Jürgen Groß writes ("Re: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface"): > On 24.03.21 12:02, Ian Jackson wrote: > > Is it possible to do sort this out in a more minimal way ? Eg we > > could change the name to namespace it properly. (I haven't looked at > > the code in detai

[PATCH-for-4.15 V2] tools/libs/store: tidy up libxenstore interface

2021-03-24 Thread Juergen Gross
xenstore_lib.h is in need to be tidied up a little bit: - the definition of struct xs_tdb_record_hdr shouldn't be here - some symbols are not namespaced correctly Signed-off-by: Juergen Gross --- V2: minimal variant (Ian Jackson) --- tools/include/xenstore_lib.h | 17 - tool

Re: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface

2021-03-24 Thread Jürgen Groß
On 24.03.21 12:30, Ian Jackson wrote: Jürgen Groß writes ("Re: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface"): On 24.03.21 12:02, Ian Jackson wrote: Is it possible to do sort this out in a more minimal way ? Eg we could change the name to namespace it properly. (I haven't

Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally

2021-03-24 Thread Tamas K Lengyel
On Wed, Mar 24, 2021 at 6:34 AM Jan Beulich wrote: > > Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC > static PIT clock gating") was reported to cause boot failures on certain > AMD Ryzen systems. Until we can figure out what the actual issue there > is, skip this new pa

Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking

2021-03-24 Thread Tamas K Lengyel
> > When creating a VM fork copy the parent VM's hostp2m max_mapped_pfn value. > > Some > > toolstack relies on the XENMEM_maximum_gpfn value to establish the maximum > > addressable physical memory in the VM and for forks that have not yet been > > unpaused that value is not going to reflect the

Re: [PATCH-for-4.15 V2] tools/libs/store: tidy up libxenstore interface

2021-03-24 Thread Andrew Cooper
On 24/03/2021 11:30, Juergen Gross wrote: > xenstore_lib.h is in need to be tidied up a little bit: > > - the definition of struct xs_tdb_record_hdr shouldn't be here > - some symbols are not namespaced correctly > > Signed-off-by: Juergen Gross > --- > V2: minimal variant (Ian Jackson) > --- > t

Re: [ANNOUNCE] Xen 4.15 - release status, branching tomorrow

2021-03-24 Thread Tamas K Lengyel
> The revert seems unattractive. Your suggested command line option > sounds like a good workaround to me. Under the circumstances it seems > like it should default to the old behaviour, as I think you are > suggesting. > > So I am be inclined to ask if you, Jan, would prepare a patch > implement

Re: [PATCH-for-4.15 V2] tools/libs/store: tidy up libxenstore interface

2021-03-24 Thread Jürgen Groß
On 24.03.21 12:42, Andrew Cooper wrote: On 24/03/2021 11:30, Juergen Gross wrote: xenstore_lib.h is in need to be tidied up a little bit: - the definition of struct xs_tdb_record_hdr shouldn't be here - some symbols are not namespaced correctly Signed-off-by: Juergen Gross --- V2: minimal var

Re: [ANNOUNCE] Xen 4.15 - release status, branching tomorrow

2021-03-24 Thread Andrew Cooper
On 24/03/2021 11:48, Tamas K Lengyel wrote: >> The revert seems unattractive. Your suggested command line option >> sounds like a good workaround to me. Under the circumstances it seems >> like it should default to the old behaviour, as I think you are >> suggesting. >> >> So I am be inclined to

[PATCH] intel/pinctrl: check capability offset is between MMIO region

2021-03-24 Thread Roger Pau Monne
When parsing the capability list make sure the offset is between the MMIO region mapped in 'regs', or else the kernel hits a page fault. This fault has been seen when running as a Xen PVH dom0, which doesn't have the MMIO regions mapped into the domain physical memory map, despite having the devic

[PATCH v2 2/2] Revert "xen: fix p2m size in dom0 for disabled memory hotplug case"

2021-03-24 Thread Roger Pau Monne
This partially reverts commit 882213990d32fd224340a4533f6318dd152be4b2. There's no need to special case XEN_UNPOPULATED_ALLOC anymore in order to correctly size the p2m. The generic memory hotplug option has already been tied together with the Xen hotplug limit, so enabling memory hotplug should a

[PATCH v2 0/2] xen/x86: alternative fix for XSA-369

2021-03-24 Thread Roger Pau Monne
Hello, This is a proposal for an alternative fix for XSA-369 that instead of special casing XEN_UNPOPULATED_ALLOC to size the p2m relies on making XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on the generic MEMORY_HOTPLUG option rather than XEN_BALLOON_MEMORY_HOTPLUG. I think this is safer, as we don'

[PATCH v2 1/2] xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on MEMORY_HOTPLUG

2021-03-24 Thread Roger Pau Monne
The Xen memory hotplug limit should depend on the memory hotplug generic option, rather than the Xen balloon configuration. It's possible to have a kernel with generic memory hotplug enabled, but without Xen balloon enabled, at which point memory hotplug won't work correctly due to the size limitat

[PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region

2021-03-24 Thread Roger Pau Monne
When parsing the capability list make sure the offset is between the MMIO region mapped in 'regs', or else the kernel hits a page fault. This fault has been seen when running as a Xen PVH dom0, which doesn't have the MMIO regions mapped into the domain physical memory map, despite having the devic

[PATCH-for-4.15 v3] tools/libs/store: tidy up libxenstore interface

2021-03-24 Thread Juergen Gross
xenstore_lib.h is in need to be tidied up a little bit: - the definition of struct xs_tdb_record_hdr shouldn't be here - some symbols are not namespaced correctly - the layout of a structure with an enum inside it depends on the implementation of the compiler Signed-off-by: Juergen Gross --- V

Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document

2021-03-24 Thread Christopher Clark
On Wed, Mar 24, 2021 at 1:01 AM Roger Pau Monné wrote: > > On Tue, Mar 23, 2021 at 10:39:53AM -0700, Christopher Clark wrote: > > On Thu, Mar 18, 2021 at 9:43 AM Roger Pau Monné > > wrote: > > > > > > Just took a quick look at it. > > > > > > On Mon, Mar 15, 2021 at 11:18:13PM -0400, Daniel P. S

Re: [PATCH v8] arm: Add Kconfig entry to select CONFIG_DTB_FILE

2021-03-24 Thread Bertrand Marquis
Hi Michal, > On 22 Mar 2021, at 08:17, Michal Orzel wrote: > > Currently in order to link existing DTB into Xen image > we need to either specify option CONFIG_DTB_FILE on the > command line or manually add it into .config. > Add Kconfig entry: CONFIG_DTB_FILE > to be able to provide the path to

Re: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region

2021-03-24 Thread Andy Shevchenko
On Wed, Mar 24, 2021 at 01:31:18PM +0100, Roger Pau Monne wrote: > When parsing the capability list make sure the offset is between the > MMIO region mapped in 'regs', or else the kernel hits a page fault. > > This fault has been seen when running as a Xen PVH dom0, which doesn't > have the MMIO r

Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document

2021-03-24 Thread George Dunlap
> On Mar 24, 2021, at 12:53 PM, Christopher Clark > wrote: > > Do you know if there is a need to perform work to support the > assignment of PCI devices at the point of domain creation (ie. in > domain_create), rather than handling it in a later step of domain > configuration, prior to the dom

Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally

2021-03-24 Thread Jan Beulich
On 24.03.2021 12:37, Tamas K Lengyel wrote: > On Wed, Mar 24, 2021 at 6:34 AM Jan Beulich wrote: >> >> Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC >> static PIT clock gating") was reported to cause boot failures on certain >> AMD Ryzen systems. Until we can figure out

Re: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region

2021-03-24 Thread Roger Pau Monné
On Wed, Mar 24, 2021 at 02:58:07PM +0200, Andy Shevchenko wrote: > On Wed, Mar 24, 2021 at 01:31:18PM +0100, Roger Pau Monne wrote: > > When parsing the capability list make sure the offset is between the > > MMIO region mapped in 'regs', or else the kernel hits a page fault. > > > > This fault ha

Re: [PATCH-for-4.15 V2] tools/libs/store: tidy up libxenstore interface

2021-03-24 Thread Julien Grall
Hi Juergen, On 24/03/2021 11:30, Juergen Gross wrote: xenstore_lib.h is in need to be tidied up a little bit: - the definition of struct xs_tdb_record_hdr shouldn't be here - some symbols are not namespaced correctly Signed-off-by: Juergen Gross --- V2: minimal variant (Ian Jackson) --- too

[PATCH] ARM: xen/mm.c: A mundane typo fix

2021-03-24 Thread Bhaskar Chowdhury
s/acrros/across/ Signed-off-by: Bhaskar Chowdhury --- arch/arm/xen/mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c index 467fa225c3d0..be7c942c74bf 100644 --- a/arch/arm/xen/mm.c +++ b/arch/arm/xen/mm.c @@ -105,7 +105,7 @@ bool xen_a

Re: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region

2021-03-24 Thread Andy Shevchenko
On Wed, Mar 24, 2021 at 02:55:15PM +0100, Roger Pau Monné wrote: > On Wed, Mar 24, 2021 at 02:58:07PM +0200, Andy Shevchenko wrote: > > On Wed, Mar 24, 2021 at 01:31:18PM +0100, Roger Pau Monne wrote: ... > What could be done is check whether reading REVID returns ~0 and exit > at that point, if

[qemu-mainline test] 160361: regressions - FAIL

2021-03-24 Thread osstest service owner
flight 160361 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160361/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i3

Re: [PATCH-for-4.15 V2] tools/libs/store: tidy up libxenstore interface

2021-03-24 Thread Jürgen Groß
On 24.03.21 15:09, Julien Grall wrote: Hi Juergen, On 24/03/2021 11:30, Juergen Gross wrote: xenstore_lib.h is in need to be tidied up a little bit: - the definition of struct xs_tdb_record_hdr shouldn't be here - some symbols are not namespaced correctly Signed-off-by: Juergen Gross --- V2:

Commit moratorium for branching

2021-03-24 Thread Ian Jackson
Please do not push any commits to xen.git#staging, corresponding qemu branches, etc. I'm going to make the 4.15 branch etc. I will let you know when I'm done. Ian.

Re: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region

2021-03-24 Thread Roger Pau Monné
On Wed, Mar 24, 2021 at 04:22:44PM +0200, Andy Shevchenko wrote: > On Wed, Mar 24, 2021 at 02:55:15PM +0100, Roger Pau Monné wrote: > > On Wed, Mar 24, 2021 at 02:58:07PM +0200, Andy Shevchenko wrote: > > > On Wed, Mar 24, 2021 at 01:31:18PM +0100, Roger Pau Monne wrote: > > > Moreover, it seems yo

Re: [PATCH-for-4.15 V2] tools/libs/store: tidy up libxenstore interface

2021-03-24 Thread Julien Grall
On 24/03/2021 14:33, Jürgen Groß wrote: On 24.03.21 15:09, Julien Grall wrote: Hi Juergen, On 24/03/2021 11:30, Juergen Gross wrote: xenstore_lib.h is in need to be tidied up a little bit: - the definition of struct xs_tdb_record_hdr shouldn't be here - some symbols are not namespaced corr

[PATCH v2 0/2] intel/pinctrl: check some registers reads

2021-03-24 Thread Roger Pau Monne
Hello, The following series adds some consistency checks to the values returned by some of the MMIO registers of the Intel pinctrl device. That done to avoid a crash when running as a PVH dom0. See patch #1 for more details. Thanks, Roger. Roger Pau Monne (2): intel/pinctrl: check REVID regis

[PATCH v2 1/2] intel/pinctrl: check REVID register value for device presence

2021-03-24 Thread Roger Pau Monne
Use the value read from the REVID register in order to check for the presence of the device. A read of all ones is treated as if the device is not present, and hence probing is ended. This fixes an issue when running as a Xen PVH dom0, where the ACPI DSDT table is provided unmodified to dom0 and h

[PATCH v2 2/2] intel/pinctrl: check capability offset is between MMIO region

2021-03-24 Thread Roger Pau Monne
When parsing the capability list make sure the offset is between the MMIO region mapped in 'regs', or else the kernel hits a page fault. Adding the check is harmless, and prevents buggy or broken systems from crashing the kernel if the capability linked list is somehow broken. Fixes: 91d898e51e60

[libvirt test] 160379: regressions - FAIL

2021-03-24 Thread osstest service owner
flight 160379 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160379/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-armhf-libvirt

[PATCH 1/2] Branching: Update version files etc. for newly unstable

2021-03-24 Thread Ian Jackson
Signed-off-by: Ian Jackson --- CHANGELOG.md | 2 ++ Config.mk| 4 ++-- README | 16 SUPPORT.md | 2 +- xen/Makefile | 4 ++-- 5 files changed, 15 insertions(+), 13 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c407f6bb2f..f76fadf8c7 100644 --- a/CHA

[PATCH 2/2] Branching: Rerun autoconf to put version right

2021-03-24 Thread Ian Jackson
Signed-off-by: Ian Jackson --- configure | 18 +- docs/configure| 18 +- stubdom/configure | 18 +- tools/configure | 18 +- 4 files changed, 36 insertions(+), 36 deletions(-) diff --git a/configure b/configure index a

[PATCH for-4.15 1/2] 4.15: Turn off debug on the stable branch

2021-03-24 Thread Ian Jackson
Signed-off-by: Ian Jackson --- tools/Rules.mk| 2 +- xen/Kconfig.debug | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/Rules.mk b/tools/Rules.mk index 2907ed2d39..444e5bacdd 100644 --- a/tools/Rules.mk +++ b/tools/Rules.mk @@ -20,7 +20,7 @@ CFLAGS_xeninclude = -I$

[PATCH for-4.15 2/2] CHANGELOG: Correct sub-section headings

2021-03-24 Thread Ian Jackson
Signed-off-by: Ian Jackson --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c407f6bb2f..07f240b6ab 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,12 +6,12 @@ The format is based on [Keep a Changelog](https://keepachang

Xen 4.15 branched; commit moratorium lifted

2021-03-24 Thread Ian Jackson
I have just branched Xen 4.15. Patches targeted for Xen 4.15, with appropriate release-ack and maintainer acks, should be pushed to the branch staging-4.15. Patches targeting xen-next should be pushed to simply staging. Please do not commit anything to the new staging which would cause it to div

[PATCH 2/6] CHANGELOG.md: Add named PCI devices

2021-03-24 Thread George Dunlap
Signed-off-by: George Dunlap --- CC: Ian Jackson CC: Paul Durrant --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f03e85bd7..8c89212f14 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ The format is based on [Keep a Changelo

[PATCH 3/6] CHANGELOG.md: Add dom0 zstd compression support

2021-03-24 Thread George Dunlap
Signed-off-by: George Dunlap --- CC: Jan Beulich CC: Ian Jackson --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8c89212f14..354f213e81 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog

[PATCH 6/6] CHANGELOG.md: Add entries for CI loop

2021-03-24 Thread George Dunlap
Signed-off-by: George Dunlap --- CC: Wei Liu CC: Andrew Cooper CC: Stefano Stabellini CC: Doug Goldstein --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index df6c638152..15a22d6bde 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,8

[PATCH 1/6] Intel Processor Trace Support: Add CHANGELOG.md and SUPPORT.md entries

2021-03-24 Thread George Dunlap
Signed-off-by: George Dunlap --- CC: Andrew Cooper CC: Ian Jackson CC: Tamas K Lengyel --- CHANGELOG.md | 1 + SUPPORT.md | 7 +++ 2 files changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c407f6bb2f..7f03e85bd7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6

[PATCH 5/6] CHANGELOG.md: Add entries for emulation

2021-03-24 Thread George Dunlap
Signed-off-by: George Dunlap --- CC: Jan Beulich CC: Ian Jackson --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3f4eed1d98..df6c638152 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,8 @@ The format is based on [Keep a Changel

[PATCH 4/6] CHANGELOG.md: NetBSD lib/gnttab support

2021-03-24 Thread George Dunlap
Signed-off-by: George Dunlap --- CC: Manuel Bouyer CC: Ian Jackson CC: Roger Pau Monne --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 354f213e81..3f4eed1d98 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ The format is base

Re: [PATCH 1/2] Branching: Update version files etc. for newly unstable

2021-03-24 Thread Jan Beulich
On 24.03.2021 17:28, Ian Jackson wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -1,8 +1,8 @@ > # This is the correct place to edit the build version. > # All other places this is stored (eg. compile.h) should be autogenerated. > export XEN_VERSION = 4 > -export XEN_SUBVERSION= 1

Re: [PATCH 3/6] CHANGELOG.md: Add dom0 zstd compression support

2021-03-24 Thread Andrew Cooper
On 24/03/2021 16:44, George Dunlap wrote: > Signed-off-by: George Dunlap > --- > CC: Jan Beulich > CC: Ian Jackson > --- > CHANGELOG.md | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index 8c89212f14..354f213e81 100644 > --- a/CHANGELOG.md > +++ b/CHANGEL

Re: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region

2021-03-24 Thread Andy Shevchenko
On Wed, Mar 24, 2021 at 04:13:59PM +0100, Roger Pau Monné wrote: > On Wed, Mar 24, 2021 at 04:22:44PM +0200, Andy Shevchenko wrote: > > On Wed, Mar 24, 2021 at 02:55:15PM +0100, Roger Pau Monné wrote: > > > On Wed, Mar 24, 2021 at 02:58:07PM +0200, Andy Shevchenko wrote: > > > > On Wed, Mar 24, 202

Re: [PATCH v2 1/2] intel/pinctrl: check REVID register value for device presence

2021-03-24 Thread Andy Shevchenko
On Wed, Mar 24, 2021 at 04:43:11PM +0100, Roger Pau Monne wrote: Thanks for a fix! My comments below. > Use the value read from the REVID register in order to check for the > presence of the device. A read of all ones is treated as if the device > is not present, and hence probing is ended. > >

Re: [PATCH v2 2/2] intel/pinctrl: check capability offset is between MMIO region

2021-03-24 Thread Andy Shevchenko
On Wed, Mar 24, 2021 at 04:43:12PM +0100, Roger Pau Monne wrote: > When parsing the capability list make sure the offset is between the > MMIO region mapped in 'regs', or else the kernel hits a page fault. > > Adding the check is harmless, and prevents buggy or broken systems > from crashing the k

Re: [PATCH 3/6] CHANGELOG.md: Add dom0 zstd compression support

2021-03-24 Thread George Dunlap
> On Mar 24, 2021, at 4:56 PM, Andrew Cooper wrote: > > On 24/03/2021 16:44, George Dunlap wrote: >> Signed-off-by: George Dunlap >> --- >> CC: Jan Beulich >> CC: Ian Jackson >> --- >> CHANGELOG.md | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/CHANGELOG.md b/CHANGELOG.md >> ind

[PATCH] CHANGELOG.md: Make PV shim smaller by factoring out HVM-specific shadow code

2021-03-24 Thread George Dunlap
Signed-off-by: George Dunlap --- Missed one from my list when creating the other series CC: Ian Jackson CC: Jan Beulich CC: Roger Pau Monne --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 15a22d6bde..49832ae017 100644 --- a/CHANGELOG.md +

Re: [PATCH] ARM: xen/mm.c: A mundane typo fix

2021-03-24 Thread Stefano Stabellini
On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote: > s/acrros/across/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Stefano Stabellini > --- > arch/arm/xen/mm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c > index 467fa225c3d0

Re: [PATCH 6/6] CHANGELOG.md: Add entries for CI loop

2021-03-24 Thread Stefano Stabellini
On Wed, 24 Mar 2021, George Dunlap wrote: > Signed-off-by: George Dunlap > --- > CC: Wei Liu > CC: Andrew Cooper > CC: Stefano Stabellini > CC: Doug Goldstein > --- > CHANGELOG.md | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index df6c638152..15a22

Re: [PATCH] ARM: xen/mm.c: A mundane typo fix

2021-03-24 Thread Randy Dunlap
On 3/24/21 11:55 AM, Stefano Stabellini wrote: > On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote: >> s/acrros/across/ >> >> Signed-off-by: Bhaskar Chowdhury > > Reviewed-by: Stefano Stabellini > > Hi, It seems to me like some of those "page" should be "pages". >> --- >> arch/arm/xen/mm.c | 2 +

Re: [PATCH 1/2] docs/designs/launch: hyperlaunch design document

2021-03-24 Thread Stefano Stabellini
On Wed, 24 Mar 2021, Christopher Clark wrote: > > > > I'm also not sure how you are going to handle things like SR-IOV > > > > devices. Right now SR-IOV capability is setup and initialized by the > > > > hardware domain, and the new virtual devices are notified to Xen once > > > > setup is done. Do

Re: [PATCH] ARM: xen/mm.c: A mundane typo fix

2021-03-24 Thread Stefano Stabellini
On Wed, 24 Mar 2021, Randy Dunlap wrote: > On 3/24/21 11:55 AM, Stefano Stabellini wrote: > > On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote: > >> s/acrros/across/ > >> > >> Signed-off-by: Bhaskar Chowdhury > > > > Reviewed-by: Stefano Stabellini > > > > > > Hi, > It seems to me like some of th

[xen-unstable-smoke test] 160397: tolerable all pass - PUSHED

2021-03-24 Thread osstest service owner
flight 160397 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160397/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v8] arm: Add Kconfig entry to select CONFIG_DTB_FILE

2021-03-24 Thread Julien Grall
Hi Michal, On 22/03/2021 08:17, Michal Orzel wrote: Currently in order to link existing DTB into Xen image we need to either specify option CONFIG_DTB_FILE on the command line or manually add it into .config. Add Kconfig entry: CONFIG_DTB_FILE to be able to provide the path to DTB we want to emb

Re: [PATCH v2 0/5] xen/arm: smmuv1: Fix stream match conflict issue

2021-03-24 Thread Julien Grall
Hi Rahul, On 22/03/2021 16:11, Rahul Singh wrote: This patch is the work to fix the stream match conflict issue when two devices have the same stream-id. Approach taken is to merge the below commit from Linux driver to fix the issue. 1. "iommu/arm-smmu: Handle stream IDs more dynamically"

[PATCH] Performance regression due to XSA-336

2021-03-24 Thread Boris Ostrovsky
While running performance tests with recent XSAs backports to our product we've discovered significant regression in TPCC performance. With a particular guest kernel the numbers dropped by as much as 40%. We've narrowed that down to XSA-336 patch, specifically to the pt_migrate rwlock, and even

[PATCH] x86/vpt: Replace per-guest pt_migrate lock with per pt lock

2021-03-24 Thread Boris Ostrovsky
Commit 8e76aef72820 ("x86/vpt: fix race when migrating timers between vCPUs") addressed XSA-336 by introducing a per-domain rwlock that was intended to protect periodic timer during VCPU migration. Since such migration is an infrequent event no performance impact was expected. Unfortunately this t

[PATCH RESEND] Performance regression due to XSA-336

2021-03-24 Thread Boris Ostrovsky
(Re-sending with Stephen added) While running performance tests with recent XSAs backports to our product we've discovered significant regression in TPCC performance. With a particular guest kernel the numbers dropped by as much as 40%. We've narrowed that down to XSA-336 patch, specifically t

[PATCH RESEND] x86/vpt: Replace per-guest pt_migrate lock with per pt lock

2021-03-24 Thread Boris Ostrovsky
Commit 8e76aef72820 ("x86/vpt: fix race when migrating timers between vCPUs") addressed XSA-336 by introducing a per-domain rwlock that was intended to protect periodic timer during VCPU migration. Since such migration is an infrequent event no performance impact was expected. Unfortunately this t

[xen-4.12-testing test] 160370: regressions - FAIL

2021-03-24 Thread osstest service owner
flight 160370 xen-4.12-testing real [real] flight 160398 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160370/ http://logs.test-lab.xenproject.org/osstest/logs/160398/ Regressions :-( Tests which did not succeed and are blocking, including tests which could

[PATCH V2] ARM: xen/mm.c: A mundane typo fix

2021-03-24 Thread Bhaskar Chowdhury
s/acrros/across/ Plus some words need prural version...so did it.(page->pages) Signed-off-by: Bhaskar Chowdhury --- Changes from V1: Randy's findings incorporated. arch/arm/xen/mm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c

Re: [PATCH] ARM: xen/mm.c: A mundane typo fix

2021-03-24 Thread Bhaskar Chowdhury
On 11:59 Wed 24 Mar 2021, Randy Dunlap wrote: On 3/24/21 11:55 AM, Stefano Stabellini wrote: On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote: s/acrros/across/ Signed-off-by: Bhaskar Chowdhury Reviewed-by: Stefano Stabellini Hi, It seems to me like some of those "page" should be "pages".

Re: [PATCH v2 0/2] xen/x86: alternative fix for XSA-369

2021-03-24 Thread Boris Ostrovsky
On 3/24/21 8:24 AM, Roger Pau Monne wrote: > Hello, > > This is a proposal for an alternative fix for XSA-369 that instead of > special casing XEN_UNPOPULATED_ALLOC to size the p2m relies on making > XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on the generic MEMORY_HOTPLUG > option rather than XEN_BA

Re: [PATCH V2] ARM: xen/mm.c: A mundane typo fix

2021-03-24 Thread Randy Dunlap
On 3/24/21 9:35 PM, Bhaskar Chowdhury wrote: > s/acrros/across/ > > Plus some words need prural version...so did it.(page->pages) > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > Changes from V1: > Randy's findings incorporated. > > arch/arm/xen/mm.c | 4 ++-- > 1 file

[xen-4.15-testing baseline test] 160394: tolerable FAIL

2021-03-24 Thread osstest service owner
"Old" tested version had not actually been tested; therefore in this flight we test it, rather than a new candidate. The baseline, if any, is the most recent actually tested revision. flight 160394 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160394/ Failures :-/

[xen-unstable test] 160376: tolerable FAIL - PUSHED

2021-03-24 Thread osstest service owner
flight 160376 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/160376/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 160348 test-armhf-armhf-libvirt 16 save

[PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice

2021-03-24 Thread Wan Jiabing
struct xen_drm_front_drm_info has been declared. Remove the duplicate. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/xen/xen_drm_front_conn.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/xen/xen_drm_front_conn.h b/drivers/gpu/drm/xen/xen_drm_front_conn.h index 3adacba9a2

Re: [PATCH] gpu/xen: Fix a use after free in xen_drm_drv_init

2021-03-24 Thread Oleksandr Andrushchenko
Hi, good catch On 3/23/21 3:46 AM, Lv Yunlong wrote: > In function displback_changed, has the call chain > displback_connect(front_info)->xen_drm_drv_init(front_info). > We can see that drm_info is assigned to front_info->drm_info > and drm_info is freed in fail branch in xen_drm_drv_init(). > >