Re: more randconfig failures

2021-01-28 Thread Jan Beulich
On 27.01.2021 22:23, Andrew Cooper wrote: > On 27/01/2021 21:16, Stefano Stabellini wrote: >> Hi all, >> >> These are two recent randconfig build failures reported by gitlab (the >> two patches that triggered the CI-loop are two patches to the >> MAINTAINERS file -- certainly not the cause of the b

[libvirt test] 158717: regressions - FAIL

2021-01-28 Thread osstest service owner
flight 158717 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/158717/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH V5 04/22] xen/ioreq: Make x86's IOREQ feature common

2021-01-28 Thread Jan Beulich
On 27.01.2021 21:14, Oleksandr wrote: > On 27.01.21 18:58, Jan Beulich wrote: >> On 25.01.2021 20:08, Oleksandr Tyshchenko wrote: >>> --- a/xen/arch/x86/Kconfig >>> +++ b/xen/arch/x86/Kconfig >>> @@ -92,6 +92,7 @@ config PV_LINEAR_PT >>> >>> config HVM >>> def_bool !PV_SHIM_EXCLUSIVE >>> +

RE: [PATCH] xen-blkback: fix compatibility bug with single page rings

2021-01-28 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of Dongli > Zhang > Sent: 27 January 2021 19:57 > To: Paul Durrant ; xen-devel@lists.xenproject.org; > linux-bl...@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: Paul Durrant ; Konrad Rzeszutek Wilk > ; Roger Pau > Monné ; Jens Ax

Re: [RFC PATCH 02/34] block: introduce and use bio_new

2021-01-28 Thread Chaitanya Kulkarni
On 1/27/21 11:21 PM, Damien Le Moal wrote: On 2021/01/28 16:12, Chaitanya Kulkarni wrote: Introduce bio_new() helper and use it in blk-lib.c to allocate and initialize various non-optional or semi-optional members of the bio along with bio allocation done with bio_alloc(). Here we also calmp the

Re: [RFC PATCH 02/34] block: introduce and use bio_new

2021-01-28 Thread Chaitanya Kulkarni
On 1/27/21 11:27 PM, Damien Le Moal wrote: + + bio_set_dev(bio, bdev); + bio->bi_iter.bi_sector = sector; + bio_set_op_attrs(bio, op, op_flags); This function is obsolete. Open code this. And that also mean that you could remove one argument to bio_new(): combine op and op_fl

[xen-unstable test] 158711: tolerable FAIL - PUSHED

2021-01-28 Thread osstest service owner
flight 158711 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/158711/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stopfail like 158699 test-amd64-amd64-xl-qemuu-win7-amd64

Re: [PATCH V5 14/22] arm/ioreq: Introduce arch specific bits for IOREQ/DM features

2021-01-28 Thread Julien Grall
Hi Oleksandr, On 27/01/2021 19:20, Oleksandr wrote: > >>> So I think we may be able to drop the include from asm/hvm/domain.h (this would avoid to include it everywhere...). I have tried that, but other CUs use definitions from public/hvm/dm_op.h, for example: p2m-pt.c: In function 'p2m_t

Re: Problems with APIC on versions 4.9 and later (4.8 works)

2021-01-28 Thread Jan Beulich
On 26.01.2021 14:03, Claudemir Todo Bom wrote: > If this information is good for more tests, please send the patch and > I will test it! Here you go. For simplifying analysis it may be helpful if you could limit the number of CPUs in use, e.g. by "maxcpus=4" or at least "smt=0". Provided the probl

Re: Problems with APIC on versions 4.9 and later (4.8 works)

2021-01-28 Thread Jan Beulich
On 28.01.2021 10:47, Jan Beulich wrote: > On 26.01.2021 14:03, Claudemir Todo Bom wrote: >> If this information is good for more tests, please send the patch and >> I will test it! > > Here you go. For simplifying analysis it may be helpful if you > could limit the number of CPUs in use, e.g. by "

Re: [PATCH V5 22/22] xen/arm: Add mapcache invalidation handling

2021-01-28 Thread Julien Grall
Hi Oleksandr, On 25/01/2021 19:08, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko We need to send mapcache invalidation request to qemu/demu everytime the page gets removed from a guest. At the moment, the Arm code doesn't explicitely remove the existing mapping before inserting the n

Re: [PATCH] xen: Add RING_COPY_RESPONSE()

2021-01-28 Thread Jan Beulich
On 28.01.2021 06:38, Jürgen Groß wrote: > On 28.01.21 04:16, Marek Marczykowski-Górecki wrote: >> Using RING_GET_RESPONSE() on a shared ring is easy to use incorrectly >> (i.e., by not considering that the other end may alter the data in the >> shared ring while it is being inspected). Safe usage o

Re: [PATCH for-4.15] x86/boot: Drop 'noapic' suggestion from check_timer()

2021-01-28 Thread Jan Beulich
On 27.01.2021 20:49, Andrew Cooper wrote: > In practice, there is no such thing as a real 64bit system without > APICs. (PVH style virtual environments, sure, but they don't end up here). > > The suggestion to try and use noapic only makes a bad situation worse. > > Signed-off-by: Andrew Cooper

Re: [PATCH] x86/pod: Do not fragment PoD memory allocations

2021-01-28 Thread Jan Beulich
On 27.01.2021 23:28, Elliott Mitchell wrote: > On Wed, Jan 27, 2021 at 09:03:32PM +, Andrew Cooper wrote: >> So.?? What *should* happen is that if QEMU/OVMF dirties more memory than >> exists in the PoD cache, the domain gets terminated. >> >> Irrespective, Xen/dom0 dying isn't an expected cons

[ANNOUNCE] NEW CALLIN DETAILS Call for agenda items for 4 February Community Call @ 16:00 UTC

2021-01-28 Thread George Dunlap
Hi all, PLEASE NOTE NEW CALLIN DETAILS BELOW. The proposed agenda is in https://cryptpad.fr/pad/#/2/pad/edit/e2cGWQMdvrXt86dvezuzJ9S2/ and you can edit to add items. Alternatively, you can reply to this mail directly. Agenda items appreciated a few days before the call: please put your name

Re: [RFC PATCH 29/34] power/swap: use bio_new in hib_submit_io

2021-01-28 Thread Rafael J. Wysocki
On Thu, Jan 28, 2021 at 8:21 AM Chaitanya Kulkarni wrote: > Please explain in the changelog why making this change is a good idea. > Signed-off-by: Chaitanya Kulkarni > --- > kernel/power/swap.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/kernel/power/swap.c

[linux-linus test] 158712: regressions - FAIL

2021-01-28 Thread osstest service owner
flight 158712 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/158712/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

Re: [PATCH v2] xenpmd.c: use dynamic allocation

2021-01-28 Thread Roger Pau Monné
On Tue, Jan 26, 2021 at 11:48:00PM +0100, Manuel Bouyer wrote: > On NetBSD, d_name is larger than 256, so file_name[284] may not be large > enough (and gcc emits a format-truncation error). > Use asprintf() instead of snprintf() on a static on-stack buffer. > > Signed-off-by: Manuel Bouyer Revie

[PATCH] memory: bail from page scrubbing when CPU is no longer online

2021-01-28 Thread Jan Beulich
Scrubbing can significantly delay the offlining (parking) of a CPU (e.g. because of booting into in smt=0 mode), to a degree that the "CPU still not dead..." messages logged on x86 in 1s intervals can be seen multiple times. There are no softirqs involved in this process, so extend the existing pr

Re: [PATCH] memory: bail from page scrubbing when CPU is no longer online

2021-01-28 Thread Andrew Cooper
On 28/01/2021 10:35, Jan Beulich wrote: > Scrubbing can significantly delay the offlining (parking) of a CPU (e.g. > because of booting into in smt=0 mode), to a degree that the "CPU > still not dead..." messages logged on x86 in 1s intervals can be seen > multiple times. There are no softirqs inv

Re: [PATCH v2] libs/foreignmemory: Implement on NetBSD

2021-01-28 Thread Roger Pau Monné
On Tue, Jan 26, 2021 at 11:47:52PM +0100, Manuel Bouyer wrote: > Implement foreignmemory interface on NetBSD. The compat interface is now used > only on __sun__ > > Signed-off-by: Manuel Bouyer > --- > tools/libs/foreignmemory/Makefile | 2 +- > tools/libs/foreignmemory/netbsd.c | 66

Re: [PATCH V5 09/22] xen/ioreq: Make x86's IOREQ related dm-op handling common

2021-01-28 Thread Jan Beulich
On 25.01.2021 20:08, Oleksandr Tyshchenko wrote: > --- /dev/null > +++ b/xen/include/xen/dm.h > @@ -0,0 +1,41 @@ > +/* > + * Copyright (c) 2016 Citrix Systems Inc. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU Gen

Re: [PATCH v2] libs/foreignmemory: Implement on NetBSD

2021-01-28 Thread Andrew Cooper
On 26/01/2021 22:47, Manuel Bouyer wrote: > diff --git a/tools/libs/foreignmemory/netbsd.c > b/tools/libs/foreignmemory/netbsd.c > index 54a418ebd6..a7e1d72ffc 100644 > --- a/tools/libs/foreignmemory/netbsd.c > +++ b/tools/libs/foreignmemory/netbsd.c > @@ -97,7 +102,48 @@ void *osdep_map_foreign_b

Re: [PATCH v2] libs/store: make build without PTHREAD_STACK_MIN

2021-01-28 Thread Roger Pau Monné
On Tue, Jan 26, 2021 at 11:47:59PM +0100, Manuel Bouyer wrote: > On NetBSD, PTHREAD_STACK_MIN is not available. > If PTHREAD_STACK_MIN is not defined, define it to 0 so that we fallback to > DEFAULT_THREAD_STACKSIZE > I would add: Suggested-by: Andrew Cooper > Signed-off-by: Manuel Bouyer Re

Re: [PATCH V5 04/22] xen/ioreq: Make x86's IOREQ feature common

2021-01-28 Thread Oleksandr
On 27.01.21 22:46, Stefano Stabellini wrote: Hi Stefano, all On Wed, 27 Jan 2021, Oleksandr wrote: On Mon, 25 Jan 2021 at 19:09, Oleksandr Tyshchenko wrote: *** Please note, this patch depends on the following which is on review: https://patchwork.kernel.org/patch/11816689/ The effort (to

Re: [PATCH v2] libs/light: make it build without setresuid()

2021-01-28 Thread Ian Jackson
Manuel Bouyer writes ("[PATCH v2] libs/light: make it build without setresuid()"): > NetBSD doesn't have setresuid(). introcuce libxl__setresuid(), > which on NetBSD assert() that it's never called (it should not be called when > dm restriction is off, and NetBSD doesn't support dm restriction at

Re: [PATCH v2] libs/light: pass some infos to qemu

2021-01-28 Thread Roger Pau Monné
On Tue, Jan 26, 2021 at 11:47:58PM +0100, Manuel Bouyer wrote: > Pass bridge name to qemu as command line option > When starting qemu, set an environnement variable XEN_DOMAIN_ID, > to be used by qemu helper scripts > The only functional difference of using the br parameter is that the > bridge nam

Re: [PATCH v2] libs/store: make build without PTHREAD_STACK_MIN

2021-01-28 Thread Andrew Cooper
On 28/01/2021 10:57, Roger Pau Monné wrote: > On Tue, Jan 26, 2021 at 11:47:59PM +0100, Manuel Bouyer wrote: >> On NetBSD, PTHREAD_STACK_MIN is not available. >> If PTHREAD_STACK_MIN is not defined, define it to 0 so that we fallback to >> DEFAULT_THREAD_STACKSIZE >> > I would add: > > Suggested-by

Re: [PATCH v2] libs/gnttab: implement on NetBSD

2021-01-28 Thread Roger Pau Monné
On Tue, Jan 26, 2021 at 11:47:53PM +0100, Manuel Bouyer wrote: > +int osdep_gntshr_unshare(xengntshr_handle *xgs, > + void *start_address, uint32_t count) > +{ > +return munmap(start_address, count * PAGE_SIZE); > +} > + > +/* > + * The functions below are Linux-isms tha

Re: [PATCH V5 04/22] xen/ioreq: Make x86's IOREQ feature common

2021-01-28 Thread Oleksandr
On 28.01.21 10:06, Jan Beulich wrote: Hi Jan On 27.01.2021 21:14, Oleksandr wrote: On 27.01.21 18:58, Jan Beulich wrote: On 25.01.2021 20:08, Oleksandr Tyshchenko wrote: --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -92,6 +92,7 @@ config PV_LINEAR_PT config HVM d

Re: [PATCH v2] NetBSD: use system-provided headers

2021-01-28 Thread Roger Pau Monné
On Tue, Jan 26, 2021 at 11:47:50PM +0100, Manuel Bouyer wrote: > On NetBSD use the system-provided headers for ioctl and related definitions, > they are up to date and have more chances to match the kernel's idea of > the ioctls and structures. > Remove now-unused NetBSD/evtchn.h and NetBSD/privcmd

Re: [PATCH V5 04/22] xen/ioreq: Make x86's IOREQ feature common

2021-01-28 Thread Jan Beulich
On 28.01.2021 12:01, Oleksandr wrote: > On 27.01.21 22:46, Stefano Stabellini wrote: >> On Wed, 27 Jan 2021, Oleksandr wrote: >>> Thank you. I got a request to make a possibility for user to select IOREQ >>> via >>> the menuconfig on Arm. Saying tech preview do you mean that I also need to >>> pu

Re: [PATCH V5 04/22] xen/ioreq: Make x86's IOREQ feature common

2021-01-28 Thread Jan Beulich
On 28.01.2021 12:16, Oleksandr wrote: > On 28.01.21 10:06, Jan Beulich wrote: >> On 27.01.2021 21:14, Oleksandr wrote: >>> On 27.01.21 18:58, Jan Beulich wrote: On 25.01.2021 20:08, Oleksandr Tyshchenko wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -92,6 +92

Re: [PATCH V5 14/22] arm/ioreq: Introduce arch specific bits for IOREQ/DM features

2021-01-28 Thread Oleksandr
On 28.01.21 11:40, Julien Grall wrote: Hi Julien Hi Oleksandr, On 27/01/2021 19:20, Oleksandr wrote:  >  >>> So I think we may be able to drop the include from asm/hvm/domain.h (this would avoid to include it everywhere...). I have tried that, but other CUs use definitions from public/hv

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-28 Thread Ian Jackson
Manuel Bouyer writes ("Re: [PATCH] libs/light: make it build without setresuid()"): > On Wed, Jan 27, 2021 at 04:03:04PM +, Ian Jackson wrote: > > How about I write a patch splitting the relevant part up into a > > version for systems with setresuid and systems without ? Then you > > could fi

Re: [PATCH v2] libs/foreignmemory: Implement on NetBSD

2021-01-28 Thread Andrew Cooper
On 28/01/2021 10:52, Andrew Cooper wrote: > On 26/01/2021 22:47, Manuel Bouyer wrote: >> diff --git a/tools/libs/foreignmemory/netbsd.c >> b/tools/libs/foreignmemory/netbsd.c >> index 54a418ebd6..a7e1d72ffc 100644 >> --- a/tools/libs/foreignmemory/netbsd.c >> +++ b/tools/libs/foreignmemory/netbsd.

Re: [PATCH v2] NetBSD hotplug: fix block unconfigure on destroy

2021-01-28 Thread Roger Pau Monné
On Tue, Jan 26, 2021 at 11:47:49PM +0100, Manuel Bouyer wrote: > When a domain is destroyed, xparams may not be available any more when > the block script is called to unconfigure the vnd. > Check xparam only at configure time, and just unconfigure any vnd present > in the xenstore. Can you paste

[PATCH v4] tools/foreignmem: Support querying the size of a resource

2021-01-28 Thread Andrew Cooper
With the Xen side of this interface (soon to be) fixed to return real sizes, userspace needs to be able to make the query. Introduce xenforeignmemory_resource_size() for the purpose, bumping the library minor version. Update both all osdep_xenforeignmemory_map_resource() implementations to unders

Re: [PATCH V5 09/22] xen/ioreq: Make x86's IOREQ related dm-op handling common

2021-01-28 Thread Oleksandr
On 28.01.21 12:52, Jan Beulich wrote: Hi Jan On 25.01.2021 20:08, Oleksandr Tyshchenko wrote: --- /dev/null +++ b/xen/include/xen/dm.h @@ -0,0 +1,41 @@ +/* + * Copyright (c) 2016 Citrix Systems Inc. + * + * This program is free software; you can redistribute it and/or modify it + * under the

Re: [RFC PATCH 25/34] ocfs/cluster: use bio_new in dm-log-writes

2021-01-28 Thread Joseph Qi
I think you send a wrong subject by mistake. Thanks, Joseph On 1/28/21 3:11 PM, Chaitanya Kulkarni wrote: > Signed-off-by: Chaitanya Kulkarni > --- > fs/ocfs2/cluster/heartbeat.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/oc

RE: [PATCH v4] tools/foreignmem: Support querying the size of a resource

2021-01-28 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 28 January 2021 12:02 > To: Xen-devel > Cc: Andrew Cooper ; Wei Liu ; Paul > Durrant ; > Roger Pau Monné ; Juergen Gross ; Ian > Jackson > ; Michał Leszczyński ; > Hubert Jasudowicz > ; Tamas K Lengyel ; Manuel > Bouyer > Subject: [P

Re: [RFC PATCH 19/34] fs/jfs/jfs_logmgr.c: use bio_new in lbmRead

2021-01-28 Thread Dave Kleikamp
You probably don't need 4 patches to fs/jfs/. These can be combined into a single patch. Dave On 1/28/21 1:11 AM, Chaitanya Kulkarni wrote: Signed-off-by: Chaitanya Kulkarni --- fs/jfs/jfs_logmgr.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/jfs/jfs_logmgr

Re: [PATCH V5 04/22] xen/ioreq: Make x86's IOREQ feature common

2021-01-28 Thread Oleksandr
On 28.01.21 13:21, Jan Beulich wrote: Hi Jan On 28.01.2021 12:01, Oleksandr wrote: On 27.01.21 22:46, Stefano Stabellini wrote: On Wed, 27 Jan 2021, Oleksandr wrote: Thank you. I got a request to make a possibility for user to select IOREQ via the menuconfig on Arm. Saying tech preview do

[PATCH] xen-blkback: fix compatibility bug with single page rings

2021-01-28 Thread Paul Durrant
From: Paul Durrant Prior to commit 4a8c31a1c6f5 ("xen/blkback: rework connect_ring() to avoid inconsistent xenstore 'ring-page-order' set by malicious blkfront"), the behaviour of xen-blkback when connecting to a frontend was: - read 'ring-page-order' - if not present then expect a single page r

Re: [PATCH v4] tools/foreignmem: Support querying the size of a resource

2021-01-28 Thread Wei Liu
On Thu, Jan 28, 2021 at 12:01:52PM +, Andrew Cooper wrote: > With the Xen side of this interface (soon to be) fixed to return real sizes, > userspace needs to be able to make the query. > > Introduce xenforeignmemory_resource_size() for the purpose, bumping the > library minor version. > > Up

RE: [PATCH] xen-blkback: fix compatibility bug with single page rings

2021-01-28 Thread Paul Durrant
Apologies; I missed the v2 from the subject line. I'll re-send. Paul > -Original Message- > From: Xen-devel On Behalf Of Paul > Durrant > Sent: 28 January 2021 12:55 > To: xen-devel@lists.xenproject.org; linux-bl...@vger.kernel.org; > linux-ker...@vger.kernel.org > Cc: Paul Durrant ;

[PATCH v2] xen-blkback: fix compatibility bug with single page rings

2021-01-28 Thread Paul Durrant
From: Paul Durrant Prior to commit 4a8c31a1c6f5 ("xen/blkback: rework connect_ring() to avoid inconsistent xenstore 'ring-page-order' set by malicious blkfront"), the behaviour of xen-blkback when connecting to a frontend was: - read 'ring-page-order' - if not present then expect a single page r

Re: [PATCH V5 22/22] xen/arm: Add mapcache invalidation handling

2021-01-28 Thread Oleksandr
On 28.01.21 11:55, Julien Grall wrote: Hi Oleksandr, Hi Julien On 25/01/2021 19:08, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko We need to send mapcache invalidation request to qemu/demu everytime the page gets removed from a guest. At the moment, the Arm code doesn't exp

Re: [PATCH V5 09/22] xen/ioreq: Make x86's IOREQ related dm-op handling common

2021-01-28 Thread Jan Beulich
On 28.01.2021 13:06, Oleksandr wrote: > > On 28.01.21 12:52, Jan Beulich wrote: > > Hi Jan > >> On 25.01.2021 20:08, Oleksandr Tyshchenko wrote: >>> --- /dev/null >>> +++ b/xen/include/xen/dm.h >>> @@ -0,0 +1,41 @@ >>> +/* >>> + * Copyright (c) 2016 Citrix Systems Inc. >>> + * >>> + * This progr

Re: [PATCH V5 14/22] arm/ioreq: Introduce arch specific bits for IOREQ/DM features

2021-01-28 Thread Oleksandr
On 28.01.21 13:33, Oleksandr wrote: Hi Julien On 28.01.21 11:40, Julien Grall wrote: Hi Julien Hi Oleksandr, On 27/01/2021 19:20, Oleksandr wrote:  >  >>> So I think we may be able to drop the include from asm/hvm/domain.h (this would avoid to include it everywhere...). I have tried t

Re: [PATCH V5 10/22] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu

2021-01-28 Thread Julien Grall
Hi Oleksandr, On 25/01/2021 19:08, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The IOREQ is a common feature now and these fields will be used on Arm as is. Move them to common struct vcpu as a part of new struct vcpu_io and drop duplicating "io" prefixes. Also move enum hvm_io_comp

Re: [PATCH V5 10/22] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu

2021-01-28 Thread Jan Beulich
On 28.01.2021 14:41, Julien Grall wrote: > Hi Oleksandr, > > On 25/01/2021 19:08, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> The IOREQ is a common feature now and these fields will be used >> on Arm as is. Move them to common struct vcpu as a part of new >> struct vcpu_io and

Re: [PATCH] NetBSD hotplug: Introduce locking functions

2021-01-28 Thread Ian Jackson
Manuel Bouyer writes ("Re: [PATCH] NetBSD hotplug: Introduce locking functions"): > thanks, but I submitted a v2 patch which uses a locking.sh derived > from the linux one, based on your feedback. > Should I add your Reviewed-by to the v2 ? Sorry, yes, please. Ian.

Re: [PATCH V5 10/22] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu

2021-01-28 Thread Oleksandr
On 28.01.21 15:41, Julien Grall wrote: Hi Oleksandr, Hi Julien On 25/01/2021 19:08, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The IOREQ is a common feature now and these fields will be used on Arm as is. Move them to common struct vcpu as a part of new struct vcpu_io and

Re: [PATCH V5 10/22] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu

2021-01-28 Thread Julien Grall
Hi Jan, On 28/01/2021 13:53, Jan Beulich wrote: On 28.01.2021 14:41, Julien Grall wrote: Hi Oleksandr, On 25/01/2021 19:08, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The IOREQ is a common feature now and these fields will be used on Arm as is. Move them to common struct vcpu as

Re: [OSSTEST PATCH 7/7] make-flight: Stripy xenstored [and 2 more messages]

2021-01-28 Thread Ian Jackson
Andrew Cooper writes ("Re: [OSSTEST PATCH 7/7] make-flight: Stripy xenstored [and 2 more messages]"): > Well - I ask specifically because there is a thread on xen-devel about > upping the minimum supported version of Ocaml, in order to simplify a > couple of aspects. > > This would manifest as ox

Re: [PATCH V5 14/22] arm/ioreq: Introduce arch specific bits for IOREQ/DM features

2021-01-28 Thread Oleksandr
Hi Julien On 28.01.21 15:39, Oleksandr wrote: On 28.01.21 13:33, Oleksandr wrote: Hi Julien On 28.01.21 11:40, Julien Grall wrote: Hi Julien Hi Oleksandr, On 27/01/2021 19:20, Oleksandr wrote:  >  >>> So I think we may be able to drop the include from asm/hvm/domain.h (this would a

Re: [PATCH V5 10/22] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu

2021-01-28 Thread Jan Beulich
On 28.01.2021 15:21, Julien Grall wrote: > On 28/01/2021 13:53, Jan Beulich wrote: >> On 28.01.2021 14:41, Julien Grall wrote: >>> On 25/01/2021 19:08, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The IOREQ is a common feature now and these fields will be used on Arm

Re: [PATCH V5 00/22] IOREQ feature (+ virtio-mmio) on Arm

2021-01-28 Thread Oleksandr
Hi Julien, all On 27.01.21 19:45, Oleksandr wrote: On 27.01.21 19:42, Julien Grall wrote: Hi On 27/01/2021 17:37, Oleksandr wrote: On 27.01.21 19:33, Julien Grall wrote: Hi Julien On 27/01/2021 16:50, Oleksandr wrote: On 27.01.21 18:43, Julien Grall wrote: Hi Oleksandr, Hi J

[PATCH] x86/HVM: re-order error path of hvm_domain_initialise()

2021-01-28 Thread Jan Beulich
hvm_destroy_all_ioreq_servers(), called from hvm_domain_relinquish_resources(), invokes relocate_portio_handler(), which uses d->arch.hvm.io_handler. Defer freeing of this array accordingly on the error path of hvm_domain_initialise(). Similarly rtc_deinit() requires d->arch.hvm.pl_time to still b

Re: [PATCH V5 14/22] arm/ioreq: Introduce arch specific bits for IOREQ/DM features

2021-01-28 Thread Julien Grall
On 28/01/2021 14:29, Oleksandr wrote: Hi Julien On 28.01.21 15:39, Oleksandr wrote: On 28.01.21 13:33, Oleksandr wrote: Hi Julien On 28.01.21 11:40, Julien Grall wrote: Hi Julien Hi Oleksandr, On 27/01/2021 19:20, Oleksandr wrote:  >  >>> So I think we may be able to drop the incl

Re: [PATCH v3] x86/mm: Short circuit damage from "fishy" ref/typecount failure

2021-01-28 Thread Jan Beulich
On 25.01.2021 18:59, Andrew Cooper wrote: > I am literally not changing the current behaviour.  Xen *will* hit a > BUG() if any of these domain_crash() paths are taken. > > If you do not believe me, then please go and actually check what happens > when simulating a ref-acquisition failure. Okay,

Re: [PATCH V5 10/22] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu

2021-01-28 Thread Andrew Cooper
On 28/01/2021 14:36, Jan Beulich wrote: > On 28.01.2021 15:21, Julien Grall wrote: >> I was going to reply back on my e-mail with more debugging information. >> It seems that this is a build issue as if I clean the repo the error >> disappear. >> >> The error happens when I move from staging to a

[xen-unstable-smoke test] 158724: regressions - FAIL

2021-01-28 Thread osstest service owner
flight 158724 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/158724/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 158713 Tests which

Re: [PATCH V5 10/22] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu

2021-01-28 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH V5 10/22] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu"): > On 28.01.2021 15:21, Julien Grall wrote: > > It seems that this is a build issue as if I clean the repo the error > > disappear. > > > > The error happens when I move from staging to a

Re: [PATCH V5 14/22] arm/ioreq: Introduce arch specific bits for IOREQ/DM features

2021-01-28 Thread Oleksandr
On 28.01.21 16:41, Julien Grall wrote: Hi Julien On 28/01/2021 14:29, Oleksandr wrote: Hi Julien On 28.01.21 15:39, Oleksandr wrote: On 28.01.21 13:33, Oleksandr wrote: Hi Julien On 28.01.21 11:40, Julien Grall wrote: Hi Julien Hi Oleksandr, On 27/01/2021 19:20, Oleksandr wrot

Re: [PATCH V5 10/22] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu

2021-01-28 Thread Jan Beulich
On 28.01.2021 15:51, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH V5 10/22] xen/ioreq: Move x86's > io_completion/io_req fields to struct vcpu"): >> On 28.01.2021 15:21, Julien Grall wrote: >>> It seems that this is a build issue as if I clean the repo the error >>> disappear. >>> >>> The

Re: [PATCH for-4.15] x86/boot: Drop 'noapic' suggestion from check_timer()

2021-01-28 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH for-4.15] x86/boot: Drop 'noapic' suggestion from check_timer()"): > On 27.01.2021 20:49, Andrew Cooper wrote: > > In practice, there is no such thing as a real 64bit system without > > APICs. (PVH style virtual environments, sure, but they don't end up here). > >

Re: [PATCH V5 10/22] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu

2021-01-28 Thread Julien Grall
Hi Jan, On 28/01/2021 14:36, Jan Beulich wrote: On 28.01.2021 15:21, Julien Grall wrote: On 28/01/2021 13:53, Jan Beulich wrote: On 28.01.2021 14:41, Julien Grall wrote: On 25/01/2021 19:08, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The IOREQ is a common feature now and these

Re: [PATCH V5 14/22] arm/ioreq: Introduce arch specific bits for IOREQ/DM features

2021-01-28 Thread Julien Grall
On 28/01/2021 14:52, Oleksandr wrote: On 28.01.21 16:41, Julien Grall wrote: On 28/01/2021 14:29, Oleksandr wrote: On 28.01.21 15:39, Oleksandr wrote: On 28.01.21 13:33, Oleksandr wrote: Hi Julien On 28.01.21 11:40, Julien Grall wrote: Hi Julien Hi Oleksandr, On 27/01/2021 19:20,

Re: [PATCH V5 00/22] IOREQ feature (+ virtio-mmio) on Arm

2021-01-28 Thread Julien Grall
Hi, On 28/01/2021 14:37, Oleksandr wrote: On 27.01.21 19:45, Oleksandr wrote: On 27.01.21 19:42, Julien Grall wrote: Hi On 27/01/2021 17:37, Oleksandr wrote: On 27.01.21 19:33, Julien Grall wrote: Hi Julien On 27/01/2021 16:50, Oleksandr wrote: On 27.01.21 18:43, Julien Grall wro

Re: [PATCH for-4.15] x86/boot: Drop 'noapic' suggestion from check_timer()

2021-01-28 Thread Andrew Cooper
On 28/01/2021 14:57, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH for-4.15] x86/boot: Drop 'noapic' suggestion > from check_timer()"): >> On 27.01.2021 20:49, Andrew Cooper wrote: >>> In practice, there is no such thing as a real 64bit system without >>> APICs. (PVH style virtual environm

[GIT PULL] xen: branch for v5.11-rc6

2021-01-28 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.11-rc6-tag xen: branch for v5.11-rc6 It contains the following fixes: - A fix for a regression introduced in 5.11 resulting in Xen dom0 having problems to correctly initialize Xe

[PATCH v2] xen: Add RING_COPY_RESPONSE()

2021-01-28 Thread Marek Marczykowski-Górecki
Using RING_GET_RESPONSE() on a shared ring is easy to use incorrectly (i.e., by not considering that the other end may alter the data in the shared ring while it is being inspected). Safe usage of a response generally requires taking a local copy. Provide a RING_COPY_RESPONSE() macro to use instea

[PATCH] xen/memory: Reject out-of-range resource 'frame' values

2021-01-28 Thread Andrew Cooper
The ABI is unfortunate, and frame being 64 bits leads to all kinds of problems performing correct overflow checks. Furthermore, the mixed use of unsigned int and unsigned long in the call tree is buggy on arm32 where the two are the same size, and certain out-of-range combinations will truncated a

Re: [PATCH V5 00/22] IOREQ feature (+ virtio-mmio) on Arm

2021-01-28 Thread Julien Grall
Hi, On 25/01/2021 19:08, Oleksandr Tyshchenko wrote: > Patch series [8] was rebased on recent "staging branch" (5e31789 tools/ocaml/libs/xb: Do not crash after xenbus is unmapped) and tested on Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) with virtio-mmio disk backend [9] running in driver

Re: [PATCH V5 10/22] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu

2021-01-28 Thread Andrew Cooper
On 28/01/2021 14:54, Jan Beulich wrote: > On 28.01.2021 15:51, Ian Jackson wrote: >> Jan Beulich writes ("Re: [PATCH V5 10/22] xen/ioreq: Move x86's >> io_completion/io_req fields to struct vcpu"): Removing entry.o or asm-offsets.h before building doesn't help. Any other idea? >>> No, I

Re: more randconfig failures

2021-01-28 Thread Julien Grall
On 27/01/2021 23:11, Rahul Singh wrote: Hello Julien, Hi Rahul, On 27 Jan 2021, at 9:25 pm, Julien Grall wrote: Hi, On Wed, 27 Jan 2021 at 21:16, Stefano Stabellini wrote: Hi all, These are two recent randconfig build failures reported by gitlab (the two patches that triggered the CI-l

[PATCH] xen-release-management doc: More info on schedule

2021-01-28 Thread Ian Jackson
This documents our practice, established in 2018 https://lists.xen.org/archives/html/xen-devel/2018-07/msg02240.html et seq CC: Jürgen Groß CC: Paul Durrant CC: Wei Liu Signed-off-by: Ian Jackson --- docs/process/xen-release-management.pandoc | 12 ++-- 1 file changed, 10 insertions

Re: more randconfig failures

2021-01-28 Thread Jan Beulich
On 28.01.2021 17:34, Julien Grall wrote: > On 27/01/2021 23:11, Rahul Singh wrote: >> Hello Julien, > > Hi Rahul, > >>> On 27 Jan 2021, at 9:25 pm, Julien Grall wrote: >>> >>> Hi, >>> >>> On Wed, 27 Jan 2021 at 21:16, Stefano Stabellini >>> wrote: Hi all, These are two rece

Re: [Ocfs2-devel] [RFC PATCH 02/34] block: introduce and use bio_new

2021-01-28 Thread Matthew Wilcox
FYI your email is completely unreadable to those not using html. I can't tell what you wrote and what Damien wrote. On Thu, Jan 28, 2021 at 08:33:10AM +, Chaitanya Kulkarni wrote: > On 1/27/21 11:21 PM, Damien Le Moal wrote: > > On 2021/01/28 16:12, Chaitanya Kulkarni wrote: > > > Introdu

Re: [PATCH] xen-release-management doc: More info on schedule

2021-01-28 Thread Jan Beulich
On 28.01.2021 17:35, Ian Jackson wrote: > This documents our practice, established in 2018 > https://lists.xen.org/archives/html/xen-devel/2018-07/msg02240.html > et seq > > CC: Jürgen Groß > CC: Paul Durrant > CC: Wei Liu > Signed-off-by: Ian Jackson > --- > docs/process/xen-release-manage

Re: [PATCH] x86/HVM: re-order error path of hvm_domain_initialise()

2021-01-28 Thread Andrew Cooper
On 28/01/2021 14:40, Jan Beulich wrote: > hvm_destroy_all_ioreq_servers(), called from > hvm_domain_relinquish_resources(), invokes relocate_portio_handler(), > which uses d->arch.hvm.io_handler. Defer freeing of this array > accordingly on the error path of hvm_domain_initialise(). > > Similarly r

Re: [PATCH] xen-release-management doc: More info on schedule

2021-01-28 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH] xen-release-management doc: More info on schedule"): > On 28.01.2021 17:35, Ian Jackson wrote: > > -The Xen hypervisor project now releases every 8 months. The actual release > > date > > -depends on a lot of factors. > > +The Xen hypervisor project now releases e

Re: [PATCH] x86/HVM: re-order error path of hvm_domain_initialise()

2021-01-28 Thread Jan Beulich
On 28.01.2021 17:51, Andrew Cooper wrote: > On 28/01/2021 14:40, Jan Beulich wrote: >> hvm_destroy_all_ioreq_servers(), called from >> hvm_domain_relinquish_resources(), invokes relocate_portio_handler(), >> which uses d->arch.hvm.io_handler. Defer freeing of this array >> accordingly on the error

Re: [RFC PATCH 17/34] iomap: use bio_new in iomap_dio_zero

2021-01-28 Thread Darrick J. Wong
On Wed, Jan 27, 2021 at 11:11:16PM -0800, Chaitanya Kulkarni wrote: > Signed-off-by: Chaitanya Kulkarni Looks ok to me, Reviewed-by: Darrick J. Wong --D > --- > fs/iomap/direct-io.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/iomap/direct-io.c b/fs/iomap

RE: [PATCH] xen/memory: Reject out-of-range resource 'frame' values

2021-01-28 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 28 January 2021 16:06 > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Roger Pau Monné > ; Wei Liu ; Stefano Stabellini > ; Julien > Grall ; Volodymyr Babchuk ; Paul > Durrant ; > Oleksandr Tyshchenko > Subject: [PATCH] xen/memor

Re: [PATCH V5 04/22] xen/ioreq: Make x86's IOREQ feature common

2021-01-28 Thread Stefano Stabellini
On Thu, 28 Jan 2021, Oleksandr wrote: > On 28.01.21 13:21, Jan Beulich wrote: > > On 28.01.2021 12:01, Oleksandr wrote: > > > On 27.01.21 22:46, Stefano Stabellini wrote: > > > > On Wed, 27 Jan 2021, Oleksandr wrote: > > > > > Thank you. I got a request to make a possibility for user to select > >

[qemu-mainline test] 158714: regressions - FAIL

2021-01-28 Thread osstest service owner
flight 158714 qemu-mainline real [real] flight 158734 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/158714/ http://logs.test-lab.xenproject.org/osstest/logs/158734/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: more randconfig failures

2021-01-28 Thread Rahul Singh
Hello Julien, > On 28 Jan 2021, at 4:34 pm, Julien Grall wrote: > > On 27/01/2021 23:11, Rahul Singh wrote: >> Hello Julien, > > Hi Rahul, > >>> On 27 Jan 2021, at 9:25 pm, Julien Grall wrote: >>> >>> Hi, >>> >>> On Wed, 27 Jan 2021 at 21:16, Stefano Stabellini >>> wrote: Hi al

Re: [RFC PATCH 26/34] xfs: use bio_new in xfs_rw_bdev

2021-01-28 Thread Darrick J. Wong
On Wed, Jan 27, 2021 at 11:11:25PM -0800, Chaitanya Kulkarni wrote: > Signed-off-by: Chaitanya Kulkarni Seems fine to me... Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_bio_io.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/xfs/xfs_bio_io.c b/fs/xf

Re: [RFC PATCH 27/34] xfs: use bio_new in xfs_buf_ioapply_map

2021-01-28 Thread Darrick J. Wong
On Wed, Jan 27, 2021 at 11:11:26PM -0800, Chaitanya Kulkarni wrote: > Signed-off-by: Chaitanya Kulkarni Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_buf.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c > index f8400bb

Re: [RFC PATCH 18/34] iomap: use bio_new in iomap_dio_bio_actor

2021-01-28 Thread Darrick J. Wong
On Wed, Jan 27, 2021 at 11:11:17PM -0800, Chaitanya Kulkarni wrote: > Signed-off-by: Chaitanya Kulkarni > --- > fs/iomap/direct-io.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > index f6c557a1bd25..0737192f7e5c 100644

Re: [PATCH V5 00/22] IOREQ feature (+ virtio-mmio) on Arm

2021-01-28 Thread Stefano Stabellini
On Thu, 28 Jan 2021, Julien Grall wrote: > On 25/01/2021 19:08, Oleksandr Tyshchenko wrote: > > Patch series [8] was rebased on recent "staging branch" > > (5e31789 tools/ocaml/libs/xb: Do not crash after xenbus is unmapped) and > > tested on > > Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) wit

Re: [PATCH V5 00/22] IOREQ feature (+ virtio-mmio) on Arm

2021-01-28 Thread Julien Grall
On 28/01/2021 17:24, Stefano Stabellini wrote: On Thu, 28 Jan 2021, Julien Grall wrote: On 25/01/2021 19:08, Oleksandr Tyshchenko wrote: > Patch series [8] was rebased on recent "staging branch" (5e31789 tools/ocaml/libs/xb: Do not crash after xenbus is unmapped) and tested on Renesas Salv

Re: more randconfig failures

2021-01-28 Thread Julien Grall
On 28/01/2021 16:46, Jan Beulich wrote: On 28.01.2021 17:34, Julien Grall wrote: On 27/01/2021 23:11, Rahul Singh wrote: Hello Julien, Hi Rahul, On 27 Jan 2021, at 9:25 pm, Julien Grall wrote: Hi, On Wed, 27 Jan 2021 at 21:16, Stefano Stabellini wrote: Hi all, These are two recent

Re: [PATCH V5 14/22] arm/ioreq: Introduce arch specific bits for IOREQ/DM features

2021-01-28 Thread Oleksandr
On 28.01.21 17:08, Julien Grall wrote: Hi Julien On 28/01/2021 14:52, Oleksandr wrote: On 28.01.21 16:41, Julien Grall wrote: On 28/01/2021 14:29, Oleksandr wrote: On 28.01.21 15:39, Oleksandr wrote: On 28.01.21 13:33, Oleksandr wrote: Hi Julien On 28.01.21 11:40, Julien Grall wro

[xen-unstable-smoke test] 158728: regressions - FAIL

2021-01-28 Thread osstest service owner
flight 158728 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/158728/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 158713 Tests which

Re: [PATCH V5 00/22] IOREQ feature (+ virtio-mmio) on Arm

2021-01-28 Thread Oleksandr
On 28.01.21 17:14, Julien Grall wrote: Hi Julien Hi, On 28/01/2021 14:37, Oleksandr wrote: On 27.01.21 19:45, Oleksandr wrote: On 27.01.21 19:42, Julien Grall wrote: Hi On 27/01/2021 17:37, Oleksandr wrote: On 27.01.21 19:33, Julien Grall wrote: Hi Julien On 27/01/2021 16:50,

Re: [PATCH V5 00/22] IOREQ feature (+ virtio-mmio) on Arm

2021-01-28 Thread Andrew Cooper
On 28/01/2021 17:44, Julien Grall wrote: > > > On 28/01/2021 17:24, Stefano Stabellini wrote: >> On Thu, 28 Jan 2021, Julien Grall wrote: >>> On 25/01/2021 19:08, Oleksandr Tyshchenko wrote: >>>   > Patch series [8] was rebased on recent "staging branch" (5e31789 tools/ocaml/libs/xb: Do not cr

  1   2   >