Re: [PATCH v3 5/8] xen/hypfs: add support for id-based dynamic directories

2021-01-18 Thread Jan Beulich
On 18.01.2021 08:25, Jürgen Groß wrote: > On 18.12.20 10:09, Jan Beulich wrote: >> On 18.12.2020 09:57, Jürgen Groß wrote: >>> On 17.12.20 13:14, Jan Beulich wrote: On 17.12.2020 12:32, Jürgen Groß wrote: > On 17.12.20 12:28, Jan Beulich wrote: >> On 09.12.2020 17:09, Juergen Gross wro

RE: [PATCH V4 01/24] x86/ioreq: Prepare IOREQ feature for making it common

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Oleksandr Tyshchenko > Sent: 12 January 2021 21:52 > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko ; Paul Durrant > ; Jan Beulich > ; Andrew Cooper ; Roger Pau > Monné > ; Wei Liu ; Julien Grall > ; Stefano Stabellini > ; Julien Grall > Subj

Re: [PATCH v3 1/7] xen/gnttab: Rework resource acquisition

2021-01-18 Thread Jan Beulich
On 15.01.2021 17:57, Andrew Cooper wrote: > On 15/01/2021 11:56, Jan Beulich wrote: >>> +/* Grow table if necessary. */ >>> +grant_write_lock(gt); >>> +rc = -EINVAL; >>> +switch ( id ) >>> +{ >>> +case XENMEM_resource_grant_table_id_shared: >>> +vaddrs = gt->shared_r

RE: [PATCH V4 02/24] x86/ioreq: Add IOREQ_STATUS_* #define-s and update code for moving

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of > Oleksandr Tyshchenko > Sent: 12 January 2021 21:52 > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko ; Paul Durrant > ; Jan Beulich > ; Andrew Cooper ; Roger Pau > Monné > ; Wei Liu ; Julien Grall > ; Stefano Stabellin

RE: [PATCH V4 03/24] x86/ioreq: Provide out-of-line wrapper for the handle_mmio()

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of > Oleksandr Tyshchenko > Sent: 12 January 2021 21:52 > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko ; Paul Durrant > ; Jan Beulich > ; Andrew Cooper ; Roger Pau > Monné > ; Wei Liu ; Julien Grall > ; Stefano Stabellin

Re: [PATCH V4 24/24] [RFC] libxl: Add support for virtio-disk configuration

2021-01-18 Thread Oleksandr
On 16.01.21 00:01, Julien Grall wrote: Hi Oleksandr, Hi Julien On 12/01/2021 21:52, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko This patch adds basic support for configuring and assisting virtio-disk backend (emualator) which is intended to run out of Qemu and could be run

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-18 Thread Roger Pau Monné
On Sat, Jan 16, 2021 at 12:25:02PM +0100, Manuel Bouyer wrote: > On Sat, Jan 16, 2021 at 11:16:06AM +0100, Roger Pau Monné wrote: > > On Tue, Jan 12, 2021 at 07:12:37PM +0100, Manuel Bouyer wrote: > > > From: Manuel Bouyer > > > > > > Pass bridge name to qemu as command line option > > > When sta

RE: [PATCH V4 04/24] xen/ioreq: Make x86's IOREQ feature common

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Oleksandr Tyshchenko > Sent: 12 January 2021 21:52 > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko ; Andrew Cooper > ; > George Dunlap ; Ian Jackson ; > Jan Beulich > ; Julien Grall ; Stefano Stabellini > ; Wei > Liu ; Roger Pau Monné ; Paul

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-18 Thread Manuel Bouyer
On Mon, Jan 18, 2021 at 09:36:42AM +0100, Roger Pau Monné wrote: > On Sat, Jan 16, 2021 at 12:25:02PM +0100, Manuel Bouyer wrote: > > On Sat, Jan 16, 2021 at 11:16:06AM +0100, Roger Pau Monné wrote: > > > On Tue, Jan 12, 2021 at 07:12:37PM +0100, Manuel Bouyer wrote: > > > > From: Manuel Bouyer >

RE: [PATCH V4 07/24] xen/ioreq: Make x86's hvm_ioreq_(page/vcpu/server) structs common

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of > Oleksandr Tyshchenko > Sent: 12 January 2021 21:52 > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko ; Paul Durrant > ; Jan Beulich > ; Andrew Cooper ; Roger Pau > Monné > ; Wei Liu ; George Dunlap > ; Julien Grall > ;

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-18 Thread Roger Pau Monné
On Mon, Jan 18, 2021 at 09:52:14AM +0100, Manuel Bouyer wrote: > On Mon, Jan 18, 2021 at 09:36:42AM +0100, Roger Pau Monné wrote: > > I also wonder why NetBSD needs to add the tap interface to the bridge > > in the QEMU script instead of doing it from the hotplug script called > > by libxl, like Li

RE: [PATCH V4 08/24] xen/ioreq: Move x86's ioreq_server to struct domain

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of > Oleksandr Tyshchenko > Sent: 12 January 2021 21:52 > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko ; Paul Durrant > ; Andrew Cooper > ; George Dunlap ; Ian > Jackson > ; Jan Beulich ; Julien Grall > ; Stefano > Stabe

Re: [PATCH] x86/mem_sharing: silence ubsan warning

2021-01-18 Thread Jan Beulich
On 18.01.2021 02:38, Tamas K Lengyel wrote: > On Mon, Jan 4, 2021 at 12:21 PM Tamas K Lengyel wrote: >> >> On Mon, Jan 4, 2021 at 7:31 AM Andrew Cooper >> wrote: >>> >>> On 03/01/2021 18:47, Tamas K Lengyel wrote: Running Xen compiled with UBSAN produces a warning for mismatched size.

RE: [PATCH V4 09/24] xen/ioreq: Make x86's IOREQ related dm-op handling common

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of > Oleksandr Tyshchenko > Sent: 12 January 2021 21:52 > To: xen-devel@lists.xenproject.org > Cc: Julien Grall ; Jan Beulich ; > Andrew Cooper > ; Roger Pau Monné ; Wei Liu > ; George > Dunlap ; Ian Jackson ; Julien > Grall ; > Stefano

[libvirt test] 158485: regressions - FAIL

2021-01-18 Thread osstest service owner
flight 158485 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/158485/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-18 Thread Manuel Bouyer
On Mon, Jan 18, 2021 at 10:07:22AM +0100, Roger Pau Monné wrote: > On Mon, Jan 18, 2021 at 09:52:14AM +0100, Manuel Bouyer wrote: > > On Mon, Jan 18, 2021 at 09:36:42AM +0100, Roger Pau Monné wrote: > > > I also wonder why NetBSD needs to add the tap interface to the bridge > > > in the QEMU script

Re: [PATCH] xen/arm: livepatch: Include xen/mm.h rather than asm/mm.h

2021-01-18 Thread Jan Beulich
On 15.01.2021 20:29, Julien Grall wrote: > From: Julien Grall > > Livepatch fails to build on Arm after commit ced9795c6cb4 "mm: split > out mfn_t / gfn_t / pfn_t definitions and helpers": > > In file included from livepatch.c:13:0: > /oss/xen/xen/include/asm/mm.h:32:28: error: field ‘list’ has

Re: [PATCH v2 4/8] tools/ocaml/xenstored: only quit on SIGTERM when a reload is possible

2021-01-18 Thread Edwin Torok
On Mon, 2021-01-18 at 08:51 +0100, Jürgen Groß wrote: > On 15.01.21 23:28, Edwin Török wrote: > > Currently when oxenstored receives SIGTERM it dumps its state and > > quits. > > It is possible to then restart it if --restart is given, however > > that is > > not always safe: > > > > * domains cou

Re: [PATCH 1/3] introduce unaligned.h

2021-01-18 Thread Jan Beulich
On 15.01.2021 12:27, Jan Beulich wrote: > On 15.01.2021 12:13, Andrew Cooper wrote: >> On 15/01/2021 10:05, Jan Beulich wrote: >>> Rather than open-coding commonly used constructs in yet more places when >>> pulling in zstd decompression support (and its xxhash prereq), pull out >>> the custom bits

RE: [PATCH V4 10/24] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Oleksandr Tyshchenko > Sent: 12 January 2021 21:52 > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko ; Paul Durrant > ; Jan Beulich > ; Andrew Cooper ; Roger Pau > Monné > ; Wei Liu ; George Dunlap > ; Ian Jackson > ; Julien Grall ; Stefano Sta

RE: [PATCH V4 11/24] xen/mm: Make x86's XENMEM_resource_ioreq_server handling common

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of > Oleksandr Tyshchenko > Sent: 12 January 2021 21:52 > To: xen-devel@lists.xenproject.org > Cc: Julien Grall ; Jan Beulich ; > Andrew Cooper > ; Roger Pau Monné ; Wei Liu > ; George > Dunlap ; Ian Jackson ; Julien > Grall ; > Stefano

Re: [PATCH v2 1/8] tools/xenstore: add live update command to xenstore-control

2021-01-18 Thread Edwin Torok
On Mon, 2021-01-18 at 08:50 +0100, Jürgen Groß wrote: > On 15.01.21 23:28, Edwin Török wrote: > > From: Juergen Gross > > > > Add the "live-update" command to xenstore-control enabling updating > > xenstored to a new version in a running Xen system. > > > > With -c it is possible to pass a diff

Re: [PATCH 1/3] introduce unaligned.h

2021-01-18 Thread Jan Beulich
On 18.01.2021 10:33, Jan Beulich wrote: > On 15.01.2021 12:27, Jan Beulich wrote: >> On 15.01.2021 12:13, Andrew Cooper wrote: >>> On 15/01/2021 10:05, Jan Beulich wrote: Rather than open-coding commonly used constructs in yet more places when pulling in zstd decompression support (and it

RE: [PATCH V4 12/24] xen/ioreq: Remove "hvm" prefixes from involved function names

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Oleksandr Tyshchenko > Sent: 12 January 2021 21:52 > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko ; Jan Beulich > ; Andrew > Cooper ; Roger Pau Monné ; > Wei Liu ; > George Dunlap ; Ian Jackson ; > Julien Grall > ; Stefano Stabellini ; Paul

RE: [PATCH V4 13/24] xen/ioreq: Use guest_cmpxchg64() instead of cmpxchg()

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of > Oleksandr Tyshchenko > Sent: 12 January 2021 21:52 > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko ; Paul Durrant > ; Julien Grall > ; Stefano Stabellini ; Julien Grall > > Subject: [PATCH V4 13/24] xen/ioreq: Use gu

Re: XSA-332 kernel patch - huge network performance on pfSense VMs

2021-01-18 Thread Roger Pau Monné
On Fri, Jan 15, 2021 at 03:03:26PM +, Samuel Verschelde wrote: > Hi list, > > Another "popular" thread on XCP-ng forum [1], started in october 2020, > allowed us to detect that patch 12 from the XSA-332 advisory [2] had a very > significant impact on network performance in the case of pfSense

Re: [PATCH V4 09/24] xen/ioreq: Make x86's IOREQ related dm-op handling common

2021-01-18 Thread Oleksandr
On 18.01.21 11:17, Paul Durrant wrote: Hi Paul -Original Message- From: Xen-devel On Behalf Of Oleksandr Tyshchenko Sent: 12 January 2021 21:52 To: xen-devel@lists.xenproject.org Cc: Julien Grall ; Jan Beulich ; Andrew Cooper ; Roger Pau Monné ; Wei Liu ; George Dunlap ; Ian Jac

Re: Xen VM call trace on fstrim: Error: discard_granularity is 0.

2021-01-18 Thread Roger Pau Monné
On Wed, Jan 13, 2021 at 11:43:50AM +0100, Arthur Borsboom wrote: > When performing the following command in a Xen VM the call trace below is > generated. > > sudo fstrim -v / > > Xen VM host: Xen 4.14.0 > Xen Dom0: Linux 4.19.14 > Xen DomX: Linux 5.10.6 > > The code in the kernel triggering

RE: [PATCH V4 17/24] xen/ioreq: Introduce domain_has_ioreq_server()

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of > Oleksandr Tyshchenko > Sent: 12 January 2021 21:52 > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko ; Stefano Stabellini > ; > Julien Grall ; Volodymyr Babchuk > ; Paul Durrant > ; Julien Grall > Subject: [PATCH V4 17

RE: [PATCH V4 21/24] xen/ioreq: Make x86's send_invalidate_req() common

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of > Oleksandr Tyshchenko > Sent: 12 January 2021 21:52 > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko ; Jan Beulich > ; Andrew > Cooper ; Roger Pau Monné ; > Wei Liu ; > George Dunlap ; Ian Jackson ; > Julien Grall > ;

RE: [PATCH V4 09/24] xen/ioreq: Make x86's IOREQ related dm-op handling common

2021-01-18 Thread Paul Durrant
> -Original Message- [snip] > >> diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c > >> index a319c88..72b5da0 100644 > >> --- a/xen/common/ioreq.c > >> +++ b/xen/common/ioreq.c > >> @@ -591,8 +591,8 @@ static void hvm_ioreq_server_deinit(struct > >> ioreq_server *s) > >> put_doma

Re: [PATCH 1/3] introduce unaligned.h

2021-01-18 Thread Julien Grall
Hi Jan, On 15/01/2021 11:29, Jan Beulich wrote: On 15.01.2021 12:13, Andrew Cooper wrote: On 15/01/2021 10:05, Jan Beulich wrote: Rather than open-coding commonly used constructs in yet more places when pulling in zstd decompression support (and its xxhash prereq), pull out the custom bits int

RE: [PATCH 2/7] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Lee Jones > Sent: 15 January 2021 20:09 > To: lee.jo...@linaro.org > Cc: linux-ker...@vger.kernel.org; Wei Liu ; Paul Durrant > ; David S. > Miller ; Jakub Kicinski ; Alexei > Starovoitov ; > Daniel Borkmann ; Jesper Dangaard Brouer > ; John Fastabend > ; Ru

Re: [PATCH V4 14/24] arm/ioreq: Introduce arch specific bits for IOREQ/DM features

2021-01-18 Thread Jan Beulich
On 17.01.2021 18:11, Oleksandr wrote: > On 15.01.21 22:26, Julien Grall wrote: >> On 12/01/2021 21:52, Oleksandr Tyshchenko wrote: >>> --- a/xen/arch/arm/io.c >>> +++ b/xen/arch/arm/io.c >>> @@ -16,6 +16,7 @@ >>>    * GNU General Public License for more details. >>>    */ >>>   +#include >>>   #in

Re: [PATCH 1/3] introduce unaligned.h

2021-01-18 Thread Julien Grall
Hi Jan, On 18/01/2021 09:33, Jan Beulich wrote: On 15.01.2021 12:27, Jan Beulich wrote: On 15.01.2021 12:13, Andrew Cooper wrote: On 15/01/2021 10:05, Jan Beulich wrote: Rather than open-coding commonly used constructs in yet more places when pulling in zstd decompression support (and its xxh

Re: Xen VM call trace on fstrim: Error: discard_granularity is 0.

2021-01-18 Thread Roger Pau Monné
On Mon, Jan 18, 2021 at 11:25:49AM +0100, Arthur Borsboom wrote: > Find attached the output of xenstore-ls Thanks, that's very helpful. I think this is ude to QEMU not writing the discard-aligment node, which leads to blkfront only setting the discard feature partially. Could you give a try to th

Re: [PATCH V4 15/24] xen/arm: Stick around in leave_hypervisor_to_guest until I/O has completed

2021-01-18 Thread Julien Grall
Hi Oleksandr, On 17/01/2021 20:23, Oleksandr wrote: On 15.01.21 22:55, Julien Grall wrote: So we need to check if the I/O has completed and wait again if it hasn't (we will block the vCPU again until an event is received). This loop makes sure that all the vCPU works are done before we return

Re: [PATCH 1/3] introduce unaligned.h

2021-01-18 Thread Jan Beulich
On 18.01.2021 11:45, Julien Grall wrote: > On 18/01/2021 09:33, Jan Beulich wrote: >> On 15.01.2021 12:27, Jan Beulich wrote: >>> On 15.01.2021 12:13, Andrew Cooper wrote: On 15/01/2021 10:05, Jan Beulich wrote: > Rather than open-coding commonly used constructs in yet more places when >>>

Re: [PATCH] x86/CPUID: unconditionally set XEN_HVM_CPUID_IOMMU_MAPPINGS

2021-01-18 Thread Jan Beulich
On 15.01.2021 16:01, Roger Pau Monne wrote: > This is a revert of f5cfa0985673 plus a rework of the comment that > accompanies the setting of the flag so we don't forget why it needs to > be unconditionally set: it's indicating whether the version of Xen has > the original issue fixed and IOMMU ent

[PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Jan Beulich
The individual decompression CUs need to only surface their top level functions to other code. Arrange for everything else to be static, to make sure no undue uses of that code exist or will appear without explicitly noticing. (In some cases this also results in code size reduction, but since this

[xen-unstable test] 158480: tolerable FAIL

2021-01-18 Thread osstest service owner
flight 158480 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/158480/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-examine4 memdisk-try-append fail in 158467 pass in 158480 test-amd64-i386-xl-qemut-debianh

[PATCH v4 5/5] xen/cpupool: make per-cpupool sched-gran hypfs node writable

2021-01-18 Thread Juergen Gross
Make /cpupool//sched-gran in hypfs writable. This will enable per cpupool selectable scheduling granularity. Writing this node is allowed only with no cpu assigned to the cpupool. Allowed are values "cpu", "core" and "socket". Signed-off-by: Juergen Gross --- V2: - test user parameters earlier (

[PATCH v4 2/5] xen/hypfs: add support for id-based dynamic directories

2021-01-18 Thread Juergen Gross
Add some helpers to hypfs.c to support dynamic directories with a numerical id as name. The dynamic directory is based on a template specified by the user allowing to use specific access functions and having a predefined set of entries in the directory. Signed-off-by: Juergen Gross --- V2: - use

[PATCH v4 0/5] xen: support per-cpupool scheduling granularity

2021-01-18 Thread Juergen Gross
Support scheduling granularity per cpupool. Setting the granularity is done via hypfs, which needed to gain dynamical entries for that purpose. Apart from the hypfs related additional functionality the main change for cpupools was the support for moving a domain to a new granularity, as this requi

[PATCH v4 3/5] xen/cpupool: add cpupool directories

2021-01-18 Thread Juergen Gross
Add /cpupool/ directories to hypfs. Those are completely dynamic, so the related hypfs access functions need to be implemented. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Reviewed-by: Dario Faggioli --- V2: - added const (Jan Beulich) - call hypfs_add_dir() in helper (Dario Faggioli)

[PATCH v4 4/5] xen/cpupool: add scheduling granularity entry to cpupool entries

2021-01-18 Thread Juergen Gross
Add a "sched-gran" entry to the per-cpupool hypfs directories. For now make this entry read-only and let it contain one of the strings "cpu", "core" or "socket". Signed-off-by: Juergen Gross --- V2: - added const (Jan Beulich) - modify test in cpupool_gran_read() (Jan Beulich) --- docs/misc/hyp

[PATCH v4 1/5] xen/hypfs: support dynamic hypfs nodes

2021-01-18 Thread Juergen Gross
Add a HYPFS_VARDIR_INIT() macro for initializing such a directory statically, taking a struct hypfs_funcs pointer as parameter additional to those of HYPFS_DIR_INIT(). Modify HYPFS_VARSIZE_INIT() to take the function vector pointer as an additional parameter as this will be needed for dynamical en

Re: [PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Andrew Cooper
On 18/01/2021 11:19, Jan Beulich wrote: > The individual decompression CUs need to only surface their top level > functions to other code. Arrange for everything else to be static, to > make sure no undue uses of that code exist or will appear without > explicitly noticing. (In some cases this also

[PATCH] tools/libxenhypfs: fix reading of gzipped string

2021-01-18 Thread Juergen Gross
Reading a gzipped string value from hypfs doesn't add a 0 byte at the end. Fix that. Fixes: 86234eafb95295 ("libs: add libxenhypfs") Signed-off-by: Juergen Gross --- tools/libs/hypfs/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/libs/hypfs/core.c b/tools/libs

[ovmf test] 158484: all pass - PUSHED

2021-01-18 Thread osstest service owner
flight 158484 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/158484/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a7ef2a03b96c464c776a139c104471fb2b84e39b baseline version: ovmf c88736f8605eab3b0877d

Re: [PATCH V4 15/24] xen/arm: Stick around in leave_hypervisor_to_guest until I/O has completed

2021-01-18 Thread Oleksandr
On 18.01.21 12:57, Julien Grall wrote: Hi Oleksandr, Hi Julien On 17/01/2021 20:23, Oleksandr wrote: On 15.01.21 22:55, Julien Grall wrote: So we need to check if the I/O has completed and wait again if it hasn't (we will block the vCPU again until an event is received). This loop ma

Re: [PATCH] tools/libxenhypfs: fix reading of gzipped string

2021-01-18 Thread Andrew Cooper
On 18/01/2021 12:06, Juergen Gross wrote: > Reading a gzipped string value from hypfs doesn't add a 0 byte at the > end. Fix that. > > Fixes: 86234eafb95295 ("libs: add libxenhypfs") > Signed-off-by: Juergen Gross Acked-by: Andrew Cooper > --- > tools/libs/hypfs/core.c | 3 ++- > 1 file change

Re: [PATCH] x86/mem_sharing: silence ubsan warning

2021-01-18 Thread Tamas K Lengyel
On Mon, Jan 18, 2021 at 4:10 AM Jan Beulich wrote: > > On 18.01.2021 02:38, Tamas K Lengyel wrote: > > On Mon, Jan 4, 2021 at 12:21 PM Tamas K Lengyel wrote: > >> > >> On Mon, Jan 4, 2021 at 7:31 AM Andrew Cooper > >> wrote: > >>> > >>> On 03/01/2021 18:47, Tamas K Lengyel wrote: > Running

[PATCH for <= 5.4] xen/privcmd: allow fetching resource sizes

2021-01-18 Thread Roger Pau Monne
commit ef3a575baf53571dc405ee4028e26f50856898e7 upstream Allow issuing an IOCTL_PRIVCMD_MMAP_RESOURCE ioctl with num = 0 and addr = 0 in order to fetch the size of a specific resource. Add a shortcut to the default map resource path, since fetching the size requires no address to be passed in, an

[PATCH] xen/domain: Reposition config copying in domain_create()

2021-01-18 Thread Andrew Cooper
This is cleanup for two pending series which will copy more data than just flags from config. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk The series in question are my fault-ttl series, and M

[PATCH] xen/xsm: Improve alloc/free of evtchn buckets

2021-01-18 Thread Andrew Cooper
Currently, flask_alloc_security_evtchn() is called in loops of 64 (EVTCHNS_PER_BUCKET), which for non-dummy implementations is a function pointer call even in the no-op case. The non no-op case only sets a single constant, and doesn't actually fail. Spectre v2 protections has made function pointe

Re: [PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Jan Beulich
On 18.01.2021 12:58, Andrew Cooper wrote: > On 18/01/2021 11:19, Jan Beulich wrote: >> The individual decompression CUs need to only surface their top level >> functions to other code. Arrange for everything else to be static, to >> make sure no undue uses of that code exist or will appear without

[PATCH] xen-blkfront: don't make discard-alignment mandatory

2021-01-18 Thread Roger Pau Monne
Don't require the discard-alignment xenstore node to be present in order to correctly setup the feature. This can happen with versions of QEMU that only write the discard-granularity but not the discard-alignment node. Assume discard-alignment is 0 if not present. While there also fix the logic to

[qemu-mainline test] 158481: regressions - FAIL

2021-01-18 Thread osstest service owner
flight 158481 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/158481/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 152631 test-amd64-amd64

Re: [PATCH] xen/domain: Reposition config copying in domain_create()

2021-01-18 Thread Jan Beulich
On 18.01.2021 15:59, Andrew Cooper wrote: > This is cleanup for two pending series which will copy more data than just > flags from config. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich

Re: [PATCH] xen/xsm: Improve alloc/free of evtchn buckets

2021-01-18 Thread Jan Beulich
On 18.01.2021 16:06, Andrew Cooper wrote: > --- a/xen/common/event_channel.c > +++ b/xen/common/event_channel.c > @@ -147,6 +147,14 @@ static bool virq_is_global(unsigned int virq) > return true; > } > > +static void free_evtchn_bucket(struct domain *d, struct evtchn *bucket) > +{ > +if

Re: [PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Andrew Cooper
On 18/01/2021 15:13, Jan Beulich wrote: > On 18.01.2021 12:58, Andrew Cooper wrote: >> On 18/01/2021 11:19, Jan Beulich wrote: >>> The individual decompression CUs need to only surface their top level >>> functions to other code. Arrange for everything else to be static, to >>> make sure no undue u

Re: [PATCH v4 07/11] xen/arm: bitops: Implement a ffsll function

2021-01-18 Thread Rahul Singh
Hello Julien, > On 15 Jan 2021, at 12:16 pm, Julien Grall wrote: > > Hi Rahul, > > On 08/01/2021 14:46, Rahul Singh wrote: >> Implement the ffsll based on built-in function "__builtin_ffsll()" >> ffsll will return one plus the index of the least significant 1-bit in >> doublewords or if doublew

Re: [PATCH v4 09/11] xen/arm: smmuv3: Use fallthrough pseudo-keyword

2021-01-18 Thread Rahul Singh
Hello Julien, > On 15 Jan 2021, at 12:18 pm, Julien Grall wrote: > > Hi Rahul, > > On 08/01/2021 14:46, Rahul Singh wrote: >> Merge the patch from linux to use fallthrough pseudo-keyword. > > Please add more information about the patch you are backporting. Is it a > clean backport? Ok . I wi

[PATCH] xen-block: fix reporting of discard feature

2021-01-18 Thread Roger Pau Monne
Linux blkfront expects both "discard-granularity" and "discard-alignment" present on xenbus in order to properly enable the feature, not exposing "discard-alignment" left some Linux blkfront versions with a broken discard setup. This has also been addressed in Linux with: https://lore.kernel.org/l

Re: [PATCH v4 11/11] xen/arm: smmuv3: Add support for SMMUv3 driver

2021-01-18 Thread Rahul Singh
Hello Oleksandr, > On 11 Jan 2021, at 4:39 pm, Oleksandr wrote: > > > Hi Rahul > > >>> - >>> static int arm_smmu_device_probe(struct platform_device *pdev) >>> { >>> int irq, ret; >>> -struct resource *res; >>> -resource_size_t ioaddr; >>> +paddr_t ioaddr, iosize; >>>

Re: [PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Jan Beulich
On 18.01.2021 16:31, Andrew Cooper wrote: > On 18/01/2021 15:13, Jan Beulich wrote: >> On 18.01.2021 12:58, Andrew Cooper wrote: >>> but I really would >>> like to see the STATIC and INIT defines disappear eventually. >> I too would like to, but I don't see this happen in particular >> for INIT and

Ping: [PATCH] kconfig: ensure strndup() declaration is visible

2021-01-18 Thread Jan Beulich
Doug, On 11.01.2021 15:42, Jan Beulich wrote: > Its guard was updated such that it is visible by default when POSIX 2008 > was adopted by glibc. It's not visible by default on older glibc. > > Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4") > Signed-off-by: Jan Beulich I've got an ack

[xen-unstable-smoke test] 158488: regressions - FAIL

2021-01-18 Thread osstest service owner
flight 158488 xen-unstable-smoke real [real] flight 158490 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/158488/ http://logs.test-lab.xenproject.org/osstest/logs/158490/ Regressions :-( Tests which did not succeed and are blocking, including tests which co

RE: [PATCH] xen-block: fix reporting of discard feature

2021-01-18 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 18 January 2021 15:34 > To: qemu-de...@nongnu.org > Cc: Roger Pau Monne ; Arthur Borsboom > ; Stefano > Stabellini ; Anthony Perard > ; Paul Durrant > ; Kevin Wolf ; Max Reitz ; > xen- > de...@lists.xenproject.org; qemu-bl...@nongnu.o

Re: [PATCH V4 14/24] arm/ioreq: Introduce arch specific bits for IOREQ/DM features

2021-01-18 Thread Oleksandr
On 18.01.21 12:44, Jan Beulich wrote: Hi Jan On 17.01.2021 18:11, Oleksandr wrote: On 15.01.21 22:26, Julien Grall wrote: On 12/01/2021 21:52, Oleksandr Tyshchenko wrote: --- a/xen/arch/arm/io.c +++ b/xen/arch/arm/io.c @@ -16,6 +16,7 @@    * GNU General Public License for more details.  

Re: [PATCH] x86/CPUID: unconditionally set XEN_HVM_CPUID_IOMMU_MAPPINGS

2021-01-18 Thread Roger Pau Monné
On Mon, Jan 18, 2021 at 12:05:12PM +0100, Jan Beulich wrote: > On 15.01.2021 16:01, Roger Pau Monne wrote: > > This is a revert of f5cfa0985673 plus a rework of the comment that > > accompanies the setting of the flag so we don't forget why it needs to > > be unconditionally set: it's indicating wh

Re: [PATCH V4 14/24] arm/ioreq: Introduce arch specific bits for IOREQ/DM features

2021-01-18 Thread Jan Beulich
On 18.01.2021 16:52, Oleksandr wrote: > On 18.01.21 12:44, Jan Beulich wrote: >> On 17.01.2021 18:11, Oleksandr wrote: >>> On 15.01.21 22:26, Julien Grall wrote: On 12/01/2021 21:52, Oleksandr Tyshchenko wrote: > --- a/xen/arch/arm/io.c > +++ b/xen/arch/arm/io.c > @@ -16,6 +16,7 @@

Re: [PATCH] x86/CPUID: unconditionally set XEN_HVM_CPUID_IOMMU_MAPPINGS

2021-01-18 Thread Jan Beulich
On 18.01.2021 16:54, Roger Pau Monné wrote: > On Mon, Jan 18, 2021 at 12:05:12PM +0100, Jan Beulich wrote: >> On 15.01.2021 16:01, Roger Pau Monne wrote: >>> This is a revert of f5cfa0985673 plus a rework of the comment that >>> accompanies the setting of the flag so we don't forget why it needs to

Re: [PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Ian Jackson
Jan Beulich writes ("[PATCH] xen/decompress: make helper symbols static"): > The individual decompression CUs need to only surface their top level > functions to other code. Arrange for everything else to be static, to > make sure no undue uses of that code exist or will appear without > explicitly

Re: [xen-unstable-smoke test] 158488: regressions - FAIL

2021-01-18 Thread Jan Beulich
On 18.01.2021 16:43, osstest service owner wrote: > flight 158488 xen-unstable-smoke real [real] > flight 158490 xen-unstable-smoke real-retest [real] > http://logs.test-lab.xenproject.org/osstest/logs/158488/ > http://logs.test-lab.xenproject.org/osstest/logs/158490/ > > Regressions :-( > > Test

Re: [PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Andrew Cooper
On 18/01/2021 16:09, Ian Jackson wrote: > Jan Beulich writes ("[PATCH] xen/decompress: make helper symbols static"): >> The individual decompression CUs need to only surface their top level >> functions to other code. Arrange for everything else to be static, to >> make sure no undue uses of that c

Re: [PATCH] xen/decompress: make helper symbols static

2021-01-18 Thread Jan Beulich
On 18.01.2021 17:09, Ian Jackson wrote: > Jan Beulich writes ("[PATCH] xen/decompress: make helper symbols static"): >> The individual decompression CUs need to only surface their top level >> functions to other code. Arrange for everything else to be static, to >> make sure no undue uses of that c

Re: [PATCH v4 11/11] xen/arm: smmuv3: Add support for SMMUv3 driver

2021-01-18 Thread Oleksandr
On 18.01.21 17:33, Rahul Singh wrote: Hello Oleksandr, On 11 Jan 2021, at 4:39 pm, Oleksandr wrote: Hi Rahul Hi Rahul - static int arm_smmu_device_probe(struct platform_device *pdev) { int irq, ret; -struct resource *res; -resource_size_t ioaddr; +paddr_t i

Re: [PATCH] xen/xsm: Improve alloc/free of evtchn buckets

2021-01-18 Thread Andrew Cooper
On 18/01/2021 15:31, Jan Beulich wrote: > On 18.01.2021 16:06, Andrew Cooper wrote: >> --- a/xen/common/event_channel.c >> +++ b/xen/common/event_channel.c >> @@ -147,6 +147,14 @@ static bool virq_is_global(unsigned int virq) >> return true; >> } >> >> +static void free_evtchn_bucket(struct

[linux-linus test] 158482: regressions - FAIL

2021-01-18 Thread osstest service owner
flight 158482 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/158482/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qem

Re: [PATCH V4 14/24] arm/ioreq: Introduce arch specific bits for IOREQ/DM features

2021-01-18 Thread Oleksandr
On 18.01.21 18:00, Jan Beulich wrote: Hi Jan On 18.01.2021 16:52, Oleksandr wrote: On 18.01.21 12:44, Jan Beulich wrote: On 17.01.2021 18:11, Oleksandr wrote: On 15.01.21 22:26, Julien Grall wrote: On 12/01/2021 21:52, Oleksandr Tyshchenko wrote: --- a/xen/arch/arm/io.c +++ b/xen/arch/ar

Re: IRQ latency measurements in hypervisor

2021-01-18 Thread Dario Faggioli
On Thu, 2021-01-14 at 15:33 -0800, Stefano Stabellini wrote: > On Tue, 12 Jan 2021, Volodymyr Babchuk wrote: > > 2. RTDS scheduler. With console disabled, things like "hexdump -v > >    /dev/zero" didn't affected the latency so badly, but anyways, > >    sometimes I got ~600us spikes. This is not a

Re: [PATCH v4 11/11] xen/arm: smmuv3: Add support for SMMUv3 driver

2021-01-18 Thread Rahul Singh
Hello Oleksandr, > On 18 Jan 2021, at 4:20 pm, Oleksandr wrote: > > > On 18.01.21 17:33, Rahul Singh wrote: >> Hello Oleksandr, >> >>> On 11 Jan 2021, at 4:39 pm, Oleksandr wrote: >>> >>> >>> Hi Rahul > > Hi Rahul > > >>> >>> > - > static int arm_smmu_device_probe(struct plat

Re: [PATCH] x86/CPUID: unconditionally set XEN_HVM_CPUID_IOMMU_MAPPINGS

2021-01-18 Thread Roger Pau Monné
On Mon, Jan 18, 2021 at 05:04:19PM +0100, Jan Beulich wrote: > On 18.01.2021 16:54, Roger Pau Monné wrote: > > On Mon, Jan 18, 2021 at 12:05:12PM +0100, Jan Beulich wrote: > >> On 15.01.2021 16:01, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/traps.c > >>> +++ b/xen/arch/x86/traps.c > >>> @@ -10

Re: [PATCH] kconfig: ensure strndup() declaration is visible

2021-01-18 Thread Doug Goldstein
On 1/11/21 8:42 AM, Jan Beulich wrote: Its guard was updated such that it is visible by default when POSIX 2008 was adopted by glibc. It's not visible by default on older glibc. Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4") Signed-off-by: Jan Beulich --- a/xen/tools/kconfig/parser.

[PATCH] x86/mem_sharing: fix uninitialized 'preempted' variable

2021-01-18 Thread Tamas K Lengyel
UBSAN catches an uninitialized use of the 'preempted' variable in fork_hap_allocation when there is no preemption. Signed-off-by: Tamas K Lengyel --- xen/arch/x86/mm/mem_sharing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/

Re: [PATCH] x86/mem_sharing: fix uninitialized 'preempted' variable

2021-01-18 Thread Andrew Cooper
On 18/01/2021 17:23, Tamas K Lengyel wrote: > UBSAN catches an uninitialized use of the 'preempted' variable in > fork_hap_allocation when there is no preemption. Fixes: 41548c5472a ("mem_sharing: VM forking") > Signed-off-by: Tamas K Lengyel Acked-by: Andrew Cooper

Re: [PATCH] libs/light: Switch NetBSD to QEMU_XEN

2021-01-18 Thread Roger Pau Monné
On Tue, Jan 12, 2021 at 07:12:33PM +0100, Manuel Bouyer wrote: > From: Manuel Bouyer > > Switch NetBSD to QEMU_XEN. > All 3 versions of libxl__default_device_model() now return > LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN, so remove it and just set > b_info->device_model_version to LIBXL_DEVICE_MODEL_VE

Re: [PATCH V4 11/24] xen/mm: Make x86's XENMEM_resource_ioreq_server handling common

2021-01-18 Thread Oleksandr
On 15.01.21 16:35, Alex Bennée wrote: Hi Alex Oleksandr writes: On 14.01.21 05:58, Wei Chen wrote: Hi Oleksandr, Hi Wei @@ -1090,6 +1091,40 @@ static int acquire_grant_table(struct domain *d, unsigned int id, return 0; } +static int acquire_ioreq_server(struct domain *d, +

Re: [PATCH] x86/CPUID: unconditionally set XEN_HVM_CPUID_IOMMU_MAPPINGS

2021-01-18 Thread Andrew Cooper
On 18/01/2021 17:10, Roger Pau Monné wrote: > On Mon, Jan 18, 2021 at 05:04:19PM +0100, Jan Beulich wrote: >> On 18.01.2021 16:54, Roger Pau Monné wrote: >>> On Mon, Jan 18, 2021 at 12:05:12PM +0100, Jan Beulich wrote: On 15.01.2021 16:01, Roger Pau Monne wrote: > --- a/xen/arch/x86/traps.

Re: [PATCH] libs/foreignmemory: Implement on NetBSD

2021-01-18 Thread Roger Pau Monné
On Tue, Jan 12, 2021 at 07:12:31PM +0100, Manuel Bouyer wrote: > From: Manuel Bouyer > > Implement foreignmemory interface on NetBSD. The compat interface is now used > only on __sun__ > > Signed-off-by: Manuel Bouyer > --- > tools/libs/foreignmemory/Makefile | 2 +- > tools/libs/foreignmemo

Re: [PATCH] libs/gnttab: implement on NetBSD

2021-01-18 Thread Roger Pau Monné
On Tue, Jan 12, 2021 at 07:12:32PM +0100, Manuel Bouyer wrote: > From: Manuel Bouyer > > Implement gnttab interface on NetBSD. > The kernel interface is different from FreeBSD so we can't use the FreeBSD > version Since I'm not familiar with the NetBSD interface I can provide much feedback, but

Re: [PATCH] libs/call: fix build on NetBSD

2021-01-18 Thread Roger Pau Monné
On Tue, Jan 12, 2021 at 07:12:29PM +0100, Manuel Bouyer wrote: > From: Manuel Bouyer > > Define PAGE_* if not already defined > Catch up with osdep interface change. > > Signed-off-by: Manuel Bouyer Reviewed-by: Roger Pau Monné Just one comment below, please keep the tag when resending with

Re: [PATCH] libs/evtchn: fix build on NetBSD.

2021-01-18 Thread Roger Pau Monné
On Tue, Jan 12, 2021 at 07:12:30PM +0100, Manuel Bouyer wrote: > From: Manuel Bouyer > > use xenio3.h for ioctl definitions > read_exact/write_exact seems to not be available here, which cause > a gcc error. > Use plain read/write, the xenevtchn interface won't do partial read/write > on NetBSD a

Re: [PATCH] gdbsx: use right path for privcmd

2021-01-18 Thread Roger Pau Monné
On Tue, Jan 12, 2021 at 07:12:28PM +0100, Manuel Bouyer wrote: > From: Manuel Bouyer > > On NetBSD the privcmd interface node is /kern/xen/privcmd > > Signed-off-by: Manuel Bouyer > --- > tools/debugger/gdbsx/xg/xg_main.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > >

Re: [PATCH] xenstat_netbsd: remove usused code

2021-01-18 Thread Roger Pau Monné
On Tue, Jan 12, 2021 at 07:12:42PM +0100, Manuel Bouyer wrote: > From: Manuel Bouyer > > remove PROCNETDEV_HEADER[] and read_attributes_vbd(), gcc complains that they > are unused > > Signed-off-by: Manuel Bouyer Reviewed-by: Roger Pau Monné Thanks, Roger.

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-18 Thread Roger Pau Monné
On Tue, Jan 12, 2021 at 07:12:36PM +0100, Manuel Bouyer wrote: > From: Manuel Bouyer > > NetBSD doesn't have setresuid(). Add a configure check for it, > and use plain setuid() if !HAVE_SETRESUID > > Signed-off-by: Manuel Bouyer LGTM from a code PoV, but I think George/Ian should take a look,

Re: [PATCH] libs/store: make build without PTHREAD_STACK_MIN

2021-01-18 Thread Roger Pau Monné
On Tue, Jan 12, 2021 at 07:12:38PM +0100, Manuel Bouyer wrote: > From: Manuel Bouyer > > On NetBSD, PTHREAD_STACK_MIN is not available. > Just use DEFAULT_THREAD_STACKSIZE if PTHREAD_STACK_MIN is not available. > > Signed-off-by: Manuel Bouyer Reviewed-by: Roger Pau Monné Thanks, Roger.

Re: [PATCH] libs/light: fix tv_sec printf format

2021-01-18 Thread Roger Pau Monné
On Tue, Jan 12, 2021 at 07:12:34PM +0100, Manuel Bouyer wrote: > From: Manuel Bouyer > > Don't assume tv_sec is a unsigned long, it is 64 bits on NetBSD 32 bits. > Use %jd and cast to (intmax_t) instead > > Signed-off-by: Manuel Bouyer Reviewed-by: Roger Pau Monné Thanks, Roger.

  1   2   >