Re: PVH mode PCI passthrough status

2020-12-29 Thread Roger Pau Monné
On Mon, Dec 28, 2020 at 06:11:08PM +, tosher 1 wrote: > Hi, > > As of Xen 4.10, PCI passthrough support was not available in PVH mode. I was > wondering if the PCI passthrough support was added in a later version. > > It would be great to know the latest status of the PCI passthrough support

Re: [openxt-dev] VirtIO-Argo initial development proposal

2020-12-29 Thread Roger Pau Monné
On Wed, Dec 23, 2020 at 04:32:01PM -0500, Rich Persaud wrote: > On Dec 17, 2020, at 07:13, Jean-Philippe Ouellet wrote: > > On Wed, Dec 16, 2020 at 2:37 PM Christopher Clark > > wrote: > >> Hi all, > >> > >> I have written a page for the OpenXT wiki describing a proposal for > >> initial devel

[qemu-mainline test] 157949: regressions - FAIL

2020-12-29 Thread osstest service owner
flight 157949 qemu-mainline real [real] flight 157956 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157949/ http://logs.test-lab.xenproject.org/osstest/logs/157956/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH 2/4] x86/ACPI: fix S3 wakeup vector mapping

2020-12-29 Thread Roger Pau Monné
On Mon, Nov 23, 2020 at 01:40:12PM +0100, Jan Beulich wrote: > Use of __acpi_map_table() here was at least close to an abuse already > before, but it will now consistently return NULL here. Drop the layering > violation and use set_fixmap() directly. Re-use of the ACPI fixmap area > is hopefully go

Re: Ping: [PATCH 2/4] x86/ACPI: fix S3 wakeup vector mapping

2020-12-29 Thread Roger Pau Monné
On Wed, Dec 23, 2020 at 04:09:07PM +0100, Jan Beulich wrote: > On 30.11.2020 14:02, Jan Beulich wrote: > > On 24.11.2020 12:04, Jan Beulich wrote: > >> On 23.11.2020 17:14, Andrew Cooper wrote: > >>> On 23/11/2020 16:07, Roger Pau Monné wrote: > On Mon, Nov 23, 2020 at 04:30:05PM +0100, Jan Be

Re: [PATCH 1/4] x86/ACPI: fix mapping of FACS

2020-12-29 Thread Roger Pau Monné
On Mon, Nov 23, 2020 at 01:39:55PM +0100, Jan Beulich wrote: > acpi_fadt_parse_sleep_info() runs when the system is already in > SYS_STATE_boot. Hence its direct call to __acpi_map_table() won't work > anymore. This call should probably have been replaced long ago already, > as the layering violati

Re: [PATCH 12/24] Implement gnttab on NetBSD

2020-12-29 Thread Roger Pau Monné
Might need some kind of log message, and will also required your Signed-off-by (or from the original author of the patch). On Mon, Dec 14, 2020 at 05:36:11PM +0100, Manuel Bouyer wrote: > --- > tools/libs/gnttab/Makefile | 2 +- > tools/libs/gnttab/netbsd.c | 267 +++

Re: [PATCH 02/24] NetBSD doens't need xenbackendd with xl toolstack

2020-12-29 Thread Roger Pau Monné
On Mon, Dec 14, 2020 at 05:36:01PM +0100, Manuel Bouyer wrote: > --- > tools/Makefile | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/Makefile b/tools/Makefile > index ed71474421..757a560be0 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -18,7 +18,6 @@ SUBDIRS-$(CONFIG_X8

Re: [PATCH 04/24] Make xg_main.c build on NetBSD

2020-12-29 Thread Roger Pau Monné
On Mon, Dec 14, 2020 at 05:36:03PM +0100, Manuel Bouyer wrote: > --- > tools/debugger/gdbsx/xg/xg_main.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/tools/debugger/gdbsx/xg/xg_main.c > b/tools/debugger/gdbsx/xg/xg_main.c > index a4e8653168..fa2741ccf8 100644 > --- a/too

Re: [PATCH 05/24] Introduce locking functions for block device setup on NetBSD

2020-12-29 Thread Roger Pau Monné
I think you want tot CC the tools dev on this one, specially Ian who knows how the Linux one is implemented and can likely give valuable input. On Mon, Dec 14, 2020 at 05:36:04PM +0100, Manuel Bouyer wrote: > --- > tools/hotplug/NetBSD/Makefile | 1 + > tools/hotplug/NetBSD/block | 5 ++-

Re: [PATCH 06/24] Handle the case where vifname is not present in xenstore.

2020-12-29 Thread Roger Pau Monné
Maybe it would be easier to just fix libxl to always set the vifname in xenstore? FWIW, on FreeBSD I'm passing the vifname as an environment parameter to the script. Thanks, Roger.

Re: [PATCH 07/24] Remove NetBSD's system headers. We'll use the system-provided ones, which are up to date.

2020-12-29 Thread Roger Pau Monné
What would happen when a new device (or ioctl to and existing one) is added? You would then run into issues of newer versions of Xen not building on older NetBSD systems, or would have to appropriately gate the newly added code to only be built when the headers are available. Thanks, Roger.

[libvirt test] 157953: regressions - trouble: blocked/fail/pass/starved

2020-12-29 Thread osstest service owner
flight 157953 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/157953/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-i386-libvirt

Re: [PATCH 08/24] Make libs/call build on NetBSD

2020-12-29 Thread Roger Pau Monné
LGTM. On Mon, Dec 14, 2020 at 05:36:07PM +0100, Manuel Bouyer wrote: > --- > tools/libs/call/netbsd.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/tools/libs/call/netbsd.c b/tools/libs/call/netbsd.c > index a5502da377..1a771e9928 100644 > --- a/too

Re: [PATCH 10/24] Make libs/evtchn build on NetBSD

2020-12-29 Thread Roger Pau Monné
On Mon, Dec 14, 2020 at 05:36:09PM +0100, Manuel Bouyer wrote: > --- > tools/libs/evtchn/netbsd.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/libs/evtchn/netbsd.c b/tools/libs/evtchn/netbsd.c > index 8b8545d2f9..6d4ce28011 100644 > --- a/tools/libs/evtch

[xen-unstable test] 157950: tolerable FAIL

2020-12-29 Thread osstest service owner
flight 157950 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/157950/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stopfail like 157931 test-amd64-amd64-xl-qemuu-win7-amd64

Re: [PATCH 11/24] Implement foreignmemory on NetBSD

2020-12-29 Thread Roger Pau Monné
On Mon, Dec 14, 2020 at 05:36:10PM +0100, Manuel Bouyer wrote: > --- > tools/libs/foreignmemory/Makefile | 2 +- > tools/libs/foreignmemory/netbsd.c | 76 ++ > tools/libs/foreignmemory/private.h | 10 +++- > 3 files changed, 75 insertions(+), 13 deletions(-) > > dif

Re: [PATCH 13/24] Don't assume tv_sec is a unsigned long (for NetBSD)

2020-12-29 Thread Roger Pau Monné
On Mon, Dec 14, 2020 at 05:36:12PM +0100, Manuel Bouyer wrote: > --- > tools/libs/light/libxl_create.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c > index 321a13e519..44691010bc 100644 > --- a/t

Re: [PATCH 15/24] Make libs/light build on NetBSD

2020-12-29 Thread Roger Pau Monné
On Mon, Dec 14, 2020 at 05:36:14PM +0100, Manuel Bouyer wrote: > --- > tools/libs/light/libxl_dm.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c > index 5948ace60d..c93bdf2cc9 100644 > --- a/tools/libs/light/libxl_dm.c

Re: [PATCH 16/24] Switch NetBSD to QEMU_XEN (!traditional)

2020-12-29 Thread Roger Pau Monné
On Mon, Dec 14, 2020 at 05:36:15PM +0100, Manuel Bouyer wrote: > --- > tools/libs/light/libxl_netbsd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/libs/light/libxl_netbsd.c b/tools/libs/light/libxl_netbsd.c > index e66a393d7f..31334f932c 100644 > --- a/tools/lib

Re: [PATCH 17/24] Make libs/light build on NetBSD

2020-12-29 Thread Roger Pau Monné
There's already a patch with the same subject in the series. I would recommend to be a bit more specific with the fixes, specally if there's no log message. This for example would better be: tools/libxl: fix uuid build on NetBSD On Mon, Dec 14, 2020 at 05:36:16PM +0100, Manuel Bouyer wrote: > ---

Re: [PATCH 18/24] xeneventchn_stubs.c doens't need xen/sys/evtchn.h (NetBSD fix)

2020-12-29 Thread Roger Pau Monné
If it builds on other OSes: Reviewed-by: Roger Pau Monné Subject would better be: tools/evtchn: remove unneeded evtchn.h include Thanks, Roger.

Re: [PATCH 19/24] errno may not be a gobal R/W variable, use a local variable instead (fix build on NetBSD)

2020-12-29 Thread Roger Pau Monné
On Mon, Dec 14, 2020 at 05:36:18PM +0100, Manuel Bouyer wrote: > --- > tools/xenpaging/xenpaging.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c > index 33098046c2..39c8c83b4b 100644 > --- a/tools/xenpaging/

Re: [PATCH 20/24] If FILENAME_MAX is defined, use it instead of arbitrary value (fix format-truncation errors with GCC >= 7)

2020-12-29 Thread Roger Pau Monné
On Mon, Dec 14, 2020 at 05:36:19PM +0100, Manuel Bouyer wrote: > --- > tools/xenpmd/xenpmd.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/tools/xenpmd/xenpmd.c b/tools/xenpmd/xenpmd.c > index 12b82cf43e..cfd22e64e3 100644 > --- a/tools/xenpmd/xenpmd.c > +++ b/tools/xenpmd/xenpmd.c

Re: [PATCH 22/24] If PTHREAD_STACK_MIN is not defined, use DEFAULT_THREAD_STACKSIZE

2020-12-29 Thread Roger Pau Monné
Reviewed-by: Roger Pau Monné I've been told that PTHREAD_STACK_MIN is not designed to be used like this anyway, and that what we do could be dangerous: https://lists.freebsd.org/pipermail/freebsd-current/2014-March/048885.html Please adjust the subject line to mention this applies to tools/xens

Re: [PATCH 14/24] Pass bridge name to qemu and set XEN_DOMAIN_ID

2020-12-29 Thread Roger Pau Monné
On Mon, Dec 14, 2020 at 05:36:13PM +0100, Manuel Bouyer wrote: > Pass bridge name to qemu > When starting qemu, set an environnement variable XEN_DOMAIN_ID, > to be used by qemu helper scripts NetBSD is the only one to use QEMU nic scripts, both FreeBSD and Linux don't use up/down scripts with QEM

Re: [PATCH 00/24] NetBSD fixes

2020-12-29 Thread Roger Pau Monné
On Mon, Dec 14, 2020 at 05:35:59PM +0100, Manuel Bouyer wrote: > Hello, > here is a set of 24 patches, which are needed to build and run the > tools on NetBSD. They are extracted from NetBSD's pkgsrc repository for > Xen 4.13, and ported to 4.15. Thanks! I think they are mostly fine. All of them

Re:

2020-12-29 Thread Roger Pau Monné
On Mon, Nov 30, 2020 at 04:21:59PM +, Alex Bennée wrote: > > Oleksandr Tyshchenko writes: > > > From: Oleksandr Tyshchenko > > > > > > Date: Sat, 28 Nov 2020 22:33:51 +0200 > > Subject: [PATCH V3 00/23] IOREQ feature (+ virtio-mmio) on Arm > > MIME-Version: 1.0 > > Content-Type: text/plain;

[linux-linus test] 157952: regressions - FAIL

2020-12-29 Thread osstest service owner
flight 157952 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/157952/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd

Re: [PATCH] x86/msr: don't inject #GP when trying to read FEATURE_CONTROL

2020-12-29 Thread Roger Pau Monné
On Fri, Nov 27, 2020 at 11:56:25AM +0100, Jan Beulich wrote: > On 27.11.2020 11:46, Roger Pau Monne wrote: > > Windows 10 will triple fault if #GP is injected when attempting to > > read the FEATURE_CONTROL MSR on Intel or compatible hardware. Fix this > > by injecting a #GP only when the vendor do

[PATCH v2] x86/msr: don't inject #GP when trying to read FEATURE_CONTROL

2020-12-29 Thread Roger Pau Monne
Windows 10 will triple fault if #GP is injected when attempting to read the FEATURE_CONTROL MSR on Intel or compatible hardware. Fix this by injecting a #GP only when the vendor doesn't support the MSR, even if there are no features to expose. Fixes: 39ab598c50a2 ('x86/pv: allow reading FEATURE_CO

Re: PVH mode PCI passthrough status

2020-12-29 Thread tosher 1
Hi Roger, > I think you meant PVH mode in the sentence above instead of PVM? Sorry, that was a typo. I meant PVH. > Arm folks are working on using vPCI for domUs, which could easily be picked > up by x86 once ready. There's also the option to import xenpt [0] from Paul > Durrant and use it wit

Re: PVH mode PCI passthrough status

2020-12-29 Thread Roger Pau Monné
On Tue, Dec 29, 2020 at 05:01:50PM +, tosher 1 wrote: > Hi Roger, > > > I think you meant PVH mode in the sentence above instead of PVM? > > Sorry, that was a typo. I meant PVH. > > > Arm folks are working on using vPCI for domUs, which could easily be picked > > up by x86 once ready. There

[qemu-mainline test] 157957: regressions - FAIL

2020-12-29 Thread osstest service owner
flight 157957 qemu-mainline real [real] flight 157963 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157957/ http://logs.test-lab.xenproject.org/osstest/logs/157963/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[linux-linus test] 157960: regressions - FAIL

2020-12-29 Thread osstest service owner
flight 157960 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/157960/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd

Re: [openxt-dev] VirtIO-Argo initial development proposal

2020-12-29 Thread Christopher Clark
On Thu, Dec 17, 2020 at 4:13 AM Jean-Philippe Ouellet wrote: > > On Wed, Dec 16, 2020 at 2:37 PM Christopher Clark > wrote: > > Hi all, > > > > I have written a page for the OpenXT wiki describing a proposal for > > initial development towards the VirtIO-Argo transport driver, and the > > related

Re: [openxt-dev] VirtIO-Argo initial development proposal

2020-12-29 Thread Christopher Clark
On Tue, Dec 29, 2020 at 1:17 AM Roger Pau Monné wrote: > > On Wed, Dec 23, 2020 at 04:32:01PM -0500, Rich Persaud wrote: > > On Dec 17, 2020, at 07:13, Jean-Philippe Ouellet wrote: > > > On Wed, Dec 16, 2020 at 2:37 PM Christopher Clark > > > wrote: > > >> Hi all, > > >> > > >> I have written

Re: PVH mode PCI passthrough status

2020-12-29 Thread Oleksandr Andrushchenko
Hi, all On 12/29/20 8:32 PM, Roger Pau Monné wrote: > On Tue, Dec 29, 2020 at 05:01:50PM +, tosher 1 wrote: >> Hi Roger, >> >>> I think you meant PVH mode in the sentence above instead of PVM? >> Sorry, that was a typo. I meant PVH. >> >>> Arm folks are working on using vPCI for domUs, which c

[qemu-mainline test] 157964: regressions - FAIL

2020-12-29 Thread osstest service owner
flight 157964 qemu-mainline real [real] flight 157971 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157964/ http://logs.test-lab.xenproject.org/osstest/logs/157971/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[PATCH] xen: fix: use WARN_ON instead of if condition followed by BUG.

2020-12-29 Thread YANG LI
Use WARN_ON instead of if condition followed by BUG in gnttab_batch_map() and gnttab_batch_copy(). This issue was detected with the help of coccicheck. Signed-off-by: YANG LI Reported-by: Abaci --- drivers/xen/grant-table.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --