[ovmf test] 157547: regressions - FAIL

flight 157547 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/157547/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 157345 test-amd64-amd64-xl-qemuu

Re: [PATCH 14/24] Pass bridge name to qemu and set XEN_DOMAIN_ID

On Mon, Dec 14, 2020 at 05:36:13PM +0100, Manuel Bouyer wrote: > Pass bridge name to qemu > When starting qemu, set an environnement variable XEN_DOMAIN_ID, > to be used by qemu helper scripts This one is not NetBSD related, I should have sent is as a separate git mail ... I guess (i'm not familia

Re: [PATCH v5 1/3] xen/arm: add support for run_in_exception_handler()

On 15.12.2020 07:33, Juergen Gross wrote: > --- a/xen/include/asm-arm/bug.h > +++ b/xen/include/asm-arm/bug.h > @@ -15,65 +15,62 @@ > > struct bug_frame { > signed int loc_disp;/* Relative address to the bug address */ > -signed int file_disp; /* Relative address to the filename *

[libvirt test] 157543: regressions - FAIL

flight 157543 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/157543/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 151777 build-arm64-libvirt

Re: [PATCH v5 1/3] xen/arm: add support for run_in_exception_handler()

On 15.12.20 10:02, Jan Beulich wrote: On 15.12.2020 07:33, Juergen Gross wrote: --- a/xen/include/asm-arm/bug.h +++ b/xen/include/asm-arm/bug.h @@ -15,65 +15,62 @@ struct bug_frame { signed int loc_disp;/* Relative address to the bug address */ -signed int file_disp; /* Rel

Re: [PATCH v3 7/8] xen/arm: Add support for SMMUv3 driver

Hi Julien, > On 14 Dec 2020, at 19:35, Julien Grall wrote: > > > > On 14/12/2020 19:08, Rahul Singh wrote: >> Hello Julien, > > Hi Rahul, > >>> On 11 Dec 2020, at 2:25 pm, Julien Grall wrote: >>> >>> Hi Rahul, >>> >>> On 10/12/2020 16:57, Rahul Singh wrote: struct arm_smmu_strtab_cf

Re: [PATCH v3 7/8] xen/arm: Add support for SMMUv3 driver

On 15/12/2020 09:42, Bertrand Marquis wrote: Hi Julien, Hi, On 14 Dec 2020, at 19:35, Julien Grall wrote: On 14/12/2020 19:08, Rahul Singh wrote: Hello Julien, Hi Rahul, On 11 Dec 2020, at 2:25 pm, Julien Grall wrote: Hi Rahul, On 10/12/2020 16:57, Rahul Singh wrote: struct

[xen-unstable test] 157536: regressions - FAIL

flight 157536 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/157536/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 157512 build-i386

Re: xen/evtchn: Interrupt for port 34, but apparently not enabled; per-user 00000000a86a4c1b on 5.10

On 15.12.20 08:27, Jürgen Groß wrote: On 14.12.20 22:25, Julien Grall wrote: Hi Juergen, When testing Linux 5.10 dom0, I could reliably hit the following warning with using event 2L ABI: [  589.591737] Interrupt for port 34, but apparently not enabled; per-user a86a4c1b [  589.59325

Re: [PATCH v3 7/8] xen/arm: Add support for SMMUv3 driver

Hi Julien, > On 15 Dec 2020, at 10:13, Julien Grall wrote: > > > > On 15/12/2020 09:42, Bertrand Marquis wrote: >> Hi Julien, > > Hi, > >>> On 14 Dec 2020, at 19:35, Julien Grall wrote: >>> >>> >>> >>> On 14/12/2020 19:08, Rahul Singh wrote: Hello Julien, >>> >>> Hi Rahul, >>> >>>

[linux-linus test] 157538: regressions - FAIL

flight 157538 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/157538/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-xl

[PATCH v2] xen/xenbus: make xs_talkv() interruptible

In case a process waits for any Xenstore action in the xenbus driver it should be interruptible by signals. Signed-off-by: Juergen Gross --- V2: - don't special case SIGKILL as libxenstore is handling -EINTR fine --- drivers/xen/xenbus/xenbus_xs.c | 9 - 1 file changed, 8 insertions(+),

[PATCH] xen: Rework WARN_ON() to return whether a warning was triggered

From: Julien Grall So far, our implementation of WARN_ON() cannot be used in the following situation: if ( WARN_ON() ) ... This is because the WARN_ON() doesn't return whether a warning. Such construction can be handy to have if you have to print more information and now the stack track. R

Re: [PATCH v3 7/8] xen/arm: Add support for SMMUv3 driver

On 15/12/2020 10:51, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 15 Dec 2020, at 10:13, Julien Grall wrote: On 15/12/2020 09:42, Bertrand Marquis wrote: Hi Julien, Hi, On 14 Dec 2020, at 19:35, Julien Grall wrote: On 14/12/2020 19:08, Rahul Singh wrote: Hello Julien,

Re: [PATCH] xen: Rework WARN_ON() to return whether a warning was triggered

On 15.12.20 12:26, Julien Grall wrote: From: Julien Grall So far, our implementation of WARN_ON() cannot be used in the following situation: if ( WARN_ON() ) ... This is because the WARN_ON() doesn't return whether a warning. Such ... warning has been triggered. construction can be h

Re: [PATCH v3 7/8] xen/arm: Add support for SMMUv3 driver

Hi Julien, > On 15 Dec 2020, at 11:31, Julien Grall wrote: > > > > On 15/12/2020 10:51, Bertrand Marquis wrote: >> Hi Julien, > > Hi Bertrand, > >>> On 15 Dec 2020, at 10:13, Julien Grall wrote: >>> >>> >>> >>> On 15/12/2020 09:42, Bertrand Marquis wrote: Hi Julien, >>> >>> Hi, >>>

Re: [PATCH v2 00/12] x86: major paravirt cleanup

Peter, On 23.11.20 14:43, Peter Zijlstra wrote: On Fri, Nov 20, 2020 at 01:53:42PM +0100, Peter Zijlstra wrote: On Fri, Nov 20, 2020 at 12:46:18PM +0100, Juergen Gross wrote: 30 files changed, 325 insertions(+), 598 deletions(-) Much awesome ! I'll try and get that objtool thing sorted.

Re: [PATCH] xen: Rework WARN_ON() to return whether a warning was triggered

On 15.12.2020 12:26, Julien Grall wrote: > --- a/xen/include/xen/lib.h > +++ b/xen/include/xen/lib.h > @@ -23,7 +23,13 @@ > #include > > #define BUG_ON(p) do { if (unlikely(p)) BUG(); } while (0) > -#define WARN_ON(p) do { if (unlikely(p)) WARN(); } while (0) > +#define WARN_ON(p) ({

Re: [PATCH v2 1/4] block: Honor blk_set_aio_context() context requirements

Am 14.12.2020 um 18:05 hat Sergio Lopez geschrieben: > The documentation for bdrv_set_aio_context_ignore() states this: > > * The caller must own the AioContext lock for the old AioContext of bs, but > it > * must not own the AioContext lock for new_context (unless new_context is the > * same

Re: [PATCH v2 2/4] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

Am 14.12.2020 um 18:05 hat Sergio Lopez geschrieben: > While processing the parents of a BDS, one of the parents may process > the child that's doing the tail recursion, which leads to a BDS being > processed twice. This is especially problematic for the aio_notifiers, > as they might attempt to wo

Xen Security Advisory 323 v3 (CVE-2020-29482) - Xenstore: wrong path length check

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2020-29482 / XSA-323 version 3 Xenstore: wrong path length check UPDATES IN VERSION 3 Public release. ISSUE DESCRIPTION =

Xen Security Advisory 324 v3 (CVE-2020-29484) - Xenstore: guests can crash xenstored via watchs

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2020-29484 / XSA-324 version 3 Xenstore: guests can crash xenstored via watchs UPDATES IN VERSION 3 Public release. ISSUE DESCRIPTION ==

Xen Security Advisory 322 v4 (CVE-2020-29481) - Xenstore: new domains inheriting existing node permissions

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2020-29481 / XSA-322 version 4 Xenstore: new domains inheriting existing node permissions UPDATES IN VERSION 4 Public release. ISSUE DESCRIPTION

Xen Security Advisory 325 v3 (CVE-2020-29483) - Xenstore: guests can disturb domain cleanup

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2020-29483 / XSA-325 version 3 Xenstore: guests can disturb domain cleanup UPDATES IN VERSION 3 Public release. ISSUE DESCRIPTION

Xen Security Advisory 350 v4 (CVE-2020-29569) - Use after free triggered by block frontend in Linux blkback

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2020-29569 / XSA-350 version 4 Use after free triggered by block frontend in Linux blkback UPDATES IN VERSION 4 Public release. ISSUE DESCRIPTION

Xen Security Advisory 352 v3 (CVE-2020-29486) - oxenstored: node ownership can be changed by unprivileged clients

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2020-29486 / XSA-352 version 3 oxenstored: node ownership can be changed by unprivileged clients UPDATES IN VERSION 3 Public release. ISSUE DESCRIPTION =

Xen Security Advisory 330 v3 (CVE-2020-29485) - oxenstored memory leak in reset_watches

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2020-29485 / XSA-330 version 3 oxenstored memory leak in reset_watches UPDATES IN VERSION 3 Public release. ISSUE DESCRIPTION ==

Xen Security Advisory 358 v4 (CVE-2020-29570) - FIFO event channels control block related ordering

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2020-29570 / XSA-358 version 4 FIFO event channels control block related ordering UPDATES IN VERSION 4 Public release. ISSUE DESCRIPTION =

Xen Security Advisory 349 v3 (CVE-2020-29568) - Frontends can trigger OOM in Backends by update a watched path

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2020-29568 / XSA-349 version 3 Frontends can trigger OOM in Backends by update a watched path UPDATES IN VERSION 3 Public release. ISSUE DESCRIPTION ==

[GIT PULL] xen: branch for v5.11-rc1

Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.11-rc1-tag xen: branch for v5.11-rc1 It contains fixes for security issues just having been disclosed: - a 5 patch series for fixing of XSA-349 (DoS via resource depletion in Xen

Xen Security Advisory 356 v3 (CVE-2020-29567) - infinite loop when cleaning up IRQ vectors

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2020-29567 / XSA-356 version 3 infinite loop when cleaning up IRQ vectors UPDATES IN VERSION 3 Public release. ISSUE DESCRIPTION =

Xen Security Advisory 359 v3 (CVE-2020-29571) - FIFO event channels control structure ordering

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2020-29571 / XSA-359 version 3 FIFO event channels control structure ordering UPDATES IN VERSION 3 Public release. ISSUE DESCRIPTION ===

Xen Security Advisory 353 v4 (CVE-2020-29479) - oxenstored: permissions not checked on root node

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2020-29479 / XSA-353 version 4 oxenstored: permissions not checked on root node UPDATES IN VERSION 4 Public release. ISSUE DESCRIPTION ==

Xen Security Advisory 354 v4 (CVE-2020-29487) - XAPI: guest-triggered excessive memory usage

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2020-29487 / XSA-354 version 4 XAPI: guest-triggered excessive memory usage UPDATES IN VERSION 4 Public release. ISSUE DESCRIPTION

Xen Security Advisory 348 v3 (CVE-2020-29566) - undue recursion in x86 HVM context switch code

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2020-29566 / XSA-348 version 3 undue recursion in x86 HVM context switch code UPDATES IN VERSION 3 Public release. ISSUE DESCRIPTION ===

[ovmf test] 157549: regressions - FAIL

flight 157549 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/157549/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 157345 test-amd64-amd64-xl-qemuu

Re: [PATCH] xen: Rework WARN_ON() to return whether a warning was triggered

Hi Juergen, On 15/12/2020 11:31, Jürgen Groß wrote: On 15.12.20 12:26, Julien Grall wrote: From: Julien Grall So far, our implementation of WARN_ON() cannot be used in the following situation: if ( WARN_ON() ) ... This is because the WARN_ON() doesn't return whether a warning. Such .

Re: [PATCH] xen: Rework WARN_ON() to return whether a warning was triggered

Hi, On 15/12/2020 11:46, Jan Beulich wrote: On 15.12.2020 12:26, Julien Grall wrote: --- a/xen/include/xen/lib.h +++ b/xen/include/xen/lib.h @@ -23,7 +23,13 @@ #include #define BUG_ON(p) do { if (unlikely(p)) BUG(); } while (0) -#define WARN_ON(p) do { if (unlikely(p)) WARN(); } whil

Re: [PATCH v5 1/3] xen/arm: add support for run_in_exception_handler()

Hi Jan, On 15/12/2020 09:02, Jan Beulich wrote: On 15.12.2020 07:33, Juergen Gross wrote: --- a/xen/include/asm-arm/bug.h +++ b/xen/include/asm-arm/bug.h @@ -15,65 +15,62 @@ struct bug_frame { signed int loc_disp;/* Relative address to the bug address */ -signed int file_dis

Re: [PATCH v5 1/3] xen/arm: add support for run_in_exception_handler()

On 15.12.2020 14:39, Julien Grall wrote: > On 15/12/2020 09:02, Jan Beulich wrote: >> On 15.12.2020 07:33, Juergen Gross wrote: >>> --- a/xen/include/asm-arm/bug.h >>> +++ b/xen/include/asm-arm/bug.h >>> @@ -15,65 +15,62 @@ >>> >>> struct bug_frame { >>> signed int loc_disp;/* Relati

Re: [PATCH] xen: Rework WARN_ON() to return whether a warning was triggered

On 15.12.2020 14:19, Julien Grall wrote: > On 15/12/2020 11:46, Jan Beulich wrote: >> On 15.12.2020 12:26, Julien Grall wrote: >>> --- a/xen/include/xen/lib.h >>> +++ b/xen/include/xen/lib.h >>> @@ -23,7 +23,13 @@ >>> #include >>> >>> #define BUG_ON(p) do { if (unlikely(p)) BUG(); } while

Re: [PATCH v2 00/12] x86: major paravirt cleanup

On Tue, Dec 15, 2020 at 12:42:45PM +0100, Jürgen Groß wrote: > Peter, > > On 23.11.20 14:43, Peter Zijlstra wrote: > > On Fri, Nov 20, 2020 at 01:53:42PM +0100, Peter Zijlstra wrote: > > > On Fri, Nov 20, 2020 at 12:46:18PM +0100, Juergen Gross wrote: > > > > 30 files changed, 325 insertions(+),

Re: [PATCH v4 23/32] qdev: Move dev->realized check to qdev_property_set()

On Mon, 14 Dec 2020 12:24:18 -0500 Eduardo Habkost wrote: > On Mon, Dec 14, 2020 at 03:55:30PM +0100, Igor Mammedov wrote: > > On Fri, 11 Dec 2020 17:05:20 -0500 > > Eduardo Habkost wrote: > > > > > Every single qdev property setter function manually checks > > > dev->realized. We can just c

Re: [PATCH v2 00/12] x86: major paravirt cleanup

On Tue, Dec 15, 2020 at 03:18:34PM +0100, Peter Zijlstra wrote: > Ah, I was waiting for Josh to have an opinion (and then sorta forgot > about the whole thing again). Let me refresh and provide at least a > Changelog. How's this then? --- Subject: objtool: Alternatives vs ORC, the hard way From:

Re: [PATCH v2 2/4] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

Am 15.12.2020 um 14:15 hat Sergio Lopez geschrieben: > On Tue, Dec 15, 2020 at 01:12:33PM +0100, Kevin Wolf wrote: > > Am 14.12.2020 um 18:05 hat Sergio Lopez geschrieben: > > > While processing the parents of a BDS, one of the parents may process > > > the child that's doing the tail recursion, wh

[PATCH] tools/xenstore: rework path length check

The different fixed limits for absolute and relative path lengths of Xenstore nodes make it possible to create per-domain nodes via absolute paths which are not accessible using relative paths, as the two limits differ by 1024 characters. Instead of this weird limits use only one limit, which appl

Re: [PATCH] tools/xenstore: rework path length check

On 15/12/2020 15:04, Juergen Gross wrote: > The different fixed limits for absolute and relative path lengths of > Xenstore nodes make it possible to create per-domain nodes via > absolute paths which are not accessible using relative paths, as the > two limits differ by 1024 characters. > > Instea

Re: [PATCH v2 00/12] x86: major paravirt cleanup

On 15.12.20 15:54, Peter Zijlstra wrote: On Tue, Dec 15, 2020 at 03:18:34PM +0100, Peter Zijlstra wrote: Ah, I was waiting for Josh to have an opinion (and then sorta forgot about the whole thing again). Let me refresh and provide at least a Changelog. How's this then? Thanks, will add it in

Re: [PATCH v2 4/4] block: Close block exports in two steps

Am 14.12.2020 um 18:05 hat Sergio Lopez geschrieben: > There's a cross-dependency between closing the block exports and > draining the block layer. The latter needs that we close all export's > client connections to ensure they won't queue more requests, but the > exports may have coroutines yieldi

Re: [PATCH] examples: Add PVH example to config example list

On Mon, Dec 14, 2020 at 06:35:32PM -0800, Elliott Mitchell wrote: > Somewhat helpful to actually install the example configurations. > > Signed-off-by: Elliott Mitchell Acked-by: Wei Liu

Re: [PATCH] tools/xenstore: rework path length check

On Tue, Dec 15, 2020 at 04:04:11PM +0100, Juergen Gross wrote: > The different fixed limits for absolute and relative path lengths of > Xenstore nodes make it possible to create per-domain nodes via > absolute paths which are not accessible using relative paths, as the > two limits differ by 1024 c

Re: [PATCH v6 01/25] libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X

On Tue, Dec 08, 2020 at 07:30:09PM +, Paul Durrant wrote: > From: Paul Durrant > > The seemingly arbitrary use of 'pci' and 'pcidev' in the code in libxl_pci.c > is confusing and also compromises use of some macros used for other device > types. Indeed it seems that DEFINE_DEVICE_TYPE_STRUCT_

Re: [PATCH v6 02/25] xl: s/pcidev/pci where possible

On Tue, Dec 08, 2020 at 07:30:10PM +, Paul Durrant wrote: > From: Paul Durrant > > To improve naming consistency, replaces occurrences of 'pcidev' with 'pci'. > The only remaining use of the term should be in relation to > 'libxl_domain_config' where there are fields named 'pcidevs' and > 'n

Re: [PATCH v6 21/25] libxl: convert internal functions in libxl_pci.c...

On Tue, Dec 08, 2020 at 07:30:29PM +, Paul Durrant wrote: > From: Paul Durrant > > ... to use 'libx_pci_bdf' where appropriate. > > No API change. > > Signed-off-by: Paul Durrant Acked-by: Wei Liu

Re: [PATCH v6 22/25] libxl: introduce libxl_pci_bdf_assignable_add/remove/list/list_free(), ...

On Tue, Dec 08, 2020 at 07:30:30PM +, Paul Durrant wrote: > From: Paul Durrant > > which support naming and use 'libxl_pci_bdf' rather than 'libxl_device_pci', > as replacements for libxl_device_pci_assignable_add/remove/list/list_free(). > > libxl_pci_bdf_assignable_add() takes a 'name' par

Re: [PATCH v6 23/25] xl: support naming of assignable devices

On Tue, Dec 08, 2020 at 07:30:31PM +, Paul Durrant wrote: > From: Paul Durrant > > This patch converts libxl to use libxl_pci_bdf_assignable_add/remove/list/ > list_free() rather than libxl_device_pci_assignable_add/remove/list/ > list_free(), which then allows naming of assignable devices to

[PATCH v2 0/4] x86: XSA-348 follow-up

The changes for this XSA introduced an inefficiency and could do with some further hardening. Addressing of this wasn't sensible as part of the XSA, though (but you may take this as an explanation of why this starts out as v2). 1: x86: verify function type (and maybe attribute) in switch_stack_and

Re: [PATCH v1 1/3] tools: allocate bitmaps in units of unsigned long

On Wed, Dec 09, 2020 at 04:54:49PM +0100, Olaf Hering wrote: > Allocate enough memory so that the returned pointer can be safely > accessed as an array of unsigned long. > > The actual bitmap size in units of bytes, as returned by bitmap_size, > remains unchanged. > > Signed-off-by: Olaf Hering

[PATCH v2 1/4] x86: verify function type (and maybe attribute) in switch_stack_and_jump()

It is imperative that the functions passed here are taking no arguments, return no values, and don't return in the first place. While the type can be checked uniformly, the attribute check is limited to gcc 9 and newer (no clang support for this so far afaict). Note that I didn't want to have the

[PATCH v2 2/4] x86: clobber registers in switch_stack_and_jump() when !LIVEPATCH

In order to have the same effect on registers as a call to check_for_livepatch_work() may have, clobber all call-clobbered registers in debug builds. Signed-off-by: Jan Beulich --- v2: New. --- a/xen/include/asm-x86/current.h +++ b/xen/include/asm-x86/current.h @@ -120,6 +120,14 @@ unsigned long

[xen-unstable-smoke test] 157560: tolerable all pass - PUSHED

flight 157560 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/157560/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH v2 3/4] x86/PV: avoid double stack reset during schedule tail handling

Invoking check_wakeup_from_wait() from assembly allows the new continue_pv_domain() to replace the prior continue_nonidle_domain() as the tail hook, eliminating an extra reset_stack_and_jump(). Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross --- a/xen/arch/x86/pv/domain.c +++ b/xen/arch/x

[PATCH v2 4/4] livepatch: adjust a stale comment

As of 005de45c887e ("xen: do live patching only from main idle loop") the comment ahead of livepatch_do_action() has been stale. Signed-off-by: Jan Beulich --- a/xen/common/livepatch.c +++ b/xen/common/livepatch.c @@ -1392,8 +1392,8 @@ static inline bool was_action_consistent } /* - * This f

[qemu-mainline test] 157548: regressions - FAIL

flight 157548 qemu-mainline real [real] flight 157567 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157548/ http://logs.test-lab.xenproject.org/osstest/logs/157567/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH] xen: Rework WARN_ON() to return whether a warning was triggered

On 15.12.20 14:11, Julien Grall wrote: Hi Juergen, On 15/12/2020 11:31, Jürgen Groß wrote: On 15.12.20 12:26, Julien Grall wrote: From: Julien Grall So far, our implementation of WARN_ON() cannot be used in the following situation: if ( WARN_ON() ) ... This is because the WARN_ON() do

Re: [PATCH v1 2/3] tools: remove unused ORDER_LONG

On Wed, Dec 09, 2020 at 04:54:50PM +0100, Olaf Hering wrote: > There are no users left, xenpaging has its own variant. > The last user was removed with commit 11d0044a168994de85b9b328452292852aedc871 > > Signed-off-by: Olaf Hering Acked-by: Wei Liu

Re: [PATCH v1 3/3] tools: add API to work with sevaral bits at once

On Wed, Dec 09, 2020 at 04:54:51PM +0100, Olaf Hering wrote: > Introduce new API to test if a fixed number of bits is clear or set, > and clear or set them all at once. > > The caller has to make sure the input bitnumber is a multiply of > BITS_PER_LONG. > > This API avoids the loop over each bi

[PATCH 0/6] x86/p2m: restrict more code to build just for HVM

1: p2m: tidy p2m_add_foreign() a little 2: mm: p2m_add_foreign() is HVM-only 3: p2m: set_{foreign,mmio}_p2m_entry() are HVM-only 4: p2m: {,un}map_mmio_regions() are HVM-only 5: mm: the gva_to_gfn() hook is HVM-only 6: p2m: set_shared_p2m_entry() is MEM_SHARING-only Jan

[PATCH 1/6] x86/p2m: tidy p2m_add_foreign() a little

Drop a bogus ASSERT() - we don't typically assert incoming domain pointers to be non-NULL, and there's no particular reason to do so here. Replace the open-coded DOMID_SELF check by use of rcu_lock_remote_domain_by_id(), at the same time covering the request being made with the current domain's ac

[PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

This is together with its only caller, xenmem_add_to_physmap_one(). Move the latter next to p2m_add_foreign(), allowing this one to become static at the same time. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -118,7 +118,6 @@ #include #include #include -#in

[PATCH 3/6] x86/p2m: set_{foreign,mmio}_p2m_entry() are HVM-only

Extend a respective #ifdef from inside set_typed_p2m_entry() to around all three functions. Add ASSERT_UNREACHABLE() to the latter one's safety check path. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -1257,6 +1257,8 @@ int p2m_finish_type_change(struct d

[PATCH 4/6] x86/p2m: {,un}map_mmio_regions() are HVM-only

Mirror the "translated" check the functions do to do_domctl(), allowing the calls to be DCEd by the compiler. Add ASSERT_UNREACHABLE() to the original checks. Also arrange for {set,clear}_mmio_p2m_entry() and {set,clear}_identity_p2m_entry() to respectively live next to each other, such that clear

[PATCH 5/6] x86/mm: the gva_to_gfn() hook is HVM-only

As is the adjacent ga_to_gfn() one as well as paging_gva_to_gfn(). Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -1772,7 +1772,6 @@ void np2m_schedule(int dir) p2m_unlock(p2m); } } -#endif unsigned long paging_gva_to_gfn(struct vcpu *v,

[PATCH 6/6] x86/p2m: set_shared_p2m_entry() is MEM_SHARING-only

Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -1476,6 +1476,8 @@ int clear_identity_p2m_entry(struct doma return ret; } +#ifdef CONFIG_MEM_SHARING + /* Returns: 0 for success, -errno for failure */ int set_shared_p2m_entry(struct domain *d, unsign

Re: [PATCH v2 1/4] x86: verify function type (and maybe attribute) in switch_stack_and_jump()

On Tue, Dec 15, 2020 at 05:11:41PM +0100, Jan Beulich wrote: > It is imperative that the functions passed here are taking no arguments, > return no values, and don't return in the first place. While the type > can be checked uniformly, the attribute check is limited to gcc 9 and > newer (no clang s

Re: [PATCH v2 2/4] x86: clobber registers in switch_stack_and_jump() when !LIVEPATCH

On Tue, Dec 15, 2020 at 05:12:12PM +0100, Jan Beulich wrote: > In order to have the same effect on registers as a call to > check_for_livepatch_work() may have, clobber all call-clobbered > registers in debug builds. > > Signed-off-by: Jan Beulich Reviewed-by: Wei Liu

Re: [PATCH v1 3/3] tools: add API to work with sevaral bits at once

Am Tue, 15 Dec 2020 16:22:44 + schrieb Wei Liu : > What's wrong with requiring the input addr be const unsigned long *? Probably nothing. In the end I just borrowed the prototypes from the other functions in this file. I will resend with this change once I have the consumers ready. Olaf

Re: [PATCH v2 3/4] x86/PV: avoid double stack reset during schedule tail handling

On Tue, Dec 15, 2020 at 05:12:36PM +0100, Jan Beulich wrote: > Invoking check_wakeup_from_wait() from assembly allows the new > continue_pv_domain() to replace the prior continue_nonidle_domain() as > the tail hook, eliminating an extra reset_stack_and_jump(). > > Signed-off-by: Jan Beulich > Rev

Re: [PATCH v1 3/3] tools: add API to work with sevaral bits at once

On Tue, Dec 15, 2020 at 05:29:17PM +0100, Olaf Hering wrote: > Am Tue, 15 Dec 2020 16:22:44 + > schrieb Wei Liu : > > > What's wrong with requiring the input addr be const unsigned long *? > > Probably nothing. In the end I just borrowed the prototypes from the other > functions in this file

Re: [PATCH v2 4/4] livepatch: adjust a stale comment

On Tue, Dec 15, 2020 at 05:13:43PM +0100, Jan Beulich wrote: > As of 005de45c887e ("xen: do live patching only from main idle loop") > the comment ahead of livepatch_do_action() has been stale. > Reviewed-by: Konrad Rzeszutek Wilk Thank you! > Signed-off-by: Jan Beulich > > --- a/xen/common/li

[PATCH v10 04/25] tools/libxenevtchn: add possibility to not close file descriptor on exec

Today the file descriptor for the access of the event channel driver is being closed in case of exec(2). For the support of live update of a daemon using libxenevtchn this can be problematic, so add a way to keep that file descriptor open. Add support of a flag XENEVTCHN_NO_CLOEXEC for xenevtchn_o

[PATCH v10 01/25] tools/xenstore: switch barf[_perror]() to use syslog()

When xenstored crashes due to an unrecoverable condition it is calling either barf() or barf_perror() to issue a message and then exit(). Make sure the message is visible somewhere by using syslog() additionally to xprintf(), as the latter will be visible only with tracing active. Signed-off-by:

[PATCH v10 02/25] tools/xenstore: make set_tdb_key() non-static

set_tdb_key() can be used by destroy_node(), too. So remove the static attribute and move it to xenstored_core.c. Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant --- V5: - new patch V6: - add comment (Julien Grall) Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c

[PATCH v10 08/25] tools/xenstore: introduce live update status block

Live update of Xenstore is done in multiple steps. It needs a status block holding the current state of live update and related data. It is allocated as child of the connection live update was started over in order to abort live update in case the connection is closed. Allocation of the block is d

[PATCH v10 00/25] tools/xenstore: support live update for xenstored

Today Xenstore is not restartable. This means a Xen server needing an update of xenstored has to be rebooted in order to let this update become effective. This patch series is changing that: The internal state of xenstored (the contents of Xenstore, all connections to various clients like programs

[PATCH v10 10/25] tools/xenstore: add command line handling for live update

Updating an instance of Xenstore via live update needs to hand over the command line parameters to the updated instance. Those can be either the parameters used by the updated instance or new ones when supplied when starting the live update. So when supplied store the new command line parameters i

[PATCH v10 03/25] tools/xenstore: remove unused cruft from xenstored_domain.c

domain->remote_port and restore_existing_connections() are useless and can be removed. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- V7: - new patch --- tools/xenstore/xenstored_core.c | 3 --- tools/xenstore/xenstored_domain.c | 11 --- tools/xenstore/xenstored_domain.h

[PATCH v10 09/25] tools/xenstore: save new binary for live update

Save the new binary name for the daemon case and the new kernel for stubdom in order to support live update of Xenstore.. Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant Reviewed-by: Julien Grall --- tools/xenstore/xenstored_control.c | 41 +- 1 file changed,

[PATCH v10 11/25] tools/xenstore: add the basic framework for doing the live update

Add the main framework for executing the live update. This for now only defines the basic execution steps with empty dummy functions. This final step returning means failure, as in case of success the new executable will have taken over. Signed-off-by: Juergen Gross Acked-by: Julien Grall Review

[PATCH v10 05/25] tools/xenstore: refactor XS_CONTROL handling

In order to allow control commands with binary data refactor handling of XS_CONTROL: - get primary command first - add maximum number of additional parameters to pass to command handler Signed-off-by: Juergen Gross Reviewed-by: Julien Grall Reviewed-by: Paul Durrant --- V2: - add comment reg

[PATCH v10 14/25] tools/xenstore: add include file for state structure definitions

Add an include file containing all structures and defines needed for dumping and restoring the internal Xenstore state. Signed-off-by: Juergen Gross Acked-by: Julien Grall --- V4: - drop mfn from connection record (rebase to V5 of state doc patch) - add #ifdef __MINIOS__ (Julien Grall) - correct

[PATCH v10 06/25] tools/xenstore: add live update command to xenstore-control

Add the "live-update" command to xenstore-control enabling updating xenstored to a new version in a running Xen system. With -c it is possible to pass a different command line to the new instance of xenstored. This will replace the command line used for the invocation of the just running xenstore

[PATCH v10 12/25] tools/xenstore: allow live update only with no transaction active

In order to simplify live update state dumping only allow live update to happen when no transaction is active. A timeout is used to detect guests which have a transaction active for longer periods of time. In case such a guest is detected when trying to do a live update it will be reported and the

[PATCH v10 17/25] tools/xenstore: split off domain introduction from do_introduce()

For live update the functionality to introduce a new domain similar to the XS_INTRODUCE command is needed, so split that functionality off into a dedicated function introduce_domain(). Switch initial dom0 initialization to use this function, too. Signed-off-by: Juergen Gross Reviewed-by: Julien

[PATCH v10 07/25] tools/xenstore: add basic live-update command parsing

Add the basic parts for parsing the live-update control command. For now only add the parameter evaluation and calling appropriate functions. Those function only print a message for now and return success. Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant Reviewed-by: Julien Grall --- V2:

[PATCH v10 13/25] docs: update the xenstore migration stream documentation

For live update of Xenstore some records defined in the migration stream document need to be changed: - Support of the read-only socket has been dropped from all Xenstore implementations, so ro-socket-fd in the global record can be removed. - Some guests require the event channel to Xenstore to

[PATCH v10 19/25] tools/xenstore: read internal state when doing live upgrade

When started due to a live upgrade read the internal state and apply it to the data base and internal structures. Add the main control functions for that. For now only handle the daemon case. Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant Acked-by: Julien Grall --- V4: - directly mmap

[PATCH v10 18/25] tools/xenstore: evaluate the live update flag when starting

In the live update case several initialization steps of xenstore must be omitted or modified. Add the proper handling for that. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- V4: - set xprintf = trace in daemon case (Julien Grall) - only update /tool/xenstored node contents V7: - so

[PATCH v10 16/25] tools/xenstore: handle CLOEXEC flag for local files and pipes

For support of live update the locally used files need to have the "close on exec" flag set. Fortunately the used Xen libraries are already doing this, so only the logging and tdb related files and pipes are affected. openlog() has the close on exec attribute, too. In order to be able to keep the

[PATCH v10 20/25] tools/xenstore: add reading global state for live update

Add reading the global state for live update. Signed-off-by: Juergen Gross Acked-by: Julien Grall Reviewed-by: Paul Durrant --- tools/xenstore/xenstored_control.c | 1 + tools/xenstore/xenstored_core.c| 9 + tools/xenstore/xenstored_core.h| 2 ++ 3 files changed, 12 insertions(

  1   2   >