Re: [PATCH v3 13/13] compiler.h: remove QEMU_GNUC_PREREQ

2020-12-14 Thread Marc-André Lureau
Hi On Thu, Dec 10, 2020 at 6:07 PM wrote: > From: Marc-André Lureau > > When needed, the G_GNUC_CHECK_VERSION() glib macro can be used instead. > > Signed-off-by: Marc-André Lureau > --- > include/qemu/compiler.h| 11 --- > scripts/cocci-macro-file.h | 1 - > 2 files changed, 12

[linux-linus test] 157509: regressions - FAIL

2020-12-14 Thread osstest service owner
flight 157509 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/157509/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

Re: [PATCH] Revert "x86/mm: drop guest_get_eff_l1e()"

2020-12-14 Thread Jan Beulich
On 11.12.2020 15:16, Andrew Cooper wrote: > This reverts commit 9ff9705647646aa937b5f5c1426a64c69a62b3bd. > > The change is only correct in the original context of XSA-286, where Xen's use > of the linear pagetables were dropped. However, performance problems > interfered with that plan, and XSA-

Re: [XEN PATCH v1 1/1] Invalidate cache for cpus affinitized to the domain

2020-12-14 Thread Jan Beulich
On 11.12.2020 12:44, Harsha Shamsundara Havanur wrote: > A HVM domain flushes cache on all the cpus using > `flush_all` macro which uses cpu_online_map, during > i) creation of a new domain > ii) when device-model op is performed > iii) when domain is destructed. > > This triggers IPI on all the c

Re: [PATCH v4 1/3] xen/arm: add support for run_in_exception_handler()

2020-12-14 Thread Jan Beulich
On 14.12.2020 08:56, Juergen Gross wrote: > Add support to run a function in an exception handler for Arm. Do it > the same way as on x86 via a bug_frame. > > Unfortunately inline assembly on Arm seems to be less capable than on > x86, leading to functions called via run_in_exception_handler() hav

Re: [PATCH v4 0/3] xen: add support for automatic debug key actions in case of crash

2020-12-14 Thread Jan Beulich
On 14.12.2020 08:56, Juergen Gross wrote: > Patch 2 opens up more potential for simplification: in theory there is > no need any more to call any key handler with the regs parameter, > allowing to use the same prototype for all handlers. The downside would > be to have an additional irq frame on th

Re: [PATCH v4 1/3] xen/arm: add support for run_in_exception_handler()

2020-12-14 Thread Jürgen Groß
On 14.12.20 10:03, Jan Beulich wrote: On 14.12.2020 08:56, Juergen Gross wrote: Add support to run a function in an exception handler for Arm. Do it the same way as on x86 via a bug_frame. Unfortunately inline assembly on Arm seems to be less capable than on x86, leading to functions called via

Re: [PATCH v4 3/3] xen: add support for automatic debug key actions in case of crash

2020-12-14 Thread Jan Beulich
On 14.12.2020 08:56, Juergen Gross wrote: > @@ -519,6 +521,59 @@ void __init initialize_keytable(void) > } > } > > +#define CRASHACTION_SIZE 32 > +static char crash_debug_panic[CRASHACTION_SIZE]; > +string_runtime_param("crash-debug-panic", crash_debug_panic); > +static char crash_debug_hw

Re: [PATCH v4 3/3] xen: add support for automatic debug key actions in case of crash

2020-12-14 Thread Jürgen Groß
On 14.12.20 10:16, Jan Beulich wrote: On 14.12.2020 08:56, Juergen Gross wrote: @@ -519,6 +521,59 @@ void __init initialize_keytable(void) } } +#define CRASHACTION_SIZE 32 +static char crash_debug_panic[CRASHACTION_SIZE]; +string_runtime_param("crash-debug-panic", crash_debug_panic)

Re: [PATCH v4 0/3] xen: add support for automatic debug key actions in case of crash

2020-12-14 Thread Jürgen Groß
On 14.12.20 10:09, Jan Beulich wrote: On 14.12.2020 08:56, Juergen Gross wrote: Patch 2 opens up more potential for simplification: in theory there is no need any more to call any key handler with the regs parameter, allowing to use the same prototype for all handlers. The downside would be to h

Re: [PATCH v4 1/3] xen/arm: add support for run_in_exception_handler()

2020-12-14 Thread Jan Beulich
On 14.12.2020 10:15, Jürgen Groß wrote: > On 14.12.20 10:03, Jan Beulich wrote: >> On 14.12.2020 08:56, Juergen Gross wrote: >>> Add support to run a function in an exception handler for Arm. Do it >>> the same way as on x86 via a bug_frame. >>> >>> Unfortunately inline assembly on Arm seems to be

Re: [PATCH v4 0/3] xen: add support for automatic debug key actions in case of crash

2020-12-14 Thread Jan Beulich
On 14.12.2020 10:21, Jürgen Groß wrote: > On 14.12.20 10:09, Jan Beulich wrote: >> On 14.12.2020 08:56, Juergen Gross wrote: >>> Patch 2 opens up more potential for simplification: in theory there is >>> no need any more to call any key handler with the regs parameter, >>> allowing to use the same

Re: [PATCH v4 1/3] xen/arm: add support for run_in_exception_handler()

2020-12-14 Thread Jürgen Groß
On 14.12.20 10:22, Jan Beulich wrote: On 14.12.2020 10:15, Jürgen Groß wrote: On 14.12.20 10:03, Jan Beulich wrote: On 14.12.2020 08:56, Juergen Gross wrote: Add support to run a function in an exception handler for Arm. Do it the same way as on x86 via a bug_frame. Unfortunately inline assem

Re: [XEN PATCH v1 1/1] Invalidate cache for cpus affinitized to the domain

2020-12-14 Thread Shamsundara Havanur, Harsha
On Mon, 2020-12-14 at 09:52 +0100, Jan Beulich wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > On 11.12.2020 12:44, Harsha Shamsundara Havanur wrote: > > A

Re: [PATCH v3 4/5] evtchn: convert domain event lock to an r/w one

2020-12-14 Thread Jan Beulich
On 11.12.2020 11:57, Julien Grall wrote: > On 11/12/2020 10:32, Jan Beulich wrote: >> On 09.12.2020 12:54, Julien Grall wrote: >>> On 23/11/2020 13:29, Jan Beulich wrote: @@ -620,7 +620,7 @@ int evtchn_close(struct domain *d1, int long rc = 0; again: >>>

Re: [XEN PATCH v1 1/1] Invalidate cache for cpus affinitized to the domain

2020-12-14 Thread Jan Beulich
On 14.12.2020 10:26, Shamsundara Havanur, Harsha wrote: > On Mon, 2020-12-14 at 09:52 +0100, Jan Beulich wrote: >> On 11.12.2020 12:44, Harsha Shamsundara Havanur wrote: >>> A HVM domain flushes cache on all the cpus using >>> `flush_all` macro which uses cpu_online_map, during >>> i) creation of a

Re: [PATCH v3 03/13] compiler.h: remove GCC < 3 __builtin_expect fallback

2020-12-14 Thread Paolo Bonzini
On 10/12/20 15:32, Philippe Mathieu-Daudé wrote: On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >= 4.8. (clang >= 3.4 advertizes itself as GCC >= 4

Re: [PATCH v4 1/3] xen/arm: add support for run_in_exception_handler()

2020-12-14 Thread Julien Grall
Hi Juergen, On 14/12/2020 07:56, Juergen Gross wrote: Add support to run a function in an exception handler for Arm. Do it the same way as on x86 via a bug_frame. Unfortunately inline assembly on Arm seems to be less capable than on x86, leading to functions called via run_in_exception_handler(

Re: [PATCH v3 00/13] Remove GCC < 4.8 checks

2020-12-14 Thread Paolo Bonzini
On 10/12/20 14:47, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Hi, Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >= 4.8. v3: - drop first patch replacing QEMU_GNUC_PREREQ with G_GNUC_CHECK_VERSION - add last

Re: [PATCH v4 3/3] xen: add support for automatic debug key actions in case of crash

2020-12-14 Thread Julien Grall
Hi Juergen, On 14/12/2020 07:56, Juergen Gross wrote: diff --git a/xen/common/keyhandler.c b/xen/common/keyhandler.c index de120fa092..806355ed8b 100644 --- a/xen/common/keyhandler.c +++ b/xen/common/keyhandler.c @@ -3,7 +3,9 @@ */ #include +#include #include +#include #include

Re: [PATCH v4 23/32] qdev: Move dev->realized check to qdev_property_set()

2020-12-14 Thread Cornelia Huck
On Fri, 11 Dec 2020 17:05:20 -0500 Eduardo Habkost wrote: > Every single qdev property setter function manually checks > dev->realized. We can just check dev->realized inside > qdev_property_set() instead. > > The check is being added as a separate function > (qdev_prop_allow_set()) because it

Re: [PATCH v4 1/3] xen/arm: add support for run_in_exception_handler()

2020-12-14 Thread Jürgen Groß
On 14.12.20 11:17, Julien Grall wrote: Hi Juergen, On 14/12/2020 07:56, Juergen Gross wrote: Add support to run a function in an exception handler for Arm. Do it the same way as on x86 via a bug_frame. Unfortunately inline assembly on Arm seems to be less capable than on x86, leading to functi

Re: [XEN PATCH v1 1/1] Invalidate cache for cpus affinitized to the domain

2020-12-14 Thread Julien Grall
Hi Harsha, On 14/12/2020 09:26, Shamsundara Havanur, Harsha wrote: On Mon, 2020-12-14 at 09:52 +0100, Jan Beulich wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On

Re: [PATCH v4 30/32] qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr()

2020-12-14 Thread Cornelia Huck
On Fri, 11 Dec 2020 17:05:27 -0500 Eduardo Habkost wrote: > The function will be moved to common QOM code, as it is not > specific to TYPE_DEVICE anymore. > > Reviewed-by: Stefan Berger > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * Rename to object_field_prop_ptr() instead of

[ovmf test] 157513: regressions - FAIL

2020-12-14 Thread osstest service owner
flight 157513 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/157513/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 157345 test-amd64-amd64-xl-qemuu

Re: [PATCH v4 3/3] xen: add support for automatic debug key actions in case of crash

2020-12-14 Thread Jürgen Groß
On 14.12.20 11:24, Julien Grall wrote: Hi Juergen, On 14/12/2020 07:56, Juergen Gross wrote: diff --git a/xen/common/keyhandler.c b/xen/common/keyhandler.c index de120fa092..806355ed8b 100644 --- a/xen/common/keyhandler.c +++ b/xen/common/keyhandler.c @@ -3,7 +3,9 @@    */   #include +#include

Re: [PATCH v4 1/3] xen/arm: add support for run_in_exception_handler()

2020-12-14 Thread Julien Grall
Hi Juergen, On 14/12/2020 10:51, Jürgen Groß wrote: On 14.12.20 11:17, Julien Grall wrote: Hi Juergen, On 14/12/2020 07:56, Juergen Gross wrote: Add support to run a function in an exception handler for Arm. Do it the same way as on x86 via a bug_frame. Unfortunately inline assembly on Arm s

Re: [PATCH v4 1/3] xen/arm: add support for run_in_exception_handler()

2020-12-14 Thread Jürgen Groß
On 14.12.20 12:14, Julien Grall wrote: Hi Juergen, On 14/12/2020 10:51, Jürgen Groß wrote: On 14.12.20 11:17, Julien Grall wrote: Hi Juergen, On 14/12/2020 07:56, Juergen Gross wrote: Add support to run a function in an exception handler for Arm. Do it the same way as on x86 via a bug_frame.

Re: [PATCH v4 1/3] xen/arm: add support for run_in_exception_handler()

2020-12-14 Thread Julien Grall
Hi Juergen, On 14/12/2020 11:21, Jürgen Groß wrote: On 14.12.20 12:14, Julien Grall wrote: Hi Juergen, On 14/12/2020 10:51, Jürgen Groß wrote: On 14.12.20 11:17, Julien Grall wrote: Hi Juergen, On 14/12/2020 07:56, Juergen Gross wrote: Add support to run a function in an exception handler

Re: [PATCH v4 1/3] xen/arm: add support for run_in_exception_handler()

2020-12-14 Thread Jürgen Groß
On 14.12.20 12:21, Jürgen Groß wrote: On 14.12.20 12:14, Julien Grall wrote: Hi Juergen, On 14/12/2020 10:51, Jürgen Groß wrote: On 14.12.20 11:17, Julien Grall wrote: Hi Juergen, On 14/12/2020 07:56, Juergen Gross wrote: Add support to run a function in an exception handler for Arm. Do it

[xen-unstable test] 157512: tolerable FAIL

2020-12-14 Thread osstest service owner
flight 157512 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/157512/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 157451 pass in 157512 test-amd64-i386-xl-qemut-d

Re: [PATCH] Revert "x86/mm: drop guest_get_eff_l1e()"

2020-12-14 Thread Andrew Cooper
On 14/12/2020 08:27, Jan Beulich wrote: > On 11.12.2020 15:16, Andrew Cooper wrote: >> This reverts commit 9ff9705647646aa937b5f5c1426a64c69a62b3bd. >> >> The change is only correct in the original context of XSA-286, where Xen's >> use >> of the linear pagetables were dropped. However, performan

Re: [PATCH] Revert "x86/mm: drop guest_get_eff_l1e()"

2020-12-14 Thread Jan Beulich
On 14.12.2020 14:21, Andrew Cooper wrote: > On 14/12/2020 08:27, Jan Beulich wrote: >> On 11.12.2020 15:16, Andrew Cooper wrote: >>> This reverts commit 9ff9705647646aa937b5f5c1426a64c69a62b3bd. >>> >>> The change is only correct in the original context of XSA-286, where Xen's >>> use >>> of the l

[PATCH] x86/PV: guest_get_eff_kern_l1e() may still need to switch page tables

2020-12-14 Thread Jan Beulich
While indeed unnecessary for pv_ro_page_fault(), pv_map_ldt_shadow_page() may run when guest user mode is active, and hence may need to switch to the kernel page tables in order to retrieve an LDT page mapping. Fixes: 9ff970564764 ("x86/mm: drop guest_get_eff_l1e()") Reported-by: Manuel Bouyer Si

Re: [PATCH] x86/PV: guest_get_eff_kern_l1e() may still need to switch page tables

2020-12-14 Thread Andrew Cooper
On 14/12/2020 13:57, Jan Beulich wrote: > While indeed unnecessary for pv_ro_page_fault(), pv_map_ldt_shadow_page() > may run when guest user mode is active, and hence may need to switch to > the kernel page tables in order to retrieve an LDT page mapping. > > Fixes: 9ff970564764 ("x86/mm: drop gue

Re: [PATCH v4 23/32] qdev: Move dev->realized check to qdev_property_set()

2020-12-14 Thread Igor Mammedov
On Fri, 11 Dec 2020 17:05:20 -0500 Eduardo Habkost wrote: > Every single qdev property setter function manually checks > dev->realized. We can just check dev->realized inside > qdev_property_set() instead. > > The check is being added as a separate function > (qdev_prop_allow_set()) because it

Re: [PATCH v4 30/32] qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr()

2020-12-14 Thread Igor Mammedov
On Fri, 11 Dec 2020 17:05:27 -0500 Eduardo Habkost wrote: > The function will be moved to common QOM code, as it is not > specific to TYPE_DEVICE anymore. > > Reviewed-by: Stefan Berger > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Changes v1 -> v2: > * Rename to objec

[ovmf test] 157521: regressions - FAIL

2020-12-14 Thread osstest service owner
flight 157521 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/157521/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 157345 test-amd64-amd64-xl-qemuu

[qemu-mainline test] 157514: regressions - FAIL

2020-12-14 Thread osstest service owner
flight 157514 qemu-mainline real [real] flight 157523 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157514/ http://logs.test-lab.xenproject.org/osstest/logs/157523/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [XEN PATCH v1 1/1] Invalidate cache for cpus affinitized to the domain

2020-12-14 Thread Andrew Cooper
On 14/12/2020 10:56, Julien Grall wrote: > Hi Harsha, > > On 14/12/2020 09:26, Shamsundara Havanur, Harsha wrote: >> On Mon, 2020-12-14 at 09:52 +0100, Jan Beulich wrote: >>> CAUTION: This email originated from outside of the organization. Do >>> not click links or open attachments unless you can c

Re: [PATCH] x86/PV: guest_get_eff_kern_l1e() may still need to switch page tables

2020-12-14 Thread Manuel Bouyer
On Mon, Dec 14, 2020 at 02:57:53PM +0100, Jan Beulich wrote: > While indeed unnecessary for pv_ro_page_fault(), pv_map_ldt_shadow_page() > may run when guest user mode is active, and hence may need to switch to > the kernel page tables in order to retrieve an LDT page mapping. > > Fixes: 9ff970564

[ovmf test] 157525: regressions - FAIL

2020-12-14 Thread osstest service owner
flight 157525 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/157525/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 157345 test-amd64-amd64-xl-qemuu

Re: [PATCH v3 01/13] qemu/atomic: Drop special case for unsupported compiler

2020-12-14 Thread Stefan Hajnoczi
On Thu, Dec 10, 2020 at 05:47:40PM +0400, marcandre.lur...@redhat.com wrote: > From: Philippe Mathieu-Daudé > > Since commit efc6c070aca ("configure: Add a test for the > minimum compiler version") the minimum compiler version > required for GCC is 4.8, which has the GCC BZ#36793 bug fixed. > >

Re: [PATCH v3 06/13] virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON

2020-12-14 Thread Stefan Hajnoczi
On Thu, Dec 10, 2020 at 05:47:45PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This allows to get rid of a check for older GCC version (which was a bit > bogus too since it was falling back on c++ version..) > > Signed-off-by: Marc-André Lureau > --- > tools/virtiof

Re: [PATCH v4 23/32] qdev: Move dev->realized check to qdev_property_set()

2020-12-14 Thread Eduardo Habkost
On Mon, Dec 14, 2020 at 03:55:30PM +0100, Igor Mammedov wrote: > On Fri, 11 Dec 2020 17:05:20 -0500 > Eduardo Habkost wrote: > > > Every single qdev property setter function manually checks > > dev->realized. We can just check dev->realized inside > > qdev_property_set() instead. > > > > The ch

[linux-linus test] 157519: regressions - FAIL

2020-12-14 Thread osstest service owner
flight 157519 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/157519/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

[PATCH 05/24] Introduce locking functions for block device setup on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/hotplug/NetBSD/Makefile | 1 + tools/hotplug/NetBSD/block | 5 ++- tools/hotplug/NetBSD/locking.sh | 72 + 3 files changed, 77 insertions(+), 1 deletion(-) create mode 100644 tools/hotplug/NetBSD/locking.sh diff --git a/tools/hotplug/NetBSD/Make

[PATCH 03/24] Fix lock directory path for NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/configure b/tools/configure index 8a708e9baa..131112c41e 100755 --- a/tools/configure +++ b/tools/configure @@ -4030,7 +4030,7 @@ XEN_SCRIPT_DIR=$XEN_CONFIG_DIR/scripts case "$host_os" in *freebsd*) X

[PATCH 07/24] Remove NetBSD's system headers. We'll use the system-provided ones, which are up to date.

2020-12-14 Thread Manuel Bouyer
--- tools/include/Makefile | 2 +- tools/include/xen-sys/NetBSD/evtchn.h | 86 tools/include/xen-sys/NetBSD/privcmd.h | 106 - 3 files changed, 1 insertion(+), 193 deletions(-) delete mode 100644 tools/include/xen-sys/NetBSD/evtchn.

[PATCH 15/24] Make libs/light build on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/light/libxl_dm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 5948ace60d..c93bdf2cc9 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -3659,6 +3659,14 @@ static int kill_dev

[PATCH 00/24] NetBSD fixes

2020-12-14 Thread Manuel Bouyer
Hello, here is a set of 24 patches, which are needed to build and run the tools on NetBSD. They are extracted from NetBSD's pkgsrc repository for Xen 4.13, and ported to 4.15. Manuel Bouyer (24): Fix lock directory path for NetBSD NetBSD doens't need xenbackendd with xl toolstack Fix lock d

[PATCH 04/24] Make xg_main.c build on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/debugger/gdbsx/xg/xg_main.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tools/debugger/gdbsx/xg/xg_main.c b/tools/debugger/gdbsx/xg/xg_main.c index a4e8653168..fa2741ccf8 100644 --- a/tools/debugger/gdbsx/xg/xg_main.c +++ b/tools/debugger/gdbsx/xg/xg_main.c @@ -49,7

[PATCH 20/24] If FILENAME_MAX is defined, use it instead of arbitrary value (fix format-truncation errors with GCC >= 7)

2020-12-14 Thread Manuel Bouyer
--- tools/xenpmd/xenpmd.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/xenpmd/xenpmd.c b/tools/xenpmd/xenpmd.c index 12b82cf43e..cfd22e64e3 100644 --- a/tools/xenpmd/xenpmd.c +++ b/tools/xenpmd/xenpmd.c @@ -101,7 +101,11 @@ FILE *get_next_battery_file(DIR *battery_dir, { FIL

[PATCH 12/24] Implement gnttab on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/gnttab/Makefile | 2 +- tools/libs/gnttab/netbsd.c | 267 + 2 files changed, 268 insertions(+), 1 deletion(-) create mode 100644 tools/libs/gnttab/netbsd.c diff --git a/tools/libs/gnttab/Makefile b/tools/libs/gnttab/Makefile index d86c49d243..

[PATCH 13/24] Don't assume tv_sec is a unsigned long (for NetBSD)

2020-12-14 Thread Manuel Bouyer
--- tools/libs/light/libxl_create.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index 321a13e519..44691010bc 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -496,

[PATCH 09/24] Use xen/xenio.h on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/call/private.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/libs/call/private.h b/tools/libs/call/private.h index 21f992b37e..96922e03d5 100644 --- a/tools/libs/call/private.h +++ b/tools/libs/call/private.h @@ -7,13 +7,19 @@ #include #includ

[PATCH 10/24] Make libs/evtchn build on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/evtchn/netbsd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libs/evtchn/netbsd.c b/tools/libs/evtchn/netbsd.c index 8b8545d2f9..6d4ce28011 100644 --- a/tools/libs/evtchn/netbsd.c +++ b/tools/libs/evtchn/netbsd.c @@ -25,10 +25,10 @@ #include

[PATCH 11/24] Implement foreignmemory on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/foreignmemory/Makefile | 2 +- tools/libs/foreignmemory/netbsd.c | 76 ++ tools/libs/foreignmemory/private.h | 10 +++- 3 files changed, 75 insertions(+), 13 deletions(-) diff --git a/tools/libs/foreignmemory/Makefile b/tools/libs/foreignmemory/Makef

[PATCH 01/24] Fix lock directory path for NetBSD

2020-12-14 Thread Manuel Bouyer
--- m4/paths.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/paths.m4 b/m4/paths.m4 index 89d3bb8312..1c107b1a61 100644 --- a/m4/paths.m4 +++ b/m4/paths.m4 @@ -142,7 +142,7 @@ AC_SUBST(XEN_SCRIPT_DIR) case "$host_os" in *freebsd*) XEN_LOCK_DIR=$localstatedir/lib ;; -*

[PATCH 22/24] If PTHREAD_STACK_MIN is not defined, use DEFAULT_THREAD_STACKSIZE

2020-12-14 Thread Manuel Bouyer
--- tools/libs/store/xs.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/libs/store/xs.c b/tools/libs/store/xs.c index 4ac73ec317..8e646b98d6 100644 --- a/tools/libs/store/xs.c +++ b/tools/libs/store/xs.c @@ -811,9 +811,13 @@ bool xs_watch(struct xs_handle *h, const char *path, cons

[PATCH 17/24] Make libs/light build on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/light/libxl_uuid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libs/light/libxl_uuid.c b/tools/libs/light/libxl_uuid.c index dadb79bad8..a8ee5f253e 100644 --- a/tools/libs/light/libxl_uuid.c +++ b/tools/libs/light/libxl_uuid.c @@ -82,7 +82,7 @@ void

[PATCH 02/24] NetBSD doens't need xenbackendd with xl toolstack

2020-12-14 Thread Manuel Bouyer
--- tools/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/Makefile b/tools/Makefile index ed71474421..757a560be0 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -18,7 +18,6 @@ SUBDIRS-$(CONFIG_X86) += firmware SUBDIRS-y += console SUBDIRS-y += xenmon SUBDIRS-y += xentop -S

[PATCH 19/24] errno may not be a gobal R/W variable, use a local variable instead (fix build on NetBSD)

2020-12-14 Thread Manuel Bouyer
--- tools/xenpaging/xenpaging.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c index 33098046c2..39c8c83b4b 100644 --- a/tools/xenpaging/xenpaging.c +++ b/tools/xenpaging/xenpaging.c @@ -180,10 +180,11 @@ static in

[PATCH 14/24] Pass bridge name to qemu and set XEN_DOMAIN_ID

2020-12-14 Thread Manuel Bouyer
Pass bridge name to qemu When starting qemu, set an environnement variable XEN_DOMAIN_ID, to be used by qemu helper scripts --- tools/libs/light/libxl_dm.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 3da83259c0..5

[PATCH 08/24] Make libs/call build on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/call/netbsd.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tools/libs/call/netbsd.c b/tools/libs/call/netbsd.c index a5502da377..1a771e9928 100644 --- a/tools/libs/call/netbsd.c +++ b/tools/libs/call/netbsd.c @@ -19,12 +19,14 @@ * Split f

[PATCH 24/24] Fix error: array subscript has type 'char' [-Werror=char-subscripts]

2020-12-14 Thread Manuel Bouyer
--- tools/libs/light/libxl_qmp.c | 2 +- tools/xentrace/xentrace.c| 2 +- xen/tools/symbols.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libs/light/libxl_qmp.c b/tools/libs/light/libxl_qmp.c index c394000ea9..9b638e6f54 100644 --- a/tools/libs/light

[PATCH 16/24] Switch NetBSD to QEMU_XEN (!traditional)

2020-12-14 Thread Manuel Bouyer
--- tools/libs/light/libxl_netbsd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_netbsd.c b/tools/libs/light/libxl_netbsd.c index e66a393d7f..31334f932c 100644 --- a/tools/libs/light/libxl_netbsd.c +++ b/tools/libs/light/libxl_netbsd.c @@ -110,7 +110,7

[PATCH 18/24] xeneventchn_stubs.c doens't need xen/sys/evtchn.h (NetBSD fix)

2020-12-14 Thread Manuel Bouyer
--- tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c index ba40078d09..f889a7a2e4 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c +++ b/tools/oc

[PATCH 06/24] Handle the case where vifname is not present in xenstore.

2020-12-14 Thread Manuel Bouyer
--- tools/hotplug/NetBSD/vif-bridge | 5 - tools/hotplug/NetBSD/vif-ip | 4 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/hotplug/NetBSD/vif-bridge b/tools/hotplug/NetBSD/vif-bridge index b58e922601..cd428b5936 100644 --- a/tools/hotplug/NetBSD/vif-bridge +++ b/t

[PATCH 21/24] Fix unused functions/variables error

2020-12-14 Thread Manuel Bouyer
--- tools/libs/stat/xenstat_netbsd.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/tools/libs/stat/xenstat_netbsd.c b/tools/libs/stat/xenstat_netbsd.c index 6e9d6aee10..64eda9e1ae 100644 --- a/tools/libs/stat/xenstat_netbsd.c +++ b/tools/libs/stat/xenstat_netbsd.c @@ -55,11 +55,6

[PATCH 23/24] Use xen/xenio.h on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/ctrl/xc_private.h | 4 1 file changed, 4 insertions(+) diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h index f0b5f83ac8..68e388f488 100644 --- a/tools/libs/ctrl/xc_private.h +++ b/tools/libs/ctrl/xc_private.h @@ -39,7 +39,11 @@ #include #include

[PATCH v2 0/4] nbd/server: Quiesce coroutines on context switch

2020-12-14 Thread Sergio Lopez
This series allows the NBD server to properly switch between AIO contexts, having quiesced recv_coroutine and send_coroutine before doing the transition. We need this because we send back devices running in IO Thread owned contexts to the main context when stopping the data plane, something that c

[PATCH v2 2/4] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

2020-12-14 Thread Sergio Lopez
While processing the parents of a BDS, one of the parents may process the child that's doing the tail recursion, which leads to a BDS being processed twice. This is especially problematic for the aio_notifiers, as they might attempt to work on both the old and the new AIO contexts. To avoid this,

[PATCH v2 1/4] block: Honor blk_set_aio_context() context requirements

2020-12-14 Thread Sergio Lopez
The documentation for bdrv_set_aio_context_ignore() states this: * The caller must own the AioContext lock for the old AioContext of bs, but it * must not own the AioContext lock for new_context (unless new_context is the * same as the current context of bs). As blk_set_aio_context() makes use

[PATCH v2 3/4] nbd/server: Quiesce coroutines on context switch

2020-12-14 Thread Sergio Lopez
When switching between AIO contexts we need to me make sure that both recv_coroutine and send_coroutine are not scheduled to run. Otherwise, QEMU may crash while attaching the new context with an error like this one: aio_co_schedule: Co-routine was already scheduled in 'aio_co_schedule' To achiev

[PATCH v2 4/4] block: Close block exports in two steps

2020-12-14 Thread Sergio Lopez
There's a cross-dependency between closing the block exports and draining the block layer. The latter needs that we close all export's client connections to ensure they won't queue more requests, but the exports may have coroutines yielding in the block layer, which implies they can't be fully clos

Re: [XEN PATCH v1 1/1] Invalidate cache for cpus affinitized to the domain

2020-12-14 Thread Shamsundara Havanur, Harsha
On Mon, 2020-12-14 at 16:01 +, Andrew Cooper wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > On 14/12/2020 10:56, Julien Grall wrote: > > Hi Harsha, >

Re: [PATCH v3 7/8] xen/arm: Add support for SMMUv3 driver

2020-12-14 Thread Rahul Singh
Hello Julien, > On 11 Dec 2020, at 2:25 pm, Julien Grall wrote: > > Hi Rahul, > > On 10/12/2020 16:57, Rahul Singh wrote: >> struct arm_smmu_strtab_cfg { >> @@ -613,8 +847,13 @@ struct arm_smmu_device { >> u64 padding; >> }; >> - /* IOMMU core code hand

Re: [PATCH v3 7/8] xen/arm: Add support for SMMUv3 driver

2020-12-14 Thread Julien Grall
On 14/12/2020 19:08, Rahul Singh wrote: Hello Julien, Hi Rahul, On 11 Dec 2020, at 2:25 pm, Julien Grall wrote: Hi Rahul, On 10/12/2020 16:57, Rahul Singh wrote: struct arm_smmu_strtab_cfg { @@ -613,8 +847,13 @@ struct arm_smmu_device { u64 paddi

Re: [XEN PATCH v1 1/1] Invalidate cache for cpus affinitized to the domain

2020-12-14 Thread Andrew Cooper
On 14/12/2020 19:05, Shamsundara Havanur, Harsha wrote: > On Mon, 2020-12-14 at 16:01 +, Andrew Cooper wrote: >> CAUTION: This email originated from outside of the organization. Do >> not click links or open attachments unless you can confirm the sender >> and know the content is safe. >> >> >>

Re: [PATCH v3 0/8] xen/arm: Add support for SMMUv3 driver

2020-12-14 Thread Rahul Singh
Hello Julien,Stefano > On 11 Dec 2020, at 2:29 pm, Julien Grall wrote: > > Hi Rahul, > > On 10/12/2020 16:56, Rahul Singh wrote: >> This patch series is v3 of the work to add support for the SMMUv3 driver. >> Approach taken is to first merge the Linux copy of the SMMUv3 driver >> (tag v5.8.18)

xen/evtchn: Interrupt for port 34, but apparently not enabled; per-user 00000000a86a4c1b on 5.10

2020-12-14 Thread Julien Grall
Hi Juergen, When testing Linux 5.10 dom0, I could reliably hit the following warning with using event 2L ABI: [ 589.591737] Interrupt for port 34, but apparently not enabled; per-user a86a4c1b [ 589.593259] WARNING: CPU: 0 PID: at /home/ANT.AMAZON.COM/jgrall/works/oss/linux/dr

Re: [patch 22/30] net/mlx5: Replace irq_to_desc() abuse

2020-12-14 Thread Saeed Mahameed
On Thu, 2020-12-10 at 20:25 +0100, Thomas Gleixner wrote: > No driver has any business with the internals of an interrupt > descriptor. Storing a pointer to it just to use yet another helper at > the > actual usage site to retrieve the affinity mask is creative at best. > Just > because C does not

Re: [patch 23/30] net/mlx5: Use effective interrupt affinity

2020-12-14 Thread Saeed Mahameed
On Thu, 2020-12-10 at 20:25 +0100, Thomas Gleixner wrote: > Using the interrupt affinity mask for checking locality is not really > working well on architectures which support effective affinity masks. > > The affinity mask is either the system wide default or set by user > space, > but the archit

Re: kexec not working in xen domU?

2020-12-14 Thread Guilherme G. Piccoli
On Wed, Dec 9, 2020 at 4:13 PM Phillip Susi wrote: > > Whenever I try to use kexec in a xen domU, the domain just reboots all > the way through the bios rather than loading the kexec'ed kernel with > the given command line. Is this a known issue? I've tried with both > systemctl kexec and kexec

Re: kexec not working in xen domU?

2020-12-14 Thread Phillip Susi
Guilherme G. Piccoli writes: > Can you capture the serial console in a pastebin? Maybe add something > like "earlyprintk=ttySX", where ttySX is your known-to-work serial > console output. This helps to determine if it's a shutdown issue or an > early boot problem. The regular xen cosole should

Re: [openxt-dev] Re: Follow up on libxl-fix-reboot.patch

2020-12-14 Thread Rich Persaud
(adding xen-devel & toolstack devs) On Dec 14, 2020, at 16:12, Jason Andryuk wrote: > > On Fri, Dec 11, 2020 at 3:56 PM Chris Rogers wrote: >> >> This is a follow up to a request during our roadmapping meeting to clarify >> the purpose of libxl-fix-reboot.patch on the current version of Xen

[ovmf test] 157527: regressions - FAIL

2020-12-14 Thread osstest service owner
flight 157527 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/157527/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 157345 test-amd64-amd64-xl-qemuu

[qemu-mainline test] 157526: regressions - FAIL

2020-12-14 Thread osstest service owner
flight 157526 qemu-mainline real [real] flight 157532 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157526/ http://logs.test-lab.xenproject.org/osstest/logs/157532/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [openxt-dev] Re: Follow up on libxl-fix-reboot.patch

2020-12-14 Thread Stefano Stabellini
On Mon, 14 Dec 2020, Rich Persaud wrote: > (adding xen-devel & toolstack devs) > > On Dec 14, 2020, at 16:12, Jason Andryuk wrote: > > > > On Fri, Dec 11, 2020 at 3:56 PM Chris Rogers wrote: > >> > >> This is a follow up to a request during our roadmapping meeting to clarify > >> the purpose

[ovmf test] 157531: regressions - FAIL

2020-12-14 Thread osstest service owner
flight 157531 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/157531/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 157345 build-i386

Re: [PATCH v3 0/8] xen/arm: Add support for SMMUv3 driver

2020-12-14 Thread Stefano Stabellini
On Mon, 14 Dec 2020, Rahul Singh wrote: > Hello Julien,Stefano > > > On 11 Dec 2020, at 2:29 pm, Julien Grall wrote: > > > > Hi Rahul, > > > > On 10/12/2020 16:56, Rahul Singh wrote: > >> This patch series is v3 of the work to add support for the SMMUv3 driver. > >> Approach taken is to first m

[ovmf test] 157535: regressions - FAIL

2020-12-14 Thread osstest service owner
flight 157535 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/157535/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i3866 xen-buildfail REGR. vs. 157345 build-amd64

Xen-ARM DomUs

2020-12-14 Thread Elliott Mitchell
Finally getting to the truly productive stages of my project with Xen on ARM. How many of the OSes which function as x86 DomUs for Xen, function as ARM DomUs? Getting Linux operational was straightforward, but what of others? The available examples seem geared towards Linux DomUs. I'm looking a

Re: Xen-ARM DomUs

2020-12-14 Thread Roman Shaposhnik
On Mon, Dec 14, 2020 at 6:16 PM Elliott Mitchell wrote: > > Finally getting to the truly productive stages of my project with Xen on > ARM. > > How many of the OSes which function as x86 DomUs for Xen, function as > ARM DomUs? Getting Linux operational was straightforward, but what of > others?

[PATCH] examples: Add PVH example to config example list

2020-12-14 Thread Elliott Mitchell
Somewhat helpful to actually install the example configurations. Signed-off-by: Elliott Mitchell --- tools/examples/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/examples/Makefile b/tools/examples/Makefile index f86ed3a271..fd8fba757d 100644 --- a/tools/examples/Makefile +++

[ovmf test] 157537: regressions - FAIL

2020-12-14 Thread osstest service owner
flight 157537 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/157537/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i3866 xen-buildfail REGR. vs. 157345 build-amd64

[linux-linus test] 157529: regressions - FAIL

2020-12-14 Thread osstest service owner
flight 157529 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/157529/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

Re: Xen-ARM DomUs

2020-12-14 Thread Elliott Mitchell
On Mon, Dec 14, 2020 at 06:35:14PM -0800, Roman Shaposhnik wrote: > On Mon, Dec 14, 2020 at 6:16 PM Elliott Mitchell wrote: > > > > Finally getting to the truly productive stages of my project with Xen on > > ARM. > > > > How many of the OSes which function as x86 DomUs for Xen, function as > > AR

Re: Xen-ARM DomUs

2020-12-14 Thread Roman Shaposhnik
On Mon, Dec 14, 2020 at 6:59 PM Elliott Mitchell wrote: > > On Mon, Dec 14, 2020 at 06:35:14PM -0800, Roman Shaposhnik wrote: > > On Mon, Dec 14, 2020 at 6:16 PM Elliott Mitchell wrote: > > > > > > Finally getting to the truly productive stages of my project with Xen on > > > ARM. > > > > > > How

  1   2   >