[libvirt test] 157369: regressions - trouble: blocked/fail/pass/starved

2020-12-10 Thread osstest service owner
flight 157369 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/157369/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

RE: [PATCH V3 17/23] xen/ioreq: Introduce domain_has_ioreq_server()

2020-12-10 Thread Paul Durrant
> -Original Message- > From: Oleksandr > Sent: 09 December 2020 20:36 > To: p...@xen.org > Cc: 'Jan Beulich' ; 'Oleksandr Tyshchenko' > ; > 'Stefano Stabellini' ; 'Julien Grall' > ; 'Volodymyr Babchuk' > ; 'Andrew Cooper' ; > 'George Dunlap' > ; 'Ian Jackson' ; 'Wei Liu' > ; 'Julien Gr

[qemu-mainline test] 157361: regressions - FAIL

2020-12-10 Thread osstest service owner
flight 157361 qemu-mainline real [real] flight 157374 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157361/ http://logs.test-lab.xenproject.org/osstest/logs/157374/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: dom0 PV looping on search_pre_exception_table()

2020-12-10 Thread Manuel Bouyer
On Wed, Dec 09, 2020 at 07:08:41PM +, Andrew Cooper wrote: > Oh of course - we don't follow the exit-to-guest path on the way out here. > > As a gross hack to check that we've at least diagnosed the issue > appropriately, could you modify NetBSD to explicitly load the %ss > selector into %es (

[PATCH] xen/arm: Add workaround for Cortex-A53 erratum #843419

2020-12-10 Thread Luca Fancellu
On the Cortex A53, when executing in AArch64 state, a load or store instruction which uses the result of an ADRP instruction as a base register, or which uses a base register written by an instruction immediately after an ADRP to the same register, might access an incorrect address. The workaround

Re: [PATCH v2 05/12] x86: rework arch_local_irq_restore() to not use popf

2020-12-10 Thread Mark Rutland
On Wed, Dec 09, 2020 at 07:54:26PM +0100, Thomas Gleixner wrote: > On Wed, Dec 09 2020 at 18:15, Mark Rutland wrote: > > In arch/x86/kernel/apic/io_apic.c's timer_irq_works() we do: > > > > local_irq_save(flags); > > local_irq_enable(); > > > > [ trigger an IRQ here ] > > > > local_

Re: [PATCH 2/2] xen: don't use page->lru for ZONE_DEVICE memory

2020-12-10 Thread Roger Pau Monné
On Tue, Dec 08, 2020 at 07:45:00AM +0100, Jürgen Groß wrote: > On 07.12.20 21:48, Jason Andryuk wrote: > > On Mon, Dec 7, 2020 at 8:30 AM Juergen Gross wrote: > > > > > > Commit 9e2369c06c8a18 ("xen: add helpers to allocate unpopulated > > > memory") introduced usage of ZONE_DEVICE memory for for

[xen-unstable test] 157365: tolerable FAIL

2020-12-10 Thread osstest service owner
flight 157365 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/157365/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-examine4 memdisk-try-append fail in 157335 pass in 157365 test-armhf-armhf-xl-rtds 18 gues

Re: [PATCH 2/2] xen: don't use page->lru for ZONE_DEVICE memory

2020-12-10 Thread Jürgen Groß
On 10.12.20 12:14, Roger Pau Monné wrote: On Tue, Dec 08, 2020 at 07:45:00AM +0100, Jürgen Groß wrote: On 07.12.20 21:48, Jason Andryuk wrote: On Mon, Dec 7, 2020 at 8:30 AM Juergen Gross wrote: Commit 9e2369c06c8a18 ("xen: add helpers to allocate unpopulated memory") introduced usage of ZON

Re: dom0 PV looping on search_pre_exception_table()

2020-12-10 Thread Jan Beulich
On 10.12.2020 10:51, Manuel Bouyer wrote: > On Wed, Dec 09, 2020 at 07:08:41PM +, Andrew Cooper wrote: >> Oh of course - we don't follow the exit-to-guest path on the way out here. >> >> As a gross hack to check that we've at least diagnosed the issue >> appropriately, could you modify NetBSD t

Re: [PATCH RFC 0/3] xen: add hypfs per-domain abi-features

2020-12-10 Thread Jürgen Groß
On 09.12.20 17:24, Julien Grall wrote: Hi, On 09/12/2020 16:16, Juergen Gross wrote: This small series is meant as an example how to add further dynamical directories to hypfs. It can be used to replace Paul's current approach to specify ABI-features via domain create flags and replace those by

Re: [PATCH RFC 2/3] xen/domain: add domain hypfs directories

2020-12-10 Thread Jürgen Groß
On 09.12.20 17:37, Julien Grall wrote: Hi Juergen, On 09/12/2020 16:16, Juergen Gross wrote: Add /domain/ directories to hypfs. Those are completely dynamic, so the related hypfs access functions need to be implemented. Signed-off-by: Juergen Gross --- V3: - new patch ---   docs/misc/hypfs-pa

Re: [PATCH v3 1/8] xen: fix build when $(obj-y) consists of just blanks

2020-12-10 Thread Jan Beulich
On 09.12.2020 18:40, Anthony PERARD wrote: > On Mon, Nov 23, 2020 at 04:20:52PM +0100, Jan Beulich wrote: >> This case can occur when combining empty lists >> >> obj-y := >> ... >> obj-y += $(empty) >> >> or >> >> obj-y := $(empty) $(empty) >> >> where (only) blanks would accumulate. This was only

Re: [PATCH RFC 2/3] xen/domain: add domain hypfs directories

2020-12-10 Thread Julien Grall
On 10/12/2020 07:54, Jürgen Groß wrote: On 09.12.20 17:37, Julien Grall wrote:   only the syntax used in this document):   * STRING -- an arbitrary 0-delimited byte string. @@ -191,6 +192,15 @@ The scheduling granularity of a cpupool.   Writing a value is allowed only for cpupools with no cpu

Re: [PATCH RFC 0/3] xen: add hypfs per-domain abi-features

2020-12-10 Thread Julien Grall
On 10/12/2020 07:49, Jürgen Groß wrote: On 09.12.20 17:24, Julien Grall wrote: Hi, On 09/12/2020 16:16, Juergen Gross wrote: This small series is meant as an example how to add further dynamical directories to hypfs. It can be used to replace Paul's current approach to specify ABI-features

Re: [PATCH RFC 2/3] xen/domain: add domain hypfs directories

2020-12-10 Thread Jürgen Groß
On 10.12.20 12:51, Julien Grall wrote: On 10/12/2020 07:54, Jürgen Groß wrote: On 09.12.20 17:37, Julien Grall wrote:   only the syntax used in this document):   * STRING -- an arbitrary 0-delimited byte string. @@ -191,6 +192,15 @@ The scheduling granularity of a cpupool.   Writing a value i

Re: [PATCH V3 18/23] xen/dm: Introduce xendevicemodel_set_irq_level DM op

2020-12-10 Thread Oleksandr
On 10.12.20 04:21, Stefano Stabellini wrote: Hi Stefano On Mon, 30 Nov 2020, Oleksandr Tyshchenko wrote: From: Julien Grall This patch adds ability to the device emulator to notify otherend (some entity running in the guest) using a SPI and implements Arm specific bits for it. Proposed int

[ovmf test] 157366: regressions - FAIL

2020-12-10 Thread osstest service owner
flight 157366 ovmf real [real] flight 157381 ovmf real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157366/ http://logs.test-lab.xenproject.org/osstest/logs/157381/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-

Re: [PATCH] x86/HVM: refine when to send mapcache invalidation request to qemu

2020-12-10 Thread Hongyan Xia
I came across the same issue when QEMU was holding an extra reference to a page removed from p2m, via XENMEM_add_to_physmap. Please tell me if I am talking nonsense since my knowledge around QEMU invalidation is limited. On Mon, 2020-09-28 at 12:44 +0200, Jan Beulich wrote: > For one it was wrong

Re: [PATCH V3 15/23] xen/arm: Stick around in leave_hypervisor_to_guest until I/O has completed

2020-12-10 Thread Julien Grall
Hi Stefano, On 10/12/2020 02:30, Stefano Stabellini wrote: I am also wondering if there is any benefit in calling wait_for_io() earlier, maybe from try_handle_mmio if IO_RETRY? wait_for_io() may end up to deschedule the vCPU. I would like to avoid this to happen in the middle of the I/O emulat

Re: [PATCH V3 15/23] xen/arm: Stick around in leave_hypervisor_to_guest until I/O has completed

2020-12-10 Thread Oleksandr
On 10.12.20 04:30, Stefano Stabellini wrote: Hi Julien, Stefano On Wed, 9 Dec 2020, Julien Grall wrote: On 09/12/2020 23:35, Stefano Stabellini wrote: On Wed, 9 Dec 2020, Stefano Stabellini wrote: On Mon, 30 Nov 2020, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko This patch add

Re: [PATCH 2/2] xen: don't use page->lru for ZONE_DEVICE memory

2020-12-10 Thread Jason Andryuk
On Thu, Dec 10, 2020 at 6:40 AM Jürgen Groß wrote: > > On 10.12.20 12:14, Roger Pau Monné wrote: > > On Tue, Dec 08, 2020 at 07:45:00AM +0100, Jürgen Groß wrote: > >> On 07.12.20 21:48, Jason Andryuk wrote: > >>> On Mon, Dec 7, 2020 at 8:30 AM Juergen Gross wrote: > > Commit 9e2369c06c8

Re: [PATCH] x86/HVM: refine when to send mapcache invalidation request to qemu

2020-12-10 Thread Jan Beulich
On 10.12.2020 14:09, Hongyan Xia wrote: > On Mon, 2020-09-28 at 12:44 +0200, Jan Beulich wrote: >> Plus finally there's no point sending the request for the local >> domain >> when the domain acted upon is a different one. If anything that >> domain's >> qemu's mapcache may need invalidating, but i

Re: [PATCH V3 18/23] xen/dm: Introduce xendevicemodel_set_irq_level DM op

2020-12-10 Thread Julien Grall
Hi Stefano, On 10/12/2020 02:21, Stefano Stabellini wrote: On Mon, 30 Nov 2020, Oleksandr Tyshchenko wrote: From: Julien Grall This patch adds ability to the device emulator to notify otherend (some entity running in the guest) using a SPI and implements Arm specific bits for it. Proposed int

[PATCH v3 01/13] qemu/atomic: Drop special case for unsupported compiler

2020-12-10 Thread marcandre . lureau
From: Philippe Mathieu-Daudé Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8, which has the GCC BZ#36793 bug fixed. We can safely remove the special case introduced in commit a281ebc11a6 ("virtio: add missin

[PATCH v3 00/13] Remove GCC < 4.8 checks

2020-12-10 Thread marcandre . lureau
From: Marc-André Lureau Hi, Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >= 4.8. v3: - drop first patch replacing QEMU_GNUC_PREREQ with G_GNUC_CHECK_VERSION - add last patch to remove QEMU_GNUC_PREREQ - tweak commit messages

[PATCH v3 02/13] accel/tcg: Remove special case for GCC < 4.6

2020-12-10 Thread marcandre . lureau
From: Philippe Mathieu-Daudé Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8. We can safely remove the special case for GCC 4.6 introduced in commit 0448f5f8b81 ("cpu-exec: Fix compiler warning (-Werror=clob

[PATCH v3 03/13] compiler.h: remove GCC < 3 __builtin_expect fallback

2020-12-10 Thread marcandre . lureau
From: Marc-André Lureau Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >= 4.8. (clang >= 3.4 advertizes itself as GCC >= 4.2 compatible and supports __builtin_expect too) Signed-off-by: Marc-André Lureau --- include/qemu/compil

[PATCH v3 04/13] qemu-plugin.h: remove GCC < 4

2020-12-10 Thread marcandre . lureau
From: Marc-André Lureau Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >= 4.8. (clang >= 3.4 advertizes itself as GCC >= 4.2 compatible) Signed-off-by: Marc-André Lureau Acked-by: Alex Bennée --- include/qemu/qemu-plugin.h | 9

[PATCH v3 05/13] tests: remove GCC < 4 fallbacks

2020-12-10 Thread marcandre . lureau
From: Marc-André Lureau Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >= 4.8. (clang >= 3.4 advertizes itself as GCC >= 4.2 compatible) Signed-off-by: Marc-André Lureau Reviewed-by: Peter Maydell Acked-by: Alex Bennée --- te

[PATCH v3 06/13] virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON

2020-12-10 Thread marcandre . lureau
From: Marc-André Lureau This allows to get rid of a check for older GCC version (which was a bit bogus too since it was falling back on c++ version..) Signed-off-by: Marc-André Lureau --- tools/virtiofsd/fuse_common.h | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --gi

[PATCH v3 07/13] compiler.h: explicit case for Clang printf attribute

2020-12-10 Thread marcandre . lureau
From: Marc-André Lureau Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >= 4.8, we could thus drop earlier version checks. Except clang advertizes itself as GCC 4.2.1. Since clang doesn't support gnu_printf, make that case explicit

[PATCH v3 08/13] audio: remove GNUC & MSVC check

2020-12-10 Thread marcandre . lureau
From: Marc-André Lureau QEMU requires either GCC or Clang, which both advertize __GNUC__. Drop MSVC fallback path. Note: I intentionally left further cleanups for a later work. Signed-off-by: Marc-André Lureau --- audio/audio.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) dif

[PATCH v3 09/13] poison: remove GNUC check

2020-12-10 Thread marcandre . lureau
From: Marc-André Lureau QEMU requires Clang or GCC, that define and support __GNUC__ extensions Signed-off-by: Marc-André Lureau Reviewed-by: Peter Maydell --- include/exec/poison.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/exec/poison.h b/include/exec/poison.h index 7b9ac3

[PATCH v3 10/13] xen: remove GNUC check

2020-12-10 Thread marcandre . lureau
From: Marc-André Lureau QEMU requires Clang or GCC, that define and support __GNUC__ extensions Signed-off-by: Marc-André Lureau Acked-by: Stefano Stabellini --- include/hw/xen/interface/io/ring.h | 9 - 1 file changed, 9 deletions(-) diff --git a/include/hw/xen/interface/io/ring.h

[PATCH v3 11/13] compiler: remove GNUC check

2020-12-10 Thread marcandre . lureau
From: Marc-André Lureau QEMU requires Clang or GCC, that define and support __GNUC__ extensions. Signed-off-by: Marc-André Lureau --- include/qemu/compiler.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index 62122

[PATCH v3 13/13] compiler.h: remove QEMU_GNUC_PREREQ

2020-12-10 Thread marcandre . lureau
From: Marc-André Lureau When needed, the G_GNUC_CHECK_VERSION() glib macro can be used instead. Signed-off-by: Marc-André Lureau --- include/qemu/compiler.h| 11 --- scripts/cocci-macro-file.h | 1 - 2 files changed, 12 deletions(-) diff --git a/include/qemu/compiler.h b/include/

[PATCH v3 12/13] linux-user: remove GNUC check

2020-12-10 Thread marcandre . lureau
From: Marc-André Lureau QEMU requires Clang or GCC, that define and support __GNUC__ extensions. Signed-off-by: Marc-André Lureau Reviewed-by: Peter Maydell --- linux-user/strace.c | 4 1 file changed, 4 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 11fea14fb

Re: [PATCH v3 00/13] Remove GCC < 4.8 checks

2020-12-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201210134752.780923-1-marcandre.lur...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201210134752.780923-1-marcandre.lur...@redhat.com Subject: [PATCH v3 00/13] Re

[ovmf bisection] complete test-amd64-i386-xl-qemuu-ovmf-amd64

2020-12-10 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-qemuu-ovmf-amd64 testid debian-hvm-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenb

Re: [PATCH v3 08/13] audio: remove GNUC & MSVC check

2020-12-10 Thread Philippe Mathieu-Daudé
On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > QEMU requires either GCC or Clang, which both advertize __GNUC__. > Drop MSVC fallback path. > > Note: I intentionally left further cleanups for a later work. > > Signed-off-by: Marc-André Lureau > --- > aud

Re: [PATCH v3 09/13] poison: remove GNUC check

2020-12-10 Thread Philippe Mathieu-Daudé
On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > QEMU requires Clang or GCC, that define and support __GNUC__ extensions > > Signed-off-by: Marc-André Lureau > Reviewed-by: Peter Maydell > --- > include/exec/poison.h | 2 -- > 1 file changed, 2 deletions(-

Re: [PATCH v3 12/13] linux-user: remove GNUC check

2020-12-10 Thread Philippe Mathieu-Daudé
On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > QEMU requires Clang or GCC, that define and support __GNUC__ extensions. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Peter Maydell > --- > linux-user/strace.c | 4 > 1 file changed, 4 deletions(

Re: [PATCH v3 08/13] audio: remove GNUC & MSVC check

2020-12-10 Thread Peter Maydell
On Thu, 10 Dec 2020 at 14:26, Philippe Mathieu-Daudé wrote: > > On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > QEMU requires either GCC or Clang, which both advertize __GNUC__. > > Drop MSVC fallback path. > > > > Note: I intentionally left further cle

Re: [PATCH v3 03/13] compiler.h: remove GCC < 3 __builtin_expect fallback

2020-12-10 Thread Philippe Mathieu-Daudé
On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Since commit efc6c07 ("configure: Add a test for the minimum compiler > version"), QEMU explicitely depends on GCC >= 4.8. > > (clang >= 3.4 advertizes itself as GCC >= 4.2 compatible and supports > __builtin_e

Re: [PATCH v3 08/13] audio: remove GNUC & MSVC check

2020-12-10 Thread Philippe Mathieu-Daudé
On 12/10/20 3:27 PM, Peter Maydell wrote: > On Thu, 10 Dec 2020 at 14:26, Philippe Mathieu-Daudé > wrote: >> >> On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> QEMU requires either GCC or Clang, which both advertize __GNUC__. >>> Drop MSVC fallback pat

Re: [PATCH v3 03/13] compiler.h: remove GCC < 3 __builtin_expect fallback

2020-12-10 Thread Peter Maydell
On Thu, 10 Dec 2020 at 14:32, Philippe Mathieu-Daudé wrote: > > On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Since commit efc6c07 ("configure: Add a test for the minimum compiler > > version"), QEMU explicitely depends on GCC >= 4.8. > > > > (clang >

Re: [PATCH v3 2/8] lib: collect library files in an archive

2020-12-10 Thread Anthony PERARD
On Mon, Nov 23, 2020 at 04:21:19PM +0100, Jan Beulich wrote: > In order to (subsequently) drop odd things like CONFIG_NEEDS_LIST_SORT > just to avoid bloating binaries when only some arch-es and/or > configurations need generic library routines, combine objects under lib/ > into an archive, which t

Re: [PATCH v3 1/8] xen: fix build when $(obj-y) consists of just blanks

2020-12-10 Thread Anthony PERARD
On Thu, Dec 10, 2020 at 11:21:53AM +0100, Jan Beulich wrote: > On 09.12.2020 18:40, Anthony PERARD wrote: > > How about using $(XEN_CFLAGS) instead of $(c_flags)? That should prevent > > CC from generating the .*.o.d files while keeping the relevant flags. > > What does "relevant" cover? For an em

Re: [PATCH v3 03/13] compiler.h: remove GCC < 3 __builtin_expect fallback

2020-12-10 Thread Marc-André Lureau
Hi On Thu, Dec 10, 2020 at 6:47 PM Peter Maydell wrote: > > On Thu, 10 Dec 2020 at 14:32, Philippe Mathieu-Daudé > wrote: > > > > On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Since commit efc6c07 ("configure: Add a test for the minimum compi

Re: [PATCH v3 08/13] audio: remove GNUC & MSVC check

2020-12-10 Thread Marc-André Lureau
Hi On Thu, Dec 10, 2020 at 6:35 PM Philippe Mathieu-Daudé wrote: > > On 12/10/20 3:27 PM, Peter Maydell wrote: > > On Thu, 10 Dec 2020 at 14:26, Philippe Mathieu-Daudé > > wrote: > >> > >> On 12/10/20 2:47 PM, marcandre.lur...@redhat.com wrote: > >>> From: Marc-André Lureau > >>> > >>> QEMU re

Re: [PATCH v3 5/7] xen/arm: Add handler for cp15 ID registers

2020-12-10 Thread Bertrand Marquis
Hi Stefano, > On 9 Dec 2020, at 19:54, Stefano Stabellini wrote: > > On Wed, 9 Dec 2020, Bertrand Marquis wrote: >> Add support for emulation of cp15 based ID registers (on arm32 or when >> running a 32bit guest on arm64). >> The handlers are returning the values stored in the guest_cpuinfo >> s

[linux-linus test] 157368: regressions - FAIL

2020-12-10 Thread osstest service owner
flight 157368 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/157368/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

Re: [PATCH v3 1/7] xen/arm: Add ID registers and complete cpuinfo

2020-12-10 Thread Bertrand Marquis
Hi Julien, > On 9 Dec 2020, at 23:03, Julien Grall wrote: > > Hi Bertrand, > > On 09/12/2020 16:30, Bertrand Marquis wrote: >> Add definition and entries in cpuinfo for ID registers introduced in >> newer Arm Architecture reference manual: >> - ID_PFR2: processor feature register 2 >> - ID_DFR1

Re: [PATCH v3 4/7] xen/arm: Add handler for ID registers on arm64

2020-12-10 Thread Bertrand Marquis
Hi Stefano, > On 9 Dec 2020, at 19:38, Stefano Stabellini wrote: > > On Wed, 9 Dec 2020, Bertrand Marquis wrote: >> Add vsysreg emulation for registers trapped when TID3 bit is activated >> in HSR. >> The emulation is returning the value stored in cpuinfo_guest structure >> for know registers an

Re: [PATCH v3 4/7] xen/arm: Add handler for ID registers on arm64

2020-12-10 Thread Bertrand Marquis
Hi Julien, > On 9 Dec 2020, at 23:13, Julien Grall wrote: > > > > On 09/12/2020 16:30, Bertrand Marquis wrote: >> Add vsysreg emulation for registers trapped when TID3 bit is activated >> in HSR. >> The emulation is returning the value stored in cpuinfo_guest structure >> for know registers an

Re: [PATCH v3 6/7] xen/arm: Add CP10 exception support to handle MVFR

2020-12-10 Thread Bertrand Marquis
Hi Stefano, > On 9 Dec 2020, at 21:04, Stefano Stabellini wrote: > > On Wed, 9 Dec 2020, Bertrand Marquis wrote: >> Add support for cp10 exceptions decoding to be able to emulate the >> values for MVFR0, MVFR1 and MVFR2 when TID3 bit of HSR is activated. >> This is required for aarch32 guests ac

Re: [PATCH v3 6/7] xen/arm: Add CP10 exception support to handle MVFR

2020-12-10 Thread Bertrand Marquis
Hi Julien > On 9 Dec 2020, at 23:15, Julien Grall wrote: > > Hi Bertrand, > > On 09/12/2020 16:30, Bertrand Marquis wrote: >> Add support for cp10 exceptions decoding to be able to emulate the >> values for MVFR0, MVFR1 and MVFR2 when TID3 bit of HSR is activated. >> This is required for aarch3

Re: [PATCH v3 7/7] xen/arm: Activate TID3 in HCR_EL2

2020-12-10 Thread Bertrand Marquis
Hi Julien, > On 9 Dec 2020, at 23:17, Julien Grall wrote: > > Hi Bertrand, > > On 09/12/2020 16:31, Bertrand Marquis wrote: >> Activate TID3 bit in HSR register when starting a guest. > > s/HSR/HCR/ > Right, I did it a lot thanks for the review. I will fix that in V4. >> This will trap all

Re: [PATCH v3 1/7] xen/arm: Add ID registers and complete cpuinfo

2020-12-10 Thread Julien Grall
Hi Bertrand, On 10/12/2020 15:14, Bertrand Marquis wrote: Hi Julien, On 9 Dec 2020, at 23:03, Julien Grall wrote: Hi Bertrand, On 09/12/2020 16:30, Bertrand Marquis wrote: Add definition and entries in cpuinfo for ID registers introduced in newer Arm Architecture reference manual: - ID_PFR

Re: [PATCH v3 2/7] xen/arm: Add arm64 ID registers definitions

2020-12-10 Thread Julien Grall
On 10/12/2020 02:30, Stefano Stabellini wrote: On Wed, 9 Dec 2020, Julien Grall wrote: Hi Bertrand, On 09/12/2020 16:30, Bertrand Marquis wrote: Add coprocessor registers definitions for all ID registers trapped through the TID3 bit of HSR. Those are the one that will be emulated in Xen to

Re: [PATCH v3 3/7] xen/arm: create a cpuinfo structure for guest

2020-12-10 Thread Bertrand Marquis
Hi Julien, > On 9 Dec 2020, at 23:09, Julien Grall wrote: > > Hi Bertand, > > On 09/12/2020 16:30, Bertrand Marquis wrote: >> Create a cpuinfo structure for guest and mask into it the features that >> we do not support in Xen or that we do not want to publish to guests. >> Modify some values in

Re: [PATCH v3 3/7] xen/arm: create a cpuinfo structure for guest

2020-12-10 Thread Bertrand Marquis
Hi, > On 9 Dec 2020, at 23:22, Julien Grall wrote: > > Hi, > > On 09/12/2020 16:30, Bertrand Marquis wrote: >> +/* Disable MPAM as xen does not support it */ > > I am going to be picky :). I think we want to say "hide" rather than > "disable" because the latter is done differently via the

Re: dom0 PV looping on search_pre_exception_table()

2020-12-10 Thread Andrew Cooper
On 10/12/2020 09:51, Manuel Bouyer wrote: > On Wed, Dec 09, 2020 at 07:08:41PM +, Andrew Cooper wrote: >> Oh of course - we don't follow the exit-to-guest path on the way out here. >> >> As a gross hack to check that we've at least diagnosed the issue >> appropriately, could you modify NetBSD t

Re: [PATCH] x86/HVM: refine when to send mapcache invalidation request to qemu

2020-12-10 Thread Hongyan Xia
On Thu, 2020-12-10 at 14:37 +0100, Jan Beulich wrote: > On 10.12.2020 14:09, Hongyan Xia wrote: > > On Mon, 2020-09-28 at 12:44 +0200, Jan Beulich wrote: > > > Plus finally there's no point sending the request for the local > > > domain > > > when the domain acted upon is a different one. If anythi

Re: [PATCH v6 00/25] xl / libxl: named PCI pass-through devices

2020-12-10 Thread Wei Liu
On Wed, Dec 09, 2020 at 06:41:03PM -0800, Stefano Stabellini wrote: > On Wed, 9 Dec 2020, Stefano Stabellini wrote: > > On Wed, 9 Dec 2020, Wei Liu wrote: > > > On Tue, Dec 08, 2020 at 05:02:50PM -0800, Stefano Stabellini wrote: > > > > The pipeline failed because the "fedora-gcc-debug" build faile

Re: [PATCH v3 1/7] xen/arm: Add ID registers and complete cpuinfo

2020-12-10 Thread Bertrand Marquis
Hi, > On 10 Dec 2020, at 15:45, Julien Grall wrote: > > Hi Bertrand, > > On 10/12/2020 15:14, Bertrand Marquis wrote: >> Hi Julien, >>> On 9 Dec 2020, at 23:03, Julien Grall wrote: >>> >>> Hi Bertrand, >>> >>> On 09/12/2020 16:30, Bertrand Marquis wrote: Add definition and entries in cp

Re: [PATCH v3 2/7] xen/arm: Add arm64 ID registers definitions

2020-12-10 Thread Bertrand Marquis
Hi, > On 10 Dec 2020, at 15:46, Julien Grall wrote: > > > > On 10/12/2020 02:30, Stefano Stabellini wrote: >> On Wed, 9 Dec 2020, Julien Grall wrote: >>> Hi Bertrand, >>> >>> On 09/12/2020 16:30, Bertrand Marquis wrote: Add coprocessor registers definitions for all ID registers trapped >

Re: [PATCH v3 3/7] xen/arm: create a cpuinfo structure for guest

2020-12-10 Thread Julien Grall
On 10/12/2020 15:48, Bertrand Marquis wrote: Hi Julien, On 9 Dec 2020, at 23:09, Julien Grall wrote: Hi Bertand, On 09/12/2020 16:30, Bertrand Marquis wrote: Create a cpuinfo structure for guest and mask into it the features that we do not support in Xen or that we do not want to publish

Re: [PATCH v3 3/7] xen/arm: create a cpuinfo structure for guest

2020-12-10 Thread Bertrand Marquis
Hi Julien, > On 10 Dec 2020, at 16:05, Julien Grall wrote: > > > > On 10/12/2020 15:48, Bertrand Marquis wrote: >> Hi Julien, >>> On 9 Dec 2020, at 23:09, Julien Grall wrote: >>> >>> Hi Bertand, >>> >>> On 09/12/2020 16:30, Bertrand Marquis wrote: Create a cpuinfo structure for guest a

Re: [PATCH v3 3/7] xen/arm: create a cpuinfo structure for guest

2020-12-10 Thread Julien Grall
On 10/12/2020 16:17, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 10 Dec 2020, at 16:05, Julien Grall wrote: On 10/12/2020 15:48, Bertrand Marquis wrote: Hi Julien, On 9 Dec 2020, at 23:09, Julien Grall wrote: Hi Bertand, On 09/12/2020 16:30, Bertrand Marquis wrote: Create

Re: [PATCH v3 3/7] xen/arm: create a cpuinfo structure for guest

2020-12-10 Thread Bertrand Marquis
Hi Julien, > On 10 Dec 2020, at 16:30, Julien Grall wrote: > > > > On 10/12/2020 16:17, Bertrand Marquis wrote: >> Hi Julien, > > Hi Bertrand, > >>> On 10 Dec 2020, at 16:05, Julien Grall wrote: >>> >>> >>> >>> On 10/12/2020 15:48, Bertrand Marquis wrote: Hi Julien, > On 9 Dec 2

Re: [PATCH] xen/arm: Add workaround for Cortex-A53 erratum #843419

2020-12-10 Thread Bertrand Marquis
Hi Luca, > On 10 Dec 2020, at 10:42, Luca Fancellu wrote: > > On the Cortex A53, when executing in AArch64 state, a load or store > instruction > which uses the result of an ADRP instruction as a base register, or which uses > a base register written by an instruction immediately after an ADRP

[PATCH v3 0/8] xen/arm: Add support for SMMUv3 driver

2020-12-10 Thread Rahul Singh
This patch series is v3 of the work to add support for the SMMUv3 driver. Approach taken is to first merge the Linux copy of the SMMUv3 driver (tag v5.8.18) and then modify the driver to build on XEN. MSI and PCI ATS functionality are not supported. Code is not tested and compiled. Code is guarde

Re: [PATCH V3 17/23] xen/ioreq: Introduce domain_has_ioreq_server()

2020-12-10 Thread Oleksandr
On 10.12.20 10:38, Paul Durrant wrote: Hi Paul. -Original Message- From: Oleksandr Sent: 09 December 2020 20:36 To: p...@xen.org Cc: 'Jan Beulich' ; 'Oleksandr Tyshchenko' ; 'Stefano Stabellini' ; 'Julien Grall' ; 'Volodymyr Babchuk' ; 'Andrew Cooper' ; 'George Dunlap' ; 'Ian Jack

[PATCH v3 1/8] xen/arm: Import the SMMUv3 driver from Linux

2020-12-10 Thread Rahul Singh
Based on tag Linux 5.8.18 commit ab435ce49bd1d02e33dfec24f76955dc1196970b Directory structure change for the SMMUv3 driver starting from Linux 5.9, to revert the patches smoothly using the "git revert" command we decided to choose Linux 5.8.18. Only difference between latest stable Linux 5.9.12 a

[PATCH v3 2/8] xen/arm: revert atomic operation related command-queue insertion patch

2020-12-10 Thread Rahul Singh
Linux SMMUv3 code implements the commands-queue insertion based on atomic operations implemented in Linux. Atomic functions used by the commands-queue insertion are not implemented in XEN therefore revert the patch that implemented the commands-queue insertion based on atomic operations. Reverted

[PATCH v3 3/8] xen/arm: revert patch related to XArray

2020-12-10 Thread Rahul Singh
XArray is not implemented in XEN revert the patch that introduce the XArray code in SMMUv3 driver. XArray is added in preparation for sharing some ASIDs with the CPU, As XEN support only Stage-2 translation, ASID is used for Stage-1 translation there is no consequences of reverting this patch for

[PATCH v3 4/8] xen/arm: Remove support for Stage-1 translation on SMMUv3.

2020-12-10 Thread Rahul Singh
Linux SMMUv3 driver supports both Stage-1 and Stage-2 translations. As of now only Stage-2 translation support has been tested. Once Stage-1 translation support is tested this patch can be added. Signed-off-by: Rahul Singh --- Changes in v3: - No change from previous version. --- xen/drivers/

[PATCH v3 5/8] xen/device-tree: Add dt_property_match_string helper

2020-12-10 Thread Rahul Singh
Import the Linux helper of_property_match_string. This function searches a string list property and returns the index of a specific string value. Signed-off-by: Rahul Singh --- Changes in v3: - This patch is introduce in this verison. --- xen/common/device_tree.c | 27

[PATCH v3 6/8] xen/arm: Remove Linux specific code that is not usable in XEN

2020-12-10 Thread Rahul Singh
Remove code that is related to below functionality : 1. struct io_pgtable_ops 2. struct io_pgtable_cfg 3. struct iommu_flush_ops, 4. struct iommu_ops 5. module_param_named, MODULE_PARM_DESC, module_platform_driver, MODULE_* 6. IOMMU domain-types 7. arm_smmu_set_bus_ops 8. iommu_device_s

[PATCH v3 8/8] xen/arm: smmuv3: Remove linux compatibility functions.

2020-12-10 Thread Rahul Singh
Replace all Linux compatible device tree handling function with the XEN functions. Replace all Linux ktime function with the XEN time functions. Signed-off-by: Rahul Singh --- Changes in v3: - This patch is introduce in this version. --- xen/drivers/passthrough/arm/smmu-v3.c | 32 +++-

[PATCH v3 7/8] xen/arm: Add support for SMMUv3 driver

2020-12-10 Thread Rahul Singh
Add support for ARM architected SMMUv3 implementation. It is based on the Linux SMMUv3 driver. Driver is currently supported as Tech Preview. Major differences with regard to Linux driver are as follows: 2. Only Stage-2 translation is supported as compared to the Linux driver that supports bot

Re: dom0 PV looping on search_pre_exception_table()

2020-12-10 Thread Manuel Bouyer
On Thu, Dec 10, 2020 at 03:51:46PM +, Andrew Cooper wrote: > > [ 7.6617663] cs 0x47 ds 0x23 es 0x23 fs gs ss 0x3f > > [ 7.7345663] fsbase 00 gsbase 00 > > > > so it looks like something resets %fs to 0 ... > > > > Anyway the fault address 0xfff

Re: dom0 PV looping on search_pre_exception_table()

2020-12-10 Thread Andrew Cooper
On 10/12/2020 17:03, Manuel Bouyer wrote: > On Thu, Dec 10, 2020 at 03:51:46PM +, Andrew Cooper wrote: >>> [ 7.6617663] cs 0x47 ds 0x23 es 0x23 fs gs ss 0x3f >>> [ 7.7345663] fsbase 00 gsbase 00 >>> >>> so it looks like something resets %fs to

Re: dom0 PV looping on search_pre_exception_table()

2020-12-10 Thread Manuel Bouyer
On Thu, Dec 10, 2020 at 05:18:39PM +, Andrew Cooper wrote: > The debugging earlier shows that MMUEXT_SET_LDT has indeed been called.  > Presumably 0xbd00a000 is a plausible virtual address for NetBSD > to position the LDT? Yes, it is. > > However, Xen finds the mapping not-present w

Re: [PATCH v2 07/12] x86: add new features for paravirt patching

2020-12-10 Thread Borislav Petkov
On Wed, Dec 09, 2020 at 01:22:24PM +0100, Jürgen Groß wrote: > Lets take the spin_unlock() case. With patch 11 of the series this is > > PVOP_ALT_VCALLEE1(lock.queued_spin_unlock, lock, > "movb $0, (%%" _ASM_ARG1 ");", > X86_FEATURE_NO_PVUNLOCK); > > which boil

[ovmf test] 157383: regressions - FAIL

2020-12-10 Thread osstest service owner
flight 157383 ovmf real [real] flight 157387 ovmf real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157383/ http://logs.test-lab.xenproject.org/osstest/logs/157387/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-

Re: [PATCH V3 21/23] xen/arm: Add mapcache invalidation handling

2020-12-10 Thread Julien Grall
Hi Stefano, On 10/12/2020 02:30, Stefano Stabellini wrote: On Mon, 30 Nov 2020, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko We need to send mapcache invalidation request to qemu/demu everytime the page gets removed from a guest. At the moment, the Arm code doesn't explicitely remo

[patch 02/30] genirq: Move status flag checks to core

2020-12-10 Thread Thomas Gleixner
These checks are used by modules and prevent the removal of the export of irq_to_desc(). Move the accessor into the core. Signed-off-by: Thomas Gleixner --- include/linux/irqdesc.h | 17 + kernel/irq/manage.c | 17 + 2 files changed, 22 insertions(+), 12 d

[patch 08/30] genirq: Provide kstat_irqdesc_cpu()

2020-12-10 Thread Thomas Gleixner
Most users of kstat_irqs_cpu() have the irq descriptor already. No point in calling into the core code and looking it up once more. Use it in per_cpu_count_show() to start with. Signed-off-by: Thomas Gleixner --- include/linux/irqdesc.h |6 ++ kernel/irq/irqdesc.c|4 ++-- 2 file

[patch 04/30] genirq: Provide irq_get_effective_affinity()

2020-12-10 Thread Thomas Gleixner
Provide an accessor to the effective interrupt affinity mask. Going to be used to replace open coded fiddling with the irq descriptor. Signed-off-by: Thomas Gleixner --- include/linux/irq.h |7 +++ 1 file changed, 7 insertions(+) --- a/include/linux/irq.h +++ b/include/linux/irq.h @@ -9

[patch 06/30] parisc/irq: Simplify irq count output for /proc/interrupts

2020-12-10 Thread Thomas Gleixner
The SMP variant works perfectly fine on UP as well. Signed-off-by: Thomas Gleixner Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: afzal mohammed Cc: linux-par...@vger.kernel.org --- arch/parisc/kernel/irq.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) --- a/arch/parisc/kerne

[patch 10/30] arm64/smp: Use irq_desc_kstat_cpu() in arch_show_interrupts()

2020-12-10 Thread Thomas Gleixner
The irq descriptor is already there, no need to look it up again. Signed-off-by: Thomas Gleixner Cc: Mark Rutland Cc: Catalin Marinas Cc: Will Deacon Cc: Marc Zyngier Cc: linux-arm-ker...@lists.infradead.org --- arch/arm64/kernel/smp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[patch 05/30] genirq: Annotate irq stats data races

2020-12-10 Thread Thomas Gleixner
Both the per cpu stats and the accumulated count are accessed lockless and can be concurrently modified. That's intentional and the stats are a rough estimate anyway. Annotate them with data_race(). Signed-off-by: Thomas Gleixner --- kernel/irq/irqdesc.c |4 ++-- kernel/irq/proc.c|5

[patch 03/30] genirq: Move irq_set_lockdep_class() to core

2020-12-10 Thread Thomas Gleixner
irq_set_lockdep_class() is used from modules and requires irq_to_desc() to be exported. Move it into the core code which lifts another requirement for the export. Signed-off-by: Thomas Gleixner --- include/linux/irqdesc.h | 10 -- kernel/irq/irqdesc.c| 14 ++ 2 files

[patch 00/30] genirq: Treewide hunt for irq descriptor abuse and assorted fixes

2020-12-10 Thread Thomas Gleixner
A recent request to export kstat_irqs() pointed to a copy of the same in the i915 code, which made me look for further usage of irq descriptors in drivers. The usage in drivers ranges from creative to broken in all colours. irqdesc.h clearly says that this is core functionality and the fact C doe

[patch 01/30] genirq: Move irq_has_action() into core code

2020-12-10 Thread Thomas Gleixner
This function uses irq_to_desc() and is going to be used by modules to replace the open coded irq_to_desc() (ab)usage. The final goal is to remove the export of irq_to_desc() so driver cannot fiddle with it anymore. Move it into the core code and fixup the usage sites to include the proper header.

[patch 11/30] parisc/irq: Use irq_desc_kstat_cpu() in show_interrupts()

2020-12-10 Thread Thomas Gleixner
The irq descriptor is already there, no need to look it up again. Signed-off-by: Thomas Gleixner Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: afzal mohammed Cc: linux-par...@vger.kernel.org --- arch/parisc/kernel/irq.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/pa

[patch 09/30] ARM: smp: Use irq_desc_kstat_cpu() in show_ipi_list()

2020-12-10 Thread Thomas Gleixner
The irq descriptor is already there, no need to look it up again. Signed-off-by: Thomas Gleixner Cc: Marc Zyngier Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org --- arch/arm/kernel/smp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/arm/kernel/smp.c +++ b/arch

  1   2   >