Re: [PATCH v7 7/9] common/domain: add a domain context record for shared_info...

2020-09-07 Thread Jan Beulich
On 04.09.2020 19:29, Paul Durrant wrote: >> From: Jan Beulich >> Sent: 26 August 2020 14:58 >> >> On 18.08.2020 12:30, Paul Durrant wrote: >>> v7: >>> - Only restore vcpu_info and arch sub-structures for PV domains, to match >>>processing of SHARED_INFO in xc_sr_restore_x86_pv.c >> >> Since y

RE: [EXTERNAL] [PATCH v7 7/9] common/domain: add a domain context record for shared_info...

2020-09-07 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 07 September 2020 08:01 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > 'Ian Jackson' > ; 'Wei Liu' ; 'Andrew Cooper' > ; > 'George Dunlap' ; 'Julien Grall' ; > 'Stefano Stabellini' > > Subject: RE: [EXTERNAL]

Re: [PATCH] EFI: Enable booting unified hypervisor/kernel/initrd images

2020-09-07 Thread Jan Beulich
On 04.09.2020 19:35, Julien Grall wrote: > On 04/09/2020 11:06, Trammell Hudson wrote: >> On Friday, September 4, 2020 5:29 AM, Julien Grall wrote: >> >>> On 28/08/2020 12:51, Trammell Hudson wrote: >>> - /* PE32+ Subsystem type */ +#if defined(ARM) >>> >>> Shouldn't this be

Re: [PATCH v2 1/2] drm: allow limiting the scatter list size.

2020-09-07 Thread Daniel Vetter
On Mon, Sep 7, 2020 at 8:39 AM Gerd Hoffmann wrote: > > > > + /** > > > +* @max_segment: > > > +* > > > +* Max size for scatter list segments. When unset the default > > > +* (SCATTERLIST_MAX_SEGMENT) is used. > > > +*/ > > > + size_t max_segment; > > > > Is there no bette

Re: [PATCH] EFI: Enable booting unified hypervisor/kernel/initrd images

2020-09-07 Thread Jan Beulich
On 04.09.2020 18:48, Trammell Hudson wrote: > On Friday, September 4, 2020 9:02 AM, Roger Pau Monné > wrote: >> On Fri, Aug 28, 2020 at 11:51:35AM +, Trammell Hudson wrote: >>> - return secboot == 1 && setupmode == 0; >> >> Does this need to be strictly 1, or any value != 0? > > We discuss

Re: [xen-unstable bisection] complete test-amd64-i386-xl-shadow

2020-09-07 Thread Jan Beulich
On 07.09.2020 00:48, osstest service owner wrote: > branch xen-unstable > xenbranch xen-unstable > job test-amd64-i386-xl-shadow > testid guest-saverestore > > Tree: linux git://xenbits.xen.org/linux-pvops.git > Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git > Tree: qemu git:

Re: [PATCH v3 1/8] x86/vmx: handle writes to MISC_ENABLE MSR

2020-09-07 Thread Jan Beulich
On 07.09.2020 05:25, Tian, Kevin wrote: >> From: Roger Pau Monne >> Sent: Tuesday, September 1, 2020 6:55 PM >> >> Such handling consist in checking that no bits have been changed from >> the read value, if that's the case silently drop the write, otherwise >> inject a fault. >> >> At least Window

Re: [PATCH v2] efi: Always map EfiRuntimeServicesCode and EfiRuntimeServicesData

2020-09-07 Thread Jan Beulich
On 04.09.2020 23:11, Sergey Temerkhanov wrote: > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -1100,7 +1100,9 @@ static void __init efi_exit_boot(EFI_HANDLE > ImageHandle, EFI_SYSTEM_TABLE *Syste > { > EFI_MEMORY_DESCRIPTOR *desc = efi_memmap + i; > > -if

[PATCH v5 2/8] iommu: remove unused iommu_ops method and tasklet

2020-09-07 Thread Paul Durrant
From: Paul Durrant The VT-d and AMD IOMMU implementations both use the general x86 IOMMU page table allocator and ARM always shares page tables with CPU. Hence there is no need to retain the free_page_table() method or the tasklet which invokes it. Signed-off-by: Paul Durrant Reviewed-by: Jan B

[PATCH v5 4/8] iommu: make map and unmap take a page count, similar to flush

2020-09-07 Thread Paul Durrant
From: Paul Durrant At the moment iommu_map() and iommu_unmap() take a page order rather than a count, whereas iommu_iotlb_flush() takes a page count rather than an order. This patch makes them consistent with each other, opting for a page count since CPU page orders are not necessarily the same a

[PATCH v5 3/8] iommu: flush I/O TLB if iommu_map() or iommu_unmap() fail

2020-09-07 Thread Paul Durrant
From: Paul Durrant This patch adds a full I/O TLB flush to the error paths of iommu_map() and iommu_unmap(). Without this change callers need constructs such as: rc = iommu_map/unmap(...) err = iommu_flush(...) if ( !rc ) rc = err; With this change, it can be simplified to: rc = iommu_map/u

[PATCH v5 0/8] IOMMU cleanup

2020-09-07 Thread Paul Durrant
From: Paul Durrant Paul Durrant (8): x86/iommu: convert VT-d code to use new page table allocator iommu: remove unused iommu_ops method and tasklet iommu: flush I/O TLB if iommu_map() or iommu_unmap() fail iommu: make map and unmap take a page count, similar to flush remove remaining us

[PATCH v5 6/8] common/grant_table: batch flush I/O TLB

2020-09-07 Thread Paul Durrant
From: Paul Durrant This patch avoids calling iommu_iotlb_flush() for each individual GNTTABOP and instead calls iommu_iotlb_flush_all() at the end of a batch. This should mean non-singleton map/unmap operations perform better. NOTE: A batch is the number of operations done before a pre-emption c

[PATCH v5 7/8] iommu: remove the share_p2m operation

2020-09-07 Thread Paul Durrant
From: Paul Durrant Sharing of HAP tables is now VT-d specific so the operation is never defined for AMD IOMMU any more. There's also no need to pro-actively set vtd.pgd_maddr when using shared EPT as it is straightforward to simply define a helper function to return the appropriate value in the s

[PATCH v5 1/8] x86/iommu: convert VT-d code to use new page table allocator

2020-09-07 Thread Paul Durrant
From: Paul Durrant This patch converts the VT-d code to use the new IOMMU page table allocator function. This allows all the free-ing code to be removed (since it is now handled by the general x86 code) which reduces TLB and cache thrashing as well as shortening the code. The scope of the mappin

[PATCH v5 8/8] iommu: stop calling IOMMU page tables 'p2m tables'

2020-09-07 Thread Paul Durrant
From: Paul Durrant It's confusing and not consistent with the terminology introduced with 'dfn_t'. Just call them IOMMU page tables. Also remove a pointless check of the 'acpi_drhd_units' list in vtd_dump_page_table_level(). If the list is empty then IOMMU mappings would not have been enabled fo

[PATCH v5 5/8] remove remaining uses of iommu_legacy_map/unmap

2020-09-07 Thread Paul Durrant
From: Paul Durrant The 'legacy' functions do implicit flushing so amend the callers to do the appropriate flushing. Unfortunately, because of the structure of the P2M code, we cannot remove the per-CPU 'iommu_dont_flush_iotlb' global and the optimization it facilitates. It is now checked directl

[ovmf test] 153855: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153855 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/153855/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

Re: [PATCH v2 1/2] x86/pv: Fix consistency of 64bit segment bases

2020-09-07 Thread Jan Beulich
On 04.09.2020 15:52, Andrew Cooper wrote: > The comments in save_segments(), _toggle_guest_pt() and write_cr() are false. > The %fs and %gs bases can be updated at any time by the guest. > > As a consequence, Xen's fs_base/etc tracking state is always stale when the > vcpu is in context, and must

Re: [PATCH v2 2/2] x86/pv: Rewrite segment context switching from scratch

2020-09-07 Thread Jan Beulich
On 04.09.2020 15:52, Andrew Cooper wrote: > There are multiple bugs with the existing implementation. > > On AMD CPUs prior to Zen2, loading a NUL segment selector doesn't clear the > segment base, which is a problem for 64bit code which typically expects to use > a NUL %fs/%gs selector. > > On a

[linux-5.4 test] 153827: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153827 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/153827/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i3866 xen-buildfail REGR. vs. 152853 build-i386-xsm

Re: [xen-unstable bisection] complete test-amd64-i386-xl-shadow

2020-09-07 Thread Jan Beulich
On 07.09.2020 00:48, osstest service owner wrote: > branch xen-unstable > xenbranch xen-unstable > job test-amd64-i386-xl-shadow > testid guest-saverestore > > Tree: linux git://xenbits.xen.org/linux-pvops.git > Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git > Tree: qemu git:

Re: [PATCH] EFI: Enable booting unified hypervisor/kernel/initrd images

2020-09-07 Thread Jan Beulich
On 28.08.2020 13:51, Trammell Hudson wrote: > This patch adds support for bundling the xen.efi hypervisor, the xen.cfg > configuration file, the Linux kernel and initrd, as well as the XSM, and > CPU microcode into a single "unified" EFI executable. The resulting EFI > executable can be invoked di

[ovmf test] 153860: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153860 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/153860/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

Re: [PATCH] x86: guard against straight-line speculation past RET

2020-09-07 Thread Jan Beulich
On 04.09.2020 20:18, Andrew Cooper wrote: > On 24/08/2020 13:50, Jan Beulich wrote: >> --- a/xen/include/asm-x86/asm-defns.h >> +++ b/xen/include/asm-x86/asm-defns.h >> @@ -50,3 +50,19 @@ >> .macro INDIRECT_JMP arg:req >> INDIRECT_BRANCH jmp \arg >> .endm >> + >> +/* >> + * To guard against

Re: [xen-unstable bisection] complete test-amd64-i386-xl-shadow

2020-09-07 Thread Jan Beulich
On 07.09.2020 11:20, Roger Pau Monné wrote: > On Mon, Sep 07, 2020 at 10:21:36AM +0200, Jan Beulich wrote: >> On 07.09.2020 00:48, osstest service owner wrote: >>> branch xen-unstable >>> xenbranch xen-unstable >>> job test-amd64-i386-xl-shadow >>> testid guest-saverestore >>> >>> Tree: linux git:/

[ovmf test] 153867: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153867 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/153867/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

Re: [PATCH v3] x86/HVM: more consistently set I/O completion

2020-09-07 Thread Jan Beulich
On 04.09.2020 18:17, Paul Durrant wrote: >> @@ -2610,8 +2612,13 @@ static const struct x86_emulate_ops hvm_ >> .vmfunc= hvmemul_vmfunc, >> }; >> >> +/* >> + * Note that passing HVMIO_no_completion into this function serves as kind >> + * of (but not fully) an "auto select completion"

RE: [PATCH v3] x86/HVM: more consistently set I/O completion

2020-09-07 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 07 September 2020 10:43 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; 'Andrew Cooper' > ; 'Wei Liu' > ; 'Roger Pau Monné' ; 'Jun Nakajima' > ; > 'Kevin Tian' ; 'George Dunlap' > > Subject: Re: [PATCH v3] x86/HVM: more consiste

[ovmf test] 153870: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153870 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/153870/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

Re: [PATCH] x86: guard against straight-line speculation past RET

2020-09-07 Thread Jan Beulich
On 07.09.2020 11:25, Jan Beulich wrote: > On 04.09.2020 20:18, Andrew Cooper wrote: >> Clang doesn't actually expand the macro for ret instructions, so a Clang >> build of Xen only ends up getting protected in the assembly files. >> >> The following experiment demonstrates the issue: >> >> $ cat re

[ovmf test] 153872: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153872 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/153872/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

[libvirt test] 153853: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153853 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/153853/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 151777 build-arm64-libvirt

[PATCH v4 1/1] drm: allow limiting the scatter list size.

2020-09-07 Thread Gerd Hoffmann
Add drm_device argument to drm_prime_pages_to_sg(), so we can call dma_max_mapping_size() to figure the segment size limit and call into __sg_alloc_table_from_pages() with the correct limit. This fixes virtio-gpu with sev. Possibly it'll fix other bugs too given that drm seems to totaly ignore se

[xen-unstable-smoke test] 153866: tolerable all pass - PUSHED

2020-09-07 Thread osstest service owner
flight 153866 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/153866/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[ovmf test] 153875: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153875 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/153875/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

[PATCH] minios: use more recent commit for building xen unstable

2020-09-07 Thread Juergen Gross
Commit 82c3d15c903aa43 ("minios: Revert recent change and revert to working minios") switched the used commit for the build of Xen unstable from master to a rather old commit (the one used for Xen 4.13 instead of the last one without a known problem). Switch to Mini-OS commit 051b87bb9c196 instead

[PATCH] config: use mini-os master for unstable

2020-09-07 Thread Juergen Gross
We haven't used mini-os master for about 2 years now due to a stubdom test failing [1]. Booting a guest with mini-os master used for building stubdom didn't reveal any problem, so use master for unstable in order to let OSStest find any problems not showing up in the local test. [1]: https://lists

Re: [PATCH] config: use mini-os master for unstable

2020-09-07 Thread Jürgen Groß
Sorry, please ignore, this was an old patch lying around. :-( On 07.09.20 13:48, Juergen Gross wrote: We haven't used mini-os master for about 2 years now due to a stubdom test failing [1]. Booting a guest with mini-os master used for building stubdom didn't reveal any problem, so use master for

[xen-unstable test] 153845: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153845 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/153845/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 14 guest-saverestore fail REGR. vs. 152877 test-amd64-i386-xl

[ovmf test] 153878: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153878 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/153878/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

Re: [xen-unstable bisection] complete test-amd64-i386-xl-shadow

2020-09-07 Thread Roger Pau Monné
On Mon, Sep 07, 2020 at 10:21:36AM +0200, Jan Beulich wrote: > On 07.09.2020 00:48, osstest service owner wrote: > > branch xen-unstable > > xenbranch xen-unstable > > job test-amd64-i386-xl-shadow > > testid guest-saverestore > > > > Tree: linux git://xenbits.xen.org/linux-pvops.git > > Tree: lin

Re: [PATCH v4 1/1] drm: allow limiting the scatter list size.

2020-09-07 Thread Daniel Vetter
On Mon, Sep 7, 2020 at 1:24 PM Gerd Hoffmann wrote: > > Add drm_device argument to drm_prime_pages_to_sg(), so we can > call dma_max_mapping_size() to figure the segment size limit > and call into __sg_alloc_table_from_pages() with the correct > limit. > > This fixes virtio-gpu with sev. Possibly

[xen-unstable-smoke test] 153880: tolerable FAIL - PUSHED

2020-09-07 Thread osstest service owner
flight 153880 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/153880/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-amd64 14 guest-localmigrate fail REGR. vs. 153866 Tests which d

Re: [PATCH] libgnttab/freebsd: add tools libs.h

2020-09-07 Thread Wei Liu
On Mon, Sep 07, 2020 at 12:18:05PM +0200, Roger Pau Monne wrote: > In order to get the ROUNDUP macro, or else the build fails. I assume > ROUNDUP would previously get included from a different header. > > Seeing as Linux does explicitly include libs.h do the same for > FreeBSD. > > Signed-off-by:

Re: [PATCH] minios: use more recent commit for building xen unstable

2020-09-07 Thread Wei Liu
On Mon, Sep 07, 2020 at 01:48:14PM +0200, Juergen Gross wrote: > Commit 82c3d15c903aa43 ("minios: Revert recent change and revert to > working minios") switched the used commit for the build of Xen unstable > from master to a rather old commit (the one used for Xen 4.13 instead > of the last one wi

[ovmf test] 153885: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153885 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/153885/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

Re: [PATCH] golang/xenlight: Move to an entirely external repo

2020-09-07 Thread Wei Liu
On Fri, Sep 04, 2020 at 05:40:00PM +0100, George Dunlap wrote: > Remove all go files and generation targets. > > Add a convenience macro to build the package from staging. This isn't > really meant to be called directly; rather, it's meant to be called > from a corresponding build target inside t

[PATCH] libgnttab/freebsd: add tools libs.h

2020-09-07 Thread Roger Pau Monne
In order to get the ROUNDUP macro, or else the build fails. I assume ROUNDUP would previously get included from a different header. Seeing as Linux does explicitly include libs.h do the same for FreeBSD. Signed-off-by: Roger Pau Monné --- tools/libs/gnttab/freebsd.c | 2 ++ 1 file changed, 2 in

[linux-linus test] 153854: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153854 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/153854/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 152332 build-i386

Re: [PATCH v4 02/31] tools: drop explicit path specifications for qemu build

2020-09-07 Thread Wei Liu
On Fri, Aug 28, 2020 at 05:07:18PM +0200, Juergen Gross wrote: > Since more than three years now qemu is capable to set the needed > include and library paths for the Xen libraries via pkg-config. > > So drop the specification of those paths in tools/Makefile. This will > enable to move libxenctrl

Re: [PATCH v4 01/31] tools: generate pkg-config files from make variables

2020-09-07 Thread Wei Liu
On Fri, Aug 28, 2020 at 05:07:17PM +0200, Juergen Gross wrote: > For each library built two variants of pkg-config files are created > from a per-library template: an "official" one for installation on > the user's system, and one used for building internal tools, like e.g. > qemu. > > Instead of

Re: [PATCH v2] tools/hotplug/Linux: don't needlessly use non-standard features in vif-{bridge,route}

2020-09-07 Thread Wei Liu
On Wed, Sep 02, 2020 at 08:09:28AM +0200, Jan Beulich wrote: > We're not after any "fall-through" behavior here. Replace the constructs > with ones understood by all conforming shells, including older bash > (problem observed with 3.1.51(1)). > > Fixes: b51715f02bf9 ("tools/hotplug/Linux: remove c

[PATCH v4 3/5] x86/pv: disallow access to unknown MSRs

2020-09-07 Thread Roger Pau Monne
Change the catch-all behavior for MSR not explicitly handled. Instead of allow full read-access to the MSR space and silently dropping writes return an exception when the MSR is not explicitly handled. Signed-off-by: Roger Pau Monné Acked-by: Andrew Cooper --- Changes since v2: - Added missing

[PATCH v4 4/5] x86/hvm: Disallow access to unknown MSRs

2020-09-07 Thread Roger Pau Monne
From: Andrew Cooper Change the catch-all behavior for MSR not explicitly handled. Instead of allow full read-access to the MSR space and silently dropping writes return an exception when the MSR is not explicitly handled. Signed-off-by: Andrew Cooper [remove rdmsr_safe from default case in svm_

[PATCH v4 1/5] x86/svm: handle BU_CFG and BU_CFG2 with cases

2020-09-07 Thread Roger Pau Monne
Move the special handling of reads to it's own switch case, and also add support for BU_CFG2. On the write side ignore writes if the MSR is readable, otherwise return a #GP. This is in preparation for changing the default MSR read/write behavior, which will instead return #GP on not explicitly han

[PATCH v4 5/5] x86/msr: Drop compatibility #GP handling in guest_{rd, wr}msr()

2020-09-07 Thread Roger Pau Monne
From: Andrew Cooper Now that the main PV/HVM MSR handlers raise #GP for all unknown MSRs, there is no need to special case these MSRs any more. Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné --- Changes since v1: - New in this version. --- xen/arch/x86/msr.c | 46 -

[PATCH v4 2/5] x86/pv: allow reading FEATURE_CONTROL MSR

2020-09-07 Thread Roger Pau Monne
Linux PV guests will attempt to read the FEATURE_CONTROL MSR, so move the handling done in VMX code into guest_rdmsr as it can be shared between PV and HVM guests that way. Note that there's a slight behavior change and attempting to read the MSR when no features are available will result in a fau

[PATCH v4 0/5] x86: switch default MSR behavior

2020-09-07 Thread Roger Pau Monne
Hello, The current series attempts to change the current MSR default handling behavior, which is to silently drop writes to writable MSRs, and allow reading any MSR not explicitly handled. After this series access to MSRs not explicitly handled will trigger a #GP fault. I've tested this series wi

Re: [PATCH 2/3] tools/hotplug: Fix dhcpd symlink removal in vif-nat

2020-09-07 Thread Wei Liu
On Thu, Aug 20, 2020 at 12:00:23PM +0100, Diego Sueiro wrote: > Copy temp files used to add/remove dhcpd configurations to avoid > replacing potential symlinks. > Can you clarify the issue you saw a bit? Which one of the parameter is a symlink (I assume the latter) and what problem you see with

Re: [PATCH 1/3] tools/hotplug: Fix hostname setting in vif-nat

2020-09-07 Thread Wei Liu
On Thu, Aug 27, 2020 at 02:14:03PM +, Bertrand Marquis wrote: > > > > On 20 Aug 2020, at 11:58, Diego Sueiro wrote: > > > > Setting the hostname is failing because the "$XENBUS_PATH/domain" > > doesn't exist anymore. To fix this we set it to dom$domid > > > > Signed-off-by: Diego Sueiro >

Re: [PATCH 3/3] tools/hotplug: Extend dhcpd conf, init and arg files search

2020-09-07 Thread Wei Liu
On Thu, Aug 20, 2020 at 12:01:11PM +0100, Diego Sueiro wrote: > Newer versions of the ISC dhcp server expect the dhcpd.conf file > to be located at /etc/dhcp directory. > > Also, some distributions and Yocto based ones have these installation > paths by default: /etc/init.d/{isc-dhcp-server,dhcp-s

Re: [PATCH] x86: guard against straight-line speculation past RET

2020-09-07 Thread Jan Beulich
On 07.09.2020 15:50, Andrew Cooper wrote: > On 07/09/2020 10:25, Jan Beulich wrote: >> On 04.09.2020 20:18, Andrew Cooper wrote: >>> Third, there is a huge quantity of complexity for a form of the >>> instruction we don't use. >> The complexity isn't with handling the possible immediate operand, >>

Re: [PATCH v4 01/31] tools: generate pkg-config files from make variables

2020-09-07 Thread Jürgen Groß
On 07.09.20 16:25, Wei Liu wrote: On Fri, Aug 28, 2020 at 05:07:17PM +0200, Juergen Gross wrote: For each library built two variants of pkg-config files are created from a per-library template: an "official" one for installation on the user's system, and one used for building internal tools, lik

[qemu-mainline test] 153847: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153847 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/153847/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-xsm 12 guest-start fail REGR. vs. 152631 test-armhf-armhf-

Re: [PATCH v4 01/31] tools: generate pkg-config files from make variables

2020-09-07 Thread Wei Liu
On Mon, Sep 07, 2020 at 04:44:28PM +0200, Jürgen Groß wrote: > On 07.09.20 16:25, Wei Liu wrote: > > On Fri, Aug 28, 2020 at 05:07:17PM +0200, Juergen Gross wrote: > > > For each library built two variants of pkg-config files are created > > > from a per-library template: an "official" one for inst

Re: [PATCH 2/3] tools/hotplug: Fix dhcpd symlink removal in vif-nat

2020-09-07 Thread Bertrand Marquis
Hi Wei, > On 7 Sep 2020, at 15:36, Wei Liu wrote: > > On Thu, Aug 20, 2020 at 12:00:23PM +0100, Diego Sueiro wrote: >> Copy temp files used to add/remove dhcpd configurations to avoid >> replacing potential symlinks. >> > > Can you clarify the issue you saw a bit? > > Which one of the paramet

Re: [PATCH 2/3] tools/hotplug: Fix dhcpd symlink removal in vif-nat

2020-09-07 Thread Wei Liu
On Mon, Sep 07, 2020 at 03:01:37PM +, Bertrand Marquis wrote: > Hi Wei, > > > On 7 Sep 2020, at 15:36, Wei Liu wrote: > > > > On Thu, Aug 20, 2020 at 12:00:23PM +0100, Diego Sueiro wrote: > >> Copy temp files used to add/remove dhcpd configurations to avoid > >> replacing potential symlinks.

Re: [PATCH v4 28/31] tools/libxl: move libxenlight to tools/libs/light

2020-09-07 Thread Wei Liu
On Mon, Aug 31, 2020 at 07:50:42AM +0200, Jürgen Groß wrote: > On 28.08.20 18:05, Wei Liu wrote: > > On Fri, Aug 28, 2020 at 05:07:44PM +0200, Juergen Gross wrote: > > > Carve out all libxenlight related sources and move them to > > > tools/libs/light in order to use the generic library build envir

Re: [PATCH v4 29/31] tools: rename global libxlutil make variables

2020-09-07 Thread Wei Liu
On Fri, Aug 28, 2020 at 05:07:45PM +0200, Juergen Gross wrote: > Rename *_libxlutil make variables to *_libxenutil in order to avoid > nasty indirections when moving libxlutil under the tools/libs > infrastructure. xl means xenlight. So I think the name should be libxenlightutil here. Wei.

Re: [PATCH v4 28/31] tools/libxl: move libxenlight to tools/libs/light

2020-09-07 Thread Jürgen Groß
On 07.09.20 17:52, Wei Liu wrote: On Mon, Aug 31, 2020 at 07:50:42AM +0200, Jürgen Groß wrote: On 28.08.20 18:05, Wei Liu wrote: On Fri, Aug 28, 2020 at 05:07:44PM +0200, Juergen Gross wrote: Carve out all libxenlight related sources and move them to tools/libs/light in order to use the generi

Re: [PATCH v4 29/31] tools: rename global libxlutil make variables

2020-09-07 Thread Jürgen Groß
On 07.09.20 17:55, Wei Liu wrote: On Fri, Aug 28, 2020 at 05:07:45PM +0200, Juergen Gross wrote: Rename *_libxlutil make variables to *_libxenutil in order to avoid nasty indirections when moving libxlutil under the tools/libs infrastructure. xl means xenlight. So I think the name should be l

Re: [PATCH v4 28/31] tools/libxl: move libxenlight to tools/libs/light

2020-09-07 Thread Wei Liu
On Mon, Sep 07, 2020 at 06:15:00PM +0200, Jürgen Groß wrote: > On 07.09.20 17:52, Wei Liu wrote: > > On Mon, Aug 31, 2020 at 07:50:42AM +0200, Jürgen Groß wrote: > > > On 28.08.20 18:05, Wei Liu wrote: > > > > On Fri, Aug 28, 2020 at 05:07:44PM +0200, Juergen Gross wrote: > > > > > Carve out all li

[ovmf test] 153887: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153887 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/153887/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

[xen-unstable-smoke test] 153890: tolerable all pass - PUSHED

2020-09-07 Thread osstest service owner
flight 153890 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/153890/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH v3 0/4] efi: Unified Xen hypervisor/kernel/initrd images

2020-09-07 Thread Trammell Hudson
This patch series adds support for bundling the xen.efi hypervisor, the xen.cfg configuration file, the Linux kernel and initrd, as well as the XSM, and architectural specific files into a single "unified" EFI executable. This allows an administrator to update the components independently without

[PATCH v3 1/4] x86/xen.lds.S: Work around binutils build id alignment bug

2020-09-07 Thread Trammell Hudson
binutils in most distrbutions have a bug in find_section_by_vma() that causes objcopy round section addresses incorrectly and that think the .buildid section overlaps with the .rodata. Aligning the sections allows these older verisons of the tools to work on the xen.efi executable image. Mailing

[PATCH v3 2/4] efi/boot.c: add file.need_to_free and split display_file_info()

2020-09-07 Thread Trammell Hudson
add file.need_to_free and split display_file_info() Signed-off-by: Trammell hudson --- xen/common/efi/boot.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index 4022a672c9..f5bdc4b1df 10064

[PATCH v3 3/4] efi: Enable booting unified hypervisor/kernel/initrd images

2020-09-07 Thread Trammell Hudson
This patch adds support for bundling the xen.efi hypervisor, the xen.cfg configuration file, the Linux kernel and initrd, as well as the XSM, and architectural specific files into a single "unified" EFI executable. This allows an administrator to update the components independently without requirin

[PATCH v3 4/4] efi: Do not use command line if secure boot is enabled.

2020-09-07 Thread Trammell Hudson
If secure boot is enabled, the Xen command line arguments are ignored. If a unified Xen image is used, then the bundled configuration, dom0 kernel, and initrd are prefered over the ones listed in the config file. Unlike the shim based verification, the PE signature on a unified image covers the al

Re: [PATCH] x86: guard against straight-line speculation past RET

2020-09-07 Thread Andrew Cooper
On 07/09/2020 10:25, Jan Beulich wrote: > On 04.09.2020 20:18, Andrew Cooper wrote: >> On 24/08/2020 13:50, Jan Beulich wrote: >>> --- a/xen/include/asm-x86/asm-defns.h >>> +++ b/xen/include/asm-x86/asm-defns.h >>> @@ -50,3 +50,19 @@ >>> .macro INDIRECT_JMP arg:req >>> INDIRECT_BRANCH jmp \ar

Re: [PATCH] EFI: Enable booting unified hypervisor/kernel/initrd images

2020-09-07 Thread Julien Grall
On 04/09/2020 19:18, Trammell Hudson wrote: On Friday, September 4, 2020 2:05 PM, Trammell Hudson wrote: On Friday, September 4, 2020 1:58 PM, Julien Grall jul...@xen.org wrote: On 28/08/2020 12:51, Trammell Hudson wrote: This patch adds support for bundling the xen.efi hypervisor, the xe

Re: [PATCH] EFI: Enable booting unified hypervisor/kernel/initrd images

2020-09-07 Thread Julien Grall
On 07/09/2020 08:11, Jan Beulich wrote: On 04.09.2020 19:35, Julien Grall wrote: On 04/09/2020 11:06, Trammell Hudson wrote: On Friday, September 4, 2020 5:29 AM, Julien Grall wrote: On 28/08/2020 12:51, Trammell Hudson wrote: - /* PE32+ Subsystem type */ +#if defined(ARM) Sh

Re: [PATCH v3 0/4] efi: Unified Xen hypervisor/kernel/initrd images

2020-09-07 Thread Julien Grall
Hi, On 07/09/2020 18:45, Trammell Hudson wrote: This patch series adds support for bundling the xen.efi hypervisor, the xen.cfg configuration file, the Linux kernel and initrd, as well as the XSM, and architectural specific files into a single "unified" EFI executable. This allows an administra

[xen-unstable bisection] complete test-amd64-i386-freebsd10-amd64

2020-09-07 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-freebsd10-amd64 testid guest-saverestore Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git:/

Re: [PATCH] golang/xenlight: Move to an entirely external repo

2020-09-07 Thread George Dunlap
> On Sep 7, 2020, at 3:17 PM, Wei Liu wrote: > > On Fri, Sep 04, 2020 at 05:40:00PM +0100, George Dunlap wrote: >> Remove all go files and generation targets. >> >> Add a convenience macro to build the package from staging. This isn't >> really meant to be called directly; rather, it's meant

[ovmf test] 153894: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153894 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/153894/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

[PATCH v3 2/4] efi/boot.c: add file.need_to_free and split display_file_info()

2020-09-07 Thread Trammell Hudson
From: Trammell hudson Signed-off-by: Trammell hudson --- xen/common/efi/boot.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index 4022a672c9..f5bdc4b1df 100644 --- a/xen/common/efi/boot.c

[PATCH v3 0/4] efi: Unified Xen hypervisor/kernel/initrd images

2020-09-07 Thread Trammell Hudson
From: Trammell hudson This patch series adds support for bundling the xen.efi hypervisor, the xen.cfg configuration file, the Linux kernel and initrd, as well as the XSM, and architectural specific files into a single "unified" EFI executable. This allows an administrator to update the component

[PATCH v3 1/4] x86/xen.lds.S: Work around binutils build id alignment bug

2020-09-07 Thread Trammell Hudson
From: Trammell hudson binutils in most distrbutions have a bug in find_section_by_vma() that causes objcopy round section addresses incorrectly and that think the .buildid section overlaps with the .rodata. Aligning the sections allows these older verisons of the tools to work on the xen.efi exe

[PATCH v3 3/4] efi: Enable booting unified hypervisor/kernel/initrd images

2020-09-07 Thread Trammell Hudson
From: Trammell hudson This patch adds support for bundling the xen.efi hypervisor, the xen.cfg configuration file, the Linux kernel and initrd, as well as the XSM, and architectural specific files into a single "unified" EFI executable. This allows an administrator to update the components indepe

[PATCH v3 4/4] efi: Do not use command line if secure boot is enabled.

2020-09-07 Thread Trammell Hudson
From: Trammell hudson If secure boot is enabled, the Xen command line arguments are ignored. If a unified Xen image is used, then the bundled configuration, dom0 kernel, and initrd are prefered over the ones listed in the config file. Unlike the shim based verification, the PE signature on a uni

[ovmf test] 153899: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153899 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/153899/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

[linux-5.4 test] 153861: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153861 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/153861/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i3866 xen-buildfail REGR. vs. 152853 build-i386-xsm

[xen-unstable test] 153882: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153882 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/153882/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 152877 test-amd64-i386-xl

[ovmf test] 153901: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153901 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/153901/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

[linux-linus test] 153886: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153886 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/153886/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152332 build-amd64

[ovmf test] 153907: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153907 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/153907/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

[ovmf test] 153918: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153918 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/153918/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

[ovmf test] 153920: regressions - FAIL

2020-09-07 Thread osstest service owner
flight 153920 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/153920/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 152863 build-amd64-xsm

  1   2   >