Re: [PATCH v2] xen/arm: Convert runstate address during hypcall

2020-07-29 Thread Bertrand Marquis
> On 28 Jul 2020, at 21:54, Jan Beulich wrote: > > On 28.07.2020 17:52, Bertrand Marquis wrote: >> At the moment on Arm, a Linux guest running with KTPI enabled will >> cause the following error when a context switch happens in user mode: >> (XEN) p2m.c:1890: d1v0: Failed to walk page-table va

[libvirt test] 152278: regressions - FAIL

2020-07-29 Thread osstest service owner
flight 152278 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/152278/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

[xen-unstable-coverity test] 152283: all pass - PUSHED

2020-07-29 Thread osstest service owner
flight 152283 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/152283/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen b071ec25e85c4aacf3da59e5258cda0b1c4df45d baseline version: xen 0562

[qemu-mainline test] 152266: regressions - FAIL

2020-07-29 Thread osstest service owner
flight 152266 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/152266/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 14 xen-boot/l1 fail REGR. vs. 151065 test-amd64-i386-x

[PATCH] xen/spinlock: move debug helpers inside the locked regions

2020-07-29 Thread Roger Pau Monne
Debug helpers such as lock profiling or the invariant pCPU assertions must strictly be performed inside the exclusive locked region, or else races might happen. Note the issue was not strictly introduced by the pointed commit in the Fixes tag, since lock stats where already incremented before the

RE: [PATCH 4/6] remove remaining uses of iommu_legacy_map/unmap

2020-07-29 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 26 July 2020 09:36 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > Andrew Cooper > ; Wei Liu ; Roger Pau Monné > ; George > Dunlap ; Ian Jackson ; > Julien Grall > ; Stefano Stabellini ; Jun Nakajima > ; > Kev

RE: [PATCH 5/6] iommu: remove the share_p2m operation

2020-07-29 Thread Durrant, Paul
> -Original Message- > From: Andrew Cooper > Sent: 24 July 2020 20:01 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Durrant, Paul ; Jan Beulich ; > George Dunlap > ; Wei Liu ; Roger Pau Monné > ; Kevin Tian > > Subject: RE: [EXTERNAL] [PATCH 5/6] iommu: remove the share_p2m

RE: [PATCH 5/6] iommu: remove the share_p2m operation

2020-07-29 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 26 July 2020 09:50 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > Andrew Cooper > ; George Dunlap ; Wei > Liu ; Roger Pau > Monné ; Kevin Tian > Subject: RE: [EXTERNAL] [PATCH 5/6] iommu: remove the share_p2m

[ovmf test] 152277: all pass - PUSHED

2020-07-29 Thread osstest service owner
flight 152277 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152277/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e848b58d7c85293cd4121287abcea2d22a4f0620 baseline version: ovmf 744ad444e5306ef68edbe

Re: [PATCH] xen/spinlock: move debug helpers inside the locked regions

2020-07-29 Thread Julien Grall
Hi Roger, On 29/07/2020 12:13, Roger Pau Monne wrote: Debug helpers such as lock profiling or the invariant pCPU assertions must strictly be performed inside the exclusive locked region, or else races might happen. Note the issue was not strictly introduced by the pointed commit in the Fixes ta

Re: [PATCH] xen/spinlock: move debug helpers inside the locked regions

2020-07-29 Thread Roger Pau Monné
On Wed, Jul 29, 2020 at 02:37:44PM +0100, Julien Grall wrote: > Hi Roger, > > On 29/07/2020 12:13, Roger Pau Monne wrote: > > Debug helpers such as lock profiling or the invariant pCPU assertions > > must strictly be performed inside the exclusive locked region, or else > > races might happen. > >

Re: [PATCH] xen/spinlock: move debug helpers inside the locked regions

2020-07-29 Thread Julien Grall
Hi Roger, On 29/07/2020 14:50, Roger Pau Monné wrote: On Wed, Jul 29, 2020 at 02:37:44PM +0100, Julien Grall wrote: Hi Roger, On 29/07/2020 12:13, Roger Pau Monne wrote: Debug helpers such as lock profiling or the invariant pCPU assertions must strictly be performed inside the exclusive locke

[qemu-mainline bisection] complete test-amd64-amd64-xl-qemuu-ws16-amd64

2020-07-29 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-qemuu-ws16-amd64 testid windows-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbi

[linux-linus test] 152272: regressions - FAIL

2020-07-29 Thread osstest service owner
flight 152272 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152272/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 10 debian-hvm-install fail REGR. vs. 151214 Regressi

Re: [PATCH] x86/cpuid: Fix APIC bit clearing

2020-07-29 Thread Roger Pau Monné
On Wed, Jul 29, 2020 at 05:33:41PM +0100, f...@euphon.net wrote: > From: Fam Zheng > > The bug is obvious here, other places in this function used > "cpufeat_mask" correctly. > > Signed-off-by: Fam Zheng > Fixes: 46df8a65 ("x86/cpuid: Effectively remove pv_cpuid() and hvm_cpuid()") Reviewed-by

Re: [PATCH] x86/cpuid: Fix APIC bit clearing

2020-07-29 Thread Andrew Cooper
On 29/07/2020 17:33, f...@euphon.net wrote: > From: Fam Zheng > > The bug is obvious here, other places in this function used > "cpufeat_mask" correctly. > > Signed-off-by: Fam Zheng > Fixes: 46df8a65 ("x86/cpuid: Effectively remove pv_cpuid() and hvm_cpuid()") > --- > xen/arch/x86/cpuid.c | 2 +

Re: fwupd support under Xen - firmware updates with the UEFI capsule

2020-07-29 Thread Jan Beulich
On 28.07.2020 23:01, Andrew Cooper wrote: On 28/07/2020 21:00, Jan Beulich wrote: On 28.07.2020 09:41, Norbert Kaminski wrote: I'm trying to add support for the firmware updates with the UEFI capsule in Qubes OS. I've got the troubles with reading ESRT (EFI System Resource Table) in the dom0, w

Re: [PATCH v2] xen/arm: Convert runstate address during hypcall

2020-07-29 Thread Jan Beulich
On 29.07.2020 09:08, Bertrand Marquis wrote: On 28 Jul 2020, at 21:54, Jan Beulich wrote: On 28.07.2020 17:52, Bertrand Marquis wrote: At the moment on Arm, a Linux guest running with KTPI enabled will cause the following error when a context switch happens in user mode: (XEN) p2m.c:1890: d

Re: [PATCH v3] print: introduce a format specifier for pci_sbdf_t

2020-07-29 Thread Jan Beulich
Andrew, On 27.07.2020 12:31, Roger Pau Monne wrote: The new format specifier is '%pp', and prints a pci_sbdf_t using the seg:bus:dev.func format. Replace all SBDFs printed using '%04x:%02x:%02x.%u' to use the new format specifier. No functional change intended. Signed-off-by: Roger Pau Monné

Re: [PATCH 1/5] xen/memory: Introduce CONFIG_ARCH_ACQUIRE_RESOURCE

2020-07-29 Thread Jan Beulich
On 28.07.2020 13:37, Andrew Cooper wrote: New architectures shouldn't be forced to implement no-op stubs for unused functionality. Introduce CONFIG_ARCH_ACQUIRE_RESOURCE which can be opted in to, and provide compatibility logic in xen/mm.h No functional change. Signed-off-by: Andrew Cooper

[xen-unstable test] 152275: tolerable FAIL - PUSHED

2020-07-29 Thread osstest service owner
flight 152275 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152275/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 152233 test-amd64-amd64-xl-qemuu-win7-amd64

Re: [PATCH 2/5] xen/gnttab: Rework resource acquisition

2020-07-29 Thread Jan Beulich
On 28.07.2020 13:37, Andrew Cooper wrote: The existing logic doesn't function in the general case for mapping a guests grant table, due to arbitrary 32 frame limit, and the default grant table limit being 64. In order to start addressing this, rework the existing grant table logic by implementin

Re: [PATCH 3/5] xen/memory: Fix compat XENMEM_acquire_resource for size requests

2020-07-29 Thread Jan Beulich
On 28.07.2020 13:37, Andrew Cooper wrote: Copy the nr_frames from the correct structure, so the caller doesn't unconditionally receive 0. Well, no - it does get copied from the correct structure. It's just that the field doesn't get set properly up front. Otherwise you'll (a) build in an unchec

Re: [RFC v2 1/2] arm,smmu: switch to using iommu_fwspec functions

2020-07-29 Thread Julien Grall
Hi Brian, On 22/07/2020 05:00, Brian Woods wrote: Modify the smmu driver so that it uses the iommu_fwspec helper functions. This means both ARM IOMMU drivers will both use the iommu_fwspec helper functions. Signed-off-by: Brian Woods --- Interested in if combining the legacy and generic bind

Re: [RFC v2 2/2] arm,smmu: add support for generic DT bindings

2020-07-29 Thread Julien Grall
Hi Brian, On 22/07/2020 05:00, Brian Woods wrote: Restructure some of the code and add supporting functions for adding generic device tree (DT) binding support. It feels to me you want to split the patch in two: 1) Restructure the code 2) Add support for DT bindings This will allow f

[linux-5.4 test] 152282: tolerable FAIL - PUSHED

2020-07-29 Thread osstest service owner
flight 152282 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/152282/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 16 guest-start/debian.repeatfail like 152137 test-amd64-amd64-libvirt 13 migrate

[xen-unstable-smoke test] 152288: regressions - FAIL

2020-07-29 Thread osstest service owner
flight 152288 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152288/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm 7 xen-boot fail REGR. vs. 152269 Tests which

Re: [PATCH] x86/S3: put data segment registers into known state upon resume

2020-07-29 Thread M. Vefa Bicakci
On 7/23/20 7:00 PM, Andrew Cooper wrote: On 23/07/2020 16:19, Jan Beulich wrote: On 23.07.2020 16:40, Andrew Cooper wrote: On 20/07/2020 16:20, Jan Beulich wrote: wakeup_32 sets %ds and %es to BOOT_DS, while leaving %fs at what wakeup_start did set it to, and %gs at whatever BIOS did load into

Re: [PATCH] x86/S3: put data segment registers into known state upon resume

2020-07-29 Thread Andrew Cooper
On 30/07/2020 00:29, M. Vefa Bicakci wrote: > On 7/23/20 7:00 PM, Andrew Cooper wrote: >> On 23/07/2020 16:19, Jan Beulich wrote: >>> On 23.07.2020 16:40, Andrew Cooper wrote: On 20/07/2020 16:20, Jan Beulich wrote: > wakeup_32 sets %ds and %es to BOOT_DS, while leaving %fs at what > w

Re: [PATCH] x86/S3: put data segment registers into known state upon resume

2020-07-29 Thread M. Vefa Bicakci
On 7/30/20 2:31 AM, Andrew Cooper wrote: On 30/07/2020 00:29, M. Vefa Bicakci wrote: On 7/23/20 7:00 PM, Andrew Cooper wrote: On 23/07/2020 16:19, Jan Beulich wrote: On 23.07.2020 16:40, Andrew Cooper wrote: On 20/07/2020 16:20, Jan Beulich wrote: wakeup_32 sets %ds and %es to BOOT_DS, while

Re: Porting Xen to Jetson Nano

2020-07-29 Thread Stefano Stabellini
On Wed, 29 Jul 2020, sr...@yujala.com wrote: > Hi Julien, > > On 2020-07-24 17:25, Julien Grall wrote: > > On 24/07/2020 16:01, Srinivas Bangalore wrote: > > > > I struggled to find your comment inline as your e-mail client doesn't > > quote my answer. Please configure your e-mail client to use s

kernel-doc and xen.git

2020-07-29 Thread Stefano Stabellini
Hi all, I would like to ask for your feedback on the adoption of the kernel-doc format for in-code comments. In the FuSa SIG we have started looking into FuSa documents for Xen. One of the things we are investigating are ways to link these documents to in-code comments in xen.git and vice versa.

Re: [PATCH v2] xen/arm: Convert runstate address during hypcall

2020-07-29 Thread Stefano Stabellini
On Wed, 29 Jul 2020, Jan Beulich wrote: > On 29.07.2020 09:08, Bertrand Marquis wrote: > > > On 28 Jul 2020, at 21:54, Jan Beulich wrote: > > > > > > On 28.07.2020 17:52, Bertrand Marquis wrote: > > > > At the moment on Arm, a Linux guest running with KTPI enabled will > > > > cause the following

[qemu-mainline test] 152284: regressions - FAIL

2020-07-29 Thread osstest service owner
flight 152284 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/152284/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-seattle 7 xen-boot fail REGR. vs. 151065 test-arm64-arm64-

[PATCH] x86/cpuid: Fix APIC bit clearing

2020-07-29 Thread fam
From: Fam Zheng The bug is obvious here, other places in this function used "cpufeat_mask" correctly. Signed-off-by: Fam Zheng Fixes: 46df8a65 ("x86/cpuid: Effectively remove pv_cpuid() and hvm_cpuid()") --- xen/arch/x86/cpuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[xen-unstable-smoke test] 152291: regressions - FAIL

2020-07-29 Thread osstest service owner
flight 152291 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152291/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm 7 xen-boot fail REGR. vs. 152269 Tests which