[libvirt test] 152226: regressions - FAIL

2020-07-27 Thread osstest service owner
flight 152226 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/152226/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

[ovmf test] 152225: all pass - PUSHED

2020-07-27 Thread osstest service owner
flight 152225 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152225/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6074f57e5b19c4cfd45a139b793191f34fa31781 baseline version: ovmf 8c30327debb28c0b6cfa2

Re: [PATCH v2 4/4] xen: add helpers to allocate unpopulated memory

2020-07-27 Thread David Hildenbrand
On 24.07.20 18:36, Boris Ostrovsky wrote: > On 7/24/20 10:34 AM, David Hildenbrand wrote: >> CCing Dan >> >> On 24.07.20 14:42, Roger Pau Monne wrote: >>> diff --git a/drivers/xen/unpopulated-alloc.c >>> b/drivers/xen/unpopulated-alloc.c >>> new file mode 100644 >>> index ..aaa91cefbbf

Re: [RFC PATCH v1 2/4] xen/arm: Discovering PCI devices and add the PCI devices in XEN.

2020-07-27 Thread Rahul Singh
Sorry for the late reply. > On 23 Jul 2020, at 9:44 pm, Stefano Stabellini wrote: > > On Thu, 23 Jul 2020, Rahul Singh wrote: >> Hardware domain is in charge of doing the PCI enumeration and will >> discover the PCI devices and then will communicate to XEN via hyper >> call PHYSDEVOP_pci_device_

Re: [PATCH v2 4/4] xen: add helpers to allocate unpopulated memory

2020-07-27 Thread Roger Pau Monné
On Fri, Jul 24, 2020 at 12:36:33PM -0400, Boris Ostrovsky wrote: > On 7/24/20 10:34 AM, David Hildenbrand wrote: > > CCing Dan > > > > On 24.07.20 14:42, Roger Pau Monne wrote: > >> + > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> + > >> +#inclu

Re: [PATCH v7 03/15] x86/mm: rewrite virt_to_xen_l*e

2020-07-27 Thread Hongyan Xia
On Tue, 2020-07-14 at 12:47 +0200, Jan Beulich wrote: > On 29.05.2020 13:11, Hongyan Xia wrote: > > From: Wei Liu > > > > Rewrite those functions to use the new APIs. Modify its callers to > > unmap > > the pointer returned. Since alloc_xen_pagetable_new() is almost > > never > > useful unless ac

[PATCH v3 3/4] Revert "xen/balloon: Fix crash when ballooning on x86 32 bit PAE"

2020-07-27 Thread Roger Pau Monne
This reverts commit dfd74a1edfaba5864276a2859190a8d242d18952. This has been fixed by commit dca4436d1cf9e0d237c which added the out of bounds check to __add_memory, so that trying to add blocks past MAX_PHYSMEM_BITS will fail. Note the check in the Xen balloon driver was bogus anyway, as it check

[PATCH v3 1/4] xen/balloon: fix accounting in alloc_xenballooned_pages error path

2020-07-27 Thread Roger Pau Monne
target_unpopulated is incremented with nr_pages at the start of the function, but the call to free_xenballooned_pages will only subtract pgno number of pages, and thus the rest need to be subtracted before returning or else accounting will be skewed. Signed-off-by: Roger Pau Monné Reviewed-by: Ju

[PATCH v3 0/4] xen/balloon: fixes for memory hotplug

2020-07-27 Thread Roger Pau Monne
Hello, The following series contain some fixes in order to split Xen unpopulated memory handling from the ballooning driver if ZONE_DEVICE is available, so that physical memory regions used to map foreign pages are not tied to memory hotplug. First two patches are bugfixes that IMO should be back

[PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-27 Thread Roger Pau Monne
To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels without support for ZONE_DEVICE Xen will fallbac

[PATCH v3 2/4] xen/balloon: make the balloon wait interruptible

2020-07-27 Thread Roger Pau Monne
So it can be killed, or else processes can get hung indefinitely waiting for balloon pages. Signed-off-by: Roger Pau Monné Reviewed-by: Juergen Gross Cc: sta...@vger.kernel.org --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-devel@lists.xenproject.org --- drivers/xen

Re: [PATCH] xen: hypercall.h: fix duplicated word

2020-07-27 Thread Jürgen Groß
On 26.07.20 02:17, Randy Dunlap wrote: Change the repeated word "as" to "as a". Signed-off-by: Randy Dunlap Reviewed-by: Juergen Gross Juergen

[PATCH v3] print: introduce a format specifier for pci_sbdf_t

2020-07-27 Thread Roger Pau Monne
The new format specifier is '%pp', and prints a pci_sbdf_t using the seg:bus:dev.func format. Replace all SBDFs printed using '%04x:%02x:%02x.%u' to use the new format specifier. No functional change intended. Signed-off-by: Roger Pau Monné Reviewed-by: Kevin Tian Acked-by: Julien Grall For ju

Re: [RFC PATCH v1 1/4] arm/pci: PCI setup and PCI host bridge discovery within XEN on ARM.

2020-07-27 Thread Roger Pau Monné
On Fri, Jul 24, 2020 at 05:54:20PM +0100, Julien Grall wrote: > Hi Jan, > > On 24/07/2020 17:01, Jan Beulich wrote: > > On 24.07.2020 17:15, Julien Grall wrote: > > > On 24/07/2020 15:44, Roger Pau Monné wrote: > > > > > + > > > > > +struct pci_host_bridge *bridge = pci_find_host_bridge(sbdf.s

Re: [RFC PATCH v1 1/4] arm/pci: PCI setup and PCI host bridge discovery within XEN on ARM.

2020-07-27 Thread Roger Pau Monné
On Sat, Jul 25, 2020 at 10:59:50AM +0100, Julien Grall wrote: > On Sat, 25 Jul 2020 at 00:46, Stefano Stabellini > wrote: > > > > On Fri, 24 Jul 2020, Julien Grall wrote: > > > On Fri, 24 Jul 2020 at 19:32, Stefano Stabellini > > > wrote: > > > > > If they are not equal, then I fail to see why

[linux-linus test] 152223: regressions - FAIL

2020-07-27 Thread osstest service owner
flight 152223 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152223/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-pair 11 xen-boot/dst_hostfail REGR. vs. 151214 test-arm64-arm64-li

Re: [PATCH v7 09/15] efi: use new page table APIs in copy_mapping

2020-07-27 Thread Hongyan Xia
On Tue, 2020-07-14 at 14:42 +0200, Jan Beulich wrote: > On 29.05.2020 13:11, Hongyan Xia wrote: > > From: Wei Liu > > > > After inspection ARM doesn't have alloc_xen_pagetable so this > > function > > is x86 only, which means it is safe for us to change. > > Well, it sits inside a "#ifndef CONFI

[RFC PATCH 1/2] libxl: add Function class to IDL

2020-07-27 Thread Nick Rosbrook
Add a Function and CtxFunction classes to idl.py to allow generator scripts to generate wrappers which are repetitive and straight forward when doing so by hand. Examples of such functions are the device_add/remove functions. To start, a Function has attributes for namespace, name, parameters, ret

[RFC PATCH 2/2] libxl: prototype libxl_device_nic_add/remove with IDL

2020-07-27 Thread Nick Rosbrook
Add a DeviceFunction class and describe prototypes for libxl_device_nic_add/remove in libxl_types.idl. Signed-off-by: Nick Rosbrook -- This is mostly to serve as an example of how the first patch would be used for function support in the IDL. --- tools/libxl/idl.py | 8 tools/l

[RFC PATCH 0/2] add function support to IDL

2020-07-27 Thread Nick Rosbrook
At a Xen Summit design session for the golang bindings (see [1]), we agreed that it would be beneficial to expand the libxl IDL with function support. In addition to benefiting libxl itself, this would allow other language bindings to easily generate function wrappers. These RFC patches outline a

Re: [RFC PATCH v1 1/4] arm/pci: PCI setup and PCI host bridge discovery within XEN on ARM.

2020-07-27 Thread Rahul Singh
> On 24 Jul 2020, at 12:38 am, Stefano Stabellini > wrote: > > + Jan, Andrew, Roger > > Please have a look at my comment on whether we should share the MMCFG > code below, feel free to ignore the rest :-) > > > On Thu, 23 Jul 2020, Rahul Singh wrote: >> XEN during boot will read the PCI dev

RE: [PATCH 1/6] x86/iommu: re-arrange arch_iommu to separate common fields...

2020-07-27 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 26 July 2020 09:14 > To: p...@xen.org > Cc: 'Andrew Cooper' ; > xen-devel@lists.xenproject.org; Durrant, Paul > ; 'Lukasz Hawrylko' ; > 'Wei Liu' ; > 'Roger Pau Monné' ; 'Kevin Tian' > Subject: RE: [EXTERNAL] [PATCH 1/6] x86/iommu: re-arr

RE: [PATCH 2/6] x86/iommu: add common page-table allocator

2020-07-27 Thread Durrant, Paul
> -Original Message- > From: Andrew Cooper > Sent: 24 July 2020 19:24 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Durrant, Paul ; Jan Beulich ; > Kevin Tian > ; Wei Liu ; Roger Pau Monné > > Subject: RE: [EXTERNAL] [PATCH 2/6] x86/iommu: add common page-table allocator >

Re: [RFC PATCH v1 4/4] arm/libxl: Emulated PCI device tree node in libxl

2020-07-27 Thread Rahul Singh
> On 24 Jul 2020, at 12:39 am, Stefano Stabellini > wrote: > > On Thu, 23 Jul 2020, Rahul Singh wrote: >> libxl will create an emulated PCI device tree node in the >> device tree to enable the guest OS to discover the virtual >> PCI during guest boot. >> >> We introduced the new config option

Re: [PATCH v7 09/15] efi: use new page table APIs in copy_mapping

2020-07-27 Thread Hongyan Xia
On Mon, 2020-07-27 at 13:45 +0100, Hongyan Xia wrote: > On Tue, 2020-07-14 at 14:42 +0200, Jan Beulich wrote: > > On 29.05.2020 13:11, Hongyan Xia wrote: > > > From: Wei Liu > > > > > > After inspection ARM doesn't have alloc_xen_pagetable so this > > > function > > > is x86 only, which means it

[qemu-mainline bisection] complete test-amd64-amd64-qemuu-nested-amd

2020-07-27 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-qemuu-nested-amd testid xen-boot/l1 Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.

RE: [PATCH 3/6] iommu: remove iommu_lookup_page() and the lookup_page() method...

2020-07-27 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 26 July 2020 09:28 > To: p...@xen.org > Cc: 'Andrew Cooper' ; > xen-devel@lists.xenproject.org; Durrant, Paul > ; 'Kevin Tian' > Subject: RE: [EXTERNAL] [PATCH 3/6] iommu: remove iommu_lookup_page() and the > lookup_page() method... > >

RE: [PATCH 6/6] iommu: stop calling IOMMU page tables 'p2m tables'

2020-07-27 Thread Durrant, Paul
> -Original Message- > From: Andrew Cooper > Sent: 24 July 2020 20:09 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Durrant, Paul ; Jan Beulich ; > Kevin Tian > > Subject: RE: [EXTERNAL] [PATCH 6/6] iommu: stop calling IOMMU page tables > 'p2m tables' > > CAUTION: This emai

[PATCH v8 00/15] switch to domheap for Xen page tables

2020-07-27 Thread Hongyan Xia
From: Hongyan Xia This series rewrites all the remaining functions and finally makes the switch from xenheap to domheap for Xen page tables, so that they no longer need to rely on the direct map, which is a big step towards removing the direct map. This series depends on the following mini-serie

[PATCH v8 08/15] x86_64/mm: switch to new APIs in setup_m2p_table

2020-07-27 Thread Hongyan Xia
From: Wei Liu While doing so, avoid repetitive mapping of l2_ro_mpt by keeping it across loops, and only unmap and map it when crossing 1G boundaries. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia Reviewed-by: Jan Beulich --- Changed in v8: - re-structure if condition around l2_ro_mpt. -

[PATCH v8 02/15] x86/mm: make sure there is one exit path for modify_xen_mappings

2020-07-27 Thread Hongyan Xia
From: Wei Liu We will soon need to handle dynamically mapping / unmapping page tables in the said function. Since dynamic mappings may map and unmap pl3e in different iterations, lift pl3e out of the loop. No functional change. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed si

[PATCH v8 04/15] x86/mm: switch to new APIs in map_pages_to_xen

2020-07-27 Thread Hongyan Xia
From: Wei Liu Page tables allocated in that function should be mapped and unmapped now. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia Reviewed-by: Jan Beulich --- xen/arch/x86/mm.c | 60 +-- 1 file changed, 36 insertions(+), 24 deletion

[PATCH v8 01/15] x86/mm: map_pages_to_xen would better have one exit path

2020-07-27 Thread Hongyan Xia
From: Wei Liu We will soon rewrite the function to handle dynamically mapping and unmapping of page tables. Since dynamic mappings may map and unmap pages in different iterations of the while loop, we need to lift pl3e out of the loop. No functional change. Signed-off-by: Wei Liu Signed-off-by

[PATCH v8 03/15] x86/mm: rewrite virt_to_xen_l*e

2020-07-27 Thread Hongyan Xia
From: Wei Liu Rewrite those functions to use the new APIs. Modify its callers to unmap the pointer returned. Since alloc_xen_pagetable_new() is almost never useful unless accompanied by page clearing and a mapping, introduce a helper alloc_map_clear_xen_pt() for this sequence. Note that the chan

[PATCH v8 05/15] x86/mm: switch to new APIs in modify_xen_mappings

2020-07-27 Thread Hongyan Xia
From: Wei Liu Page tables allocated in that function should be mapped and unmapped now. Note that pl2e now maybe mapped and unmapped in different iterations, so we need to add clean-ups for that. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia Reviewed-by: Jan Beulich --- Changed in v7: -

[PATCH v8 07/15] x86_64/mm: switch to new APIs in paging_init

2020-07-27 Thread Hongyan Xia
From: Wei Liu Map and unmap pages instead of relying on the direct map. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia Reviewed-by: Jan Beulich --- Changed in v8: - replace l3/2_ro_mpt_mfn with just mfn since their lifetimes do not overlap Changed in v7: - use the new alloc_map_clear_x

[PATCH v8 09/15] efi: use new page table APIs in copy_mapping

2020-07-27 Thread Hongyan Xia
From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v8: - remove redundant commit message. - unmap l3src based on va instead of mfn. - re-structure if condition around l3dst. Changed in v7: - hoist l3 variables out of the loop to avoid repetitive mappings. --- xen/

[PATCH v8 06/15] x86_64/mm: introduce pl2e in paging_init

2020-07-27 Thread Hongyan Xia
From: Wei Liu We will soon map and unmap pages in paging_init(). Introduce pl2e so that we can use l2_ro_mpt to point to the page table itself. No functional change. Signed-off-by: Wei Liu Acked-by: Jan Beulich --- Changed in v7: - reword commit message. --- xen/arch/x86/x86_64/mm.c | 16 ++

qdisk error with rbd

2020-07-27 Thread Antoine Perdaens
Hello all, Our current setup is based on Xen 4.11 + Qemu 3.1 with rbd disks, an example of a disk that works : "vdev=xvda1,backendtype=qdisk,target=rbd:rbd-pool/disk-02-root:id=rbd”. The same setup with Qemu 5.0 gives this error in /var/log/xen/qemu-dm-* : "qemu-system-i386: failed to create '

[PATCH v8 14/15] x86: switch to use domheap page for page tables

2020-07-27 Thread Hongyan Xia
From: Hongyan Xia Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia Reviewed-by: Jan Beulich --- Changed in v8: - const qualify pg in alloc_xen_pagetable_new(). --- xen/arch/x86/mm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/

[PATCH v8 15/15] x86/mm: drop _new suffix for page table APIs

2020-07-27 Thread Hongyan Xia
From: Wei Liu No functional change. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia Acked-by: Jan Beulich --- xen/arch/x86/mm.c| 44 ++-- xen/arch/x86/smpboot.c | 6 +++--- xen/arch/x86/x86_64/mm.c | 2 +- xen/include/asm-x86/mm.h | 4 ++

[PATCH v8 10/15] efi: switch to new APIs in EFI code

2020-07-27 Thread Hongyan Xia
From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia Reviewed-by: Jan Beulich --- Changed in v7: - add blank line after declaration. - rename efi_l4_pgtable into efi_l4t. - pass the mapped efi_l4t to copy_mapping() instead of map it again. - use the alloc_map_clear_xen_pt() API. -

[PATCH v8 11/15] x86/smpboot: add exit path for clone_mapping()

2020-07-27 Thread Hongyan Xia
From: Wei Liu We will soon need to clean up page table mappings in the exit path. No functional change. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v7: - edit commit message. - begin with rc = 0 and set it to -ENOMEM ahead of if(). --- xen/arch/x86/smpboot.c | 16 ++

[PATCH v8 13/15] x86/mm: drop old page table APIs

2020-07-27 Thread Hongyan Xia
From: Hongyan Xia Two sets of old APIs, alloc/free_xen_pagetable() and lXe_to_lYe(), are now dropped to avoid the dependency on direct map. There are two special cases which still have not been re-written into the new APIs, thus need special treatment: rpt in smpboot.c cannot use ephemeral mapp

[PATCH v8 12/15] x86/smpboot: switch clone_mapping() to new APIs

2020-07-27 Thread Hongyan Xia
From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia Reviewed-by: Jan Beulich --- Changed in v7: - change patch title - remove initialiser of pl3e. - combine the initialisation of pl3e into a single assignment. - use the new alloc_map_clear() helper. - use the normal map_domain_pag

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-27 Thread Roger Pau Monné
On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote: > Introduce proper assembler macros instead, enabled only when the > assembler itself doesn't support the insns. To avoid duplicating the > macros for assembly and C files, have them processed into asm-macros.h. > This in turn requires ad

Re: [PATCH 2/4] x86: reduce CET-SS related #ifdef-ary

2020-07-27 Thread Roger Pau Monné
On Wed, Jul 15, 2020 at 12:48:46PM +0200, Jan Beulich wrote: > Commit b586a81b7a90 ("x86/CET: Fix build following c/s 43b98e7190") had > to introduce a number of #ifdef-s to make the build work with older tool > chains. Introduce an assembler macro covering for tool chains not > knowing of CET-SS,

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-27 Thread Jürgen Groß
On 27.07.20 11:13, Roger Pau Monne wrote: To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels with

Re: [PATCH 3/4] x86: drop ASM_{CL,ST}AC

2020-07-27 Thread Roger Pau Monné
On Wed, Jul 15, 2020 at 12:49:04PM +0200, Jan Beulich wrote: > Use ALTERNATIVE directly, such that at the use sites it is visible that > alternative code patching is in use. Similarly avoid hiding the fact in > SAVE_ALL. > > No change to generated code. > > Signed-off-by: Jan Beulich I think th

Re: [PATCH 4/4] x86: fold indirect_thunk_asm.h into asm-defns.h

2020-07-27 Thread Roger Pau Monné
On Wed, Jul 15, 2020 at 12:49:40PM +0200, Jan Beulich wrote: > There's little point in having two separate headers both getting > included by asm_defns.h. This in particular reduces the number of > instances of guarding asm(".include ...") suitably in such dual use > headers. > > No change to gene

Re: [RFC PATCH v1 1/4] arm/pci: PCI setup and PCI host bridge discovery within XEN on ARM.

2020-07-27 Thread Rahul Singh
> On 24 Jul 2020, at 8:03 am, Oleksandr Andrushchenko > wrote: > > > On 7/24/20 2:38 AM, Stefano Stabellini wrote: >> + Jan, Andrew, Roger >> >> Please have a look at my comment on whether we should share the MMCFG >> code below, feel free to ignore the rest :-) >> >> >> On Thu, 23 Jul 202

Re: [RFC PATCH v1 1/4] arm/pci: PCI setup and PCI host bridge discovery within XEN on ARM.

2020-07-27 Thread Rahul Singh
> On 24 Jul 2020, at 9:05 am, Julien Grall wrote: > > Hi, > > On 24/07/2020 08:03, Oleksandr Andrushchenko wrote: diff --git a/xen/arch/arm/pci/pci-access.c b/xen/arch/arm/pci/pci-access.c new file mode 100644 index 00..c53ef58336 --- /dev/null +++ b/xen/arch/

Re: [RFC PATCH v1 1/4] arm/pci: PCI setup and PCI host bridge discovery within XEN on ARM.

2020-07-27 Thread Rahul Singh
> On 24 Jul 2020, at 9:23 am, Julien Grall wrote: > > Hi Rahul, > > On 23/07/2020 16:40, Rahul Singh wrote: >> XEN during boot will read the PCI device tree node “reg” property >> and will map the PCI config space to the XEN memory. >> XEN will read the “linux, pci-domain” property from the de

[[XSATOOL]] repo: Add missing spaces in the configure cmdline for "xentools"

2020-07-27 Thread Julien Grall
From: Julien Grall The operator + will just concatenate two strings. As the result, the configure cmdline for "xentools" will look like: ./configure --disable-stubdom --disable-qemu-traditional--with-system-qemu=/bin/false --with-system-seabios=/bin/false--disable-ovmf This can be avoided by

Re: [[XSATOOL]] repo: Add missing spaces in the configure cmdline for "xentools"

2020-07-27 Thread Julien Grall
Hmmm I forgot to CC George. Sorry for that. On 27/07/2020 17:04, Julien Grall wrote: From: Julien Grall The operator + will just concatenate two strings. As the result, the configure cmdline for "xentools" will look like: ./configure --disable-stubdom --disable-qemu-traditional--with-system-

Re: [RFC PATCH v1 2/4] xen/arm: Discovering PCI devices and add the PCI devices in XEN.

2020-07-27 Thread Rahul Singh
> On 24 Jul 2020, at 8:14 am, Oleksandr Andrushchenko > wrote: > > > On 7/23/20 11:44 PM, Stefano Stabellini wrote: >> On Thu, 23 Jul 2020, Rahul Singh wrote: >>> Hardware domain is in charge of doing the PCI enumeration and will >>> discover the PCI devices and then will communicate to XEN

Re: [OSSTEST PATCH 06/14] sg-report-flight: Use WITH clause to use index for $anypassq

2020-07-27 Thread George Dunlap
> On Jul 21, 2020, at 7:41 PM, Ian Jackson wrote: > > Perf: runtime of my test case now ~11s > > Example query before (from the Perl DBI trace): > >SELECT * FROM flights JOIN steps USING (flight) >WHERE (branch='xen-unstable') > AND job=? and testid=? and sta

[xen-unstable-smoke test] 152235: tolerable all pass - PUSHED

2020-07-27 Thread osstest service owner
flight 152235 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152235/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH v2 4/5] x86/vpt: only try to resume timers belonging to enabled devices

2020-07-27 Thread Roger Pau Monne
Check whether the emulated device is actually enabled before trying to resume the associated timers. Thankfully all those structures are zeroed at initialization, and since the devices are not enabled they are never populated, which triggers the pt->vcpu check at the beginning of pt_resume forcing

[PATCH v2 2/5] x86/hvm: don't force vCPU 0 for IRQ 0 when using fixed destination mode

2020-07-27 Thread Roger Pau Monne
When the IO APIC pin mapped to the ISA IRQ 0 has been configured to use fixed delivery mode do not forcefully route interrupts to vCPU 0, as the OS might have setup those interrupts to be injected to a different vCPU, and injecting to vCPU 0 can cause the OS to miss such interrupts or errors to hap

[PATCH v2 1/5] x86/hvm: fix vIO-APIC build without IRQ0_SPECIAL_ROUTING

2020-07-27 Thread Roger Pau Monne
pit_channel0_enabled needs to be guarded with IRQ0_SPECIAL_ROUTING since it's only used when the special handling of ISA IRQ 0 is enabled. However such helper being a single line it's better to just inline it directly in vioapic_deliver where it's used. No functional change. Signed-off-by: Roger

[PATCH v2 0/5] x86_ virtual timer related fixes

2020-07-27 Thread Roger Pau Monne
Hello, This is the first part of the vPT fixes that in the past I've posted as a single series. I don't think it has any controversial patches, and most have already been Acked or RB. I've split them from the series because those can likely go in now, while I work on properly finishing the remain

[PATCH v2 3/5] x86/hvm: fix ISA IRQ 0 handling when set as lowest priority mode in IO APIC

2020-07-27 Thread Roger Pau Monne
Lowest priority destination mode does allow the vIO APIC code to select a vCPU to inject the interrupt to, but the selected vCPU must be part of the possible destinations configured for such IO APIC pin. Fix the code in order to only force vCPU 0 if it's part of the listed destinations. Signed-of

[PATCH v2 5/5] x86/hvm: only translate ISA interrupts to GSIs in virtual timers

2020-07-27 Thread Roger Pau Monne
Only call hvm_isa_irq_to_gsi for ISA interrupts, interrupts originating from an IO APIC pin already use a GSI and don't need to be translated. I haven't observed any issues from this, but I think it's better to use it correctly. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Change

Re: [OSSTEST PATCH 14/14] duration_estimator: Move duration query loop into database

2020-07-27 Thread George Dunlap
> On Jul 21, 2020, at 7:42 PM, Ian Jackson wrote: > > Stuff the two queries together: we use the firsty query as a WITH > clause. This is significantly faster, perhaps because the query > optimiser does a better job but probably just because it saves on > round trips. > > No functional change

Re: [PATCH v7 03/15] x86/mm: rewrite virt_to_xen_l*e

2020-07-27 Thread Jan Beulich
On 27.07.2020 11:09, Hongyan Xia wrote: On Tue, 2020-07-14 at 12:47 +0200, Jan Beulich wrote: On 29.05.2020 13:11, Hongyan Xia wrote: --- a/xen/include/asm-x86/page.h +++ b/xen/include/asm-x86/page.h @@ -291,7 +291,13 @@ void copy_page_sse2(void *, const void *); #define pfn_to_paddr(pfn) _

Re: [PATCH v7 09/15] efi: use new page table APIs in copy_mapping

2020-07-27 Thread Jan Beulich
On 27.07.2020 14:45, Hongyan Xia wrote: On Tue, 2020-07-14 at 14:42 +0200, Jan Beulich wrote: On 29.05.2020 13:11, Hongyan Xia wrote: @@ -1442,29 +1443,42 @@ static __init void copy_mapping(unsigned long mfn, unsigned long end, unsigned long em

Re: [PATCH 2/6] x86/iommu: add common page-table allocator

2020-07-27 Thread Jan Beulich
On 27.07.2020 11:37, Durrant, Paul wrote: From: Andrew Cooper Sent: 24 July 2020 19:24 On 24/07/2020 17:46, Paul Durrant wrote: --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -140,11 +140,19 @@ int arch_iommu_domain_init(struct domain *d) spin_loc

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-27 Thread Jan Beulich
On 27.07.2020 16:55, Roger Pau Monné wrote: On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote: --- /dev/null +++ b/xen/include/asm-x86/asm-defns.h Maybe this could be asm-insn.h or a different name? I find it confusing to have asm-defns.h and an asm_defs.h. While indeed I anticipat

Re: [PATCH 2/4] x86: reduce CET-SS related #ifdef-ary

2020-07-27 Thread Jan Beulich
On 27.07.2020 17:00, Roger Pau Monné wrote: On Wed, Jul 15, 2020 at 12:48:46PM +0200, Jan Beulich wrote: Commit b586a81b7a90 ("x86/CET: Fix build following c/s 43b98e7190") had to introduce a number of #ifdef-s to make the build work with older tool chains. Introduce an assembler macro covering

[qemu-mainline test] 152227: regressions - FAIL

2020-07-27 Thread osstest service owner
flight 152227 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/152227/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 14 xen-boot/l1 fail REGR. vs. 151065 test-amd64-i386-x

Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode

2020-07-27 Thread Boris Ostrovsky
On 7/24/20 7:01 PM, Stefano Stabellini wrote: > Yes, it does, thank you. I'd rather not introduce unknown regressions so > I would recommend to add an arch-specific check on registering > freeze/thaw/restore handlers. Maybe something like the following: > > #ifdef CONFIG_X86 > .freeze = blkfron

RE: Porting Xen to Jetson Nano

2020-07-27 Thread Srinivas Bangalore
Hi, On 24/07/2020 16:01, Srinivas Bangalore wrote: > Hi Julien, Hello, > > Thanks for the tips. Comments inline... I struggled to find your comment inline as your e-mail client doesn't quote my answer. Please configure your e-mail client to use some form of quoting (the usual is '>'). [] Don

[PATCH AUTOSEL 5.7 22/25] xen-netfront: fix potential deadlock in xennet_remove()

2020-07-27 Thread Sasha Levin
From: Andrea Righi [ Upstream commit c2c633106453611be07821f53dff9e93a9d1c3f0 ] There's a potential race in xennet_remove(); this is what the driver is doing upon unregistering a network device: 1. state = read bus state 2. if state is not "Closed": 3.request to set state to "Closing"

[PATCH AUTOSEL 5.4 15/17] xen-netfront: fix potential deadlock in xennet_remove()

2020-07-27 Thread Sasha Levin
From: Andrea Righi [ Upstream commit c2c633106453611be07821f53dff9e93a9d1c3f0 ] There's a potential race in xennet_remove(); this is what the driver is doing upon unregistering a network device: 1. state = read bus state 2. if state is not "Closed": 3.request to set state to "Closing"

[PATCH AUTOSEL 4.4 4/4] xen-netfront: fix potential deadlock in xennet_remove()

2020-07-27 Thread Sasha Levin
From: Andrea Righi [ Upstream commit c2c633106453611be07821f53dff9e93a9d1c3f0 ] There's a potential race in xennet_remove(); this is what the driver is doing upon unregistering a network device: 1. state = read bus state 2. if state is not "Closed": 3.request to set state to "Closing"

[PATCH AUTOSEL 4.9 7/7] xen-netfront: fix potential deadlock in xennet_remove()

2020-07-27 Thread Sasha Levin
From: Andrea Righi [ Upstream commit c2c633106453611be07821f53dff9e93a9d1c3f0 ] There's a potential race in xennet_remove(); this is what the driver is doing upon unregistering a network device: 1. state = read bus state 2. if state is not "Closed": 3.request to set state to "Closing"

[PATCH AUTOSEL 4.19 10/10] xen-netfront: fix potential deadlock in xennet_remove()

2020-07-27 Thread Sasha Levin
From: Andrea Righi [ Upstream commit c2c633106453611be07821f53dff9e93a9d1c3f0 ] There's a potential race in xennet_remove(); this is what the driver is doing upon unregistering a network device: 1. state = read bus state 2. if state is not "Closed": 3.request to set state to "Closing"

[PATCH AUTOSEL 4.14 10/10] xen-netfront: fix potential deadlock in xennet_remove()

2020-07-27 Thread Sasha Levin
From: Andrea Righi [ Upstream commit c2c633106453611be07821f53dff9e93a9d1c3f0 ] There's a potential race in xennet_remove(); this is what the driver is doing upon unregistering a network device: 1. state = read bus state 2. if state is not "Closed": 3.request to set state to "Closing"

Re: [RFC PATCH v1 1/4] arm/pci: PCI setup and PCI host bridge discovery within XEN on ARM.

2020-07-27 Thread Stefano Stabellini
On Mon, 27 Jul 2020, Roger Pau Monné wrote: > On Sat, Jul 25, 2020 at 10:59:50AM +0100, Julien Grall wrote: > > On Sat, 25 Jul 2020 at 00:46, Stefano Stabellini > > wrote: > > > > > > On Fri, 24 Jul 2020, Julien Grall wrote: > > > > On Fri, 24 Jul 2020 at 19:32, Stefano Stabellini > > > > wrote

[linux-linus test] 152232: regressions - FAIL

2020-07-27 Thread osstest service owner
flight 152232 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152232/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-xsm 16 guest-start/debian.repeat fail REGR. vs. 151214 Tests which are fa