Re: [OSSTEST PATCH 22/38] buster: Extend guest bootloader workaround

2020-05-29 Thread Julien Grall
Hi, On 28/05/2020 16:41, Ian Jackson wrote: Julien Grall writes ("Re: [OSSTEST PATCH 22/38] buster: Extend guest bootloader workaround"): On 28/05/2020 15:53, Ian Jackson wrote: It's Complicated. There are several options, but the usual ones are: 1. pygrub: Install some version of grub, whi

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Roger Pau Monné
On Thu, May 28, 2020 at 07:54:35PM +0100, Julien Grall wrote: > Hi Bertrand, > > Thank you for the patch. > > On 28/05/2020 16:25, Bertrand Marquis wrote: > > +static int map_runstate_area(struct vcpu *v, > > +struct vcpu_register_runstate_memory_area *area) > > +{ > > +un

Re: [PATCH v2 3/3] clang: don't define nocall

2020-05-29 Thread Julien Grall
Hi Roger, On 28/05/2020 15:40, Roger Pau Monne wrote: Clang doesn't support attribute error, and the possible equivalents like diagnose_if don't seem to work well in this case as they trigger when when the function is not called (just by being used by the APPEND_CALL macro). OOI, could you sha

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Jan Beulich
On 28.05.2020 20:54, Julien Grall wrote: > On 28/05/2020 16:25, Bertrand Marquis wrote: >> At the moment on Arm, a Linux guest running with KTPI enabled will >> cause the following error when a context switch happens in user mode: >> (XEN) p2m.c:1890: d1v0: Failed to walk page-table va 0xff837e

[PATCH v3 1/4] microvm: use 3G split unconditionally

2020-05-29 Thread Gerd Hoffmann
Looks like the logic was copied over from q35. q35 does this for backward compatibility, there is no reason to do this on microvm though. Also microvm doesn't need much mmio space, 1G is more than enough. Using an mmio window smaller than 1G is bad for gigabyte alignment and hugepages though. S

[PATCH v3 4/4] microvm: move virtio base to 0xfeb00000

2020-05-29 Thread Gerd Hoffmann
Place virtio-mmio devices near the other mmio regions, next ioapic is at @ 0xfec0. Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386/microvm.h b/include/hw/i386/microvm.h index ba68d1f22bb3..fd34b78e

[PATCH v3 2/4] microvm: drop max-ram-below-4g support

2020-05-29 Thread Gerd Hoffmann
Not useful for microvm and allows users to shoot themself into the foot (make ram + mmio overlap). Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Acked-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/microvm.c | 19 --- 1 file changed, 19 deletions(-

[PATCH v3 0/4] microvm: memory config tweaks

2020-05-29 Thread Gerd Hoffmann
With more microvm memory config tweaks split this into its owns series, the microvm acpi patch series is already big enough ... v2: - use 3G split. - add patch to move virtio-mmio region. - pick up acks & reviews. v3: - fix xen build. - pick up acks & reviews. take care, Gerd Gerd Hoffman

[PATCH v3 3/4] x86: move max-ram-below-4g to pc

2020-05-29 Thread Gerd Hoffmann
Move from X86MachineClass to PCMachineClass so it disappears from microvm machine type property list. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini --- include/hw/i386/pc.h | 2 ++ include/hw/i386/x86.h | 4 hw/i386/pc.c | 46

RE: [PATCH v3 3/4] x86: move max-ram-below-4g to pc

2020-05-29 Thread Paul Durrant
> -Original Message- > From: Gerd Hoffmann > Sent: 29 May 2020 08:40 > To: qemu-de...@nongnu.org > Cc: Paolo Bonzini ; Eduardo Habkost > ; Sergio Lopez > ; phi...@redhat.com; Marcel Apfelbaum > ; Stefano Stabellini > ; Paul Durrant ; > xen-devel@lists.xenproject.org; Michael S. > Tsirki

Re: [PATCH 2/2] SUPPORT.md: add hypervisor file system

2020-05-29 Thread Jan Beulich
On 26.05.2020 11:50, Juergen Gross wrote: > Signed-off-by: Juergen Gross Acked-by: Jan Beulich

*** Cut-off date for Xen 4.14 is today ***

2020-05-29 Thread Paul Durrant
Hi all, This is a reminder that the cut-off date for Xen 4.14 is today (May 29th). If you want your features to be included for the release, please make sure they are committed a.s.a.p. Paul Durrant

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Bertrand Marquis
Hi Julien, > On 28 May 2020, at 19:54, Julien Grall wrote: > > Hi Bertrand, > > Thank you for the patch. > > On 28/05/2020 16:25, Bertrand Marquis wrote: >> At the moment on Arm, a Linux guest running with KTPI enabled will >> cause the following error when a context switch happens in user mod

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Bertrand Marquis
> On 28 May 2020, at 20:12, Julien Grall wrote: > > Hi, > > On 28/05/2020 18:19, Bertrand Marquis wrote: + +return 0; +} + int domain_kill(struct domain *d) { int rc = 0; @@ -727,7 +788,10 @@ int domain_kill(struct domain *d) if ( cp

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Bertrand Marquis
> On 29 May 2020, at 08:19, Roger Pau Monné wrote: > > On Thu, May 28, 2020 at 07:54:35PM +0100, Julien Grall wrote: >> Hi Bertrand, >> >> Thank you for the patch. >> >> On 28/05/2020 16:25, Bertrand Marquis wrote: >>> +static int map_runstate_area(struct vcpu *v, >>> +str

Re: [PATCH v2 3/3] clang: don't define nocall

2020-05-29 Thread Roger Pau Monné
On Fri, May 29, 2020 at 08:25:44AM +0100, Julien Grall wrote: > Hi Roger, > > On 28/05/2020 15:40, Roger Pau Monne wrote: > > Clang doesn't support attribute error, and the possible equivalents > > like diagnose_if don't seem to work well in this case as they trigger > > when when the function is

Re: [PATCH v10 07/12] xen: provide version information in hypfs

2020-05-29 Thread Jan Beulich
On 19.05.2020 09:21, Juergen Gross wrote: > @@ -373,6 +374,52 @@ void __init do_initcalls(void) > (*call)(); > } > > +#ifdef CONFIG_HYPFS > +static unsigned int __read_mostly major_version; > +static unsigned int __read_mostly minor_version; > + > +static HYPFS_DIR_INIT(buildinfo, "buil

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Bertrand Marquis
Hi Jan > On 29 May 2020, at 08:35, Jan Beulich wrote: > > On 28.05.2020 20:54, Julien Grall wrote: >> On 28/05/2020 16:25, Bertrand Marquis wrote: >>> At the moment on Arm, a Linux guest running with KTPI enabled will >>> cause the following error when a context switch happens in user mode: >>>

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Jan Beulich
On 29.05.2020 10:32, Bertrand Marquis wrote: > So the only way to solve the KPTI issue would actually be to create a new > hypercall and keep the current bug/problem ? That's my view on it at least, yes. Jan

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Jan Beulich
On 29.05.2020 10:13, Bertrand Marquis wrote: >> On 28 May 2020, at 19:54, Julien Grall wrote: >> AFAICT, there is no restriction on when the runstate hypercall can be >> called. So this can even be called before the vCPU is brought up. > > I understand the remark but it still feels very weird to

Re: [Xen-devel] [RFC 1/9] schedule: Introduce per-pcpu time accounting

2020-05-29 Thread Dario Faggioli
On Tue, 2020-05-26 at 02:27 +, Volodymyr Babchuk wrote: > Hello All, > Hello Volodymyr, > This is gentle reminder about this RFC. > > Sadly, Andrii Anisov has left our team. But I'm commited to continue > his work on time accounting and real time scheduling. > Ok, so, first of all, sorry t

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread Jan Beulich
On 27.05.2020 18:08, George Dunlap wrote: >> On May 27, 2020, at 4:41 PM, Ian Jackson wrote: >> 2. Xen should disable the XSM policy build when FLASK is disabled. >> This is unfortunately not so simple because the XSM policy build is a >> tools option and FLASK is a Xen option and the configuratio

[linux-linus test] 150432: tolerable trouble: fail/pass/starved - PUSHED

2020-05-29 Thread osstest service owner
flight 150432 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/150432/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 150390 test-amd64-amd64-xl-qemuu-win7-amd64

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread Jan Beulich
On 27.05.2020 18:08, George Dunlap wrote: >> On May 27, 2020, at 4:41 PM, Ian Jackson wrote: >> >> The Xen tools build system builds a FLASK policy by default. It does >> this even if the hypervisor build for XSM is disabled. >> >> I recently sent patches upstream to grub to support XSM in >> upd

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Bertrand Marquis
Hi Jan, > On 29 May 2020, at 09:45, Jan Beulich wrote: > > On 29.05.2020 10:13, Bertrand Marquis wrote: >>> On 28 May 2020, at 19:54, Julien Grall wrote: >>> AFAICT, there is no restriction on when the runstate hypercall can be >>> called. So this can even be called before the vCPU is brought

Re: [PATCH v10 07/12] xen: provide version information in hypfs

2020-05-29 Thread Jürgen Groß
On 29.05.20 10:34, Jan Beulich wrote: On 19.05.2020 09:21, Juergen Gross wrote: @@ -373,6 +374,52 @@ void __init do_initcalls(void) (*call)(); } +#ifdef CONFIG_HYPFS +static unsigned int __read_mostly major_version; +static unsigned int __read_mostly minor_version; + +static HYPF

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Roger Pau Monné
On Fri, May 29, 2020 at 09:18:42AM +, Bertrand Marquis wrote: > Hi Jan, > > > On 29 May 2020, at 09:45, Jan Beulich wrote: > > > > On 29.05.2020 10:13, Bertrand Marquis wrote: > >>> On 28 May 2020, at 19:54, Julien Grall wrote: > >>> AFAICT, there is no restriction on when the runstate hype

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Jan Beulich
On 29.05.2020 11:18, Bertrand Marquis wrote: > Hi Jan, > >> On 29 May 2020, at 09:45, Jan Beulich wrote: >> >> On 29.05.2020 10:13, Bertrand Marquis wrote: On 28 May 2020, at 19:54, Julien Grall wrote: AFAICT, there is no restriction on when the runstate hypercall can be called.

[xen-unstable-smoke test] 150465: regressions - trouble: blocked/fail

2020-05-29 Thread osstest service owner
flight 150465 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150465/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 150438 build-amd64

[PATCH] xsm: also panic upon "flask=enforcing" when XSM_FLASK=n

2020-05-29 Thread Jan Beulich
While the behavior to ignore this option without FLASK support was properly documented, it is still somewhat surprising to someone using this option and then still _not_ getting the assumed security. Add a 2nd handler for the command line option for the XSM_FLASK=n case, and invoke panic() when the

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Julien Grall
Hi Bertrand, On 29/05/2020 09:13, Bertrand Marquis wrote: Hi Julien, On 28 May 2020, at 19:54, Julien Grall wrote: Hi Bertrand, Thank you for the patch. On 28/05/2020 16:25, Bertrand Marquis wrote: At the moment on Arm, a Linux guest running with KTPI enabled will cause the following erro

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Hongyan Xia
On Fri, 2020-05-29 at 08:13 +, Bertrand Marquis wrote: > Hi Julien, > > > On 28 May 2020, at 19:54, Julien Grall wrote: > > > > Hi Bertrand, > > > > Thank you for the patch. > > > > On 28/05/2020 16:25, Bertrand Marquis wrote: > > > At the moment on Arm, a Linux guest running with KTPI ena

Re: [PATCH v10 07/12] xen: provide version information in hypfs

2020-05-29 Thread Jan Beulich
On 29.05.2020 11:19, Jürgen Groß wrote: > On 29.05.20 10:34, Jan Beulich wrote: >> On 19.05.2020 09:21, Juergen Gross wrote: >>> @@ -373,6 +374,52 @@ void __init do_initcalls(void) >>> (*call)(); >>> } >>> >>> +#ifdef CONFIG_HYPFS >>> +static unsigned int __read_mostly major_version;

Re: [PATCH v8 2/8] block: consolidate blocksize properties consistency checks

2020-05-29 Thread Markus Armbruster
Roman Kagan writes: > Several block device properties related to blocksize configuration must > be in certain relationship WRT each other: physical block must be no > smaller than logical block; min_io_size, opt_io_size, and > discard_granularity must be a multiple of a logical block. > > To ensu

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread George Dunlap
> On May 29, 2020, at 9:52 AM, Jan Beulich wrote: > > On 27.05.2020 18:08, George Dunlap wrote: >>> On May 27, 2020, at 4:41 PM, Ian Jackson wrote: >>> 2. Xen should disable the XSM policy build when FLASK is disabled. >>> This is unfortunately not so simple because the XSM policy build is a >

Re: [PATCH v10 07/12] xen: provide version information in hypfs

2020-05-29 Thread Jürgen Groß
On 29.05.20 11:53, Jan Beulich wrote: On 29.05.2020 11:19, Jürgen Groß wrote: On 29.05.20 10:34, Jan Beulich wrote: On 19.05.2020 09:21, Juergen Gross wrote: @@ -373,6 +374,52 @@ void __init do_initcalls(void) (*call)(); } +#ifdef CONFIG_HYPFS +static unsigned int __read_mos

Re: [PATCH 2/2] xen: credit2: limit the max number of CPUs in a runqueue

2020-05-29 Thread Jan Beulich
On 28.05.2020 16:55, Dario Faggioli wrote: > On Wed, 2020-05-27 at 08:17 +0200, Jan Beulich wrote: >> On 27.05.2020 00:00, Dario Faggioli wrote: >>> Just in case, is there a >>> way to identify them easily, like with a mask or something, in the >>> code >>> already? >> >> cpu_sibling_mask still get

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread Jan Beulich
On 29.05.2020 11:55, George Dunlap wrote: > > >> On May 29, 2020, at 9:52 AM, Jan Beulich wrote: >> >> On 27.05.2020 18:08, George Dunlap wrote: On May 27, 2020, at 4:41 PM, Ian Jackson wrote: 2. Xen should disable the XSM policy build when FLASK is disabled. This is unfortunatel

Re: [PATCH] xsm: also panic upon "flask=enforcing" when XSM_FLASK=n

2020-05-29 Thread Andrew Cooper
On 29/05/2020 10:34, Jan Beulich wrote: > While the behavior to ignore this option without FLASK support was > properly documented, it is still somewhat surprising to someone using > this option and then still _not_ getting the assumed security. Add a > 2nd handler for the command line option for t

Re: [PATCH 2/2] xen: credit2: limit the max number of CPUs in a runqueue

2020-05-29 Thread Dario Faggioli
On Fri, 2020-05-29 at 11:58 +0200, Jan Beulich wrote: > On 28.05.2020 16:55, Dario Faggioli wrote: > > > > Which means I will be treating HTs and CUs the same which, thinking > > more about it (and thinking actually to CUs, rather than to any > > cache > > sharing relationship), does make sense fo

Re: [PATCH 0/3] Automation: improve openSUSE containers + podman

2020-05-29 Thread Dario Faggioli
On Thu, 2020-05-21 at 09:43 +0200, Dario Faggioli wrote: > On Thu, 2020-04-30 at 20:27 +0200, Dario Faggioli wrote: > > Hello, > > > > This short series contains some improvements for building Xen in > > openSUSE containers. In fact, the build dependencies inside the > > Tumbleweed container are u

Re: [PATCH] xsm: also panic upon "flask=enforcing" when XSM_FLASK=n

2020-05-29 Thread Jan Beulich
On 29.05.2020 12:07, Andrew Cooper wrote: > On 29/05/2020 10:34, Jan Beulich wrote: >> While the behavior to ignore this option without FLASK support was >> properly documented, it is still somewhat surprising to someone using >> this option and then still _not_ getting the assumed security. Add a

[PATCH] tools: fix Rules.mk library make variables

2020-05-29 Thread Juergen Gross
Both SHDEPS_libxendevicemodel and SHDEPS_libxenhypfs have a bug by adding $(SHLIB_xencall) instead of $(SHLIB_libxencall). The former seems not to have any negative impact, probably because it is not used anywhere in Xen without the correct $(SHLIB_libxencall) being used, too. Fixes: 86234eafb952

Re: [PATCH] xsm: also panic upon "flask=enforcing" when XSM_FLASK=n

2020-05-29 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH] xsm: also panic upon "flask=enforcing" when XSM_FLASK=n"): > On 29/05/2020 10:34, Jan Beulich wrote: > > While the behavior to ignore this option without FLASK support was > > properly documented, it is still somewhat surprising to someone using > > this option a

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread Ian Jackson
George Dunlap writes ("Re: Xen XSM/FLASK policy, grub defaults, etc."): > > On May 27, 2020, at 4:41 PM, Ian Jackson wrote: > > 3. Failing that, Xen should provide some other mechanism which would > > enable something like update-grub to determine whether a particular > > hypervisor can sensibly b

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread Ian Jackson
Ian Jackson writes ("Re: Xen XSM/FLASK policy, grub defaults, etc."): > George Dunlap writes ("Re: Xen XSM/FLASK policy, grub defaults, etc."): > > > On May 27, 2020, at 4:41 PM, Ian Jackson wrote: > > > 3. Failing that, Xen should provide some other mechanism which would > > > enable something li

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Julien Grall
Hi, On 29/05/2020 10:18, Bertrand Marquis wrote: On 29 May 2020, at 09:45, Jan Beulich wrote: On 29.05.2020 10:13, Bertrand Marquis wrote: On 28 May 2020, at 19:54, Julien Grall wrote: AFAICT, there is no restriction on when the runstate hypercall can be called. So this can even be called b

Re: [PATCH] xsm: also panic upon "flask=enforcing" when XSM_FLASK=n

2020-05-29 Thread George Dunlap
> On May 29, 2020, at 11:39 AM, Ian Jackson wrote: > > Andrew Cooper writes ("Re: [PATCH] xsm: also panic upon "flask=enforcing" > when XSM_FLASK=n"): >> On 29/05/2020 10:34, Jan Beulich wrote: >>> While the behavior to ignore this option without FLASK support was >>> properly documented, it is

Re: [PATCH v8 2/8] block: consolidate blocksize properties consistency checks

2020-05-29 Thread Roman Kagan
On Fri, May 29, 2020 at 11:53:26AM +0200, Markus Armbruster wrote: > Roman Kagan writes: > > > Several block device properties related to blocksize configuration must > > be in certain relationship WRT each other: physical block must be no > > smaller than logical block; min_io_size, opt_io_size,

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread George Dunlap
> On May 29, 2020, at 11:50 AM, Ian Jackson wrote: > > George Dunlap writes ("Re: Xen XSM/FLASK policy, grub defaults, etc."): >>> On May 27, 2020, at 4:41 PM, Ian Jackson wrote: >>> 3. Failing that, Xen should provide some other mechanism which would >>> enable something like update-grub to d

[xen-unstable-smoke test] 150469: regressions - trouble: blocked/fail

2020-05-29 Thread osstest service owner
flight 150469 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150469/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 150438 build-amd64

Re: [RFC PATCH 1/1] xen: Use a global mapping for runstate

2020-05-29 Thread Julien Grall
Hi Jan, On 29/05/2020 08:35, Jan Beulich wrote: On 28.05.2020 20:54, Julien Grall wrote: On 28/05/2020 16:25, Bertrand Marquis wrote: At the moment on Arm, a Linux guest running with KTPI enabled will cause the following error when a context switch happens in user mode: (XEN) p2m.c:1890: d1v0:

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread Jan Beulich
On 29.05.2020 12:50, Ian Jackson wrote: > George Dunlap writes ("Re: Xen XSM/FLASK policy, grub defaults, etc."): >>> On May 27, 2020, at 4:41 PM, Ian Jackson wrote: >>> 3. Failing that, Xen should provide some other mechanism which would >>> enable something like update-grub to determine whether

[PATCH v7 02/15] x86/mm: make sure there is one exit path for modify_xen_mappings

2020-05-29 Thread Hongyan Xia
From: Wei Liu We will soon need to handle dynamically mapping / unmapping page tables in the said function. Since dynamic mappings may map and unmap pl3e in different iterations, lift pl3e out of the loop. No functional change. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed si

[PATCH v7 09/15] efi: use new page table APIs in copy_mapping

2020-05-29 Thread Hongyan Xia
From: Wei Liu After inspection ARM doesn't have alloc_xen_pagetable so this function is x86 only, which means it is safe for us to change. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v7: - hoist l3 variables out of the loop to avoid repetitive mappings. --- xen/common/ef

[PATCH v7 04/15] x86/mm: switch to new APIs in map_pages_to_xen

2020-05-29 Thread Hongyan Xia
From: Wei Liu Page tables allocated in that function should be mapped and unmapped now. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- xen/arch/x86/mm.c | 60 --- 1 file changed, 36 insertions(+), 24 deletions(-) diff --git a/xen/arch/x86/mm

[PATCH v7 00/15] switch to domheap for Xen page tables

2020-05-29 Thread Hongyan Xia
From: Hongyan Xia This series rewrites all the remaining functions and finally makes the switch from xenheap to domheap for Xen page tables, so that they no longer need to rely on the direct map, which is a big step towards removing the direct map. This series depends on the following mini-serie

[PATCH v7 07/15] x86_64/mm: switch to new APIs in paging_init

2020-05-29 Thread Hongyan Xia
From: Wei Liu Map and unmap pages instead of relying on the direct map. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v7: - use the new alloc_map_clear_xen_pt() helper. - move the unmap of pl3t up a bit. - remove the unmaps in the nomem path. --- xen/arch/x86/x86_64/mm.c |

[PATCH v7 01/15] x86/mm: map_pages_to_xen would better have one exit path

2020-05-29 Thread Hongyan Xia
From: Wei Liu We will soon rewrite the function to handle dynamically mapping and unmapping of page tables. Since dynamic mappings may map and unmap pages in different iterations of the while loop, we need to lift pl3e out of the loop. No functional change. Signed-off-by: Wei Liu Signed-off-by

[PATCH v7 08/15] x86_64/mm: switch to new APIs in setup_m2p_table

2020-05-29 Thread Hongyan Xia
From: Wei Liu Avoid repetitive mapping of l2_ro_mpt by keeping it across loops, and only unmap and map it when crossing 1G boundaries. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v7: - avoid repetitive mapping of l2_ro_mpt. - edit commit message. - switch to alloc_map_cle

[PATCH v7 06/15] x86_64/mm: introduce pl2e in paging_init

2020-05-29 Thread Hongyan Xia
From: Wei Liu We will soon map and unmap pages in paging_init(). Introduce pl2e so that we can use l2_ro_mpt to point to the page table itself. No functional change. Signed-off-by: Wei Liu --- Changed in v7: - reword commit message. --- xen/arch/x86/x86_64/mm.c | 16 +--- 1 file

[PATCH v7 03/15] x86/mm: rewrite virt_to_xen_l*e

2020-05-29 Thread Hongyan Xia
From: Wei Liu Rewrite those functions to use the new APIs. Modify its callers to unmap the pointer returned. Since alloc_xen_pagetable_new() is almost never useful unless accompanied by page clearing and a mapping, introduce a helper alloc_map_clear_xen_pt() for this sequence. Note that the chan

[PATCH v7 05/15] x86/mm: switch to new APIs in modify_xen_mappings

2020-05-29 Thread Hongyan Xia
From: Wei Liu Page tables allocated in that function should be mapped and unmapped now. Note that pl2e now maybe mapped and unmapped in different iterations, so we need to add clean-ups for that. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v7: - use normal unmap in the e

[OSSTEST PATCH 01/49] ts-logs-capture: Cope if xl shutdown leaves domain running for a bit

2020-05-29 Thread Ian Jackson
This seems mostly to affect buster but it could in principle affect earlier releases too I think. In principle it would be nice to fix this bug, and to have a proper test for it, but a reliable test is hard and an unreliable one is not useful. So I guess we are going to have this workaround indef

[OSSTEST PATCH 07/49] setupboot_grub2: Drop $submenu variable

2020-05-29 Thread Ian Jackson
We really only used this to check how many levels deep in { we are. That can be done by checking $#offsets, which is >0 if we are in a submenu and not otherwise. We lose the ability to report the start line of the submenu, but that's OK. But as a bonus, we no longer bomb out on nested submenus: p

[OSSTEST PATCH v2 00/49] Switch to Debian buster (= Debian stable)

2020-05-29 Thread Ian Jackson
This series looks about as ready as it is going to be. Unfortunately there are still two issues, each of which cropped up once in my final formal retest. See below. What are people's opinions? Should I push this to osstest pretest soon after the Xen codefreeze (eg, after we get the first push a

[OSSTEST PATCH 04/49] TestSupport: allow more time for apt

2020-05-29 Thread Ian Jackson
Empirically some of these operations can take longer than 30s, especially with a cold cache. Note that because of host sharing and our on-host apt lock, the timeout needs to be the same for every apt operation: a fast operation could be blocked behind a slow one. Signed-off-by: Ian Jackson ---

[OSSTEST PATCH 09/49] Bodge systemd random seed arrangements

2020-05-29 Thread Ian Jackson
systemd does not regard the contents of the random seed file as useful for the purposes of placating the kernel's entropy tracker. As a result, the system hangs at boot waiting for entropy. Fix this by providing a small program which can be used to load a seed file into /dev/random and also call

[OSSTEST PATCH 05/49] Booting: Use `--' rather than `---' to introduce host cmdline

2020-05-29 Thread Ian Jackson
Because systemd did something obnoxious, the kernel retaliated in the game of Core Wars by hiding all arguments before `--' from userspace. So use `---' instead so that all the arguments remain visible. This in some sense now applies to host installs a change we had already made to Debian HVM gues

[OSSTEST PATCH 03/49] lvcreate argments: pass --yes -Z y -W y

2020-05-29 Thread Ian Jackson
The documentation seesm to think this is the default but empirically it isn't. In our environment --yes is fine. I have reported this to Debian as #953183. Also vaguely related (and discovered by me at the same time) is #953185. This came up while trying to get things work on buster. I don't k

[OSSTEST PATCH 02/49] ts-xen-build-prep: Install rsync

2020-05-29 Thread Ian Jackson
osstest uses this for transferring configuration, build artefacts, and so on. In Debian stretch and earlier, rsync happened to be pulled in by something else. Signed-off-by: Ian Jackson --- ts-xen-build-prep | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-xen-build-prep b

[OSSTEST PATCH 08/49] ts-leak-check: Ignore buster's udevd too

2020-05-29 Thread Ian Jackson
For reasons I don't propose to investigate, on buster udevd shows up like this: 2019-11-26 18:13:48 Z LEAKED [process 2633 /lib/systemd/systemd-udevd] process: root 2633 1555 0 18:10 ?00:00:00 /lib/systemd/systemd-udevd This does not match our suppression. Add an additional su

[OSSTEST PATCH 06/49] di_installcmdline_core: Pass locale on d-i command line

2020-05-29 Thread Ian Jackson
In buster, d-i wants when setting up the network, ie before the preseed is loaded. We leave it in the preseed too because why not. I think this change should be fine for older versions of Debian. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 3 ++- 1 file changed, 2 insertions(+), 1 delet

Re: Xen XSM/FLASK policy, grub defaults, etc.

2020-05-29 Thread George Dunlap
> On May 29, 2020, at 12:02 PM, Jan Beulich wrote: > > On 29.05.2020 12:50, Ian Jackson wrote: >> George Dunlap writes ("Re: Xen XSM/FLASK policy, grub defaults, etc."): On May 27, 2020, at 4:41 PM, Ian Jackson wrote: 3. Failing that, Xen should provide some other mechanism which wou

[PATCH v7 12/15] x86/smpboot: switch clone_mapping() to new APIs

2020-05-29 Thread Hongyan Xia
From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v7: - change patch title - remove initialiser of pl3e. - combine the initialisation of pl3e into a single assignment. - use the new alloc_map_clear() helper. - use the normal map_domain_page() in the error path. ---

[PATCH v7 14/15] x86: switch to use domheap page for page tables

2020-05-29 Thread Hongyan Xia
From: Hongyan Xia Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- xen/arch/x86/mm.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 38cfa3ce25..16f1aa3344 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -4

[PATCH v7 13/15] x86/mm: drop old page table APIs

2020-05-29 Thread Hongyan Xia
From: Hongyan Xia Two sets of old APIs, alloc/free_xen_pagetable() and lXe_to_lYe(), are now dropped to avoid the dependency on direct map. There are two special cases which still have not been re-written into the new APIs, thus need special treatment: rpt in smpboot.c cannot use ephemeral mapp

[PATCH v7 10/15] efi: switch to new APIs in EFI code

2020-05-29 Thread Hongyan Xia
From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v7: - add blank line after declaration. - rename efi_l4_pgtable into efi_l4t. - pass the mapped efi_l4t to copy_mapping() instead of map it again. - use the alloc_map_clear_xen_pt() API. - unmap pl3e, pl2e, l1t earl

RE: [OSSTEST PATCH v2 00/49] Switch to Debian buster (= Debian stable)

2020-05-29 Thread Paul Durrant
> -Original Message- > From: Ian Jackson > Sent: 29 May 2020 12:19 > To: xen-devel@lists.xenproject.org; Paul Durrant > Cc: Ian Jackson ; committ...@xenproject.org > Subject: [OSSTEST PATCH v2 00/49] Switch to Debian buster (= Debian stable) > > This series looks about as ready as it is

[PATCH v7 15/15] x86/mm: drop _new suffix for page table APIs

2020-05-29 Thread Hongyan Xia
From: Wei Liu No functional change. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia Acked-by: Jan Beulich --- xen/arch/x86/mm.c| 44 xen/arch/x86/smpboot.c | 6 +++--- xen/arch/x86/x86_64/mm.c | 2 +- xen/include/asm-x86/mm.h | 4 ++--

[PATCH v7 11/15] x86/smpboot: add exit path for clone_mapping()

2020-05-29 Thread Hongyan Xia
From: Wei Liu We will soon need to clean up page table mappings in the exit path. No functional change. Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia --- Changed in v7: - edit commit message. - begin with rc = 0 and set it to -ENOMEM ahead of if(). --- xen/arch/x86/smpboot.c | 16 ++

[BOOTLOADER SPECIFICATION RFC] The bootloader log format for TrenchBoot and others

2020-05-29 Thread Daniel Kiper
Hey, Below you can find my rough idea of the bootloader log format which is generic thing but initially will be used for TrenchBoot work. I discussed this proposal with Ross and Daniel S. So, the idea went through initial sanitization. Now I would like to take feedback from other folks too. So, pl

[OSSTEST PATCH 27/49] 20_linux_xen: Ignore xenpolicy and config files too

2020-05-29 Thread Ian Jackson
"file_is_not_sym" currently only checks for xen-syms. Extend it to disregard xenpolicy (XSM policy files) and files ending .config (which are built by the Xen upstream build system in some configurations and can therefore end up in /boot). Rename the function accordingly, to "file_is_not_xen_garb

[OSSTEST PATCH 26/49] 20_linux_xen: Adhoc template substitution

2020-05-29 Thread Ian Jackson
This file is a template that various build-time variables get substituted into. Make thos substitutions by hand (actually, by copying the values our file for stretch). And rename the file. So now we are using our file instead of the grub package's. But it is the same... Signed-off-by: Ian Jack

[OSSTEST PATCH 36/49] buster: setupboot_grub2: Handle missing policy file bug

2020-05-29 Thread Ian Jackson
This is a complex interaction between update-grub and the Xen build system on ARM64. Not sure exactly who to blame but since we have our own 20_linux_xen bodge, let's wait until we don't. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 12 +++- 1 file changed, 11 insertions(+), 1 del

[OSSTEST PATCH 44/49] setupboot_grub2: Print line number of entry we are using

2020-05-29 Thread Ian Jackson
Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index a20569e5..615047cb 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -562,7 +562,7 @@ sub setupboot_grub2 () { di

[OSSTEST PATCH 25/49] 20_linux_xen: Copy Debian buster version into our initramfs area

2020-05-29 Thread Ian Jackson
This is from 41e42571ebc50fa351cd63ce40044946652c5c72 in Debian's grub package. We are going to want to modify this to support XSM/FLASK and cope with upstream build outputs. In this commit we dump the exact file contents across. It's not effective right now because of the ".in" extension. In f

[OSSTEST PATCH 39/49] ts-xen-install: Move some_extradebs to Debian.pm

2020-05-29 Thread Ian Jackson
Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 38 ++ ts-xen-install| 36 2 files changed, 38 insertions(+), 36 deletions(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 49d94b9b..d51ac493 100644 --- a/O

[OSSTEST PATCH 20/49] buster: ts-host-install: NTP not honoured bug remains

2020-05-29 Thread Ian Jackson
Debian #778564 remains open. Signed-off-by: Ian Jackson --- ts-host-install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-host-install b/ts-host-install index fe26f70f..253dbb5d 100755 --- a/ts-host-install +++ b/ts-host-install @@ -152,7 +152,7 @@ END my $do

[OSSTEST PATCH 32/49] buster: chiark-scripts: Install a new version on buster too

2020-05-29 Thread Ian Jackson
We need various fixes that are not in buster, sadly. Signed-off-by: Ian Jackson --- production-config | 1 + 1 file changed, 1 insertion(+) diff --git a/production-config b/production-config index f0ddc132..e3870d47 100644 --- a/production-config +++ b/production-config @@ -107,6 +107,7 @@ Tftp

[OSSTEST PATCH 30/49] overlay-initrd-buster/sbin/reopen-console: Copy from Debian

2020-05-29 Thread Ian Jackson
We are going to patch this file to work around a bug, using the new overlay mechanism. The first step is to include the file in our overlay so we overwrite it. Currently, this is a no-op, so no functional change. Signed-off-by: Ian Jackson --- overlay-initrd-buster/sbin/reopen-console | 94 +++

[OSSTEST PATCH 35/49] buster: setupboot_grub2: Note what files exist in /boot

2020-05-29 Thread Ian Jackson
Nothing uses this yet. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 9f1ce1df..0386ff7a 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -448,6 +448,11 @@ sub setupboot_grub2 () {

[OSSTEST PATCH 37/49] buster: Extend workaround for dhcpd EROFS bug

2020-05-29 Thread Ian Jackson
Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 51217fb4..49d94b9b 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -1624,7 +1624,7 @@ sub debian_dhcp_rofs_fix ($$) { # /

[OSSTEST PATCH 21/49] buster: Extend ARM clock workaround

2020-05-29 Thread Ian Jackson
CC: Julien Grall CC: Stefano Stabellini Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index bac33d00..71167351 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -248,7 +248,7 @@

[OSSTEST PATCH 24/49] buster: Specify DebianImageFile_SUITE_ARCH

2020-05-29 Thread Ian Jackson
Signed-off-by: Ian Jackson --- production-config | 3 +++ 1 file changed, 3 insertions(+) diff --git a/production-config b/production-config index 103b8915..f0ddc132 100644 --- a/production-config +++ b/production-config @@ -98,6 +98,9 @@ DebianSnapshotBackports_jessie http://snapshot.debian.or

[OSSTEST PATCH 23/49] Honour DebianImageFile_SUITE_ARCH

2020-05-29 Thread Ian Jackson
This lets us specify the whole filename, not just a version. This is needed because for buster we are going to use debian-10.2.0-ARCH-xfce-CD-1.iso Signed-off-by: Ian Jackson --- mfi-common | 9 + 1 file changed, 9 insertions(+) diff --git a/mfi-common b/mfi-common index b40f057e..64

[OSSTEST PATCH 38/49] ts-xen-install: Add $ho argument to some_extradebs

2020-05-29 Thread Ian Jackson
This is going to move to Debian.pm. Signed-off-by: Ian Jackson --- ts-xen-install | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ts-xen-install b/ts-xen-install index 08b4ea23..6196a890 100755 --- a/ts-xen-install +++ b/ts-xen-install @@ -71,8 +71,8 @@ sub packages (

[OSSTEST PATCH 33/49] buster: Provide TftpDiVersion

2020-05-29 Thread Ian Jackson
Signed-off-by: Ian Jackson --- production-config | 1 + 1 file changed, 1 insertion(+) diff --git a/production-config b/production-config index e3870d47..6372ac9a 100644 --- a/production-config +++ b/production-config @@ -91,6 +91,7 @@ TftpNetbootGroup osstest TftpDiVersion_wheezy 2016-06-08 T

[OSSTEST PATCH 15/49] buster: make-hosts-flight: Add to possible suites for hosts flight

2020-05-29 Thread Ian Jackson
Signed-off-by: Ian Jackson --- make-hosts-flight | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/make-hosts-flight b/make-hosts-flight index 92da1c7c..e2c3776a 100755 --- a/make-hosts-flight +++ b/make-hosts-flight @@ -26,7 +26,7 @@ blessing=$4 buildflight=$5 : ${ALL_ARCHE

[OSSTEST PATCH 17/49] buster: ts-host-install: Extend net.ifnames workaround

2020-05-29 Thread Ian Jackson
Really we should fix this by making a .deb in Debian that we could install. But this is a longer-term project. Signed-off-by: Ian Jackson --- ts-host-install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-host-install b/ts-host-install index 7a72a867..fe26f70f 100755 ---

  1   2   3   >