Re: [PATCH 1/1] xen/manage: enable C_A_D to force reboot

2020-05-15 Thread Jürgen Groß
On 14.05.20 01:34, Dongli Zhang wrote: The systemd may be configured to mask ctrl-alt-del via "systemctl mask ctrl-alt-del.target". As a result, the pv reboot would not work as signal is ignored. This patch always enables C_A_D before the call of ctrl_alt_del() in order to force the reboot. Hm

Cut-off date for Xen 4.14 is May 22nd

2020-05-15 Thread Paul Durrant
*** ONE WEEK TO GO *** Hi all, The cut-off date for Xen 4.14 is Friday May 22nd. If you want your features to be included for the release, please make sure they are committed by that date. Paul Durrant

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Bertrand Marquis
On 14 May 2020, at 20:13, Julien Grall mailto:julien.grall@gmail.com>> wrote: On Thu, 14 May 2020 at 19:12, Andrew Cooper mailto:andrew.coop...@citrix.com>> wrote: On 14/05/2020 18:38, Julien Grall wrote: Hi, On 14/05/2020 17:18, Bertrand Marquis wrote: On 14 May 2020, at 16:57, Julien

Re: [PATCH] x86: retrieve and log CPU frequency information

2020-05-15 Thread Roger Pau Monné
On Wed, Apr 15, 2020 at 01:55:24PM +0200, Jan Beulich wrote: > While from just a single Skylake system it is already clear that we > can't base any of our logic on CPUID leaf 15 [1] (leaf 16 is > documented to be used for display purposes only anyway), logging this > information may still give us s

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Roger Pau Monné
On Fri, May 15, 2020 at 07:39:16AM +, Bertrand Marquis wrote: > > > On 14 May 2020, at 20:13, Julien Grall > mailto:julien.grall@gmail.com>> wrote: > > On Thu, 14 May 2020 at 19:12, Andrew Cooper > mailto:andrew.coop...@citrix.com>> wrote: > > On 14/05/2020 18:38, Julien Grall wrote:

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Julien Grall
Hi, On 15/05/2020 09:38, Roger Pau Monné wrote: On Fri, May 15, 2020 at 07:39:16AM +, Bertrand Marquis wrote: On 14 May 2020, at 20:13, Julien Grall mailto:julien.grall@gmail.com>> wrote: On Thu, 14 May 2020 at 19:12, Andrew Cooper mailto:andrew.coop...@citrix.com>> wrote: On 14/0

Re: [PATCH] x86: retrieve and log CPU frequency information

2020-05-15 Thread Jan Beulich
On 15.05.2020 10:32, Roger Pau Monné wrote: > On Wed, Apr 15, 2020 at 01:55:24PM +0200, Jan Beulich wrote: >> While from just a single Skylake system it is already clear that we >> can't base any of our logic on CPUID leaf 15 [1] (leaf 16 is >> documented to be used for display purposes only anyway

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Roger Pau Monné
On Fri, May 15, 2020 at 09:53:54AM +0100, Julien Grall wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > Hi, > > On 15/05/2020 09:38, Roger Pau Monné wrote: > > On Fri, May 15, 2020 at 07:39:

Re: [PATCH] x86: retrieve and log CPU frequency information

2020-05-15 Thread Roger Pau Monné
On Fri, May 15, 2020 at 11:08:04AM +0200, Jan Beulich wrote: > On 15.05.2020 10:32, Roger Pau Monné wrote: > > On Wed, Apr 15, 2020 at 01:55:24PM +0200, Jan Beulich wrote: > >> While from just a single Skylake system it is already clear that we > >> can't base any of our logic on CPUID leaf 15 [1]

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Bertrand Marquis
On 15 May 2020, at 10:10, Roger Pau Monné mailto:roger@citrix.com>> wrote: On Fri, May 15, 2020 at 09:53:54AM +0100, Julien Grall wrote: [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe. Hi, On 15/0

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Julien Grall
On 15/05/2020 10:10, Roger Pau Monné wrote: On Fri, May 15, 2020 at 09:53:54AM +0100, Julien Grall wrote: [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe. Hi, On 15/05/2020 09:38, Roger Pau Monné wro

Re: [PATCH v8 04/12] xen: add basic hypervisor filesystem support

2020-05-15 Thread Jan Beulich
On 15.05.2020 07:33, Jürgen Groß wrote: > On 14.05.20 11:50, Jürgen Groß wrote: >> On 14.05.20 09:59, Jan Beulich wrote: >>> On 08.05.2020 17:34, Juergen Gross wrote: +int hypfs_read_dir(const struct hypfs_entry *entry, +   XEN_GUEST_HANDLE_PARAM(void) uaddr) +{

Re: [PATCH v2 4/6] x86/mem-paging: add minimal lock order enforcement to p2m_mem_paging_prep()

2020-05-15 Thread Jan Beulich
On 14.05.2020 18:25, Roger Pau Monné wrote: > On Thu, Apr 23, 2020 at 10:38:44AM +0200, Jan Beulich wrote: >> While full checking is impossible (as the lock is being acquired/ >> released down the call tree), perform at least a lock level check. > > I'm slightly confused, doesn't alloc_domheap_pag

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Roger Pau Monné
On Fri, May 15, 2020 at 10:23:16AM +0100, Julien Grall wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > > On 15/05/2020 10:10, Roger Pau Monné wrote: > > On Fri, May 15, 2020 at 09:53:54AM +

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Julien Grall
Hi Bertrand, On 15/05/2020 10:21, Bertrand Marquis wrote: On 15 May 2020, at 10:10, Roger Pau Monné > wrote: On Fri, May 15, 2020 at 09:53:54AM +0100, Julien Grall wrote: [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have v

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Roger Pau Monné
Can you please fix your email client to properly indent replies? It's impossible to distinguish your added text when you reply from the original email, as it's not indented in any way. On Fri, May 15, 2020 at 09:21:34AM +, Bertrand Marquis wrote: > On 15 May 2020, at 10:10, Roger Pau Monné >

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Julien Grall
Hi, On 15/05/2020 10:57, Roger Pau Monné wrote: On Fri, May 15, 2020 at 10:23:16AM +0100, Julien Grall wrote: [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe. On 15/05/2020 10:10, Roger Pau Monné wrote

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Bertrand Marquis
> On 15 May 2020, at 11:00, Julien Grall wrote: > > Hi Bertrand, > > On 15/05/2020 10:21, Bertrand Marquis wrote: >>> On 15 May 2020, at 10:10, Roger Pau Monné >> > wrote: >>> >>> On Fri, May 15, 2020 at 09:53:54AM +0100, Julien Grall wrote: [CAUTION - EXTERN

Re: [PATCH v2 4/6] x86/mem-paging: add minimal lock order enforcement to p2m_mem_paging_prep()

2020-05-15 Thread Roger Pau Monné
On Fri, May 15, 2020 at 11:46:23AM +0200, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 14.05.2020 18:25, Roger Pau Monné wrote: > > On Thu, Apr 23, 2020 at 10:38:44AM +0200

Items for CHANGELOG.md in 4.14

2020-05-15 Thread Paul Durrant
All, In the last community call I took an ACTION to send a reminder email to submit patches to get CHANGELOG.md up to date. Several items were mentioned during the call (see minutes at https://cryptpad.fr/pad/#/2/pad/edit/qPQUEQEv3nJJ97clS8b2KdtP/): - Ability to conditionally compile-out 32-b

[xen-unstable test] 150179: regressions - FAIL

2020-05-15 Thread osstest service owner
flight 150179 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/150179/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-vhd 10 debian-di-installfail REGR. vs. 150164 Tests which did no

[qemu-mainline test] 150185: regressions - FAIL

2020-05-15 Thread osstest service owner
flight 150185 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/150185/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm 7 xen-boot fail REGR. vs. 150151 build-arm64

[PATCH v9 02/12] xen: add a generic way to include binary files as variables

2020-05-15 Thread Juergen Gross
Add a new script xen/tools/binfile for including a binary file at build time being usable via a pointer and a size variable in the hypervisor. Make use of that generic tool in xsm. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Reviewed-by: Wei Liu --- V3: - new patch V4: - add alignme

[PATCH v9 08/12] xen: add /buildinfo/config entry to hypervisor filesystem

2020-05-15 Thread Juergen Gross
Add the /buildinfo/config entry to the hypervisor filesystem. This entry contains the .config file used to build the hypervisor. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V3: - store data in gzip format - use binfile mechanism to create data file - move code to kernel.c V6: - ad

[PATCH v9 01/12] xen/vmx: let opt_ept_ad always reflect the current setting

2020-05-15 Thread Juergen Gross
In case opt_ept_ad has not been set explicitly by the user via command line or runtime parameter, it is treated as "no" on Avoton cpus. Change that handling by setting opt_ept_ad to 0 for this cpu type explicitly if no user value has been set. By putting this into the (renamed) boot time initiali

[PATCH v9 07/12] xen: provide version information in hypfs

2020-05-15 Thread Juergen Gross
Provide version and compile information in /buildinfo/ node of the Xen hypervisor file system. As this information is accessible by dom0 only no additional security problem arises. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V3: - new patch V4: - add __read_mostly annotations (Jan

[PATCH v9 05/12] libs: add libxenhypfs

2020-05-15 Thread Juergen Gross
Add the new library libxenhypfs for access to the hypervisor filesystem. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- V1: - rename to libxenhypfs - add xenhypfs_write() V3: - major rework due to new hypervisor interface - add decompression capability V4: - add dependency to libz in pkgco

[PATCH v9 06/12] tools: add xenfs tool

2020-05-15 Thread Juergen Gross
Add the xenfs tool for accessing the hypervisor filesystem. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- V1: - rename to xenhypfs - don't use "--" for subcommands - add write support V2: - escape non-printable characters per default with cat subcommand (Ian Jackson) - add -b option to c

[PATCH v9 10/12] tools/libxl: use libxenhypfs for setting xen runtime parameters

2020-05-15 Thread Juergen Gross
Instead of xc_set_parameters() use xenhypfs_write() for setting parameters of the hypervisor. Signed-off-by: Juergen Gross --- V6: - new patch --- tools/Rules.mk | 2 +- tools/libxl/Makefile | 3 +- tools/libxl/libxl.c | 53 t

[PATCH v9 03/12] docs: add feature document for Xen hypervisor sysfs-like support

2020-05-15 Thread Juergen Gross
On the 2019 Xen developer summit there was agreement that the Xen hypervisor should gain support for a hierarchical name-value store similar to the Linux kernel's sysfs. In the beginning there should only be basic support: entries can be added from the hypervisor itself only, there is a simple hyp

[PATCH v9 11/12] tools/libxc: remove xc_set_parameters()

2020-05-15 Thread Juergen Gross
There is no user of xc_set_parameters() left, so remove it. Signed-off-by: Juergen Gross --- V6: - new patch --- tools/libxc/include/xenctrl.h | 1 - tools/libxc/xc_misc.c | 21 - 2 files changed, 22 deletions(-) diff --git a/tools/libxc/include/xenctrl.h b/tools/li

[PATCH v9 00/12] Add hypervisor sysfs-like support

2020-05-15 Thread Juergen Gross
On the 2019 Xen developer summit there was agreement that the Xen hypervisor should gain support for a hierarchical name-value store similar to the Linux kernel's sysfs. This is a first implementation of that idea adding the basic functionality to hypervisor and tools side. The interface to any us

[PATCH v9 04/12] xen: add basic hypervisor filesystem support

2020-05-15 Thread Juergen Gross
Add the infrastructure for the hypervisor filesystem. This includes the hypercall interface and the base functions for entry creation, deletion and modification. In order not to have to repeat the same pattern multiple times in case adding a new node should BUG_ON() failure, the helpers for addin

[PATCH v9 12/12] xen: remove XEN_SYSCTL_set_parameter support

2020-05-15 Thread Juergen Gross
The functionality of XEN_SYSCTL_set_parameter is available via hypfs now, so it can be removed. This allows to remove the kernel_param structure for runtime parameters by putting the now only used structure element into the hypfs node structure of the runtime parameters. Signed-off-by: Juergen Gr

[PATCH v9 09/12] xen: add runtime parameter access support to hypfs

2020-05-15 Thread Juergen Gross
Add support to read and modify values of hypervisor runtime parameters via the hypervisor file system. As runtime parameters can be modified via a sysctl, too, this path has to take the hypfs rw_lock as writer. For custom runtime parameters the connection between the parameter value and the file

Re: [PATCH v2 1/6] x86/mem-paging: fold p2m_mem_paging_prep()'s main if()-s

2020-05-15 Thread Andrew Cooper
On 23/04/2020 09:37, Jan Beulich wrote: > --- a/xen/arch/x86/mm/p2m.c > +++ b/xen/arch/x86/mm/p2m.c > @@ -1819,22 +1821,16 @@ int p2m_mem_paging_prep(struct domain *d > goto out; > mfn = page_to_mfn(page); > page_extant = 0; > -} > - > -/* If we were given a b

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Julien Grall
Hi, On 15/05/2020 11:10, Bertrand Marquis wrote: On 15 May 2020, at 11:00, Julien Grall wrote: Hi Bertrand, On 15/05/2020 10:21, Bertrand Marquis wrote: On 15 May 2020, at 10:10, Roger Pau Monné mailto:roger@citrix.com>> wrote: On Fri, May 15, 2020 at 09:53:54AM +0100, Julien Grall w

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Bertrand Marquis
Hi Roger > On 15 May 2020, at 11:07, Roger Pau Monné wrote: > > Can you please fix your email client to properly indent replies? It's > impossible to distinguish your added text when you reply from the > original email, as it's not indented in any way. Sorry for that it seems my email client is

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Bertrand Marquis
> On 15 May 2020, at 13:07, Julien Grall wrote: > > Hi, > > On 15/05/2020 11:10, Bertrand Marquis wrote: >>> On 15 May 2020, at 11:00, Julien Grall wrote: >>> >>> Hi Bertrand, >>> >>> On 15/05/2020 10:21, Bertrand Marquis wrote: > On 15 May 2020, at 10:10, Roger Pau Monné

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Roger Pau Monné
On Fri, May 15, 2020 at 12:34:08PM +, Bertrand Marquis wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > Hi Roger > > > On 15 May 2020, at 11:07, Roger Pau Monné wrote: > > > > Can you

[ovmf test] 150187: all pass - PUSHED

2020-05-15 Thread osstest service owner
flight 150187 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/150187/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf bcf181a33b2ea46c36c3be701a5b2e232deaece7 baseline version: ovmf f2cdb268ef04eeec51948

Re: [PATCH] x86/gen-cpuid: Distinguish default vs max in feature annotations

2020-05-15 Thread Andrew Cooper
On 11/05/2020 08:43, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 08.05.2020 17:27, Andrew Cooper wrote: >> @@ -133,9 +134,13 @@ def crunch_numbers(state): >> state.hvm

[libvirt test] 150190: regressions - FAIL

2020-05-15 Thread osstest service owner
flight 150190 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/150190/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 146182 build-i386-libvirt

[PATCH v3 0/2] x86/idle: fix for Intel ISR errata

2020-05-15 Thread Roger Pau Monne
Apply a workaround in order to cope with the BDX99, CLX30, SKX100, CFW125, BDF104, BDH85, BDM135, KWB131 erratas. Roger Pau Monne (2): x86/idle: rework C6 EOI workaround x86/idle: prevent entering C6 with in service interrupts on Intel docs/misc/xen-command-line.pandoc | 9 xen/arch/x8

[PATCH v3 1/2] x86/idle: rework C6 EOI workaround

2020-05-15 Thread Roger Pau Monne
Change the C6 EOI workaround (errata AAJ72) to use x86_match_cpu. Also call the workaround from mwait_idle, previously it was only used by the ACPI idle driver. Finally make sure the routine is called for all states equal or greater than ACPI_STATE_C3, note that the ACPI driver doesn't currently ha

[PATCH v3 2/2] x86/idle: prevent entering C6 with in service interrupts on Intel

2020-05-15 Thread Roger Pau Monne
Apply a workaround for Intel errata BDX99, CLX30, SKX100, CFW125, BDF104, BDH85, BDM135, KWB131: "A Pending Fixed Interrupt May Be Dispatched Before an Interrupt of The Same Priority Completes". Apply the errata to all server and client models (big cores) from Broadwell to Cascade Lake. The workar

Re: Error during update_runstate_area with KPTI activated

2020-05-15 Thread Hongyan Xia
On Fri, 2020-05-15 at 11:08 +0100, Julien Grall wrote: > Hi, > > On 15/05/2020 10:57, Roger Pau Monné wrote: > > On Fri, May 15, 2020 at 10:23:16AM +0100, Julien Grall wrote: > > > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open > > > attachments unless you have verified the sender a

Re: [XEN PATCH 1/2] xen/build: fixup path to merge_config.sh

2020-05-15 Thread Anthony PERARD
On Tue, May 12, 2020 at 01:52:05PM -0400, Stewart Hildebrand wrote: > This resolves the following observed error: > > /bin/sh: /path/to/xen/xen/../xen/scripts/kconfig/merge_config.sh: No such > file or directory > > Signed-off-by: Stewart Hildebrand Reviewed-by: Anthony PERARD Thanks, -- A

Ping: [PATCH v2 3/6] x86/mem-paging: use guest handle for XENMEM_paging_op_prep

2020-05-15 Thread Jan Beulich
On 23.04.2020 10:38, Jan Beulich wrote: > While it should have been this way from the beginning, not doing so will > become an actual problem with PVH Dom0. The interface change is binary > compatible, but requires tools side producers to be re-built. > > Drop the bogus/unnecessary page alignment

Re: [XEN PATCH 0/2] xen/build: fix kconfig errors during config merge

2020-05-15 Thread Anthony PERARD
On Tue, May 12, 2020 at 01:52:04PM -0400, Stewart Hildebrand wrote: > This series fixes a couple of kconfig errors that I observed while > invoking a build with a defconfig and config fragment. > > I invoked the build as follows: > > cat > xen/arch/arm/configs/custom.config < CONFIG_DEBUG=y > CON

Re: [PATCH v2 2/6] x86/mem-paging: correct p2m_mem_paging_prep()'s error handling

2020-05-15 Thread Andrew Cooper
On 23/04/2020 09:37, Jan Beulich wrote: > Communicating errors from p2m_set_entry() to the caller is not enough: > Neither the M2P nor the stats updates should occur in such a case. "neither".  Following a colon/semicolon isn't the start of a new sentence. > Instead the allocated page needs to be

Re: [PATCH v2 3/6] x86/mem-paging: use guest handle for XENMEM_paging_op_prep

2020-05-15 Thread Andrew Cooper
On 23/04/2020 09:38, Jan Beulich wrote: > While it should have been this way from the beginning, not doing so will > become an actual problem with PVH Dom0. The interface change is binary > compatible, but requires tools side producers to be re-built. > > Drop the bogus/unnecessary page alignment r

Re: [XEN PATCH 2/2] xen/build: use the correct kconfig makefile

2020-05-15 Thread Anthony PERARD
On Tue, May 12, 2020 at 01:52:06PM -0400, Stewart Hildebrand wrote: > This resolves the following observed error: > > # > # merged configuration written to .config (needs make) > # > make -f /path/to/xen/xen/../xen/Makefile olddefconfig > make[2]: Entering directory '/path/to/xen/xen' > make[2]: *

[seabios test] 150188: tolerable FAIL - PUSHED

2020-05-15 Thread osstest service owner
flight 150188 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/150188/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 149712 test-amd64-amd64-xl-qemuu-win7-amd64 17 g

Re: [PATCH v2 2/6] x86/mem-paging: correct p2m_mem_paging_prep()'s error handling

2020-05-15 Thread Jan Beulich
On 15.05.2020 16:40, Andrew Cooper wrote: > On 23/04/2020 09:37, Jan Beulich wrote: >> @@ -1816,9 +1816,19 @@ int p2m_mem_paging_prep(struct domain *d >> goto out; >> /* Get a free page */ >> ret = -ENOMEM; >> -page = alloc_domheap_page(p2m->domain, 0); >> +

Re: [PATCH v4] x86: clear RDRAND CPUID bit on AMD family 15h/16h

2020-05-15 Thread Roger Pau Monné
On Mon, Mar 09, 2020 at 10:08:50AM +0100, Jan Beulich wrote: > Inspired by Linux commit c49a0a80137c7ca7d6ced4c812c9e07a949f6f24: > > There have been reports of RDRAND issues after resuming from suspend on > some AMD family 15h and family 16h systems. This issue stems from a BIOS > not

[linux-linus test] 150186: tolerable FAIL - PUSHED

2020-05-15 Thread osstest service owner
flight 150186 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/150186/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds16 guest-start/debian.repeat fail REGR. vs. 150159 Tests which did not succeed,

Re: [PATCH v2 5/6] x86/mem-paging: move code to its dedicated source file

2020-05-15 Thread Andrew Cooper
On 23/04/2020 09:39, Jan Beulich wrote: > Do a little bit of style adjustment along the way, and drop the > "p2m_mem_paging_" prefixes from the now static functions. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper

Re: [PATCH v2 6/6] x86/mem-paging: consistently use gfn_t

2020-05-15 Thread Andrew Cooper
On 23/04/2020 09:39, Jan Beulich wrote: > --- a/xen/arch/x86/mm/hap/guest_walk.c > +++ b/xen/arch/x86/mm/hap/guest_walk.c > @@ -68,7 +68,7 @@ unsigned long hap_p2m_ga_to_gfn(GUEST_PA > *pfec = PFEC_page_paged; > if ( top_page ) > put_page(top_page); > -p2m_mem

Re: [PATCH v2 6/6] x86/mem-paging: consistently use gfn_t

2020-05-15 Thread Andrew Cooper
On 15/05/2020 16:49, Andrew Cooper wrote: > On 23/04/2020 09:39, Jan Beulich wrote: >> --- a/xen/arch/x86/mm/hap/guest_walk.c >> +++ b/xen/arch/x86/mm/hap/guest_walk.c >> @@ -68,7 +68,7 @@ unsigned long hap_p2m_ga_to_gfn(GUEST_PA >> *pfec = PFEC_page_paged; >> if ( top_page ) >>

Re: [PATCH v3 2/3] xen/sched: don't call sync_vcpu_execstate() in sched_unit_migrate_finish()

2020-05-15 Thread Dario Faggioli
On Thu, 2020-05-14 at 17:36 +0200, Juergen Gross wrote: > With support of core scheduling sched_unit_migrate_finish() gained a > call of sync_vcpu_execstate() as it was believed to be called as a > result of vcpu migration in any case. > > In case of migrating a vcpu away from a physical cpu for a

Re: [PATCH 05/16] x86/shstk: Introduce Supervisor Shadow Stack support

2020-05-15 Thread Anthony PERARD
On Mon, May 04, 2020 at 03:52:58PM +0200, Jan Beulich wrote: > On 02.05.2020 00:58, Andrew Cooper wrote: > > --- a/xen/scripts/Kconfig.include > > +++ b/xen/scripts/Kconfig.include > > @@ -31,6 +31,10 @@ cc-option = $(success,$(CC) -Werror $(CLANG_FLAGS) $(1) > > -E -x c /dev/null -o /de > > # Re

Re: [PATCH v2 3/6] x86/mem-paging: use guest handle for XENMEM_paging_op_prep

2020-05-15 Thread Wei Liu
On Thu, Apr 23, 2020 at 10:38:18AM +0200, Jan Beulich wrote: > While it should have been this way from the beginning, not doing so will > become an actual problem with PVH Dom0. The interface change is binary > compatible, but requires tools side producers to be re-built. > > Drop the bogus/unnece

Re: Items for CHANGELOG.md in 4.14

2020-05-15 Thread Wei Liu
On Fri, May 15, 2020 at 12:20:44PM +0100, Paul Durrant wrote: > All, > > In the last community call I took an ACTION to send a reminder email to > submit patches to get CHANGELOG.md up to date. Several > items were mentioned during the call (see minutes at > https://cryptpad.fr/pad/#/2/pad/edi

[PATCH 0/3] vm_event: fix race-condition when disabling monitor events

2020-05-15 Thread Tamas K Lengyel
For the last couple years we have received numerous reports from users of monitor vm_events of spurious guest crashes when using events. In particular, it has observed that the problem occurs when vm_events are being disabled. The nature of the guest crash varied widely and has only occured occasio

[PATCH 3/3] xen/vm_event: Add safe to disable vm_event

2020-05-15 Thread Tamas K Lengyel
Instead of having to repeatedly try to disable vm_events, request a specific vm_event to be sent when the domain is safe to continue with shutting down the vm_event interface. Signed-off-by: Tamas K Lengyel --- xen/arch/x86/hvm/hvm.c| 38 ++- xen/arch/x86/

[PATCH 1/3] xen/monitor: Control register values

2020-05-15 Thread Tamas K Lengyel
Extend the monitor_op domctl to include option that enables controlling what values certain registers are permitted to hold by a monitor subscriber. Signed-off-by: Tamas K Lengyel --- xen/arch/x86/hvm/hvm.c | 31 +++ xen/arch/x86/monitor.c | 10 +-

[PATCH 2/3] xen/vm_event: add vm_event_check_pending_op

2020-05-15 Thread Tamas K Lengyel
Perform sanity checking when shutting vm_event down to determine whether it is safe to do so. Error out with -EAGAIN in case pending operations have been found for the domain. Signed-off-by: Tamas K Lengyel --- xen/arch/x86/vm_event.c| 23 +++ xen/common/vm_event.c

[xen-unstable-smoke test] 150198: tolerable all pass - PUSHED

2020-05-15 Thread osstest service owner
flight 150198 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150198/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

RE: Items for CHANGELOG.md in 4.14

2020-05-15 Thread Paul Durrant
> -Original Message- > From: Wei Liu > Sent: 15 May 2020 17:44 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; 'Roger Pau Monne' ; > Wei Liu > Subject: Re: Items for CHANGELOG.md in 4.14 > > On Fri, May 15, 2020 at 12:20:44PM +0100, Paul Durrant wrote: > > All, > > > > In the

Re: [PATCH 1/1] xen/manage: enable C_A_D to force reboot

2020-05-15 Thread Boris Ostrovsky
On 5/15/20 3:01 AM, Jürgen Groß wrote: > On 14.05.20 01:34, Dongli Zhang wrote: >> The systemd may be configured to mask ctrl-alt-del via "systemctl mask >> ctrl-alt-del.target". As a result, the pv reboot would not work as >> signal >> is ignored. >> >> This patch always enables C_A_D before the c

Re: [PATCH] domain_page: handle NULL within unmap_domain_page() itself

2020-05-15 Thread Julien Grall
Hi, On 13/05/2020 16:43, Hongyan Xia wrote: From: Hongyan Xia The macro version UNMAP_DOMAIN_PAGE() does both NULL checking and variable clearing. Move NULL checking into the function itself so that the semantics is consistent with other similar constructs like XFREE(). This also eases the use

[XEN PATCH v2] xen/build: use the correct kconfig makefile

2020-05-15 Thread Stewart Hildebrand
This resolves the following observed error during config merge: /bin/sh /path/to/xen/xen/../xen/tools/kconfig/merge_config.sh -m .config /path/to/xen/xen/../xen/arch/arm/configs/custom.config Using .config as base Merging /path/to/xen/xen/../xen/arch/arm/configs/custom.config # # merged configura

RE: [XEN PATCH v2] xen/build: use the correct kconfig makefile

2020-05-15 Thread Stewart Hildebrand
Friday, May 15, 2020 2:25 PM, Stewart Hildebrand wrote: >Signed-off-by: Stewart Hildebrand I forgot to include Anthony's Reviewed-by from v1 https://lists.xenproject.org/archives/html/xen-devel/2020-05/msg00848.html

[xen-unstable-smoke test] 150205: tolerable all pass - PUSHED

2020-05-15 Thread osstest service owner
flight 150205 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150205/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v2 2/6] x86/mem-paging: correct p2m_mem_paging_prep()'s error handling

2020-05-15 Thread Andrew Cooper
On 15/05/2020 16:15, Jan Beulich wrote: >>> +domain_crash(d); > This already leaves a file/line combination as a (minimal hint). First, that is still tantamount to useless in logs from a user. Second, the use of __LINE__ is why it breaks livepatching, and people using livepatching is

IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0

2020-05-15 Thread Manuel Bouyer
Hello, NetBSD works as dom0 up to Xen 4.11. I'm trying to get it working on 4.13.0. I added the support for gntdev operations, but I'm stuck with privcmd IOCTL_PRIVCMD_MMAPBATCH. It seems to work fine for PV and PVH domUs, but with HVM domUs, MMU_NORMAL_PT_UPDATE returns -22 (EINVAL) and qemu-dm d

Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0

2020-05-15 Thread Andrew Cooper
On 15/05/2020 21:29, Manuel Bouyer wrote: > Hello, > NetBSD works as dom0 up to Xen 4.11. I'm trying to get it working > on 4.13.0. I added the support for gntdev operations, but I'm stuck with > privcmd IOCTL_PRIVCMD_MMAPBATCH. It seems to work fine for PV and PVH domUs, > but with HVM domUs, MMU

Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0

2020-05-15 Thread Manuel Bouyer
On Fri, May 15, 2020 at 10:00:07PM +0100, Andrew Cooper wrote: > What is qemu doing at the time?  Is it by any chance trying to map the > IOREQ server frame? Here's what gdb says about it: Core was generated by `qemu-dm'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00

Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0

2020-05-15 Thread Andrew Cooper
On 15/05/2020 22:06, Manuel Bouyer wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On Fri, May 15, 2020 at 10:00:07PM +0100, Andrew Cooper wrote: >> What is qemu doing at the time?  Is it by

Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0

2020-05-15 Thread Manuel Bouyer
On Fri, May 15, 2020 at 10:38:13PM +0100, Andrew Cooper wrote: > > [...] > > Does it help ? > > Yes and no.  This is collateral damage of earlier bug. > > What failed was xen_init_fv()'s > >     shared_page = xc_map_foreign_range(xc_handle, domid, XC_PAGE_SIZE, >    

[xen-unstable-smoke test] 150209: tolerable all pass - PUSHED

2020-05-15 Thread osstest service owner
flight 150209 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150209/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH 0/3] vm_event: fix race-condition when disabling monitor events

2020-05-15 Thread Michał Leszczyński
> For the last couple years we have received numerous reports from users of > monitor vm_events of spurious guest crashes when using events. In particular, > it has observed that the problem occurs when vm_events are being disabled. The > nature of the guest crash varied widely and has only occured

[ovmf test] 150196: all pass - PUSHED

2020-05-15 Thread osstest service owner
flight 150196 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/150196/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9099dcbd61c8d22b5eedda783d143c222d2705a3 baseline version: ovmf bcf181a33b2ea46c36c3b

[qemu-mainline test] 150194: tolerable FAIL - PUSHED

2020-05-15 Thread osstest service owner
flight 150194 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/150194/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail blocked in 150151 test-amd64-amd64-xl-qemuu-win7-amd6

[seabios test] 150201: tolerable FAIL - PUSHED

2020-05-15 Thread osstest service owner
flight 150201 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/150201/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 150188 test-amd64-amd64-xl-qemuu-win7-amd64 17 g

[xen-unstable test] 150192: tolerable FAIL - PUSHED

2020-05-15 Thread osstest service owner
flight 150192 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/150192/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 16 guest-localmigrate fail like 150164 test-amd64-amd64-xl-qemuu-win7-amd64

[libvirt test] 150210: regressions - FAIL

2020-05-15 Thread osstest service owner
flight 150210 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/150210/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 146182 build-i386-libvirt