[PATCH v3 3/3] hw: Remove unnecessary DEVICE() cast

2020-05-12 Thread Philippe Mathieu-Daudé
The DEVICE() macro is defined as: #define DEVICE(obj) OBJECT_CHECK(DeviceState, (obj), TYPE_DEVICE) which expands to: ((DeviceState *)object_dynamic_cast_assert((Object *)(obj), (name), __FILE__, __LINE__,

[PATCH v3 0/3] various: Remove unnecessary casts

2020-05-12 Thread Philippe Mathieu-Daudé
Remove unnecessary casts using coccinelle scripts. The CPU()/OBJECT() patches don't introduce logical change, The DEVICE() one removes various OBJECT_CHECK() calls. Since v3: - Fixed patch #2 description (Markus) - Add A-b/R-b tags Since v2: - Reword description (Markus) - Add A-b/R-b tags Phil

[PATCH v3 1/3] target: Remove unnecessary CPU() cast

2020-05-12 Thread Philippe Mathieu-Daudé
The CPU() macro is defined as: #define CPU(obj) ((CPUState *)(obj)) which expands to: ((CPUState *)object_dynamic_cast_assert((Object *)(obj), (name), __FILE__, __LINE__, __func__)) This assertion can only fail when @obj points to something other th

[PATCH v3 2/3] various: Remove unnecessary OBJECT() cast

2020-05-12 Thread Philippe Mathieu-Daudé
The OBJECT() macro is defined as: #define OBJECT(obj) ((Object *)(obj)) Remove the unnecessary OBJECT() casts when we already know the pointer is of Object type. Patch created mechanically using spatch with this script: @@ typedef Object; Object *o; @@ - OBJECT(o) + o Acked-b

Re: [PATCH 0/2] Fixups for fcf-protection

2020-05-12 Thread Stefan Bader
On 12.05.20 05:39, Jason Andryuk wrote: > Two patches to fix building with a cf-protection toolchain. The first > handles the case where the compiler fails to run with "error: > ‘-mindirect-branch’ and ‘-fcf-protection’ are not compatible". > > The second fixes a runtime error that prevented Xen

Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly

2020-05-12 Thread Jan Beulich
On 11.05.2020 19:14, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be > selected from the menuconfig directly"): >> I'm trying to make the point that your patch, to me, looks to be >> trying to overcome a problem for which we have had a solution all >>

[linux-linus test] 150140: regressions - FAIL

2020-05-12 Thread osstest service owner
flight 150140 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/150140/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail in 150133 REGR. vs. 150126 Tests which are fai

Re: [PATCH 05/12] xen: introduce reserve_heap_pages

2020-05-12 Thread Julien Grall
Hi, On 12/05/2020 02:10, Stefano Stabellini wrote: On Thu, 30 Apr 2020, Julien Grall wrote: On 30/04/2020 18:00, Stefano Stabellini wrote: On Thu, 30 Apr 2020, Julien Grall wrote: +pg = maddr_to_page(start); +node = phys_to_nid(start); +zone = page_to_zone(pg); +page_list_del(

[PATCH v4 27/38] xen: gntdev: fix common struct sg_table related issues

2020-05-12 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the original number of the entries passed to the dma_

Re: [PATCH 1/2] xen/xenbus: avoid large structs and arrays on the stack

2020-05-12 Thread Jürgen Groß
On 11.05.20 20:01, Boris Ostrovsky wrote: On 5/11/20 3:31 AM, Juergen Gross wrote: static int xenbus_map_ring_valloc_hvm(struct xenbus_device *dev, I wonder whether we can drop valloc/vfree from xenbus_ring_ops' names. I can do that. + struct map

odd pte_mfn_to_pfn() behavior

2020-05-12 Thread Jan Beulich
Jürgen, Boris, in figuring out why a W+X mapping warning has magically disappeared (I now at least know that it was for the shared info fixmap page) in 5.6, besides finding two logic errors in 2ae27137b2db ("x86: mm: convert dump_pagetables to use walk_page_range") - one in the way st->prot_levels

Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly

2020-05-12 Thread Julien Grall
Hi, On 12/05/2020 08:18, Jan Beulich wrote: On 11.05.2020 19:14, Ian Jackson wrote: Jan Beulich writes ("Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly"): I'm trying to make the point that your patch, to me, looks to be trying to overcome a problem f

Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly

2020-05-12 Thread Jan Beulich
On 12.05.2020 12:08, Julien Grall wrote: > On 12/05/2020 08:18, Jan Beulich wrote: >> On 11.05.2020 19:14, Ian Jackson wrote: >>> Jan Beulich writes ("Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be >>> selected from the menuconfig directly"): I'm trying to make the point that your patch,

use of "stat -"

2020-05-12 Thread Jan Beulich
Hello, now that I've been able to do a little bit of work from the office again, I've run into a regression from b72682c602b8 "scripts: Use stat to check lock claim". On one of my older machines I've noticed guests wouldn't launch anymore, which I've tracked down to the system having an old stat o

Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly

2020-05-12 Thread Julien Grall
Hi Jan, On 12/05/2020 11:15, Jan Beulich wrote: On 12.05.2020 12:08, Julien Grall wrote: On 12/05/2020 08:18, Jan Beulich wrote: On 11.05.2020 19:14, Ian Jackson wrote: Jan Beulich writes ("Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly"): I'm tryi

Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly

2020-05-12 Thread Jan Beulich
On 12.05.2020 13:00, Julien Grall wrote: > Hi Jan, > > On 12/05/2020 11:15, Jan Beulich wrote: >> On 12.05.2020 12:08, Julien Grall wrote: >>> On 12/05/2020 08:18, Jan Beulich wrote: On 11.05.2020 19:14, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH RESEND 2/2] xen: Allow EXPERT mo

Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly

2020-05-12 Thread George Dunlap
> On May 12, 2020, at 12:03 PM, Jan Beulich wrote: > > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 12.05.2020 13:00, Julien Grall wrote: >> Hi Jan, >> >> On 12/05/2020 11:15, Jan Beulich

Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly

2020-05-12 Thread Jan Beulich
On 12.05.2020 13:05, George Dunlap wrote: > > >> On May 12, 2020, at 12:03 PM, Jan Beulich wrote: >> >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments >> unless you have verified the sender and know the content is safe. >> >> On 12.05.2020 13:00, Julien Grall wrote: >

Re: [PATCH RESEND 1/2] xen/Kconfig: define EXPERT a bool rather than a string

2020-05-12 Thread Julien Grall
Hi, It would be good a have an ack for the small Arm changes. I will wait until tomorrow morning (UK time) and commit it if I see no objection. Cheers, On 30/04/2020 15:25, Julien Grall wrote: From: Julien Grall Since commit f80fe2b34f08 "xen: Update Kconfig to Linux v5.4" EXPERT can only

Re: [PATCH 03/16] x86/traps: Factor out exception_fixup() and make printing consistent

2020-05-12 Thread Jan Beulich
On 11.05.2020 17:14, Andrew Cooper wrote: > On 04/05/2020 14:20, Jan Beulich wrote: >> On 02.05.2020 00:58, Andrew Cooper wrote: >>> --- a/xen/arch/x86/traps.c >>> +++ b/xen/arch/x86/traps.c >>> @@ -774,10 +774,27 @@ static void do_reserved_trap(struct cpu_user_regs >>> *regs) >>>trapn

Re: [PATCH v2 1/1] golang/xenlight: add NameToDomid and DomidToName util functions

2020-05-12 Thread George Dunlap
> On Apr 27, 2020, at 7:51 PM, Nick Rosbrook wrote: > > On Mon, Apr 27, 2020 at 8:59 AM George Dunlap > wrote: >> >> >> >>> On Apr 24, 2020, at 4:02 AM, Nick Rosbrook wrote: >>> >>> Many exported functions in xenlight require a domid as an argument. Make >>> it easier for package users t

Re: [PATCH 05/16] x86/shstk: Introduce Supervisor Shadow Stack support

2020-05-12 Thread Jan Beulich
On 11.05.2020 17:46, Andrew Cooper wrote: > On 04/05/2020 14:52, Jan Beulich wrote: >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments >> unless you have verified the sender and know the content is safe. >> >> On 02.05.2020 00:58, Andrew Cooper wrote: >>> --- a/xen/arch/x

[libvirt test] 150146: regressions - FAIL

2020-05-12 Thread osstest service owner
flight 150146 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/150146/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 146182 build-i386-libvirt

Re: [PATCH 06/16] x86/traps: Implement #CP handler and extend #PF for shadow stacks

2020-05-12 Thread Jan Beulich
On 11.05.2020 19:20, Andrew Cooper wrote: > On 04/05/2020 15:10, Jan Beulich wrote: >> On 02.05.2020 00:58, Andrew Cooper wrote: >>> @@ -1457,6 +1451,10 @@ void do_page_fault(struct cpu_user_regs *regs) >>> { >>> enum pf_type pf_type = spurious_page_fault(addr, regs); >>> >>> +

Re: [PATCH 07/16] x86/shstk: Re-layout the stack block for shadow stacks

2020-05-12 Thread Jan Beulich
On 11.05.2020 19:48, Andrew Cooper wrote: > On 04/05/2020 15:24, Jan Beulich wrote: >> On 02.05.2020 00:58, Andrew Cooper wrote: >>> --- a/xen/arch/x86/cpu/common.c >>> +++ b/xen/arch/x86/cpu/common.c >>> @@ -732,14 +732,14 @@ void load_system_tables(void) >>> .rsp2 = 0x8600

[xen-unstable test] 150142: tolerable FAIL - PUSHED

2020-05-12 Thread osstest service owner
flight 150142 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/150142/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 16 guest-localmigrate fail like 150135 test-amd64-amd64-xl-qemuu-win7-amd64

Re: use of "stat -"

2020-05-12 Thread Wei Liu
On Tue, May 12, 2020 at 12:58:46PM +0200, Jan Beulich wrote: > Hello, > > now that I've been able to do a little bit of work from the office > again, I've run into a regression from b72682c602b8 "scripts: Use > stat to check lock claim". On one of my older machines I've noticed > guests wouldn't l

[linux-5.4 test] 150143: tolerable FAIL - PUSHED

2020-05-12 Thread osstest service owner
flight 150143 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/150143/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 15 guest-saverestorefail like 150086 test-armhf-armhf-xl-rtds 16 guest-s

Re: [PATCH 12/16] x86/extable: Adjust extable handling to be shadow stack compatible

2020-05-12 Thread Jan Beulich
On 11.05.2020 23:09, Andrew Cooper wrote: > On 07/05/2020 14:35, Jan Beulich wrote: >> On 02.05.2020 00:58, Andrew Cooper wrote: >>> --- a/xen/arch/x86/traps.c >>> +++ b/xen/arch/x86/traps.c >>> @@ -778,6 +778,28 @@ static bool exception_fixup(struct cpu_user_regs >>> *regs, bool print) >>>

Re: use of "stat -"

2020-05-12 Thread Jan Beulich
On 12.05.2020 16:19, Wei Liu wrote: > On Tue, May 12, 2020 at 12:58:46PM +0200, Jan Beulich wrote: >> now that I've been able to do a little bit of work from the office >> again, I've run into a regression from b72682c602b8 "scripts: Use >> stat to check lock claim". On one of my older machines I'v

Re: [PATCH 2/3] golang/xenlight: init xenlight go module

2020-05-12 Thread George Dunlap
> On Apr 30, 2020, at 10:39 PM, Nick Rosbrook wrote: > > Initialize the xenlight Go module using the xenbits git-http URL, > xenbits.xen.org/git-http/xen.git/tools/golang/xenlight, and update the > XEN_GOCODE_URL variable in tools/Rules.mk accordingly. > > Signed-off-by: Nick Rosbrook > --- >

Re: use of "stat -"

2020-05-12 Thread Andrew Cooper
On 12/05/2020 15:33, Jan Beulich wrote: > On 12.05.2020 16:19, Wei Liu wrote: >> On Tue, May 12, 2020 at 12:58:46PM +0200, Jan Beulich wrote: >>> now that I've been able to do a little bit of work from the office >>> again, I've run into a regression from b72682c602b8 "scripts: Use >>> stat to chec

Re: [PATCH 1/3] golang/xenlight: re-track generated go code

2020-05-12 Thread George Dunlap
> On Apr 30, 2020, at 10:38 PM, Nick Rosbrook wrote: > > Commit df669de074c395a3b2eeb975fddd3da4c148da13 un-tracked the generated > Go code, but it was decided that we actually keep the generated code > in-tree. > > Undo the changes to ignore the generated code, and re-generate it. > > Signe

Re: [PATCH v2 1/1] golang/xenlight: add NameToDomid and DomidToName util functions

2020-05-12 Thread Nick Rosbrook
> > I just tested this way, and it does not work as expected. Since > > C.INVALID_DOMID is #define'd, cgo does not know it is intended to be > > used as uint32_t, and decides to declare C.INVALID_DOMID as int. So, > > C.INVALID_DOMID = ^int(0) = -1, which overflows Domid. > > > > I tried a few thin

Re: [PATCH 15/16] x86/entry: Adjust guest paths to be shadow stack compatible

2020-05-12 Thread Jan Beulich
On 11.05.2020 23:45, Andrew Cooper wrote: > On 07/05/2020 17:15, Jan Beulich wrote: > --- a/xen/arch/x86/x86_64/entry.S > +++ b/xen/arch/x86/x86_64/entry.S > @@ -194,6 +194,15 @@ restore_all_guest: > movq 8(%rsp),%rcx# RIP > jairet_exit_to_gues

Re: use of "stat -"

2020-05-12 Thread Jan Beulich
On 12.05.2020 16:47, Andrew Cooper wrote: > On 12/05/2020 15:33, Jan Beulich wrote: >> On 12.05.2020 16:19, Wei Liu wrote: >>> On Tue, May 12, 2020 at 12:58:46PM +0200, Jan Beulich wrote: now that I've been able to do a little bit of work from the office again, I've run into a regression

Re: [PATCH 2/3] golang/xenlight: init xenlight go module

2020-05-12 Thread Nick Rosbrook
On Tue, May 12, 2020 at 10:36 AM George Dunlap wrote: > > > > > On Apr 30, 2020, at 10:39 PM, Nick Rosbrook wrote: > > > > Initialize the xenlight Go module using the xenbits git-http URL, > > xenbits.xen.org/git-http/xen.git/tools/golang/xenlight, and update the > > XEN_GOCODE_URL variable in to

Re: [PATCH 2/2] x86/boot: Drop .note.gnu.properties in build32.lds

2020-05-12 Thread Jan Beulich
On 12.05.2020 05:39, Jason Andryuk wrote: > reloc.S and cmdline.S as arrays of executable bytes for inclusion in > head.S generated from compiled object files. Object files generated by > an -fcf-protection toolchain include a .note.gnu.property section. The > way reloc.S and cmdline.S are genera

Re: [PATCH RESEND 1/2] xen/Kconfig: define EXPERT a bool rather than a string

2020-05-12 Thread Stefano Stabellini
On Tue, 12 May 2020, Julien Grall wrote: > Hi, > > It would be good a have an ack for the small Arm changes. Acked-by: Stefano Stabellini > I will wait until > tomorrow morning (UK time) and commit it if I see no objection. > > Cheers, > > On 30/04/2020 15:25, Julien Grall wrote: > > From: J

Re: [PATCH 2/3] golang/xenlight: init xenlight go module

2020-05-12 Thread George Dunlap
> On May 12, 2020, at 4:06 PM, Nick Rosbrook wrote: > > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On Tue, May 12, 2020 at 10:36 AM George Dunlap > wrote: >> >> >> >>> On Apr 30, 2020,

Re: use of "stat -"

2020-05-12 Thread Jason Andryuk
On Tue, May 12, 2020 at 10:59 AM Jan Beulich wrote: > > On 12.05.2020 16:47, Andrew Cooper wrote: > > On 12/05/2020 15:33, Jan Beulich wrote: > >> On 12.05.2020 16:19, Wei Liu wrote: > >>> On Tue, May 12, 2020 at 12:58:46PM +0200, Jan Beulich wrote: > now that I've been able to do a little bi

Re: [PATCH 2/2] x86/boot: Drop .note.gnu.properties in build32.lds

2020-05-12 Thread Andrew Cooper
On 12/05/2020 16:32, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 12.05.2020 05:39, Jason Andryuk wrote: >> reloc.S and cmdline.S as arrays of executable bytes for inclusion

Re: [PATCH 2/3] golang/xenlight: init xenlight go module

2020-05-12 Thread Nick Rosbrook
> For trademark reasons, when we joined the Linux Foundation, we did a big > rebranding from “Xen” to “XenProject”. (See [1] for more details.) The > xen.org domains are just for backwards compatibility. :-) Ah, thanks! I'll fix that. -NR

Re: [PATCH 2/2] x86/boot: Drop .note.gnu.properties in build32.lds

2020-05-12 Thread Jan Beulich
On 12.05.2020 17:58, Andrew Cooper wrote: > On 12/05/2020 16:32, Jan Beulich wrote: >> On 12.05.2020 05:39, Jason Andryuk wrote: >>> Discard the .note.gnu.property section when linking to avoid the extra >>> bytes. >> If we go this route (and if, as per above, I'm misremembering, >> meaning we didn

Re: [PATCH 2/2] x86/boot: Drop .note.gnu.properties in build32.lds

2020-05-12 Thread Andrew Cooper
On 12/05/2020 17:11, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 12.05.2020 17:58, Andrew Cooper wrote: >> On 12/05/2020 16:32, Jan Beulich wrote: >>> On 12.05.2020 05:39,

Re: [PATCH 12/16] x86/extable: Adjust extable handling to be shadow stack compatible

2020-05-12 Thread Andrew Cooper
On 12/05/2020 15:31, Jan Beulich wrote: > On 11.05.2020 23:09, Andrew Cooper wrote: >> On 07/05/2020 14:35, Jan Beulich wrote: >>> On 02.05.2020 00:58, Andrew Cooper wrote: --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -778,6 +778,28 @@ static bool exception_fixup(struct c

Re: [PATCH 2/2] x86/boot: Drop .note.gnu.properties in build32.lds

2020-05-12 Thread Jason Andryuk
On Tue, May 12, 2020 at 11:58 AM Andrew Cooper wrote: > > On 12/05/2020 16:32, Jan Beulich wrote: > > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > > unless you have verified the sender and know the content is safe. > > > > On 12.05.2020 05:39, Jason Andryuk wrote: >

[PATCH] x86/guest: Fix assembler warnings with newer binutils

2020-05-12 Thread Andrew Cooper
GAS of at least version 2.34 complains: hypercall_page.S: Assembler messages: hypercall_page.S:24: Warning: symbol 'HYPERCALL_set_trap_table' already has its type set ... hypercall_page.S:71: Warning: symbol 'HYPERCALL_arch_7' already has its type set This is because the whole page is d

Re: [PATCH 3/3] golang/xenlight: add necessary module/package documentation

2020-05-12 Thread George Dunlap
> On Apr 30, 2020, at 10:39 PM, Nick Rosbrook wrote: > > Add a README and package comment giving a brief overview of the package. > These also help pkg.go.dev generate better documentation. > > Also, add a copy of Xen's license to tools/golang/xenlight. This is > required for the package to be

Re: [PATCH 2/3] golang/xenlight: init xenlight go module

2020-05-12 Thread George Dunlap
> On May 12, 2020, at 4:06 PM, Nick Rosbrook wrote: > > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On Tue, May 12, 2020 at 10:36 AM George Dunlap > wrote: >> >> >> >>> On Apr 30, 2020, a

Re: [PATCH 2/3] golang/xenlight: init xenlight go module

2020-05-12 Thread George Dunlap
> On May 12, 2020, at 6:30 PM, George Dunlap wrote: > >> >> On May 12, 2020, at 4:06 PM, Nick Rosbrook wrote: >> >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments >> unless you have verified the sender and know the content is safe. >> >> On Tue, May 12, 2020 at 1

[XEN PATCH 0/2] xen/build: fix kconfig errors during config merge

2020-05-12 Thread Stewart Hildebrand
This series fixes a couple of kconfig errors that I observed while invoking a build with a defconfig and config fragment. I invoked the build as follows: cat > xen/arch/arm/configs/custom.config <

[XEN PATCH 1/2] xen/build: fixup path to merge_config.sh

2020-05-12 Thread Stewart Hildebrand
This resolves the following observed error: /bin/sh: /path/to/xen/xen/../xen/scripts/kconfig/merge_config.sh: No such file or directory Signed-off-by: Stewart Hildebrand --- xen/tools/kconfig/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/tools/kconfig/Makefil

[XEN PATCH 2/2] xen/build: use the correct kconfig makefile

2020-05-12 Thread Stewart Hildebrand
This resolves the following observed error: # # merged configuration written to .config (needs make) # make -f /path/to/xen/xen/../xen/Makefile olddefconfig make[2]: Entering directory '/path/to/xen/xen' make[2]: *** No rule to make target 'olddefconfig'. Stop. make[2]: Leaving directory '/path/t

Re: [PATCH 0/2] Fixups for fcf-protection

2020-05-12 Thread Andrew Cooper
On 12/05/2020 08:17, Stefan Bader wrote: > On 12.05.20 05:39, Jason Andryuk wrote: >> Two patches to fix building with a cf-protection toolchain. The first >> handles the case where the compiler fails to run with "error: >> ‘-mindirect-branch’ and ‘-fcf-protection’ are not compatible". >> >> The s

[qemu-mainline test] 150144: tolerable FAIL - PUSHED

2020-05-12 Thread osstest service owner
flight 150144 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/150144/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail like 150109 test-amd64-amd64-xl-qemuu-win7-amd6

Re: [PATCH 2/2] x86/boot: Drop .note.gnu.properties in build32.lds

2020-05-12 Thread Andrew Cooper
On 12/05/2020 17:17, Jason Andryuk wrote: > On Tue, May 12, 2020 at 11:58 AM Andrew Cooper > wrote: >> On 12/05/2020 16:32, Jan Beulich wrote: >>> On 12.05.2020 05:39, Jason Andryuk wrote: reloc.S and cmdline.S as arrays of executable bytes for inclusion in head.S generated from compile

[PATCH] x86/build32: Discard all orphaned sections

2020-05-12 Thread Andrew Cooper
Linkers may put orphaned sections ahead of .text, which breaks the calling requirements. A concrete example is Ubuntu's GCC-9 default of enabling -fcf-protection which causes us to try and execute .note.gnu.properties during Xen's boot. Put .got.plt in its own section as it specifically needs pre

[PATCH] x86/build: Unilaterally disable -fcf-protection

2020-05-12 Thread Andrew Cooper
See comment for details. Works around a GCC-9 bug which breaks the build on Ubuntu. Reported-by: Jason Andryuk Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Jason Andryuk CC: Stefan Bader Sorry for messing you around with how to fix this. I'd neglec

rombios triple fault with -fcf-protection

2020-05-12 Thread Jason Andryuk
This is the output from a failed rombios boot: (d11) Invoking ROMBIOS ... (XEN) stdvga.c:173:d11v0 entering stdvga mode (d11) VGABios $Id: vgabios.c,v 1.67 2008/01/27 09:44:12 vruppert Exp $ (d11) Bochs BIOS - build: 06/23/99 (d11) $Revision: 1.221 $ $Date: 2008/12/07 17:32:29 $ (d11) Options: apm

Re: use of "stat -"

2020-05-12 Thread Elliott Mitchell
On Tue, May 12, 2020 at 11:52:25AM -0400, Jason Andryuk wrote: > I was just looking to remove perl since it's a large dependency for > this single use. I'm not tied to a particular approach. Have you tried to remove Perl from a system? This is possible, but on many systems there will be hundreds

Re: use of "stat -"

2020-05-12 Thread Andrew Cooper
On 12/05/2020 20:50, Elliott Mitchell wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On Tue, May 12, 2020 at 11:52:25AM -0400, Jason Andryuk wrote: >> I was just looking to remove perl since

Re: [PATCH 3/3] golang/xenlight: add necessary module/package documentation

2020-05-12 Thread Nick Rosbrook
On Tue, May 12, 2020 at 1:20 PM George Dunlap wrote: > > > > > On Apr 30, 2020, at 10:39 PM, Nick Rosbrook wrote: > > > > Add a README and package comment giving a brief overview of the package. > > These also help pkg.go.dev generate better documentation. > > > > Also, add a copy of Xen's licens

Re: use of "stat -"

2020-05-12 Thread Elliott Mitchell
On Tue, May 12, 2020 at 08:54:26PM +0100, Andrew Cooper wrote: > On 12/05/2020 20:50, Elliott Mitchell wrote: > > On Tue, May 12, 2020 at 11:52:25AM -0400, Jason Andryuk wrote: > >> I was just looking to remove perl since it's a large dependency for > >> this single use. I'm not tied to a particul

[linux-linus test] 150148: tolerable FAIL - PUSHED

2020-05-12 Thread osstest service owner
flight 150148 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/150148/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail like 150126 test-amd64-amd64-xl-qemut-win7-amd64

Re: [PATCH 2/3] golang/xenlight: init xenlight go module

2020-05-12 Thread Nick Rosbrook
> The whole point of running ‘go build’ is to make sure that *the code we just > copied* — the code right now in our own local tree, perhaps which was just > generated — actually compiles. I understand that, and in my tests that's the outcome. > It looks like when we add the `go.mod` further up

[PATCH v3 0/1] More wrappers for xenlight Go package

2020-05-12 Thread Nick Rosbrook
This series adds wrappers to the xenlight package for various libxl functions, which are now trivial to add with the generated types and marshaling helpers. In particular, these are functions that would allow redctl to begin making the transition to using the xenlight package. For reference, I ha

[PATCH v3 1/1] golang/xenlight: add NameToDomid and DomidToName util functions

2020-05-12 Thread Nick Rosbrook
Many exported functions in xenlight require a domid as an argument. Make it easier for package users to use these functions by adding wrappers for the libxl utility functions libxl_name_to_domid and libxl_domid_to_name. Signed-off-by: Nick Rosbrook --- tools/golang/xenlight/xenlight.go | 40

[PATCH v2 0/3] initialize xenlight go module

2020-05-12 Thread Nick Rosbrook
These patches setup an initial Go module for the xenlight package. The go code is tracked again, since the module is defined in xen.git as xenbits.xenproject.org/git-http/xen.git/tools/golang/xenlight. The final patch adds a README and LICENSE to tools/golang/xenlight so that the package will show

[PATCH v2 2/3] golang/xenlight: init xenlight go module

2020-05-12 Thread Nick Rosbrook
Initialize the xenlight Go module using the xenbits git-http URL, xenbits.xenproject.org/git-http/xen.git/tools/golang/xenlight. Also simplify the build Make target by using `go build` instead of `go install`, and do not set GOPATH here because it is now unnecessary. Signed-off-by: Nick Rosbrook

[PATCH v2 3/3] golang/xenlight: add necessary module/package documentation

2020-05-12 Thread Nick Rosbrook
Add a README and package comment giving a brief overview of the package. These also help pkg.go.dev generate better documentation. Also, add a copy of the LGPL (the same license used by libxl) to tools/golang/xenlight. This is required for the package to be shown on pkg.go.dev and added to the def

Re: [PATCH] x86/build32: Discard all orphaned sections

2020-05-12 Thread Jason Andryuk
On Tue, May 12, 2020 at 3:11 PM Andrew Cooper wrote: > > Linkers may put orphaned sections ahead of .text, which breaks the calling > requirements. A concrete example is Ubuntu's GCC-9 default of enabling > -fcf-protection which causes us to try and execute .note.gnu.properties during > Xen's boo

Re: [PATCH] x86/build: Unilaterally disable -fcf-protection

2020-05-12 Thread Jason Andryuk
On Tue, May 12, 2020 at 3:11 PM Andrew Cooper wrote: > > See comment for details. Works around a GCC-9 bug which breaks the build on > Ubuntu. > > Reported-by: Jason Andryuk > Signed-off-by: Andrew Cooper Tested-by: Jason Andryuk Reviewed-by: Jason Andryuk > diff --git a/xen/arch/x86/arch.m

[ovmf test] 150152: all pass - PUSHED

2020-05-12 Thread osstest service owner
flight 150152 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/150152/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 88899a372cfc44f8612315f4b43a084d1814fe69 baseline version: ovmf 9378310dd877b99be1da3

[xen-unstable test] 150150: tolerable FAIL

2020-05-12 Thread osstest service owner
flight 150150 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/150150/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 17 guest-saverestore.2 fail blocked in 150142 test-amd64-amd64-xl-qemuu-win7-amd64

Re: [PATCH 0/2] Fixups for fcf-protection

2020-05-12 Thread Stefan Bader
On 12.05.20 20:47, Andrew Cooper wrote: > On 12/05/2020 08:17, Stefan Bader wrote: >> On 12.05.20 05:39, Jason Andryuk wrote: >>> Two patches to fix building with a cf-protection toolchain. The first >>> handles the case where the compiler fails to run with "error: >>> ‘-mindirect-branch’ and ‘-fc

[qemu-mainline test] 150151: tolerable FAIL - PUSHED

2020-05-12 Thread osstest service owner
flight 150151 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/150151/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 16 guest-localmigrate fail REGR. vs. 150144 Tests which did not succee