Re: [Xen-devel] [PATCH v3] SVM: Add union intstat_t for offset 68h in vmcb struct

2020-03-27 Thread Jan Beulich
On 26.03.2020 14:56, Andrew Cooper wrote: > On 26/03/2020 13:44, Pu Wen wrote: >> According to chapter "Appendix B Layout of VMCB" in the new version >> (v3.32) AMD64 APM[1], bit 1 of the VMCB offset 68h is defined as >> GUEST_INTERRUPT_MASK. >> >> In current xen codes, it use whole u64 interrupt_s

Re: [Xen-devel] [PATCH v8 3/5] xen: don't process rcu callbacks when holding a rcu_read_lock()

2020-03-27 Thread Jürgen Groß
On 27.03.20 00:24, Igor Druzhinin wrote: On 26/03/2020 09:19, Juergen Gross wrote: Some keyhandlers are calling process_pending_softirqs() while holding a rcu_read_lock(). This is wrong, as process_pending_softirqs() might activate rcu calls which should not happen inside a rcu_read_lock(). For

Re: [Xen-devel] [PATCH v8 3/5] xen: don't process rcu callbacks when holding a rcu_read_lock()

2020-03-27 Thread Jan Beulich
On 27.03.2020 09:10, Jürgen Groß wrote: > On 27.03.20 00:24, Igor Druzhinin wrote: >> On 26/03/2020 09:19, Juergen Gross wrote: >>> Some keyhandlers are calling process_pending_softirqs() while holding >>> a rcu_read_lock(). This is wrong, as process_pending_softirqs() might >>> activate rcu calls

Re: [Xen-devel] [PATCH v8 3/5] xen: don't process rcu callbacks when holding a rcu_read_lock()

2020-03-27 Thread Jürgen Groß
On 27.03.20 09:35, Jan Beulich wrote: On 27.03.2020 09:10, Jürgen Groß wrote: On 27.03.20 00:24, Igor Druzhinin wrote: On 26/03/2020 09:19, Juergen Gross wrote: Some keyhandlers are calling process_pending_softirqs() while holding a rcu_read_lock(). This is wrong, as process_pending_softirqs()

Re: [Xen-devel] PCIe IOMMU ACS support

2020-03-27 Thread Paul Durrant
> -Original Message- > From: Roman Shaposhnik > Sent: 26 March 2020 22:03 > To: Roger Pau Monné > Cc: xen-devel@lists.xenproject.org; Jan Beulich ; Paul > Durrant ; > Kevin Tian ; Andrew Cooper > Subject: Re: [Xen-devel] PCIe IOMMU ACS support > > On Wed, Mar 25, 2020 at 4:05 AM Roger

Re: [Xen-devel] [PATCH v3 3/4] x86/nvmx: split updating RVI from SVI in nvmx_update_apicv

2020-03-27 Thread Roger Pau Monné
On Fri, Mar 27, 2020 at 02:21:46AM +, Tian, Kevin wrote: > > From: Roger Pau Monne > > Sent: Thursday, March 26, 2020 11:27 PM > > > > Updating SVI is required when an interrupt has been injected using the > > Ack on exit VMEXIT feature, so that the in service interrupt in the > > GUEST_INTR_

Re: [Xen-devel] [PATCH v8 3/5] xen: don't process rcu callbacks when holding a rcu_read_lock()

2020-03-27 Thread Igor Druzhinin
On 27/03/2020 08:35, Jan Beulich wrote: > On 27.03.2020 09:10, Jürgen Groß wrote: >> On 27.03.20 00:24, Igor Druzhinin wrote: >>> On 26/03/2020 09:19, Juergen Gross wrote: Some keyhandlers are calling process_pending_softirqs() while holding a rcu_read_lock(). This is wrong, as process_pe

[Xen-devel] [PATCH] xen/softirq: adjust comment

2020-03-27 Thread Juergen Gross
With commit cef21210fb133 ("rcu: don't process callbacks when holding a rcu_read_lock()") the comment in process_pending_softirqs() about not entering the scheduler should have been moved. Signed-off-by: Juergen Gross --- xen/common/softirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Xen-devel] [PATCH] xen/softirq: adjust comment

2020-03-27 Thread Jan Beulich
On 27.03.2020 11:31, Juergen Gross wrote: > With commit cef21210fb133 ("rcu: don't process callbacks when holding > a rcu_read_lock()") the comment in process_pending_softirqs() about > not entering the scheduler should have been moved. > > Signed-off-by: Juergen Gross Acked-by: Jan Beulich

Re: [Xen-devel] [PATCH 09/17] xen/x86: Reduce the number of use of l*e_{from, get}_pfn()

2020-03-27 Thread Jan Beulich
On 22.03.2020 17:14, jul...@xen.org wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -1138,7 +1138,7 @@ static int > get_page_from_l2e( > l2_pgentry_t l2e, mfn_t l2mfn, struct domain *d, unsigned int flags) > { > -unsigned long mfn = l2e_get_pfn(l2e); > +mfn_t mfn = l2

[Xen-devel] Fwd: [ANNOUNCE] Call for agenda items for April 2020 Community Call @ 15:00 UTC

2020-03-27 Thread George Dunlap
Forgot to cc xen-devel Begin forwarded message: From: George Dunlap mailto:george.dun...@citrix.com>> Subject: [ANNOUNCE] Call for agenda items for April 2020 Community Call @ 15:00 UTC Date: March 26, 2020 at 6:54:31 PM GMT Hi all, The proposed agenda is in https://cryptpad.fr/pad/#/2/pad/ed

[Xen-devel] [linux-linus test] 149049: regressions - trouble: fail/pass/starved

2020-03-27 Thread osstest service owner
flight 149049 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/149049/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 133580 test-armhf-

Re: [Xen-devel] [PATCH 10/17] xen/x86: pv: Use maddr_to_mfn(...) instead of the open-coding version

2020-03-27 Thread Jan Beulich
On 22.03.2020 17:14, jul...@xen.org wrote: > From: Julien Grall > > _mfn(addr >> PAGE_SHIFT) is equivalent to maddr_to_mfn(addr). > > Signed-off-by: Julien Grall Acked-by: Jan Beulich

Re: [Xen-devel] [PATCH 11/17] xen/x86: nested_ept: Fix typo in the message in nept_translate_l2ga()

2020-03-27 Thread Jan Beulich
On 22.03.2020 17:14, jul...@xen.org wrote: > From: Julien Grall > > Signed-off-by: Julien Grall Acked-by: Jan Beulich

Re: [Xen-devel] [PATCH 12/17] xen/x86: p2m: Remove duplicate error message in p2m_pt_audit_p2m()

2020-03-27 Thread Jan Beulich
On 22.03.2020 17:14, jul...@xen.org wrote: > From: Julien Grall > > p2m_pt_audit_p2m() has one place where the same message may be printed > twice via printk and P2M_PRINTK. > > Remove the one printed using printk to stay consistent with the rest of > the code. > > Signed-off-by: Julien Grall

Re: [Xen-devel] [PATCH 13/17] xen/x86: p2m: Reflow P2M_PRINTK()s in p2m_pt_audit_p2m()

2020-03-27 Thread Jan Beulich
On 22.03.2020 17:14, jul...@xen.org wrote: > From: Julien Grall > > We tend to avoid splitting message on multiple line, so it is easier to > find it. > > Signed-off-by: Julien Grall Acked-by: Jan Beulich

[Xen-devel] [PATCH] automation/gitlab: add https transport support to Debian images

2020-03-27 Thread Roger Pau Monne
The LLVM repos have switched from http to https, and trying to access using http will get redirected to https. Add the apt-transport-https package to the x86 Debian containers that use the LLVM repos, in order to support the https transport method. Note that on Arm we only test with gcc, so don't

[Xen-devel] [PATCH] x86/ucode/amd: Fix buffer overrun with equiv table handling

2020-03-27 Thread Andrew Cooper
find_equiv_cpu_id() loops until it finds a 0 installed_cpu entry. Well formed AMD microcode containers have this property. Extend the checking in install_equiv_cpu_table() to reject tables which don't have a sentinal at the end. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC:

[Xen-devel] [PATCH] x86/ucode: Drop the sanity check for interrupts being disabled

2020-03-27 Thread Andrew Cooper
Of the substantial number of things which can go wrong during microcode load, this is not one. Loading occurs entirely within the boundary of a single WRMSR instruction. Its certainly not a BUG()-worthy condition. Xen has legitimate reasons to not want interrupts enabled at this point, but that

[Xen-devel] [linux-5.4 test] 149052: regressions - trouble: fail/pass/starved

2020-03-27 Thread osstest service owner
flight 149052 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/149052/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 146121 Regressions w

[Xen-devel] [PATCH v2 1/7] x86/ucode: Remove unnecessary indirection in struct microcode_patch

2020-03-27 Thread Andrew Cooper
Currently, each cpu_request_microcode() allocates a struct microcode_patch, which is a single pointer to a separate allocated structure. This is wasteful. Fixing this is complicated because the common microcode_free_patch() code is responsible for freeing struct microcode_patch, despite this bein

[Xen-devel] [PATCH v2 0/7] x86/ucode: Cleanup and fixes - Part 3/n (Intel)

2020-03-27 Thread Andrew Cooper
This supercedes the remnants of the Part 1 series, using Jan's suggested alternative for making struct microcode_patch opaque. Andrew Cooper (7): x86/ucode: Remove unnecessary indirection in struct microcode_patch x86/ucode/intel: Adjust microcode_sanity_check() to not take void * x86/ucode/

[Xen-devel] [PATCH v2 6/7] x86/ucode/intel: Clean up microcode_sanity_check()

2020-03-27 Thread Andrew Cooper
Rewrite the size checks in a way which doesn't depend on Xen being compiled as 64bit. Introduce a check missing from the old code, that total_size is a multiple of 1024 bytes, and drop unnecessary defines/macros/structures. No practical change in behaviour. Signed-off-by: Andrew Cooper --- CC:

[Xen-devel] [PATCH v2 4/7] x86/ucode/intel: Reimplement get_{data, total}size() helpers

2020-03-27 Thread Andrew Cooper
Every caller actually passes a struct microcode_header_intel *, but it is more helpful to us longterm to take struct microcode_patch *. Implement the helpers with proper types, and leave a comment explaining the Pentium Pro/II behaviour with empty {data,total}size fields. No functional change. S

[Xen-devel] [PATCH v2 7/7] x86/ucode/intel: Fold structures together

2020-03-27 Thread Andrew Cooper
With all the necessary cleanup now in place, fold struct microcode_header_intel into struct microcode_patch and drop the struct microcode_intel temporary ifdef-ary. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné v2: * Rebase over struc

[Xen-devel] [PATCH v2 5/7] x86/ucode/intel: Clean up microcode_update_match()

2020-03-27 Thread Andrew Cooper
Implement a new get_ext_sigtable() helper to abstract the logic for identifying whether an extended signature table exists. As part of this, rename microcode_intel.bits to data and change its type so it can be usefully used in combination with the datasize header field. Also, replace the sigmatch

[Xen-devel] [PATCH v2 2/7] x86/ucode/intel: Adjust microcode_sanity_check() to not take void *

2020-03-27 Thread Andrew Cooper
microcode_sanity_check()'s callers actually call it with a mixture of microcode_intel(/patch) and microcode_header_intel pointers, which is fragile. Rework it to take struct microcode_patch *, which in turn requires microcode_update_match()'s type to be altered. No functional change - compiled bi

[Xen-devel] [PATCH v2 3/7] x86/ucode/intel: Remove gratuitous memory allocations from cpu_request_microcode()

2020-03-27 Thread Andrew Cooper
cpu_request_microcode() needs to scan its container and duplicate one blob, but the get_next_ucode_from_buffer() helper duplicates every blob in turn. Furthermore, the length checking is only safe from overflow in 64bit builds. Delete get_next_ucode_from_buffer() and alter the purpose of the saved

Re: [Xen-devel] [PATCH] x86/ucode/amd: Fix buffer overrun with equiv table handling

2020-03-27 Thread Jan Beulich
On 27.03.2020 12:59, Andrew Cooper wrote: > find_equiv_cpu_id() loops until it finds a 0 installed_cpu entry. Well formed > AMD microcode containers have this property. With this, would you mind adding "potential" to the subject? > Extend the checking in install_equiv_cpu_table() to reject table

Re: [Xen-devel] [PATCH] x86/ucode: Drop the sanity check for interrupts being disabled

2020-03-27 Thread Jan Beulich
On 27.03.2020 13:19, Andrew Cooper wrote: > Of the substantial number of things which can go wrong during microcode load, > this is not one. Loading occurs entirely within the boundary of a single > WRMSR instruction. Its certainly not a BUG()-worthy condition. > > Xen has legitimate reasons to

Re: [Xen-devel] [PATCH 7/7] x86/ucode/intel: Fold structures together

2020-03-27 Thread Andrew Cooper
On 26/03/2020 15:05, Jan Beulich wrote: > On 26.03.2020 15:50, Andrew Cooper wrote: >> On a perhaps tangential note, what (if anything) are you plans regarding >> backport here? >> >> These defines are ok for a transitional period across a series (and >> probably means I'll need to get the AMD side

Re: [Xen-devel] [PATCH 14/17] xen/x86: mm: Re-implement set_gpfn_from_mfn() as a static inline function

2020-03-27 Thread Jan Beulich
On 22.03.2020 17:14, jul...@xen.org wrote: > From: Julien Grall > > set_gpfn_from_mfn() is currently implement in a 2 part macros. The > second macro is only called within the first macro, so they can be > folded together. > > Furthermore, this is now converted to a static inline making the code

Re: [Xen-devel] [PATCH 15/17] xen/x86: p2m: Rework printk format in audit_p2m()

2020-03-27 Thread Jan Beulich
On 22.03.2020 17:14, jul...@xen.org wrote: > From: Julien Grall > > One of the printk format in audit_p2m() may be difficult to read as it > is not clear what is the first number. > > Furthermore, the format can now take advantage of %pd. > > Signed-off-by: Julien Grall Acked-by: Jan Beulich

[Xen-devel] [PATCH v4 1/2] x86/nvmx: split updating RVI from SVI in nvmx_update_apicv

2020-03-27 Thread Roger Pau Monne
Updating SVI is required when an interrupt has been injected using the Ack on exit VMEXIT feature, so that the in service interrupt in the GUEST_INTR_STATUS matches the vector that is signaled in VM_EXIT_INTR_INFO. Updating RVI however is not tied to the Ack on exit feature, as it signals the next

[Xen-devel] [PATCH v4 2/2] x86/nvmx: update exit bitmap when using virtual interrupt delivery

2020-03-27 Thread Roger Pau Monne
Force an update of the EOI exit bitmap in nvmx_update_apicv, because the one performed in vmx_intr_assist might not be reached if the interrupt is intercepted by nvmx_intr_intercept returning true. Extract the code to update the exit bitmap from vmx_intr_assist into a helper and use it in nvmx_upd

[Xen-devel] [PATCH v4 0/2] x86/nvmx: fixes for interrupt injection

2020-03-27 Thread Roger Pau Monne
Hello, osstest identified a regression caused by my earlier attempt to fix interrupt injection when using nested VMX. This series aims to fix the regression, and should unblock several osstest branches. The following report is from osstest with this series applied: http://logs.test-lab.xenprojec

Re: [Xen-devel] [PATCH 16/17] xen/mm: Convert {s, g}et_gpfn_from_mfn() to use typesafe MFN

2020-03-27 Thread Jan Beulich
On 22.03.2020 17:14, jul...@xen.org wrote: > @@ -983,19 +984,20 @@ long p2m_pt_audit_p2m(struct p2m_domain *p2m) > /* check for 1GB super page */ > if ( l3e_get_flags(l3e[i3]) & _PAGE_PSE ) > { > -mfn = l3e_get_pfn(l3e[i3]); > -

Re: [Xen-devel] [PATCH] automation/gitlab: add https transport support to Debian images

2020-03-27 Thread Wei Liu
On Fri, Mar 27, 2020 at 12:49:47PM +0100, Roger Pau Monne wrote: > The LLVM repos have switched from http to https, and trying to access > using http will get redirected to https. Add the apt-transport-https > package to the x86 Debian containers that use the LLVM repos, in order > to support the h

Re: [Xen-devel] [PATCH] SVM: split _np_enable VMCB field

2020-03-27 Thread Andrew Cooper
On 26/03/2020 14:00, Jan Beulich wrote: > The nest paging enable is actually just a single bit within the 64-bit > VMCB field, which is particularly relevant for uses like the one in > nsvm_vcpu_vmentry(). Lucky for us, these are configuration options, not returned data, so at least the field won'

[Xen-devel] [PATCH v8 2/2] docs/designs: Add a design document for migration of xenstore data

2020-03-27 Thread Paul Durrant
From: Paul Durrant This patch details proposes extra migration data and xenstore protocol extensions to support non-cooperative live migration of guests. NOTE: doc/misc/xenstore.txt is also amended to replace the term for the INTRODUCE operation with the , since this is what it actu

[Xen-devel] [PATCH v8 0/2] docs: Migration design documents

2020-03-27 Thread Paul Durrant
Paul Durrant (2): docs/designs: Add a design document for non-cooperative live migration docs/designs: Add a design document for migration of xenstore data docs/designs/non-cooperative-migration.md | 280 ++ docs/designs/xenstore-migration.md| 256 +

[Xen-devel] [PATCH v8 1/2] docs/designs: Add a design document for non-cooperative live migration

2020-03-27 Thread Paul Durrant
From: Paul Durrant It has become apparent to some large cloud providers that the current model of cooperative migration of guests under Xen is not usable as it relies on software running inside the guest, which is likely beyond the provider's control. This patch introduces a proposal for non-coop

Re: [Xen-devel] [PATCH] automation: update openSUSE Tumbleweed building dependencies

2020-03-27 Thread Andrew Cooper
On 26/03/2020 17:29, Dario Faggioli wrote: > We need python3 (and the respective -devel package), these days. > > Signed-off-by: Dario Faggioli > --- > Cc: Doug Goldstein > --- > .../build/suse/opensuse-tumbleweed.dockerfile |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [Xen-devel] [PATCH 17/17] xen: Switch parameter in get_page_from_gfn to use typesafe gfn

2020-03-27 Thread Jan Beulich
On 22.03.2020 17:14, jul...@xen.org wrote: > --- a/xen/arch/x86/hvm/domain.c > +++ b/xen/arch/x86/hvm/domain.c > @@ -296,8 +296,10 @@ int arch_set_info_hvm_guest(struct vcpu *v, const > vcpu_hvm_context_t *ctx) > if ( hvm_paging_enabled(v) && !paging_mode_hap(v->domain) ) > { >

[Xen-devel] [xen-unstable-smoke test] 149087: tolerable all pass - PUSHED

2020-03-27 Thread osstest service owner
flight 149087 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/149087/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH 17/17] xen: Switch parameter in get_page_from_gfn to use typesafe gfn

2020-03-27 Thread Julien Grall
Hi Jan, On 27/03/2020 13:50, Jan Beulich wrote: On 22.03.2020 17:14, jul...@xen.org wrote: --- a/xen/arch/x86/hvm/domain.c +++ b/xen/arch/x86/hvm/domain.c @@ -296,8 +296,10 @@ int arch_set_info_hvm_guest(struct vcpu *v, const vcpu_hvm_context_t *ctx) if ( hvm_paging_enabled(v) && !paging

[Xen-devel] [PATCH v1] libxl: remove limit for default number of event channels

2020-03-27 Thread Olaf Hering
The imposed limit of 1023 is too low for a three digit value of vcpus. Remove the arbitrary value of 1023 and let Xen decide about the upper limit. Signed-off-by: Olaf Hering --- docs/man/xl.cfg.5.pod.in | 8 +++- tools/libxl/libxl_create.c | 2 +- 2 files changed, 4 insertions(+), 6 delet

Re: [Xen-devel] [PATCH v1] libxl: remove limit for default number of event channels

2020-03-27 Thread Ian Jackson
Olaf Hering writes ("[PATCH v1] libxl: remove limit for default number of event channels"): > The imposed limit of 1023 is too low for a three digit value of vcpus. > Remove the arbitrary value of 1023 and let Xen decide about the upper limit. This seems likely to be right, but: what is the defau

Re: [Xen-devel] [PATCH v1] libxl: remove limit for default number of event channels

2020-03-27 Thread Olaf Hering
On Fri, Mar 27, Ian Jackson wrote: > This seems likely to be right, but: what is the default in Xen ? Is > it sufficiently tight to stop a guest using too many resources ? The value of d->max_evtchns will be either 4k or 128k. AFAICS no extra resources are allocated with the changed value. Olaf

Re: [Xen-devel] [PATCH v1] libxl: remove limit for default number of event channels

2020-03-27 Thread Jan Beulich
On 27.03.2020 15:37, Olaf Hering wrote: > On Fri, Mar 27, Ian Jackson wrote: > >> This seems likely to be right, but: what is the default in Xen ? Is >> it sufficiently tight to stop a guest using too many resources ? > > The value of d->max_evtchns will be either 4k or 128k. > AFAICS no extra r

Re: [Xen-devel] [PATCH v1] libxl: remove limit for default number of event channels

2020-03-27 Thread Julien Grall
Hi, On 27/03/2020 14:37, Olaf Hering wrote: On Fri, Mar 27, Ian Jackson wrote: This seems likely to be right, but: what is the default in Xen ? Is it sufficiently tight to stop a guest using too many resources ? The value of d->max_evtchns will be either 4k or 128k. AFAICS no extra resource

Re: [Xen-devel] [PATCH v8 1/2] docs/designs: Add a design document for non-cooperative live migration

2020-03-27 Thread Julien Grall
Hi Paul, On 27/03/2020 13:46, Paul Durrant wrote: From: Paul Durrant It has become apparent to some large cloud providers that the current model of cooperative migration of guests under Xen is not usable as it relies on software running inside the guest, which is likely beyond the provider's c

Re: [Xen-devel] [PATCH v8 2/2] docs/designs: Add a design document for migration of xenstore data

2020-03-27 Thread Julien Grall
On 27/03/2020 13:46, Paul Durrant wrote: +The semantics of this are similar to the domain issuing +TRANSACTION_START and receiving the specified as the response. +The main difference is that the transaction will be immediately marked as +'conflicting' such that when the domain isses TRANSACTI

Re: [Xen-devel] [PATCH v8 2/2] docs/designs: Add a design document for migration of xenstore data

2020-03-27 Thread Paul Durrant
> -Original Message- > From: Julien Grall > Sent: 27 March 2020 16:58 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Paul Durrant ; Andrew Cooper > ; George Dunlap > ; Ian Jackson ; Jan > Beulich > ; Konrad Rzeszutek Wilk ; Stefano > Stabellini > ; Wei Liu > Subject: Re: [PA

[Xen-devel] [xen-unstable-smoke test] 149096: tolerable all pass - PUSHED

2020-03-27 Thread osstest service owner
flight 149096 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/149096/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[Xen-devel] [libvirt test] 149074: regressions - FAIL

2020-03-27 Thread osstest service owner
flight 149074 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/149074/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 146182 build-i386-libvirt

[Xen-devel] [OSSTEST PATCH 2/6] ts-logs-capture: Introduce @allguests containing even non-running

2020-03-27 Thread Ian Jackson
Nothing looks at this yet. Signed-off-by: Ian Jackson --- ts-logs-capture | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ts-logs-capture b/ts-logs-capture index d16372f2..88b19658 100755 --- a/ts-logs-capture +++ b/ts-logs-capture @@ -39,7 +39,7 @@ if (!$ho) { ex

[Xen-devel] [OSSTEST PATCH 1/6] TestSupport: export guest_find_lv

2020-03-27 Thread Ian Jackson
We'll need this in a moment. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 1c13e2af..5fb78468 100644 --- a/Osstest/TestSupport.pm +++ b/Osstest/TestSupport.pm @@ -114

[Xen-devel] [OSSTEST PATCH 5/6] ts-logs-capture: try_fetch_logs: Honour $fs_ and $out_prefix

2020-03-27 Thread Ian Jackson
This allows us to add some stuff to add to each pattern, and each filename. This will be useful in a moment. None of the call sites pass this yet. Signed-off-by: Ian Jackson --- ts-logs-capture | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/ts-logs-capture b/ts

[Xen-devel] [OSSTEST PATCH] README.dev: Suggest -P for commissioning flights

2020-03-27 Thread Ian Jackson
Signed-off-by: Ian Jackson --- README.dev | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.dev b/README.dev index e32889b7..2cbca109 100644 --- a/README.dev +++ b/README.dev @@ -115,7 +115,7 @@ and boot Xen: $ hn=mudcake $ flight=`./make-hosts-flight play xen-uns

[Xen-devel] [OSSTEST PATCH 4/6] ts-logs-capture: Move some general logs onto @general_logs

2020-03-27 Thread Ian Jackson
Now @general_logs contains logs we want from guests as well as hosts. Signed-off-by: Ian Jackson --- ts-logs-capture | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/ts-logs-capture b/ts-logs-capture index ae37d492..418155ce 100755 --- a/ts-logs-capture +++ b/ts-lo

[Xen-devel] [OSSTEST PATCH 3/6] ts-logs-capture: Break logs up into general logs and host logs

2020-03-27 Thread Ian Jackson
We are going to fetch logs out of guests. @general_logs will contain the relevant patterns. Right now we just introduce the variable and split the list. The categorisation is roughly right... Signed-off-by: Ian Jackson --- ts-logs-capture | 7 +-- 1 file changed, 5 insertions(+), 2 deleti

[Xen-devel] [OSSTEST PATCH 6/6] ts-logs-capture: Fish some logs out of guest filesystem

2020-03-27 Thread Ian Jackson
This involves shutting the guests down. We use this shell rune because xl doesn't provide a good way to ensure there are no guests running. Signed-off-by: Ian Jackson --- ts-logs-capture | 30 ++ 1 file changed, 30 insertions(+) diff --git a/ts-logs-capture b/ts-log

Re: [Xen-devel] [PATCH v5 01/10] x86emul: support AVX512_BF16 insns

2020-03-27 Thread Andrew Cooper
On 24/03/2020 12:30, Jan Beulich wrote: > --- a/tools/tests/x86_emulator/evex-disp8.c > +++ b/tools/tests/x86_emulator/evex-disp8.c > @@ -550,6 +550,12 @@ static const struct test avx512_4vnniw_5 > INSN(p4dpwssds, f2, 0f38, 53, el_4, d, vl), > }; > > +static const struct test avx512_bf16_al

[Xen-devel] [OSSTEST PATCH] ts-examine-hostprops-save: Save for commissioning flights too (!)

2020-03-27 Thread Ian Jackson
Signed-off-by: Ian Jackson --- ts-examine-hostprops-save | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ts-examine-hostprops-save b/ts-examine-hostprops-save index e50ea7fb..3995a7a7 100755 --- a/ts-examine-hostprops-save +++ b/ts-examine-hostprops-save @@ -31,8 +31,8 @@

[Xen-devel] [PATCH 3/5] tools/misc: add xen-ctx to present domain context

2020-03-27 Thread Paul Durrant
This tools is analogous to 'xen-hvmctx' which presents HVM context. Subsequent patches will add 'dump' functions when new records are introduced. Signed-off-by: Paul Durrant --- Cc: Ian Jackson Cc: Wei Liu --- .gitignore | 1 + tools/misc/Makefile | 4 ++ tools/misc/xen-ctx.c |

[Xen-devel] [PATCH 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

2020-03-27 Thread Paul Durrant
Domain context is state held in the hypervisor that does not come under the category of 'HVM state' but is instead 'PV state' that is common between PV guests and enlightened HVM guests (i.e. those that have PV drivers) such as event channel state, grant entry state, etc. To allow enlightened HVM

[Xen-devel] [PATCH 5/5] tools/libxc: make use of domain context SHARED_INFO record...

2020-03-27 Thread Paul Durrant
... in the save/restore code. This patch replaces direct mapping of the shared_info_frame (retrieved using XEN_DOMCTL_getdomaininfo) with save/load of the domain context SHARED_INFO record. No modifications are made to the definition of the migration stream at this point. Subsequent patches will

[Xen-devel] [PATCH 0/5] domain context infrastructure

2020-03-27 Thread Paul Durrant
Paul Durrant (5): xen/common: introduce a new framework for save/restore of 'domain' context xen/common/domctl: introduce XEN_DOMCTL_get/setdomaincontext tools/misc: add xen-ctx to present domain context common/domain: add a domain context record for shared_info... tools/libxc: make u

[Xen-devel] [PATCH 2/5] xen/common/domctl: introduce XEN_DOMCTL_get/setdomaincontext

2020-03-27 Thread Paul Durrant
These domctls provide a mechanism to get and set domain context from the toolstack. Signed-off-by: Paul Durrant --- Cc: Daniel De Graaf Cc: Ian Jackson Cc: Wei Liu Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini --- tools/flask/policy/modules/x

[Xen-devel] [PATCH 4/5] common/domain: add a domain context record for shared_info...

2020-03-27 Thread Paul Durrant
... and update xen-ctx to dump some information describing the record. NOTE: To allow a sensible definition of the record in public/save.h this patch also adds a definition of the Xen ABI's de-facto page size into public/xen.h. Signed-off-by: Paul Durrant --- Cc: Ian Jackson Cc: Wei

[Xen-devel] [PATCH 1/3] xen/x86: ioapic: Use true/false in bad_ioapic_register()

2020-03-27 Thread Julien Grall
From: Julien Grall bad_ioapic_register() is return a bool, so we should switch to true/false. Signed-off-by: Julien Grall --- xen/arch/x86/io_apic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index e98e08e9c8..9868933

[Xen-devel] [PATCH 3/3] xen/x86: ioapic: Simplify ioapic_init()

2020-03-27 Thread Julien Grall
From: Julien Grall Since commit 9facd54a45 "x86/ioapic: Add register level checks to detect bogus io-apic entries", Xen is able to cope with IO APICs not mapped in the fixmap. Therefore the whole logic to allocate a fake page for some IO APICs is unnecessary. With the logic removed, the code ca

[Xen-devel] [PATCH 2/3] xen/x86: ioapic: Rename init_ioapic_mappings() to init_ioapic()

2020-03-27 Thread Julien Grall
From: Julien Grall The function init_ioapic_mappings() is doing more than initialization mappings. It is also initialization the number of IRQs/GSIs supported. So rename the function to init_ioapic(). This will allow us to re-use the name in a follow-up patch. Signed-off-by: Julien Grall ---

[Xen-devel] [PATCH 0/3] xen/x86: Simplify ioapic_init()

2020-03-27 Thread Julien Grall
From: Julien Grall Hi all, The main goal of this small series is to simplify ioapic_init(). Cheers, Julien Grall (3): xen/x86: ioapic: Use true/false in bad_ioapic_register() xen/x86: ioapic: Rename init_ioapic_mappings() to init_ioapic() xen/x86: ioapic: Simplify ioapic_init() xen/arc

[Xen-devel] [ovmf test] 149071: all pass - PUSHED

2020-03-27 Thread osstest service owner
flight 149071 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/149071/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 695d90b9b156573d0dafb20afecea09dc9a914f4 baseline version: ovmf f52b30e73ddee9a3a609a

[Xen-devel] [PATCH] sched/core: Fix bug when moving a domain between cpupools

2020-03-27 Thread Jeff Kubascik
For each UNIT, sched_set_affinity is called before unit->priv is updated to the new cpupool private UNIT data structure. The issue is sched_set_affinity will call the adjust_affinity method of the cpupool. If defined, the new cpupool may use unit->priv (e.g. credit), which at this point still refer

[Xen-devel] [xen-unstable-smoke test] 149110: tolerable all pass - PUSHED

2020-03-27 Thread osstest service owner
flight 149110 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/149110/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] PCIe IOMMU ACS support

2020-03-27 Thread Roman Shaposhnik
On Fri, Mar 27, 2020 at 2:12 AM Paul Durrant wrote: > > > -Original Message- > > From: Roman Shaposhnik > > Sent: 26 March 2020 22:03 > > To: Roger Pau Monné > > Cc: xen-devel@lists.xenproject.org; Jan Beulich ; Paul > > Durrant ; > > Kevin Tian ; Andrew Cooper > > Subject: Re: [Xen-de

[Xen-devel] [seabios test] 149072: regressions - FAIL

2020-03-27 Thread osstest service owner
flight 149072 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/149072/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 148666 Tests which did

[Xen-devel] [xen-unstable test] 149068: regressions - trouble: fail/pass/starved

2020-03-27 Thread osstest service owner
flight 149068 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/149068/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-intel 16 guest-localmigrate fail REGR. vs. 148925 Tests which did no

[Xen-devel] [PATCH] xen/x86: Remove unnecessary cast on void pointer

2020-03-27 Thread Simran Singhal
Assignment to a typed pointer is sufficient in C. No cast is needed. Signed-off-by: Simran Singhal --- xen/arch/x86/acpi/cpufreq/powernow.c | 2 +- xen/arch/x86/cpu/vpmu.c | 2 +- xen/arch/x86/hpet.c | 2 +- xen/arch/x86/hvm/save.c | 2 +- xen/arch/x86/