[Xen-devel] [linux-4.14 test] 148232: regressions - FAIL

2020-03-09 Thread osstest service owner
flight 148232 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148232/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 142849 test-armhf-armhf-xl-

Re: [Xen-devel] [PATCH] x86/cpuid: Untangle Invariant TSC handling

2020-03-09 Thread Jan Beulich
On 06.03.2020 18:48, Andrew Cooper wrote: > On 05/03/2020 08:20, Jan Beulich wrote: >> On 04.03.2020 19:40, Andrew Cooper wrote: >>> On 04/03/2020 10:25, Jan Beulich wrote: Actually looking at the change to libxl__cpuid_legacy() I wonder whether you don't instead mean "requests vTSC"

Re: [Xen-devel] [PATCH 2/2] domain: use PGC_extra domheap page for shared_info

2020-03-09 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 06 March 2020 17:17 > To: Paul Durrant > Cc: sstabell...@kernel.org; jul...@xen.org; volodymyr_babc...@epam.com; > w...@xen.org; > konrad.w...@oracle.com; andrew.coop...@citrix.com; ian.jack...@eu.citrix.com; > george.dun...@citrix.com; xe

Re: [Xen-devel] [PATCH 2/2] domain: use PGC_extra domheap page for shared_info

2020-03-09 Thread Jan Beulich
On 09.03.2020 09:48, Paul Durrant wrote: >> -Original Message- >> From: Jan Beulich >> Sent: 06 March 2020 17:17 >> To: Paul Durrant >> Cc: sstabell...@kernel.org; jul...@xen.org; volodymyr_babc...@epam.com; >> w...@xen.org; >> konrad.w...@oracle.com; andrew.coop...@citrix.com; ian.jack.

Re: [Xen-devel] [PATCH v2 2/2] AMD/IOMMU: without XT, x2APIC needs to be forced into physical mode

2020-03-09 Thread Jan Beulich
On 28.02.2020 13:12, Jan Beulich wrote: > The wider cluster mode APIC IDs aren't generally representable. Convert > the iommu_intremap variable into a tristate, allowing the AMD IOMMU > driver to signal this special restriction to the apic_x2apic_probe(). > (Note: assignments to the variable get ad

[Xen-devel] [PATCH v4] x86: clear RDRAND CPUID bit on AMD family 15h/16h

2020-03-09 Thread Jan Beulich
Inspired by Linux commit c49a0a80137c7ca7d6ced4c812c9e07a949f6f24: There have been reports of RDRAND issues after resuming from suspend on some AMD family 15h and family 16h systems. This issue stems from a BIOS not performing the proper steps during resume to ensure RDRAND continues

[Xen-devel] [PATCH v4 1/6] domain: introduce alloc/free_shared_info() helpers...

2020-03-09 Thread paul
From: Paul Durrant ... and save the MFN. This patch modifies the 'shared_info' field of struct domain to be a structure comprising an MFN and a virtual address. Allocations are still done from xenheap, so the virtual address still equates to virt_to_mfn() called on the MFN but subsequent patch w

[Xen-devel] [PATCH v4 0/6] remove one more shared xenheap page: shared_info

2020-03-09 Thread paul
From: Paul Durrant Paul Durrant (6): domain: introduce alloc/free_shared_info() helpers... x86 / p2m: remove page_list check in p2m_alloc_table... x86 / pv: do not treat PGC_extra pages as RAM x86 / ioreq: use a MEMF_no_refcount allocation for server pages... mm: add 'is_special_page' i

[Xen-devel] [PATCH v4 3/6] x86 / pv: do not treat PGC_extra pages as RAM

2020-03-09 Thread paul
From: Paul Durrant This patch modifies several places walking the domain's page_list to make them ignore PGC_extra pages: - dump_pageframe_info() should ignore PGC_extra pages in its dump as it determines whether to dump using domain_tot_pages() which also ignores PGC_extra pages. - arch_se

[Xen-devel] [PATCH v4 5/6] mm: add 'is_special_page' inline function...

2020-03-09 Thread paul
From: Paul Durrant ... to cover xenheap and PGC_extra pages. PGC_extra pages are intended to hold data structures that are associated with a domain and may be mapped by that domain. They should not be treated as 'normal' guest pages (i.e. RAM or page tables). Hence, in many cases where code curr

[Xen-devel] [PATCH v4 6/6] domain: use PGC_extra domheap page for shared_info

2020-03-09 Thread paul
From: Paul Durrant Currently shared_info is a shared xenheap page but shared xenheap pages complicate future plans for live-update of Xen so it is desirable to, where possible, not use them [1]. This patch therefore converts shared_info into a PGC_extra domheap page. This does entail freeing shar

[Xen-devel] [PATCH v4 4/6] x86 / ioreq: use a MEMF_no_refcount allocation for server pages...

2020-03-09 Thread paul
From: Paul Durrant ... now that it is safe to assign them. This avoids relying on libxl (or whatever toolstack is in use) setting max_pages up with sufficient 'slop' to allow all necessary ioreq server pages to be allocated. Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich --- Cc: Andrew

[Xen-devel] [PATCH v4 2/6] x86 / p2m: remove page_list check in p2m_alloc_table...

2020-03-09 Thread paul
From: Paul Durrant ... and replace with a check of domain_tot_pages(). The check of page_list prevents the prior allocation of PGC_extra pages, whereas what the code is trying to verify is that the toolstack has not already RAM for the domain. Signed-off-by: Paul Durrant --- Cc: Jan Beulich C

Re: [Xen-devel] [RFC PATCH v3 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2020-03-09 Thread Roger Pau Monné
On Fri, Mar 06, 2020 at 06:40:33PM +, Anchal Agarwal wrote: > On Fri, Feb 21, 2020 at 03:24:45PM +0100, Roger Pau Monné wrote: > > On Fri, Feb 14, 2020 at 11:25:34PM +, Anchal Agarwal wrote: > > > blkfront_gather_backend_features(info); > > > /* Reset limits changed by blk_mq_update_nr_

Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-09 Thread Markus Armbruster
Suggest scripts: Coccinelle script to use auto-propagated errp or scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE() Vladimir Sementsov-Ogievskiy writes: > Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and > does corresponding changes in code (look for detail

Re: [Xen-devel] [PATCH v4 2/6] x86 / p2m: remove page_list check in p2m_alloc_table...

2020-03-09 Thread Jan Beulich
On 09.03.2020 10:35, p...@xen.org wrote: > From: Paul Durrant > > ... and replace with a check of domain_tot_pages(). > > The check of page_list prevents the prior allocation of PGC_extra pages, > whereas what the code is trying to verify is that the toolstack has not > already RAM for the domai

Re: [Xen-devel] [PATCH v4 2/6] x86 / p2m: remove page_list check in p2m_alloc_table...

2020-03-09 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 09 March 2020 09:59 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; Paul Durrant ; > Andrew Cooper > ; George Dunlap ; Wei > Liu ; Roger Pau > Monné > Subject: Re: [PATCH v4 2/6] x86 / p2m: remove page_list check in > p2m_alloc_

Re: [Xen-devel] [PATCH v4 6/6] domain: use PGC_extra domheap page for shared_info

2020-03-09 Thread Durrant, Paul
> -Original Message- > From: p...@xen.org > Sent: 09 March 2020 09:35 > To: xen-devel@lists.xenproject.org > Cc: Durrant, Paul ; Paul Durrant ; > Stefano Stabellini > ; Julien Grall ; Volodymyr Babchuk > ; Andrew Cooper ; > George Dunlap > ; Ian Jackson ; Jan > Beulich ; > Konrad Rzeszu

[Xen-devel] [PATCH v5 0/6] remove one more shared xenheap page: shared_info

2020-03-09 Thread paul
From: Paul Durrant Paul Durrant (6): domain: introduce alloc/free_shared_info() helpers... x86 / p2m: replace page_list check in p2m_alloc_table... x86 / pv: do not treat PGC_extra pages as RAM x86 / ioreq: use a MEMF_no_refcount allocation for server pages... mm: add 'is_special_page'

[Xen-devel] [PATCH v5 3/6] x86 / pv: do not treat PGC_extra pages as RAM

2020-03-09 Thread paul
From: Paul Durrant This patch modifies several places walking the domain's page_list to make them ignore PGC_extra pages: - dump_pageframe_info() should ignore PGC_extra pages in its dump as it determines whether to dump using domain_tot_pages() which also ignores PGC_extra pages. - arch_se

[Xen-devel] [PATCH v5 2/6] x86 / p2m: replace page_list check in p2m_alloc_table...

2020-03-09 Thread paul
From: Paul Durrant ... with a check of domain_tot_pages(). The check of page_list prevents the prior allocation of PGC_extra pages, whereas what the code is trying to verify is that the toolstack has not already RAM for the domain. Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich --- Cc:

[Xen-devel] [PATCH v5 6/6] domain: use PGC_extra domheap page for shared_info

2020-03-09 Thread paul
From: Paul Durrant Currently shared_info is a shared xenheap page but shared xenheap pages complicate future plans for live-update of Xen so it is desirable to, where possible, not use them [1]. This patch therefore converts shared_info into a PGC_extra domheap page. This does entail freeing shar

[Xen-devel] [PATCH v5 1/6] domain: introduce alloc/free_shared_info() helpers...

2020-03-09 Thread paul
From: Paul Durrant ... and save the MFN. This patch modifies the 'shared_info' field of struct domain to be a structure comprising an MFN and a virtual address. Allocations are still done from xenheap, so the virtual address still equates to virt_to_mfn() called on the MFN but subsequent patch w

[Xen-devel] [PATCH v5 4/6] x86 / ioreq: use a MEMF_no_refcount allocation for server pages...

2020-03-09 Thread paul
From: Paul Durrant ... now that it is safe to assign them. This avoids relying on libxl (or whatever toolstack is in use) setting max_pages up with sufficient 'slop' to allow all necessary ioreq server pages to be allocated. Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich --- Cc: Andrew

[Xen-devel] [PATCH v5 5/6] mm: add 'is_special_page' inline function...

2020-03-09 Thread paul
From: Paul Durrant ... to cover xenheap and PGC_extra pages. PGC_extra pages are intended to hold data structures that are associated with a domain and may be mapped by that domain. They should not be treated as 'normal' guest pages (i.e. RAM or page tables). Hence, in many cases where code curr

[Xen-devel] [PATCH v2 0/5] IOMMU: restrict visibility/scope if certain variables

2020-03-09 Thread Jan Beulich
A number of the command line controlled variables are x86- or even x86-HVM-specific. Don't have those variables elsewhere in the first place (in some cases replace them by a #define), and as a result also don't silently accept such "iommu=" sub-options which in fact have no effect. 1: iommu_intrem

[Xen-devel] [PATCH v2 1/5] IOMMU: iommu_intremap is x86-only

2020-03-09 Thread Jan Beulich
Provide a #define for other cases; it didn't seem worthwhile to me to introduce an IOMMU_INTREMAP Kconfig option at this point. Signed-off-by: Jan Beulich --- v2: Refine doc adjustment. --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1299,6 +1299,8 @@ boolean

[Xen-devel] [PATCH v2 2/5] IOMMU: iommu_intpost is x86/HVM-only

2020-03-09 Thread Jan Beulich
Provide a #define for all other cases. Signed-off-by: Jan Beulich --- v2: Refine doc adjustment. --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1309,6 +1309,8 @@ boolean (e.g. `iommu=no`) can override t This option depends on `intremap`, and is disabled

[Xen-devel] [PATCH v2 3/5] IOMMU: iommu_igfx is x86-only

2020-03-09 Thread Jan Beulich
In fact it's VT-d specific, but we don't have a way yet to build code for just one vendor. Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -32,7 +32,6 @@ bool_t __read_mostly iommu_enabled; bool_t __read_mostly force_iommu; bool_t __rea

[Xen-devel] [PATCH v2 4/5] IOMMU: iommu_qinval is x86-only

2020-03-09 Thread Jan Beulich
In fact it's VT-d specific, but we don't have a way yet to build code for just one vendor. Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -33,7 +33,6 @@ bool_t __read_mostly force_iommu; bool_t __read_mostly iommu_verbose; bool __read_

[Xen-devel] [PATCH v2 5/5] IOMMU: iommu_snoop is x86-only

2020-03-09 Thread Jan Beulich
In fact it's VT-d specific, but we don't have a way yet to build code for just one vendor. Provide a #define for the opposite case. Signed-off-by: Jan Beulich --- v2: The option isn't HVM-specific, after all. --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -32,7 +3

[Xen-devel] xen-4.13 tools/xentop.c backport request

2020-03-09 Thread Sander Eikelenboom
Hi Ian, If I'm not mistaken you do the tools backports. I just noticed that the problem that is fixed by commit: 4b5b431edd984b26f43b3efc7de465f3560a949e tools/xentop: Fix calculation of used memory is already present in the xen-4.13 branch (older releases are uneffected). Unfortunately I didn

[Xen-devel] [PATCH v3] IOMMU: make DMA containment of quarantined devices optional

2020-03-09 Thread Jan Beulich
Containing still in flight DMA was introduced to work around certain devices / systems hanging hard upon hitting a "not-present" IOMMU fault. Passing through (such) devices (on such systems) is inherently insecure (as guests could easily arrange for IOMMU faults of any kind to occur). Defaulting to

Re: [Xen-devel] [PATCH OSSTEST] make-flight: add dom0 PVH test

2020-03-09 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH OSSTEST] make-flight: add dom0 PVH test"): > Add a dom0 PVH test, the test to be run is launching a PV guest > (test-debian). Note the PVH dom0 tests are only enabled for Xen >= > 4.13. Reviewed-by: Ian Jackson Thanks! Ian. __

Re: [Xen-devel] [XEN PATCH v2 1/2] xen/arm: Rename all early printk macro

2020-03-09 Thread Anthony PERARD
On Fri, Mar 06, 2020 at 03:57:23PM -0800, Stefano Stabellini wrote: > On Fri, 6 Mar 2020, Anthony PERARD wrote: > > We also reuse CONFIG_EARLY_PRINTK provided by users to enable or not > > early printk, thus we need to override the value in makefile. > > > > Signed-off-by: Anthony PERARD > > I t

Re: [Xen-devel] [PATCH v6 01/12] xen: allow only sizeof(bool) variables for boolean_param()

2020-03-09 Thread Julien Grall
Hi Juergen, On 26/02/2020 12:46, Juergen Gross wrote: Support of other variable sizes than that of normal bool ones for boolean_parameter() don't make sense, so catch any other sized variables at build time. Fix the one parameter using a plain int instead of bool. Signed-off-by: Juergen Gross

Re: [Xen-devel] [PATCH v6 03/12] docs: add feature document for Xen hypervisor sysfs-like support

2020-03-09 Thread Julien Grall
Hi Juergen, On 26/02/2020 12:46, Juergen Gross wrote: On the 2019 Xen developer summit there was agreement that the Xen hypervisor should gain support for a hierarchical name-value store similar to the Linux kernel's sysfs. In the beginning there should only be basic support: entries can be add

[Xen-devel] [PATCH] memaccess: reduce include dependencies

2020-03-09 Thread Jan Beulich
The common header doesn't itself need to include public/vm_event.h nor public/memory.h. Drop their inclusion. This requires using the non- typedef names in two prototypes and an inline function; by not changing the callers and function definitions at the same time it'll remain certain that the buil

[Xen-devel] [PATCH] vmevent: reduce include dependencies

2020-03-09 Thread Jan Beulich
There's no need for virtually everything to include public/vm_event.h. Move its inclusion out of sched.h. This requires using the non-typedef name in p2m_mem_paging_resume()'s prototype; by not changing the function definition at the same time it'll remain certain that the build would fail if the t

Re: [Xen-devel] [PATCH v6 01/12] xen: allow only sizeof(bool) variables for boolean_param()

2020-03-09 Thread Jan Beulich
On 09.03.2020 12:43, Julien Grall wrote: > On 26/02/2020 12:46, Juergen Gross wrote: >> @@ -46,7 +48,8 @@ extern const struct kernel_param __param_start[], >> __param_end[]; >> __kparam __setup_##_var = \ >> { .name = __setup_str_##_var, \ >> .type = OPT_BOOL, \ >> -

Re: [Xen-devel] [PATCH] vmevent: reduce include dependencies

2020-03-09 Thread Ross Lagerwall
On 3/9/20 11:51 AM, Jan Beulich wrote: > There's no need for virtually everything to include public/vm_event.h. > Move its inclusion out of sched.h. This requires using the non-typedef > name in p2m_mem_paging_resume()'s prototype; by not changing the > function definition at the same time it'll re

Re: [Xen-devel] [PATCH 00/20] hw: Clean up hw/i386 headers (and few alpha/hppa)

2020-03-09 Thread Laurent Vivier
Le 27/02/2020 à 14:28, Paolo Bonzini a écrit : > On 26/10/19 15:32, Laurent Vivier wrote: >> Le 26/10/2019 à 14:20, Philippe Mathieu-Daudé a écrit : >>> Hi, >>> >>> On 10/14/19 4:22 PM, Philippe Mathieu-Daudé wrote: This is a follow-up of Markus's cleanup series: Tame a few "touch this, r

[Xen-devel] [PATCH 0/9] x86: reduce include dependencies

2020-03-09 Thread Jan Beulich
In a number of cases I've noticed the x86 emulator, which is quite slow to build especially with not very new gcc, to re-build when having changed headers which I wouldn't have expected to be included there in the first place. Hence I've gone through the dependencies of that object file and tried t

Re: [Xen-devel] [XEN PATCH v2 1/2] xen/arm: Rename all early printk macro

2020-03-09 Thread Anthony PERARD
On Sun, Mar 08, 2020 at 05:57:32PM +, Julien Grall wrote: > On 06/03/2020 17:42, Anthony PERARD wrote: > > We also reuse CONFIG_EARLY_PRINTK provided by users to enable or not > > early printk, thus we need to override the value in makefile. [...] > > ifneq ($(EARLY_PRINTK_INC),) > > -EARLY_P

[Xen-devel] [PATCH 1/9] x86/HVM: reduce domain.h include dependencies

2020-03-09 Thread Jan Beulich
Drop #include-s not needed by the header itself. Put the ones needed into whichever other files actually need them. Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/mcheck/vmce.c +++ b/xen/arch/x86/cpu/mcheck/vmce.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #incl

[Xen-devel] [PATCH 4/9] x86/HVM: reduce vpic.h include dependencies

2020-03-09 Thread Jan Beulich
Drop an #include not needed by the header itself. Signed-off-by: Jan Beulich --- a/xen/include/asm-x86/hvm/vpic.h +++ b/xen/include/asm-x86/hvm/vpic.h @@ -27,7 +27,8 @@ #ifndef __ASM_X86_HVM_VPIC_H__ #define __ASM_X86_HVM_VPIC_H__ -#include +struct domain; +struct vcpu; void vpic_irq_pos

[Xen-devel] [PATCH 3/9] x86/HVM: reduce vpt.h include dependencies

2020-03-09 Thread Jan Beulich
Drop #include-s not needed by the header itself. Signed-off-by: Jan Beulich --- a/xen/include/asm-x86/hvm/vpt.h +++ b/xen/include/asm-x86/hvm/vpt.h @@ -19,16 +19,9 @@ #ifndef __ASM_X86_HVM_VPT_H__ #define __ASM_X86_HVM_VPT_H__ -#include -#include -#include -#include -#include #include

[Xen-devel] [PATCH 2/9] x86/HVM: reduce vcpu.h include dependencies

2020-03-09 Thread Jan Beulich
Drop #include-s not needed by the header itself. Put the ones needed into whichever other files actually need them. Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include --- a/

[Xen-devel] [PATCH 5/9] x86/HVM: reduce vioapic.h include dependencies

2020-03-09 Thread Jan Beulich
Drop an #include not needed by the header itself. While verifyin the header (now) builds standalone, I noticed an omission in a public header which gets taken care of here as well. Signed-off-by: Jan Beulich --- a/xen/include/asm-x86/hvm/vioapic.h +++ b/xen/include/asm-x86/hvm/vioapic.h @@ -25,7

[Xen-devel] [PATCH 6/9] x86/HVM: reduce vlapic.h include dependencies

2020-03-09 Thread Jan Beulich
Drop #include-s not needed by the header itself. Signed-off-by: Jan Beulich --- a/xen/include/asm-x86/hvm/vlapic.h +++ b/xen/include/asm-x86/hvm/vlapic.h @@ -21,8 +21,6 @@ #define __ASM_X86_HVM_VLAPIC_H__ #include -#include -#include #include #define vcpu_vlapic(x) (&(x)->arch.hvm.

[Xen-devel] [PATCH 7/9] x86/HVM: reduce io.h include dependencies

2020-03-09 Thread Jan Beulich
Drop #include-s not needed by the header itself as well as one include of the header which isn't needed. Put the one needed into the file actually requiring it. Signed-off-by: Jan Beulich --- a/xen/include/asm-x86/hvm/io.h +++ b/xen/include/asm-x86/hvm/io.h @@ -19,12 +19,8 @@ #ifndef __ASM_X86_

[Xen-devel] [PATCH 8/9] x86/HVM: reduce hvm.h include dependencies

2020-03-09 Thread Jan Beulich
Drop #include-s not needed by the header itself, and add smaller scope ones instead. Put the ones needed into whichever other files actually need them. Signed-off-by: Jan Beulich --- a/xen/include/asm-x86/hvm/emulate.h +++ b/xen/include/asm-x86/hvm/emulate.h @@ -13,6 +13,7 @@ #define __ASM_X86_

[Xen-devel] [PATCH 9/9] x86: reduce mce.h include dependencies

2020-03-09 Thread Jan Beulich
Drop the public header #include as not needed by the header itself. Add one that was missing, and move all inside the inclusion guard. Signed-off-by: Jan Beulich --- a/xen/include/asm-x86/mce.h +++ b/xen/include/asm-x86/mce.h @@ -1,8 +1,9 @@ -#include -#include #ifndef _XEN_X86_MCE_H #define

[Xen-devel] [xen-unstable test] 148236: regressions - FAIL

2020-03-09 Thread osstest service owner
flight 148236 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/148236/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-amd 12 guest-start/redhat.repeat fail REGR. vs. 148098 Tests whic

Re: [Xen-devel] [PATCH v6 01/12] xen: allow only sizeof(bool) variables for boolean_param()

2020-03-09 Thread Jürgen Groß
On 09.03.20 12:55, Jan Beulich wrote: On 09.03.2020 12:43, Julien Grall wrote: On 26/02/2020 12:46, Juergen Gross wrote: @@ -46,7 +48,8 @@ extern const struct kernel_param __param_start[], __param_end[]; __kparam __setup_##_var = \ { .name = __setup_str_##_var, \

Re: [Xen-devel] [PATCH v5 3/6] x86 / pv: do not treat PGC_extra pages as RAM

2020-03-09 Thread Jan Beulich
On 09.03.2020 11:23, p...@xen.org wrote: > From: Paul Durrant > > This patch modifies several places walking the domain's page_list to make > them ignore PGC_extra pages: > > - dump_pageframe_info() should ignore PGC_extra pages in its dump as it > determines whether to dump using domain_tot_p

Re: [Xen-devel] [PATCH v6 01/12] xen: allow only sizeof(bool) variables for boolean_param()

2020-03-09 Thread Jan Beulich
On 09.03.2020 14:01, Jürgen Groß wrote: > On 09.03.20 12:55, Jan Beulich wrote: >> On 09.03.2020 12:43, Julien Grall wrote: >>> On 26/02/2020 12:46, Juergen Gross wrote: @@ -46,7 +48,8 @@ extern const struct kernel_param __param_start[], __param_end[]; __kparam __setup_##_var

Re: [Xen-devel] [PATCH v5 5/6] mm: add 'is_special_page' inline function...

2020-03-09 Thread Jan Beulich
On 09.03.2020 11:23, p...@xen.org wrote: > v4: > - Use inline function instead of macro > - Add missing conversions from is_xen_heap_page() Among these also one conversion of is_xen_heap_mfn(). I'm still curious why others wouldn't need converting - the description doesn't mention there are more

Re: [Xen-devel] [PATCH 1/9] x86/HVM: reduce domain.h include dependencies

2020-03-09 Thread Andrew Cooper
On 09/03/2020 12:06, Jan Beulich wrote: > Drop #include-s not needed by the header itself. Put the ones needed > into whichever other files actually need them. > > Signed-off-by: Jan Beulich Having attempted to compile this myself, you're at a minimum missing Flask, viridian, general HVM (because

[Xen-devel] [xen-unstable-smoke test] 148301: tolerable all pass - PUSHED

2020-03-09 Thread osstest service owner
flight 148301 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/148301/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH 1/9] x86/HVM: reduce domain.h include dependencies

2020-03-09 Thread Jan Beulich
On 09.03.2020 14:33, Andrew Cooper wrote: > On 09/03/2020 12:06, Jan Beulich wrote: >> Drop #include-s not needed by the header itself. Put the ones needed >> into whichever other files actually need them. >> >> Signed-off-by: Jan Beulich > > Having attempted to compile this myself, you're at a m

Re: [Xen-devel] [PATCH v6 01/12] xen: allow only sizeof(bool) variables for boolean_param()

2020-03-09 Thread Jürgen Groß
On 09.03.20 14:06, Jan Beulich wrote: On 09.03.2020 14:01, Jürgen Groß wrote: On 09.03.20 12:55, Jan Beulich wrote: On 09.03.2020 12:43, Julien Grall wrote: On 26/02/2020 12:46, Juergen Gross wrote: @@ -46,7 +48,8 @@ extern const struct kernel_param __param_start[], __param_end[]; __

Re: [Xen-devel] [PATCH 1/9] x86/HVM: reduce domain.h include dependencies

2020-03-09 Thread Jan Beulich
On 09.03.2020 14:33, Andrew Cooper wrote: > On 09/03/2020 12:06, Jan Beulich wrote: >> Drop #include-s not needed by the header itself. Put the ones needed >> into whichever other files actually need them. >> >> Signed-off-by: Jan Beulich > > Having attempted to compile this myself, you're at a m

Re: [Xen-devel] [PATCH] vmevent: reduce include dependencies

2020-03-09 Thread Isaila Alexandru
On 09.03.2020 13:51, Jan Beulich wrote: There's no need for virtually everything to include public/vm_event.h. Move its inclusion out of sched.h. This requires using the non-typedef name in p2m_mem_paging_resume()'s prototype; by not changing the function definition at the same time it'll remai

Re: [Xen-devel] [PATCH v2] golang/xenlight: implement constructor generation

2020-03-09 Thread George Dunlap
On 3/2/20 8:10 PM, Nick Rosbrook wrote: > Generate constructors for generated Go types. Call libxl__init so > the Go type can be properly initialized. > > If a type has a keyed union field, add a parameter to the function > signature to set the key variable, and call the init function for the > ke

[Xen-devel] [PATCH v4 3/3] golang/xenlight: Implement DomainCreateNew

2020-03-09 Thread George Dunlap
This implements the wrapper around libxl_domain_create_new(). With the previous changes, it's now possible to create a domain using the golang bindings (although not yet to unpause it or harvest it after it shuts down). Signed-off-by: George Dunlap --- v4: - Remove hand-crafted constructor code,

[Xen-devel] [PATCH v4 2/3] golang/xenlight: Notify xenlight of SIGCHLD

2020-03-09 Thread George Dunlap
libxl forks external processes and waits for them to complete; it therefore needs to be notified when children exit. In absence of instructions to the contrary, libxl sets up its own SIGCHLD handlers. Golang always unmasks and handles SIGCHLD itself. libxl thankfully notices this and throws an a

[Xen-devel] [PATCH v4 1/3] golang/xenlight: Don't try to marshall zero-length arrays in fromC

2020-03-09 Thread George Dunlap
The current fromC array code will do the "magic" casting and martialling even when num_foo variable is 0. Go crashes when doing the cast. Only do array marshalling if the number of elements is non-zero; otherwise, leave the target pointer empty (nil for Go slices, NULL for C arrays). Signed-off-

Re: [Xen-devel] [XEN PATCH v2 2/2] xen/arm: Configure early printk via Kconfig

2020-03-09 Thread Anthony PERARD
On Sun, Mar 08, 2020 at 06:29:02PM +, Julien Grall wrote: > On 06/03/2020 17:42, Anthony PERARD wrote: > > - - pl011,, > > -- is, optionally a baud rate which should be used to > > - configure the UART at start of day. > > - > > - If is not given then the code will not try to >

[Xen-devel] [linux-4.9 test] 148241: regressions - FAIL

2020-03-09 Thread osstest service owner
flight 148241 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148241/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 142947 Tests which d

Re: [Xen-devel] [PATCH] vmevent: reduce include dependencies

2020-03-09 Thread Tamas K Lengyel
On Mon, Mar 9, 2020 at 5:51 AM Jan Beulich wrote: > > There's no need for virtually everything to include public/vm_event.h. > Move its inclusion out of sched.h. This requires using the non-typedef > name in p2m_mem_paging_resume()'s prototype; by not changing the > function definition at the same

Re: [Xen-devel] [PATCH] memaccess: reduce include dependencies

2020-03-09 Thread Tamas K Lengyel
On Mon, Mar 9, 2020 at 5:49 AM Jan Beulich wrote: > > The common header doesn't itself need to include public/vm_event.h nor > public/memory.h. Drop their inclusion. This requires using the non- > typedef names in two prototypes and an inline function; by not changing > the callers and function de

Re: [Xen-devel] [PATCH] memaccess: reduce include dependencies

2020-03-09 Thread Jan Beulich
On 09.03.2020 16:07, Tamas K Lengyel wrote: > On Mon, Mar 9, 2020 at 5:49 AM Jan Beulich wrote: >> >> The common header doesn't itself need to include public/vm_event.h nor >> public/memory.h. Drop their inclusion. This requires using the non- >> typedef names in two prototypes and an inline funct

Re: [Xen-devel] [PATCH] memaccess: reduce include dependencies

2020-03-09 Thread Andrew Cooper
On 09/03/2020 15:10, Jan Beulich wrote: > On 09.03.2020 16:07, Tamas K Lengyel wrote: >> On Mon, Mar 9, 2020 at 5:49 AM Jan Beulich wrote: >>> The common header doesn't itself need to include public/vm_event.h nor >>> public/memory.h. Drop their inclusion. This requires using the non- >>> typedef

[Xen-devel] [OSSTEST PATCH] ts-*logs*: Capture xl dmesg, and save it from host examination

2020-03-09 Thread Ian Jackson
CC: Roger Pau Monné CC: Andrew Cooper Signed-off-by: Ian Jackson --- ts-examine-logs-save | 3 ++- ts-logs-capture | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/ts-examine-logs-save b/ts-examine-logs-save index 0c97330b..58823620 100755 --- a/ts-examine-logs-save +++

Re: [Xen-devel] [PATCH] memaccess: reduce include dependencies

2020-03-09 Thread Tamas K Lengyel
On Mon, Mar 9, 2020 at 5:49 AM Jan Beulich wrote: > > The common header doesn't itself need to include public/vm_event.h nor > public/memory.h. Drop their inclusion. This requires using the non- > typedef names in two prototypes and an inline function; by not changing > the callers and function de

[Xen-devel] [PATCH] xen/xenbus: remove unused xenbus_map_ring()

2020-03-09 Thread Juergen Gross
xenbus_map_ring() is used nowhere in the tree, remove it. xenbus_unmap_ring() is used only locally, so make it static and move it up. Signed-off-by: Juergen Gross --- drivers/xen/xenbus/xenbus_client.c | 126 + include/xen/xenbus.h | 7 --- 2 f

Re: [Xen-devel] [PATCH v5 6/6] domain: use PGC_extra domheap page for shared_info

2020-03-09 Thread Jan Beulich
On 09.03.2020 11:23, p...@xen.org wrote: > From: Paul Durrant > > Currently shared_info is a shared xenheap page but shared xenheap pages > complicate future plans for live-update of Xen so it is desirable to, > where possible, not use them [1]. This patch therefore converts shared_info > into a

Re: [Xen-devel] [PATCH] memaccess: reduce include dependencies

2020-03-09 Thread Jan Beulich
On 09.03.2020 16:51, Tamas K Lengyel wrote: > On Mon, Mar 9, 2020 at 5:49 AM Jan Beulich wrote: >> --- a/xen/include/asm-arm/mem_access.h >> +++ b/xen/include/asm-arm/mem_access.h >> @@ -17,9 +17,11 @@ >> #ifndef _ASM_ARM_MEM_ACCESS_H >> #define _ASM_ARM_MEM_ACCESS_H >> >> +struct vm_event_st; >

Re: [Xen-devel] [PATCH] memaccess: reduce include dependencies

2020-03-09 Thread Tamas K Lengyel
On Mon, Mar 9, 2020 at 10:03 AM Jan Beulich wrote: > > On 09.03.2020 16:51, Tamas K Lengyel wrote: > > On Mon, Mar 9, 2020 at 5:49 AM Jan Beulich wrote: > >> --- a/xen/include/asm-arm/mem_access.h > >> +++ b/xen/include/asm-arm/mem_access.h > >> @@ -17,9 +17,11 @@ > >> #ifndef _ASM_ARM_MEM_ACCES

[Xen-devel] [ovmf bisection] complete build-i386-xsm

2020-03-09 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-i386-xsm testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen

Re: [Xen-devel] [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs

2020-03-09 Thread Jan Beulich
On 06.03.2020 17:02, p...@xen.org wrote: > From: Varad Gautam > > XEN_DOMCTL_destroydomain creates a continuation if domain_kill -ERESTARTS. > In that scenario, it is possible to receive multiple __pirq_guest_unbind > calls for the same pirq from domain_kill, if the pirq has not yet been > remove

Re: [Xen-devel] [PATCH v4 1/3] x86/hypervisor: pass flags to hypervisor_flush_tlb

2020-03-09 Thread Jan Beulich
On 19.02.2020 12:44, Wei Liu wrote: > --- a/xen/include/asm-x86/flushtlb.h > +++ b/xen/include/asm-x86/flushtlb.h > @@ -123,6 +123,9 @@ void switch_cr3_cr4(unsigned long cr3, unsigned long cr4); > /* Flush all HVM guests linear TLB (using ASID/VPID) */ > #define FLUSH_GUESTS_TLB 0x4000 > > +#d

Re: [Xen-devel] [PATCH v4 1/3] x86/hypervisor: pass flags to hypervisor_flush_tlb

2020-03-09 Thread Wei Liu
On Mon, Mar 09, 2020 at 05:38:12PM +0100, Jan Beulich wrote: > On 19.02.2020 12:44, Wei Liu wrote: > > --- a/xen/include/asm-x86/flushtlb.h > > +++ b/xen/include/asm-x86/flushtlb.h > > @@ -123,6 +123,9 @@ void switch_cr3_cr4(unsigned long cr3, unsigned long > > cr4); > > /* Flush all HVM guests

[Xen-devel] [xen-unstable-smoke test] 148323: tolerable all pass - PUSHED

2020-03-09 Thread osstest service owner
flight 148323 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/148323/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[Xen-devel] [XEN PATCH v3 0/2] xen/arm: Configure early printk via Kconfig

2020-03-09 Thread Anthony PERARD
Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.arm-early-printk-v3 v3: - many changes listed in patch notes. Hi, That two patchs is to unblock my work on "xen: Build system improvements". There is an easier fix to build with early

[Xen-devel] [XEN PATCH v3 2/2] xen/arm: Configure early printk via Kconfig

2020-03-09 Thread Anthony PERARD
At the moment, early printk can only be configured on the make command line. It is not very handy because a user has to remove the option everytime it is using another command other than compiling the hypervisor. Furthermore, early printk is one of the few odds one that are not using Kconfig. So

[Xen-devel] [XEN PATCH v3 1/2] xen/arm: Rename all early printk macro

2020-03-09 Thread Anthony PERARD
We are going to move the generation of the early printk macro into Kconfig. This means all macro will be prefix with CONFIG_. We do that ahead of the change. We also take the opportunity to better name some variables, which are used by only one driver and wouldn't make sens for other UART driver.

Re: [Xen-devel] [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs

2020-03-09 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 09 March 2020 16:29 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; Varad Gautam ; Julien > Grall ; Roger > Pau Monné ; Andrew Cooper > Subject: Re: [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for > shared pirqs > >

[Xen-devel] [libvirt test] 148269: regressions - FAIL

2020-03-09 Thread osstest service owner
flight 148269 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/148269/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 146182 build-i386-libvirt

[Xen-devel] [qemu-mainline test] 148261: regressions - FAIL

2020-03-09 Thread osstest service owner
flight 148261 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/148261/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 10 debian-hvm-install fail REGR. vs. 14486

[Xen-devel] [ovmf test] 148280: trouble: broken/pass

2020-03-09 Thread osstest service owner
flight 148280 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/148280/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 broken test-amd64-i386-xl-qe

Re: [Xen-devel] [PATCH v2] xen: Use evtchn_type_t as a type for event channels

2020-03-09 Thread Boris Ostrovsky
On 3/8/20 9:19 AM, Yan Yankovskyi wrote: > On Sat, Mar 07, 2020 at 02:41:44PM -0500, Boris Ostrovsky wrote: > >> I also think that, given that this patch is trying to get types in >> order, find_virq() will need more changes: it is supposed to return >> evtchn_port_t. But then it also wants to re

Re: [Xen-devel] [EXTERNAL][RFC PATCH v3 07/12] genirq: Shutdown irq chips in suspend/resume during hibernation

2020-03-09 Thread Anchal Agarwal
On Sat, Mar 07, 2020 at 12:03:52AM +0100, Thomas Gleixner wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > Anchal Agarwal writes: > > > There are no pm

[Xen-devel] [linux-4.4 test] 148277: regressions - trouble: broken/fail/pass

2020-03-09 Thread osstest service owner
flight 148277 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148277/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd broken test-amd64-i386-xl-qemuu-debianhvm-i386

Re: [Xen-devel] [PATCH v2 2/2] AMD/IOMMU: without XT, x2APIC needs to be forced into physical mode

2020-03-09 Thread Tian, Kevin
> From: Jan Beulich > Sent: Monday, March 9, 2020 4:59 PM > > On 28.02.2020 13:12, Jan Beulich wrote: > > The wider cluster mode APIC IDs aren't generally representable. Convert > > the iommu_intremap variable into a tristate, allowing the AMD IOMMU > > driver to signal this special restriction t

Re: [Xen-devel] [PATCH v2 2/5] IOMMU: iommu_intpost is x86/HVM-only

2020-03-09 Thread Tian, Kevin
> From: Jan Beulich > Sent: Monday, March 9, 2020 6:43 PM > > Provide a #define for all other cases. > > Signed-off-by: Jan Beulich > --- > v2: Refine doc adjustment. > > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -1309,6 +1309,8 @@ boolean (e.g. `io

Re: [Xen-devel] [PATCH v2 0/5] IOMMU: restrict visibility/scope if certain variables

2020-03-09 Thread Tian, Kevin
> From: Jan Beulich > Sent: Monday, March 9, 2020 6:40 PM > > A number of the command line controlled variables are x86- > or even x86-HVM-specific. Don't have those variables elsewhere > in the first place (in some cases replace them by a #define), > and as a result also don't silently accept su

Re: [Xen-devel] [PATCH V6] x86/altp2m: Hypercall to set altp2m view visibility

2020-03-09 Thread Tian, Kevin
> From: Alexandru Stefan ISAILA > Sent: Tuesday, March 3, 2020 8:23 PM > > At this moment a guest can call vmfunc to change the altp2m view. This > should be limited in order to avoid any unwanted view switch. I look forward to more elaboration of the motivation, especially for one who doesn't t

Re: [Xen-devel] [PATCH v5 2/4] x86/HVM: implement memory read caching for insn emulation

2020-03-09 Thread Tian, Kevin
> From: Jan Beulich > Sent: Tuesday, March 3, 2020 6:17 PM > > Emulation requiring device model assistance uses a form of instruction > re-execution, assuming that the second (and any further) pass takes > exactly the same path. This is a valid assumption as far as use of CPU ah, I was not aware

  1   2   >