Re: [Xen-devel] xen boot PVH guest with linux 5.6.0-rc4-ish kernel: general protection fault, RIP: 0010:__pv_queued_spin_lock_slowpath

2020-03-05 Thread Jürgen Groß
On 04.03.20 18:52, Sander Eikelenboom wrote: Hi Juergen, Just tested a 5.6.0-rc4'ish kernel (8b614cb8f1dcac8ca77cf4dd85f46ef3055f8238, so it includes the xen fixes from x86 trees). Xen is the latest xen-unstable, dom0 kernel is 5.5.7. During boot of the PVH guest I got the splat below. With a

Re: [Xen-devel] [PATCH] x86/cpuid: Untangle Invariant TSC handling

2020-03-05 Thread Jan Beulich
On 04.03.2020 19:40, Andrew Cooper wrote: > On 04/03/2020 10:25, Jan Beulich wrote: >> On 03.03.2020 19:24, Andrew Cooper wrote: >>> ITSC being visible to the guest is currently implicit with the toolstack >>> unconditionally asking for it, and Xen clipping it based on the vTSC and/or >>> XEN_DOMCT

Re: [Xen-devel] [PATCH v6 09/12] xen: add runtime parameter access support to hypfs

2020-03-05 Thread Jan Beulich
On 05.03.2020 07:01, Jürgen Groß wrote: > On 04.03.20 17:56, Jan Beulich wrote: >> On 04.03.2020 17:31, Jürgen Groß wrote: >>> On 04.03.20 16:19, Jan Beulich wrote: On 04.03.2020 16:07, Jürgen Groß wrote: > On 04.03.20 12:32, Jan Beulich wrote: >> On 26.02.2020 13:47, Juergen Gross wro

[Xen-devel] [linux-4.9 test] 148034: regressions - FAIL

2020-03-05 Thread osstest service owner
flight 148034 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148034/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 142947 test-amd64-i3

Re: [Xen-devel] [linux-linus bisection] complete test-amd64-amd64-xl-credit2

2020-03-05 Thread Dario Faggioli
On Wed, 2020-03-04 at 10:29 +, osstest service owner wrote: > branch xen-unstable > xenbranch xen-unstable > job test-amd64-amd64-xl-credit2 > testid guest-start > I was having a look at this. A question: > Tree: linux > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git > T

[Xen-devel] [linux-linus test] 148038: regressions - FAIL

2020-03-05 Thread osstest service owner
flight 148038 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/148038/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-shadow12 guest-start fail REGR. vs. 133580 test-amd64-amd64-xl

Re: [Xen-devel] [PATCH] x86/cpuid: Untangle Invariant TSC handling

2020-03-05 Thread Durrant, Paul
> -Original Message- > From: Andrew Cooper > Sent: 04 March 2020 17:31 > To: Durrant, Paul ; Xen-devel > > Cc: Wei Liu ; Jan Beulich ; Anthony PERARD > ; > Ian Jackson ; Roger Pau Monné > Subject: RE: [EXTERNAL][Xen-devel] [PATCH] x86/cpuid: Untangle Invariant TSC > handling > > CAUT

[Xen-devel] [qemu-mainline test] 148010: regressions - FAIL

2020-03-05 Thread osstest service owner
flight 148010 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/148010/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 11 guest-startfail REGR. vs. 144861 test-amd64-i386-f

Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-03-05 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > This is part of upgrading our build system and import more of Linux's > one. > > In Linux, subdir-y in Makefiles is only used to descend into > subdirectory when there are no object to build, Xen doesn't have that > and all subdir have object to be incl

Re: [Xen-devel] [PATCH v3] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs

2020-03-05 Thread Jan Beulich
On 29.01.2020 12:47, Jan Beulich wrote: > On 29.01.2020 11:30, Roger Pau Monné wrote: >> Hello, >> >> Thanks for the patch! Next time could you please try to reply to the >> previous questions before sending a new version: >> >> https://lists.xenproject.org/archives/html/xen-devel/2019-07/msg00257.

[Xen-devel] [PATCH] xen: Use evtchn_type_t as a type for event channels

2020-03-05 Thread Yan Yankovskyi
Make event channel functions pass event channel port using evtchn_port_t type. It eliminates signed <-> unsigned conversion. Also rename 'evtchn' variables to 'port' in case if 'port' is not ambiguous. Signed-off-by: Yan Yankovskyi --- drivers/xen/events/events_2l.c| 20 +- drivers/xen/

[Xen-devel] [PATCH] xen/blkfront: fix ring info addressing

2020-03-05 Thread Juergen Gross
Commit 0265d6e8ddb890 ("xen/blkfront: limit allocated memory size to actual use case") made struct blkfront_ring_info size dynamic. This is fine when running with only one queue, but with multiple queues the addressing of the single queues has to be adapted as the structs are allocated in an array.

[Xen-devel] [PATCH] xen/xenbus: fix locking

2020-03-05 Thread Juergen Gross
Commit 060eabe8fbe726 ("xenbus/backend: Protect xenbus callback with lock") introduced a bug by holding a lock while calling a function which might schedule. Fix that by using a semaphore instead. Fixes: 060eabe8fbe726 ("xenbus/backend: Protect xenbus callback with lock") Signed-off-by: Juergen G

Re: [Xen-devel] xen boot PVH guest with linux 5.6.0-rc4-ish kernel: general protection fault, RIP: 0010:__pv_queued_spin_lock_slowpath

2020-03-05 Thread Jürgen Groß
On 04.03.20 18:52, Sander Eikelenboom wrote: Hi Juergen, Just tested a 5.6.0-rc4'ish kernel (8b614cb8f1dcac8ca77cf4dd85f46ef3055f8238, so it includes the xen fixes from x86 trees). Xen is the latest xen-unstable, dom0 kernel is 5.5.7. During boot of the PVH guest I got the splat below. With a

[Xen-devel] preparations for 4.11.4

2020-03-05 Thread Jan Beulich
All, the release is due by the end of March. Please point out backports you find missing from the respective staging branch, but which you consider relevant. These commits I've queued already on top of what was just pushed (albeit I didn't check their applicability yet to this oldest of our fully

Re: [Xen-devel] [PATCH] xen/blkfront: fix ring info addressing

2020-03-05 Thread Roger Pau Monné
On Thu, Mar 05, 2020 at 11:03:31AM +0100, Juergen Gross wrote: > Commit 0265d6e8ddb890 ("xen/blkfront: limit allocated memory size to > actual use case") made struct blkfront_ring_info size dynamic. This is > fine when running with only one queue, but with multiple queues the > addressing of the si

Re: [Xen-devel] [XEN PATCH v3 20/23] xen/build: factorise generation of the linker scripts

2020-03-05 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > --- a/xen/Rules.mk > +++ b/xen/Rules.mk > @@ -230,6 +230,14 @@ cmd_s_S = $(CPP) $(filter-out -Wa$(comma)%,$(a_flags)) > $< -o $@ > %.s: %.S FORCE > $(call if_changed,cpp_s_S) > > +# Linker scripts, .lds.S -> .lds > +quiet_cmd_cc_lds_S = LDS

Re: [Xen-devel] xen boot PVH guest with linux 5.6.0-rc4-ish kernel: general protection fault, RIP: 0010:__pv_queued_spin_lock_slowpath

2020-03-05 Thread Sander Eikelenboom
On 05/03/2020 11:18, Jürgen Groß wrote: > On 04.03.20 18:52, Sander Eikelenboom wrote: >> Hi Juergen, >> >> Just tested a 5.6.0-rc4'ish kernel >> (8b614cb8f1dcac8ca77cf4dd85f46ef3055f8238, so it includes the xen fixes from >> x86 trees). >> Xen is the latest xen-unstable, dom0 kernel is 5.5.7. >>

Re: [Xen-devel] [PATCH] xen/blkfront: fix ring info addressing

2020-03-05 Thread Jürgen Groß
On 05.03.20 11:49, Roger Pau Monné wrote: On Thu, Mar 05, 2020 at 11:03:31AM +0100, Juergen Gross wrote: Commit 0265d6e8ddb890 ("xen/blkfront: limit allocated memory size to actual use case") made struct blkfront_ring_info size dynamic. This is fine when running with only one queue, but with mul

Re: [Xen-devel] xen boot PVH guest with linux 5.6.0-rc4-ish kernel: general protection fault, RIP: 0010:__pv_queued_spin_lock_slowpath

2020-03-05 Thread Jürgen Groß
On 05.03.20 12:04, Sander Eikelenboom wrote: On 05/03/2020 11:18, Jürgen Groß wrote: On 04.03.20 18:52, Sander Eikelenboom wrote: Hi Juergen, Just tested a 5.6.0-rc4'ish kernel (8b614cb8f1dcac8ca77cf4dd85f46ef3055f8238, so it includes the xen fixes from x86 trees). Xen is the latest xen-unsta

Re: [Xen-devel] [XEN PATCH v3 20/23] xen/build: factorise generation of the linker scripts

2020-03-05 Thread Jan Beulich
On 27.02.2020 14:14, Roger Pau Monné wrote: > On Wed, Feb 26, 2020 at 11:33:52AM +, Anthony PERARD wrote: >> In Arm and X86 makefile, generating the linker script is the same, so >> we can simply have both call the same macro. >> >> We need to add *.lds files into extra-y so that Rules.mk can f

Re: [Xen-devel] xen boot PVH guest with linux 5.6.0-rc4-ish kernel: general protection fault, RIP: 0010:__pv_queued_spin_lock_slowpath

2020-03-05 Thread Sander Eikelenboom
On 05/03/2020 12:06, Jürgen Groß wrote: > On 05.03.20 12:04, Sander Eikelenboom wrote: >> On 05/03/2020 11:18, Jürgen Groß wrote: >>> On 04.03.20 18:52, Sander Eikelenboom wrote: Hi Juergen, Just tested a 5.6.0-rc4'ish kernel (8b614cb8f1dcac8ca77cf4dd85f46ef3055f8238, so it inc

[Xen-devel] [qemu-mainline bisection] complete test-amd64-i386-qemuu-rhel6hvm-amd

2020-03-05 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-qemuu-rhel6hvm-amd testid redhat-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.

Re: [Xen-devel] [linux-linus bisection] complete test-amd64-amd64-xl-credit2

2020-03-05 Thread Ian Jackson
Dario Faggioli writes ("Re: [Xen-devel] [linux-linus bisection] complete test-amd64-amd64-xl-credit2"): > On Wed, 2020-03-04 at 10:29 +, osstest service owner wrote: > > branch xen-unstable > > xenbranch xen-unstable > > job test-amd64-amd64-xl-credit2 > > testid guest-start > > > I was havin

Re: [Xen-devel] [linux-linus bisection] complete test-amd64-amd64-xl-credit2

2020-03-05 Thread Ian Jackson
Ian Jackson writes ("Re: [Xen-devel] [linux-linus bisection] complete test-amd64-amd64-xl-credit2"): > Here is its console log: > > http://logs.test-lab.xenproject.org/osstest/logs/148053/test-amd64-amd64-xl-credit2/chardonnay1---var-log-xen-console-guest-debian.guest.osstest.log1 I mean http:/

Re: [Xen-devel] [linux-linus bisection] complete test-amd64-amd64-xl-credit2

2020-03-05 Thread Jürgen Groß
On 05.03.20 12:25, Ian Jackson wrote: Dario Faggioli writes ("Re: [Xen-devel] [linux-linus bisection] complete test-amd64-amd64-xl-credit2"): On Wed, 2020-03-04 at 10:29 +, osstest service owner wrote: branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-credit2 testid guest-

Re: [Xen-devel] [PATCH] xen/blkfront: fix ring info addressing

2020-03-05 Thread Roger Pau Monné
On Thu, Mar 05, 2020 at 12:04:27PM +0100, Jürgen Groß wrote: > On 05.03.20 11:49, Roger Pau Monné wrote: > > On Thu, Mar 05, 2020 at 11:03:31AM +0100, Juergen Gross wrote: > > > Commit 0265d6e8ddb890 ("xen/blkfront: limit allocated memory size to > > > actual use case") made struct blkfront_ring_in

[Xen-devel] [PATCH v2] xen/blkfront: fix ring info addressing

2020-03-05 Thread Juergen Gross
Commit 0265d6e8ddb890 ("xen/blkfront: limit allocated memory size to actual use case") made struct blkfront_ring_info size dynamic. This is fine when running with only one queue, but with multiple queues the addressing of the single queues has to be adapted as the structs are allocated in an array.

Re: [Xen-devel] [PATCH v2 1/4] qapi: net: Add query-netdevs command

2020-03-05 Thread Markus Armbruster
Alexey Kirillov writes: > Add a qmp command that provides information about currently attached > network devices and their configuration. Closes a gap in QMP; appreciated! > Signed-off-by: Alexey Kirillov [...] > diff --git a/qapi/net.json b/qapi/net.json > index 1cb9a7d782..4f329a1de0 100644

[Xen-devel] [PATCH v2 1/2] libxl: create domain 'error' node in xenstore

2020-03-05 Thread pdurrant
From: Paul Durrant Several PV drivers (both historically and currently [1]) report errors by writing text into /local/domain/$DOMID/error. This patch creates the node in libxl and makes it writable by the domain, and also adds some text into xenstore-paths.pandoc to state what the node is for. [

[Xen-devel] [PATCH v2 2/2] libxl: make creation of xenstore 'suspend event channel' node optional...

2020-03-05 Thread pdurrant
From: Paul Durrant ... and make the top level 'device' node in xenstore writable by the guest The purpose and semantics of the suspend event channel node are explained in xenstore-paths.pandoc [1]. It was originally introduced in xend by commit 17636f47a474 "Teach xc_save to use event-channel-ba

[Xen-devel] [PATCH v2 0/2] PV driver compatibility fixes

2020-03-05 Thread pdurrant
From: Paul Durrant Paul Durrant (2): libxl: create domain 'error' node in xenstore libxl: make creation of xenstore 'suspend event channel' node optional... docs/man/xl.cfg.5.pod.in| 7 +++ docs/misc/xenstore-paths.pandoc | 12 +--- tools/libxl/libxl.h |

Re: [Xen-devel] [PATCH v2] golang/xenlight: implement constructor generation

2020-03-05 Thread George Dunlap
On 3/4/20 6:08 PM, George Dunlap wrote: > On 3/2/20 8:10 PM, Nick Rosbrook wrote: >> Generate constructors for generated Go types. Call libxl__init so >> the Go type can be properly initialized. >> >> If a type has a keyed union field, add a parameter to the function >> signature to set the key var

Re: [Xen-devel] [PATCH v2] xen/blkfront: fix ring info addressing

2020-03-05 Thread Roger Pau Monné
On Thu, Mar 05, 2020 at 12:40:44PM +0100, Juergen Gross wrote: > Commit 0265d6e8ddb890 ("xen/blkfront: limit allocated memory size to > actual use case") made struct blkfront_ring_info size dynamic. This is > fine when running with only one queue, but with multiple queues the > addressing of the si

[Xen-devel] [PATCH v3 0/6] remove one more shared xenheap page: shared_info

2020-03-05 Thread pdurrant
From: Paul Durrant Paul Durrant (6): domain: introduce alloc/free_shared_info() helpers... x86 / p2m: remove page_list check in p2m_alloc_table x86 / pv: do not treat PGC_extra pages as RAM when constructing dom0 x86 / ioreq: use a MEMF_no_refcount allocation for server pages... mm: add

[Xen-devel] [PATCH v3 5/6] mm: add 'is_special_page' macro...

2020-03-05 Thread pdurrant
From: Paul Durrant ... to cover xenheap and PGC_extra pages. PGC_extra pages are intended to hold data structures that are associated with a domain and my be mapped by that domain. They should not be treated as 'normal' guest pages (i.e. RAM or page tables). Hence, in many cases where code curre

[Xen-devel] [PATCH v3 1/6] domain: introduce alloc/free_shared_info() helpers...

2020-03-05 Thread pdurrant
From: Paul Durrant ... and save the MFN. This patch modifies the 'shared_info' field of struct domain to be a structure comprising an MFN and a virtual address. Allocations are still done from xenheap, so the virtual address still equates to virt_to_mfn() called on the MFN but subsequent patch w

[Xen-devel] [PATCH v3 2/6] x86 / p2m: remove page_list check in p2m_alloc_table

2020-03-05 Thread pdurrant
From: Paul Durrant There does not seem to be any justification for refusing to create the domain's p2m table simply because it may have assigned pages. Particularly it prevents the prior allocation of PGC_extra pages. Signed-off-by: Paul Durrant --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Georg

[Xen-devel] [PATCH v3 3/6] x86 / pv: do not treat PGC_extra pages as RAM when constructing dom0

2020-03-05 Thread pdurrant
From: Paul Durrant The walk of page_list in dom0_construct_pv() should ignore PGC_extra pages as they are only created for special purposes and, if mapped, will be mapped explicitly for whatever purpose is relevant. Signed-off-by: Paul Durrant --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu

[Xen-devel] [PATCH v3 4/6] x86 / ioreq: use a MEMF_no_refcount allocation for server pages...

2020-03-05 Thread pdurrant
From: Paul Durrant ... now that it is safe to assign them. This avoids relying on libxl (or whatever toolstack is in use) setting max_pages up with sufficient 'slop' to allow all necessary ioreq server pages to be allocated. Signed-off-by: Paul Durrant --- Cc: Paul Durrant Cc: Jan Beulich Cc

[Xen-devel] [PATCH v3 6/6] domain: use PGC_extra domheap page for shared_info

2020-03-05 Thread pdurrant
From: Paul Durrant Currently shared_info is a shared xenheap page but shared xenheap pages complicate future plans for live-update of Xen so it is desirable to, where possible, not use them [1]. This patch therefore converts shared_info into a PGC_extra domheap page. This does entail freeing shar

[Xen-devel] [xen-unstable-smoke test] 148121: tolerable all pass - PUSHED

2020-03-05 Thread osstest service owner
flight 148121 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/148121/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH v3 1/6] domain: introduce alloc/free_shared_info() helpers...

2020-03-05 Thread Xia, Hongyan
On Thu, 2020-03-05 at 12:44 +, pdurr...@amzn.com wrote: > From: Paul Durrant > > ... and save the MFN. > > This patch modifies the 'shared_info' field of struct domain to be > a structure comprising an MFN and a virtual address. Allocations are > still done from xenheap, so the virtual addre

Re: [Xen-devel] [PATCH v3 1/6] domain: introduce alloc/free_shared_info() helpers...

2020-03-05 Thread Xia, Hongyan
On Thu, 2020-03-05 at 13:23 +, Hongyan Xia wrote: > On Thu, 2020-03-05 at 12:44 +, pdurr...@amzn.com wrote: > > ... > > Other than that, > Reviewed-by: Hongyan Xia Sorry, I meant hongy...@amazon.com ___ Xen-devel mailing list Xen-devel@lists.xe

Re: [Xen-devel] [PATCH v2] xen/blkfront: fix ring info addressing

2020-03-05 Thread Jürgen Groß
On 05.03.20 13:42, Roger Pau Monné wrote: On Thu, Mar 05, 2020 at 12:40:44PM +0100, Juergen Gross wrote: Commit 0265d6e8ddb890 ("xen/blkfront: limit allocated memory size to actual use case") made struct blkfront_ring_info size dynamic. This is fine when running with only one queue, but with mul

Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-03-05 Thread Andrew Cooper
On 05/03/2020 09:24, Jan Beulich wrote: > On 26.02.2020 12:33, Anthony PERARD wrote: >> This is part of upgrading our build system and import more of Linux's >> one. >> >> In Linux, subdir-y in Makefiles is only used to descend into >> subdirectory when there are no object to build, Xen doesn't hav

Re: [Xen-devel] [PATCH v2 1/4] qapi: net: Add query-netdevs command

2020-03-05 Thread Alexey Kirillov
04.03.2020, 18:57, "Laurent Vivier" : > On 04/03/2020 14:06, Alexey Kirillov wrote: >>  Add a qmp command that provides information about currently attached >>  network devices and their configuration. >> >>  Signed-off-by: Alexey Kirillov >>  --- >>   include/net/net.h | 1 + >>   net/hub.c | 8

Re: [Xen-devel] [PATCH v2 1/4] qapi: net: Add query-netdevs command

2020-03-05 Thread Alexey Kirillov
05.03.2020, 15:03, "Markus Armbruster" : > Alexey Kirillov writes: > >>  Add a qmp command that provides information about currently attached >>  network devices and their configuration. > > Closes a gap in QMP; appreciated! > >>  Signed-off-by: Alexey Kirillov > > [...] >>  diff --git a/qapi/n

[Xen-devel] [linux-4.4 test] 148041: regressions - FAIL

2020-03-05 Thread osstest service owner
flight 148041 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148041/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt 18 guest-start/debian.repeat fail REGR. vs. 139698 test-amd64-amd64-qemu

Re: [Xen-devel] [PATCH v2] golang/xenlight: implement constructor generation

2020-03-05 Thread Nick Rosbrook
> Although, I'm not sure if that implies "There's already boilerplate, so > it's extra important to avoid adding more", or "There's already > boilerplate, so it won't hurt to have a bit more, and wrap the whole > thing in a nicer library." I think the boilerplate added here is necessary. We need t

Re: [Xen-devel] [XEN PATCH v3 22/23] xen, symbols: rework file symbols selection

2020-03-05 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > Rework symbols so it prefer file symbols that names an object file to > file symbols that have a directory component. I'm afraid I don't understand the distinction you apparently mean to make: Something having a directory component may still name an obj

Re: [Xen-devel] [PATCH v2] golang/xenlight: implement constructor generation

2020-03-05 Thread Nick Rosbrook
> NewDomainConfig() as of this patch can never return success, because > DomainConfig.fromC() will call DomainBuildInfo.fromC(), which will choke > on b_info.type = LIBXL_DOMAIN_TYPE_INVALID. > > This is actually a bug in to/fromC. Consider libxl_channelinfo. > > The idl says: > > libxl_channelinf

Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-03-05 Thread Julien Grall
Hi Jan, On 05/03/2020 09:24, Jan Beulich wrote: On 26.02.2020 12:33, Anthony PERARD wrote: This is part of upgrading our build system and import more of Linux's one. In Linux, subdir-y in Makefiles is only used to descend into subdirectory when there are no object to build, Xen doesn't have th

Re: [Xen-devel] [PATCH v3 5/6] mm: add 'is_special_page' macro...

2020-03-05 Thread Tamas K Lengyel
On Thu, Mar 5, 2020 at 5:45 AM wrote: > > From: Paul Durrant > > ... to cover xenheap and PGC_extra pages. > > PGC_extra pages are intended to hold data structures that are associated > with a domain and my be mapped by that domain. They should not be treated > as 'normal' guest pages (i.e. RAM o

Re: [Xen-devel] [XEN PATCH v3 23/23] xen/build: use if_changed to build guest_%.o

2020-03-05 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > --- a/xen/Rules.mk > +++ b/xen/Rules.mk > @@ -115,6 +115,9 @@ endif > # FIXME LTO broken, but we would need a different way to filter -flto out > # $(obj-bin-y): CFLAGS := $(filter-out -flto,$(CFLAGS)) > > +# target with its suffix stripped > +target

Re: [Xen-devel] [PATCH v5 2/2] docs/designs: Add a design document for migration of xenstore data

2020-03-05 Thread Durrant, Paul
> -Original Message- > From: Julien Grall > Sent: 04 March 2020 18:32 > To: Durrant, Paul ; xen-devel@lists.xenproject.org > Cc: Andrew Cooper ; George Dunlap > ; Ian > Jackson ; Jan Beulich ; Konrad > Rzeszutek Wilk > ; Stefano Stabellini ; Wei > Liu > Subject: RE: [EXTERNAL][PATCH v5

Re: [Xen-devel] [PATCH 4/8] xen: add locks with timeouts for keyhandlers

2020-03-05 Thread Jan Beulich
On 13.02.2020 13:54, Juergen Gross wrote: > Most keyhandlers are used to dump hypervisor data to the console and > they are used mostly for debugging purposes. In those cases it might > happen that some data structures are locked and thus are blocking the > handler to access the data. > > In order

Re: [Xen-devel] [PATCH v6 2/6] x86/paging: add TLB flush hooks

2020-03-05 Thread Jan Beulich
On 03.03.2020 18:20, Roger Pau Monne wrote: > Add shadow and hap implementation specific helpers to perform guest > TLB flushes. Note that the code for both is exactly the same at the > moment, and is copied from hvm_flush_vcpu_tlb. This will be changed by > further patches that will add implementa

Re: [Xen-devel] [PATCH v6 3/6] x86/hap: improve hypervisor assisted guest TLB flush

2020-03-05 Thread Jan Beulich
On 03.03.2020 18:20, Roger Pau Monne wrote: > The current implementation of the hypervisor assisted flush for HAP is > extremely inefficient. > > First of all there's no need to call paging_update_cr3, as the only > relevant part of that function when doing a flush is the ASID vCPU > flush, so jus

Re: [Xen-devel] [PATCH v2] xen/blkfront: fix ring info addressing

2020-03-05 Thread Sander Eikelenboom
On 05/03/2020 14:40, Jürgen Groß wrote: > On 05.03.20 13:42, Roger Pau Monné wrote: >> On Thu, Mar 05, 2020 at 12:40:44PM +0100, Juergen Gross wrote: >>> Commit 0265d6e8ddb890 ("xen/blkfront: limit allocated memory size to >>> actual use case") made struct blkfront_ring_info size dynamic. This is >

[Xen-devel] [PATCH v3] xen/blkfront: fix ring info addressing

2020-03-05 Thread Juergen Gross
Commit 0265d6e8ddb890 ("xen/blkfront: limit allocated memory size to actual use case") made struct blkfront_ring_info size dynamic. This is fine when running with only one queue, but with multiple queues the addressing of the single queues has to be adapted as the structs are allocated in an array.

Re: [Xen-devel] [PATCH v3 5/6] mm: add 'is_special_page' macro...

2020-03-05 Thread Durrant, Paul
> -Original Message- > From: Tamas K Lengyel > Sent: 05 March 2020 15:10 > To: pdurr...@amzn.com > Cc: Xen-devel ; Durrant, Paul > ; Jan Beulich > ; Andrew Cooper ; Wei Liu > ; Roger Pau Monné > ; George Dunlap ; Ian Jackson > ; Julien Grall ; Konrad Rzeszutek > Wilk > ; Stefano Stabell

Re: [Xen-devel] [PATCH] xen/xenbus: fix locking

2020-03-05 Thread Boris Ostrovsky
On 3/5/20 5:03 AM, Juergen Gross wrote: > Commit 060eabe8fbe726 ("xenbus/backend: Protect xenbus callback with > lock") introduced a bug by holding a lock while calling a function > which might schedule. > > Fix that by using a semaphore instead. > > Fixes: 060eabe8fbe726 ("xenbus/backend: Protec

Re: [Xen-devel] [PATCH v3 5/6] mm: add 'is_special_page' macro...

2020-03-05 Thread Tamas K Lengyel
On Thu, Mar 5, 2020 at 8:38 AM Durrant, Paul wrote: > > > -Original Message- > > From: Tamas K Lengyel > > Sent: 05 March 2020 15:10 > > To: pdurr...@amzn.com > > Cc: Xen-devel ; Durrant, Paul > > ; Jan Beulich > > ; Andrew Cooper ; Wei Liu > > ; Roger Pau Monné > > ; George Dunlap ; Ia

Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-03-05 Thread Anthony PERARD
On Thu, Mar 05, 2020 at 03:02:22PM +, Julien Grall wrote: > Hi Jan, > > > > xen/Rules.mk | 19 --- > > > xen/arch/arm/Makefile| 14 +++--- > > > xen/arch/arm/arm32/Makefile | 2 +- > > > xen/arch/arm/arm64/Makefile

[Xen-devel] [PATCH OSSTEST] make-flight: add dom0 PVH test

2020-03-05 Thread Roger Pau Monne
Add a dom0 PVH test, the test to be run is launching a PV guest (test-debian). Note the PVH dom0 tests are only enabled for Xen >= 4.13. The runvar difference is: +test-amd64-amd64-dom0pvh-xl-amd all_host_di_version 2020-02-10 +test-amd64-amd64-dom0pvh-xl-intel all_host_di_version 2020-02-10 +t

[Xen-devel] [libvirt test] 148068: regressions - FAIL

2020-03-05 Thread osstest service owner
flight 148068 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/148068/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 146182 build-arm64-libvirt

Re: [Xen-devel] [PATCH v2 07/17] libxc/restore: STATIC_DATA_END inference for v2 compatibility

2020-03-05 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH v2 07/17] libxc/restore: STATIC_DATA_END inference for v2 compatibility"): > On 24/02/2020 17:32, Ian Jackson wrote: > > These 17 lines appears twice, in basically identical form. Could it > > be refactored ? > > Not really, no. > > The error handling (i.e. hal

[Xen-devel] [xen-unstable-smoke test] 148134: tolerable all pass - PUSHED

2020-03-05 Thread osstest service owner
flight 148134 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/148134/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-03-05 Thread Julien Grall
Hi Anthony, On 05/03/2020 15:59, Anthony PERARD wrote: On Thu, Mar 05, 2020 at 03:02:22PM +, Julien Grall wrote: Hi Jan, xen/Rules.mk | 19 --- xen/arch/arm/Makefile| 14 +++--- xen/arch/arm/arm32/Makefile |

[Xen-devel] [linux-4.4 bisection] complete test-amd64-amd64-xl-qemuu-ovmf-amd64

2020-03-05 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-qemuu-ovmf-amd64 testid debian-hvm-install Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/oss

Re: [Xen-devel] [PATCH v2 10/17] tools/libxl: Plumb a restore boolean down into libxl__build_pre()

2020-03-05 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH v2 10/17] tools/libxl: Plumb a restore boolean down into libxl__build_pre()"): > On 24/02/2020 17:39, Ian Jackson wrote: > > Maybe it would be better to pass this via libxl__domain_build_state > > rather than as an additional parameter ? > > Well - I tried a simi

Re: [Xen-devel] [PATCH v2 03/17] tools/migration: Drop IHDR_VERSION constant from libxc and python

2020-03-05 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH v2 03/17] tools/migration: Drop IHDR_VERSION constant from libxc and python"): > On 24/02/2020 17:25, Ian Jackson wrote: > > Andrew Cooper writes ("[PATCH v2 03/17] tools/migration: Drop IHDR_VERSION > > constant from libxc and python"): > >> Migration v3 is in t

[Xen-devel] [linux-linus bisection] complete test-amd64-amd64-xl-multivcpu

2020-03-05 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-multivcpu testid guest-start Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tr

[Xen-devel] [PATCH v6 2/2] docs/designs: Add a design document for migration of xenstore data

2020-03-05 Thread pdurrant
From: Paul Durrant This patch details proposes extra migration data and xenstore protocol extensions to support non-cooperative live migration of guests. NOTE: doc/misc/xenstore.txt is also amened to replace the term for the INTRODUCE operation with the , since this is what it actua

[Xen-devel] [PATCH v6 0/2] docs: Migration design documents

2020-03-05 Thread pdurrant
From: Paul Durrant Paul Durrant (2): docs/designs: Add a design document for non-cooperative live migration docs/designs: Add a design document for migration of xenstore data docs/designs/non-cooperative-migration.md | 280 ++ docs/designs/xenstore-migration.md|

[Xen-devel] [PATCH v6 1/2] docs/designs: Add a design document for non-cooperative live migration

2020-03-05 Thread pdurrant
From: Paul Durrant It has become apparent to some large cloud providers that the current model of cooperative migration of guests under Xen is not usable as it relies on software running inside the guest, which is likely beyond the provider's control. This patch introduces a proposal for non-coop

Re: [Xen-devel] [linux-linus bisection] complete test-amd64-amd64-xl-credit2

2020-03-05 Thread Dario Faggioli
On Thu, 2020-03-05 at 11:25 +, Ian Jackson wrote: > Dario Faggioli writes ("Re: [Xen-devel] [linux-linus bisection] > complete test-amd64-amd64-xl-credit2"): > > > Last fail repro: > > > http://logs.test-lab.xenproject.org/osstest/logs/148053/ > > > > > In OSSTest, we don't capture and save

Re: [Xen-devel] [PATCH v3] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs

2020-03-05 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of Jan > Beulich > Sent: 05 March 2020 09:37 > To: Gautam, Varad > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > ; Julien Grall > ; Roger Pau Monné > Subject: Re: [Xen-devel] [PATCH v3] x86: irq: Do not BUG_ON multiple unbind > ca

Re: [Xen-devel] [PATCH 1/2] tools/helpers: Introduce cmp-fd-file-inode utility

2020-03-05 Thread George Dunlap
On Wed, Feb 26, 2020 at 3:49 PM Ian Jackson wrote: > Jason Andryuk writes ("[PATCH 1/2] tools/helpers: Introduce > cmp-fd-file-inode utility"): > > This is a C implementation of the perl code inside of locking.sh to > > check that the locked file descriptor and lock file share the same inode > >

[Xen-devel] [PATCH] x86/dom0: Fix build with clang

2020-03-05 Thread Andrew Cooper
find_memory() isn't marked as __init, so if it isn't fully inlined, it ends up tripping: Error: size of dom0_build.o:.text is 0x0c1 Fixes: 73b47eea21 "x86/dom0: improve PVH initrd and metadata placement" Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- x

Re: [Xen-devel] [PATCH] x86/dom0: Fix build with clang

2020-03-05 Thread Roger Pau Monné
On Thu, Mar 05, 2020 at 06:00:09PM +, Andrew Cooper wrote: > find_memory() isn't marked as __init, so if it isn't fully inlined, it ends up > tripping: > > Error: size of dom0_build.o:.text is 0x0c1 > > Fixes: 73b47eea21 "x86/dom0: improve PVH initrd and metadata placement" > Signed-off-by:

[Xen-devel] [linux-next test] 148054: tolerable FAIL

2020-03-05 Thread osstest service owner
flight 148054 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/148054/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm16 guest-start/debian.repeat fail blocked in 147912 test-amd64-amd64-xl-rtds 12 guest-

[Xen-devel] [linux-5.4 test] 148056: regressions - FAIL

2020-03-05 Thread osstest service owner
flight 148056 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148056/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 146121 Tests which a

Re: [Xen-devel] [PATCH 1/2] tools/helpers: Introduce cmp-fd-file-inode utility

2020-03-05 Thread Ian Jackson
Jason Andryuk writes ("Re: [PATCH 1/2] tools/helpers: Introduce cmp-fd-file-inode utility"): > I'd be happy to use stat if it works. The comment in locking.sh above > the usage is: > # We can't just stat /dev/stdin or /proc/self/fd/$_lockfd or > # use bash's test -ef because those

[Xen-devel] [linux-4.19 test] 148063: regressions - FAIL

2020-03-05 Thread osstest service owner
flight 148063 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148063/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 142932 Tests which

[Xen-devel] [xen-unstable-smoke test] 148147: tolerable all pass - PUSHED

2020-03-05 Thread osstest service owner
flight 148147 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/148147/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[Xen-devel] [linux-4.14 test] 148087: regressions - FAIL

2020-03-05 Thread osstest service owner
flight 148087 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148087/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 142849 test-armhf-armhf-xl-

[Xen-devel] [ovmf test] 148114: all pass - PUSHED

2020-03-05 Thread osstest service owner
flight 148114 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/148114/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3b9cd714542a8744252d973e1f163222a9f21b9e baseline version: ovmf 0980779a9ddcd9c98a68d

[Xen-devel] [PATCH v8 00/10] error: auto propagated local_err part I

2020-03-05 Thread Vladimir Sementsov-Ogievskiy
File with errp-cleaning APIs dropped for two reasons: 1. I'm tired after a 3-days war with coccinelle, and don't want to add more patches here. 2. Markus noted, that we forget two more functions which needs such wrappers and corresponding conversion, so seems better to handle all these thin

[Xen-devel] [PATCH v8 01/10] error: auto propagated local_err

2020-03-05 Thread Vladimir Sementsov-Ogievskiy
Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of functions with an errp OUT parameter. It has three goals: 1. Fix issue with error_fatal and error_prepend/error_append_hint: user can't see this additional information, because exit() happens in error_setg earlier than informati

[Xen-devel] [PATCH v8 10/10] xen: introduce ERRP_AUTO_PROPAGATE

2020-03-05 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want

[Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-05 Thread Vladimir Sementsov-Ogievskiy
Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and does corresponding changes in code (look for details in include/qapi/error.h) Usage example: spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ --macro-file scripts/cocci-macro-file.h --in-place --no-show-diff \

Re: [Xen-devel] [PATCH v6 04/12] xen: add basic hypervisor filesystem support

2020-03-05 Thread Jürgen Groß
On 04.03.20 16:21, Jan Beulich wrote: On 04.03.2020 16:14, Jürgen Groß wrote: On 04.03.20 16:07, Jan Beulich wrote: On 04.03.2020 15:39, Jürgen Groß wrote: On 04.03.20 14:03, Jan Beulich wrote: On 04.03.2020 13:00, Jürgen Groß wrote: On 03.03.20 17:59, Jan Beulich wrote: On 26.02.2020 13:46

[Xen-devel] [xen-unstable test] 148098: tolerable FAIL - PUSHED

2020-03-05 Thread osstest service owner
flight 148098 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/148098/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 7 xen-boot fail REGR. vs. 147600 Tests which did not succeed

Re: [Xen-devel] [PATCH v6 09/12] xen: add runtime parameter access support to hypfs

2020-03-05 Thread Jürgen Groß
On 05.03.20 09:26, Jan Beulich wrote: On 05.03.2020 07:01, Jürgen Groß wrote: On 04.03.20 17:56, Jan Beulich wrote: On 04.03.2020 17:31, Jürgen Groß wrote: On 04.03.20 16:19, Jan Beulich wrote: On 04.03.2020 16:07, Jürgen Groß wrote: On 04.03.20 12:32, Jan Beulich wrote: On 26.02.2020 13:47

Re: [Xen-devel] [PATCH v3 5/6] mm: add 'is_special_page' macro...

2020-03-05 Thread Alan Robinson
A typo... On Thu, Mar 05, 2020 at 01:45:03PM +0100, pdurr...@amzn.com wrote: > > PGC_extra pages are intended to hold data structures that are associated > with a domain and my be mapped by that domain. They should not be treated s/my/may/ > as 'normal' guest pages (i.e. RAM or page tables). He