[Xen-devel] [libvirt test] 145589: regressions - FAIL

2020-01-05 Thread osstest service owner
flight 145589 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/145589/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 145511 build-arm64-libvirt

Re: [Xen-devel] Xen crash on S3 resume on 4.13 and unstable if any CPU is re-offlined

2020-01-05 Thread Jürgen Groß
On 05.01.20 08:39, Marek Marczykowski-Górecki wrote: On Sun, Jan 05, 2020 at 12:42:30AM +, Andrew Cooper wrote: On 04/01/2020 15:30, Marek Marczykowski-Górecki wrote: Hi, I have a reliable crash on resume from S3. I can reproduce it on both real hardware and nested within KVM, although cal

[Xen-devel] [PATCH] libxl: create backend/ xenstore dir for driver domains

2020-01-05 Thread Marek Marczykowski-Górecki
Cleaning up backend xenstore entries is a responsibility of the backend. When backend lives outside of dom0, the domain needs proper permissions to do it. Normally it is given permission to remove the device dir itself, but not the dir containing it (named after frontend ID). After a whole those em

Re: [Xen-devel] Xen crash on S3 resume on 4.13 and unstable if any CPU is re-offlined

2020-01-05 Thread Marek Marczykowski-Górecki
On Sun, Jan 05, 2020 at 09:25:42AM +0100, Jürgen Groß wrote: > On 05.01.20 08:39, Marek Marczykowski-Górecki wrote: > > On Sun, Jan 05, 2020 at 12:42:30AM +, Andrew Cooper wrote: > > > On 04/01/2020 15:30, Marek Marczykowski-Górecki wrote: > > > > Hi, > > > > > > > > I have a reliable crash on

[Xen-devel] [xen-unstable-coverity test] 145603: all pass - PUSHED

2020-01-05 Thread osstest service owner
flight 145603 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/145603/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 7b3c5b70a32303b46d0d051e695f18d72cce5ed0 baseline version: xen 3a13

Re: [Xen-devel] [PATCH v6 07/12] livepatch: Add per-function applied/reverted state tracking marker

2020-01-05 Thread Andrew Cooper
On 26/11/2019 10:07, Pawel Wieczorkiewicz wrote: > @@ -1274,6 +1297,9 @@ static void livepatch_do_action(void) > else > rc = apply_payload(data); > > +if ( !was_action_consistent(data, rc ? LIVEPATCH_FUNC_NOT_APPLIED : > LIVEPATCH_FUNC_APPLIED) ) > +pani

[Xen-devel] [PATCH] xen/sched: fix resuming from S3 with smt=0

2020-01-05 Thread Juergen Gross
When resuming from S3 and smt=0 or maxcpus= are specified we must not do anything in cpu_schedule_callback(). This is not true today for taking down a cpu during resume. If anything goes wrong during resume all the scheduler related error handling is in cpupool.c, so we can just bail out early fro

[Xen-devel] [xen-unstable test] 145586: tolerable FAIL

2020-01-05 Thread osstest service owner
flight 145586 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/145586/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 16 guest-localmigrate fail pass in 145538 Tests which did not succeed, but

[Xen-devel] [libvirt bisection] complete build-arm64-libvirt

2020-01-05 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-arm64-libvirt testid libvirt-build Tree: libvirt git://libvirt.org/libvirt.git Tree: libvirt_gnulib https://git.savannah.gnu.org/git/gnulib.git/ Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: ovmf git://xenbits.x

[Xen-devel] [qemu-mainline test] 145592: regressions - FAIL

2020-01-05 Thread osstest service owner
flight 145592 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/145592/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 14 guest-saverestore fail REGR. vs. 144861 test-amd64-i386-f

Re: [Xen-devel] [PATCH] x86/shim: Short circuit control/hardware checks in PV_SHIM_EXCLUSIVE builds

2020-01-05 Thread Wei Liu
On Fri, Jan 03, 2020 at 08:07:42PM +, Andrew Cooper wrote: > The net diffstat is: > add/remove: 0/13 grow/shrink: 25/129 up/down: 6297/-20469 (-14172) > > With the following objects/functions removed entirely: > iommu_hwdom_none 1 - -1 > hwdom_max

Re: [Xen-devel] [PATCH v2 8/8] x86/hyperv: setup VP assist page

2020-01-05 Thread Wei Liu
On Fri, Jan 03, 2020 at 04:08:25PM +, Wei Liu wrote: > > Preemptively split out set_vp_assist page which will be used in the resume > path. After going through TLFS's section on reenlightenment, I don't think this is necessary. Wei. ___ Xen-devel

[Xen-devel] [PATCH v3 5/5] x86/hyperv: setup VP assist page

2020-01-05 Thread Wei Liu
VP assist page is rather important as we need to toggle some bits in it for efficient nested virtualisation. Signed-off-by: Wei Liu --- v3: 1. Use xenheap page 2. Drop set_vp_assist v2: 1. Use HV_HYP_PAGE_SHIFT instead --- xen/arch/x86/guest/hyperv/hyperv.c | 21 + xen/inclu

[Xen-devel] [PATCH v3 4/5] x86/hyperv: retrieve vp_index from Hyper-V

2020-01-05 Thread Wei Liu
This will be useful when invoking hypercall that targets specific vcpu(s). Signed-off-by: Wei Liu --- v2: 1. Fold into setup_pcpu_arg function --- xen/arch/x86/guest/hyperv/hyperv.c | 5 + xen/include/asm-x86/guest/hyperv.h | 1 + 2 files changed, 6 insertions(+) diff --git a/xen/arch/x86/g

[Xen-devel] [PATCH v3 1/5] x86/hyperv: setup hypercall page

2020-01-05 Thread Wei Liu
Signed-off-by: Wei Liu --- v2: 1. Fix issue discovered by Michael 2. Use a statically allocated page as hypercall page --- xen/arch/x86/guest/hyperv/Makefile | 1 + xen/arch/x86/guest/hyperv/hypercall_page.S | 21 + xen/arch/x86/guest/hyperv/hyperv.c | 27

[Xen-devel] [PATCH v3 0/5] More Hyper-V infrastructure

2020-01-05 Thread Wei Liu
This patch sereis implements several important functionalities to run Xen on top of Hyper-V. See individual patches for more details. Wei. Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu Cc: Roger Pau Monné Cc: Michael Kelley Cc: Paul Durrant Wei Liu (5): x86/hyperv: setup hypercall page

[Xen-devel] [PATCH v3 3/5] x86/hyperv: provide percpu hypercall input page

2020-01-05 Thread Wei Liu
Hyper-V's input / output argument must be 8 bytes aligned an not cross page boundary. The easiest way to satisfy those requirements is to use percpu page. For the foreseeable future we only need to provide input for TLB and APIC hypercalls, so skip setting up an output page. We will also need to

[Xen-devel] [PATCH v3 2/5] x86/hyperv: provide Hyper-V hypercall functions

2020-01-05 Thread Wei Liu
These functions will be used later to make hypercalls to Hyper-V. I couldn't find reference in TLFS that Hyper-V clobbers flags and r9-r11, but Linux's commit message says it does. Err on the safe side. Signed-off-by: Wei Liu --- v3: 1. Name the file hyperv-hcall.h v2: 1. Use direct call --- x

Re: [Xen-devel] [PATCH v3 1/5] x86/hyperv: setup hypercall page

2020-01-05 Thread Andrew Cooper
On 05/01/2020 16:47, Wei Liu wrote: > diff --git a/xen/arch/x86/guest/hyperv/Makefile > b/xen/arch/x86/guest/hyperv/Makefile > index 68170109a9..1a8887d2f4 100644 > --- a/xen/arch/x86/guest/hyperv/Makefile > +++ b/xen/arch/x86/guest/hyperv/Makefile > @@ -1 +1,2 @@ > +obj-y += hypercall_page.o > o

Re: [Xen-devel] [PATCH v3 2/5] x86/hyperv: provide Hyper-V hypercall functions

2020-01-05 Thread Andrew Cooper
> +static inline uint64_t hv_do_hypercall(uint64_t control, paddr_t input, > paddr_t output) > +{ > +uint64_t status; > + > +asm volatile ("mov %[output], %%r8\n" > + "call hv_hypercall_page" > + : "=a" (status), "+c" (control), > +"+d

Re: [Xen-devel] [PATCH v3 2/5] x86/hyperv: provide Hyper-V hypercall functions

2020-01-05 Thread Wei Liu
On Sun, Jan 05, 2020 at 07:08:28PM +, Andrew Cooper wrote: > > > +static inline uint64_t hv_do_hypercall(uint64_t control, paddr_t input, > > paddr_t output) > > +{ > > +uint64_t status; > > + > > +asm volatile ("mov %[output], %%r8\n" > > + "call hv_hypercall_page" >

Re: [Xen-devel] [PATCH v3 1/5] x86/hyperv: setup hypercall page

2020-01-05 Thread Wei Liu
On Sun, Jan 05, 2020 at 05:37:44PM +, Andrew Cooper wrote: > On 05/01/2020 16:47, Wei Liu wrote: > > diff --git a/xen/arch/x86/guest/hyperv/Makefile > > b/xen/arch/x86/guest/hyperv/Makefile > > index 68170109a9..1a8887d2f4 100644 > > --- a/xen/arch/x86/guest/hyperv/Makefile > > +++ b/xen/arch/

Re: [Xen-devel] [PATCH v3 1/5] x86/hyperv: setup hypercall page

2020-01-05 Thread Andrew Cooper
On 05/01/2020 21:45, Wei Liu wrote: > On Sun, Jan 05, 2020 at 05:37:44PM +, Andrew Cooper wrote: >> On 05/01/2020 16:47, Wei Liu wrote: >>> diff --git a/xen/arch/x86/guest/hyperv/Makefile >>> b/xen/arch/x86/guest/hyperv/Makefile >>> index 68170109a9..1a8887d2f4 100644 >>> --- a/xen/arch/x86/gu

Re: [Xen-devel] [PATCH v3 2/5] x86/hyperv: provide Hyper-V hypercall functions

2020-01-05 Thread Andrew Cooper
On 05/01/2020 21:22, Wei Liu wrote: > On Sun, Jan 05, 2020 at 07:08:28PM +, Andrew Cooper wrote: >>> +static inline uint64_t hv_do_hypercall(uint64_t control, paddr_t input, >>> paddr_t output) >>> +{ >>> +uint64_t status; >>> + >>> +asm volatile ("mov %[output], %%r8\n" >>> +

[Xen-devel] [libvirt bisection] complete build-amd64-libvirt

2020-01-05 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-amd64-libvirt testid libvirt-build Tree: libvirt git://libvirt.org/libvirt.git Tree: libvirt_gnulib https://git.savannah.gnu.org/git/gnulib.git/ Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: ovmf git://xenbits.x

Re: [Xen-devel] [BUG] panic: "IO-APIC + timer doesn't work" - several people have reproduced

2020-01-05 Thread Aaron Janse
On Fri, Jan 3, 2020, at 4:51 AM, Jan Beulich wrote: > On 31.12.2019 08:52, Aaron Janse wrote: > > I'd like to note that Ubuntu, unlike Qubes, doesn't need to try > > any `MP-BIOS bug` fallbacks. > > "Doesn't need to try" is supposed to mean what? That it gets past > the timer interrupt initializ

[Xen-devel] [qemu-mainline test] 145624: regressions - FAIL

2020-01-05 Thread osstest service owner
flight 145624 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/145624/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 14 guest-saverestore fail REGR. vs. 144861 test-amd64-i386-f

Re: [Xen-devel] [PATCH v4 4/7] Add Communication Guide

2020-01-05 Thread Jürgen Groß
On 30.12.19 20:32, Lars Kurth wrote: From: Lars Kurth This document is a portal page that lays out our gold standard, best practices for some common situations and mechanisms to help resolve issues that can have a negative effect on our community. Detail is covered in subsequent documents Cha

Re: [Xen-devel] [PATCH v4 5/7] Add Code Review Guide

2020-01-05 Thread Jürgen Groß
On 30.12.19 20:32, Lars Kurth wrote: From: Lars Kurth This document highlights what reviewers such as maintainers and committers look for when reviewing code. It sets expectations for code authors and provides a framework for code reviewers. Changes since v3 * Added example under *Workflow fro

Re: [Xen-devel] [PATCH v4 6/7] Add guide on Communication Best Practice

2020-01-05 Thread Jürgen Groß
On 30.12.19 20:32, Lars Kurth wrote: From: Lars Kurth This guide covers the bulk on Best Practice related to code review It primarily focusses on code review interactions It also covers how to deal with Misunderstandings and Cultural Differences Changes since v3 * Fixed typo Changes since v2

Re: [Xen-devel] [PATCH v4 7/7] Added Resolving Disagreement

2020-01-05 Thread Jürgen Groß
On 30.12.19 20:32, Lars Kurth wrote: From: Lars Kurth This guide provides Best Practice on identifying and resolving common classes of disagreement Changes since v3 * Fixed broken http link (typo) Changes since v2 (added in v2) * Fix typos * Add section: "Issue: Multiple ways to solve a probl

[Xen-devel] [libvirt test] 145656: regressions - FAIL

2020-01-05 Thread osstest service owner
flight 145656 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/145656/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 145511 build-amd64-libvirt