Re: [Xen-devel] [PATCH 1/3] x86/viridian: drop a wrong invalid value from reference TSC implementation

2019-12-23 Thread Durrant, Paul
V2? > -Original Message- > From: Wei Liu On Behalf Of Wei Liu > Sent: 22 December 2019 23:21 > To: Xen Development List > Cc: Michael Kelley ; Durrant, Paul > ; Wei Liu ; Paul Durrant > ; Jan Beulich ; Andrew Cooper > ; Wei Liu ; Roger Pau Monné > > Subject: [PATCH 1/3] x86/viridian: dr

Re: [Xen-devel] [PATCH 2/3] x86/viridian: drop virdian_sint_msr

2019-12-23 Thread Durrant, Paul
> -Original Message- > From: Wei Liu On Behalf Of Wei Liu > Sent: 22 December 2019 23:21 > To: Xen Development List > Cc: Michael Kelley ; Durrant, Paul > ; Wei Liu ; Paul Durrant > ; Jan Beulich ; Andrew Cooper > ; Wei Liu ; Roger Pau Monné > > Subject: [PATCH 2/3] x86/viridian: drop vi

Re: [Xen-devel] [PATCH 3/3] x86/viridian: drop viridian_stimer_config_msr

2019-12-23 Thread Durrant, Paul
> -Original Message- > From: Wei Liu On Behalf Of Wei Liu > Sent: 22 December 2019 23:21 > To: Xen Development List > Cc: Michael Kelley ; Durrant, Paul > ; Wei Liu ; Paul Durrant > ; Jan Beulich ; Andrew Cooper > ; Wei Liu ; Roger Pau Monné > > Subject: [PATCH 3/3] x86/viridian: drop vi

[Xen-devel] [qemu-mainline test] 145124: regressions - FAIL

2019-12-23 Thread osstest service owner
flight 145124 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/145124/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-amd64 14 guest-saverestore fail REGR. vs. 144861 test-amd64-i386-f

Re: [Xen-devel] [qemu-mainline test] 145124: regressions - FAIL

2019-12-23 Thread Durrant, Paul
-Original Message- > From: Xen-devel On Behalf Of > osstest service owner > Sent: 23 December 2019 08:59 > To: xen-devel@lists.xenproject.org; osstest-ad...@xenproject.org > Subject: [Xen-devel] [qemu-mainline test] 145124: regressions - FAIL > > flight 145124 qemu-mainline real [real] >

[Xen-devel] [libvirt test] 145133: regressions - FAIL

2019-12-23 Thread osstest service owner
flight 145133 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/145133/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt 19 leak-check/check fail REGR. vs. 145054 Tests which did not suc

Re: [Xen-devel] [PATCH v2 01/20] x86: make hvm_{get/set}_param accessible

2019-12-23 Thread Jan Beulich
On 20.12.2019 18:32, Andrew Cooper wrote: > On 20/12/2019 17:27, Tamas K Lengyel wrote: >> On Fri, Dec 20, 2019 at 9:47 AM Jan Beulich wrote: >>> On 18.12.2019 20:40, Tamas K Lengyel wrote: Currently the hvm parameters are only accessible via the HVMOP hypercalls. By exposing hvm_{

Re: [Xen-devel] [PATCH] x86/hyperv: change hv_tlb_flush_ex to fix clang build

2019-12-23 Thread Jan Beulich
On 22.12.2019 00:50, Wei Liu wrote: > Clang complains: > > In file included from synic.c:15: > /builds/xen-project/xen/xen/include/asm/guest/hyperv-tlfs.h:900:18: error: > field 'hv_vp_set' with variable sized type 'struct hv_vpset' not at the end > of a struct or class is a GNU extension > [-W

[Xen-devel] [PATCH net-next] xen-netback: support dynamic unbind/bind

2019-12-23 Thread Paul Durrant
By re-attaching RX, TX, and CTL rings during connect() rather than assuming they are freshly allocated (i.e. assuming the counters are zero), and avoiding forcing state to Closed in netback_remove() it is possible for vif instances to be unbound and re-bound from and to (respectively) a running gue

Re: [Xen-devel] [PATCH] x86/hyperv: change hv_tlb_flush_ex to fix clang build

2019-12-23 Thread Wei Liu
On Mon, Dec 23, 2019 at 10:53:29AM +0100, Jan Beulich wrote: > On 22.12.2019 00:50, Wei Liu wrote: > > Clang complains: > > > > In file included from synic.c:15: > > /builds/xen-project/xen/xen/include/asm/guest/hyperv-tlfs.h:900:18: error: > > field 'hv_vp_set' with variable sized type 'struct h

[Xen-devel] [PATCH v2] x86/hyperv: change hv_tlb_flush_ex to fix clang build

2019-12-23 Thread Wei Liu
Clang complains: In file included from synic.c:15: /builds/xen-project/xen/xen/include/asm/guest/hyperv-tlfs.h:900:18: error: field 'hv_vp_set' with variable sized type 'struct hv_vpset' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]

Re: [Xen-devel] [PATCH v2] x86/hyperv: change hv_tlb_flush_ex to fix clang build

2019-12-23 Thread Jan Beulich
On 23.12.2019 12:03, Wei Liu wrote: > Clang complains: > > In file included from synic.c:15: > /builds/xen-project/xen/xen/include/asm/guest/hyperv-tlfs.h:900:18: error: > field 'hv_vp_set' with variable sized type 'struct hv_vpset' not at the end > of a struct or class is a GNU extension > [-W

Re: [Xen-devel] [PATCH net-next] xen-netback: support dynamic unbind/bind

2019-12-23 Thread Wei Liu
On Mon, Dec 23, 2019 at 09:59:23AM +, Paul Durrant wrote: [...] > diff --git a/drivers/net/xen-netback/interface.c > b/drivers/net/xen-netback/interface.c > index f15ba3de6195..0c8a02a1ead7 100644 > --- a/drivers/net/xen-netback/interface.c > +++ b/drivers/net/xen-netback/interface.c > @@ -58

Re: [Xen-devel] [PATCH net-next] xen-netback: support dynamic unbind/bind

2019-12-23 Thread Durrant, Paul
> -Original Message- > From: Wei Liu > Sent: 23 December 2019 11:36 > To: Durrant, Paul > Cc: xen-devel@lists.xenproject.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Wei Liu ; Paul Durrant > ; David S. Miller > Subject: Re: [PATCH net-next] xen-netback: support dynamic u

[Xen-devel] [PATCH] MAINTAINERS: put hyperv-tlfs.h under viridian maintainership

2019-12-23 Thread Wei Liu
Suggested-by: Jan Beulich Signed-off-by: Wei Liu --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 012c847ebd..eaea4620e2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -516,6 +516,7 @@ M: Paul Durrant S: Supported F: xen/arch/x86/hvm/

[Xen-devel] [PATCH V6 1/4] x86/mm: Add array_index_nospec to guest provided index values

2019-12-23 Thread Alexandru Stefan ISAILA
This patch aims to sanitize indexes, potentially guest provided values, for altp2m_eptp[] and altp2m_p2m[] arrays. Requested-by: Jan Beulich Signed-off-by: Alexandru Isaila --- CC: Razvan Cojocaru CC: Tamas K Lengyel CC: Petre Pircalabu CC: George Dunlap CC: Jan Beulich CC: Andrew Cooper C

[Xen-devel] [PATCH V6 3/4] x86/mm: Pull out the p2m specifics from p2m_init_altp2m_ept

2019-12-23 Thread Alexandru Stefan ISAILA
Requested-by: Jan Beulich Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- CC: Jun Nakajima CC: Kevin Tian CC: George Dunlap CC: Jan Beulich CC: Andrew Cooper CC: Wei Liu CC: "Roger Pau Monné" --- xen/arch/x86/mm/p2m-ept.c | 6 -- xen/arch/x86/mm/p2m.c | 6 ++ 2

[Xen-devel] [PATCH V6 4/4] x86/mm: Make use of the default access param from xc_altp2m_create_view

2019-12-23 Thread Alexandru Stefan ISAILA
At this moment the default_access param from xc_altp2m_create_view is not used. This patch assigns default_access to p2m->default_access at the time of initializing a new altp2m view. Signed-off-by: Alexandru Isaila --- CC: Jan Beulich CC: Andrew Cooper CC: Wei Liu CC: "Roger Pau Monné" CC:

[Xen-devel] [PATCH V6 2/4] x86/altp2m: Add hypercall to set a range of sve bits

2019-12-23 Thread Alexandru Stefan ISAILA
By default the sve bits are not set. This patch adds a new hypercall, xc_altp2m_set_supress_ve_multi(), to set a range of sve bits. The core function, p2m_set_suppress_ve_multi(), does not brake in case of a error and it is doing a best effort for setting the bits in the given range. A check for co

Re: [Xen-devel] [PATCH] MAINTAINERS: put hyperv-tlfs.h under viridian maintainership

2019-12-23 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of Wei > Liu > Sent: 23 December 2019 12:52 > To: Xen Development List > Cc: Andrew Cooper ; Jan Beulich > ; Wei Liu ; Paul Durrant > Subject: [Xen-devel] [PATCH] MAINTAINERS: put hyperv-tlfs.h under viridian > maintainership > > Suggeste

Re: [Xen-devel] [PATCH v2] x86/hyperv: change hv_tlb_flush_ex to fix clang build

2019-12-23 Thread Paul Durrant
On Mon, 23 Dec 2019 at 11:03, Wei Liu wrote: > > Clang complains: > > In file included from synic.c:15: > /builds/xen-project/xen/xen/include/asm/guest/hyperv-tlfs.h:900:18: error: > field 'hv_vp_set' with variable sized type 'struct hv_vpset' not at the end > of a struct or class is a GNU exten

Re: [Xen-devel] [PATCH v2 01/20] x86: make hvm_{get/set}_param accessible

2019-12-23 Thread Tamas K Lengyel
On Mon, Dec 23, 2019 at 2:37 AM Jan Beulich wrote: > > On 20.12.2019 18:32, Andrew Cooper wrote: > > On 20/12/2019 17:27, Tamas K Lengyel wrote: > >> On Fri, Dec 20, 2019 at 9:47 AM Jan Beulich wrote: > >>> On 18.12.2019 20:40, Tamas K Lengyel wrote: > Currently the hvm parameters are only a

[Xen-devel] [xen-unstable-smoke test] 145144: tolerable all pass - PUSHED

2019-12-23 Thread osstest service owner
flight 145144 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/145144/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[Xen-devel] [PATCH v4 2/6] golang/xenlight: begin Go to C type marshaling

2019-12-23 Thread Nick Rosbrook
Implement conversion of basic type conversions such as strings and integer types in toC functions. Signed-off-by: Nick Rosbrook --- tools/golang/xenlight/gengotypes.py | 80 ++ tools/golang/xenlight/helpers.gen.go | 1015 ++ 2 files changed, 1095 insertions(+) diff --

[Xen-devel] [PATCH v4 3/6] golang/xenlight: implement keyed union Go to C marshaling

2019-12-23 Thread Nick Rosbrook
Since the C union cannot be directly populated, populate the fields of the corresponding C struct defined in the cgo preamble, and then copy that struct as bytes into the byte slice that Go uses as the union. Signed-off-by: Nick Rosbrook --- tools/golang/xenlight/gengotypes.py | 77 ++- to

[Xen-devel] [PATCH v4 1/6] golang/xenlight: implement array C to Go marshaling

2019-12-23 Thread Nick Rosbrook
Signed-off-by: Nick Rosbrook --- Changes in v4: - Call fromC using slice expression instead of creating temporary variable and assigning later. --- tools/golang/xenlight/gengotypes.py | 37 +++- tools/golang/xenlight/helpers.gen.go | 246 +++ 2 files changed, 282 inser

[Xen-devel] [PATCH v4 0/6] generated Go libxl bindings using IDL

2019-12-23 Thread Nick Rosbrook
After Xen summit, we started the discussion in this[1] RFC thread to figure out how to generate Go bindings for libxl. This series implements that Go code generation using the existing IDL, and updates the existing hand-written code in xenlight.go to use the generated code. The goal of this series

[Xen-devel] [PATCH v4 4/6] golang/xenlight: implement array Go to C marshaling

2019-12-23 Thread Nick Rosbrook
Signed-off-by: Nick Rosbrook --- tools/golang/xenlight/gengotypes.py | 44 +++- tools/golang/xenlight/helpers.gen.go | 359 +++ 2 files changed, 402 insertions(+), 1 deletion(-) diff --git a/tools/golang/xenlight/gengotypes.py b/tools/golang/xenlight/gengotypes.py inde

[Xen-devel] [PATCH v4 6/6] golang/xenlight: add error return type to Context.Cpupoolinfo

2019-12-23 Thread Nick Rosbrook
A previous commit that removed Context.CheckOpen revealed an ineffectual assignent to err in Context.Cpupoolinfo, as there is no error return type. Since it appears that the intent is to return an error here, add an error return value to the function signature. Signed-off-by: Nick Rosbrook Revie

[Xen-devel] [PATCH v4 5/6] golang/xenlight: revise use of Context type

2019-12-23 Thread Nick Rosbrook
Remove the exported global context variable, 'Ctx.' Generally, it is better to not export global variables for use through a Go package. However, there are some exceptions that can be found in the standard library. Add a NewContext function instead, and remove the Open, IsOpen, and CheckOpen funct

[Xen-devel] [xen-unstable test] 145136: regressions - FAIL

2019-12-23 Thread osstest service owner
flight 145136 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/145136/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 145025 Tests whic

Re: [Xen-devel] [PATCH V6 2/4] x86/altp2m: Add hypercall to set a range of sve bits

2019-12-23 Thread Tamas K Lengyel
> diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c > index 4fc919a9c5..de832dcc6d 100644 > --- a/xen/arch/x86/mm/p2m.c > +++ b/xen/arch/x86/mm/p2m.c > @@ -3070,6 +3070,70 @@ out: > return rc; > } > > +/* > + * Set/clear the #VE suppress bit for multiple pages. Only available on VMX

Re: [Xen-devel] [PATCH V6 1/4] x86/mm: Add array_index_nospec to guest provided index values

2019-12-23 Thread Tamas K Lengyel
On Mon, Dec 23, 2019 at 7:04 AM Alexandru Stefan ISAILA wrote: > > This patch aims to sanitize indexes, potentially guest provided > values, for altp2m_eptp[] and altp2m_p2m[] arrays. > > Requested-by: Jan Beulich > Signed-off-by: Alexandru Isaila For the mem_access bits: Acked-by: Tamas K Leng

[Xen-devel] [PATCH 3/4] mm: Use put_old_guest_table for relinquish_pages

2019-12-23 Thread George Dunlap
relinquish_pages() deals with interrupted de-validation in a fairly ad-hoc way, by either re-setting PGT_pinned (in the case of EINTR) or letting the page "fall through" to the "force invalidate" loop below. This requires an extensive comment describing what needs to happen to the type and count in

[Xen-devel] [PATCH 0/4] x86: Remove force-invalidate loop from relinqusish_memory

2019-12-23 Thread George Dunlap
George Dunlap (4): xen: Remove trailing whitespace from time.c xen: Add 'synthetic' preemption check parameter mm: Use put_old_guest_table for relinquish_pages x86/mm: Remove force-invalidate loop docs/misc/xen-command-line.pandoc | 20 - xen/arch/x86/domain.c | 121 +

[Xen-devel] [PATCH 2/4] xen: Add 'synthetic' preemption check parameter

2019-12-23 Thread George Dunlap
In order to better test hypervisor preemption paths, add an option to artificially increase the number of preemptions. While modifying xen-command-line.pandoc, escape some underscores, and remove some trailing whitespace. Signed-off-by: George Dunlap --- CC: Andrew Cooper CC: Jan Beulich ---

[Xen-devel] [PATCH 4/4] x86/mm: Remove force-invalidate loop

2019-12-23 Thread George Dunlap
The comment about the "force-invalidate" loop gives two reasons for its existence: 1. Breaking circular "linear pagetable" references 2. Cleaning up partially-validated pages. The first reason been invalid since XSA-240: Since then it hasn't been possible to generate circular linear pagetable re

[Xen-devel] [PATCH 1/4] xen: Remove trailing whitespace from time.c

2019-12-23 Thread George Dunlap
No functional changes. Signed-off-by: George Dunlap --- CC: Andrew Cooper CC: Jan Beulich --- xen/arch/x86/time.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c index ea696a95e8..64e471a39b 100644 -

Re: [Xen-devel] [PATCH] x86: move vgc_flags to struct pv_vcpu

2019-12-23 Thread Julien Grall
Hi Jan, On 20/12/2019 14:55, Jan Beulich wrote: There's been effectively no use of the field for HVM. Also shrink the field to unsigned int, even if this doesn't immediately yield any space benefit for the structure itself. The resulting 32-bit padding slot can eventually be used for some other

Re: [Xen-devel] [XEN PATCH v2 0/6] xen: Kconfig update with few extra

2019-12-23 Thread Julien Grall
Hi, On 17/12/2019 11:58, Anthony PERARD wrote: Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.build-system-xen-kconfig-v2 v2: nit changes in patch 1 and 2. Hi, This is a update of Kconfig as used to build the hypervisor. Th

Re: [Xen-devel] [PATCH] x86/hvm/rtc: preserved guest RTC offset during suspend/resume/migrate

2019-12-23 Thread Julien Grall
Hi Paul, On 18/12/2019 15:41, Paul Durrant wrote: The emulated RTC is synchronized with the PV wallclock; any write to the RTC will update struct domain's 'time_offset_seconds' field and call update_domain_wallclock(). However, the value of 'time_offset_seconds' is not preserved in any save rec

Re: [Xen-devel] [PATCH V6 1/4] x86/mm: Add array_index_nospec to guest provided index values

2019-12-23 Thread George Dunlap
On 12/23/19 2:04 PM, Alexandru Stefan ISAILA wrote: > This patch aims to sanitize indexes, potentially guest provided > values, for altp2m_eptp[] and altp2m_p2m[] arrays. > > Requested-by: Jan Beulich > Signed-off-by: Alexandru Isaila > --- > CC: Razvan Cojocaru > CC: Tamas K Lengyel > CC: Pet

Re: [Xen-devel] [PATCH 2/4] tools/dombuilder: Remove PV-only, mandatory hooks

2019-12-23 Thread Julien Grall
Hi Andrew, On 17/12/2019 21:15, Andrew Cooper wrote: Currently, the setup_pgtable() hook is optional, but alloc_pgtable() hook is not. Both are specific to x86 PV guests, and stubbed in various ways by the dombuilders for translated guests (x86 HVM, ARM). Make alloc_pgtables() optional, and dr

Re: [Xen-devel] [PATCH 4/4] tools/dombuilder: Don't allocate dom->p2m_host[] for translated domains

2019-12-23 Thread Julien Grall
Hi, On 17/12/2019 21:15, Andrew Cooper wrote: xc_dom_p2m() and dom->p2m_host[] implement a linear transform for translated domains, but waste a substantial chunk of RAM doing so. ARM literally never reads dom->p2m_host[] (because of the xc_dom_translated() short circuit in xc_dom_p2m()). Drop

[Xen-devel] [xen-4.13-testing test] 145145: tolerable FAIL - PUSHED

2019-12-23 Thread osstest service owner
flight 145145 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/145145/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 12 guest-start fail like 144932 test-amd64-i386-xl-pvshim12

[Xen-devel] [xen-unstable-smoke test] 145155: tolerable all pass - PUSHED

2019-12-23 Thread osstest service owner
flight 145155 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/145155/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[Xen-devel] [qemu-mainline test] 145140: regressions - FAIL

2019-12-23 Thread osstest service owner
flight 145140 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/145140/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-amd64 14 guest-saverestore fail REGR. vs. 144861 test-amd64-i386-f

[Xen-devel] [examine test] 145152: tolerable trouble: pass/starved

2019-12-23 Thread osstest service owner
flight 145152 examine real [real] http://logs.test-lab.xenproject.org/osstest/logs/145152/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: examine-debina0 2 hosts-allocate starved n/a baseline version: flight 144269

[Xen-devel] [xen-unstable test] 145153: regressions - FAIL

2019-12-23 Thread osstest service owner
flight 145153 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/145153/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 145025 Tests whic

[Xen-devel] [qemu-mainline test] 145162: regressions - FAIL

2019-12-23 Thread osstest service owner
flight 145162 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/145162/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-amd64 14 guest-saverestore fail REGR. vs. 144861 test-amd64-i386-f