[Xen-devel] [ovmf test] 144770: regressions - FAIL

2019-12-13 Thread osstest service owner
flight 144770 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144770/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 144637 build-i386-xsm

Re: [Xen-devel] [xen-4.13-testing test] 144736: regressions - FAIL

2019-12-13 Thread Jürgen Groß
On 12.12.19 23:35, osstest service owner wrote: flight 144736 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/144736/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit1 7 xen-boot

Re: [Xen-devel] [PATCH] xen-blkback: prevent premature module unload

2019-12-13 Thread Jürgen Groß
On 10.12.19 15:53, Paul Durrant wrote: Objects allocated by xen_blkif_alloc come from the 'blkif_cache' kmem cache. This cache is destoyed when xen-blkif is unloaded so it is necessary to wait for the deferred free routine used for such objects to complete. This necessity was missed in commit 148

Re: [Xen-devel] [PATCH v3 3/4] xen/interface: re-define FRONT/BACK_RING_ATTACH()

2019-12-13 Thread Jürgen Groß
On 12.12.19 07:04, Jürgen Groß wrote: On 11.12.19 16:29, Paul Durrant wrote: Currently these macros are defined to re-initialize a front/back ring (respectively) to values read from the shared ring in such a way that any requests/responses that are added to the shared ring whilst the front/back

Re: [Xen-devel] [PATCH v3 3/4] xen/interface: re-define FRONT/BACK_RING_ATTACH()

2019-12-13 Thread Durrant, Paul
> -Original Message- > From: Jürgen Groß > Sent: 13 December 2019 09:00 > To: Durrant, Paul ; xen-devel@lists.xenproject.org; > linux-bl...@vger.kernel.org; linux-ker...@vger.kernel.org > Cc: Boris Ostrovsky ; Stefano Stabellini > > Subject: Re: [PATCH v3 3/4] xen/interface: re-define > F

Re: [Xen-devel] [PATCH net-next] xen-netback: get rid of old udev related code

2019-12-13 Thread Durrant, Paul
> -Original Message- > From: Jürgen Groß > Sent: 13 December 2019 05:41 > To: David Miller ; Durrant, Paul > > Cc: xen-devel@lists.xenproject.org; wei@kernel.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org > Subject: Re: [Xen-devel] [PATCH net-next] xen-netback: get rid o

Re: [Xen-devel] [PATCH v7 2/3] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-13 Thread Roger Pau Monné
On Thu, Dec 12, 2019 at 05:06:58PM +0100, SeongJae Park wrote: > On Thu, 12 Dec 2019 16:27:57 +0100 "Roger Pau Monné" > wrote: > > > > diff --git a/drivers/block/xen-blkback/blkback.c > > > b/drivers/block/xen-blkback/blkback.c > > > index fd1e19f1a49f..98823d150905 100644 > > > --- a/drivers/b

Re: [Xen-devel] [PATCH v7 2/3] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-13 Thread Jürgen Groß
On 13.12.19 10:27, Roger Pau Monné wrote: On Thu, Dec 12, 2019 at 05:06:58PM +0100, SeongJae Park wrote: On Thu, 12 Dec 2019 16:27:57 +0100 "Roger Pau Monné" wrote: diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index fd1e19f1a49f..98823d150905 100644

Re: [Xen-devel] [PATCH] x86/microcode: Support builtin CPU microcode

2019-12-13 Thread Jan Beulich
On 12.12.2019 23:17, Eslam Elnikety wrote: > On the "newest of everything": That's not what I intend to propose. The > microcode provided via a scan (or for that matter) will always > override the builtin microcode. The common case would be that the > microcode provided via a scan (or ) is newe

Re: [Xen-devel] [PATCH net-next] xen-netback: get rid of old udev related code

2019-12-13 Thread Jürgen Groß
On 13.12.19 10:24, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 13 December 2019 05:41 To: David Miller ; Durrant, Paul Cc: xen-devel@lists.xenproject.org; wei@kernel.org; linux- ker...@vger.kernel.org; net...@vger.kernel.org Subject: Re: [Xen-devel] [PATCH net-ne

Re: [Xen-devel] [PATCH V3 1/2] x86/altp2m: Add hypercall to set a range of sve bits

2019-12-13 Thread Alexandru Stefan ISAILA
On 03.12.2019 10:14, Jan Beulich wrote: > On 02.12.2019 15:40, Alexandru Stefan ISAILA wrote: >> On 29.11.2019 13:31, Jan Beulich wrote: >>> On 21.11.2019 16:02, Alexandru Stefan ISAILA wrote: @@ -4711,6 +4712,18 @@ static int do_altp2m_op( } break; >

Re: [Xen-devel] [PATCH V3 1/2] x86/altp2m: Add hypercall to set a range of sve bits

2019-12-13 Thread Alexandru Stefan ISAILA
On 03.12.2019 10:14, Jan Beulich wrote: > On 02.12.2019 15:40, Alexandru Stefan ISAILA wrote: >> On 29.11.2019 13:31, Jan Beulich wrote: >>> On 21.11.2019 16:02, Alexandru Stefan ISAILA wrote: @@ -4711,6 +4712,18 @@ static int do_altp2m_op( } break; >

Re: [Xen-devel] [PATCH net-next] xen-netback: get rid of old udev related code

2019-12-13 Thread Durrant, Paul
> -Original Message- > From: Jürgen Groß > Sent: 13 December 2019 10:02 > To: Durrant, Paul ; David Miller > > Cc: xen-devel@lists.xenproject.org; wei@kernel.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org > Subject: Re: [Xen-devel] [PATCH net-next] xen-netback: get rid o

[Xen-devel] [PATCH] public/io/ring.h: add FRONT/BACK_RING_ATTACH macros

2019-12-13 Thread Paul Durrant
The version of this header present in the Linux source tree has contained such macros for some time. These macros, as the names imply, allow front or back rings to be set up for existent (rather than freshly created and zeroed) shared rings. This patch is to update this, the canonical version of t

Re: [Xen-devel] [PATCH] public/io/ring.h: add FRONT/BACK_RING_ATTACH macros

2019-12-13 Thread Jürgen Groß
On 13.12.19 11:18, Paul Durrant wrote: The version of this header present in the Linux source tree has contained such macros for some time. These macros, as the names imply, allow front or back rings to be set up for existent (rather than freshly created and zeroed) shared rings. This patch is t

Re: [Xen-devel] [PATCH 2/4] x86/mm: Implement common put_data_pages for put_page_from_l[23]e

2019-12-13 Thread Jan Beulich
On 12.12.2019 18:32, George Dunlap wrote: > Both put_page_from_l2e and put_page_from_l3e handle having superpage > entries by looping over each page and "put"-ing each one individually. > As with putting page table entries, this code is functionally > identical, but for some reason different. More

Re: [Xen-devel] [PATCH 4/4] x86/mm: More discriptive names for page de/validation functions

2019-12-13 Thread Jan Beulich
On 12.12.2019 21:07, Andrew Cooper wrote: > On 12/12/2019 17:32, George Dunlap wrote: >> The functions alloc_page_type(), alloc_lN_table(), free_page_type() >> and free_lN_table() are confusingly named: > > There is alloc_segdesc_page() which should be adjusted for consistency. > >> nothing is be

Re: [Xen-devel] [XEN PATCH 3/8] xen: Update Kconfig to Linux v5.4

2019-12-13 Thread Jan Beulich
Just two minor remarks: On 12.12.2019 19:27, Anthony PERARD wrote: > --- /dev/null > +++ b/docs/misc/kconfig-macro-language.rst > @@ -0,0 +1,247 @@ > +== > +Kconfig macro language > +== > + > +Concept > +--- > + > +The basic idea was inspired by Make. Wh

Re: [Xen-devel] [XEN PATCH 6/8] xen: Move CONFIG_INDIRECT_THUNK to Kconfig

2019-12-13 Thread Jan Beulich
On 12.12.2019 19:27, Anthony PERARD wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -32,6 +32,9 @@ config ARCH_DEFCONFIG > string > default "arch/x86/configs/x86_64_defconfig" > > +config INDIRECT_THUNK > + def_bool $(cc-option,-mindirect-branch-register) I'

Re: [Xen-devel] [xen-4.13-testing test] 144736: regressions - FAIL

2019-12-13 Thread Julien Grall
Hi Juergen, On 13/12/2019 08:31, Jürgen Groß wrote: On 12.12.19 23:35, osstest service owner wrote: flight 144736 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/144736/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not

Re: [Xen-devel] [xen-4.13-testing test] 144736: regressions - FAIL

2019-12-13 Thread Jürgen Groß
On 13.12.19 12:14, Julien Grall wrote: Hi Juergen, On 13/12/2019 08:31, Jürgen Groß wrote: On 12.12.19 23:35, osstest service owner wrote: flight 144736 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/144736/ Regressions :-( Tests which did not succeed and are b

Re: [Xen-devel] [XEN PATCH 8/8] xen: Move GCC_HAS_VISIBILITY_ATTRIBUTE to Kconfig and common

2019-12-13 Thread Jan Beulich
On 12.12.2019 20:04, Andrew Cooper wrote: > On 12/12/2019 18:27, Anthony PERARD wrote: >> diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h >> index ff6c0f5cdd18..8c846261d241 100644 >> --- a/xen/include/xen/compiler.h >> +++ b/xen/include/xen/compiler.h >> @@ -78,7 +78,7 @@ >>

Re: [Xen-devel] [xen-4.13-testing test] 144736: regressions - FAIL

2019-12-13 Thread Julien Grall
On 13/12/2019 11:24, Jürgen Groß wrote: On 13.12.19 12:14, Julien Grall wrote: Hi Juergen, On 13/12/2019 08:31, Jürgen Groß wrote: On 12.12.19 23:35, osstest service owner wrote: flight 144736 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/144736/ Regressions

[Xen-devel] [xen-4.9-testing test] 144758: regressions - trouble: fail/pass/starved

2019-12-13 Thread osstest service owner
flight 144758 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/144758/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-ws16-amd64 16 guest-localmigrate/x10 fail REGR. vs. 144545 Tests wh

Re: [Xen-devel] [xen-4.13-testing test] 144736: regressions - FAIL

2019-12-13 Thread Ian Jackson
Julien Grall writes ("Re: [Xen-devel] [xen-4.13-testing test] 144736: regressions - FAIL"): > AMD Seattle boards (laxton*) are known to fail booting time to time > because of PCI training issue. We have workaround for it (involving > longer power cycle) but this is not 100% reliable. This wasn'

Re: [Xen-devel] [xen-4.9-testing test] 144723: regressions - trouble: fail/pass/starved

2019-12-13 Thread Jan Beulich
On 12.12.2019 18:18, Ian Jackson wrote: > osstest service owner writes ("[xen-4.9-testing test] 144723: regressions - > trouble: fail/pass/starved"): >> flight 144723 xen-4.9-testing real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/144723/ >> >> Regressions :-( >> >> Tests which did

Re: [Xen-devel] [PATCH v7 2/3] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-13 Thread SeongJae Park
On Fri, Dec 13, 2019 at 10:33 AM Jürgen Groß wrote: > > On 13.12.19 10:27, Roger Pau Monné wrote: > > On Thu, Dec 12, 2019 at 05:06:58PM +0100, SeongJae Park wrote: > >> On Thu, 12 Dec 2019 16:27:57 +0100 "Roger Pau Monné" > >> wrote: > >> > diff --git a/drivers/block/xen-blkback/blkback.c

Re: [Xen-devel] [xen-4.9-testing test] 144723: regressions - trouble: fail/pass/starved

2019-12-13 Thread Ian Jackson
Jan Beulich writes ("Re: [xen-4.9-testing test] 144723: regressions - trouble: fail/pass/starved"): > On 12.12.2019 18:18, Ian Jackson wrote: > > osstest service owner writes ("[xen-4.9-testing test] 144723: regressions - > > trouble: fail/pass/starved"): > >> flight 144723 xen-4.9-testing real [

[Xen-devel] [xen-4.9-testing test] 144782: trouble: preparing/queued

2019-12-13 Thread osstest service owner
flight 144782 xen-4.9-testing running [real] http://logs.test-lab.xenproject.org/osstest/logs/144782/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-amd64-pvgrub queued test-amd64-i386-

Re: [Xen-devel] [PATCH 4/4] x86/mm: More discriptive names for page de/validation functions

2019-12-13 Thread George Dunlap
> On Dec 13, 2019, at 10:48 AM, Jan Beulich wrote: > > On 12.12.2019 21:07, Andrew Cooper wrote: >> On 12/12/2019 17:32, George Dunlap wrote: >>> The functions alloc_page_type(), alloc_lN_table(), free_page_type() >>> and free_lN_table() are confusingly named: >> >> There is alloc_segdesc_page

Re: [Xen-devel] [XEN PATCH 6/8] xen: Move CONFIG_INDIRECT_THUNK to Kconfig

2019-12-13 Thread Anthony PERARD
On Fri, Dec 13, 2019 at 12:13:53PM +0100, Jan Beulich wrote: > On 12.12.2019 19:27, Anthony PERARD wrote: > > --- a/xen/arch/x86/Kconfig > > +++ b/xen/arch/x86/Kconfig > > @@ -32,6 +32,9 @@ config ARCH_DEFCONFIG > > string > > default "arch/x86/configs/x86_64_defconfig" > > > > +config IN

Re: [Xen-devel] [PATCH 4/4] x86/mm: More discriptive names for page de/validation functions

2019-12-13 Thread Jan Beulich
On 13.12.2019 13:00, George Dunlap wrote: > > >> On Dec 13, 2019, at 10:48 AM, Jan Beulich wrote: >> >> On 12.12.2019 21:07, Andrew Cooper wrote: >>> On 12/12/2019 17:32, George Dunlap wrote: The functions alloc_page_type(), alloc_lN_table(), free_page_type() and free_lN_table() are co

Re: [Xen-devel] [XEN PATCH 6/8] xen: Move CONFIG_INDIRECT_THUNK to Kconfig

2019-12-13 Thread Jan Beulich
On 13.12.2019 13:18, Anthony PERARD wrote: > On Fri, Dec 13, 2019 at 12:13:53PM +0100, Jan Beulich wrote: >> On 12.12.2019 19:27, Anthony PERARD wrote: >>> --- a/xen/arch/x86/Kconfig >>> +++ b/xen/arch/x86/Kconfig >>> @@ -32,6 +32,9 @@ config ARCH_DEFCONFIG >>> string >>> default "arch/x86/

[Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Jan Beulich
Containing still in flight DMA was introduced to work around certain devices / systems hanging hard upon hitting an IOMMU fault. Passing through (such) devices (on such systems) is inherently insecure (as guests could easily arrange for IOMMU faults to occur). Defaulting to a mode where admins may

[Xen-devel] [PATCH] x86emul: correct far branch handling for 64-bit mode

2019-12-13 Thread Jan Beulich
AMD and friends explicitly specify that 64-bit operands aren't possible for these insns. Nevertheless REX.W isn't fully ignored: It still cancels a possible operand size override (0x66). Intel otoh explicitly provides for 64-bit operands on the respective insn page of the SDM. Signed-off-by: Jan B

Re: [Xen-devel] [PATCH] x86emul: correct far branch handling for 64-bit mode

2019-12-13 Thread Andrew Cooper
On 13/12/2019 12:54, Jan Beulich wrote: > AMD and friends explicitly specify that 64-bit operands aren't possible > for these insns. Nevertheless REX.W isn't fully ignored: It still > cancels a possible operand size override (0x66). Intel otoh explicitly > provides for 64-bit operands on the respec

[Xen-devel] [PATCH v8 1/3] xenbus/backend: Add memory pressure handler callback

2019-12-13 Thread SeongJae Park
Granting pages consumes backend system memory. In systems configured with insufficient spare memory for those pages, it can cause a memory pressure situation. However, finding the optimal amount of the spare memory is challenging for large systems having dynamic resource utilization patterns. Al

[Xen-devel] [PATCH v8 0/3] xenbus/backend: Add a memory pressure handler callback

2019-12-13 Thread SeongJae Park
Granting pages consumes backend system memory. In systems configured with insufficient spare memory for those pages, it can cause a memory pressure situation. However, finding the optimal amount of the spare memory is challenging for large systems having dynamic resource utilization patterns. Al

[Xen-devel] [PATCH v8 2/3] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-13 Thread SeongJae Park
Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and is increased on demand while processing the I/O requests. If current I/O requests handling is finished or 100 milliseconds has passed since last I/O requests handling, it checks and shrinks the poo

[Xen-devel] [PATCH v8 3/3] xen/blkback: Remove unnecessary static variable name prefixes

2019-12-13 Thread SeongJae Park
A few of static variables in blkback have 'xen_blkif_' prefix, though it is unnecessary for static variables. This commit removes such prefixes. Reviewed-by: Roger Pau Monné Signed-off-by: SeongJae Park --- drivers/block/xen-blkback/blkback.c | 37 + 1 file changed,

[Xen-devel] [PATCH] public/io/netif.h: document a mechanism to advertise carrier state

2019-12-13 Thread Paul Durrant
This patch adds a specification for a 'carrier' node in xenstore to allow a backend to notify a frontend of it's virtual carrier/link state. E.g. a backend that is unable to forward packets from the guest because it is not attached to a bridge may wish to advertise 'no carrier'. NOTE: This is pure

Re: [Xen-devel] [PATCH] x86emul: correct far branch handling for 64-bit mode

2019-12-13 Thread Jan Beulich
On 13.12.2019 14:01, Andrew Cooper wrote: > On 13/12/2019 12:54, Jan Beulich wrote: >> AMD and friends explicitly specify that 64-bit operands aren't possible >> for these insns. Nevertheless REX.W isn't fully ignored: It still >> cancels a possible operand size override (0x66). Intel otoh explicit

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of Jan > Beulich > Sent: 13 December 2019 12:53 > To: xen-devel@lists.xenproject.org > Cc: Juergen Gross ; Kevin Tian ; > Stefano Stabellini ; Julien Grall > ; Wei Liu ; Konrad Wilk > ; George Dunlap ; > Andrew Cooper ; Paul Durrant ; > Ian

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Jürgen Groß
On 13.12.19 13:53, Jan Beulich wrote: Containing still in flight DMA was introduced to work around certain devices / systems hanging hard upon hitting an IOMMU fault. Passing through (such) devices (on such systems) is inherently insecure (as guests could easily arrange for IOMMU faults to occur)

[Xen-devel] [PATCH net v2] xen-netback: avoid race that can lead to NULL pointer dereference

2019-12-13 Thread Paul Durrant
In function xenvif_disconnect_queue(), the value of queue->rx_irq is zeroed *before* queue->task is stopped. Unfortunately that task may call notify_remote_via_irq(queue->rx_irq) and calling that function with a zero value results in a NULL pointer dereference in evtchn_from_irq(). This patch simp

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Jan Beulich
On 13.12.2019 14:11, Jürgen Groß wrote: > On 13.12.19 13:53, Jan Beulich wrote: >> Containing still in flight DMA was introduced to work around certain >> devices / systems hanging hard upon hitting an IOMMU fault. Passing >> through (such) devices (on such systems) is inherently insecure (as >> gu

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Jan Beulich
On 13.12.2019 14:12, Durrant, Paul wrote: >> -Original Message- >> From: Xen-devel On Behalf Of Jan >> Beulich >> Sent: 13 December 2019 12:53 >> To: xen-devel@lists.xenproject.org >> Cc: Juergen Gross ; Kevin Tian ; >> Stefano Stabellini ; Julien Grall >> ; Wei Liu ; Konrad Wilk >> ; Geor

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 13 December 2019 13:26 > To: Durrant, Paul > Cc: xen-devel@lists.xenproject.org; Juergen Gross ; Kevin > Tian ; Stefano Stabellini ; > Julien Grall ; Wei Liu ; Konrad Wilk > ; George Dunlap ; > Andrew Cooper ; Paul Durrant ; > Ian Jackson ;

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Jürgen Groß
On 13.12.19 14:21, Jan Beulich wrote: On 13.12.2019 14:11, Jürgen Groß wrote: On 13.12.19 13:53, Jan Beulich wrote: Containing still in flight DMA was introduced to work around certain devices / systems hanging hard upon hitting an IOMMU fault. Passing through (such) devices (on such systems) i

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Jan Beulich
On 13.12.2019 14:29, Durrant, Paul wrote: >> From: Jan Beulich >> Sent: 13 December 2019 13:26 >> >> On 13.12.2019 14:12, Durrant, Paul wrote: From: Xen-devel On Behalf Of Jan Beulich Sent: 13 December 2019 12:53 +#define IOMMU_quarantine_none 0 +#define IOMMU_quara

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Jan Beulich
On 13.12.2019 14:31, Jürgen Groß wrote: > On 13.12.19 14:21, Jan Beulich wrote: >> On 13.12.2019 14:11, Jürgen Groß wrote: >>> On 13.12.19 13:53, Jan Beulich wrote: Containing still in flight DMA was introduced to work around certain devices / systems hanging hard upon hitting an IOMMU fa

Re: [Xen-devel] [PATCH] x86/microcode: Support builtin CPU microcode

2019-12-13 Thread Andrew Cooper
On 09/12/2019 21:49, Eslam Elnikety wrote: >>> + >>> +extern const char __builtin_intel_ucode_start[], >>> __builtin_intel_ucode_end[]; >>> +extern const char __builtin_amd_ucode_start[], >>> __builtin_amd_ucode_end[]; >>> +#endif >>> + >>>   /* By default, ucode loading is done in NMI handler */ >

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Jürgen Groß
On 13.12.19 14:38, Jan Beulich wrote: On 13.12.2019 14:31, Jürgen Groß wrote: On 13.12.19 14:21, Jan Beulich wrote: On 13.12.2019 14:11, Jürgen Groß wrote: On 13.12.19 13:53, Jan Beulich wrote: Containing still in flight DMA was introduced to work around certain devices / systems hanging hard

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of > Jürgen Groß > Sent: 13 December 2019 13:47 > To: Jan Beulich > Cc: Kevin Tian ; Stefano Stabellini > ; Julien Grall ; Wei Liu > ; Konrad Wilk ; George Dunlap > ; Andrew Cooper ; > Paul Durrant ; Ian Jackson ; xen- > de...@lists.xenproj

Re: [Xen-devel] [PATCH] x86/microcode: Support builtin CPU microcode

2019-12-13 Thread Andrew Cooper
On 12/12/2019 22:13, Eslam Elnikety wrote: >>> Second, there is often need to couple a Xen build with a minimum >>> microcode patch level. Having the microcode built within the Xen image >>> itself is a streamlined, natural way of achieving that. >> >> Okay, I can accept this as a reason, to some d

Re: [Xen-devel] [PATCH 2/4] x86/mm: Implement common put_data_pages for put_page_from_l[23]e

2019-12-13 Thread George Dunlap
> On Dec 12, 2019, at 7:57 PM, Andrew Cooper wrote: > > On 12/12/2019 17:32, George Dunlap wrote: >> Both put_page_from_l2e and put_page_from_l3e handle having superpage >> entries by looping over each page and "put"-ing each one individually. >> As with putting page table entries, this code is

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Jan Beulich
On 13.12.2019 14:46, Jürgen Groß wrote: > On 13.12.19 14:38, Jan Beulich wrote: >> On 13.12.2019 14:31, Jürgen Groß wrote: >>> Maybe I have misunderstood the current state, but I thought that it >>> would just silently hide quirky devices without imposing a security >>> risk. We would not learn whi

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Roger Pau Monné
On Fri, Dec 13, 2019 at 01:53:29PM +0100, Jan Beulich wrote: > Containing still in flight DMA was introduced to work around certain > devices / systems hanging hard upon hitting an IOMMU fault. Passing > through (such) devices (on such systems) is inherently insecure (as > guests could easily arran

Re: [Xen-devel] [PATCH] public/io/netif.h: document a mechanism to advertise carrier state

2019-12-13 Thread Jürgen Groß
On 13.12.19 14:03, Paul Durrant wrote: This patch adds a specification for a 'carrier' node in xenstore to allow a backend to notify a frontend of it's virtual carrier/link state. E.g. a backend that is unable to forward packets from the guest because it is not attached to a bridge may wish to ad

Re: [Xen-devel] [PATCH v4 1/2] x86/mm: factor out the code for shattering an l3 PTE

2019-12-13 Thread Andrew Cooper
On 12/12/2019 12:46, Hongyan Xia wrote: > diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c > index 7d4dd80a85..8def4fb8d8 100644 > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -5151,6 +5151,52 @@ l1_pgentry_t *virt_to_xen_l1e(unsigned long v) > flush_area_local

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Jan Beulich
On 13.12.2019 14:53, Durrant, Paul wrote: > Since *not* having the 'sink' page allows a guest pull off a host DoS > in the presence of such h/w, security is surely increased by having it? hostdevice result w/o sink result w/ sink goodgoodgood

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Jürgen Groß
On 13.12.19 15:11, Jan Beulich wrote: On 13.12.2019 14:46, Jürgen Groß wrote: On 13.12.19 14:38, Jan Beulich wrote: On 13.12.2019 14:31, Jürgen Groß wrote: Maybe I have misunderstood the current state, but I thought that it would just silently hide quirky devices without imposing a security ri

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Jürgen Groß
On 13.12.19 15:23, Jan Beulich wrote: On 13.12.2019 14:53, Durrant, Paul wrote: Since *not* having the 'sink' page allows a guest pull off a host DoS in the presence of such h/w, security is surely increased by having it? hostdevice result w/o sink result w/ sink g

Re: [Xen-devel] [PATCH v8 2/3] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-13 Thread Roger Pau Monné
On Fri, Dec 13, 2019 at 01:02:10PM +, SeongJae Park wrote: > Each `blkif` has a free pages pool for the grant mapping. The size of > the pool starts from zero and is increased on demand while processing > the I/O requests. If current I/O requests handling is finished or 100 > milliseconds has

Re: [Xen-devel] [PATCH v4 1/2] x86/mm: factor out the code for shattering an l3 PTE

2019-12-13 Thread Jan Beulich
On 13.12.2019 15:19, Andrew Cooper wrote: > On 12/12/2019 12:46, Hongyan Xia wrote: >> diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c >> index 7d4dd80a85..8def4fb8d8 100644 >> --- a/xen/arch/x86/mm.c >> +++ b/xen/arch/x86/mm.c >> @@ -5151,6 +5151,52 @@ l1_pgentry_t *virt_to_xen_l1e(unsigned lon

Re: [Xen-devel] [PATCH v4 0/2] Refactor super page shattering

2019-12-13 Thread Andrew Cooper
On 12/12/2019 13:16, Jan Beulich wrote: > On 12.12.2019 13:46, Hongyan Xia wrote: >> map_pages_to_xen and modify_xen_mappings use almost exactly the same >> page shattering logic, and the code is mingled with other PTE >> manipulations so it is less obvious that the intention is page >> shattering.

Re: [Xen-devel] [XEN PATCH 7/8] xen: Use $(CONFIG_CC_IS_CLANG) instead of $(clang) in Makefile

2019-12-13 Thread Anthony PERARD
On Thu, Dec 12, 2019 at 07:00:35PM +, Andrew Cooper wrote: > On 12/12/2019 18:27, Anthony PERARD wrote: > > Kconfig can check if $(CC) is clang or not, if it is > > CONFIG_CC_IS_CLANG will be set. > > > > With that patch, the hypervisor can be built using clang by running > > `make CC=clang CXX

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Jan Beulich
On 13.12.2019 15:29, Jürgen Groß wrote: > On 13.12.19 15:23, Jan Beulich wrote: >> On 13.12.2019 14:53, Durrant, Paul wrote: >>> Since *not* having the 'sink' page allows a guest pull off a host DoS >>> in the presence of such h/w, security is surely increased by having it? >> >> host devic

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Jan Beulich
On 13.12.2019 15:24, Jürgen Groß wrote: > On 13.12.19 15:11, Jan Beulich wrote: >> On 13.12.2019 14:46, Jürgen Groß wrote: >>> On 13.12.19 14:38, Jan Beulich wrote: On 13.12.2019 14:31, Jürgen Groß wrote: > Maybe I have misunderstood the current state, but I thought that it > would jus

Re: [Xen-devel] [XEN PATCH 1/8] Config.mk: Remove unused setvar_dir macro

2019-12-13 Thread Anthony PERARD
On Thu, Dec 12, 2019 at 06:30:43PM +, Andrew Cooper wrote: > On 12/12/2019 18:27, Anthony PERARD wrote: > > diff --git a/docs/misc/distro_mapping.txt b/docs/misc/distro_mapping.txt > > index 2e46592728e3..599b6fd1e912 100644 > > --- a/docs/misc/distro_mapping.txt > > +++ b/docs/misc/distro_mapp

Re: [Xen-devel] [PATCH v4 1/2] x86/mm: factor out the code for shattering an l3 PTE

2019-12-13 Thread Andrew Cooper
On 13/12/2019 14:36, Jan Beulich wrote: > On 13.12.2019 15:19, Andrew Cooper wrote: >> On 12/12/2019 12:46, Hongyan Xia wrote: >>> diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c >>> index 7d4dd80a85..8def4fb8d8 100644 >>> --- a/xen/arch/x86/mm.c >>> +++ b/xen/arch/x86/mm.c >>> @@ -5151,6 +5151,

Re: [Xen-devel] [PATCH v8 2/3] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-13 Thread SeongJae Park
On Fri, 13 Dec 2019 15:34:35 +0100 "Roger Pau Monné" wrote: > > Each `blkif` has a free pages pool for the grant mapping. The size of > > the pool starts from zero and is increased on demand while processing > > the I/O requests. If current I/O requests handling is finished or 100 > > millisec

Re: [Xen-devel] [PATCH 2/4] x86/mm: Implement common put_data_pages for put_page_from_l[23]e

2019-12-13 Thread Andrew Cooper
On 13/12/2019 13:58, George Dunlap wrote: > >> On Dec 12, 2019, at 7:57 PM, Andrew Cooper wrote: >> >> On 12/12/2019 17:32, George Dunlap wrote: >>> Both put_page_from_l2e and put_page_from_l3e handle having superpage >>> entries by looping over each page and "put"-ing each one individually. >>> A

Re: [Xen-devel] [XEN PATCH 2/8] Config.mk: Remove stray comment

2019-12-13 Thread Anthony PERARD
On Thu, Dec 12, 2019 at 06:32:27PM +, Andrew Cooper wrote: > On 12/12/2019 18:27, Anthony PERARD wrote: > > This comment isn't about CONFIG_TESTS, but about SEABIOS_DIR that has > > been removed. > > > > Originally, the comment was added by 5f82d0858de1 ("tools: support > > SeaBIOS. Use by defa

Re: [Xen-devel] [XEN PATCH 3/8] xen: Update Kconfig to Linux v5.4

2019-12-13 Thread Anthony PERARD
On Thu, Dec 12, 2019 at 06:45:02PM +, Andrew Cooper wrote: > On 12/12/2019 18:27, Anthony PERARD wrote: > > Dependency change: > > - Now depends on flex/bison, maybe we could _shipped those files like > > before. Linux doesn't do that anymore. > > Content like that should not be checked in t

Re: [Xen-devel] [PATCH] public/io/netif.h: document a mechanism to advertise carrier state

2019-12-13 Thread Durrant, Paul
> -Original Message- > From: Jürgen Groß > Sent: 13 December 2019 14:17 > To: Durrant, Paul ; xen-devel@lists.xenproject.org > Cc: Konrad Rzeszutek Wilk > Subject: Re: [PATCH] public/io/netif.h: document a mechanism to advertise > carrier state > > On 13.12.19 14:03, Paul Durrant wrote:

[Xen-devel] [PATCH v9 0/4] xenbus/backend: Add a memory pressure handler callback

2019-12-13 Thread SeongJae Park
Granting pages consumes backend system memory. In systems configured with insufficient spare memory for those pages, it can cause a memory pressure situation. However, finding the optimal amount of the spare memory is challenging for large systems having dynamic resource utilization patterns. Al

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-13 Thread Jürgen Groß
On 13.12.19 15:45, Jan Beulich wrote: On 13.12.2019 15:24, Jürgen Groß wrote: On 13.12.19 15:11, Jan Beulich wrote: On 13.12.2019 14:46, Jürgen Groß wrote: On 13.12.19 14:38, Jan Beulich wrote: On 13.12.2019 14:31, Jürgen Groß wrote: Maybe I have misunderstood the current state, but I though

[Xen-devel] [PATCH v9 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-13 Thread SeongJae Park
Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and is increased on demand while processing the I/O requests. If current I/O requests handling is finished or 100 milliseconds has passed since last I/O requests handling, it checks and shrinks the poo

[Xen-devel] [PATCH v9 4/4] xen/blkback: Consistently insert one empty line between functions

2019-12-13 Thread SeongJae Park
The number of empty lines between functions in the xenbus.c is inconsistent. This trivial style cleanup commit fixes the file to consistently place only one empty line. Signed-off-by: SeongJae Park --- drivers/block/xen-blkback/xenbus.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(

[Xen-devel] [PATCH v9 1/4] xenbus/backend: Add memory pressure handler callback

2019-12-13 Thread SeongJae Park
Granting pages consumes backend system memory. In systems configured with insufficient spare memory for those pages, it can cause a memory pressure situation. However, finding the optimal amount of the spare memory is challenging for large systems having dynamic resource utilization patterns. Al

[Xen-devel] [PATCH v9 3/4] xen/blkback: Remove unnecessary static variable name prefixes

2019-12-13 Thread SeongJae Park
A few of static variables in blkback have 'xen_blkif_' prefix, though it is unnecessary for static variables. This commit removes such prefixes. Reviewed-by: Roger Pau Monné Signed-off-by: SeongJae Park --- drivers/block/xen-blkback/blkback.c | 37 + 1 file changed,

Re: [Xen-devel] [xen-4.13-testing test] 144736: regressions - FAIL

2019-12-13 Thread Julien Grall
+Anthony On 13/12/2019 11:40, Ian Jackson wrote: Julien Grall writes ("Re: [Xen-devel] [xen-4.13-testing test] 144736: regressions - FAIL"): AMD Seattle boards (laxton*) are known to fail booting time to time because of PCI training issue. We have workaround for it (involving longer power cycl

Re: [Xen-devel] [XEN PATCH 3/8] xen: Update Kconfig to Linux v5.4

2019-12-13 Thread Anthony PERARD
On Fri, Dec 13, 2019 at 12:05:11PM +0100, Jan Beulich wrote: > Just two minor remarks: > > On 12.12.2019 19:27, Anthony PERARD wrote: > > --- /dev/null > > +++ b/docs/misc/kconfig-macro-language.rst [...] > > +Then, Kconfig moves onto the evaluation stage to resolve inter-symbol > > +dependency as

[Xen-devel] [PATCH v2] public/io/netif.h: document a mechanism to advertise carrier state

2019-12-13 Thread Paul Durrant
This patch adds a specification for a 'carrier' node in xenstore to allow a backend to notify a frontend of it's virtual carrier/link state. E.g. a backend that is unable to forward packets from the guest because it is not attached to a bridge may wish to advertise 'no carrier'. While in the area

Re: [Xen-devel] [xen-4.13-testing test] 144736: regressions - FAIL

2019-12-13 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of > Julien Grall > Sent: 13 December 2019 15:37 > To: Ian Jackson > Cc: Jürgen Groß ; xen-devel@lists.xenproject.org; Stefano > Stabellini ; osstest service owner ad...@xenproject.org>; Anthony Perard > Subject: Re: [Xen-devel] [xen-4.13

Re: [Xen-devel] [PATCH v4 1/2] x86/mm: factor out the code for shattering an l3 PTE

2019-12-13 Thread Xia, Hongyan
Hi, On Fri, 2019-12-13 at 14:19 +, Andrew Cooper wrote: > On 12/12/2019 12:46, Hongyan Xia wrote: > > diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c > > index 7d4dd80a85..8def4fb8d8 100644 > > --- a/xen/arch/x86/mm.c > > +++ b/xen/arch/x86/mm.c > > @@ -5151,6 +5151,52 @@ l1_pgentry_t *virt

Re: [Xen-devel] [PATCH v2] public/io/netif.h: document a mechanism to advertise carrier state

2019-12-13 Thread Jürgen Groß
On 13.12.19 16:51, Paul Durrant wrote: This patch adds a specification for a 'carrier' node in xenstore to allow a backend to notify a frontend of it's virtual carrier/link state. E.g. a backend that is unable to forward packets from the guest because it is not attached to a bridge may wish to ad

Re: [Xen-devel] [PATCH v4 1/2] x86/mm: factor out the code for shattering an l3 PTE

2019-12-13 Thread Xia, Hongyan
On Fri, 2019-12-13 at 14:58 +, Andrew Cooper wrote: > On 13/12/2019 14:36, Jan Beulich wrote: > > On 13.12.2019 15:19, Andrew Cooper wrote: > > > On 12/12/2019 12:46, Hongyan Xia wrote: > > > > diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c > > > > index 7d4dd80a85..8def4fb8d8 100644 > > >

Re: [Xen-devel] [XEN PATCH 4/8] xen: Have Kconfig check $(CC)'s version

2019-12-13 Thread Anthony PERARD
On Thu, Dec 12, 2019 at 06:56:00PM +, Andrew Cooper wrote: > On 12/12/2019 18:27, Anthony PERARD wrote: > > diff --git a/xen/Makefile b/xen/Makefile > > index efbe9605e52b..0cf4ded9d9d4 100644 > > --- a/xen/Makefile > > +++ b/xen/Makefile > > @@ -267,6 +267,7 @@ $(foreach base,arch/x86/mm/guest

[Xen-devel] [PATCH 01/12] hw/i386/pc: Convert DPRINTF() to trace events

2019-12-13 Thread Philippe Mathieu-Daudé
Convert the deprecated DPRINTF() macro to trace events. Signed-off-by: Philippe Mathieu-Daudé --- v2: rename pc_pic -> x86_pic --- hw/i386/pc.c | 19 +-- hw/i386/trace-events | 6 ++ 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/hw/i386/pc.c b/hw/i

[Xen-devel] [PATCH 00/12] hw/i386/pc: Move PC-machine specific declarations to 'pc_internal.h'

2019-12-13 Thread Philippe Mathieu-Daudé
Hi Paolo, Since you posted your "x86: allow building without PC machine types" series [1], I looked at my past work on this topic (restrict "hw/i386/pc.h" to the X86 architecture). I'm glad to see in [2] you remove most (all) of the last uses. Since I haven't looked at this for some time, my WiP b

[Xen-devel] [PATCH 02/12] hw/i386/pc: Move kvm_i8259_init() declaration to sysemu/kvm.h

2019-12-13 Thread Philippe Mathieu-Daudé
Move the KVM-related call to "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 1 - include/sysemu/kvm.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 1f86eba3f9..9866dfbd60 100644 --- a/includ

[Xen-devel] [PATCH 04/12] hw/i386/pc: Remove obsolete cpu_set_smm_t typedef

2019-12-13 Thread Philippe Mathieu-Daudé
In commit f809c6051 we replaced the use of cpu_set_smm_t callbacks by using a Notifier to modify the MemoryRegion. This prototype is now not used anymore, we can safely remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/

[Xen-devel] [PATCH 05/12] hw/i386/ich9: Remove unused include

2019-12-13 Thread Philippe Mathieu-Daudé
The "pcie_host.h" header is used by devices providing a PCI-e bus, usually North Bridges. The ICH9 is a South Bridge. Since we don't need this header, do not include it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/ich9.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw

[Xen-devel] [PATCH 03/12] hw/i386/pc: Remove obsolete pc_pci_device_init() declaration

2019-12-13 Thread Philippe Mathieu-Daudé
In commit 1454509726 we removed the pc_pci_device_init() deprecated function and its calls, but we forgot to remove its prototype. Do that now. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386

[Xen-devel] [PATCH 06/12] hw/i386/ich9: Move unnecessary "pci_bridge.h" include

2019-12-13 Thread Philippe Mathieu-Daudé
While the ICH9 chipset is a 'South Bridge', it is not a PCI bridge. Nothing in "hw/i386/ich9.h" requires definitions from "pci_bridge.h" so move its inclusion where it is required. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/ich9.h| 1 - hw/i386/acpi-build.c | 1 + hw/pci-

[Xen-devel] [PATCH 07/12] hw/ide/piix: Remove superfluous DEVICE() cast

2019-12-13 Thread Philippe Mathieu-Daudé
Commit 02a9594b4f0 already converted 'dev' to DeviceState. Since the cast is superfluous, remove it. Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/piix.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index db313dd3b1..ffeff4e095 100644 ---

[Xen-devel] [PATCH 09/12] hw/intc/ioapic: Make ioapic_print_redtbl() static

2019-12-13 Thread Philippe Mathieu-Daudé
Since commit 0c8465440 the ioapic_print_redtbl() function is not used outside of ioapic_common.c, make it static, and remove its prototype declaration in "ioapic_internal.h". Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/ioapic_internal.h | 1 - hw/intc/ioapic_common.c | 2

[Xen-devel] [PATCH 10/12] hw/i386/pc: Rename allocate_cpu_irq from 'pc' to 'x86_machine'

2019-12-13 Thread Philippe Mathieu-Daudé
All the X86 machines use an interrupt controller. Rename the function to something more generic. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 2 +- hw/i386/microvm.c| 2 +- hw/i386/pc.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/inclu

  1   2   >