[Xen-devel] [xen-unstable test] 144635: trouble: blocked/broken/fail/pass

flight 144635 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/144635/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd broken test-amd64-amd64-xl-

[Xen-devel] [libvirt test] 144636: regressions - trouble: blocked/broken/fail/pass

flight 144636 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/144636/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt broken build-i386-libvirt4 host-install(4

[Xen-devel] [PATCH] x86/microcode: Support builtin CPU microcode

Xen relies on boot modules to perform early microcode updates. This commit adds another mode, namely "builtin" via the BUILTIN_UCODE config parameter. If set, the Xen image itself will contain the microcode updates. Upon boot, Xen inspects its image for microcode blobs and performs the update. A X

[Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and be increased on demand while processing the I/O requests. If current I/O requests handling is finished or 100 milliseconds has passed since last I/O requests handling, it checks and shrinks the poo

[Xen-devel] [PATCH v3 1/1] xen/blkback: Squeeze page pools if a memory pressure is detected

From: SeongJae Park Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and be increased on demand while processing the I/O requests. If current I/O requests handling is finished or 100 milliseconds has passed since last I/O requests handling, it chec

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

On 09.12.19 09:58, SeongJae Park wrote: Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and be increased on demand while processing the I/O requests. If current I/O requests handling is finished or 100 milliseconds has passed since last I/O reques

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 09:39 > To: Park, Seongjae ; ax...@kernel.dk; > konrad.w...@oracle.com; roger@citrix.com > Cc: linux-bl...@vger.kernel.org; linux-ker...@vger.kernel.org; Durrant, > Paul ; sj38.p...@gmail.com; xen- > de...@lists.xenproje

[Xen-devel] [PATCH-for-5.0 v3 2/6] hw/pci-host/i440fx: Extract PCII440FXState to "hw/pci-host/i440fx.h"

Make the PCII440FXState structure public, so it can be used out of this source file. This will allow us to extract the IGD Passthrough Host Bridge, which is a children of the TYPE_I440FX_PCI_DEVICE. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci-host/i440fx.h | 19 +--

[Xen-devel] [PATCH-for-5.0 v3 4/6] hw/pci-host/i440fx: Use definitions instead of magic values

Use definitions from "hw/pci/pci_regs.h". This also helps when using git-grep. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/i440fx.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c index 0cc80b276d..414138595

[Xen-devel] [PATCH-for-5.0 v3 1/6] hw/pci-host/i440fx: Correct the header description

Missed during the refactor in commits 14a026dd58 and 0f25d865a, this file is now only about the i440FX chipset. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/i440fx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c index f27

[Xen-devel] [PATCH-for-5.0 v3 5/6] hw/pci-host/i440fx: Extract the IGD passthrough host bridge device

We can use a i440FX without the IGD passthrough host bridge. Extract it into a new file, 'hw/pci-host/igd_pt.c'. Signed-off-by: Philippe Mathieu-Daudé --- v3: - Rename as 'xen_igd_pt.c' (Alex Williamson) - Add an entry in MAINTAINERS::Xen --- hw/pci-host/i440fx.c | 84 -

[Xen-devel] [PATCH-for-5.0 v3 3/6] hw/pci-host/i440fx: Use size_t to iterate over ARRAY_SIZE()

We don't enforce the -Wsign-conversion CPPFLAG, but it doesn't hurt to avoid this warning: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion] Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/i440fx.c | 5 ++--- 1 file changed, 2

[Xen-devel] [PATCH-for-5.0 v3 0/6] hw/pci-host: Add Kconfig selector for IGD PCIe pass-through

Introduce a kconfig selector to allow builds without Intel Integrated Graphics Device GPU PCIe passthrough. This device is enabled by default on the Xen build. v3: - Make it Xen specific v2: - do not mix with vfio code (Alex) - extract to different file to avoid #ifdef (Thomas) Philippe Mathieu

[Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge

Add the XEN_IGD_PASSTHROUGH Kconfig option. Xen build has that option selected by default. Non-Xen builds now have to select this feature manually. Signed-off-by: Philippe Mathieu-Daudé --- v3: Only default with Xen (Alex Williamson) I did not used 'depends on XEN' as suggested by Alex but 'def

Re: [Xen-devel] [PATCH-for-5.0 v3 1/6] hw/pci-host/i440fx: Correct the header description

On 09/12/2019 10.49, Philippe Mathieu-Daudé wrote: > Missed during the refactor in commits 14a026dd58 and 0f25d865a, > this file is now only about the i440FX chipset. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/i440fx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Xen-devel] [PATCH-for-5.0 v3 2/6] hw/pci-host/i440fx: Extract PCII440FXState to "hw/pci-host/i440fx.h"

On 09/12/2019 10.49, Philippe Mathieu-Daudé wrote: > Make the PCII440FXState structure public, so it can be used out of > this source file. This will allow us to extract the IGD Passthrough > Host Bridge, which is a children of the TYPE_I440FX_PCI_DEVICE. > > Signed-off-by: Philippe Mathieu-Daudé

Re: [Xen-devel] [PATCH-for-5.0 v3 3/6] hw/pci-host/i440fx: Use size_t to iterate over ARRAY_SIZE()

On 09/12/2019 10.49, Philippe Mathieu-Daudé wrote: > We don't enforce the -Wsign-conversion CPPFLAG, but it doesn't hurt > to avoid this warning: > > warning: implicit conversion changes signedness: 'int' to 'size_t' (aka > 'unsigned long') [-Wsign-conversion] > > Signed-off-by: Philippe Mathi

Re: [Xen-devel] [PATCH-for-5.0 v3 4/6] hw/pci-host/i440fx: Use definitions instead of magic values

On 09/12/2019 10.50, Philippe Mathieu-Daudé wrote: > Use definitions from "hw/pci/pci_regs.h". > This also helps when using git-grep. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/i440fx.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/hw

Re: [Xen-devel] [PATCH-for-5.0 v3 5/6] hw/pci-host/i440fx: Extract the IGD passthrough host bridge device

> -Original Message- > From: Xen-devel On Behalf Of > Philippe Mathieu-Daudé > Sent: 09 December 2019 09:50 > To: qemu-de...@nongnu.org > Cc: Thomas Huth ; Stefano Stabellini > ; Michael S. Tsirkin ; Paul > Durrant ; Markus Armbruster ; Alex > Williamson ; Marcel Apfelbaum > ; Paolo Bonzin

Re: [Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge

> -Original Message- > From: Xen-devel On Behalf Of > Philippe Mathieu-Daudé > Sent: 09 December 2019 09:50 > To: qemu-de...@nongnu.org > Cc: Thomas Huth ; Stefano Stabellini > ; Michael S. Tsirkin ; Paul > Durrant ; Markus Armbruster ; Alex > Williamson ; Marcel Apfelbaum > ; Paolo Bonzin

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

On 09.12.19 10:46, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 09 December 2019 09:39 To: Park, Seongjae ; ax...@kernel.dk; konrad.w...@oracle.com; roger@citrix.com Cc: linux-bl...@vger.kernel.org; linux-ker...@vger.kernel.org; Durrant, Paul ; sj38.p...@gmail.com;

Re: [Xen-devel] [PATCH v3] x86: do not enable global pages when virtualized on AMD hardware

On Wed, Dec 04, 2019 at 06:05:11PM +0100, Jan Beulich wrote: > On 04.12.2019 17:18, Roger Pau Monné wrote: > > On Wed, Dec 04, 2019 at 05:11:42PM +0100, Jan Beulich wrote: > >> On 04.12.2019 16:12, Roger Pau Monne wrote: > >>> @@ -130,7 +143,7 @@ unsigned long pv_make_cr4(const struct vcpu *v) > >>

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

On Mon, 9 Dec 2019 10:39:02 +0100 Juergen wrote: >On 09.12.19 09:58, SeongJae Park wrote: >> Each `blkif` has a free pages pool for the grant mapping. The size of >> the pool starts from zero and be increased on demand while processing >> the I/O requests. If current I/O requests handling is

Re: [Xen-devel] [PATCH v3 2/4] x86/apic: force phys mode if interrupt remapping is disabled

On Thu, Dec 05, 2019 at 10:32:34AM +0100, Jan Beulich wrote: > On 04.12.2019 17:20, Roger Pau Monne wrote: > > Cluster mode can only be used with interrupt remapping support, since > > the top 16bits of the APIC ID are filled with the cluster ID, and > > hence on systems where the physical ID is st

Re: [Xen-devel] [PATCH v3 3/4] x86/smp: check APIC ID on AP bringup

On Thu, Dec 05, 2019 at 10:33:44AM +0100, Jan Beulich wrote: > On 04.12.2019 17:20, Roger Pau Monne wrote: > > Check that the processor to be woken up APIC ID is addressable in the > > current APIC mode. > > > > Note that in practice systems with APIC IDs > 255 should already have > > x2APIC enabl

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

On 09.12.19 11:23, SeongJae Park wrote: On Mon, 9 Dec 2019 10:39:02 +0100 Juergen wrote: On 09.12.19 09:58, SeongJae Park wrote: Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and be increased on demand while processing the I/O requests. I

Re: [Xen-devel] Problem booting Debian buster on arndale

Hi, On 06/12/2019 18:08, Ian Jackson wrote: Julien Grall writes ("Re: Problem booting Debian buster on arndale"): On 06/12/2019 16:47, Ian Jackson wrote: It seems to have hung during boot. NB that I don't know whether this is a one-off. Looking at [1], most of the recent flight have managed

Re: [Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge

On 09/12/19 10:50, Philippe Mathieu-Daudé wrote: > Add the XEN_IGD_PASSTHROUGH Kconfig option. > > Xen build has that option selected by default. Non-Xen builds now > have to select this feature manually. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v3: Only default with Xen (Alex Williamso

Re: [Xen-devel] [PATCH v3 1/3] xen/flask: Drop the gen-policy.py script

On Sat, Dec 7, 2019 at 9:17 PM Andrew Cooper wrote: > > The script is Python 2 specific, and fails with string/binary issues with > Python 3: > > Traceback (most recent call last): > File "gen-policy.py", line 14, in > for char in sys.stdin.read(): > File "/usr/lib/python3.5/codec

Re: [Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge

On 09/12/19 11:10, Durrant, Paul wrote: >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> v3: Only default with Xen (Alex Williamson) >> >> I did not used 'depends on XEN' as suggested by Alex but >> 'default y if XEN', so one can build XEN without this feature >> (for example, on other ARCH t

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

On Mon, 9 Dec 2019 11:15:22 +0100 "Jürgen Groß" wrote: >On 09.12.19 10:46, Durrant, Paul wrote: >>> -Original Message- >>> From: Jürgen Groß >>> Sent: 09 December 2019 09:39 >>> To: Park, Seongjae ; ax...@kernel.dk; >>> konrad.w...@oracle.com; roger@citrix.com >>> Cc: linux-bl...@vge

Re: [Xen-devel] [PATCH v3 4/4] x86/apic: allow enabling x2APIC mode regardless of interrupt remapping

On Thu, Dec 05, 2019 at 10:45:59AM +0100, Jan Beulich wrote: > On 04.12.2019 17:20, Roger Pau Monne wrote: > > +switch ( iommu_enable_x2apic() ) > > { > > +case 0: > > +iommu_x2apic_enabled = true; > > +break; > > + > > +case -ENXIO: /* ACPI_

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

On 09.12.19 11:52, SeongJae Park wrote: On Mon, 9 Dec 2019 11:15:22 +0100 "Jürgen Groß" wrote: On 09.12.19 10:46, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 09 December 2019 09:39 To: Park, Seongjae ; ax...@kernel.dk; konrad.w...@oracle.com; roger@citrix.com

Re: [Xen-devel] [PATCH v3 3/3] xen/build: Automatically locate a suitable python interpreter

On 12/7/19 9:16 PM, Andrew Cooper wrote: > Needing to pass PYTHON=python3 into hypervisor builds is irritating and > unnecessary. Locate a suitable interpreter automatically, defaulting to Py3 > if it is available. > > Reported-by: Steven Haigh > Signed-off-by: Andrew Cooper > --- > CC: George

Re: [Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge

On 12/9/19 11:42 AM, Paolo Bonzini wrote: On 09/12/19 11:10, Durrant, Paul wrote: Signed-off-by: Philippe Mathieu-Daudé --- v3: Only default with Xen (Alex Williamson) I did not used 'depends on XEN' as suggested by Alex but 'default y if XEN', so one can build XEN without this feature (for e

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

On 06/12/2019, 09:51, "Jan Beulich" wrote: On 06.12.2019 00:41, Lars Kurth wrote: > I propose to add the following section to code-review-guide.md > > > ## Problematic Patch Reviews > > A typical waterfall software development process is sequential with the

Re: [Xen-devel] [PATCH v3 2/3] xen/banner: Drop the fig-to-oct.py script

On 12/7/19 9:16 PM, Andrew Cooper wrote: > The script is 664 rather than 775, so the banner conversion doesn't actually > work if $(PYTHON) is empty: > > /bin/sh: tools/fig-to-oct.py: Permission denied > make[3]: *** [include/xen/compile.h] Error 126 > make[3]: Leaving directory `/builds/xen

Re: [Xen-devel] [PATCH] x86/iommu: remove usage of {set/clear}_identity_p2m_entry against PV domains

On Thu, Dec 05, 2019 at 12:24:29PM +0100, Jan Beulich wrote: > On 02.08.2019 11:22, Roger Pau Monne wrote: > > Switch rmrr_identity_mapping to use iommu_{un}map in order to > > establish RMRR mappings for PV domains, like it's done in > > arch_iommu_hwdom_init. This solves the issue of a PV hardwar

[Xen-devel] [ovmf test] 144637: all pass - PUSHED

flight 144637 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144637/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 804666c86e7b6f04fe5c5cfdb13199c19e0e99b0 baseline version: ovmf 49054b6bb66d35484e92c

Re: [Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge

On 09/12/19 11:56, Philippe Mathieu-Daudé wrote: > > I think so, but with PC_I440FX -> PCI_I440FX ;) > > It would be cleaner to pass the CONFIG_XEN_PCI_PASSTHROUGH variable to > Kconfig and use it (use 'depends on XEN_PCI_PASSTHROUGH'). > > This can be another step, so if this series looks OK to

[Xen-devel] [PATCH v3] CODING_STYLE: Document how to handle unexpected conditions

It's not always clear what the best way is to handle unexpected conditions: whether with ASSERT(), domain_crash(), BUG_ON(), or some other method. All methods have a risk of introducing security vulnerabilities and unnecessary instabilities to production systems. Provide guidelines for different

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

On Mon, 9 Dec 2019 12:08:10 +0100 "Jürgen Groß" wrote: >On 09.12.19 11:52, SeongJae Park wrote: >> On Mon, 9 Dec 2019 11:15:22 +0100 "Jürgen Groß" wrote: >> >>> On 09.12.19 10:46, Durrant, Paul wrote: > -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 09:39 >>

Re: [Xen-devel] [PATCH 1/4] xenbus: move xenbus_dev_shutdown() into frontend code...

On 05.12.19 15:01, Paul Durrant wrote: ...and make it static xenbus_dev_shutdown() is seemingly intended to cause clean shutdown of PV frontends when a guest is rebooted. Indeed the function waits for a conpletion which is only set by a call to xenbus_frontend_closed(). This patch removes the s

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On Thu, Dec 05, 2019 at 02:01:21PM +, Paul Durrant wrote: > Only force state to closed in the case when the toolstack may need to > clean up. This can be detected by checking whether the state in xenstore > has been set to closing prior to device removal. I'm not sure I see the point of this,

Re: [Xen-devel] Problem booting Debian buster on arndale

Julien Grall writes ("Re: Problem booting Debian buster on arndale"): > Looking at the command line for Linux, we don't pass clk_ignore_unused. > Without it, the Linux may disable the clock of the UART if it wasn't > shared with another device. This would explain the sudden loss of the > console

Re: [Xen-devel] [PATCH 3/4] xen/interface: don't discard pending work in FRONT/BACK_RING_ATTACH

On Thu, Dec 05, 2019 at 02:01:22PM +, Paul Durrant wrote: > Currently these macros will skip over any requests/responses that are > added to the shared ring whilst it is detached. This, in general, is not > a desirable semantic since most frontend implementations will eventually > block waiting

Re: [Xen-devel] Problem booting Debian buster on arndale

Hi, On 09/12/2019 11:39, Ian Jackson wrote: Julien Grall writes ("Re: Problem booting Debian buster on arndale"): Looking at the command line for Linux, we don't pass clk_ignore_unused. Without it, the Linux may disable the clock of the UART if it wasn't shared with another device. This would e

[Xen-devel] [PATCH v2 0/2] Refactor super page shattering

map_pages_to_xen and modify_xen_mappings use almost exactly the same page shattering logic, and the code is mingled with other PTE manipulations so it is less obvious that the intention is page shattering. Factor out the functions to make them reusable and to make the intention more obvious. Of co

[Xen-devel] [PATCH v2 2/2] x86/mm: factor out the code for shattering an l2 PTE

map_pages_to_xen and modify_xen_mappings are performing almost exactly the same operations when shattering an l2 PTE, the only difference being whether we want to flush. Signed-off-by: Hongyan Xia --- Changes in v2: - improve asm. - re-read pl2e from memory when taking the lock. - move the alloc

[Xen-devel] [PATCH v2 1/2] x86/mm: factor out the code for shattering an l3 PTE

map_pages_to_xen and modify_xen_mappings are performing almost exactly the same operations when shattering an l3 PTE, the only difference being whether we want to flush. Signed-off-by: Hongyan Xia --- Changes in v2: - improve asm. - re-read pl3e from memory when taking the lock. - move the alloc

Re: [Xen-devel] [PATCH v4] gnttab: don't expose host physical address without need

On 06.12.2019 20:48, Andrew Cooper wrote: > On 05/12/2019 16:57, Jan Beulich wrote: >> On 05.12.2019 16:47, Andrew Cooper wrote: >>> On 05/12/2019 15:34, Jan Beulich wrote: Translated domains shouldn't see host physical addresses. While the address is also not supposed to be handed back e

Re: [Xen-devel] [PATCH 3/4] xen/interface: don't discard pending work in FRONT/BACK_RING_ATTACH

On 09.12.19 12:41, Roger Pau Monné wrote: On Thu, Dec 05, 2019 at 02:01:22PM +, Paul Durrant wrote: Currently these macros will skip over any requests/responses that are added to the shared ring whilst it is detached. This, in general, is not a desirable semantic since most frontend implemen

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On 09.12.19 12:39, Roger Pau Monné wrote: On Thu, Dec 05, 2019 at 02:01:21PM +, Paul Durrant wrote: Only force state to closed in the case when the toolstack may need to clean up. This can be detected by checking whether the state in xenstore has been set to closing prior to device removal.

Re: [Xen-devel] [PATCH 1/4] xenbus: move xenbus_dev_shutdown() into frontend code...

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 11:34 > To: Durrant, Paul ; linux-ker...@vger.kernel.org; > xen-devel@lists.xenproject.org > Cc: Boris Ostrovsky ; Stefano Stabellini > > Subject: Re: [PATCH 1/4] xenbus: move xenbus_dev_shutdown() into frontend > code... >

Re: [Xen-devel] [PATCH 1/4] xenbus: move xenbus_dev_shutdown() into frontend code...

On 09.12.19 12:55, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 09 December 2019 11:34 To: Durrant, Paul ; linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org Cc: Boris Ostrovsky ; Stefano Stabellini Subject: Re: [PATCH 1/4] xenbus: move xenbus_dev_shutdown()

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Roger Pau Monné > Sent: 09 December 2019 11:39 > To: Durrant, Paul > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Juergen > Gross ; Stefano Stabellini ; > Boris Ostrovsky > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 11:55 > To: Roger Pau Monné ; Durrant, Paul > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano > Stabellini ; Boris Ostrovsky > > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH 1/3] x86: relax GDT check in arch_set_info_guest()

On 06.12.2019 20:51, Andrew Cooper wrote: > On 06/12/2019 11:32, Jan Beulich wrote: >> On 06.12.2019 11:25, Andrew Cooper wrote: >>> On 06/12/2019 10:14, Jan Beulich wrote: It is wrong for us to check frames beyond the guest specified limit. Signed-off-by: Jan Beulich >>> I don't co

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On 09.12.19 13:03, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 09 December 2019 11:55 To: Roger Pau Monné ; Durrant, Paul Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano Stabellini ; Boris Ostrovsky Subject: Re: [Xen-devel] [PATCH 2/4] xenb

Re: [Xen-devel] [PATCH for-4.13] xen: Drop bogus BOOLEAN definitions, TRUE and FALSE

On 06.12.2019 22:02, Andrew Cooper wrote: > On 12/11/2019 14:03, Jan Beulich wrote: >> Bottom line - I'm half convinced and willing to give my ack, but >> I'm not convinced you truly thought through the longer term >> consequences. I'd therefore be far happier to see this patch >> split into a non-

Re: [Xen-devel] [PATCH 4/4] xen-blkback: support dynamic unbind/bind

On Thu, Dec 05, 2019 at 02:01:23PM +, Paul Durrant wrote: > By simply re-attaching to shared rings during connect_ring() rather than > assuming they are freshly allocated (i.e assuming the counters are zero) > it is possible for vbd instances to be unbound and re-bound from and to > (respective

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 12:09 > To: Durrant, Paul ; Roger Pau Monné > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano > Stabellini ; Boris Ostrovsky > > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH 4/4] xen-blkback: support dynamic unbind/bind

> -Original Message- > From: Roger Pau Monné > Sent: 09 December 2019 12:17 > To: Durrant, Paul > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Konrad > Rzeszutek Wilk ; Jens Axboe ; > Boris Ostrovsky ; Juergen Gross > ; Stefano Stabellini > Subject: Re: [PATCH 4/4] x

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On Mon, Dec 09, 2019 at 12:01:38PM +, Durrant, Paul wrote: > > -Original Message- > > From: Roger Pau Monné > > Sent: 09 December 2019 11:39 > > To: Durrant, Paul > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Juergen > > Gross ; Stefano Stabellini ; > > Boris O

Re: [Xen-devel] [PATCH for-4.13] xen: Drop bogus BOOLEAN definitions, TRUE and FALSE

Hi Jan, On 09/12/2019 12:11, Jan Beulich wrote: On 06.12.2019 22:02, Andrew Cooper wrote: On 12/11/2019 14:03, Jan Beulich wrote: Bottom line - I'm half convinced and willing to give my ack, but I'm not convinced you truly thought through the longer term consequences. I'd therefore be far happ

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Roger Pau Monné > Sent: 09 December 2019 12:26 > To: Durrant, Paul > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Juergen > Gross ; Stefano Stabellini ; > Boris Ostrovsky > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH 3/4] xen/interface: don't discard pending work in FRONT/BACK_RING_ATTACH

> -Original Message- > From: Xen-devel On Behalf Of > Jürgen Groß > Sent: 09 December 2019 11:52 > To: Roger Pau Monné ; Durrant, Paul > > Cc: xen-devel@lists.xenproject.org; Boris Ostrovsky > ; Stefano Stabellini ; > linux-ker...@vger.kernel.org > Subject: Re: [Xen-devel] [PATCH 3/4] xen

Re: [Xen-devel] [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU

On 26.09.2019 17:23, Jürgen Groß wrote: > On 25.09.19 17:27, Jan Beulich wrote: >> There's nothing to restore here if there's no FPU in the first place. >> >> Signed-off-by: Jan Beulich > > Release-acked-by: Juergen Gross While I've committed the change to the unstable branch, making use of thi

Re: [Xen-devel] XSA-255 and Arm

Sorry I forgot to CC xen-devel. On 09/12/2019 13:13, Julien Grall wrote: Hi all, I was looking at the Grant Table code over the week-end and noticed thart XSA-255 [1] introduced some unintended consequences on Arm. Since the XSA, gnttab_map_frame() will remove the previous mapping (if any)

Re: [Xen-devel] [PATCH 1/2] x86/mm: factor out the code for shattering an l3 PTE

On 07.12.2019 19:20, Xia, Hongyan wrote: > On Fri, 2019-12-06 at 17:50 +, Andrew Cooper wrote: >> On 06/12/2019 15:53, Hongyan Xia wrote: >>> +/* Shatter an l3 entry and populate l2. If virt is passed in, also >>> do flush. */ >>> +static void shatter_l3e(l3_pgentry_t *pl3e, l2_pgentry_t *l2t,

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On 09.12.19 13:19, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 09 December 2019 12:09 To: Durrant, Paul ; Roger Pau Monné Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano Stabellini ; Boris Ostrovsky Subject: Re: [Xen-devel] [PATCH 2/4] xenb

Re: [Xen-devel] [PATCH v3 1/3] xen/flask: Drop the gen-policy.py script

On 07.12.2019 22:16, Andrew Cooper wrote: > --- /dev/null > +++ b/xen/xsm/flask/flask-policy.S > @@ -0,0 +1,20 @@ > +.section .init.rodata, "a", %progbits > + > +/* const unsigned char xsm_flask_init_policy[] __initconst */ > +.align 4 I'm afraid .align is not universal enough to b

Re: [Xen-devel] [PATCH v3] CODING_STYLE: Document how to handle unexpected conditions

On 09.12.2019 12:29, George Dunlap wrote: > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -133,3 +133,97 @@ the end of files. It should be: > * indent-tabs-mode: nil > * End: > */ > + > +Handling unexpected conditions > +-- > + > +GUIDELINES: > + > +Passing errors

Re: [Xen-devel] [PATCH 3/4] xen/interface: don't discard pending work in FRONT/BACK_RING_ATTACH

On 05.12.19 15:01, Paul Durrant wrote: Currently these macros will skip over any requests/responses that are added to the shared ring whilst it is detached. This, in general, is not a desirable semantic since most frontend implementations will eventually block waiting for a response which would e

Re: [Xen-devel] [PATCH 4/4] xen-blkback: support dynamic unbind/bind

On 05.12.19 15:01, Paul Durrant wrote: By simply re-attaching to shared rings during connect_ring() rather than assuming they are freshly allocated (i.e assuming the counters are zero) it is possible for vbd instances to be unbound and re-bound from and to (respectively) a running guest. This ha

Re: [Xen-devel] [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU

On 09.12.19 14:06, Jan Beulich wrote: On 26.09.2019 17:23, Jürgen Groß wrote: On 25.09.19 17:27, Jan Beulich wrote: There's nothing to restore here if there's no FPU in the first place. Signed-off-by: Jan Beulich Release-acked-by: Juergen Gross While I've committed the change to the unst

Re: [Xen-devel] [PATCH 4/4] xen-blkback: support dynamic unbind/bind

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 13:58 > To: Durrant, Paul ; linux-ker...@vger.kernel.org; > xen-devel@lists.xenproject.org > Cc: Konrad Rzeszutek Wilk ; Roger Pau Monné > ; Jens Axboe ; Boris Ostrovsky > ; Stefano Stabellini > Subject: Re: [PATCH 4/4] xen

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 13:39 > To: Durrant, Paul ; Roger Pau Monné > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano > Stabellini ; Boris Ostrovsky > > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH] cmdline: treat hyphens and underscores the same

On 12/6/19 4:42 PM, Jan Beulich wrote: > On 06.12.2019 17:20, Julien Grall wrote: >> Hi, >> >> On 06/12/2019 16:06, Jan Beulich wrote: >>> On 06.12.2019 15:46, Julien Grall wrote: On 05/12/2019 16:50, Jan Beulich wrote: > On 05.12.2019 17:27, Julien Grall wrote: >> On 05/12/2019 15:33,

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On 09.12.19 15:06, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 09 December 2019 13:39 To: Durrant, Paul ; Roger Pau Monné Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano Stabellini ; Boris Ostrovsky Subject: Re: [Xen-devel] [PATCH 2/4] xenb

Re: [Xen-devel] [PATCH] cmdline: treat hyphens and underscores the same

On 09.12.2019 15:06, George Dunlap wrote: > On 12/6/19 4:42 PM, Jan Beulich wrote: >> On 06.12.2019 17:20, Julien Grall wrote: >>> Hi, >>> >>> On 06/12/2019 16:06, Jan Beulich wrote: On 06.12.2019 15:46, Julien Grall wrote: > On 05/12/2019 16:50, Jan Beulich wrote: >> On 05.12.2019 17:

Re: [Xen-devel] [PATCH v3] x86: do not enable global pages when virtualized on AMD hardware

On 09.12.2019 11:20, Roger Pau Monné wrote: > On Wed, Dec 04, 2019 at 06:05:11PM +0100, Jan Beulich wrote: >> On 04.12.2019 17:18, Roger Pau Monné wrote: >>> On Wed, Dec 04, 2019 at 05:11:42PM +0100, Jan Beulich wrote: On 04.12.2019 16:12, Roger Pau Monne wrote: > @@ -130,7 +143,7 @@ unsig

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 14:10 > To: Durrant, Paul ; Roger Pau Monné > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano > Stabellini ; Boris Ostrovsky > > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On Mon, Dec 09, 2019 at 12:40:47PM +, Durrant, Paul wrote: > > -Original Message- > > From: Roger Pau Monné > > Sent: 09 December 2019 12:26 > > To: Durrant, Paul > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Juergen > > Gross ; Stefano Stabellini ; > > Boris O

Re: [Xen-devel] [PATCH v3 2/4] x86/apic: force phys mode if interrupt remapping is disabled

On 09.12.2019 11:25, Roger Pau Monné wrote: > On Thu, Dec 05, 2019 at 10:32:34AM +0100, Jan Beulich wrote: >> On 04.12.2019 17:20, Roger Pau Monne wrote: >>> Cluster mode can only be used with interrupt remapping support, since >>> the top 16bits of the APIC ID are filled with the cluster ID, and >

Re: [Xen-devel] [PATCH v3 4/4] x86/apic: allow enabling x2APIC mode regardless of interrupt remapping

On 09.12.2019 11:56, Roger Pau Monné wrote: > On Thu, Dec 05, 2019 at 10:45:59AM +0100, Jan Beulich wrote: >> On 04.12.2019 17:20, Roger Pau Monne wrote: >>> +switch ( iommu_enable_x2apic() ) >>> { >>> +case 0: >>> +iommu_x2apic_enabled = true; >>> +

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On 09.12.19 15:23, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 09 December 2019 14:10 To: Durrant, Paul ; Roger Pau Monné Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano Stabellini ; Boris Ostrovsky Subject: Re: [Xen-devel] [PATCH 2/4] xenb

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Roger Pau Monné > Sent: 09 December 2019 14:29 > To: Durrant, Paul > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Juergen > Gross ; Stefano Stabellini ; > Boris Ostrovsky > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 14:41 > To: Durrant, Paul ; Roger Pau Monné > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano > Stabellini ; Boris Ostrovsky > > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH v3] x86: do not enable global pages when virtualized on AMD hardware

On Mon, Dec 09, 2019 at 03:21:28PM +0100, Jan Beulich wrote: > On 09.12.2019 11:20, Roger Pau Monné wrote: > > On Wed, Dec 04, 2019 at 06:05:11PM +0100, Jan Beulich wrote: > >> On 04.12.2019 17:18, Roger Pau Monné wrote: > >>> On Wed, Dec 04, 2019 at 05:11:42PM +0100, Jan Beulich wrote: > On 0

Re: [Xen-devel] [PATCH v3 2/4] x86/apic: force phys mode if interrupt remapping is disabled

On Mon, Dec 09, 2019 at 03:30:27PM +0100, Jan Beulich wrote: > On 09.12.2019 11:25, Roger Pau Monné wrote: > > On Thu, Dec 05, 2019 at 10:32:34AM +0100, Jan Beulich wrote: > >> On 04.12.2019 17:20, Roger Pau Monne wrote: > >>> Cluster mode can only be used with interrupt remapping support, since >

Re: [Xen-devel] [PATCH v3] x86: do not enable global pages when virtualized on AMD hardware

On 09.12.2019 15:46, Roger Pau Monné wrote: > On Mon, Dec 09, 2019 at 03:21:28PM +0100, Jan Beulich wrote: >> On 09.12.2019 11:20, Roger Pau Monné wrote: >>> On Wed, Dec 04, 2019 at 06:05:11PM +0100, Jan Beulich wrote: On 04.12.2019 17:18, Roger Pau Monné wrote: > On Wed, Dec 04, 2019 at 0

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On Mon, Dec 09, 2019 at 02:41:40PM +, Durrant, Paul wrote: > > -Original Message- > > From: Roger Pau Monné > > Sent: 09 December 2019 14:29 > > To: Durrant, Paul > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Juergen > > Gross ; Stefano Stabellini ; > > Boris O

Re: [Xen-devel] [PATCH] x86/microcode: Support builtin CPU microcode

On 09/12/2019 08:41, Eslam Elnikety wrote: > diff --git a/docs/misc/builtin-ucode.txt b/docs/misc/builtin-ucode.txt > new file mode 100644 > index 00..43bb60d3eb Instead of introducing a new file, please extend docs/admin-guide/microcode-loading.rst I have an in-prep docs/hypervisor-guide

Re: [Xen-devel] [PATCH] docs/sphinx: How Xen Boots on x86

On 06.12.2019 20:34, Andrew Cooper wrote: > Begin to document how the x86 build of Xen boots. It is by no means complete, > but is a start. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Wei Liu > CC: Roger Pau Monné > > This came about while I sat in SFO waiting for a delaye

Re: [Xen-devel] [PATCH 2/6] xen/tasklet: Switch data parameter from unsigned long to void *.

On 05.12.2019 23:30, Andrew Cooper wrote: > Most users pass a vcpu pointer, and only stopmachine_action() takes an integer > parameter. Switch to using void * to substantially reduce the number of > explicit casts. > > No functional change. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulic

Re: [Xen-devel] [PATCH v3] x86: do not enable global pages when virtualized on AMD hardware

On Mon, Dec 09, 2019 at 04:04:51PM +0100, Jan Beulich wrote: > On 09.12.2019 15:46, Roger Pau Monné wrote: > > On Mon, Dec 09, 2019 at 03:21:28PM +0100, Jan Beulich wrote: > >> On 09.12.2019 11:20, Roger Pau Monné wrote: > >>> On Wed, Dec 04, 2019 at 06:05:11PM +0100, Jan Beulich wrote: > On 0

Re: [Xen-devel] [PATCH v3] x86: do not enable global pages when virtualized on AMD hardware

On 09.12.2019 16:36, Roger Pau Monné wrote: > On Mon, Dec 09, 2019 at 04:04:51PM +0100, Jan Beulich wrote: >> On 09.12.2019 15:46, Roger Pau Monné wrote: >>> On Mon, Dec 09, 2019 at 03:21:28PM +0100, Jan Beulich wrote: On 09.12.2019 11:20, Roger Pau Monné wrote: > On Wed, Dec 04, 2019 at 0

Re: [Xen-devel] [PATCH v3] x86: do not enable global pages when virtualized on AMD hardware

On Mon, Dec 09, 2019 at 04:39:58PM +0100, Jan Beulich wrote: > On 09.12.2019 16:36, Roger Pau Monné wrote: > > On Mon, Dec 09, 2019 at 04:04:51PM +0100, Jan Beulich wrote: > >> On 09.12.2019 15:46, Roger Pau Monné wrote: > >>> On Mon, Dec 09, 2019 at 03:21:28PM +0100, Jan Beulich wrote: > On 0

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

> On 9 Dec 2019, at 11:02, Lars Kurth wrote: > > > > On 06/12/2019, 09:51, "Jan Beulich" > wrote: > >On 06.12.2019 00:41, Lars Kurth wrote: >> I propose to add the following section to code-review-guide.md >> >> >> ## Problematic Patch Reviews >> >> A t

  1   2   >