flight 141434 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/141434/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-pvshim 18 guest-localmigrate/x10 fail REGR. vs. 140282
test-armhf-armhf-
On 18/09/2019 17:09, Jan Beulich wrote:
> On 13.09.2019 21:27, Andrew Cooper wrote:
>> +else
>> +{
>> +/*
>> + * Topology for HVM guests is entirely controlled by Xen. For now,
>> we
>> + * hardcode APIC_ID = vcpu_id * 2 to give the illusion of no SMT.
>> +
Hi Roger,
On 22/08/2019 07:51, Roger Pau Monne wrote:
The new format specifier is '%pp', and prints a pci_sbdf_t using the
seg:bus:dev.func format. Replace all SBDFs printed using
'%04x:%02x:%02x.%u' to use the new format specifier.
No functional change intended.
Signed-off-by: Roger Pau Monné
Hi Lars,
On 18/09/2019 12:50, Lars Kurth wrote:
On 18/09/2019, 11:44, "Wieczorkiewicz, Pawel" wrote:
> On 18. Sep 2019, at 12:41, Ian Jackson wrote:
>
> Julien Grall writes ("Re: [PATCH] create-diff-object: more precisely identify
.rodata sections"):
>> On 18/09/2019 1
Hi Lars,
On 18/09/2019 13:14, Lars Kurth wrote:
On 18/09/2019, 12:15, "Julien Grall" wrote:
Hi Ian,
On 18/09/2019 11:41, Ian Jackson wrote:
> Julien Grall writes ("Re: [PATCH] create-diff-object: more precisely identify
.rodata sections"):
>> On 18/09/2019 10:52,
On 18.09.2019 21:22, Andrew Cooper wrote:
> On 18/09/2019 07:34, Jan Beulich wrote:
>> On 17.09.2019 19:17, Andrew Cooper wrote:
>>> On 16/09/2019 10:48, Jan Beulich wrote:
XED commit 1b2fd94425 ("Update MOVSXD to modern behavior") points out
that as of SDM rev 064 MOVSXD is specified to
Hi Oleksandr,
On 13/09/2019 16:35, Oleksandr Tyshchenko wrote:
diff --git a/xen/drivers/passthrough/arm/iommu.c
b/xen/drivers/passthrough/arm/iommu.c
index f219de9..555acfc 100644
--- a/xen/drivers/passthrough/arm/iommu.c
+++ b/xen/drivers/passthrough/arm/iommu.c
@@ -20,6 +20,12 @@
#include
Hi Oleksandr,
On 13/09/2019 16:35, Oleksandr Tyshchenko wrote:
From: Oleksandr Tyshchenko
Clean up the code a bit by putting the headers in alphabetical order.
Signed-off-by: Oleksandr Tyshchenko
Acked-by: Julien Grall
And committed.
Cheers,
---
xen/drivers/passthrough/arm/iommu.c |
On 19.09.19 12:44, Julien Grall wrote:
Hi Oleksandr,
Hi, Julien.
On 13/09/2019 16:35, Oleksandr Tyshchenko wrote:
diff --git a/xen/drivers/passthrough/arm/iommu.c
b/xen/drivers/passthrough/arm/iommu.c
index f219de9..555acfc 100644
--- a/xen/drivers/passthrough/arm/iommu.c
+++ b/xen/drive
Replace the assert(0) by abort() since the intention in libxl is that
asserts are always compiled in. This patch makes its clear and removes
the need to deal with asserts been compiled out.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- replace asserts by abort().
tools/libxl/libxl_usb
Hi,
On 17/09/2019 19:18, Oleksandr wrote:
On 17.09.19 09:12, Jan Beulich wrote:
Hi, Jan
On 16.09.2019 20:08, Oleksandr wrote:
On 16.09.19 13:40, Jan Beulich wrote:
+/* per-device IOMMU instance data */
+struct iommu_fwspec {
+ /* this device's IOMMU */
+ struct device *iommu_dev;
+
On 19.09.2019 12:12, Julien Grall wrote:
> Hi,
>
> On 17/09/2019 19:18, Oleksandr wrote:
>>
>> On 17.09.19 09:12, Jan Beulich wrote:
>>
>> Hi, Jan
>>
>>> On 16.09.2019 20:08, Oleksandr wrote:
On 16.09.19 13:40, Jan Beulich wrote:
>> +/* per-device IOMMU instance data */
>> +struct iom
On 18.09.2019 23:16, Joe Jin wrote:
> On 9/16/19 11:48 PM, Jan Beulich wrote:
>> On 17.09.2019 00:20, Joe Jin wrote:
>>> On 9/16/19 1:01 AM, Jan Beulich wrote:
On 13.09.2019 18:38, Joe Jin wrote:
> On 9/13/19 12:14 AM, Jan Beulich wrote:
>> On 12.09.2019 20:03, Joe Jin wrote:
>>> -
hvm_monitor_cpuid() expects the input registers, not two of the outputs.
However, once having made the necessary adjustment, the SVM and VMX
functions are so similar that they should be folded (thus avoiding
further similar asymmetries to get introduced). Use the best of both
worlds by e.g. using
+Ross
+ Doug
On 19/09/2019, 10:30, "Julien Grall" wrote:
Hi Lars,
On 18/09/2019 13:14, Lars Kurth wrote:
>
>
> On 18/09/2019, 12:15, "Julien Grall" wrote:
>
> Hi Ian,
>
> On 18/09/2019 11:41, Ian Jackson wrote:
> > Julien Gr
flight 141462 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/141462/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 141253
Tests which
Hi, all.
+struct iommu_fwspec {
+ /* this device's IOMMU */
+ struct device *iommu_dev;
+ /* IOMMU driver private data for this device */
+ void *iommu_priv;
+ /* number of associated device IDs */
+ unsigned int num_ids;
+ /* IDs which this device may present to the IOMMU
That comment as been separated from the function it defines by
4197d3abbb3055d3798254eb7ba239bfb5824360, but then was not useful
anymore when the libxl__device_disk_add() prototype was removed by
22ea8ad02e465e32cd40887c750b55c3a997a288.
Signed-off-by: Anthony PERARD
Acked-by: Wei Liu
Acked-by:
.. and rename them to libxl__qmp_param_*.
This is to allow other files than libxl_qmp.c to make QMP calls with
parameters.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_internal.h | 15
tools/libxl/libxl_qmp.c | 75 +---
.. and use a new "slow" lock to avoid holding the userdata lock across
several functions.
This patch cuts libxl_cdrom_insert into different step/function but
there are still called synchronously. (Taking the ev_lock is the only
step that might be asynchronous.) A later patch will call them
asynchr
It will often be the case that the lock is free to grab. So we first
try to grab it before we have to fork. Even though in this case the
locks are grabbed in the wrong order in the lock hierarchy (ev_lock
should be outside of CTX_LOCK), it is fine to try without blocking. If
that failed, we will re
This is in preparation of cutting libxl_cdrom_insert into several
functions to allow asynchronous callbacks.
No functional changes.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_disk.c | 58 ++--
1 file changed, 32 insertions(+),
Hi,
Changes in v3:
- renamed libxl__ev_lock to libxl__ev_devlock
- rebased
- 1 patch not acked "libxl_internal: Introduce libxl__ev_devlock for devices
hotplug via QMP"
- other patches have been updated for the new ev_devlock name and for the
rebased
Changes in v2:
- New libxl__ev_lock, which a
Make libxl_cdrom_insert asynchronous when QEMU is involved. And
have the cdrom opened by libxl, sending a file descriptor to QEMU.
The "opaque" parameter of the "add-fd" can help to figure out what a
fdset in QEMU is used for. It can be queried by "query-fdsets".
Signed-off-by: Anthony PERARD
A
The current lock `domain_userdata_lock' can't be used when modification
to a guest is done by sending command to QEMU, this is a slow process
and requires to call CTX_UNLOCK, which is not possible while holding
the `domain_userdata_lock'.
To resolve this issue, we create a new lock which can take
After the patch "libxl_disk: Use ev_qmp in libxl_cdrom_insert"
there will not be any kind of timeout, add one back.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
Notes:
Ian, in this patch, the timeout is setup after we have aquired the lock.
Should we change that to also have
It is currently difficult to know how/when/why the userdata lock is
supposed to be used. Add some pointers to the hotplug comments.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_internal.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/libxl/libxl_in
16cc3362a missed one print statement.
Signed-off-by: Wei Liu
---
m4/python_devel.m4 | 2 +-
tools/configure| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/m4/python_devel.m4 b/m4/python_devel.m4
index 7f26381376..e365cd658e 100644
--- a/m4/python_devel.m4
+++ b/m4/pyth
Anthony PERARD writes ("[PATCH 28/35] libxl_pci: Use ev_qmp in do_pci_add"):
> This patch also replaces the use of
> libxl__wait_for_device_model_deprecated() by its equivalent
> without the need for a thread.
Thanks.
Acked-by: Ian Jackson
But, after your series, there are two basically-identic
On Thu, 19 Sep 2019 at 12:17, Wei Liu wrote:
>
> 16cc3362a missed one print statement.
>
> Signed-off-by: Wei Liu
> ---
> m4/python_devel.m4 | 2 +-
> tools/configure| 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/m4/python_devel.m4 b/m4/python_devel.m4
> index 7f
Anthony PERARD writes ("[PATCH v2 11/15] libxl_usb: Fix wrong usage of
asserts"):
> Replace the assert(0) by abort() since the intention in libxl is that
> asserts are always compiled in. This patch makes its clear and removes
> the need to deal with asserts been compiled out.
Acked-by: Ian Jacks
Anthony PERARD writes ("[PATCH v3 3/9] libxl_internal: Introduce
libxl__ev_devlock for devices hotplug via QMP"):
> The current lock `domain_userdata_lock' can't be used when modification
> to a guest is done by sending command to QEMU, this is a slow process
> and requires to call CTX_UNLOCK, whi
Wei Liu writes ("Re: [PATCH for-4.13] configure: fix print syntax for python
3"):
> On Thu, 19 Sep 2019 at 12:17, Wei Liu wrote:
> >
> > 16cc3362a missed one print statement.
> >
> > Signed-off-by: Wei Liu
> > ---
> > m4/python_devel.m4 | 2 +-
> > tools/configure| 2 +-
> > 2 files changed
On Thu, 19 Sep 2019 at 12:28, Ian Jackson wrote:
> My previous reply bounced due to header mangling in your first mail.
> Let me try again:
>
> This is good in principle but:
>
> Can you provide as a git branch ? Then I will get the unmangled
> version and be able to try it out.
>
See
https://
Hi Oleksandr,
On 13/09/2019 16:35, Oleksandr Tyshchenko wrote:
From: Oleksandr Tyshchenko
The main puprose of this patch is to add a way to register DT device
(which is behind the IOMMU) using the generic IOMMU DT bindings [1]
before assigning that device to a domain.
So, this patch adds new
On 19/09/2019 11:57, Oleksandr wrote:
Hi, all.
Hi,
+struct iommu_fwspec {
+ /* this device's IOMMU */
+ struct device *iommu_dev;
+ /* IOMMU driver private data for this device */
+ void *iommu_priv;
+ /* number of associated device IDs */
+ unsigned int num_ids;
+
Hi Oleksandr,
On 13/09/2019 16:35, Oleksandr Tyshchenko wrote:
From: Oleksandr Tyshchenko
The IPMMU-VMSA is VMSA-compatible I/O Memory Management Unit (IOMMU)
which provides address translation and access protection functionalities
to processing units and interconnect networks.
Please note, c
Recent AMD processors may report up to 128 logical processors in CPUID
leaf 1. Doubling this value produces 0 (which OSes sincerely dislike),
as the respective field is only 8 bits wide. Suppress doubling the value
(and its leaf 0x8008 counterpart) in such a case.
Additionally don't even do an
On 19.09.19 14:45, Julien Grall wrote:
Hi Oleksandr,
Hi Julien
On 13/09/2019 16:35, Oleksandr Tyshchenko wrote:
From: Oleksandr Tyshchenko
The IPMMU-VMSA is VMSA-compatible I/O Memory Management Unit (IOMMU)
which provides address translation and access protection functionalities
to pr
Hi,
On 19/09/2019 12:58, Oleksandr wrote:
On 19.09.19 14:45, Julien Grall wrote:
Hi Oleksandr,
Hi Julien
On 13/09/2019 16:35, Oleksandr Tyshchenko wrote:
From: Oleksandr Tyshchenko
The IPMMU-VMSA is VMSA-compatible I/O Memory Management Unit (IOMMU)
which provides address translation
Hi, all.
+struct iommu_fwspec {
+ /* this device's IOMMU */
+ struct device *iommu_dev;
+ /* IOMMU driver private data for this device */
+ void *iommu_priv;
+ /* number of associated device IDs */
+ unsigned int num_ids;
+ /* IDs which this device may present to the IO
On 19.09.19 15:05, Julien Grall wrote:
Hi,
Hi Julien.
On 19/09/2019 12:58, Oleksandr wrote:
On 19.09.19 14:45, Julien Grall wrote:
Hi Oleksandr,
Hi Julien
On 13/09/2019 16:35, Oleksandr Tyshchenko wrote:
From: Oleksandr Tyshchenko
The IPMMU-VMSA is VMSA-compatible I/O Memory M
flight 141442 linux-4.14 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/141442/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail in 141400 REGR.
vs. 139910
Tests whic
On 19.09.19 14:35, Julien Grall wrote:
Hi Oleksandr,
Hi, Julien.
On 13/09/2019 16:35, Oleksandr Tyshchenko wrote:
From: Oleksandr Tyshchenko
The main puprose of this patch is to add a way to register DT device
(which is behind the IOMMU) using the generic IOMMU DT bindings [1]
before as
Hi,
On 19/09/2019 13:25, Oleksandr wrote:
On 19.09.19 14:35, Julien Grall wrote:
Hi Oleksandr,
On 13/09/2019 16:35, Oleksandr Tyshchenko wrote:
From: Oleksandr Tyshchenko
The main puprose of this patch is to add a way to register DT device
(which is behind the IOMMU) using the generic IOMMU
On Tue, Sep 17, 2019 at 05:52:24PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH 06/35] libxl: Use ev_qmp for
> switch_qemu_xen_logdirty"):
> > Signed-off-by: Anthony PERARD
> ...
> > +rc = libxl__ev_time_register_rel(ao, &lds->timeout,
> > + s
Wei Liu writes ("Re: [PATCH for-4.13] configure: fix print syntax for python
3"):
> On Thu, 19 Sep 2019 at 12:28, Ian Jackson wrote:
> > My previous reply bounced due to header mangling in your first mail.
> > Let me try again:
> >
> > This is good in principle but:
> >
> > Can you provide as a g
Anthony PERARD writes ("Re: [PATCH 06/35] libxl: Use ev_qmp for
switch_qemu_xen_logdirty"):
> On Tue, Sep 17, 2019 at 05:52:24PM +0100, Ian Jackson wrote:
> > I hate to suggest this at this stage, but: maybe the timeout could be
> > incorporated into libxl__ev_qmp ?
> >
> > I think every libxl__q
A/D bit writes (on page walks) can be considered benign by an introspection
agent, so receiving vm_events for them is a pessimization. We try here to
optimize by filtering these events out.
Currently, we are fully emulating the instruction at RIP when the hardware sees
an EPT fault with npfec.kind
The main goal continues to be to reduce the huge memory overhead
that we've noticed. On the way there a number of other things were
once again noticed. All patches have now been tested on a Fam15
and a Fam17 system.
01: don't blindly allocate interrupt remapping tables
02: make phantom functions s
ACPI tables are free to list far more device coordinates than there are
actual devices. By delaying the table allocations for most cases, and
doing them only when an actual device is known to be present at a given
position, overall memory used for the tables goes down from over 500k
pages to just o
On Thu, Sep 19, 2019 at 02:03:10PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("Re: [PATCH 06/35] libxl: Use ev_qmp for
> switch_qemu_xen_logdirty"):
> > On Tue, Sep 17, 2019 at 05:52:24PM +0100, Ian Jackson wrote:
> > I guess we could try to optimise the simpler case when there is only one
Rather than duplicating entries in amd_iommu_msi_msg_update_ire(), share
the tables. This mainly requires some care while freeing them, to avoid
freeing memory blocks twice.
Signed-off-by: Jan Beulich
Acked-by: Andrew Cooper
---
v5: New.
---
xen/drivers/passthrough/amd/iommu_init.c | 43
Rather than doing this every time we set up interrupts for a device
anew (and then in several places) fill this invariant field right after
allocating struct pci_dev.
Signed-off-by: Jan Beulich
---
v6: New.
---
xen/arch/x86/msi.c| 13 +
xen/drivers/passthrough/pci.c |
Prepare for the number of entries to not be the maximum possible, by
separating checks against maximum size from ones against actual size.
For caller side simplicity have alloc_intremap_entry() return the
maximum possible value upon allocation failure, rather than the first
just out-of-bounds one.
There's no point setting up tables with more space than a PCI device can
use. For both MSI and MSI-X we can determine how many interrupts could
be set up at most. Tables allocated during ACPI table parsing, however,
will (for now at least) continue to be set up to have maximum size.
Note that unti
Move the device flags field up into an unused hole, thus shrinking
overall structure size by 8 bytes. Use bool and uint_t as
appropriate. Drop pointless (redundant) initializations.
Signed-off-by: Jan Beulich
---
v6: New.
---
xen/drivers/passthrough/amd/iommu_acpi.c |6 +++---
xen/drivers/p
Having a single device table for all segments can't possibly be right.
(Even worse, the symbol wasn't static despite being used in just one
source file.) Attach the device tables to their respective IVRS mapping
ones.
Signed-off-by: Jan Beulich
---
v6: New.
---
xen/drivers/passthrough/amd/iommu
Make sure we don't leave any DTEs unexpected requests through which
would be passed through untranslated. Set V and IV right away (with
all other fields left as zero), relying on the V and/or IV bits
getting cleared only by amd_iommu_set_root_page_table() and
amd_iommu_set_intremap_table() under sp
On 19.09.19 15:29, Julien Grall wrote:
Hi,
Hi, Julien
+
+int __init iommu_add_dt_device(struct dt_device_node *np)
Sorry to only realise it now. Would it make sense to have this
function implemented in xen/passthrough/device_tree.c?
Not entirely sure. device_tree.c is a common code.
flight 141470 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/141470/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 141253
Tests which
On 19.09.2019 15:03, Alexandru Stefan ISAILA wrote:
> @@ -601,6 +602,7 @@ static void *hvmemul_map_linear_addr(
>
> case HVMTRANS_gfn_paged_out:
> case HVMTRANS_gfn_shared:
> +case HVMTRANS_bad_gfn_access:
> err = ERR_PTR(~X86EMUL_RETRY);
> goto
On 17.09.2019 15:21, Julien Grall wrote:
> After commit 6e3e771203 "xen/arm: setup: Relocate the Device-Tree later on
> in the boot", the boot allocator will not receive any xenheap page (i.e.
> mapped page) on Arm32.
>
> However, the boot allocator implicitely rely on having the first page
> alre
> -Original Message-
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index fdb1e17f59..4cc077bb3f 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -3236,6 +3236,19 @@ static enum hvm_translation_result __hvm_copy(
> return HVMTRANS_bad_
On 9/16/19 11:59 AM, Pawel Wieczorkiewicz wrote:
By default, in the quiescing zone, a hotpatch payload is applied with
s/hotpatch/livepatch/ (for all the patches)
apply_payload() and reverted with revert_payload() functions. Both of
the functions receive the payload struct pointer as a parame
On 9/16/19 11:59 AM, Pawel Wieczorkiewicz wrote:
With default implementation the ELF_LIVEPATCH_FUNC section containing
all functions to be replaced or added must be part of the hotpatch
payload, otherwise the payload is rejected (with -EINVAL).
However, with the extended hooks implementation, a
On Tue, Sep 17, 2019 at 06:42:10PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH 33/35] libxl: Extract qmp_parse_query_cpus"):
> > The QMP command "query-cpus" is called from different places, extract
> > the algorithm that parse the answer into a separate function.
>
> I hope you mea
On 9/16/19 11:59 AM, Pawel Wieczorkiewicz wrote:
Livepatch only tracks an entire payload applied/reverted state. But,
with an option to supply the apply_payload() and/or revert_payload()
functions as optional hooks, it becomes possible to intermix the
execution of the original apply_payload()/rev
On 14.09.2019 10:52, Juergen Gross wrote:
> This prepares support of larger scheduling granularities, e.g. core
> scheduling.
>
> While at it move sched_has_urgent_vcpu() from include/asm-x86/cpuidle.h
> into sched.h removing the need for including sched-if.h in cpuidle.h.
> For that purpose remob
flight 141444 linux-4.9 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/141444/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail in 141392 REGR.
vs. 141254
Tests which
On 14.09.2019 10:52, Juergen Gross wrote:
> Affinities are scheduler specific attributes, they should be per
> scheduling unit. So move all affinity related fields in struct vcpu
> to struct sched_unit. While at it switch affinity related functions in
> sched-if.h to use a pointer to sched_unit ins
On Tue, Sep 17, 2019 at 06:07:31PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH 17/35] libxl: Add libxl__ev_qmp to
> libxl__ao_device"):
> > `aodev->qmp' is initialised in libxl__prepare_ao_device(), but since
> > there isn't a single exit path for a `libxl__ao_device', users of this
On 14.09.2019 10:52, Juergen Gross wrote:
> Add the following helpers using a sched_unit as input instead of a
> vcpu:
>
> - is_idle_unit() similar to is_idle_vcpu()
> - is_unit_online() similar to is_vcpu_online() (returns true when any
> of its vcpus is online)
> - unit_runnable() like vcpu_ru
On 14.09.2019 10:52, Juergen Gross wrote:
> @@ -1673,8 +1676,10 @@ static void schedule(void)
> * switch, else lost_records resume will not work properly.
> */
>
> -ASSERT(!next->is_running);
> +ASSERT(!next->sched_unit->is_running);
> next->is_running = 1;
> +next->s
Andrew,
On 15.07.2019 16:58, Jan Beulich wrote:
> 1: guard top-of-stack reads
> 2: widen condition for logging top-of-stack
>
> The issue patch 2 fixes (a curious lack of an intermediate call stack
> entry) was observed in practice; patch 1 is a result of me just looking
> at the code.
I realize
On 9/16/19 11:59 AM, Pawel Wieczorkiewicz wrote:
This is the initial implementation of the expectations enhancement
to improve inline asm hotpatching.
Expectations are designed as optional feature, since the main use of
them is planned for inline asm hotpatching. The flag enabled allows
to contr
Anthony PERARD writes ("Re: [PATCH 17/35] libxl: Add libxl__ev_qmp to
libxl__ao_device"):
> On Tue, Sep 17, 2019 at 06:07:31PM +0100, Ian Jackson wrote:
> > It might be nice to add a comment about the field(s) of
> > libxl__ao_device which callers of libxl__prepare_ao_device are
> > expected to cl
Anthony PERARD writes ("Re: [PATCH 33/35] libxl: Extract qmp_parse_query_cpus"):
> On Tue, Sep 17, 2019 at 06:42:10PM +0100, Ian Jackson wrote:
> > Anthony PERARD writes ("[PATCH 33/35] libxl: Extract qmp_parse_query_cpus"):
> > > The QMP command "query-cpus" is called from different places, extrac
On 9/16/19 11:59 AM, Pawel Wieczorkiewicz wrote:
Having detailed hotpatch metadata helps to properly identify module's
origin and version. It also allows to keep track of the history of
hotpatch loads in the system (at least within dmesg buffer size
limits).
The hotpatch metadata are embedded in
On Fri, Jun 14, 2019 at 12:24:29PM +0100, Anthony PERARD wrote:
> Hi,
>
> This series contains cleanup patches, ahead of a series that's going to make
> more changes to libxl.
v2 with patch 11 acked and the whole branch rebased pushed to:
https://xenbits.xen.org/git-http/people/aperard/xen-unstab
flight 141474 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/141474/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 141253
Tests which
Patches with missing ackes:
libxl: Use ev_qmp for switch_qemu_xen_logdirty
libxl: Use ev_qmp in libxl_set_vcpuonline
libxl_pci: Extract common part of *qemu_trad_watch_state_cb
The series depends on "Some cleanup of libxl" series.
Patch series available in this git branch (which is on
Signed-off-by: Anthony PERARD
---
tools/libxl/libxl_dom_save.c | 41
tools/libxl/libxl_internal.h | 3 +--
tools/libxl/libxl_qmp.c | 10 -
3 files changed, 38 insertions(+), 16 deletions(-)
diff --git a/tools/libxl/libxl_dom_save.c b/tools/libxl
Setup a timeout of 10s for all the commands. It used to be about 5s
per commands.
The order of command is changed, we call 'query-vnc' before
'change-vnc-password', but that should not matter. That makes it
easier to call 'change-vnc-password' conditionally.
Also 'change' command is replaced by '
.. because it makes QMP calls which are going to be async.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl.h| 13 -
tools/libxl/libxl_domain.c | 12
tools/xl/xl_misc.c | 4 ++--
tools/xl/xl_vmcontrol.c| 4 ++--
4 files cha
These two functions are used from many places in libxl and need to
change to be able to accomodate libxl__ev_qmp calls and thus needs to
be asynchronous.
(There is also libxl__domain_resume_device_model in the mix.)
A later patch will introduce a new libxl__domain_resume and
libxl__domain_unpause
.. because it makes QMP calls which are going to be async.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl.h | 14 +-
tools/libxl/libxl_qmp.c | 9 +
tools/xl/xl_misc.c | 2 +-
3 files changed, 19 insertions(+), 6 deletions(-)
diff --git
libxl__qmp_initializations is part of the device domain startup, it
queries information about the newly spawned QEMU and do some
post-startup configuration. So the function call doesn't belong to the
general domain creation, but only to the device model part of the
process, thus the call belong to
.. because it makes QMP calls which are going to be async.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl.h| 15 ++-
tools/libxl/libxl_domain.c | 12
tools/xl/xl_cpupool.c | 2 +-
tools/xl/xl_vcpu.c | 2 +-
4 files chang
.. because it makes QMP calls which are going to be async.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl.h| 13 -
tools/libxl/libxl_domain.c | 14 +++---
tools/xl/xl_info.c | 3 ++-
tools/xl/xl_saverestore.c | 3 ++-
tools/xl/xl
libxl_domain_unpause needs to make QMP calls, which are asynchronous,
change the API to reflect that.
Do the same with libxl_domain_pause async, even if it will keep
completing synchronously.
Also fix some coding style issue in those functions.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackso
This was the last user of libxl__qmp_query_cpus which can now be
removed.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
Notes:
v3:
- following rename of ev_lock to ev_devlock, renamed field rdcs.ev_lock
to rdcs.devlock
tools/libxl/libxl_domain.c | 163 +++
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_usb.c | 93 ++---
1 file changed, 77 insertions(+), 16 deletions(-)
diff --git a/tools/libxl/libxl_usb.c b/tools/libxl/libxl_usb.c
index de8122dc57e9..506dbdcf5ee4 100644
--- a/tools/li
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_domain.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/tools/libxl/libxl_domain.c b/tools/libxl/libxl_domain.c
index 52a8bd7895cb..f3c39fa86fc9 100644
--- a/tools/libxl/libx
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_internal.h | 7 +-
tools/libxl/libxl_pci.c | 170 ++-
2 files changed, 150 insertions(+), 27 deletions(-)
diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
ind
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_qmp.c | 52 +++--
1 file changed, 50 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c
index 9639d491d991..9aabad74fabd 100644
--- a/tools/lib
These two fields help to give more information about the device been
hotplug/hotunplug to callbacks.
There is already `dev' of type `libxl__device', but it is mostly
useful when the backend/frontend is xenstore. Some device (like
`usbdev') don't have devid, so `dev' can't be used.
Signed-off-by:
QEMU upstream (or qemu-xen) may not have set "running" state in
xenstore. "running" with QEMU doesn't mean that the binary is
running, it means that the emulation have started. When adding a
pci-passthrough device to QEMU, we do so via QMP, we have a direct
answer to whether QEMU is running or not,
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_domain.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_domain.c b/tools/libxl/libxl_domain.c
index 80797c5ed21c..d78ffa6b6019 100644
--- a/tools/libxl/libxl_do
Removed libxl__qmp_cpu_add since it's not used anymore.
`cpumap' arg of libxl__set_vcpuonline_xenstore is constified.
The QMP command "query-cpus" is going to be called from different
places, so the algorithm that parse the answer is in a separate
function, qmp_parse_query_cpus.
Signed-off-by: A
1 - 100 of 142 matches
Mail list logo
