Re: [Xen-devel] [BUG] After upgrade to Xen 4.12.0 iommu=no-igfx

2019-08-07 Thread Jan Beulich
On 06.08.2019 23:48, Roman Shaposhnik wrote: On Tue, Aug 6, 2019 at 9:18 AM Roger Pau Monné wrote: On Fri, Aug 02, 2019 at 10:05:40AM +0200, Roger Pau Monné wrote: On Thu, Aug 01, 2019 at 11:25:04AM -0700, Roman Shaposhnik wrote: This patch completely fixes the problem for me! Thanks Roger!

Re: [Xen-devel] [PATCH v3 11/41] media/v4l2-core/mm: convert put_page() to put_user_page*()

2019-08-07 Thread Sakari Ailus
On Tue, Aug 06, 2019 at 06:33:10PM -0700, john.hubb...@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversio

[Xen-devel] [qemu-mainline test] 139766: tolerable FAIL - PUSHED

2019-08-07 Thread osstest service owner
flight 139766 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/139766/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 139678 test-armhf-armhf-libvirt 14 sav

[Xen-devel] [PATCH v2] xen/x86: lock cacheline for add_sized()

2019-08-07 Thread Juergen Gross
add_sized() should use an atomic update of the memory word, as it is used by spin_unlock(). Ticket locks are using a read-modify-write operation on parts of the lockword for unlocking, while trying to lock is done by an atomic update of the complete lockword. This requires the unlock operation to

Re: [Xen-devel] [BUG] After upgrade to Xen 4.12.0 iommu=no-igfx

2019-08-07 Thread Roger Pau Monné
On Tue, Aug 06, 2019 at 02:48:51PM -0700, Roman Shaposhnik wrote: > On Tue, Aug 6, 2019 at 9:18 AM Roger Pau Monné wrote: > > > > On Fri, Aug 02, 2019 at 10:05:40AM +0200, Roger Pau Monné wrote: > > > On Thu, Aug 01, 2019 at 11:25:04AM -0700, Roman Shaposhnik wrote: > > > > This patch completely f

Re: [Xen-devel] [PATCH v8 16/16] microcode: block #NMI handling when loading an ucode

2019-08-07 Thread Chao Gao
On Mon, Aug 05, 2019 at 12:11:01PM +, Jan Beulich wrote: >On 01.08.2019 12:22, Chao Gao wrote: >> @@ -439,12 +440,37 @@ static int do_microcode_update(void *patch) >> return ret; >> } >> >> +static int microcode_nmi_callback(const struct cpu_user_regs *regs, int cpu) >> +{ >> +bo

Re: [Xen-devel] [PATCH v3 11/41] media/v4l2-core/mm: convert put_page() to put_user_page*()

2019-08-07 Thread Hans Verkuil
On 8/7/19 3:33 AM, john.hubb...@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in comm

[Xen-devel] [Qemu-devel] [PATCH v6 13/26] target/mips: Hard code size with MO_{8|16|32|64}

2019-08-07 Thread tony.nguyen
Temporarily no-op size_memop was introduced to aid the conversion of memory_region_dispatch_{read|write} operand "unsigned size" into "MemOp op". Now size_memop is implemented, again hard coded size but with MO_{8|16|32|64}. This is more expressive and avoid size_memop calls. Signed-off-by: Tony

[Xen-devel] [Qemu-devel] [PATCH v6 06/26] hw/intc/armv7m_nic: Access MemoryRegion with MemOp

2019-08-07 Thread tony.nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Convert interfaces by using no-op size_memop. After all interfaces are converted, size_memop will be implemented and the memory_region_dispatch_{read|write} operand "unsigned size" will be conver

[Xen-devel] [Qemu-devel] [PATCH v6 12/26] hw/s390x: Hard code size with MO_{8|16|32|64}

2019-08-07 Thread tony.nguyen
Temporarily no-op size_memop was introduced to aid the conversion of memory_region_dispatch_{read|write} operand "unsigned size" into "MemOp op". Now size_memop is implemented, again hard coded size but with MO_{8|16|32|64}. This is more expressive and avoid size_memop calls. Signed-off-by: Tony

[Xen-devel] [Qemu-devel] [PATCH v6 00/26] Invert Endian bit in SPARCv9 MMU TTE

2019-08-07 Thread tony.nguyen
This patchset implements the IE (Invert Endian) bit in SPARCv9 MMU TTE. It is an attempt of the instructions outlined by Richard Henderson to Mark Cave-Ayland. Tested with OpenBSD on sun4u. Solaris 10 is my actual goal, but unfortunately a separate keyboard issue remains in the way. On 01/11/17

[Xen-devel] [Qemu-devel] [PATCH v6 07/26] hw/virtio: Access MemoryRegion with MemOp

2019-08-07 Thread tony.nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Convert interfaces by using no-op size_memop. After all interfaces are converted, size_memop will be implemented and the memory_region_dispatch_{read|write} operand "unsigned size" will be conver

[Xen-devel] [Qemu-devel] [PATCH v6 03/26] memory: Introduce size_memop

2019-08-07 Thread tony.nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Introduce no-op size_memop to aid preparatory conversion of interfaces. Once interfaces are converted, size_memop will be implemented to return a MemOp from size in bytes. Signed-off-by: Tony Ng

[Xen-devel] [Qemu-devel] [PATCH v6 14/26] exec: Hard code size with MO_{8|16|32|64}

2019-08-07 Thread tony.nguyen
Temporarily no-op size_memop was introduced to aid the conversion of memory_region_dispatch_{read|write} operand "unsigned size" into "MemOp op". Now size_memop is implemented, again hard coded size but with MO_{8|16|32|64}. This is more expressive and avoid size_memop calls. Signed-off-by: Tony

Re: [Xen-devel] [BUG] After upgrade to Xen 4.12.0 iommu=no-igfx

2019-08-07 Thread Jan Beulich
On 07.08.2019 09:35, Roger Pau Monné wrote: On Tue, Aug 06, 2019 at 02:48:51PM -0700, Roman Shaposhnik wrote: On Tue, Aug 6, 2019 at 9:18 AM Roger Pau Monné wrote: On Fri, Aug 02, 2019 at 10:05:40AM +0200, Roger Pau Monné wrote: On Thu, Aug 01, 2019 at 11:25:04AM -0700, Roman Shaposhnik wro

[Xen-devel] [Qemu-devel] [PATCH v6 08/26] hw/vfio: Access MemoryRegion with MemOp

2019-08-07 Thread tony.nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Convert interfaces by using no-op size_memop. After all interfaces are converted, size_memop will be implemented and the memory_region_dispatch_{read|write} operand "unsigned size" will be conver

[Xen-devel] [Qemu-devel] [PATCH v6 16/26] exec: Map device_endian onto MemOp

2019-08-07 Thread tony.nguyen
Preparation to replace device_endian with MemOp. Mapping device_endian onto MemOp limits behaviour changes to this relatively smaller patch. The next patch will replace all device_endian usages with the equivalent MemOp. That patch will be large but have no behaviour changes. A subsequent patch

[Xen-devel] [Qemu-devel] [PATCH v6 05/26] hw/s390x: Access MemoryRegion with MemOp

2019-08-07 Thread tony.nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Convert interfaces by using no-op size_memop. After all interfaces are converted, size_memop will be implemented and the memory_region_dispatch_{read|write} operand "unsigned size" will be conver

[Xen-devel] [Qemu-devel] [PATCH v6 01/26] configure: Define TARGET_ALIGNED_ONLY

2019-08-07 Thread tony.nguyen
Rename ALIGNED_ONLY to TARGET_ALIGNED_ONLY for clarity and move defines out of target/foo/cpu.h into configure, as we do with TARGET_WORDS_BIGENDIAN, so that it is always defined early. Poisoned TARGET_ALIGNED_ONLY to prevent use in common code. Signed-off-by: Tony Nguyen Reviewed-by: Philippe M

[Xen-devel] [Qemu-devel] [PATCH v6 10/26] cputlb: Access MemoryRegion with MemOp

2019-08-07 Thread tony.nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Convert interfaces by using no-op size_memop. After all interfaces are converted, size_memop will be implemented and the memory_region_dispatch_{read|write} operand "unsigned size" will be conver

[Xen-devel] [Qemu-devel] [PATCH v6 18/26] exec: Delete device_endian

2019-08-07 Thread tony.nguyen
device_endian has been made redundant by MemOp. Signed-off-by: Tony Nguyen --- include/exec/cpu-common.h | 8 1 file changed, 8 deletions(-) diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h index 01a29ba..7eeb78c 100644 --- a/include/exec/cpu-common.h +++ b/include/ex

[Xen-devel] [Qemu-devel] [PATCH v6 04/26] target/mips: Access MemoryRegion with MemOp

2019-08-07 Thread tony.nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Convert interfaces by using no-op size_memop. After all interfaces are converted, size_memop will be implemented and the memory_region_dispatch_{read|write} operand "unsigned size" will be conver

[Xen-devel] [Qemu-devel] [PATCH v6 15/26] build: Correct non-common common-obj-* to obj-*

2019-08-07 Thread tony.nguyen
Preparation for replacing device_endian with MemOp. Device realizing code with MemorRegionOps endianness as DEVICE_NATIVE_ENDIAN is not common code. Corrected devices were identified by making the declaration of DEVICE_NATIVE_ENDIAN conditional upon NEED_CPU_H and then listing what failed to comp

[Xen-devel] [Qemu-devel] [PATCH v6 11/26] memory: Access MemoryRegion with MemOp

2019-08-07 Thread tony.nguyen
Convert memory_region_dispatch_{read|write} operand "unsigned size" into a "MemOp op". Signed-off-by: Tony Nguyen --- include/exec/memop.h | 18 +- include/exec/memory.h | 9 + memory.c | 7 +-- 3 files changed, 23 insertions(+), 11 deletions(-) diff

[Xen-devel] [Qemu-devel] [PATCH v6 09/26] exec: Access MemoryRegion with MemOp

2019-08-07 Thread tony.nguyen
The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Convert interfaces by using no-op size_memop. After all interfaces are converted, size_memop will be implemented and the memory_region_dispatch_{read|write} operand "unsigned size" will be conver

[Xen-devel] [Qemu-devel] [PATCH v6 19/26] exec: Delete DEVICE_HOST_ENDIAN

2019-08-07 Thread tony.nguyen
DEVICE_HOST_ENDIAN is conditional upon HOST_WORDS_BIGENDIAN. Code is cleaner if the single use of DEVICE_HOST_ENDIAN is instead directly conditional upon HOST_WORDS_BIGENDIAN. Signed-off-by: Tony Nguyen --- include/exec/cpu-common.h | 8 memory.c | 6 +- 2 files ch

[Xen-devel] [Qemu-devel] [PATCH v6 20/26] memory: Access MemoryRegion with endianness

2019-08-07 Thread tony.nguyen
Preparation for collapsing the two byte swaps adjust_endianness and handle_bswap into the former. Call memory_region_dispatch_{read|write} with endianness encoded into the "MemOp op" operand. This patch does not change any behaviour as memory_region_dispatch_{read|write} is yet to handle the endi

[Xen-devel] [Qemu-devel] [PATCH v6 21/26] cputlb: Replace size and endian operands for MemOp

2019-08-07 Thread tony.nguyen
Preparation for collapsing the two byte swaps adjust_endianness and handle_bswap into the former. Signed-off-by: Tony Nguyen --- accel/tcg/cputlb.c | 170 +-- include/exec/memop.h | 6 ++ memory.c | 11 +--- 3 files changed, 90 ins

[Xen-devel] [Qemu-devel] [PATCH v6 23/26] cpu: TLB_FLAGS_MASK bit to force memory slow path

2019-08-07 Thread tony.nguyen
The fast path is taken when TLB_FLAGS_MASK is all zero. TLB_FORCE_SLOW is simply a TLB_FLAGS_MASK bit to force the slow path, there are no other side effects. Signed-off-by: Tony Nguyen Reviewed-by: Richard Henderson --- include/exec/cpu-all.h | 10 -- 1 file changed, 8 insertions(+),

[Xen-devel] [Qemu-devel] [PATCH v6 22/26] memory: Single byte swap along the I/O path

2019-08-07 Thread tony.nguyen
Now that MemOp has been pushed down into the memory API, and callers are encoding endianness, we can collapse byte swaps along the I/O path into the accelerator and target independent adjust_endianness. Collapsing byte swaps along the I/O path enables additional endian inversion logic, e.g. SPARC6

[Xen-devel] [Qemu-devel] [PATCH v6 25/26] target/sparc: Add TLB entry with attributes

2019-08-07 Thread tony.nguyen
Append MemTxAttrs to interfaces so we can pass along up coming Invert Endian TTE bit on SPARC64. Signed-off-by: Tony Nguyen Reviewed-by: Richard Henderson --- target/sparc/mmu_helper.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/target/

[Xen-devel] [Qemu-devel] [PATCH v6 24/26] cputlb: Byte swap memory transaction attribute

2019-08-07 Thread tony.nguyen
Notice new attribute, byte swap, and force the transaction through the memory slow path. Required by architectures that can invert endianness of memory transaction, e.g. SPARC64 has the Invert Endian TTE bit. Suggested-by: Richard Henderson Signed-off-by: Tony Nguyen Reviewed-by: Richard Hender

[Xen-devel] [Qemu-devel] [PATCH v6 26/26] target/sparc: sun4u Invert Endian TTE bit

2019-08-07 Thread tony.nguyen
This bit configures endianness of PCI MMIO devices. It is used by Solaris and OpenBSD sunhme drivers. Tested working on OpenBSD. Unfortunately Solaris 10 had a unrelated keyboard issue blocking testing... another inch towards Solaris 10 on SPARC64 =) Signed-off-by: Tony Nguyen Reviewed-by: Rich

Re: [Xen-devel] [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-07 Thread Jan Kara
On Fri 02-08-19 12:14:09, John Hubbard wrote: > On 8/2/19 7:52 AM, Jan Kara wrote: > > On Fri 02-08-19 07:24:43, Matthew Wilcox wrote: > > > On Fri, Aug 02, 2019 at 02:41:46PM +0200, Jan Kara wrote: > > > > On Fri 02-08-19 11:12:44, Michal Hocko wrote: > > > > > On Thu 01-08-19 19:19:31, john.hubb.

Re: [Xen-devel] [PATCH v8 16/16] microcode: block #NMI handling when loading an ucode

2019-08-07 Thread Jan Beulich
On 07.08.2019 09:59, Chao Gao wrote: On Mon, Aug 05, 2019 at 12:11:01PM +, Jan Beulich wrote: On 01.08.2019 12:22, Chao Gao wrote: @@ -439,12 +440,37 @@ static int do_microcode_update(void *patch) return ret; } +static int microcode_nmi_callback(const struct cpu_user_regs *reg

Re: [Xen-devel] [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-07 Thread Michal Hocko
On Wed 07-08-19 10:37:26, Jan Kara wrote: > On Fri 02-08-19 12:14:09, John Hubbard wrote: > > On 8/2/19 7:52 AM, Jan Kara wrote: > > > On Fri 02-08-19 07:24:43, Matthew Wilcox wrote: > > > > On Fri, Aug 02, 2019 at 02:41:46PM +0200, Jan Kara wrote: > > > > > On Fri 02-08-19 11:12:44, Michal Hocko w

Re: [Xen-devel] [PATCH v3 10/41] media/ivtv: convert put_page() to put_user_page*()

2019-08-07 Thread Hans Verkuil
On 8/7/19 3:33 AM, john.hubb...@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in comm

Re: [Xen-devel] [PATCH v4 6/6] xen/arm: clarify the support status of iomem configurations

2019-08-07 Thread Julien Grall
Hi, On 07/08/2019 01:23, Stefano Stabellini wrote: iomem settings fall under the broader category of "Non-PCI device passthrough": they are not security supported. Make it clearer. Signed-off-by: Stefano Stabellini CC: t...@xen.org CC: konrad.w...@oracle.com CC: Julien Grall CC: jbeul...@suse

Re: [Xen-devel] [PATCH v2] xen/x86: lock cacheline for add_sized()

2019-08-07 Thread Jan Beulich
On 07.08.2019 09:32, Juergen Gross wrote: add_sized() should use an atomic update of the memory word, as it is used by spin_unlock(). Ticket locks are using a read-modify-write operation on parts of the lockword for unlocking, while trying to lock is done by an atomic update of the complete lock

Re: [Xen-devel] [PATCH v4 6/6] xen/arm: clarify the support status of iomem configurations

2019-08-07 Thread Julien Grall
Hi, On 07/08/2019 10:08, Julien Grall wrote: Hi, On 07/08/2019 01:23, Stefano Stabellini wrote: iomem settings fall under the broader category of "Non-PCI device passthrough": they are not security supported. Make it clearer. Signed-off-by: Stefano Stabellini CC: t...@xen.org CC: konrad.w...

Re: [Xen-devel] [PATCH 1/6] domain: introduce XEN_DOMCTL_CDF_iommu

2019-08-07 Thread Jan Beulich
On 30.07.2019 15:44, Paul Durrant wrote: --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -673,8 +673,7 @@ int arch_domain_create(struct domain *d, ASSERT(config != NULL); -/* p2m_init relies on some value initialized by the IOMMU subsystem */ -if ( (rc = iommu_doma

Re: [Xen-devel] [PATCH v2] xen/x86: lock cacheline for add_sized()

2019-08-07 Thread Juergen Gross
On 07.08.19 11:10, Jan Beulich wrote: On 07.08.2019 09:32, Juergen Gross wrote: add_sized() should use an atomic update of the memory word, as it is used by spin_unlock(). Ticket locks are using a read-modify-write operation on parts of the lockword for unlocking, while trying to lock is done b

Re: [Xen-devel] [PATCH v5 02/10] AMD/IOMMU: drop stray "else"

2019-08-07 Thread Andrew Cooper
On 06/08/2019 14:08, Jan Beulich wrote: > The blank line between it and the prior if() clearly indicates that this > was meant to be a standalone if(). > > Signed-off-by: Jan Beulich Looks like this was you in c/s 0e8e0a0854a Acked-by: Andrew Cooper ___

[Xen-devel] [xen-unstable-coverity test] 139800: all pass - PUSHED

2019-08-07 Thread osstest service owner
flight 139800 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/139800/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 45ce5b8749a220ad7c4ce5d5eba7c201a9418078 baseline version: xen 0a6a

Re: [Xen-devel] [PATCH 2/6] use is_iommu_enabled() where appropriate...

2019-08-07 Thread Jan Beulich
On 30.07.2019 15:44, Paul Durrant wrote: --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -1531,8 +1531,7 @@ int p2m_init(struct domain *d) * shared with the CPU, Xen has to make sure that the PT changes have * reached the memory */ -p2m->clean_pte = iommu_enabled &&

Re: [Xen-devel] [BUG] After upgrade to Xen 4.12.0 iommu=no-igfx

2019-08-07 Thread Roger Pau Monné
On Wed, Aug 07, 2019 at 09:08:58AM +0200, Jan Beulich wrote: > On 06.08.2019 23:48, Roman Shaposhnik wrote: > > On Tue, Aug 6, 2019 at 9:18 AM Roger Pau Monné wrote: > > > > > > On Fri, Aug 02, 2019 at 10:05:40AM +0200, Roger Pau Monné wrote: > > > > On Thu, Aug 01, 2019 at 11:25:04AM -0700, Roma

Re: [Xen-devel] [PATCH v5 02/10] AMD/IOMMU: drop stray "else"

2019-08-07 Thread Jan Beulich
On 07.08.2019 11:48, Andrew Cooper wrote: On 06/08/2019 14:08, Jan Beulich wrote: The blank line between it and the prior if() clearly indicates that this was meant to be a standalone if(). Signed-off-by: Jan Beulich Looks like this was you in c/s 0e8e0a0854a Right - quite embarrassing. I

Re: [Xen-devel] [BUG] After upgrade to Xen 4.12.0 iommu=no-igfx

2019-08-07 Thread Jan Beulich
On 07.08.2019 11:57, Roger Pau Monné wrote: On Wed, Aug 07, 2019 at 09:08:58AM +0200, Jan Beulich wrote: On 06.08.2019 23:48, Roman Shaposhnik wrote: On Tue, Aug 6, 2019 at 9:18 AM Roger Pau Monné wrote: On Fri, Aug 02, 2019 at 10:05:40AM +0200, Roger Pau Monné wrote: On Thu, Aug 01, 2019

[Xen-devel] [PATCH v7 2/2] xen/arm: consolidate make_timer_node and make_timer_domU_node

2019-08-07 Thread Viktor Mitin
Functions make_timer_node and make_timer_domU_node are quite similar. So it is better to consolidate them to avoid discrepancy. The main difference between the functions is the timer interrupts used. Keep the domU version for the compatible as it is simpler: do not copy platform's 'compatible' pro

[Xen-devel] [PATCH v7 1/2] xen/arm: extend fdt_property_interrupts to support DomU

2019-08-07 Thread Viktor Mitin
Extend fdt_property_interrupts to deal with other domain than the hwdom. The prototype of fdt_property_interrupts() has been modified to support both hwdom and domU in one function. This is a preparatory for the next patch which consolidates make_timer_node and make_timer_domU_node". Original goa

[Xen-devel] [PATCH v7 0/2] xen/arm: Consolidate make_timer_node and make_timer_domU_node

2019-08-07 Thread Viktor Mitin
Functions make_timer_node and make_timer_domU_node are quite similar, so it is better to consolidate them to avoid discrepancy. This patch series achives this goal in two steps: - Extend fdt_property_interrupts to deal with other domain than the hwdom. - Consolidate make_timer_node and make_timer_

Re: [Xen-devel] [PATCH] xen/arm: unbreak arm64 build

2019-08-07 Thread Julien Grall
Hi Stefano, Please use add_maintainers.pl to CC the correct reviewers. It is quite common to specify the compiler/binutils version used when this is not an obvious compiler error (i.e missing braces or semi-column). In this case, this passed OSStest smoke and I haven't noticed any issues with

Re: [Xen-devel] [BUG] After upgrade to Xen 4.12.0 iommu=no-igfx

2019-08-07 Thread Roger Pau Monné
On Wed, Aug 07, 2019 at 10:31:40AM +0200, Jan Beulich wrote: > On 07.08.2019 09:35, Roger Pau Monné wrote: > > On Tue, Aug 06, 2019 at 02:48:51PM -0700, Roman Shaposhnik wrote: > > > On Tue, Aug 6, 2019 at 9:18 AM Roger Pau Monné > > > wrote: > > > > > > > > On Fri, Aug 02, 2019 at 10:05:40AM +

Re: [Xen-devel] [PATCH 2/6] use is_iommu_enabled() where appropriate...

2019-08-07 Thread Julien Grall
Hi Jan, On 07/08/2019 10:55, Jan Beulich wrote: On 30.07.2019 15:44, Paul Durrant wrote: --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -1531,8 +1531,7 @@ int p2m_init(struct domain *d)    * shared with the CPU, Xen has to make sure that the PT changes have    * reached the memory

Re: [Xen-devel] [Qemu-devel] [PATCH v6 19/26] exec: Delete DEVICE_HOST_ENDIAN

2019-08-07 Thread Paolo Bonzini
On 07/08/19 10:32, tony.ngu...@bt.com wrote: > +#if defined(HOST_WORDS_BIGENDIAN) > +    .endianness = MO_BE, > +#else > +    .endianness = MO_LE, > +#endif Host endianness is just 0, isn't it? Paolo ___ Xen-devel mailing list Xen-devel@lists.xenprojec

Re: [Xen-devel] [Qemu-devel] [PATCH v6 20/26] memory: Access MemoryRegion with endianness

2019-08-07 Thread Paolo Bonzini
On 07/08/19 10:33, tony.ngu...@bt.com wrote: > +#ifdef NEED_CPU_H > +    return ctz32(size) | MO_TE; > +#else >      return ctz32(size); > +#endif Please use two separate functions for this, for example size_to_memop and target_size_to_memop, or even just add MO_TE to the callers that need it (onl

Re: [Xen-devel] [PATCH 3/6] remove late (on-demand) construction of IOMMU page tables

2019-08-07 Thread Jan Beulich
On 30.07.2019 15:44, Paul Durrant wrote: NOTE: This patch will cause a small amount of extra resource to be used to accommodate IOMMU page tables that may never be used, since the per-domain IOMMU flag enable flag is currently set to the value of the global iommu_enable flag.

Re: [Xen-devel] [PATCH 2/4] x86/boot: Minor improvements to efi_arch_post_exit_boot()

2019-08-07 Thread Andrew Cooper
On 06/08/2019 16:20, Jan Beulich wrote: > On 05.08.2019 14:42, Andrew Cooper wrote: >> Split up the long asm block by commenting the logical subsections. >> >> The movabs for obtaining __start_xen can be a rip-relative lea >> instead.  This >> has the added advantage that objdump can now cross refe

Re: [Xen-devel] [PATCH v3 1/5] xen: add a p2mt parameter to map_mmio_regions

2019-08-07 Thread Julien Grall
On 07/08/2019 00:38, Stefano Stabellini wrote: On Wed, 10 Jul 2019, Julien Grall wrote: Hi Stefano, The Arm code looks good to me. One comment below. Should I take it as a acked-by? I will have a look at the next version. Cheers, -- Julien Grall

Re: [Xen-devel] [Qemu-devel] [PATCH v6 00/26] Invert Endian bit in SPARCv9 MMU TTE

2019-08-07 Thread Philippe Mathieu-Daudé
On 8/7/19 10:23 AM, tony.ngu...@bt.com wrote: [...] > v3: > - Like v1, the entire TCGMemOp enum is now MemOp. > - MemOp target dependant attributes are conditional upon NEED_CPU_H > > v4: > - Added Paolo Bonzini as include/exec/memop.h maintainer > > v5: > - Improved commit messages to clarify ho

Re: [Xen-devel] [PATCH 5/6] iommu: tidy up iommu_us_hap_pt() and need_iommu_pt_sync() macros

2019-08-07 Thread Jan Beulich
On 30.07.2019 15:44, Paul Durrant wrote: Thes macros really ought to live in the common xen/iommu.h header rather then being distributed amongst architecture specific iommu headers and xen/sched.h. This patch moves them there. NOTE: Disabling 'sharept' in the command line iommu options should re

Re: [Xen-devel] [Qemu-devel] [PATCH v6 15/26] build: Correct non-common common-obj-* to obj-*

2019-08-07 Thread Paolo Bonzini
On 07/08/19 10:31, tony.ngu...@bt.com wrote: > Preparation for replacing device_endian with MemOp. > > Device realizing code with MemorRegionOps endianness as > DEVICE_NATIVE_ENDIAN is not common code. > > Corrected devices were identified by making the declaration of > DEVICE_NATIVE_ENDIAN condi

Re: [Xen-devel] [PATCH v2] 9pfs has a QEMU backend

2019-08-07 Thread Ian Jackson
Stefano Stabellini writes ("[PATCH v2] 9pfs has a QEMU backend"): > Add 9pfs to the kind of PV drivers that has a QEMU backend, specifically > to the macro QEMU_BACKEND. > > This is needed otherwise upon domain destroy we get a timeout error: > > libxl: error: libxl_device.c:1132:device_backend_c

Re: [Xen-devel] [PATCH 4/4] x86/desc: Build boot_{, compat_}gdt[] in C

2019-08-07 Thread Andrew Cooper
On 06/08/2019 16:48, Jan Beulich wrote: > On 05.08.2019 14:43, Andrew Cooper wrote: >> --- a/xen/arch/x86/boot/x86_64.S >> +++ b/xen/arch/x86/boot/x86_64.S >> @@ -43,44 +43,11 @@ ENTRY(__high_start) >>   multiboot_ptr: >>   .long   0 >>   -    .word   0 >> -GLOBAL(boot_gdtr) >> -   

Re: [Xen-devel] [PATCH 2/4] x86/boot: Minor improvements to efi_arch_post_exit_boot()

2019-08-07 Thread Jan Beulich
On 07.08.2019 12:33, Andrew Cooper wrote: On 06/08/2019 16:20, Jan Beulich wrote: On 05.08.2019 14:42, Andrew Cooper wrote: Split up the long asm block by commenting the logical subsections. The movabs for obtaining __start_xen can be a rip-relative lea instead.  This has the added advantage t

Re: [Xen-devel] [PATCH 4/4] x86/desc: Build boot_{, compat_}gdt[] in C

2019-08-07 Thread Jan Beulich
On 07.08.2019 12:46, Andrew Cooper wrote: On 06/08/2019 16:48, Jan Beulich wrote: On 05.08.2019 14:43, Andrew Cooper wrote: --- a/xen/arch/x86/boot/x86_64.S +++ b/xen/arch/x86/boot/x86_64.S @@ -43,44 +43,11 @@ ENTRY(__high_start)   multiboot_ptr:   .long   0   -    .word   0 -GLO

[Xen-devel] [PATCH] xen/sched: fix memory leak in credit2

2019-08-07 Thread Juergen Gross
csched2_deinit() is leaking the run-queue memory. Signed-off-by: Juergen Gross --- xen/common/sched_credit2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c index 6fff210ca6..6b77da7476 100644 --- a/xen/common/sched_credit2.c +++ b/x

[Xen-devel] [livepatch-build-tools v2 4/4] livepatch-build: Handle newly created object files

2019-08-07 Thread Pawel Wieczorkiewicz
Up to now the livepatch-build ignores newly created object files. When patch applies new .c file and augments its Makefile to build it the resulting object file is not taken into account for final linking step. Such newly created object files can be detected by comparing patched/ and original/ dir

[Xen-devel] [PATCH] evtchn: make support for different ABIs tunable

2019-08-07 Thread Eslam Elnikety
Adding support for FIFO event channel ABI was first introduced in Xen 4.4 (see 88910061ec6). Make this support tunable, since the choice of which event channel ABI has implications for hibernation. Consider resuming a pre Xen 4.4 hibernated Linux guest. The guest boot kernel defaults to FIFO ABI, w

[Xen-devel] [livepatch-build-tools part2 v2 1/6] common: Add is_standard_section() helper function

2019-08-07 Thread Pawel Wieczorkiewicz
Detect standard (always to be included) sections via their section header type. The standard sections: ".shstrtab", ".symtab", ".strtab" are either of type SHT_SYMTAB or SHT_STRTAB. Signed-off-by: Pawel Wieczorkiewicz Reviewed-by: Andra-Irina Paraschiv Reviewed-by: Bjoern Doebel Reviewed-by: No

[Xen-devel] [PATCH] x86/boot: Set Accessed bits in boot_cpu_{, compat_}gdt_table[]

2019-08-07 Thread Andrew Cooper
There is no point causing the CPU to performed a locked update of the descriptors on first use. Reported-by: Jan Beulich Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/arch/x86/boot/x86_64.S | 26 +- 1 file changed, 13 inserti

Re: [Xen-devel] [PATCH v4 06/35] OvmfPkg/XenResetVector: Add new entry point for Xen PVH

2019-08-07 Thread Roger Pau Monné
On Mon, Jul 29, 2019 at 04:39:15PM +0100, Anthony PERARD wrote: > Add a new entry point for Xen PVH that enter directly in 32bits. > > Information on the expected state of the machine when this entry point > is used can be found at: > https://xenbits.xenproject.org/docs/unstable/misc/pvh.html > >

Re: [Xen-devel] [PATCH] evtchn: make support for different ABIs tunable

2019-08-07 Thread Andrew Cooper
On 07/08/2019 12:20, Eslam Elnikety wrote: > Adding support for FIFO event channel ABI was first introduced in Xen 4.4 > (see 88910061ec6). Make this support tunable, since the choice of which > event channel ABI has implications for hibernation. Consider resuming a > pre Xen 4.4 hibernated Linux g

[Xen-devel] [linux-4.9 test] 139772: regressions - FAIL

2019-08-07 Thread osstest service owner
flight 139772 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/139772/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-boot fail REGR. vs. 139692 test-arm64-arm64-exam

[Xen-devel] [livepatch-build-tools part2 v2 2/6] common: Add is_referenced_section() helper function

2019-08-07 Thread Pawel Wieczorkiewicz
This function checks if given section has an included corresponding RELA section and/or any of the symbols table symbols references the section. Section associated symbols are ignored here as there is always such a symbol for every section. Signed-off-by: Pawel Wieczorkiewicz Reviewed-by: Andra-I

Re: [Xen-devel] [PATCH] x86/boot: Set Accessed bits in boot_cpu_{, compat_}gdt_table[]

2019-08-07 Thread Jan Beulich
On 07.08.2019 13:34, Andrew Cooper wrote: There is no point causing the CPU to performed a locked update of the descriptors on first use. Reported-by: Jan Beulich Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich ___ Xen-devel mailing list Xe

Re: [Xen-devel] [PATCH] evtchn: make support for different ABIs tunable

2019-08-07 Thread Woodhouse, David
On Wed, 2019-08-07 at 12:40 +0100, Andrew Cooper wrote: > On 07/08/2019 12:20, Eslam Elnikety wrote: > > Adding support for FIFO event channel ABI was first introduced in Xen 4.4 > > (see 88910061ec6). Make this support tunable, since the choice of which > > event channel ABI has implications for h

Re: [Xen-devel] [PATCH] evtchn: make support for different ABIs tunable

2019-08-07 Thread Elnikety, Eslam
> On 7. Aug 2019, at 13:40, Andrew Cooper wrote: > > On 07/08/2019 12:20, Eslam Elnikety wrote: >> Adding support for FIFO event channel ABI was first introduced in Xen 4.4 >> (see 88910061ec6). Make this support tunable, since the choice of which >> event channel ABI has implications for hiber

Re: [Xen-devel] [PATCH 6/6] introduce a 'passthrough' configuration option to xl.cfg...

2019-08-07 Thread Jan Beulich
On 30.07.2019 15:44, Paul Durrant wrote: --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -605,6 +605,58 @@ option should only be used with a trusted device tree. Note that the partial device tree should avoid using the phandle 65000 which is reserved by the toolstack. +=it

Re: [Xen-devel] [PATCH] docs, arm: add documentation on available defconfigs

2019-08-07 Thread Julien Grall
Hi Volodymyr, Sorry for the late answer. On 14/06/2019 16:23, Volodymyr Babchuk wrote: As build system now have *_defconfig targets defined, lets describe available defconfig files for the Arm architecture. Signed-off-by: Volodymyr Babchuk --- docs/misc/arm/defconfigs.txt | 23 +

Re: [Xen-devel] [PATCH v7 0/2] xen/arm: Consolidate make_timer_node and make_timer_domU_node

2019-08-07 Thread Julien Grall
Hi, Thank you for adding the cover letter. Although, one more request :). Please CC reviewers on your cover letter. Otherwise, it will likely land in a different folder and be missed. The script scripts/add_maintainers.pl should do the job for you. Cheers, On 07/08/2019 11:10, Viktor Mitin

Re: [Xen-devel] [PATCH] evtchn: make support for different ABIs tunable

2019-08-07 Thread Jan Beulich
On 07.08.2019 14:04, Woodhouse, David wrote: On Wed, 2019-08-07 at 12:40 +0100, Andrew Cooper wrote: On 07/08/2019 12:20, Eslam Elnikety wrote: Adding support for FIFO event channel ABI was first introduced in Xen 4.4 (see 88910061ec6). Make this support tunable, since the choice of which eve

Re: [Xen-devel] [PATCH] evtchn: make support for different ABIs tunable

2019-08-07 Thread Jan Beulich
On 07.08.2019 14:07, Elnikety, Eslam wrote: On 7. Aug 2019, at 13:40, Andrew Cooper wrote: On 07/08/2019 12:20, Eslam Elnikety wrote: Adding support for FIFO event channel ABI was first introduced in Xen 4.4 (see 88910061ec6). Make this support tunable, since the choice of which event channel

Re: [Xen-devel] [PATCH] evtchn: make support for different ABIs tunable

2019-08-07 Thread Andrew Cooper
On 07/08/2019 13:04, Woodhouse, David wrote: > On Wed, 2019-08-07 at 12:40 +0100, Andrew Cooper wrote: >> On 07/08/2019 12:20, Eslam Elnikety wrote: >>> Adding support for FIFO event channel ABI was first introduced in Xen 4.4 >>> (see 88910061ec6). Make this support tunable, since the choice of wh

Re: [Xen-devel] [PATCH v7 1/2] xen/arm: extend fdt_property_interrupts to support DomU

2019-08-07 Thread Julien Grall
Hi Viktor, On 07/08/2019 11:10, Viktor Mitin wrote: Extend fdt_property_interrupts to deal with other domain than the hwdom. The prototype of fdt_property_interrupts() has been modified to support both hwdom and domU in one function. To be pedantic, the current prototype for fdt_property_inte

Re: [Xen-devel] [PATCH] evtchn: make support for different ABIs tunable

2019-08-07 Thread Andrew Cooper
On 07/08/2019 13:07, Elnikety, Eslam wrote: >> On 7. Aug 2019, at 13:40, Andrew Cooper wrote: >> >> On 07/08/2019 12:20, Eslam Elnikety wrote: >>> Adding support for FIFO event channel ABI was first introduced in Xen 4.4 >>> (see 88910061ec6). Make this support tunable, since the choice of which >

Re: [Xen-devel] [Qemu-devel] [PATCH v6 00/26] Invert Endian bit in SPARCv9 MMU TTE

2019-08-07 Thread tony.nguyen
On 8/7/19 8:37 PM, Philippe Mathieu-Daudé wrote: > I'm confused I think I already reviewed various patches of your previous ?> series but don't see my Reviewed-by tags.? Apologies Philippe! I am the confused one here =/ Will append. Thank you very much for the reviews and qemu-devel newbie t

Re: [Xen-devel] [Qemu-devel] [PATCH v6 10/26] cputlb: Access MemoryRegion with MemOp

2019-08-07 Thread tony.nguyen
Sorry, I missed a tag. Reviewed-by: Philippe Mathieu-Daudé ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 4/4] x86/desc: Build boot_{, compat_}gdt[] in C

2019-08-07 Thread Andrew Cooper
On 07/08/2019 11:55, Jan Beulich wrote: > On 07.08.2019 12:46, Andrew Cooper wrote: >> On 06/08/2019 16:48, Jan Beulich wrote: >>> On 05.08.2019 14:43, Andrew Cooper wrote: --- a/xen/arch/x86/boot/x86_64.S +++ b/xen/arch/x86/boot/x86_64.S @@ -43,44 +43,11 @@ ENTRY(__high_start)

Re: [Xen-devel] [Qemu-devel] [PATCH v6 04/26] target/mips: Access MemoryRegion with MemOp

2019-08-07 Thread tony.nguyen
Sorry, I missed a tag. Reviewed-by: Philippe Mathieu-Daudé ? ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [Qemu-devel] [PATCH v6 06/26] hw/intc/armv7m_nic: Access MemoryRegion with MemOp

2019-08-07 Thread tony.nguyen
Sorry, I missed a tag. Reviewed-by: Philippe Mathieu-Daudé ? ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [Qemu-devel] [PATCH v6 00/26] Invert Endian bit in SPARCv9 MMU TTE

2019-08-07 Thread Philippe Mathieu-Daudé
On 8/7/19 2:41 PM, tony.ngu...@bt.com wrote: > On 8/7/19 8:37 PM, Philippe Mathieu-Daudé wrote: > >> I'm confused I think I already reviewed various patches of your previous > ​> series but don't see my Reviewed-by tags.​> > Apologies Philippe! I am the confused one here =/ > > Will append. > >

Re: [Xen-devel] [Qemu-devel] [PATCH v6 09/26] exec: Access MemoryRegion with MemOp

2019-08-07 Thread tony.nguyen
Sorry, I missed a tag. Reviewed-by: Philippe Mathieu-Daudé ? ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH v8 1/2] xen/arm: extend fdt_property_interrupts to support DomU

2019-08-07 Thread Viktor Mitin
The domain and fdt can be found in the structure kinfo. Rather than adding a an extra argument for the domain, pass directly kinfo. This also requires to adapt fdt_property_interrupts() prototype. A follow-up patch will need to create the interrupts for either Dom0 or DomU. Suggested-by: Julien Gr

[Xen-devel] [PATCH v8 2/2] xen/arm: consolidate make_timer_node and make_timer_domU_node

2019-08-07 Thread Viktor Mitin
Functions make_timer_node and make_timer_domU_node are quite similar. So it is better to consolidate them to avoid discrepancy. The main difference between the functions is the timer interrupts used. Keep the domU version for the compatible as it is simpler: do not copy platform's 'compatible' pro

[Xen-devel] [PATCH v8 0/2] xen/arm: Consolidate make_timer_node and make_timer_domU_node

2019-08-07 Thread Viktor Mitin
Functions make_timer_node and make_timer_domU_node are quite similar, so it is better to consolidate them to avoid discrepancy. This patch series achives this goal in two steps: - Extend fdt_property_interrupts to deal with other domain than the hwdom. - Consolidate make_timer_node and make_timer_

[Xen-devel] [xen-unstable-smoke test] 139802: tolerable all pass - PUSHED

2019-08-07 Thread osstest service owner
flight 139802 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/139802/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH] evtchn: make support for different ABIs tunable

2019-08-07 Thread Elnikety, Eslam
> On 7. Aug 2019, at 14:30, Andrew Cooper wrote: > > On 07/08/2019 13:07, Elnikety, Eslam wrote: >>> On 7. Aug 2019, at 13:40, Andrew Cooper wrote: >>> >>> On 07/08/2019 12:20, Eslam Elnikety wrote: Adding support for FIFO event channel ABI was first introduced in Xen 4.4 (see 88910

Re: [Xen-devel] [PATCH v8 0/2] xen/arm: Consolidate make_timer_node and make_timer_domU_node

2019-08-07 Thread Julien Grall
Hi, Please give some time for reviewers to review the full series... I am still writing an answer on patch #2 in v7... You should at least wait for review on the series before sending a new version. This would have likely avoided to be at v8 for such series. In this case, I don't think ther

Re: [Xen-devel] [Qemu-devel] [PATCH v6 26/26] target/sparc: sun4u Invert Endian TTE bit

2019-08-07 Thread tony.nguyen
Sorry, I missed a tag.? Tested-by: Mark Cave-Ayland ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

  1   2   3   >