[Xen-devel] [xen-unstable-smoke test] 135096: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135096 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/135096/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 133991 Tests

[Xen-devel] [xen-unstable test] 135003: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135003 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/135003/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 134763 build-i386-pvops

[Xen-devel] [ovmf test] 135097: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135097 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/135097/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 134977 build-i386-pvops

Re: [Xen-devel] VMI: singlestep event not received

2019-04-22 Thread Razvan Cojocaru
On 4/22/19 1:26 AM, Mathieu Tarral wrote: The problem is that RtlUserThreadStart is paged-out, so i'm trying to reach it via singlestepping as a backup solution. FWIW, you can just use xc_hvm_inject_trap() with a TRAP_page_fault parameter to cause the OS to bring a paged out page back into ma

[Xen-devel] [linux-3.18 test] 135000: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135000 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/135000/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken in 134634 build-arm64

Re: [Xen-devel] VMI: singlestep event not received

2019-04-22 Thread Andrew Cooper
On 21/04/2019 23:26, Mathieu Tarral wrote: Answering out of order. > I discussed this bug on IRC with andyhpp, who convinced me to move the > discussion on the mailing list. > Apparently the singlestepping in Xen was in a poor quality state because of > multiple layers of refactoring. What I s

[Xen-devel] [distros-debian-sid test] 84088: trouble: blocked/broken

2019-04-22 Thread Platform Team regression test user
flight 84088 distros-debian-sid real [real] http://osstest.xensource.com/osstest/logs/84088/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-i386

[Xen-devel] [xen-unstable-smoke test] 135103: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135103 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/135103/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 133991 Tests

[Xen-devel] [PATCH 1/1] xen/gnttab: print log at level XENLOG_ERR before panic

2019-04-22 Thread Dongli Zhang
Print log at level XENLOG_ERR (instead XENLOG_INFO) as domain_crash() indicates there is fatal error. Signed-off-by: Dongli Zhang --- xen/common/grant_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index 80728ea..72

Re: [Xen-devel] [PATCH] golang/xenlight: Fixing compilation for go 1.11

2019-04-22 Thread Pasi Kärkkäinen
On Sat, Apr 20, 2019 at 07:27:55PM -0400, Daniel P. Smith wrote: > On 4/18/19 9:11 AM, George Dunlap wrote: > > On 4/18/19 2:52 AM, Daniel P. Smith wrote: > >> This deals with two casting issues for compiling under go 1.11: > >> - explicitly cast to *C.xentoollog_logger for Ctx.logger pointer > >>

[Xen-devel] [ovmf test] 135107: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135107 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/135107/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 134977 version targeted for testi

[Xen-devel] [freebsd-master test] 135111: all pass - PUSHED

2019-04-22 Thread osstest service owner
flight 135111 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/135111/ Perfect :-) All tests in this flight passed as required version targeted for testing: freebsd 8752233742e58f015043521829fd0792f1728c6e baseline version: freebsd 55a254f7734

[Xen-devel] [xen-unstable-smoke test] 135118: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135118 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/135118/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 133991 Tests

[Xen-devel] [PATCH] xen/arm: Allow cleaning the directory even when CONFIG_EARLY_PRINTK is set

2019-04-22 Thread Julien Grall
CONFIG_EARLY_PRINTK can only be set when CONFIG_DEBUG is enabled. It can be quite convenient to only modify the target. However, the target clean will not include the .config. This means CONFIG_DEBUG is not enabled and therefore make will throw an error preventing clean to continue. The check is

[Xen-devel] [PATCH 01/20] xen/const: Introduce _BITUL and _BITULL

2019-04-22 Thread Julien Grall
The pattern _AC(1, UL{,L}) << X is commonly used in the headers to make define usuable in both assembly and C. So introduce _BITUL and _BITULL to make the code slightly more readable. The idea has been taken from Linux (see include/uapi/linux.h). Signed-off-by: Julien Grall --- xen/include/xen

[Xen-devel] [PATCH 00/20] xen/arm: Clean-up & fixes in boot/mm code

2019-04-22 Thread Julien Grall
Hi all, This is the second part of the boot/memory rework for Xen on Arm. This part contains mostly clean-up & fixes found during the rework. The first part of the rework is "xen/arm: TLB flush helpers rework" [1]. For convenience, I provided a branch with all the patches applied based on next-4

[Xen-devel] [PATCH 07/20] xen/arm64: head: Remove unnecessary comment

2019-04-22 Thread Julien Grall
So far, we don't init specific core initialization at boot. So remove the comment. Signed-off-by: Julien Grall --- xen/arch/arm/arm64/head.S | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index cb30d6f22e..ad446e7345 100644 --- a/xen/ar

[Xen-devel] [PATCH 10/20] xen/arm32: head: Correctly report the HW CPU ID

2019-04-22 Thread Julien Grall
There are no reason to consider the HW CPU ID will be 0 when the processor is part of a uniprocessor system. At best, this will result to conflicting output as the rest of Xen use the value directly read from MPIDR. So remove the zeroing and logic to check if the CPU is part of a uniprocessor syst

[Xen-devel] [PATCH 04/20] xen/arm: Rework HSCTLR_BASE

2019-04-22 Thread Julien Grall
The current value of HSCTLR_BASE for Arm64 is pretty wrong. It would actually turn on SCTLR_EL2.nAA (bit 6) on hardware implementing ARMv8.4-LSE. Furthermore, the documentation of what is cleared/set in SCTLR_EL2 is also not correct and looks like to be a verbatim copy from Arm32. HSCTLR_BASE is

[Xen-devel] [PATCH 13/20] xen/arm32: mm: Avoid to zero and clean cache for CPU0 domheap

2019-04-22 Thread Julien Grall
The page-table walker is configured to use the same shareability and cacheability as the access performed when updating the page-tables. This means cleaning the cache for CPU0 domheap is unnecessary. Furthermore, CPU0 page-tables are part of Xen binary and will already be zeroed beforehand. So it

[Xen-devel] [PATCH 08/20] xen/arm64: head: Move earlyprintk messages in .rodata.str

2019-04-22 Thread Julien Grall
At the moment, the earlyprintk messages are interleaved with the instructions. This makes more difficult to read the objdump output. Introduce a new macro to add a string in .rodata.str and use it for all the earlyprintk messages. Signed-off-by: Julien Grall --- I haven't done a similar change

[Xen-devel] [PATCH 18/20] xen/arm: mm: Check start is always before end in {destroy, modify}_xen_mappings

2019-04-22 Thread Julien Grall
The two helpers {destroy, modify}_xen_mappings don't check that the start is always before the end. This should never happen but if it happens, it will result to unexpected behavior. Catch such issues earlier on by adding an ASSERT in destroy_xen_mappings and modify_xen_mappings. Signed-off-by: J

[Xen-devel] [PATCH 09/20] xen/arm64: head: Correctly report the HW CPU ID

2019-04-22 Thread Julien Grall
There are no reason to consider the HW CPU ID will be 0 when the processor is part of a uniprocessor system. At best, this will result to conflicting output as the rest of Xen use the value directly read from MPIDR_EL1. So remove the zeroing and logic to check if the CPU is part of a uniprocessor

[Xen-devel] [PATCH 06/20] xen/arm: Remove parameter cpuid from start_xen

2019-04-22 Thread Julien Grall
The parameter cpuid is not used by start_xen. So remove it. Signed-off-by: Julien Grall --- xen/arch/arm/arm32/head.S | 1 - xen/arch/arm/arm64/head.S | 1 - xen/arch/arm/setup.c | 3 +-- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/

[Xen-devel] [PATCH 05/20] xen/arm: Rework secondary_start prototype

2019-04-22 Thread Julien Grall
None of the parameters of secondary_start are actually used. So turn secondary_start to a function with no parameters. Also modify the assembly code to avoid setting-up the registers before calling secondary_start. Signed-off-by: Julien Grall --- xen/arch/arm/arm32/head.S | 6 +++--- xen/arch/a

[Xen-devel] [PATCH 16/20] xen/arm: mm: Protect Xen page-table update with a spinlock

2019-04-22 Thread Julien Grall
The function create_xen_entries may be concurrently called. So we need to protect with a spinlock to avoid corruption the page-tables. Signed-off-by: Julien Grall --- xen/arch/arm/mm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index fa0f41bd0

[Xen-devel] [PATCH 15/20] xen/arm: mm: Use the shorter version __aligned(PAGE_SIZE) to align page-tables

2019-04-22 Thread Julien Grall
We currently use the very long version __attribute__((__aligned(4096))) to align page-tables. Thankfully there is a shorter version to make the code more readable. While modifying the attribute: 1) Move it before the variable name as we do in other part of Xen 2) Switch to PAGE_SIZE instea

[Xen-devel] [PATCH 17/20] xen/arm: mm: Initialize page-tables earlier

2019-04-22 Thread Julien Grall
Since commit f60658c6ae "xen/arm: Stop relocating Xen", the function setup_page_tables() does not require any information from the FDT. So the initialization of the page-tables can be done much earlier in the boot process. The earliest setup_page_tables() can be called is after traps have been ini

[Xen-devel] [PATCH 19/20] xen/arm: Pair call to set_fixmap with call to clear_fixmap in copy_from_paddr

2019-04-22 Thread Julien Grall
At the moment, set_fixmap may replace a valid entry without following the break-before-make sequence. This may result to TLB conflict abort. Rather than dealing with Break-Before-Make in set_fixmap, every call to set_fixmap is paired with a call to clear_fixmap. Signed-off-by: Julien Grall ---

[Xen-devel] [PATCH 12/20] xen/arm32: head: Always zero r3 before update a page-table entry

2019-04-22 Thread Julien Grall
The boot code is using r2 and r3 to hold the page-table entry value. While r2 is always updated before storing the value, this is not always the case for r3. Thankfully today, r3 will always be zero when we care. But this is difficult to track and error-prone. So always zero r3 within the few ins

[Xen-devel] [PATCH 11/20] xen/arm32: head: Don't set MAIR0 and MAIR1

2019-04-22 Thread Julien Grall
The co-processor registers MAIR0 and MAIR1 are managed by EL1. So there are no need to initialize them during Xen boot. Signed-off-by: Julien Grall --- xen/arch/arm/arm32/head.S | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index d42a1

[Xen-devel] [PATCH 03/20] xen/arm: processor: Use _BITUL instead of _AC(1, U) in SCTLR_ defines

2019-04-22 Thread Julien Grall
The newly introduced macro _BITUL makes the code more readable. Signed-off-by: Julien Grall --- xen/include/asm-arm/processor.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/xen/include/asm-arm/processor.h b/xen/include/asm-arm/processor.h index c6f56490b

[Xen-devel] [PATCH 20/20] xen/arm: Allow cleaning the directory even when CONFIG_EARLY_PRINTK is set

2019-04-22 Thread Julien Grall
CONFIG_EARLY_PRINTK can only be set when CONFIG_DEBUG is enabled. It can be quite convenient to only modify the target. However, the target clean will not include the .config. This means CONFIG_DEBUG is not enabled and therefore make will throw an error preventing clean to continue. The check is

[Xen-devel] [PATCH 14/20] xen/arm32: mm: Avoid cleaning the cache for secondary CPUs page-tables

2019-04-22 Thread Julien Grall
The page-table walker is configured to use the same shareability and cacheability as the access performed when updating the page-tables. This means cleaning the cache for secondary CPUs runtime page-tables is unnecessary. Signed-off-by: Julien Grall --- xen/arch/arm/mm.c | 3 --- 1 file changed,

[Xen-devel] [PATCH 02/20] xen/arm: Rename SCTLR_* defines and remove unused one

2019-04-22 Thread Julien Grall
The SCTLR_* are currently used for SCTLR/HSCTLR (arm32) and SCTLR_EL1/SCTLR_EL2 (arm64). The naming scheme is actually quite confusing because they may only be defined for an archicture (or even an exception level). So it is not easy for the developer to know which one to use. The naming scheme i

[Xen-devel] [xen-4.12-testing test] 135008: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135008 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/135008/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow216 guest-saverestore.2 fail REGR. vs. 133989 build-i386

Re: [Xen-devel] [PATCH 1/6] xen: extend XEN_DOMCTL_memory_mapping to handle cacheability

2019-04-22 Thread Stefano Stabellini
On Sun, 21 Apr 2019, Julien Grall wrote: > Hi Stefano, > > On 4/20/19 12:20 AM, Stefano Stabellini wrote: > > On Wed, 27 Feb 2019, Julien Grall wrote: > > > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > > > > index 30cfb01..5b8fcc5 100644 > > > > --- a/xen/arch/arm/p2m.c > > > > +++ b/x

Re: [Xen-devel] [PATCH 1/6] xen: extend XEN_DOMCTL_memory_mapping to handle cacheability

2019-04-22 Thread Julien Grall
Hi, On 22/04/2019 18:33, Stefano Stabellini wrote: > On Sun, 21 Apr 2019, Julien Grall wrote: >> Hi Stefano, >> >> On 4/20/19 12:20 AM, Stefano Stabellini wrote: >>> On Wed, 27 Feb 2019, Julien Grall wrote: > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > index 30cfb01..5b8fcc5 100

[Xen-devel] [xen-unstable-smoke test] 135128: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135128 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/135128/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 133991 Tests

[Xen-devel] [linux-4.9 test] 135010: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135010 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/135010/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim7 xen-boot fail REGR. vs. 134015 test-amd64-amd64-xl-q

[Xen-devel] [ovmf test] 135124: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135124 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/135124/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 134977 build-i386-pvops

[Xen-devel] [xen-unstable-smoke test] 135143: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135143 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/135143/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 133991 Tests

Re: [Xen-devel] [PATCH 1/6] xen: extend XEN_DOMCTL_memory_mapping to handle cacheability

2019-04-22 Thread Stefano Stabellini
On Sun, 21 Apr 2019, Julien Grall wrote: > > > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > > > > index 30cfb01..5b8fcc5 100644 > > > > --- a/xen/arch/arm/p2m.c > > > > +++ b/xen/arch/arm/p2m.c > > > > @@ -1068,9 +1068,24 @@ int unmap_regions_p2mt(struct domain *d, > > > >int map_mm

Re: [Xen-devel] [PATCH 5/6] xen/arm: map reserved-memory regions as normal memory in dom0

2019-04-22 Thread Stefano Stabellini
On Tue, 26 Feb 2019, Julien Grall wrote: > Hi Stefano, > > On 26/02/2019 23:07, Stefano Stabellini wrote: > > reserved-memory regions should be mapped as normal memory. At the > > moment, they get remapped as device memory in dom0 because Xen doesn't > > know any better. Add an explicit check for

[Xen-devel] [qemu-upstream-4.10-testing test] 135014: FAIL

2019-04-22 Thread osstest service owner
flight 135014 qemu-upstream-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/135014/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken in 134

Re: [Xen-devel] VMI: singlestep event not received

2019-04-22 Thread Mathieu Tarral
On Monday 22 April 2019 11:22, Razvan Cojocaru wrote: > On 4/22/19 1:26 AM, Mathieu Tarral wrote: > > > The problem is that RtlUserThreadStart is paged-out, so i'm trying to reach > > it via singlestepping as a backup solution. > > FWIW, you can just use xc_hvm_inject_trap() with a TRAP_page_fa

[Xen-devel] [xen-unstable-smoke test] 135155: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135155 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/135155/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 133991 Tests

[Xen-devel] [libvirt test] 135017: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135017 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/135017/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 133846 Tests which did not suc

[Xen-devel] [xen-unstable-smoke test] 135158: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135158 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/135158/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 10 debian-hvm-install fail REGR. vs. 133991 Tests

[Xen-devel] [linux-4.14 test] 135021: regressions - FAIL

2019-04-22 Thread osstest service owner
flight 135021 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/135021/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 133923 build-i386-pvops