Re: [Xen-devel] [PATCH RFC 00/39] x86/KVM: Xen HVM guest support

On 10/04/2019 08:55, Ankur Arora wrote: > On 2019-04-08 10:04 p.m., Juergen Gross wrote: >> On 08/04/2019 19:31, Joao Martins wrote: >>> On 4/8/19 11:42 AM, Juergen Gross wrote: On 08/04/2019 12:36, Joao Martins wrote: > On 4/8/19 7:44 AM, Juergen Gross wrote: >> On 12/03/2019 18:14, J

Re: [Xen-devel] [PATCH v5] x86/mm: Clean up p2m_finish_type_change return value

Roger/Paul are you ok with the latest changes? Can this go in? Regards, Alex On 29.03.2019 14:50, Alexandru Stefan ISAILA wrote: > In the case of any errors, finish_type_change() passes values returned > from p2m->recalc() up the stack (with some exceptions in the case where > an error is expecte

Re: [Xen-devel] [PATCH] x86/msr: Fix fallout from mostly c/s 832c180

On Tue, Apr 09, 2019 at 06:53:47PM +0100, Andrew Cooper wrote: > The series 832c1803^..f61685a6 was committed without adequate review. > > * Fix the shim build by providing a !CONFIG_HVM declaration for >hvm_get_guest_bndcfgs() > * Revert the bogus de-const'ing of the vcpu pointer in >vm

Re: [Xen-devel] [PATCH] x86/msr: Fix fallout from mostly c/s 832c180

> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 09 April 2019 18:54 > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Wei Liu > ; Roger Pau Monne ; Paul Durrant > ; > Jun Nakajima ; Kevin Tian > Subject: [PATCH] x86/msr: Fix fallout from mostly

Re: [Xen-devel] [PATCH] x86/msr: Fix fallout from mostly c/s 832c180

> -Original Message- > From: Paul Durrant > Sent: 10 April 2019 09:28 > To: Andrew Cooper ; Xen-devel > > Cc: Andrew Cooper ; Jan Beulich > ; Wei Liu > ; Roger Pau Monne ; Jun Nakajima > ; > Kevin Tian > Subject: RE: [PATCH] x86/msr: Fix fallout from mostly c/s 832c180 > > > -Orig

Re: [Xen-devel] [PATCH v5] x86/mm: Clean up p2m_finish_type_change return value

> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf Of > Alexandru Stefan ISAILA > Sent: 10 April 2019 09:19 > To: xen-devel@lists.xenproject.org; George Dunlap ; > Paul Durrant > > Cc: Andrew Cooper ; Wei Liu ; > jbeul...@suse.com; Roger > P

Re: [edk2-devel] [PATCH v2 01/31] OvmfPkg/ResetSystemLib: Add missing dependency on PciLib

On 04/09/19 13:08, Anthony PERARD wrote: > and remove extra includes of OvmfPlatforms.h. (1) In commit messages, please don't rely on the subject line, and the first paragraph of the body, being read as a single sentence. (Similarly, please avoid empy commit message bodies.) If there's no better w

Re: [edk2-devel] [PATCH v2 01/31] OvmfPkg/ResetSystemLib: Add missing dependency on PciLib

On 2019-04-10 01:48:39, Laszlo Ersek wrote: > On 04/09/19 13:08, Anthony PERARD wrote: > > and remove extra includes of OvmfPlatforms.h. > > (1) In commit messages, please don't rely on the subject line, and the > first paragraph of the body, being read as a single sentence. I think BaseTools/Scr

Re: [Xen-devel] [PATCH 1/9] libxl_internal: Remove lost comment

On Tue, Apr 09, 2019 at 05:45:34PM +0100, Anthony PERARD wrote: > That comment as been separated from the function it defines by > 4197d3abbb3055d3798254eb7ba239bfb5824360, but then was not useful > anymore when the libxl__device_disk_add() prototype was removed by > 22ea8ad02e465e32cd40887c750b55c

Re: [edk2-devel] [PATCH v2 02/31] OvmfPkg: Create platform XenOvmf

On 04/09/19 13:08, Anthony PERARD wrote: > This is a copy of OvmfX64, removing VirtIO and some SMM. > > This new platform will be changed to make it works on two types of Xen > guest: HVM and PVH. > > Compare to OvmfX64, this patch: > > - changed: PLATFORM_GUID, OUTPUT_DIRECTORY, FLASH_DEFINITIO

[Xen-devel] [PATCH] AMD/IOMMU: adjust IOMMU list head initialization

Do this statically, which will allow accessing the (empty) list even without having come through acpi_ivrs_init(). Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/amd/iommu_init.c +++ b/xen/drivers/passthrough/amd/iommu_init.c @@ -36,7 +36,7 @@ static struct tasklet amd_iommu_irq_task

Re: [Xen-devel] [PATCH] x86/msr: Fix fallout from mostly c/s 832c180

On 10/04/2019 09:23, Wei Liu wrote: > On Tue, Apr 09, 2019 at 06:53:47PM +0100, Andrew Cooper wrote: >> The series 832c1803^..f61685a6 was committed without adequate review. >> >> * Fix the shim build by providing a !CONFIG_HVM declaration for >>hvm_get_guest_bndcfgs() >> * Revert the bogus d

Re: [edk2-devel] [PATCH v2 03/31] OvmfPkg: Introduce XenResetVector

On 04/09/19 13:08, Anthony PERARD wrote: > Copy of OvmfPkg/ResetVector, with one changes: > - SEC_DEFAULT_CR0: enable cache (bit 30 or CD set to 0) > > Xen copies the OVMF code to RAM, there is no need to disable cache. > > This new module will later be modified to add a new entry point, more >

Re: [edk2-devel] [PATCH v2 02/31] OvmfPkg: Create platform XenOvmf

On 2019-04-09 04:08:15, Anthony PERARD wrote: > This is a copy of OvmfX64, removing VirtIO and some SMM. > > This new platform will be changed to make it works on two types of Xen > guest: HVM and PVH. > > Compare to OvmfX64, this patch: > > - changed: PLATFORM_GUID, OUTPUT_DIRECTORY, FLASH_DEFI

Re: [Xen-devel] [PATCH v5] x86/mm: Clean up p2m_finish_type_change return value

>>> On 10.04.19 at 10:19, wrote: > Roger/Paul are you ok with the latest changes? Can this go in? The thing keeping it from going in is the lack of George's ack. Judging from the To: list of your mail you may even have meant him instead of Roger. Jan __

[Xen-devel] [xen-unstable-coverity test] 134603: regressions - ALL FAIL

flight 134603 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/134603/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: coverity-amd647 coverity-upload fail REGR. vs. 133615 version t

Re: [Xen-devel] [PATCH v5] x86/mm: Clean up p2m_finish_type_change return value

On 3/29/19 1:01 PM, Jan Beulich wrote: On 29.03.19 at 13:50, wrote: >> @@ -1174,9 +1174,9 @@ static int finish_type_change(struct p2m_domain *p2m, >> /* >> * ept->recalc could return 0/1/-ENOMEM. pt->recalc could return >> * 0/-ENOMEM/-ENOENT, -ENOENT isn't an err

Re: [Xen-devel] [PATCH] AMD/IOMMU: adjust IOMMU list head initialization

On 10/04/2019 10:37, Jan Beulich wrote: > Do this statically, which will allow accessing the (empty) list even > without having come through acpi_ivrs_init(). > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-dev

Re: [Xen-devel] [PATCH] x86/msr: Fix fallout from mostly c/s 832c180

On Wed, Apr 10, 2019 at 10:41:24AM +0100, Andrew Cooper wrote: > On 10/04/2019 09:23, Wei Liu wrote: > > On Tue, Apr 09, 2019 at 06:53:47PM +0100, Andrew Cooper wrote: > >> The series 832c1803^..f61685a6 was committed without adequate review. > >> > >> * Fix the shim build by providing a !CONFIG_H

Re: [Xen-devel] [PATCH] x86/msr: Fix fallout from mostly c/s 832c180

>>> On 09.04.19 at 19:53, wrote: > The series 832c1803^..f61685a6 was committed without adequate review. > > * Fix the shim build by providing a !CONFIG_HVM declaration for >hvm_get_guest_bndcfgs() > * Revert the bogus de-const'ing of the vcpu pointer in >vmx_get_guest_bndcfgs(). vmx_v

[Xen-devel] [PATCH v1] libxl: update prototype of libxl__device_vkb_dm_needed

Align code to match other usage of device_dm_needed_fn_t: recieve a void pointer, assign to expected type and use it accordingly. No functional change expected. Signed-off-by: Olaf Hering --- tools/libxl/libxl_vkb.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/too

[Xen-devel] [distros-debian-squeeze test] 83918: trouble: blocked/broken

flight 83918 distros-debian-squeeze real [real] http://osstest.xensource.com/osstest/logs/83918/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-i386

[Xen-devel] [PATCH v1] libxl: fix migration of PV and PVH domUs with and without qemu

If a domU has a qemu-xen instance attached, it is required to call qemus "xen-save-devices-state" method. Without it, the receiving side of a PV or PVH migration may be unable to lock the image: xen be: qdisk-51712: xen be: qdisk-51712: error: Failed to get "write" lock error: Failed to get "write

Re: [Xen-devel] [PATCH v1] libxl: update prototype of libxl__device_vkb_dm_needed

On Wed, Apr 10, 2019 at 12:26:34PM +0200, Olaf Hering wrote: > Align code to match other usage of device_dm_needed_fn_t: > recieve a void pointer, assign to expected type and use it accordingly. > > No functional change expected. > > Signed-off-by: Olaf Hering Acked-by: Wei Liu __

Re: [edk2-devel] [PATCH v2 04/31] OvmfPkg: Introduce XenPlatformPei

On 04/09/19 13:08, Anthony PERARD wrote: > A copy of OvmfPkg/PlatformPei without some of QEMU specific > initialization, Xen does not support QemuFwCfg. > > This new module will be adjusted to accommodate Xen PVH. > > fw_cfg dependents that have been removed, which are dynamically skipped > when

Re: [Xen-devel] [PATCH v1] libxl: fix migration of PV and PVH domUs with and without qemu

Am Wed, 10 Apr 2019 12:33:38 +0200 schrieb Olaf Hering : > +/* will be set later */ That should read 'may be set later' because not all callers of libxl__domain_build_info_setdefault() have a need to update this field. Olaf pgpr4dfH_eiXz.pgp Description: Digitale Signatur von Open

[Xen-devel] [PATCH] x86/mem-sharing: statically initialize audit list head and lock

There's no need to execute any instructions for doing so. Signed-off-by: Jan Beulich --- I wonder whether mem_sharing_init() shouldn't go away altogether then. --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -65,8 +65,8 @@ static DEFINE_PER_CPU(pg_lock_data_t, __ #i

Re: [Xen-devel] [PATCH v3 2/3] xen: remove tmem from hypervisor

>>> On 09.04.19 at 18:52, wrote: > --- a/xen/arch/x86/guest/hypercall_page.S > +++ b/xen/arch/x86/guest/hypercall_page.S > @@ -58,8 +58,8 @@ DECLARE_HYPERCALL(hvm_op) > DECLARE_HYPERCALL(sysctl) > DECLARE_HYPERCALL(domctl) > DECLARE_HYPERCALL(kexec_op) > -DECLARE_HYPERCALL(tmem_op) > DECLARE_H

[Xen-devel] [PATCH] xmalloc: statically initialize pool list head and lock

There's no need to execute any instructions for doing so. Signed-off-by: Jan Beulich --- a/xen/common/xmalloc_tlsf.c +++ b/xen/common/xmalloc_tlsf.c @@ -65,8 +65,8 @@ #define PREV_FREE (0x2) #define PREV_USED (0x0) -static spinlock_t pool_list_lock; -static struct list_head pool_

Re: [Xen-devel] [PATCH] xmalloc: statically initialize pool list head and lock

On 4/10/19 11:58 AM, Jan Beulich wrote: > There's no need to execute any instructions for doing so. > > Signed-off-by: Jan Beulich Reviewed-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailm

Re: [Xen-devel] [PATCH] xmalloc: statically initialize pool list head and lock

On Wed, Apr 10, 2019 at 04:58:30AM -0600, Jan Beulich wrote: > There's no need to execute any instructions for doing so. > > Signed-off-by: Jan Beulich Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenpr

Re: [Xen-devel] [PATCH] x86/mem-sharing: statically initialize audit list head and lock

On 10/04/2019 11:58, Jan Beulich wrote: > There's no need to execute any instructions for doing so. > > Signed-off-by: Jan Beulich > --- > I wonder whether mem_sharing_init() shouldn't go away altogether then. I vote for removing it completely.  The printk is a out-of-character compared to other

Re: [Xen-devel] [PATCH] x86/mem-sharing: statically initialize audit list head and lock

On 4/10/19 12:13 PM, Andrew Cooper wrote: > On 10/04/2019 11:58, Jan Beulich wrote: >> There's no need to execute any instructions for doing so. >> >> Signed-off-by: Jan Beulich >> --- >> I wonder whether mem_sharing_init() shouldn't go away altogether then. > > I vote for removing it completely.

Re: [Xen-devel] Xen ARM dom0less use PV drivers

Hi, CCing Stefano who is looking after dom0less. On 08/04/2019 03:17, jinchen wrote: Hello experts:     The xen 4.12 support the Dom0less VM that start domu from xen not xl, but the PV drivers hasn't been supported. Do you have some guidance for how to enable PV drivers when using dom0less?

Re: [Xen-devel] [PATCH 1/3] xen-bus: use a separate fd for each event channel

On Mon, Apr 08, 2019 at 04:16:15PM +0100, Paul Durrant wrote: > To better support use of IOThread-s it will be necessary to be able to set > the AioContext for each XenEventChannel and hence it is necessary to open a > separate handle to libxenevtchan for each channel. > > This patch stops using N

Re: [Xen-devel] [PATCH v3 2/3] xen: remove tmem from hypervisor

On Wed, Apr 10, 2019 at 04:55:50AM -0600, Jan Beulich wrote: > >>> On 09.04.19 at 18:52, wrote: > > --- a/xen/arch/x86/guest/hypercall_page.S > > +++ b/xen/arch/x86/guest/hypercall_page.S > > @@ -58,8 +58,8 @@ DECLARE_HYPERCALL(hvm_op) > > DECLARE_HYPERCALL(sysctl) > > DECLARE_HYPERCALL(domctl)

Re: [Xen-devel] [PATCH v3 2/3] xen: remove tmem from hypervisor

>>> On 10.04.19 at 13:57, wrote: > On Wed, Apr 10, 2019 at 04:55:50AM -0600, Jan Beulich wrote: >> >>> On 09.04.19 at 18:52, wrote: >> > --- a/xen/common/Makefile >> > +++ b/xen/common/Makefile >> >> There's are hunks missing here to remove >> >> obj-$(CONFIG_TMEM) += lzo.o >> >> and to replac

Re: [Xen-devel] [PATCH v3 2/3] xen: remove tmem from hypervisor

On Wed, Apr 10, 2019 at 12:57:57PM +0100, Wei Liu wrote: > On Wed, Apr 10, 2019 at 04:55:50AM -0600, Jan Beulich wrote: > > >>> On 09.04.19 at 18:52, wrote: > > > --- a/xen/arch/x86/guest/hypercall_page.S > > > +++ b/xen/arch/x86/guest/hypercall_page.S > > > @@ -58,8 +58,8 @@ DECLARE_HYPERCALL(hvm

Re: [Xen-devel] [PATCH] x86/mem-sharing: statically initialize audit list head and lock

>>> On 10.04.19 at 13:20, wrote: > On 4/10/19 12:13 PM, Andrew Cooper wrote: >> On 10/04/2019 11:58, Jan Beulich wrote: >>> There's no need to execute any instructions for doing so. >>> >>> Signed-off-by: Jan Beulich >>> --- >>> I wonder whether mem_sharing_init() shouldn't go away altogether the

Re: [Xen-devel] [PATCH v3 2/3] xen: remove tmem from hypervisor

On Wed, Apr 10, 2019 at 06:12:35AM -0600, Jan Beulich wrote: > >>> On 10.04.19 at 13:57, wrote: > > On Wed, Apr 10, 2019 at 04:55:50AM -0600, Jan Beulich wrote: > >> >>> On 09.04.19 at 18:52, wrote: > >> > --- a/xen/common/Makefile > >> > +++ b/xen/common/Makefile > >> > >> There's are hunks mis

Re: [Xen-devel] [PATCH v3 2/3] xen: remove tmem from hypervisor

On Wed, Apr 10, 2019 at 06:25:30AM -0600, Jan Beulich wrote: > >>> On 10.04.19 at 14:21, wrote: > > On Wed, Apr 10, 2019 at 06:12:35AM -0600, Jan Beulich wrote: > >> >>> On 10.04.19 at 13:57, wrote: > >> > On Wed, Apr 10, 2019 at 04:55:50AM -0600, Jan Beulich wrote: > >> >> >>> On 09.04.19 at 18:

Re: [Xen-devel] [PATCH v3 2/3] xen: remove tmem from hypervisor

>>> On 10.04.19 at 14:21, wrote: > On Wed, Apr 10, 2019 at 06:12:35AM -0600, Jan Beulich wrote: >> >>> On 10.04.19 at 13:57, wrote: >> > On Wed, Apr 10, 2019 at 04:55:50AM -0600, Jan Beulich wrote: >> >> >>> On 09.04.19 at 18:52, wrote: >> >> > --- a/xen/common/Makefile >> >> > +++ b/xen/common/

Re: [Xen-devel] [PATCH 2/3] xen-bus: allow AioContext to be specified for each event channel

On Mon, Apr 08, 2019 at 04:16:16PM +0100, Paul Durrant wrote: > This patch adds an AioContext parameter to xen_device_bind_event_channel() > and then uses aio_set_fd_handler() to set the callback rather than > qemu_set_fd_handler(). > > Signed-off-by: Paul Durrant > --- > @@ -943,6 +944,7 @@ stat

[edk2-devel] [PATCH 2/4] OvmfPkg/License.txt: refresh the MIT license text and include the SPDX ID

Refresh the MIT license text from , and add "SPDX-License-Identifier: MIT" for easier parsing by machines. This follows the tree-wide adoption of "SPDX-License-Identifier"s, made for ; in particular: - commit

[edk2-devel] [PATCH 0/4] OvmfPkg: replace MIT license blocks with SPDX IDs

Repo: https://github.com/lersek/edk2.git Branch: ovmf_spdx_mit For , we replaced open-coded license text blocks with "SPDX-License-Identifier"s, almost all over the edk2 tree. That change however was tied to a license update / CLA update too

[edk2-devel] [PATCH 4/4] OvmfPkg/XenBusDxe: replace MIT license text with SPDX ID

The "XenBus.c", "XenStore.c", "XenStore.h" files under "OvmfPkg/XenBusDxe" include the MIT License text. Replace those license blocks with "SPDX-License-Identifier: MIT" (which refers to ) for easier parsing by machines (and humans). This follows the tree-wide a

Re: [Xen-devel] [PATCH] x86: fix build race when generating temporary object files

On 09/04/2019 15:57, Jan Beulich wrote: > The rules to generate xen-syms and xen.efi may run in parallel, but both > recursively invoke $(MAKE) to build symbol/relocation table temporary > object files. These recursive builds would both re-generate the .*.d2 > files (where needed). Both would in tu

[edk2-devel] [PATCH 3/4] OvmfPkg/IndustryStandard/Xen: replace MIT license text with SPDX ID

The header files under "OvmfPkg/Include/IndustryStandard/Xen" include the MIT License text. Replace those license blocks with "SPDX-License-Identifier: MIT" (which refers to ) for easier parsing by machines (and humans). This follows the tree-wide adoption of "S

[edk2-devel] [PATCH 1/4] OvmfPkg/License.txt: remove XenPvBlkDxe from the MIT licensed dir list

All files under "OvmfPkg/XenPvBlkDxe" carry SPDX-License-Identifier: BSD-2-Clause-Patent None of them are MIT-licensed. Update "OvmfPkg/License.txt" accordingly. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Cc: Lars Kurth Cc: xen-devel@lists.xenproject.org Bug

Re: [Xen-devel] [PATCH] AMD/IOMMU: disable previously enabled IOMMUs upon init failure

On 08/04/2019 12:19, Jan Beulich wrote: > If any IOMMUs were successfully initialized before encountering failure, > the successfully enabled ones should be disabled again before cleaning > up their resources. > > Move disable_iommu() next to enable_iommu() to avoid a forward > declaration, and tak

Re: [Xen-devel] [PATCH] x86/mem-sharing: statically initialize audit list head and lock

On Wed, Apr 10, 2019 at 6:17 AM Jan Beulich wrote: > > >>> On 10.04.19 at 13:20, wrote: > > On 4/10/19 12:13 PM, Andrew Cooper wrote: > >> On 10/04/2019 11:58, Jan Beulich wrote: > >>> There's no need to execute any instructions for doing so. > >>> > >>> Signed-off-by: Jan Beulich > >>> --- > >>

[Xen-devel] x86 guest EOI timer issues / questions

All, Andrew's observation mentioned in "[PATCH v2] x86/smt: Support for enabling/disabling SMT at runtime" and some discussions we've already had with him made me look into how exactly the EOI timer works. I think there are a number of quirks. I'll enumerate all questions I've run into below. At t

Re: [Xen-devel] [PATCH v3 2/3] x86/mm: Introduce altp2m_set_entry_by_page_order

On 4/9/19 1:03 PM, Alexandru Stefan ISAILA wrote: > This patch moves common code from p2m_set_altp2m_mem_access() and > p2m_change_altp2m_gfn() into one function > > Signed-off-by: Alexandru Isaila > --- > xen/arch/x86/mm/mem_access.c | 2 +- > xen/include/asm-x86/p2m.h| 11 +++ > 2

Re: [Xen-devel] [PATCH v3 2/3] x86/mm: Introduce altp2m_set_entry_by_page_order

On 10.04.2019 17:18, George Dunlap wrote: > On 4/9/19 1:03 PM, Alexandru Stefan ISAILA wrote: >> This patch moves common code from p2m_set_altp2m_mem_access() and >> p2m_change_altp2m_gfn() into one function >> >> Signed-off-by: Alexandru Isaila >> --- >> xen/arch/x86/mm/mem_access.c | 2 +- >

[Xen-devel] [OSSTEST PATCH 01/62] gitignore: ignore vim swap file

From: Wei Liu Signed-off-by: Wei Liu Acked-by: Ian Jackson --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 425506b6..f7e5b77f 100644 --- a/.gitignore +++ b/.gitignore @@ -1,5 +1,6 @@ *~ *.bak +*.swp tmp *.tmp bisection.ps -- 2.11.0 _

[Xen-devel] [OSSTEST PATCH 02/62] power: Fix uninitialised variable warning

In power: Record approach used for power cycles in runvars we introduced a reference to $r{$rv} which might be undef, resulting in this: Use of uninitialized value in concatenation (.) or string at Osstest/TestSupport.pm line 1069. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 2 +

[Xen-devel] [OSSTEST PATCH 25/62] persistent-net: Add overlay on installed systems >= stretch

This prepares the ground for turning off net.ifnames. The actual rules are gated on net.ifnames so right now there is no change. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 414cd897..e246

[Xen-devel] [OSSTEST PATCH 12/62] ts-guests-nbd-mirror: make it work with stretch

From: Wei Liu On the server side, only add oldstyle= and port= on wheezy and jessie. stretch doesn't support or need those anymore. On the client side, generate new style configuration file. Reorder nbd-client setup a bit. Install it first, then write our own configuration file, then start it.

[Xen-devel] [OSSTEST PATCH 20/62] ts-guests-nbd-mirror: use target_{get, put}file_root to transfter cfg

From: Wei Liu The original code used target_cmd_output_root which caused a trailing new line to be deleted, which caused libvirt converter to fail. It wasn't discovered until now because we appended too many "\n". Use target_{get,put}file_root to do the job. Signed-off-by: Wei Liu --- ts-gue

[Xen-devel] [OSSTEST PATCH 00/62] Update to Debian stable (stretch)

This, finally, is the series to update osstest to Debian stretch. This is very urgent because Debian have been removing parts of jessie from their servers, in a rather unhelpful and not entirely controlled manner. Consequently, currently osstest is not reliable with jessie. I am going to push thi

[Xen-devel] [OSSTEST PATCH 13/62] Extend workaround `clk_ignore_unused' to stretch

From: Wei Liu This is https://bugs.xenproject.org/xen/bug/45 Without that parameter we lose uart output. Signed-off-by: Wei Liu CC: Stefano Stabellini CC: Julien Grall --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debia

[Xen-devel] [OSSTEST PATCH 03/62] ts-xen-build-prep: only install w3c-dtd-xhtml for suites

From: Wei Liu That package is not included in stretch. That package was installed because the libvirt build needed it. However libvirt builds fine without it in stretch. Signed-off-by: Wei Liu Acked-by: Ian Jackson --- ts-xen-build-prep | 6 -- 1 file changed, 4 insertions(+), 2 deletion

[Xen-devel] [OSSTEST PATCH 33/62] ts-xen-build: Enable ITS driver in Xen

From: Julien Grall The ITS driver was added in Xen 4.10 as a technical preview feature. However, it is required in order to boot Xen as Thunder-X because PCI devices don't support legacy interrupt. So enable CONFIG_ITS in our Xen build. Signed-off-by: Julien Grall --- ts-xen-build | 4 1

[Xen-devel] [OSSTEST PATCH 09/62] ts-debian-fixup: merge origin extra= to our own if necessary

From: Wei Liu The original extra= was not removed, so there were two extra= in the resulting config file. It wasn't a problem for xl because the second extra= took precedence. However libvirt tests would only pick up the first extra= so they worked by chance. Fix this issue by merging the origi

[Xen-devel] [OSSTEST PATCH 37/62] TestSupport: Provide target_getfile_root_stash

This convenient function selects a local filename based on a target filename, and copies the target file to the selected stash file. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm

[Xen-devel] [OSSTEST PATCH 11/62] ts-xen-build-prep: install e2fslibs-dev

From: Wei Liu The in-tree libfsimage ext2fs implementation can't handle 64bit enabled ext4, which is the default in stretch. Installing e2fslibs-dev causes libfsimage to pick up the packaged ext2fs implementation. Signed-off-by: Wei Liu --- ts-xen-build-prep | 6 ++ 1 file changed, 6 inse

[Xen-devel] [OSSTEST PATCH 34/62] TestSupport: Move `stashed files' and `next_unique_name' earlier

We are going to make more use of this in intervening code. Pure code motion. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 78 +- 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSuppor

[Xen-devel] [OSSTEST PATCH 17/62] stretch: Use chainloading when booting using GRUB on Arm64

From: Julien Grall The GRUB package in stretch is not able to boot Xen on Arm64. Use chainloading as we did for jessie for the time being. Note that a bug has been filled on Debian to integrate Xen pactches for the next release (see [1]). [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=88

[Xen-devel] [OSSTEST PATCH 40/62] preseed_base: break out debian_overlays_fixup_cmd

We are going to want this for guests too. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index d76dd03d..78d242e4 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@

[Xen-devel] [OSSTEST PATCH 10/62] ts-debian-fixup: append noresume

From: Wei Liu See code comment for explanation. Signed-off-by: Wei Liu Acked-by: Ian Jackson --- v4: Fix grammar error in comment. --- ts-debian-fixup | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ts-debian-fixup b/ts-debian-fixup index 478dc2af..0e553d47 100755 --- a/ts-deb

[Xen-devel] [OSSTEST PATCH 06/62] Debian.pm: use sysvinit-core instead of systemd

From: Wei Liu Install that packages for suites >wheezy, because they use systemd as the default init. Signed-off-by: Wei Liu Acked-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 59c60d40..82

[Xen-devel] [OSSTEST PATCH 27/62] ts-host-install: Break out $persistent_net_rules

We're going to want to reuse this value. Signed-off-by: Ian Jackson --- ts-host-install | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ts-host-install b/ts-host-install index 8ea81e24..f80a151c 100755 --- a/ts-host-install +++ b/ts-host-install @@ -195,6 +195,9 @@ sub se

[Xen-devel] [OSSTEST PATCH 26/62] persistent-net: Add overlay in installer >= stretch

We are going to need this in the installer so that the interface names from the installer environment are captured so that they can be the same on the host. This prepares the ground for turning off net.ifnames. The actual rules are gated on net.ifnames so right now there is no change. Signed-off

[Xen-devel] [OSSTEST PATCH 32/62] ts-kernel-build: Enable some additional drivers for Thunder-X

Without this, our kernels do not find the storage. Suggested-by: Julien Grall Signed-off-by: Ian Jackson --- ts-kernel-build | 11 +++ 1 file changed, 11 insertions(+) diff --git a/ts-kernel-build b/ts-kernel-build index 0bc443de..3dad7d36 100755 --- a/ts-kernel-build +++ b/ts-kernel-b

[Xen-devel] [OSSTEST PATCH 15/62] ts-debian-di-install: use gho to pick d-i

From: Wei Liu The original code used ho which gave us the host suite, but we wanted the guest suite. Signed-off-by: Wei Liu Acked-by: Ian Jackson --- ts-debian-di-install | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ts-debian-di-install b/ts-debian-di-install index

[Xen-devel] [OSSTEST PATCH 30/62] persistent-net: Include initramfs script to copy to target

This is the piece which actually copies the installer's network names to the target. It should not appear on the installed system, so it's not in overlay-persistent-net. Technically this is only useful when the installer has the overlay-persistent-net in it, which is done only in ts-host-install

[Xen-devel] [OSSTEST PATCH 23/62] contents_make_cpio: Make files owned by root

This function is called to generate overlays for use, mainly, by the initramfs. We are going to use it to ship udev rules. Annoyingly, udev hates files which aren't owned by root - it simply ignores them. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 2 +- 1 file changed, 1 insertion

[Xen-devel] [OSSTEST PATCH 60/62] Debian: Fix /lib/udev/ifupdown-hotplug in guests from debootstrap

The ifupdown-hotplug problem just described affects guests too. Empirically, this occurs only with the guests from xen-tools. In my osstest stretch series development tests this resulted in occasional failures of ts-guest-start. The problem is not deterministic; and it may be that it is a race b

[Xen-devel] [OSSTEST PATCH 24/62] overlay-persistent-net: Copy from jessie

These were copied from a system running Debian jessie. The nontrivial files are: # Copyright (C) 2006 Marco d'Itri # Copyright (C) 2007 Kay Sievers and licenced GPLv2+. That is compatible with osstest's AGPLv3+. Right now we do nothing with these. Signed-off-by: Ian Jackson --- overlay-pe

[Xen-devel] [OSSTEST PATCH 16/62] make-flight: guest should use jessie to test pvgrub

From: Wei Liu stretch has 64bit feature enabled for ext4, which pvgrub can't cope. We want to continue to test pvgrub, so specify jessie in the guest suite field. A consequence is that this test will test jessie forever. Eventually jessie will rot so badly that this test fails and then we will

[Xen-devel] [OSSTEST PATCH 50/62] dm restrict audit: actually install fishdescriptor in host

In dm restrict audit: install newer chiark-scripts for fishdescriptor arrangements were made to install a backport of chiark-scripts but the code was mistakenly placed in preseed_create_guest but of course it's needed in the host. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 11 ++---

[Xen-devel] [OSSTEST PATCH 43/62] preseed_hook_installscript: Use partman/early_command, not preseed/

On iso-based installs, with stretch, preseed/early_command runs before the network is up. This causes the install to fail. Our existing call sites add things to /usr/lib/base-installer.d/ /lib/partman/init.d/ for which this is still early enough. Signed-off-by: Ian Jackson --- Osstest/De

[Xen-devel] [OSSTEST PATCH 19/62] Debian: Fix http:// url for bugs.xenproject.org

Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 80b4cf37..414cd897 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -239,7 +239,7 @@ END # Dom0 specific kernel options

[Xen-devel] [OSSTEST PATCH 35/62] TestSupport: Move `target_somefile_getleaf' earlier

We are going to make more use of this in intervening code. Pure code motion. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index ce346097..4e2f120a 1006

[Xen-devel] [OSSTEST PATCH 08/62] ts-host-install: don't use the new nic naming scheme

From: Wei Liu Signed-off-by: Wei Liu Acked-by: Ian Jackson --- ts-host-install | 4 1 file changed, 4 insertions(+) diff --git a/ts-host-install b/ts-host-install index 292733ba..9ab3de62 100755 --- a/ts-host-install +++ b/ts-host-install @@ -244,6 +244,10 @@ END # why this is repea

[Xen-devel] [OSSTEST PATCH 38/62] ts-guests-nbd-mirror: Use target_getfile_root_stash

That removes the rather ad-hoc open-coding. Signed-off-by: Ian Jackson --- ts-guests-nbd-mirror | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ts-guests-nbd-mirror b/ts-guests-nbd-mirror index 06903aaa..0365c47b 100755 --- a/ts-guests-nbd-mirror +++ b/ts-guests-nbd-mirro

[Xen-devel] [OSSTEST PATCH 29/62] ts-host-install: Put canary in 70-persistent-net.rules

This will allow us to see if the initramfs's network names are being properly copied to the installed system. Ie, this is just a debugging aid. Signed-off-by: Ian Jackson --- ts-host-install | 4 1 file changed, 4 insertions(+) diff --git a/ts-host-install b/ts-host-install index 7423eb9b

[Xen-devel] [OSSTEST PATCH 41/62] ts-debian-fixup: Use debian_overlays_fixup_cmd

Otherwise we get the same error for guests as was prevented for hosts by "preseed_base: chmod ssh host private keys to placate sshd". Signed-off-by: Ian Jackson --- ts-debian-fixup | 5 + 1 file changed, 5 insertions(+) diff --git a/ts-debian-fixup b/ts-debian-fixup index 0e553d47..7d9d0398

[Xen-devel] [OSSTEST PATCH 22/62] contents_make_cpio: Include symlinks

We are going to introduce some symlinks into one of our preprepared overlays. We must therefore arrange to copy them as appropriate. The syntax `-type f,l' is an extension in GNU find. If this causes trouble in the future we will then have to introduce the obvious circumlocution involving ( ).

[Xen-devel] [OSSTEST PATCH 05/62] ts-xen-install: install some packages on stretch

From: Wei Liu The "route" command is now in that package. libnl is needed when running xl. Signed-off-by: Wei Liu Acked-by: Ian Jackson --- v3: invert condition. --- ts-xen-install | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ts-xen-install b/ts-xen-install index 8de94ac2..80952857

[Xen-devel] [OSSTEST PATCH 42/62] preseed_hook_command: allow specifying di keys other than preseed/*

Ie, only add preseed/ if there is not already a slash. No functional change with existing call sites other than urls and temporary filenames. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Osstest/Debian.pm b/Osstest

[Xen-devel] [OSSTEST PATCH 18/62] Drop rumprun tests

From: Wei Liu These have been failing for some time and it doesn't any more look like this will be an attractive route to stub device models. (At least two Xen downstream projects are using Linux-based stub device models.) Signed-off-by: Wei Liu Acked-by: Ian Jackson --- v4: Expand commit mes

[Xen-devel] [OSSTEST PATCH 56/62] platforms: Pass suite to get_arch_platforms

The available platforms may depend on the suite to be used. For now we use $defsuite from make-flight, which is not entirely right but it will do for now because we don't use other suites much. No functional change yet since neither implementation uses it. Signed-off-by: Ian Jackson --- Osstes

[Xen-devel] [OSSTEST PATCH 48/62] dm restrict audit: actually install right package for fishdescriptor

In dm restrict audit: install newer chiark-scripts for fishdescriptor a locally-provided chiark-scripts_6.0.2_all.deb was installed for jessie. For stretch a backport was installed, but mistakenly of chiark-utils-bin rather than chiark-scripts. Signed-off-by: Ian Jackson --- Osstest/Debian.pm

[Xen-devel] [OSSTEST PATCH 52/62] target_install_packages: Consistently use qw(...) rather than '...'

qw(...) splits its argument into words. There is one semantic change, where two package names were passed in a single argument. That worked by accident. Signed-off-by: Ian Jackson --- ts-xen-install | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ts-xen-install b

[Xen-devel] [OSSTEST PATCH 61/62] production-config-cambridge: Provide TftpDiVersion_stretch

Signed-off-by: Ian Jackson --- production-config-cambridge | 1 + 1 file changed, 1 insertion(+) diff --git a/production-config-cambridge b/production-config-cambridge index ce6239bd..a50b19b3 100644 --- a/production-config-cambridge +++ b/production-config-cambridge @@ -77,6 +77,7 @@ TftpNetGru

[Xen-devel] [OSSTEST PATCH 54/62] ts-debian-hvm-install: Honour linux_boot_append target var

This looks for: _linux_boot_append all_guest_linux_boot_append Nothing sets these yet. Signed-off-by: Ian Jackson --- ts-debian-hvm-install | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ts-debian-hvm-install b/ts-debian-hvm-install index 54d5d1c2..ed8803ed 100755 --- a/ts-debian-hv

[Xen-devel] [OSSTEST PATCH 51/62] dm restrict audit: always install (some) chiark-scripts

In dm restrict audit: install newer chiark-scripts for fishdescriptor arrangements were made to install suitable chiark-scripts for for jessie and stretch. For buster and later, the mainline Debian version of chiark-scripts is indeed sufficient, but nothing installed it. Do that. Signed-off-by

[Xen-devel] [OSSTEST PATCH 46/62] Debian: set partman-lvm/device_remove_lvm_span

Web searching[1] suggests that this suppresses this error: !! ERROR: Unable to automatically remove LVM data Because the volume group(s) on the selected device also consist of physical volumes on other devices, it is not considered safe to remove its LVM data automatically. If you wish to

[Xen-devel] [OSSTEST PATCH 07/62] ts-leak-check: suppress systemd-shim, which leaks in stretch

From: Wei Liu Signed-off-by: Wei Liu Acked-by: Ian Jackson --- ts-leak-check | 1 + 1 file changed, 1 insertion(+) diff --git a/ts-leak-check b/ts-leak-check index 678d0696..41e6245d 100755 --- a/ts-leak-check +++ b/ts-leak-check @@ -202,6 +202,7 @@ xenstore /vm xenstore /libxl process .*

  1   2   >