Re: [Xen-devel] [PATCH for-4.12 V2] x86/altp2m: fix HVMOP_altp2m_set_domain_state race

2019-02-11 Thread Jan Beulich
>>> On 08.02.19 at 18:02, wrote: > On 2/8/19 6:44 PM, Jan Beulich wrote: > On 08.02.19 at 17:30, wrote: >>> On 2/8/19 5:50 PM, Jan Beulich wrote: >>> On 08.02.19 at 15:00, wrote: > /* If the alternate p2m state has changed, handle appropriately > */ > -if (

Re: [Xen-devel] [PATCH for-4.12 V2] x86/altp2m: fix HVMOP_altp2m_set_domain_state race

2019-02-11 Thread Razvan Cojocaru
Right, I now understand what you meant by removing "if ( ostate )" - you'd like d->arch.altp2m_active to only be set _after_ the for, for the enable, as well as for the disable case. No, certainly not. Exactly because of ... However, I wanted to keep both if()s to avoid another problem with

Re: [Xen-devel] [admin] [Pkg-xen-devel] [BUG] task jbd2/xvda4-8:174 blocked for more than 120 seconds.

2019-02-11 Thread Samuel Thibault
Hello, Dongli Zhang, le lun. 11 févr. 2019 09:37:43 +0800, a ecrit: > On 2/10/19 12:35 AM, Samuel Thibault wrote: > > Hello, > > > > Hans van Kranenburg, le sam. 09 févr. 2019 17:01:55 +0100, a ecrit: > >>> I have forwarded the original mail: all VM I/O get stuck, and thus the > >>> VM becomes un

[Xen-devel] [PATCH for-4.12 V3] x86/altp2m: fix HVMOP_altp2m_set_domain_state race

2019-02-11 Thread Razvan Cojocaru
HVMOP_altp2m_set_domain_state does not domain_pause(), presumably on purpose (as it was originally supposed to cater to a in-guest agent, and a domain pausing itself is not a good idea). This can lead to domain crashes in the vmx_vmexit_handler() code that checks if the guest has the ability to sw

Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-11 Thread Jan Beulich
>>> On 08.02.19 at 18:49, wrote: > On Thu, Feb 07, 2019 at 05:21:28PM +, George Dunlap wrote: >> On 2/5/19 1:38 PM, Roger Pau Monné wrote: >> > On Tue, Feb 05, 2019 at 05:44:14AM -0700, Jan Beulich wrote: >> >> When the assertion was introduced, MMIO wasn't handled by the >> >> code correctly

Re: [Xen-devel] [PATCH net-next] xen-netback: mark expected switch fall-through

2019-02-11 Thread Jan Beulich
>>> On 08.02.19 at 20:58, wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enabling > -Wimplicit-fallthrough. > > Signed

Re: [Xen-devel] preparations for 4.10.3 and 4.9.4

2019-02-11 Thread Jan Beulich
>>> On 09.02.19 at 18:10, wrote: > Hello, > > On Tue, Feb 05, 2019 at 11:44:09AM +, Ian Jackson wrote: >> Jan Beulich writes ("Re: [Xen-devel] preparations for 4.10.3 and 4.9.4"): >> > On 01.02.19 at 12:23, wrote: >> > > For 4.10.3: >> > > >> > > https://lists.xen.org/archives/html/xen-deve

[Xen-devel] Xen (both x86 and Arm) Community Call: Feb 13 - 16:00 - 17:00 UTC - Call for Agenda Items

2019-02-11 Thread Lars Kurth
Hi all, we have the community call for February coming up this Wednesday. My sincere apologies, that I have not asked for agenda items last week. A current agenda (primarily a skeleton) is available at https://docs.google.com/document/d/15ZLzQcH794jufDZW1oNYVY2D12CnVqxQ-klFAqkd2bU/edit#headin

Re: [Xen-devel] [PATCH for-4.12 V3] x86/altp2m: fix HVMOP_altp2m_set_domain_state race

2019-02-11 Thread Jan Beulich
>>> On 11.02.19 at 10:13, wrote: > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -2150,13 +2150,13 @@ static bool_t vmx_is_singlestep_supported(void) > return !!cpu_has_monitor_trap_flag; > } > > -static void vmx_vcpu_update_eptp(struct vcpu *v) > +static void vm

[Xen-devel] [PATCH XTF perf 1/4] categories: add perf

2019-02-11 Thread Norbert Manthey
As XTF allows to write tests that interact with the hypervisor, we would like to use this capability to implement micro benchmarks, so that we can measure the performance impact of modifications to the hypervisor. Signed-off-by: Norbert Manthey --- build/common.mk | 2 +- xtf-runner | 2 +-

[Xen-devel] XTF perf - Micro Benchmarks

2019-02-11 Thread Norbert Manthey
Dear all, I added a perf category to XTF, and added functions to measure time in the guest. Finally, I added a first micro benchmark that measures the time to call a specified hypercall, and print the average time the hypercall takes. The added category should be useful to implement further micro

[Xen-devel] [PATCH XTF perf 4/4] perf: measure MMUEXT_MARK_SUPER test

2019-02-11 Thread Norbert Manthey
A first simple test is to call a hypercall in a tight loop. To measure implementation aspects of the hypervisor, we picked a hypercall that is not implemented and hence results in a no-op, namely the hypercall mmuext_op with the command MMUEXT_MARK_SUPER. Signed-off-by: Norbert Manthey --- test

[Xen-devel] [PATCH XTF perf 2/4] time: add stubs

2019-02-11 Thread Norbert Manthey
To measure how long a certain interaction takes, we need time primitives. This commit introduces these primitives, so that future tests can use the gettimeofday function to retrieve the current time. Signed-off-by: Paul Semel Signed-off-by: Norbert Manthey --- build/files.mk | 1 + commo

[Xen-devel] [PATCH XTF perf 3/4] time: provide measurement template

2019-02-11 Thread Norbert Manthey
The added function measure_performance allows to measure the run time of a function, by computing the average time it takes to call that function a given number of retries. The measured total time is returned in nano seconds. Furthermore, the value is printed via printk in a fixed format, to allow

Re: [Xen-devel] 4.10.1 Xen crash and reboot

2019-02-11 Thread Patrick Beckmann
Hi, Am 07.01.2019 um 12:12 schrieb Patrick Beckmann: > I just joined this list and am referring to > https://lists.xenproject.org/archives/html/xen-devel/2018-12/msg00938.html > > We have experienced several crashes of a recent Debian 9 Dom0 on new > hardware with Xen version "4.8.4+xsa273+shim

Re: [Xen-devel] [PATCH for-4.12 V3] x86/altp2m: fix HVMOP_altp2m_set_domain_state race

2019-02-11 Thread Razvan Cojocaru
On 2/11/19 12:10 PM, Jan Beulich wrote: On 11.02.19 at 10:13, wrote: --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2150,13 +2150,13 @@ static bool_t vmx_is_singlestep_supported(void) return !!cpu_has_monitor_trap_flag; } -static void vmx_vcpu_update_eptp(struc

[Xen-devel] arm64, laxton[01] (was Re: [xen-unstable-smoke test] 133030: trouble: blocked/broken/pass)

2019-02-11 Thread Ian Jackson
On Fri, Feb 08, 2019 at 01:14:16PM +, Wei Liu wrote: > On Fri, Feb 08, 2019 at 05:21:44AM +, osstest service owner wrote: > > flight 133030 xen-unstable-smoke real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/133030/ > > > > Failures and problems with tests :-( Thanks for l

Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-11 Thread Roger Pau Monné
On Mon, Feb 11, 2019 at 02:47:48AM -0700, Jan Beulich wrote: > >>> On 08.02.19 at 18:49, wrote: > > On Thu, Feb 07, 2019 at 05:21:28PM +, George Dunlap wrote: > >> On 2/5/19 1:38 PM, Roger Pau Monné wrote: > >> > On Tue, Feb 05, 2019 at 05:44:14AM -0700, Jan Beulich wrote: > >> >> When the ass

Re: [Xen-devel] [PATCH v2 1/2] x86: respect memory size limiting via mem= parameter

2019-02-11 Thread Ingo Molnar
* Juergen Gross wrote: > When limiting memory size via kernel parameter "mem=" this should be > respected even in case of memory made accessible via a PCI card. > > Today this kind of memory won't be made usable in initial memory > setup as the memory won't be visible in E820 map, but it might

Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-11 Thread Jan Beulich
>>> On 11.02.19 at 13:03, wrote: > On Mon, Feb 11, 2019 at 02:47:48AM -0700, Jan Beulich wrote: >> >>> On 08.02.19 at 18:49, wrote: >> > On Thu, Feb 07, 2019 at 05:21:28PM +, George Dunlap wrote: >> >> On 2/5/19 1:38 PM, Roger Pau Monné wrote: >> >> > On Tue, Feb 05, 2019 at 05:44:14AM -0700,

Re: [Xen-devel] [PATCH v2 1/2] x86: respect memory size limiting via mem= parameter

2019-02-11 Thread Juergen Gross
On 11/02/2019 13:06, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> When limiting memory size via kernel parameter "mem=" this should be >> respected even in case of memory made accessible via a PCI card. >> >> Today this kind of memory won't be made usable in initial memory >> setup as the

Re: [Xen-devel] [PATCH v2 1/2] x86: respect memory size limiting via mem= parameter

2019-02-11 Thread Ingo Molnar
* Juergen Gross wrote: > > If PCI devices had physical mmio memory areas above this range, we'd > > still expect them to work - the option was really only meant to limit > > RAM. > > No, in this case it seems to be real RAM added via PCI. The RAM is > initially present in the E820 map, but t

Re: [Xen-devel] [RFC PATCH 2/6] tools/libxc: Define VM_EVENT type

2019-02-11 Thread Petre Ovidiu PIRCALABU
On Tue, 2019-01-08 at 09:25 -0700, Jan Beulich wrote: > > > > On 19.12.18 at 19:52, wrote: > > > > @@ -796,7 +787,7 @@ struct xen_domctl_gdbsx_domstatus { > > * EXDEV - guest has PoD enabled > > * EBUSY - guest has or had paging enabled, ring buffer still > > active > > */ > > -#define XE

Re: [Xen-devel] [PATCH v2 1/2] x86: respect memory size limiting via mem= parameter

2019-02-11 Thread Juergen Gross
On 11/02/2019 13:23, Ingo Molnar wrote: > > * Juergen Gross wrote: > >>> If PCI devices had physical mmio memory areas above this range, we'd >>> still expect them to work - the option was really only meant to limit >>> RAM. >> >> No, in this case it seems to be real RAM added via PCI. The RAM

[Xen-devel] [linux-4.19 test] 132990: regressions - trouble: blocked/broken/fail/pass

2019-02-11 Thread osstest service owner
flight 132990 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/132990/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-pvops

[Xen-devel] [linux-4.9 test] 133027: trouble: blocked/broken/fail/pass

2019-02-11 Thread osstest service owner
flight 133027 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/133027/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-arm64

Re: [Xen-devel] [PATCH Makefile v2] asm: handle comments when creating header file

2019-02-11 Thread Norbert Manthey
On 2/6/19 16:10, Jan Beulich wrote: On 06.02.19 at 15:09, wrote: >> From: Norbert Manthey >> >> In the early steps of compilation, the asm header files are created, such >> as include/asm-$(TARGET_ARCH)/asm-offsets.h. These files depend on the >> assembly file arch/$(TARGET_ARCH)/asm-offsets

[Xen-devel] [libvirt test] 133093: trouble: blocked/broken/pass

2019-02-11 Thread osstest service owner
flight 133093 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/133093/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-xsm

[Xen-devel] [xen-unstable-smoke test] 133134: regressions - trouble: blocked/broken/fail/pass

2019-02-11 Thread osstest service owner
flight 133134 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/133134/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-armhf 6 xen

Re: [Xen-devel] Xen-unstable PVHdom0: Assertion 'IS_ALIGNED(dfn_x(dfn), (1ul << page_order))' failed at iommu.c:324

2019-02-11 Thread Roger Pau Monné
On Fri, Feb 08, 2019 at 08:36:54PM +0100, Sander Eikelenboom wrote: > On 08/02/2019 17:47, Roger Pau Monné wrote: > > On Fri, Feb 08, 2019 at 05:15:22PM +0100, Sander Eikelenboom wrote: > >> On 08/02/2019 16:10, Roger Pau Monné wrote: > >>> On Fri, Jan 25, 2019 at 07:44:40PM +0100, Sander Eikelenbo

Re: [Xen-devel] [PATCH v5 3/8] microcode: introduce the global microcode cache

2019-02-11 Thread Jan Beulich
>>> On 11.02.19 at 04:59, wrote: > On Fri, Feb 08, 2019 at 04:41:19AM -0700, Jan Beulich wrote: > On 28.01.19 at 08:06, wrote: >>> @@ -208,6 +210,58 @@ static void microcode_fini_cpu(unsigned int cpu) >>> spin_unlock(µcode_mutex); >>> } >>> >>> +/* Save a ucode patch to the global cac

Re: [Xen-devel] [PATCH v5 7/8] x86/microcode: Synchronize late microcode loading

2019-02-11 Thread Jan Beulich
>>> On 11.02.19 at 06:40, wrote: > On Fri, Feb 08, 2019 at 09:29:32AM -0700, Jan Beulich wrote: > On 28.01.19 at 08:06, wrote: >>> +/* >>> + * Initiate an update on all processors which don't have an online >>> sibling >>> + * thread with a lower thread id. Other sibling threads

[Xen-devel] [linux-linus test] 133106: regressions - trouble: blocked/broken/fail/pass

2019-02-11 Thread osstest service owner
flight 133106 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/133106/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-arm64-pvops

[Xen-devel] [ovmf test] 133126: all pass - PUSHED

2019-02-11 Thread osstest service owner
flight 133126 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/133126/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 2a784a2cc356df5a8958afe88bc7e844dc0fb7cc baseline version: ovmf 7a90895306acbf970de87

Re: [Xen-devel] [PATCH v5 7/8] x86/microcode: Synchronize late microcode loading

2019-02-11 Thread Juergen Gross
On 11/02/2019 14:23, Jan Beulich wrote: On 11.02.19 at 06:40, wrote: >> On Fri, Feb 08, 2019 at 09:29:32AM -0700, Jan Beulich wrote: >> On 28.01.19 at 08:06, wrote: +/* + * Initiate an update on all processors which don't have an online sibling + * thread

[Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-xl-shadow

2019-02-11 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-shadow testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.gi

Re: [Xen-devel] [PATCH for-4.12 V3] x86/altp2m: fix HVMOP_altp2m_set_domain_state race

2019-02-11 Thread Razvan Cojocaru
On 2/11/19 12:57 PM, Razvan Cojocaru wrote: On 2/11/19 12:10 PM, Jan Beulich wrote: On 11.02.19 at 10:13, wrote: --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2150,13 +2150,13 @@ static bool_t vmx_is_singlestep_supported(void)   return !!cpu_has_monitor_trap_flag;  

[Xen-devel] [xen-unstable test] 133111: trouble: blocked/broken/fail/pass

2019-02-11 Thread osstest service owner
flight 133111 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/133111/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken build-arm64-xsm

Re: [Xen-devel] [PATCH Makefile v2] asm: handle comments when creating header file

2019-02-11 Thread Juergen Gross
On 11/02/2019 14:07, Norbert Manthey wrote: > On 2/6/19 16:10, Jan Beulich wrote: > On 06.02.19 at 15:09, wrote: >>> From: Norbert Manthey >>> >>> In the early steps of compilation, the asm header files are created, such >>> as include/asm-$(TARGET_ARCH)/asm-offsets.h. These files depend on t

[Xen-devel] [linux-4.14 test] 133114: trouble: blocked/broken/fail/pass

2019-02-11 Thread osstest service owner
flight 133114 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/133114/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-xsm

Re: [Xen-devel] [PATCH v5 7/8] x86/microcode: Synchronize late microcode loading

2019-02-11 Thread Raj, Ashok
On Mon, Feb 11, 2019 at 02:35:30PM +0100, Juergen Gross wrote: > On 11/02/2019 14:23, Jan Beulich wrote: > On 11.02.19 at 06:40, wrote: > >> On Fri, Feb 08, 2019 at 09:29:32AM -0700, Jan Beulich wrote: > >> On 28.01.19 at 08:06, wrote: > +/* > + * Initiate an update on

[Xen-devel] [xen-unstable-smoke test] 133149: trouble: blocked/broken/pass

2019-02-11 Thread osstest service owner
flight 133149 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/133149/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken Regressions wh

Re: [Xen-devel] [PATCH v5 7/8] x86/microcode: Synchronize late microcode loading

2019-02-11 Thread Jan Beulich
>>> On 11.02.19 at 14:35, wrote: > On 11/02/2019 14:23, Jan Beulich wrote: > On 11.02.19 at 06:40, wrote: >>> On Fri, Feb 08, 2019 at 09:29:32AM -0700, Jan Beulich wrote: >>> On 28.01.19 at 08:06, wrote: > +/* > + * Initiate an update on all processors which don't have an

Re: [Xen-devel] Xen-unstable PVHdom0: Assertion 'IS_ALIGNED(dfn_x(dfn), (1ul << page_order))' failed at iommu.c:324

2019-02-11 Thread Sander Eikelenboom
On 11/02/2019 14:16, Roger Pau Monné wrote: > On Fri, Feb 08, 2019 at 08:36:54PM +0100, Sander Eikelenboom wrote: >> On 08/02/2019 17:47, Roger Pau Monné wrote: >>> On Fri, Feb 08, 2019 at 05:15:22PM +0100, Sander Eikelenboom wrote: On 08/02/2019 16:10, Roger Pau Monné wrote: > On Fri, Jan

Re: [Xen-devel] [PATCH for-4.12 V3] x86/altp2m: fix HVMOP_altp2m_set_domain_state race

2019-02-11 Thread Jan Beulich
>>> On 11.02.19 at 14:46, wrote: > On 2/11/19 12:57 PM, Razvan Cojocaru wrote: >> On 2/11/19 12:10 PM, Jan Beulich wrote: >> On 11.02.19 at 10:13, wrote: --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2150,13 +2150,13 @@ static bool_t vmx_is_singlestep_su

Re: [Xen-devel] [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-02-11 Thread Souptick Joarder
On Fri, Feb 8, 2019 at 10:52 AM Souptick Joarder wrote: > > On Thu, Feb 7, 2019 at 10:17 PM Matthew Wilcox wrote: > > > > On Thu, Feb 07, 2019 at 09:19:47PM +0530, Souptick Joarder wrote: > > > Just thought to take opinion for documentation before placing it in v3. > > > Does it looks fine ? > >

Re: [Xen-devel] [PATCH for-4.12 V3] x86/altp2m: fix HVMOP_altp2m_set_domain_state race

2019-02-11 Thread Razvan Cojocaru
On 2/11/19 6:59 PM, Jan Beulich wrote: >>> Thanks for noticing, actually this appears to invalidate the whole >>> purpose of the patch (I should have tested this more before sumbitting >>> V3, sorry). >>> >>> The whole point of the new boolean is to have p2m assigned an altp2m >>> regardless of

[Xen-devel] [PATCH for-4.12 v2 0/7] pvh/dom0/shadow/amd fixes

2019-02-11 Thread Roger Pau Monne
Hello, The following series contains fixes that should be considered for 4.12. I'm not sure whether patches 5, 6 and 7 should be aimed at 4.12, they contain changes to the p2m code that could affect HVM guests. Note that without those changes a PVH dom0 running on AMD hardware will be unable to c

[Xen-devel] [PATCH for-4.12 v2 1/7] dom0/pvh: align allocation and mapping order to start address

2019-02-11 Thread Roger Pau Monne
The p2m and iommu mapping code always had the requirement that addresses and orders must be aligned when populating the p2m or the iommu page tables. PVH dom0 builder didn't take this requirement into account, and can call into the p2m/iommu mapping helpers with addresses and orders that are not a

[Xen-devel] [PATCH v2 6/7] x86/mm: handle foreign mappings in p2m_entry_modify

2019-02-11 Thread Roger Pau Monne
So that the specific handling can be removed from atomic_write_ept_entry and be shared with npt and shadow code. This commit also removes the check that prevent non-ept PVH dom0 from mapping foreign pages. Signed-off-by: Roger Pau Monné --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper

[Xen-devel] [PATCH for-4.12 v2 4/7] pvh/dom0: warn when dom0_mem is not set

2019-02-11 Thread Roger Pau Monne
There have been several reports of the dom0 builder running out of memory when building a PVH dom0 without having specified a dom0_mem value. Print a warning message if dom0_mem is not set when booting in PVH mode. This is a temporary workaround until accounting for internal memory required by Xen

[Xen-devel] [PATCH v2 7/7] npt/shadow: allow getting foreign page table entries

2019-02-11 Thread Roger Pau Monne
Current npt and shadow code to get an entry will always return INVALID_MFN for foreign entries. Allow to return the entry mfn for foreign entries, like it's done for grant table entries. Signed-off-by: Roger Pau Monné --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu --- xe

[Xen-devel] [PATCH for-4.12 v2 2/7] amd/npt/shadow: replace assert that prevents creating 2M/1G MMIO entries

2019-02-11 Thread Roger Pau Monne
The assert was originally added to make sure that higher order regions (> PAGE_ORDER_4K) could not be used to bypass the mmio_ro_ranges check performed by p2m_type_to_flags. This however is already checked in set_mmio_p2m_entry, which makes sure that higher order mappings don't overlap with mmio_r

[Xen-devel] [PATCH for-4.12 v2 3/7] x86/pvh: reorder PVH dom0 iommu initialization

2019-02-11 Thread Roger Pau Monne
So that the iommu is initialized before populating the p2m, and entries added get the corresponding iommu page table entries if required. This requires splitting the current pvh_setup_p2m into two different functions. One that crafts dom0 physmap and sets the paging allocation, and another one that

[Xen-devel] [PATCH v2 5/7] x86/mm: split p2m ioreq server pages special handling into helper

2019-02-11 Thread Roger Pau Monne
So that it can be shared by both ept, npt and shadow code, instead of duplicating it. No change in functionality intended. Signed-off-by: Roger Pau Monné --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu Cc: Jun Nakajima Cc: Kevin Tian Cc: Paul Durrant --- Changes since

[Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-xl-qemuu-ovmf-amd64

2019-02-11 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-qemuu-ovmf-amd64 testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-trad

[Xen-devel] [qemu-mainline test] 133127: trouble: blocked/broken/fail/pass

2019-02-11 Thread osstest service owner
flight 133127 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/133127/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken build-arm64-xsm

[Xen-devel] [linux-4.4 test] 133129: regressions - trouble: blocked/broken/fail/pass

2019-02-11 Thread osstest service owner
flight 133129 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/133129/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-arm64-xsm

[Xen-devel] [xen-unstable-smoke test] 133154: trouble: blocked/broken/pass

2019-02-11 Thread osstest service owner
flight 133154 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/133154/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken Regressions wh

Re: [Xen-devel] [PATCH for-4.12 v2 0/7] pvh/dom0/shadow/amd fixes

2019-02-11 Thread Sander Eikelenboom
On 11/02/2019 18:46, Roger Pau Monne wrote: > Hello, > > The following series contains fixes that should be considered for 4.12. > > I'm not sure whether patches 5, 6 and 7 should be aimed at 4.12, they > contain changes to the p2m code that could affect HVM guests. Note that > without those chan

Re: [Xen-devel] [admin] [Pkg-xen-devel] [BUG] task jbd2/xvda4-8:174 blocked for more than 120 seconds.

2019-02-11 Thread Hans van Kranenburg
On 2/11/19 2:37 AM, Dongli Zhang wrote: > > On 2/10/19 12:35 AM, Samuel Thibault wrote: >> >> Hans van Kranenburg, le sam. 09 févr. 2019 17:01:55 +0100, a ecrit: I have forwarded the original mail: all VM I/O get stuck, and thus the VM becomes unusable. >>> >>> These are in many cases th

Re: [Xen-devel] [admin] [Pkg-xen-devel] [BUG] task jbd2/xvda4-8:174 blocked for more than 120 seconds.

2019-02-11 Thread Samuel Thibault
Hans van Kranenburg, le lun. 11 févr. 2019 22:59:11 +0100, a ecrit: > On 2/11/19 2:37 AM, Dongli Zhang wrote: > > > > On 2/10/19 12:35 AM, Samuel Thibault wrote: > >> > >> Hans van Kranenburg, le sam. 09 févr. 2019 17:01:55 +0100, a ecrit: > I have forwarded the original mail: all VM I/O get

[Xen-devel] [xen-unstable-smoke test] 133161: trouble: blocked/broken/pass

2019-02-11 Thread osstest service owner
flight 133161 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/133161/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken Regressions wh

[Xen-devel] [freebsd-master test] 133137: all pass - PUSHED

2019-02-11 Thread osstest service owner
flight 133137 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/133137/ Perfect :-) All tests in this flight passed as required version targeted for testing: freebsd 9e141fd88fe790e076980d25cc8373b9c880efb8 baseline version: freebsd 50ac923f6c3

[Xen-devel] [xen-unstable-smoke test] 133170: trouble: blocked/broken/pass

2019-02-11 Thread osstest service owner
flight 133170 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/133170/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken Regressions wh

[Xen-devel] [PATCH v9 0/5] misc safety certification fixes

2019-02-11 Thread Stefano Stabellini
Hi all, This version of the series introduces two macros to compare and subtract linker symbols. Note that it has been suggested on the list to add type checking inside the macros, but that is not done in this version of the series. Cheers, Stefano The following changes since commit 808cff4c2a

[Xen-devel] [PATCH v9 1/5] xen: introduce ptrdiff_t, fix uintptr_t

2019-02-11 Thread Stefano Stabellini
uintptr_t should be "unsigned long" -- same size as a pointer. Introduce the new type "ptrdiff_t" which is defined as the signed integer type of the result of subtracting two pointers. Signed-off-by: Stefano Stabellini CC: jbeul...@suse.com CC: andrew.coop...@citrix.com CC: julien.gr...@arm.com

[Xen-devel] [PATCH v9 4/5] xen/x86: use SYMBOLS_SUBTRACT and SYMBOLS_COMPARE as required

2019-02-11 Thread Stefano Stabellini
Use SYMBOLS_SUBTRACT and SYMBOLS_COMPARE in cases of comparisons and subtractions of: _start, _end, __2M_rwdata_start, __2M_rwdata_end, _stext, _etext, __end_vpci_array, __start_vpci_array, _stextentry, _etextentry, __trampoline_rel_start, __trampoline_rel_stop, __trampoline_seg_start, __trampolin

[Xen-devel] [PATCH v9 2/5] xen: introduce SYMBOLS_SUBTRACT and SYMBOLS_COMPARE

2019-02-11 Thread Stefano Stabellini
Introduce two macros meant used everywhere symbols such as _stext and _etext are compared or subtracted in the code. They are needed because the C standard forbids for both comparisons and substraction (see C Standard, 6.5.6 [ISO/IEC 9899:2011] and [1]) between pointers pointing to different objec

[Xen-devel] [PATCH v9 3/5] xen/arm: use SYMBOLS_SUBTRACT and SYMBOLS_COMPARE as required

2019-02-11 Thread Stefano Stabellini
Use SYMBOLS_SUBTRACT and SYMBOLS_COMPARE in cases of comparisons and subtractions of: _start, _end, __init_begin, __init_end, _stext, _etext, __alt_instructions, __alt_instructions_end, __per_cpu_start, __per_cpu_data_end, _splatform, _eplatform, _sdevice, _edevice, _asdevice, _aedevice. as by th

[Xen-devel] [PATCH v9 5/5] xen/common: use SYMBOLS_SUBTRACT and SYMBOLS_COMPARE as required

2019-02-11 Thread Stefano Stabellini
Use SYMBOLS_SUBTRACT and SYMBOLS_COMPARE in cases of comparisons and subtractions of: _start, _end, _stext, _etext, _srodata, _erodata, _sinittext, _einittext, __note_gnu_build_id_start, __note_gnu_build_id_end, __lock_profile_start, __lock_profile_end, __initcall_start, __initcall_end, __presmp_i

[Xen-devel] [xen-unstable-smoke test] 133173: trouble: blocked/broken/pass

2019-02-11 Thread osstest service owner
flight 133173 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/133173/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken Regressions wh

Re: [Xen-devel] [admin] [Pkg-xen-devel] [BUG] task jbd2/xvda4-8:174 blocked for more than 120 seconds.

2019-02-11 Thread Dongli Zhang
On 02/12/2019 06:10 AM, Samuel Thibault wrote: > Hans van Kranenburg, le lun. 11 févr. 2019 22:59:11 +0100, a ecrit: >> On 2/11/19 2:37 AM, Dongli Zhang wrote: >>> >>> On 2/10/19 12:35 AM, Samuel Thibault wrote: Hans van Kranenburg, le sam. 09 févr. 2019 17:01:55 +0100, a ecrit: >>

[Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-amd64-pvgrub

2019-02-11 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-amd64-pvgrub testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional

[Xen-devel] [xen-unstable-smoke test] 133178: trouble: blocked/broken/pass

2019-02-11 Thread osstest service owner
flight 133178 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/133178/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken Regressions wh

Re: [Xen-devel] [PATCH] VMX: don't ignore P2M setup error

2019-02-11 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Wednesday, February 6, 2019 6:24 PM > > set_mmio_p2m_entry() may fail, in particular with -ENOMEM. Don't ignore > such an error, but instead cause domain creation to fail in such a case. > > Signed-off-by: Jan Beulich Acked-by: Kevin Tian

Re: [Xen-devel] [PATCH for-4.12 v2] xen/iommu: fix iommu_ops initialization

2019-02-11 Thread Tian, Kevin
> From: Juergen Gross [mailto:jgr...@suse.com] > Sent: Saturday, February 2, 2019 12:30 AM > > Commit 32a5ea00ec75ef53e ("IOMMU/x86: remove indirection from > certain > IOMMU hook accesses") introduced iommu_ops initialized at boot time > with data declared as __initconstrel. > > On Intel systems

[Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-pair

2019-02-11 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-pair testid xen-boot/dst_host Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditiona

[Xen-devel] [linux-3.18 bisection] complete test-amd64-amd64-pair

2019-02-11 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-pair testid xen-boot/src_host Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditiona

Re: [Xen-devel] [PATCH for-4.12 V3] x86/altp2m: fix HVMOP_altp2m_set_domain_state race

2019-02-11 Thread Jan Beulich
>>> On 11.02.19 at 18:21, wrote: > On 2/11/19 6:59 PM, Jan Beulich wrote: Thanks for noticing, actually this appears to invalidate the whole purpose of the patch (I should have tested this more before sumbitting V3, sorry). The whole point of the new boolean is to have p