Re: [Xen-devel] [PATCH v8 for-4.12 00/17] Argo: hypervisor-mediated interdomain communication

2019-02-07 Thread Rich Persaud
On Feb 6, 2019, at 08:57, Jan Beulich wrote: On 06.02.19 at 14:53, wrote: >> On 06/02/2019 14:45, Jan Beulich wrote: >> On 06.02.19 at 09:54, wrote: Version eight of this series: Note: This version may not address the currently open discussion on the ARM hypercall

[Xen-devel] [seabios baseline-only test] 83604: tolerable FAIL

2019-02-07 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 83604 seabios real [real] http://osstest.xensource.com/osstest/logs/83604/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win10-i386 10 windows-install fail baseline untested t

Re: [Xen-devel] [PATCH v8 for-4.12 10/17] argo: implement the notify op

2019-02-07 Thread Julien Grall
Hi, On 2/7/19 6:32 AM, Christopher Clark wrote: On Wed, Feb 6, 2019 at 10:28 AM Julien Grall wrote: Hi, On 2/6/19 8:55 AM, Christopher Clark wrote: +/* + * XEN_ARGO_OP_notify + * + * Asks Xen for information about other rings in the system. + * + * ent->ring is the xen_argo_addr_t of the ri

Re: [Xen-devel] [PATCH v7 02/15] argo: introduce the argo_op hypercall boilerplate

2019-02-07 Thread Julien Grall
Hi Stefano, On 2/6/19 7:35 PM, Stefano Stabellini wrote: On Wed, 6 Feb 2019, Julien Grall wrote: However, I think we should add some sanity check in arch_set_info_guest for our peace of mind. For guest entry/exit, rather than zero the upper 32-bits I would also add sanity check in enter_hypervi

Re: [Xen-devel] [PATCH v8 for-4.12 10/17] argo: implement the notify op

2019-02-07 Thread Rich Persaud
On Feb 7, 2019, at 04:04, Julien Grall wrote: > > Hi, > >> On 2/7/19 6:32 AM, Christopher Clark wrote: >>> On Wed, Feb 6, 2019 at 10:28 AM Julien Grall wrote: >>> >>> Hi, >>> On 2/6/19 8:55 AM, Christopher Clark wrote: +/* + * XEN_ARGO_OP_notify + * + * Asks Xen for i

Re: [Xen-devel] [PATCH v8 for-4.12 00/17] Argo: hypervisor-mediated interdomain communication

2019-02-07 Thread Julien Grall
Hi, On 2/7/19 8:19 AM, Rich Persaud wrote: If necessary to unblock the merge of Argo to Xen 4.12, we can limit/constrain Arm support via SUPPORT.md. This version can go as it is for Arm without any limit/constrain via SUPPORT.md. Cheers, -- Julien Grall __

Re: [Xen-devel] [PATCH for-4.12] xen/arm: gic-v2: deactivate interrupts during initialization

2019-02-07 Thread Julien Grall
On 2/5/19 9:38 PM, Stefano Stabellini wrote: Interrupts could be ACTIVE at boot. Make sure to deactivate them during initialization. Signed-off-by: Stefano Stabellini CC: julien.gr...@arm.com CC: peng@nxp.com CC: jgr...@suse.com Reviewed-by: Julien Grall --- xen/arch/arm/gic-v2.c |

Re: [Xen-devel] [PATCH for-4.12] xen/arm: gic-v2: deactivate interrupts during initialization

2019-02-07 Thread Juergen Gross
On 05/02/2019 22:38, Stefano Stabellini wrote: > Interrupts could be ACTIVE at boot. Make sure to deactivate them during > initialization. > > Signed-off-by: Stefano Stabellini Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-

Re: [Xen-devel] RT Xen on ARM - R-Car series

2019-02-07 Thread Andrii Anisov
Hello All, On 06.02.19 23:03, Stefano Stabellini wrote: That's great. Could you or Roger take care of cleaning up the patch and properly submitting it to the list? I can take it for cleaning up. And also double check that it won't break any guests (at least the ones we know about: Linux and

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 8/9] common/grant_table: block speculative out-of-bound accesses

2019-02-07 Thread Norbert Manthey
On 2/6/19 16:53, Jan Beulich wrote: On 06.02.19 at 16:06, wrote: >> On 2/6/19 15:52, Jan Beulich wrote: >> On 29.01.19 at 15:43, wrote: @@ -963,6 +965,9 @@ map_grant_ref( PIN_FAIL(unlock_out, GNTST_bad_gntref, "Bad ref %#x for d%d\n", op->ref, rg

Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-07 Thread Roger Pau Monné
On Thu, Feb 07, 2019 at 01:07:47AM +0100, Marek Marczykowski-Górecki wrote: > From: Simon Gaiser > > Stubdomains need to be given sufficient privilege over the guest which it > provides emulation for in order for PCI passthrough to work correctly. > When a HVM domain try to enable MSI, QEMU in st

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 6/9] is_control_domain: block speculation

2019-02-07 Thread Norbert Manthey
On 2/6/19 17:01, Jan Beulich wrote: On 06.02.19 at 16:36, wrote: >> On 2/6/19 16:03, Jan Beulich wrote: >> On 29.01.19 at 15:43, wrote: @@ -908,10 +909,10 @@ void watchdog_domain_destroy(struct domain *d); *(that is, this would not be suitable for a driver domain)

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 8/9] common/grant_table: block speculative out-of-bound accesses

2019-02-07 Thread Norbert Manthey
On 2/7/19 10:50, Norbert Manthey wrote: > On 2/6/19 16:53, Jan Beulich wrote: > On 06.02.19 at 16:06, wrote: >>> On 2/6/19 15:52, Jan Beulich wrote: >>> On 29.01.19 at 15:43, wrote: > @@ -963,6 +965,9 @@ map_grant_ref( > PIN_FAIL(unlock_out, GNTST_bad_gntref, "Bad ref %#

Re: [Xen-devel] [PATCH v4 5/6] xen/x86: add PHYSDEVOP_msi_set_enable

2019-02-07 Thread Roger Pau Monné
On Thu, Feb 07, 2019 at 01:07:48AM +0100, Marek Marczykowski-Górecki wrote: > Allow device model running in stubdomain to enable/disable MSI(-X), > bypassing pciback. While pciback is still used to access config space > from within stubdomain, it refuse to write to > PCI_MSI_FLAGS_ENABLE/PCI_MSIX_F

Re: [Xen-devel] RT Xen on ARM - R-Car series

2019-02-07 Thread Roger Pau Monné
On Thu, Feb 07, 2019 at 11:42:16AM +0200, Andrii Anisov wrote: > Hello All, > > On 06.02.19 23:03, Stefano Stabellini wrote: > > That's great. Could you or Roger take care of cleaning up the patch and > > properly submitting it to the list? > > I can take it for cleaning up. > > > And also doubl

Re: [Xen-devel] RT Xen on ARM - R-Car series

2019-02-07 Thread Andrii Anisov
On 05.02.19 21:18, Stefano Stabellini wrote: I think it is acceptable to intruduce a "I know what I am doing, just disable the fix" option. There might be cases where the user doesn't care for Spectre mitigations. I see that Linux is going in this direction of offering more disabling options to

Re: [Xen-devel] RT Xen on ARM - R-Car series

2019-02-07 Thread Julien Grall
(sorry for the formatting) On Thu, 7 Feb 2019, 11:37 Roger Pau Monné, wrote: > On Thu, Feb 07, 2019 at 11:42:16AM +0200, Andrii Anisov wrote: > > Hello All, > > > > On 06.02.19 23:03, Stefano Stabellini wrote: > > > That's great. Could you or Roger take care of cleaning up the patch and > > > pr

[Xen-devel] [linux-next test] 132957: regressions - FAIL

2019-02-07 Thread osstest service owner
flight 132957 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/132957/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 132911 test-armhf-armhf-lib

[Xen-devel] [PATCH v2] x86emul: avoid speculative out of bounds accesses

2019-02-07 Thread Jan Beulich
There are a few array accesses here the indexes of which are (at least indirectly) driven by the guest. Use array_access_nospec() to bound such accesses. In the {,_}decode_gpr() cases replace existing guarding constructs. To deal with an otherwise occurring #include cycle, drop the inclusion of as

[Xen-devel] [PATCH v2] x86/shadow: adjust minimum allocation calculations

2019-02-07 Thread Jan Beulich
A previously bad situation has become worse with the early setting of ->max_vcpus: The value returned by shadow_min_acceptable_pages() has further grown, and hence now holds back even more memory from use for the p2m. Make sh_min_allocation() account for all p2m memory needed for shadow_enable() t

Re: [Xen-devel] [PATCH RFC 0/6] Slotted channels for sync vm_events

2019-02-07 Thread George Dunlap
On 2/6/19 2:26 PM, Petre Ovidiu PIRCALABU wrote: > On Wed, 2018-12-19 at 20:52 +0200, Petre Pircalabu wrote: >> This patchset is a rework of the "multi-page ring buffer" for >> vm_events >> patch based on Andrew Cooper's comments. >> For synchronous vm_events the ring waitqueue logic was unnecessar

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-02-07 Thread Ian Jackson
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL"): > I am OK with this approach. Maybe not the best IMO, but good enough. It > should also satisfy the MISRAC guys, as they wrote "ideally cast to > uintptr_t only once": here we wouldn't be casting only once, but at

[Xen-devel] [PATCH] docs: Update credit/credit2 feature docs reflecting new default scheduler

2019-02-07 Thread George Dunlap
Signed-off-by: George Dunlap --- Release justification: - "Bug" in docs (credit1 is no longer default) - No functional change CC: Andrew Cooper CC: Ian Jackson CC: Jan Beulich CC: Julien Grall CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei Liu CC: Juergen Gross

[Xen-devel] [xen-4.10-testing test] 132966: tolerable FAIL - PUSHED

2019-02-07 Thread osstest service owner
flight 132966 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/132966/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail like 132922 test-amd64-amd64-xl-qemuu-dmrest

Re: [Xen-devel] [PATCH] docs: Update credit/credit2 feature docs reflecting new default scheduler

2019-02-07 Thread Jan Beulich
>>> On 07.02.19 at 13:08, wrote: > Signed-off-by: George Dunlap Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2] x86/shadow: adjust minimum allocation calculations

2019-02-07 Thread Juergen Gross
On 07/02/2019 12:41, Jan Beulich wrote: > A previously bad situation has become worse with the early setting of > ->max_vcpus: The value returned by shadow_min_acceptable_pages() has > further grown, and hence now holds back even more memory from use for > the p2m. > > Make sh_min_allocation() acc

Re: [Xen-devel] [PATCH v2] x86emul: avoid speculative out of bounds accesses

2019-02-07 Thread Juergen Gross
On 07/02/2019 12:42, Jan Beulich wrote: > There are a few array accesses here the indexes of which are (at least > indirectly) driven by the guest. Use array_access_nospec() to bound > such accesses. In the {,_}decode_gpr() cases replace existing guarding > constructs. > > To deal with an otherwis

Re: [Xen-devel] [PATCH] docs: Update credit/credit2 feature docs reflecting new default scheduler

2019-02-07 Thread Juergen Gross
On 07/02/2019 13:08, George Dunlap wrote: > Signed-off-by: George Dunlap Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/pv: Fix construction of 32bit dom0's

2019-02-07 Thread Jan Beulich
>>> On 06.02.19 at 21:41, wrote: > Slightly RFC: > > 1) I've not worked out exactly what the > > v->vcpu_info = (void *)&d->shared_info->compat.vcpu_info[0]; > >line is supposed to be doing and whether it is needed, but it doesn't >appear to matter. It is perhaps another redundant

Re: [Xen-devel] [PATCH v8 for-4.12 10/17] argo: implement the notify op

2019-02-07 Thread Jan Beulich
>>> On 07.02.19 at 10:04, wrote: > On 2/7/19 6:32 AM, Christopher Clark wrote: >> It uses that null test because both are XEN_GUEST_HANDLE_PARAM type in >> the function signature: >> >> long do_argo_op( >> unsigned int cmd, >> XEN_GUEST_HANDLE_PARAM(void) arg1, >> XEN_GUEST_HANDLE_

Re: [Xen-devel] [PATCH v8 for-4.12 10/17] argo: implement the notify op

2019-02-07 Thread Jan Beulich
>>> On 07.02.19 at 10:15, wrote: > On Feb 7, 2019, at 04:04, Julien Grall wrote: >>> On 2/7/19 6:32 AM, Christopher Clark wrote: >>> It uses that null test because both are XEN_GUEST_HANDLE_PARAM type in >>> the function signature: >>> long do_argo_op( >>> unsigned int cmd, >>> XEN_GUEST_

Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-07 Thread Marek Marczykowski-Górecki
On Thu, Feb 07, 2019 at 10:57:19AM +0100, Roger Pau Monné wrote: > On Thu, Feb 07, 2019 at 01:07:47AM +0100, Marek Marczykowski-Górecki wrote: > > From: Simon Gaiser > > > > Stubdomains need to be given sufficient privilege over the guest which it > > provides emulation for in order for PCI passt

Re: [Xen-devel] [PATCH] x86/pv: Fix construction of 32bit dom0's

2019-02-07 Thread Andrew Cooper
On 07/02/2019 12:58, Jan Beulich wrote: On 06.02.19 at 21:41, wrote: >> Slightly RFC: >> >> 1) I've not worked out exactly what the >> >> v->vcpu_info = (void *)&d->shared_info->compat.vcpu_info[0]; >> >>line is supposed to be doing and whether it is needed, but it doesn't >>appe

Re: [Xen-devel] [PATCH] x86/pv: Fix construction of 32bit dom0's

2019-02-07 Thread Juergen Gross
On 07/02/2019 14:29, Andrew Cooper wrote: > On 07/02/2019 12:58, Jan Beulich wrote: > On 06.02.19 at 21:41, wrote: >>> Slightly RFC: >>> >>> 1) I've not worked out exactly what the >>> >>> v->vcpu_info = (void *)&d->shared_info->compat.vcpu_info[0]; >>> >>>line is supposed to be doing

Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-07 Thread Roger Pau Monné
On Thu, Feb 07, 2019 at 02:21:24PM +0100, Marek Marczykowski-Górecki wrote: > On Thu, Feb 07, 2019 at 10:57:19AM +0100, Roger Pau Monné wrote: > > On Thu, Feb 07, 2019 at 01:07:47AM +0100, Marek Marczykowski-Górecki wrote: > > > diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c > > > index 8b44d

Re: [Xen-devel] [PATCH] x86/pv: Fix construction of 32bit dom0's

2019-02-07 Thread Jan Beulich
>>> On 07.02.19 at 14:29, wrote: > On 07/02/2019 12:58, Jan Beulich wrote: > On 06.02.19 at 21:41, wrote: >>> 2) The reported >>> >>> Dom0 alloc.: 3e80->3ec0 (240470 pages to be >>> allocated) >>> >>>line changes by 1 page because of the alloc_domheap_page(

Re: [Xen-devel] [PATCH] x86/pv: Fix construction of 32bit dom0's

2019-02-07 Thread Juergen Gross
On 07/02/2019 14:45, Jan Beulich wrote: On 07.02.19 at 14:29, wrote: >> On 07/02/2019 12:58, Jan Beulich wrote: >> On 06.02.19 at 21:41, wrote: 2) The reported Dom0 alloc.: 3e80->3ec0 (240470 pages to be allocated) line cha

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 8/9] common/grant_table: block speculative out-of-bound accesses

2019-02-07 Thread Jan Beulich
>>> On 07.02.19 at 11:20, wrote: > On 2/7/19 10:50, Norbert Manthey wrote: >> On 2/6/19 16:53, Jan Beulich wrote: >> On 06.02.19 at 16:06, wrote: On 2/6/19 15:52, Jan Beulich wrote: On 29.01.19 at 15:43, wrote: >> @@ -963,6 +965,9 @@ map_grant_ref( >> PIN_FAIL

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-02-07 Thread Jan Beulich
>>> On 07.02.19 at 12:48, wrote: > Stefano Stabellini writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce > SYMBOL"): >> I am OK with this approach. Maybe not the best IMO, but good enough. It >> should also satisfy the MISRAC guys, as they wrote "ideally cast to >> uintptr_t only once": here

Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-07 Thread Marek Marczykowski-Górecki
On Thu, Feb 07, 2019 at 02:21:27PM +0100, Marek Marczykowski-Górecki wrote: > On Thu, Feb 07, 2019 at 10:57:19AM +0100, Roger Pau Monné wrote: > > On Thu, Feb 07, 2019 at 01:07:47AM +0100, Marek Marczykowski-Górecki wrote: > > > From: Simon Gaiser > > > > > > Stubdomains need to be given sufficie

Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-07 Thread Roger Pau Monné
On Thu, Feb 07, 2019 at 03:52:38PM +0100, Marek Marczykowski-Górecki wrote: > On Thu, Feb 07, 2019 at 02:21:27PM +0100, Marek Marczykowski-Górecki wrote: > > On Thu, Feb 07, 2019 at 10:57:19AM +0100, Roger Pau Monné wrote: > > > On Thu, Feb 07, 2019 at 01:07:47AM +0100, Marek Marczykowski-Górecki

[Xen-devel] [PATCH 2/3] tools: init scripts: xencommons: Fixes to Description

2019-02-07 Thread Ian Jackson
`neeeded' is a typo. And xend is long gone. No functional change. Signed-off-by: Ian Jackson --- tools/hotplug/Linux/init.d/xencommons.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/hotplug/Linux/init.d/xencommons.in b/tools/hotplug/Linux/init.d/xencommons.in ind

[Xen-devel] [PATCH 1/3] tools: init scripts: xencommons: Provides `xen'

2019-02-07 Thread Ian Jackson
It is useful to have a single `xen' facility (in the LSB Provides namespace). That allows other facilities to specify that they should go after `xen' without needing to know the implementation details. This service name is already Provide'd by the (fairly different) init scripts used in Debian.

[Xen-devel] [PATCH for-4.12 0/3] tools: Init scripts minor fixes

2019-02-07 Thread Ian Jackson
The Debian Xen maintainers had a review of the init scripts. Debian has its completely own set of scripts. This is something that needs to be tackled in the medium term but not now. However, we did identify some things which could be remedied upstream right away. Ian Jackson (3): tools: init

Re: [Xen-devel] [PATCH] x86/pv: Fix construction of 32bit dom0's

2019-02-07 Thread Andrew Cooper
On 07/02/2019 13:56, Juergen Gross wrote: > On 07/02/2019 14:45, Jan Beulich wrote: >> > @@ -606,23 +598,14 @@ int __init dom0_construct_pv(struct domain *d, > { > maddr_to_page(mpt_alloc)->u.inuse.type_info = PGT_l4_page_table; > l4start = l4tab = __va(mpt_al

[Xen-devel] [PATCH 3/3] tools: init scripts: make XEN_RUN_DIR and XEN_LOCK_DIR mode 700

2019-02-07 Thread Ian Jackson
These directories ought not to be even world-readable. If this script for some reason runs with a lax umask they might be created overly-writeable. Avoid any such bug by setting the mode explicitly. Signed-off-by: Ian Jackson --- tools/hotplug/Linux/init.d/xencommons.in | 4 ++-- 1 file change

[Xen-devel] [PATCH] docs: features/qemu-depriv formatting fixes

2019-02-07 Thread George Dunlap
Need a space between the paragraph and the list so pandoc knows it's a list. Signed-off-by: George Dunlap --- Release justification: - "Bug" in docs (incorrect HTML output generated) CC: Ian Jackson CC: Wei Liu CC: Andrew Cooper CC: Jan Beulich CC: Tim Deegan CC: Konrad Wilk CC: Stefano S

Re: [Xen-devel] [PATCH] docs: features/qemu-depriv formatting fixes

2019-02-07 Thread Andrew Cooper
On 07/02/2019 15:09, George Dunlap wrote: > Need a space between the paragraph and the list so pandoc knows it's a > list. > > Signed-off-by: George Dunlap LGTM.  Acked-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https:

Re: [Xen-devel] [PATCH for-4.12 0/3] tools: Init scripts minor fixes

2019-02-07 Thread Wei Liu
On Thu, Feb 07, 2019 at 03:02:24PM +, Ian Jackson wrote: > The Debian Xen maintainers had a review of the init scripts. Debian > has its completely own set of scripts. This is something that needs > to be tackled in the medium term but not now. > > However, we did identify some things which

Re: [Xen-devel] [PATCH for-4.12 5/8] pvh/dom0: warn when dom0_mem is not set to a fixed value

2019-02-07 Thread Roger Pau Monné
On Wed, Feb 06, 2019 at 06:54:23AM -0700, Jan Beulich wrote: > >>> On 30.01.19 at 11:36, wrote: > > There have been several reports of the dom0 builder running out of > > memory when buildign a PVH dom0 without havingf specified a dom0_mem > > "building" and "having" > > > value. Print a warning

Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-07 Thread Marek Marczykowski-Górecki
On Thu, Feb 07, 2019 at 03:57:54PM +0100, Roger Pau Monné wrote: > On Thu, Feb 07, 2019 at 03:52:38PM +0100, Marek Marczykowski-Górecki wrote: > > On Thu, Feb 07, 2019 at 02:21:27PM +0100, Marek Marczykowski-Górecki wrote: > > > On Thu, Feb 07, 2019 at 10:57:19AM +0100, Roger Pau Monné wrote: > > >

Re: [Xen-devel] [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-02-07 Thread Souptick Joarder
Hi Mike, On Thu, Jan 31, 2019 at 2:09 PM Mike Rapoport wrote: > > On Thu, Jan 31, 2019 at 08:38:12AM +0530, Souptick Joarder wrote: > > Previouly drivers have their own way of mapping range of > > kernel pages/memory into user vma and this was done by > > invoking vm_insert_page() within a loop.

[Xen-devel] [xen-unstable-smoke test] 133005: tolerable all pass - PUSHED

2019-02-07 Thread osstest service owner
flight 133005 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/133005/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-02-07 Thread Mike Rapoport
Hi Souptick, On Thu, Feb 07, 2019 at 09:19:47PM +0530, Souptick Joarder wrote: > Hi Mike, > > Just thought to take opinion for documentation before placing it in v3. > Does it looks fine ? Overall looks good to me. Several minor points below. > +/** > + * __vm_insert_range - insert range of ke

Re: [Xen-devel] [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-02-07 Thread Souptick Joarder
On Thu, Feb 7, 2019 at 9:27 PM Mike Rapoport wrote: > > Hi Souptick, > > On Thu, Feb 07, 2019 at 09:19:47PM +0530, Souptick Joarder wrote: > > Hi Mike, > > > > Just thought to take opinion for documentation before placing it in v3. > > Does it looks fine ? > > Overall looks good to me. Several min

Re: [Xen-devel] [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-02-07 Thread Mike Rapoport
On Thu, Feb 07, 2019 at 09:37:08PM +0530, Souptick Joarder wrote: > On Thu, Feb 7, 2019 at 9:27 PM Mike Rapoport wrote: > > > > Hi Souptick, > > > > On Thu, Feb 07, 2019 at 09:19:47PM +0530, Souptick Joarder wrote: > > > Hi Mike, > > > > > > Just thought to take opinion for documentation before pl

Re: [Xen-devel] [PATCH RFC 0/6] Slotted channels for sync vm_events

2019-02-07 Thread Petre Ovidiu PIRCALABU
On Thu, 2019-02-07 at 11:46 +, George Dunlap wrote: > On 2/6/19 2:26 PM, Petre Ovidiu PIRCALABU wrote: > > On Wed, 2018-12-19 at 20:52 +0200, Petre Pircalabu wrote: > > > This patchset is a rework of the "multi-page ring buffer" for > > > vm_events > > > patch based on Andrew Cooper's comments.

Re: [Xen-devel] [PATCH for-4.12 0/3] tools: Init scripts minor fixes

2019-02-07 Thread Juergen Gross
On 07/02/2019 16:02, Ian Jackson wrote: > The Debian Xen maintainers had a review of the init scripts. Debian > has its completely own set of scripts. This is something that needs > to be tackled in the medium term but not now. > > However, we did identify some things which could be remedied ups

Re: [Xen-devel] [PATCH] docs: features/qemu-depriv formatting fixes

2019-02-07 Thread Juergen Gross
On 07/02/2019 16:09, George Dunlap wrote: > Need a space between the paragraph and the list so pandoc knows it's a > list. > > Signed-off-by: George Dunlap Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenprojec

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 8/9] common/grant_table: block speculative out-of-bound accesses

2019-02-07 Thread Norbert Manthey
On 2/7/19 15:00, Jan Beulich wrote: On 07.02.19 at 11:20, wrote: >> On 2/7/19 10:50, Norbert Manthey wrote: >>> On 2/6/19 16:53, Jan Beulich wrote: >>> On 06.02.19 at 16:06, wrote: > On 2/6/19 15:52, Jan Beulich wrote: > On 29.01.19 at 15:43, wrote: >>> @@ -963,6 +965,9

[Xen-devel] [PATCH RFC 04/55] x86/mm: introduce l{1, 2}t local variables to map_pages_to_xen

2019-02-07 Thread Wei Liu
The pl2e and pl1e variables are heavily (ab)used in that function. It is fine at the moment because all page tables are always mapped so there is no need to track the life time of each variable. We will soon have the requirement to map and unmap page tables. We need to track the life time of each

[Xen-devel] [PATCH RFC 02/55] x86: move some xen mm function declarations

2019-02-07 Thread Wei Liu
They were put into page.h but mm.h is more appropriate. The real reason is that I will be adding some new functions which takes mfn_t. It turns out it is a bit difficult to do in page.h. No functional change. Signed-off-by: Wei Liu --- xen/include/asm-x86/mm.h | 5 + xen/include/asm-x86/

[Xen-devel] [PATCH RFC 01/55] x86/mm: defer clearing page in virt_to_xen_lXe

2019-02-07 Thread Wei Liu
Defer the call to clear_page to the point when we're sure the page is going to become a page table. This is a minor optimisation. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/

[Xen-devel] [PATCH RFC 03/55] x86: introduce a new set of APIs to manage Xen page tables

2019-02-07 Thread Wei Liu
We are going to switch to using domheap page for page tables. A new set of APIs is introduced to allocate, map, unmap and free pages for page tables. The allocation and deallocation work on mfn_t but not page_info, because they are required to work even before frame table is set up. Implement the

[Xen-devel] [PATCH RFC 00/55] x86: use domheap page for xen page tables

2019-02-07 Thread Wei Liu
This series switches xen page tables from xenheap page to domheap page. This is required so that when we implement xenheap on top of vmap there won't be a loop. It is done in roughly three steps: 1. Introduce a new set of APIs, implement the old APIs on top of the new ones. New APIs still use

[Xen-devel] [PATCH RFC 09/55] x86/mm: add an end_of_loop label in modify_xen_mappings

2019-02-07 Thread Wei Liu
We will soon need to clean up mappings whenever the out most loop is ended. Add a new label and turn relevant continue's into goto's. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/xen/arch/x

[Xen-devel] [PATCH RFC 08/55] x86/mm: make sure there is one exit path for modify_xen_mappings

2019-02-07 Thread Wei Liu
We will soon need to handle dynamically mapping / unmapping page tables in the said function. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index dc

[Xen-devel] [PATCH RFC 05/55] x86/mm: introduce l{1, 2}t local variables to modify_xen_mappings

2019-02-07 Thread Wei Liu
The pl2e and pl1e variables are heavily (ab)used in that function. It is fine at the moment because all page tables are always mapped so there is no need to track the life time of each variable. We will soon have the requirement to map and unmap page tables. We need to track the life time of each

[Xen-devel] [PATCH RFC 06/55] x86/mm: map_pages_to_xen should have one exit path

2019-02-07 Thread Wei Liu
We will soon rewrite the function to handle dynamically mapping and unmapping of page tables. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x

[Xen-devel] [PATCH RFC 07/55] x86/mm: add an end_of_loop label in map_pages_to_xen

2019-02-07 Thread Wei Liu
We will soon need to clean up mappings whenever the out most loop is ended. Add a new label and turn relevant continue's into goto's. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/mm.c

Re: [Xen-devel] [PATCH for-4.12 5/8] pvh/dom0: warn when dom0_mem is not set to a fixed value

2019-02-07 Thread Jan Beulich
>>> On 07.02.19 at 16:39, wrote: > On Wed, Feb 06, 2019 at 06:54:23AM -0700, Jan Beulich wrote: >> >>> On 30.01.19 at 11:36, wrote: >> > There have been several reports of the dom0 builder running out of >> > memory when buildign a PVH dom0 without havingf specified a dom0_mem >> >> "building" a

Re: [Xen-devel] [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-02-07 Thread Matthew Wilcox
On Thu, Feb 07, 2019 at 09:19:47PM +0530, Souptick Joarder wrote: > Just thought to take opinion for documentation before placing it in v3. > Does it looks fine ? > > +/** > + * __vm_insert_range - insert range of kernel pages into user vma > + * @vma: user vma to map to > + * @pages: pointer to a

Re: [Xen-devel] Reducing or removing direct map from xen (was Re: Ongoing/future speculative mitigation work)

2019-02-07 Thread Wei Liu
On Thu, Jan 24, 2019 at 11:44:55AM +, Wei Liu wrote: [...] > 3.2 Switch page table allocation to use domheap page > > We think that 3.2 is a worthwhile thing to do anyway. This work just > gives us a good excuse to do it. I just posted a patch series for this work item. See [PATCH RFC 00/5

Re: [Xen-devel] [PATCH 7/8] x86/mm: handle foreign mappings in p2m_entry_modify

2019-02-07 Thread Roger Pau Monné
On Wed, Feb 06, 2019 at 09:59:30AM -0700, Jan Beulich wrote: > >>> On 30.01.19 at 11:36, wrote: > > --- a/xen/include/asm-x86/p2m.h > > +++ b/xen/include/asm-x86/p2m.h > > @@ -933,9 +933,12 @@ struct hvm_ioreq_server *p2m_get_ioreq_server(struct > > domain *d, > >

[Xen-devel] [PATCH RFC 32/55] efi: switch EFI L4 table to use new APIs

2019-02-07 Thread Wei Liu
This requires storing the MFN instead of linear address of the L4 table. Adjust code accordingly. Signed-off-by: Wei Liu --- xen/arch/x86/efi/runtime.h | 12 +--- xen/common/efi/boot.c | 8 ++-- xen/common/efi/efi.h | 3 ++- xen/common/efi/runtime.c | 8 4 fi

[Xen-devel] [PATCH RFC 48/55] x86_64/mm: map and unmap page tables in subarch_memory_op

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/x86_64/mm.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c index 9dd2ecad4a..cac06b782d 100644 --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64/mm.c @@ -1015,8

[Xen-devel] [PATCH RFC 29/55] efi: avoid using global variable in copy_mapping

2019-02-07 Thread Wei Liu
We will soon switch efi_l4_table to use ephemeral mapping. Make copy_mapping take a pointer to the mapping instead of using the global variable. No functional change intended. Signed-off-by: Wei Liu --- xen/common/efi/boot.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) dif

[Xen-devel] [PATCH RFC 20/55] x86/mm: switch to new APIs in arch_init_memory

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index ddd99ef0f2..9e115ef0b8 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -366,19 +366,22 @@ void __init arch_init_me

[Xen-devel] [PATCH RFC 44/55] x86_64/mm: map and unmap page tables in destroy_m2p_mapping

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/x86_64/mm.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c index bd298fff1b..36f25583f2 100644 --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64/mm.c @@ -292

[Xen-devel] [PATCH RFC 52/55] x86: remove lXe_to_lYe in __start_xen

2019-02-07 Thread Wei Liu
Properly map and unmap page tables where necessary. Signed-off-by: Wei Liu --- xen/arch/x86/setup.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 92da060915..7b6420f95a 100644 --- a/xen/arch/x86/setup.c +++ b/xen/

[Xen-devel] [PATCH RFC 46/55] x86_64/mm: map and unmap page tables in cleanup_frame_table

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/x86_64/mm.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c index 6087851e69..cbd1f829cf 100644 --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64/mm.c @

[Xen-devel] [PATCH RFC 38/55] x86/smpboot: drop lXe_to_lYe invocations from cleanup_cpu_root_pgt

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/smpboot.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index 7436799d80..a9a39cea6e 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -893,23 +893,27

[Xen-devel] [PATCH RFC 31/55] efi: add emacs block to boot.c

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/common/efi/boot.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index 1d1420f02c..3868293d06 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -1705,3 +1705,13 @@ void __init efi_init_me

[Xen-devel] [PATCH RFC 13/55] x86/mm: rewrite virt_to_xen_l3e

2019-02-07 Thread Wei Liu
Rewrite that function to use the new APIs. Modify its callers to unmap the pointer returned. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 61 +++ 1 file changed, 48 insertions(+), 13 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86

[Xen-devel] [PATCH RFC 55/55] x86/mm: drop _new suffix from page table APIs

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- Patch generated with find -name '*.[ch]' -exec sed -i 's/$OLD/$NEW/g' --- xen/arch/x86/domain.c| 4 +- xen/arch/x86/domain_page.c | 2 +- xen/arch/x86/efi/runtime.h | 4 +- xen/arch/x86/mm.c| 164 +--

[Xen-devel] [PATCH RFC 33/55] x86/smpboot: add emacs block

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/smpboot.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index 7d1226d7bc..4a0982272d 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -1384,3 +1384,13 @@ void __init smp_in

[Xen-devel] [PATCH RFC 19/55] x86/mm: drop lXe_to_lYe invocations from modify_xen_mappings

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 18c7b43705..ddd99ef0f2 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -5406,8 +5406,7 @@ int modify

[Xen-devel] [PATCH RFC 15/55] x86/mm: rewrite virt_to_xen_l1e

2019-02-07 Thread Wei Liu
Rewrite this function to use new APIs. Modify its callers to unmap the pointer returned. Signed-off-by: Wei Liu --- xen/arch/x86/domain_page.c | 10 ++ xen/arch/x86/mm.c | 30 +- 2 files changed, 31 insertions(+), 9 deletions(-) diff --git a/xen/arch

Re: [Xen-devel] [PATCH 7/8] x86/mm: handle foreign mappings in p2m_entry_modify

2019-02-07 Thread Jan Beulich
>>> On 07.02.19 at 17:53, wrote: > On Wed, Feb 06, 2019 at 09:59:30AM -0700, Jan Beulich wrote: >> >>> On 30.01.19 at 11:36, wrote: >> > --- a/xen/include/asm-x86/p2m.h >> > +++ b/xen/include/asm-x86/p2m.h >> > @@ -933,9 +933,12 @@ struct hvm_ioreq_server *p2m_get_ioreq_server(struct >> > domain

[Xen-devel] [PATCH RFC 50/55] x86/pv: properly map and unmap page tables in mark_pv_pt_pages_rdonly

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/pv/dom0_build.c | 35 +++ 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c index 837ef7bca1..293be076d9 100644 --- a/xen/arch/x86/pv/dom0_build.c +++

[Xen-devel] [PATCH RFC 53/55] x86/mm: drop old page table APIs

2019-02-07 Thread Wei Liu
Now that we've switched all users to the new APIs, the old ones aren't needed anymore. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 16 xen/include/asm-x86/mm.h | 2 -- xen/include/asm-x86/page.h | 5 - 3 files changed, 23 deletions(-) diff --git a/xen/arch/x

[Xen-devel] [PATCH RFC 36/55] x86/smpboot: switch pl2e to use new APIs in clone_mapping

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/smpboot.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index f74a6c245f..e14e48d823 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -673,7 +673,7

[Xen-devel] [PATCH RFC 12/55] x86/mm: change pl3e to l3t in virt_to_xen_l3e

2019-02-07 Thread Wei Liu
We will need to have a variable named pl3e when we rewrite virt_to_xen_l3e. Change pl3e to l3t to reflect better its purpose. This will make reviewing later patch easier. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 14 +++--- 1 file changed, 7 insertions(+), 7 d

[Xen-devel] [PATCH RFC 42/55] x86_64/mm: map and unmap page tables in share_hotadd_m2p_table

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/x86_64/mm.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c index 2b88a1af37..597d8e9ed8 100644 --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64

[Xen-devel] [PATCH RFC 24/55] x86_64/mm.c: remove code that serves no purpose in setup_m2p_table

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/x86_64/mm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c index 094c609c8c..55fa338d71 100644 --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64/mm.c @@ -480,8 +480,6 @@ static int setup_m2p_t

[Xen-devel] [PATCH RFC 40/55] x86/shim: map and unmap page tables in replace_va_mapping

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/pv/shim.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c index 324ca27f93..cf638fa965 100644 --- a/xen/arch/x86/pv/shim.c +++ b/xen/arch/x86/pv/shim.c @@ -167,15 +167

[Xen-devel] [PATCH RFC 34/55] x86/smpboot: clone_mapping should have one exit path

2019-02-07 Thread Wei Liu
We will soon need to clean up page table mappings in the exit path. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/smpboot.c | 35 --- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c in

[Xen-devel] [PATCH RFC 41/55] x86_64/mm: map and unmap page tables in m2p_mapped

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/x86_64/mm.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c index 216f97c95f..2b88a1af37 100644 --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64/mm.c @@

[Xen-devel] [PATCH RFC 47/55] x86_64/mm: map and unmap page tables in subarch_init_memory

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/x86_64/mm.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c index cbd1f829cf..9dd2ecad4a 100644 --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64

[Xen-devel] [PATCH RFC 26/55] x86_64/mm: switch to new APIs in setup_m2p_table

2019-02-07 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/x86_64/mm.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c index d3e2398b6c..0b85961105 100644 --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64/mm.c @@ -397,9 +3

  1   2   >