Re: [Xen-devel] [PATCH for-4.12] arm/p2m: do not invalidate p2m root if it is shared with IOMMU

2019-02-06 Thread Andrii Anisov
Hello Stefano, On 05.02.19 11:17, Andrii Anisov wrote: Thank you. I already referred this thread in the email to the vendor as the first step. But have no answer yet :( We've got an answer from the vendor. They agree with arguments and have provided a patch to eliminate Set/Way usage. We've c

[Xen-devel] [PATCH v8 for-4.12 01/17] argo: Introduce the Kconfig option to govern inclusion of Argo

2019-02-06 Thread Christopher Clark
Defines CONFIG_ARGO when enabled. Default: disabled. When the Kconfig option is enabled, the Argo hypercall implementation will be included, allowing use of the hypervisor-mediated interdomain communication mechanism. Argo is implemented for x86 and ARM hardware platforms. Availability of the op

[Xen-devel] [PATCH v8 for-4.12 04/17] argo: init, destroy and soft-reset, with enable command line opt

2019-02-06 Thread Christopher Clark
Initialises basic data structures and performs teardown of argo state for domain shutdown. Inclusion of the Argo implementation is dependent on CONFIG_ARGO. Introduces a new Xen command line parameter 'argo': bool to enable/disable the argo hypercall. Defaults to disabled. New headers: public/

[Xen-devel] [PATCH v8 for-4.12 07/17] argo: implement the register op

2019-02-06 Thread Christopher Clark
The register op is used by a domain to register a region of memory for receiving messages from either a specified other domain, or, if specifying a wildcard, any domain. This operation creates a mapping within Xen's private address space that will remain resident for the lifetime of the ring. In s

[Xen-devel] [PATCH v8 for-4.12 03/17] argo: define argo_dprintk for subsystem debugging

2019-02-06 Thread Christopher Clark
A convenience for working on development of the argo subsystem: setting a #define variable enables additional debug messages. Signed-off-by: Christopher Clark Acked-by: Jan Beulich Reviewed-by: Roger Pau Monné --- v3 added Roger's Reviewed-by v3 added Jan's Ack v2 #03 feedback, Jan: fix ifdef/d

[Xen-devel] [PATCH v8 for-4.12 05/17] errno: add POSIX error codes EMSGSIZE, ECONNREFUSED to the ABI

2019-02-06 Thread Christopher Clark
EMSGSIZE: Argo's sendv operation will return EMSGSIZE when an excess amount of data, across all iovs, has been supplied, exceeding either the statically configured maximum size of a transmittable message, or the (variable) size of the ring registered by the destination domain. ECONNREFUSED: Argo's

[Xen-devel] [PATCH v8 for-4.12 02/17] argo: introduce the argo_op hypercall boilerplate

2019-02-06 Thread Christopher Clark
Presence is gated upon CONFIG_ARGO. Registers the hypercall previously reserved for this. Takes 5 arguments, does nothing and returns -ENOSYS. Implementation will provide a compat ABI so COMPAT_CALL is the selected macro for the hypercall tables. Signed-off-by: Christopher Clark Acked-by: Jan B

[Xen-devel] [PATCH v8 for-4.12 00/17] Argo: hypervisor-mediated interdomain communication

2019-02-06 Thread Christopher Clark
Version eight of this series: Note: This version may not address the currently open discussion on the ARM hypercall argument convention and type selection for hypercall parameters. * Range check applied to numeric args in native hypercall entry (ref: the above open discussion) * Revises the co

[Xen-devel] [PATCH v8 for-4.12 08/17] argo: implement the unregister op

2019-02-06 Thread Christopher Clark
Takes a single argument: a handle to the ring unregistration struct, which specifies the port and partner domain id or wildcard. The ring's entry is removed from the hashtable of registered rings; any entries for pending notifications are removed; and the ring is unmapped from Xen's address space.

[Xen-devel] [PATCH v8 for-4.12 09/17] argo: implement the sendv op; evtchn: expose send_guest_global_virq

2019-02-06 Thread Christopher Clark
sendv operation is invoked to perform a synchronous send of buffers contained in iovs to a remote domain's registered ring. It takes: * A destination address (domid, port) for the ring to send to. It performs a most-specific match lookup, to allow for wildcard. * A source address, used to inf

[Xen-devel] [PATCH v8 for-4.12 11/17] xsm, argo: XSM control for argo register

2019-02-06 Thread Christopher Clark
XSM controls for argo ring registration with two distinct cases, where the ring being registered is: 1) Single source: registering a ring for communication to receive messages from a specified single other domain. Default policy: allow. 2) Any source: registering a ring

[Xen-devel] [PATCH v8 for-4.12 12/17] xsm, argo: XSM control for argo message send operation

2019-02-06 Thread Christopher Clark
Default policy: allow. Signed-off-by: Christopher Clark Reviewed-by: Paul Durrant Acked-by: Daniel De Graaf Tested-by: Chris Patterson --- v3 Daniel/Jan: add to the default xsm policy for the send op v3 Add Daniel's Acked-by v2: reordered commit sequence to after sendv implementation v1 feedba

[Xen-devel] [PATCH v8 for-4.12 16/17] SUPPORT.md : add new entry for the Argo feature

2019-02-06 Thread Christopher Clark
Status: Experimental Signed-off-by: Christopher Clark --- SUPPORT.md | 4 1 file changed, 4 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index 7c8493c..19fc8d7 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -617,6 +617,10 @@ Virtual Performance Management Unit for HVM guests Disabled b

[Xen-devel] [PATCH v8 for-4.12 14/17] xsm, argo: notify: don't describe rings that cannot be sent to

2019-02-06 Thread Christopher Clark
Signed-off-by: Christopher Clark Acked-by: Daniel De Graaf Tested-by: Chris Patterson --- v3 #10 Roger: drop out label, use return -EFAULT in fill_ring_data v3: Add Daniel's Acked-by xen/common/argo.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/xen/common/argo.c b/xen/comm

[Xen-devel] [PATCH v8 for-4.12 10/17] argo: implement the notify op

2019-02-06 Thread Christopher Clark
Queries for data about space availability in registered rings and causes notification to be sent when space has become available. The hypercall op populates a supplied data structure with information about ring state and if insufficient space is currently available in a given ring, the hypervisor

[Xen-devel] [PATCH v8 for-4.12 06/17] xen/arm: introduce guest_handle_for_field()

2019-02-06 Thread Christopher Clark
ARM port of c/s bb544585: "introduce guest_handle_for_field()" This helper turns a field of a GUEST_HANDLE into a GUEST_HANDLE. Signed-off-by: Christopher Clark Reviewed-by: Paul Durrant Reviewed-by: Stefano Stabellini --- v3: Added Stefano's Reviewed-by v2: Added Paul's Reviewed-by xen/incl

[Xen-devel] [PATCH v8 for-4.12 13/17] xsm, argo: XSM control for any access to argo by a domain

2019-02-06 Thread Christopher Clark
Will inhibit initialization of the domain's argo data structure to prevent receiving any messages or notifications and access to any of the argo hypercall operations. Signed-off-by: Christopher Clark Acked-by: Daniel De Graaf Tested-by: Chris Patterson --- v7 self: fix return of check error cod

[Xen-devel] [PATCH v8 for-4.12 15/17] MAINTAINERS: add new section for Argo and self as maintainer

2019-02-06 Thread Christopher Clark
Signed-off-by: Christopher Clark Reviewed-by: Roger Pau Monné --- v7 #015 Roger: Add Reviewed-by v5 whitespace: tabs MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e99d39e..a0cda4f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -158,6 +158,

[Xen-devel] [PATCH v8 for-4.12 17/17] docs, argo: add design document for Argo

2019-02-06 Thread Christopher Clark
Document provides a brief introduction to the Argo interdomain communication mechanism and a detailed description of the granular locking used within the Argo implementation. Signed-off-by: Christopher Clark --- docs/designs/argo.pandoc | 448 +++ 1 fi

Re: [Xen-devel] [PATCH for-4.12 4/8] x86/shadow: alloc enough pages so initialization doesn't fail

2019-02-06 Thread Roger Pau Monné
On Tue, Feb 05, 2019 at 10:32:08AM -0700, Jan Beulich wrote: > >>> On 05.02.19 at 16:53, wrote: > > On Tue, Feb 05, 2019 at 08:15:27AM -0700, Jan Beulich wrote: > >> >>> On 05.02.19 at 14:52, wrote: > >> > I don't think the amount of guest memory matters here, the following > >> > example with 8G

Re: [Xen-devel] [PATCH v8 for-4.12 16/17] SUPPORT.md : add new entry for the Argo feature

2019-02-06 Thread Roger Pau Monné
On Wed, Feb 06, 2019 at 12:55:07AM -0800, Christopher Clark wrote: > Status: Experimental > > Signed-off-by: Christopher Clark Reviewed-by: Roger Pau Monné > --- > SUPPORT.md | 4 > 1 file changed, 4 insertions(+) > > diff --git a/SUPPORT.md b/SUPPORT.md > index 7c8493c..19fc8d7 100644

Re: [Xen-devel] [PATCH] x86/HVM: correctly deal with benign exceptions when combining two

2019-02-06 Thread Andrew Cooper
On 06/02/2019 07:40, Jan Beulich wrote: > Benign exceptions, no matter whether they're first or second, will never > cause #DF (a benign exception being second can basically only be #AC, as > in the XSA-156 scenario). #DB can happen as well, but I'm not sure if this example is relevant here.  Both

[Xen-devel] [xen-unstable-coverity test] 132958: regressions - ALL FAIL

2019-02-06 Thread osstest service owner
flight 132958 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/132958/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: coverity-amd647 coverity-upload fail REGR. vs. 132424 version t

Re: [Xen-devel] [PATCH RFC v2 2/2] x86/emulate: Send vm_event from emulate

2019-02-06 Thread Alexandru Stefan ISAILA
>> >> /* FPU sub-types which may be requested via ->get_fpu(). */ >> enum x86_emulate_fpu_type { >> diff --git a/xen/include/asm-x86/hvm/emulate.h >> b/xen/include/asm-x86/hvm/emulate.h >> index 26a01e83a4..721e175b04 100644 >> --- a/xen/include/asm-x86/hvm/emulate.h >> +++ b/xen/include/a

[Xen-devel] [PATCH] VMX: don't ignore P2M setup error

2019-02-06 Thread Jan Beulich
set_mmio_p2m_entry() may fail, in particular with -ENOMEM. Don't ignore such an error, but instead cause domain creation to fail in such a case. Signed-off-by: Jan Beulich --- 4.12: Another candidate, but again open for discussion. --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.

Re: [Xen-devel] [PATCH] VMX: don't ignore P2M setup error

2019-02-06 Thread Juergen Gross
On 06/02/2019 11:24, Jan Beulich wrote: > set_mmio_p2m_entry() may fail, in particular with -ENOMEM. Don't ignore > such an error, but instead cause domain creation to fail in such a case. > > Signed-off-by: Jan Beulich > --- > 4.12: Another candidate, but again open for discussion. I'm fine wit

Re: [Xen-devel] [PATCH v8 for-4.12 17/17] docs, argo: add design document for Argo

2019-02-06 Thread Roger Pau Monné
On Wed, Feb 06, 2019 at 12:55:08AM -0800, Christopher Clark wrote: > Document provides a brief introduction to the Argo interdomain > communication mechanism and a detailed description of the granular > locking used within the Argo implementation. > > Signed-off-by: Christopher Clark Reviewed-by

Re: [Xen-devel] [PATCH v5 00/15] Argo: hypervisor-mediated interdomain communication

2019-02-06 Thread Roger Pau Monné
Gentle ping on the questions below. On Mon, Feb 04, 2019 at 11:07:12AM +0100, Roger Pau Monné wrote: > On Sun, Feb 03, 2019 at 10:04:29AM -0800, Christopher Clark wrote: > > On Thu, Jan 31, 2019 at 5:39 AM Roger Pau Monné > > wrote: > > > > > > On Wed, Jan 30, 2019 at 08:05:30PM -0800, Christoph

Re: [Xen-devel] [PATCH v5 00/15] Argo: hypervisor-mediated interdomain communication

2019-02-06 Thread Roger Pau Monné
Wrong 'To:' field in the previous email, sorry. Gentle ping on the questions below. On Mon, Feb 04, 2019 at 11:07:12AM +0100, Roger Pau Monné wrote: > On Sun, Feb 03, 2019 at 10:04:29AM -0800, Christopher Clark wrote: > > On Thu, Jan 31, 2019 at 5:39 AM Roger Pau Monné > > wrote: > > > > > > On

Re: [Xen-devel] [PATCH] x86/HVM: correctly deal with benign exceptions when combining two

2019-02-06 Thread Jan Beulich
>>> On 06.02.19 at 10:57, wrote: > On 06/02/2019 07:40, Jan Beulich wrote: >> Benign exceptions, no matter whether they're first or second, will never >> cause #DF (a benign exception being second can basically only be #AC, as >> in the XSA-156 scenario). > > #DB can happen as well, but I'm not s

[Xen-devel] [PATCH] x86/shadow: adjust minimum allocation calculations

2019-02-06 Thread Jan Beulich
A previously bad situation has become worse with the early setting of ->max_vcpus: The value returned by shadow_min_acceptable_pages() has further grown, and hence now holds back even more memory from use for the p2m. Make sh_min_allocation() account for all p2m memory needed for shadow_enable() t

Re: [Xen-devel] [PATCH for-4.12 4/8] x86/shadow: alloc enough pages so initialization doesn't fail

2019-02-06 Thread Jan Beulich
>>> On 06.02.19 at 10:10, wrote: > On Tue, Feb 05, 2019 at 10:32:08AM -0700, Jan Beulich wrote: >> >>> On 05.02.19 at 16:53, wrote: >> > On Tue, Feb 05, 2019 at 08:15:27AM -0700, Jan Beulich wrote: >> >> >>> On 05.02.19 at 14:52, wrote: >> >> > I don't think the amount of guest memory matters he

[Xen-devel] [PATCH] SVM: make nested page-fault tracing and logging consistent

2019-02-06 Thread Jan Beulich
Don't call __get_gfn_type_access() more than once, to make sure data recorded for xentrace matches up with what gets logged in case of the domain getting crashed. As a side effect this also eliminates a type mismatch reported by Norbert Manthey, as the first call now also needs to update the local

Re: [Xen-devel] [PATCH] VMX: don't ignore P2M setup error

2019-02-06 Thread Andrew Cooper
On 06/02/2019 10:24, Jan Beulich wrote: > set_mmio_p2m_entry() may fail, in particular with -ENOMEM. Don't ignore > such an error, but instead cause domain creation to fail in such a case. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper ___ Xen

Re: [Xen-devel] [PATCH] x86/shadow: adjust minimum allocation calculations

2019-02-06 Thread Roger Pau Monné
On Wed, Feb 06, 2019 at 03:56:49AM -0700, Jan Beulich wrote: > A previously bad situation has become worse with the early setting of > ->max_vcpus: The value returned by shadow_min_acceptable_pages() has > further grown, and hence now holds back even more memory from use for > the p2m. > > Make sh

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-02-06 Thread Jan Beulich
>>> On 05.02.19 at 15:56, wrote: > On Mon, Feb 4, 2019 at 9:37 AM Jan Beulich wrote: >> >>> On 01.02.19 at 19:52, wrote: >> What I'm not sure I see is what you mean to >> express with all you wrote in terms of finding a way out of the >> current situation (besides requesting a vote) > > If you'

Re: [Xen-devel] [PATCH] x86/shadow: adjust minimum allocation calculations

2019-02-06 Thread Andrew Cooper
On 06/02/2019 10:56, Jan Beulich wrote: > @@ -1373,9 +1377,15 @@ static unsigned int sh_min_allocation(co > { > /* > * Don't allocate less than the minimum acceptable, plus one page per > - * megabyte of RAM (for the p2m table). > + * megabyte of RAM (for the p2m table, minimall

Re: [Xen-devel] [PATCH] x86/shadow: adjust minimum allocation calculations

2019-02-06 Thread Jan Beulich
>>> On 06.02.19 at 13:00, wrote: > On 06/02/2019 10:56, Jan Beulich wrote: >> @@ -1373,9 +1377,15 @@ static unsigned int sh_min_allocation(co >> { >> /* >> * Don't allocate less than the minimum acceptable, plus one page per >> - * megabyte of RAM (for the p2m table). >> + * me

[Xen-devel] [xen-4.10-testing test] 132922: tolerable FAIL - PUSHED

2019-02-06 Thread osstest service owner
flight 132922 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/132922/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail like 132630 test-amd64-amd64-xl-qemuu-dmrest

Re: [Xen-devel] [PATCH] x86/shadow: adjust minimum allocation calculations

2019-02-06 Thread Jan Beulich
>>> On 06.02.19 at 12:52, wrote: > On Wed, Feb 06, 2019 at 03:56:49AM -0700, Jan Beulich wrote: >> @@ -1373,9 +1377,15 @@ static unsigned int sh_min_allocation(co >> { >> /* >> * Don't allocate less than the minimum acceptable, plus one page per >> - * megabyte of RAM (for the p2m

[Xen-devel] [PATCH RFC v3 2/2] x86/emulate: Send vm_event from emulate

2019-02-06 Thread Alexandru Stefan ISAILA
This patch aims to have mem access vm events sent from the emulator. This is useful in the case of page-walks that have to emulate instructions in access denied pages. We use hvmemul_map_linear_addr() ro intercept r/w access and hvmemul_insn_fetch() to intercept exec access. First we try to send

[Xen-devel] [PATCH RFC v3 1/2] x86/emulate: Move hvmemul_linear_to_phys

2019-02-06 Thread Alexandru Stefan ISAILA
This is done so hvmemul_linear_to_phys() can be called from hvmemul_map_linear_addr(). There is no functional change. Signed-off-by: Alexandru Isaila --- xen/arch/x86/hvm/emulate.c | 181 ++--- 1 file changed, 90 insertions(+), 91 deletions(-) diff --git a/xen/a

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 4/9] spec: add l1tf-barrier

2019-02-06 Thread Norbert Manthey
On 2/5/19 15:43, Jan Beulich wrote: On 05.02.19 at 15:23, wrote: >> On 1/31/19 17:35, Jan Beulich wrote: >> On 29.01.19 at 15:43, wrote: @@ -1942,6 +1942,12 @@ Irrespective of Xen's setting, the feature is >> virtualised for HVM guests to use. By default, Xen will enable thi

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 4/9] spec: add l1tf-barrier

2019-02-06 Thread Jan Beulich
>>> On 06.02.19 at 14:02, wrote: > On 2/5/19 15:43, Jan Beulich wrote: > On 05.02.19 at 15:23, wrote: >>> On 1/31/19 17:35, Jan Beulich wrote: >>> On 29.01.19 at 15:43, wrote: > +/* > * We do not disable HT by default on affected hardware. > * > * Fi

Re: [Xen-devel] [PATCH v8 for-4.12 00/17] Argo: hypervisor-mediated interdomain communication

2019-02-06 Thread Jan Beulich
>>> On 06.02.19 at 09:54, wrote: > Version eight of this series: > > Note: This version may not address the currently open discussion on the > ARM hypercall argument convention and type selection for hypercall > parameters. > > * Range check applied to numeric args in native hypercall entry >

Re: [Xen-devel] [PATCH v8 for-4.12 00/17] Argo: hypervisor-mediated interdomain communication

2019-02-06 Thread Juergen Gross
On 06/02/2019 14:45, Jan Beulich wrote: On 06.02.19 at 09:54, wrote: >> Version eight of this series: >> >> Note: This version may not address the currently open discussion on the >> ARM hypercall argument convention and type selection for hypercall >> parameters. >> >> * Range check applied

Re: [Xen-devel] [PATCH for-4.12 5/8] pvh/dom0: warn when dom0_mem is not set to a fixed value

2019-02-06 Thread Jan Beulich
>>> On 30.01.19 at 11:36, wrote: > There have been several reports of the dom0 builder running out of > memory when buildign a PVH dom0 without havingf specified a dom0_mem "building" and "having" > value. Print a warning message if dom0_mem is not set to a fixed value > when booting in PVH mode

Re: [Xen-devel] [PATCH v8 for-4.12 00/17] Argo: hypervisor-mediated interdomain communication

2019-02-06 Thread Jan Beulich
>>> On 06.02.19 at 14:53, wrote: > On 06/02/2019 14:45, Jan Beulich wrote: > On 06.02.19 at 09:54, wrote: >>> Version eight of this series: >>> >>> Note: This version may not address the currently open discussion on the >>> ARM hypercall argument convention and type selection for hypercall >>

[Xen-devel] [PATCH Makefile v2] asm: handle comments when creating header file

2019-02-06 Thread Norbert Manthey
From: Norbert Manthey In the early steps of compilation, the asm header files are created, such as include/asm-$(TARGET_ARCH)/asm-offsets.h. These files depend on the assembly file arch/$(TARGET_ARCH)/asm-offsets.s, which is generated before. Depending on the used toolchain, there might be commen

[Xen-devel] [linux-3.18 test] 132919: regressions - trouble: blocked/broken/fail/pass

2019-02-06 Thread osstest service owner
flight 132919 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/132919/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw broken test-amd64-i386-examine 8 reboot

Re: [Xen-devel] [PATCH RFC 0/6] Slotted channels for sync vm_events

2019-02-06 Thread Petre Ovidiu PIRCALABU
On Wed, 2018-12-19 at 20:52 +0200, Petre Pircalabu wrote: > This patchset is a rework of the "multi-page ring buffer" for > vm_events > patch based on Andrew Cooper's comments. > For synchronous vm_events the ring waitqueue logic was unnecessary as > the > vcpu sending the request was blocked until

[Xen-devel] XEN on R-CAR H3

2019-02-06 Thread Amit Tomer
HI, Trying to boot XEN on R-CAR H3 starter Kit board. Linux image based on 5.0.0-rc5 and XEN image is 4.12 tftp 0x4800 xen;tftp 0x7a00 Image; tftp 4a00 r8a7795-h3ulcb.dtb setenv xen_addr_r 0x4800 setenv fdt_addr_r 4a00 setenv kernel_addr_r 0x7a00 fdt addr $fdt_addr_r fdt

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 8/9] common/grant_table: block speculative out-of-bound accesses

2019-02-06 Thread Jan Beulich
>>> On 29.01.19 at 15:43, wrote: > @@ -963,6 +965,9 @@ map_grant_ref( > PIN_FAIL(unlock_out, GNTST_bad_gntref, "Bad ref %#x for d%d\n", > op->ref, rgt->domain->domain_id); > > +/* Make sure the above check is not bypassed speculatively */ > +op->ref = array_ind

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 6/9] is_control_domain: block speculation

2019-02-06 Thread Jan Beulich
>>> On 29.01.19 at 15:43, wrote: > @@ -908,10 +909,10 @@ void watchdog_domain_destroy(struct domain *d); > *(that is, this would not be suitable for a driver domain) > * - There is never a reason to deny the hardware domain access to this > */ > -#define is_hardware_domain(_d) ((_d) ==

Re: [Xen-devel] XEN on R-CAR H3

2019-02-06 Thread Oleksandr
On 06.02.19 16:41, Amit Tomer wrote: HI, Hi Trying to boot XEN on R-CAR H3 starter Kit board. Linux image based on 5.0.0-rc5 and XEN image is 4.12 tftp 0x4800 xen;tftp 0x7a00 Image; tftp 4a00 r8a7795-h3ulcb.dtb setenv xen_addr_r 0x4800 setenv fdt_addr_r 4a00 setenv ker

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 8/9] common/grant_table: block speculative out-of-bound accesses

2019-02-06 Thread Norbert Manthey
On 2/6/19 15:52, Jan Beulich wrote: On 29.01.19 at 15:43, wrote: >> @@ -963,6 +965,9 @@ map_grant_ref( >> PIN_FAIL(unlock_out, GNTST_bad_gntref, "Bad ref %#x for d%d\n", >> op->ref, rgt->domain->domain_id); >> >> +/* Make sure the above check is not bypassed s

Re: [Xen-devel] [PATCH Makefile v2] asm: handle comments when creating header file

2019-02-06 Thread Jan Beulich
>>> On 06.02.19 at 15:09, wrote: > From: Norbert Manthey > > In the early steps of compilation, the asm header files are created, such > as include/asm-$(TARGET_ARCH)/asm-offsets.h. These files depend on the > assembly file arch/$(TARGET_ARCH)/asm-offsets.s, which is generated > before. Dependin

Re: [Xen-devel] XEN on R-CAR H3

2019-02-06 Thread Amit Tomer
Hi,Thanks for prompt reply. > Memory nodes got duplicated somehow. Likely U-Boot did something incorrect. > > Try to use single memory node in your device-tree instead of separated > by each bank nodes: > > memory@4800 { > device_type = "memory"; > /* first 128MB is reserved

[Xen-devel] [xen-unstable-smoke test] 132967: tolerable all pass - PUSHED

2019-02-06 Thread osstest service owner
flight 132967 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/132967/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 9/9] common/memory: block speculative out-of-bound accesses

2019-02-06 Thread Jan Beulich
>>> On 29.01.19 at 15:43, wrote: > @@ -33,10 +34,10 @@ unsigned long __read_mostly pdx_group_valid[BITS_TO_LONGS( > > bool __mfn_valid(unsigned long mfn) > { > -return likely(mfn < max_page) && > - likely(!(mfn & pfn_hole_mask)) && > - likely(test_bit(pfn_to_pdx(mfn) /

[Xen-devel] Ping: libfsimage path/file name changes

2019-02-06 Thread Jan Beulich
Ian, >>> On 28.01.19 at 08:55, wrote: > back in October you've added quite a number of "xen" prefixes to > various pieces there. Now that I've finally had time to connect this > change of yours with PV domain creation failures that I've since > been observing (not a bug in any way, merely resulti

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 6/9] is_control_domain: block speculation

2019-02-06 Thread Norbert Manthey
On 2/6/19 16:03, Jan Beulich wrote: On 29.01.19 at 15:43, wrote: >> @@ -908,10 +909,10 @@ void watchdog_domain_destroy(struct domain *d); >> *(that is, this would not be suitable for a driver domain) >> * - There is never a reason to deny the hardware domain access to this >> */ >>

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 9/9] common/memory: block speculative out-of-bound accesses

2019-02-06 Thread Norbert Manthey
On 2/6/19 16:25, Jan Beulich wrote: On 29.01.19 at 15:43, wrote: >> @@ -33,10 +34,10 @@ unsigned long __read_mostly >> pdx_group_valid[BITS_TO_LONGS( >> >> bool __mfn_valid(unsigned long mfn) >> { >> -return likely(mfn < max_page) && >> - likely(!(mfn & pfn_hole_mask)) && >

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-02-06 Thread Ian Jackson
Jan Beulich writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL"): > As per my earlier reply, I've yet to see proof of a "code-breaking > optimization" that actually matches our case(s). I have personally experienced a program being miscompiled because of the mistaken belief by the compi

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 8/9] common/grant_table: block speculative out-of-bound accesses

2019-02-06 Thread Jan Beulich
>>> On 06.02.19 at 16:06, wrote: > On 2/6/19 15:52, Jan Beulich wrote: > On 29.01.19 at 15:43, wrote: >>> @@ -963,6 +965,9 @@ map_grant_ref( >>> PIN_FAIL(unlock_out, GNTST_bad_gntref, "Bad ref %#x for d%d\n", >>> op->ref, rgt->domain->domain_id); >>> >>> +/* M

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 6/9] is_control_domain: block speculation

2019-02-06 Thread Jan Beulich
>>> On 06.02.19 at 16:36, wrote: > On 2/6/19 16:03, Jan Beulich wrote: > On 29.01.19 at 15:43, wrote: >>> @@ -908,10 +909,10 @@ void watchdog_domain_destroy(struct domain *d); >>> *(that is, this would not be suitable for a driver domain) >>> * - There is never a reason to deny the h

Re: [Xen-devel] [PATCH SpectreV1+L1TF v5 9/9] common/memory: block speculative out-of-bound accesses

2019-02-06 Thread Jan Beulich
>>> On 06.02.19 at 16:39, wrote: > On 2/6/19 16:25, Jan Beulich wrote: > On 29.01.19 at 15:43, wrote: >>> @@ -33,10 +34,10 @@ unsigned long __read_mostly >>> pdx_group_valid[BITS_TO_LONGS( >>> >>> bool __mfn_valid(unsigned long mfn) >>> { >>> -return likely(mfn < max_page) && >>> -

[Xen-devel] [xen-unstable test] 132932: regressions - FAIL

2019-02-06 Thread osstest service owner
flight 132932 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/132932/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-amd64-pvgrub 7 xen-bootfail REGR. vs. 132820 test-amd64-amd64-x

Re: [Xen-devel] Ping: libfsimage path/file name changes

2019-02-06 Thread Ian Jackson
Jan Beulich writes ("Ping: libfsimage path/file name changes"): > On 28.01.19 at 08:55, wrote: > > back in October you've added quite a number of "xen" prefixes to > > various pieces there. Now that I've finally had time to connect this > > change of yours with PV domain creation failures that I'v

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-02-06 Thread Jan Beulich
>>> On 06.02.19 at 16:41, wrote: > Jan Beulich writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL"): >> As per my earlier reply, I've yet to see proof of a "code-breaking >> optimization" that actually matches our case(s). > > I have personally experienced a program being miscompiled b

Re: [Xen-devel] Ping: libfsimage path/file name changes

2019-02-06 Thread Juergen Gross
On 06/02/2019 17:13, Ian Jackson wrote: > Jan Beulich writes ("Ping: libfsimage path/file name changes"): >> On 28.01.19 at 08:55, wrote: >>> back in October you've added quite a number of "xen" prefixes to >>> various pieces there. Now that I've finally had time to connect this >>> change of your

Re: [Xen-devel] [xen-unstable test] 132932: regressions - FAIL

2019-02-06 Thread Jan Beulich
>>> On 06.02.19 at 17:10, wrote: > flight 132932 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/132932/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-amd64-amd64-pvgrub 7 xen-boot

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-02-06 Thread Ian Jackson
Jan Beulich writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL"): > On 06.02.19 at 16:41, wrote: > > (i) define indirection variables eg end_ in an assembly language file. > > (ii) convert to uintptr_t before comparing > > > > (i) is IMO wholly safe but it is a bit ugly and slightly le

Re: [Xen-devel] [xen-unstable test] 132932: regressions - FAIL

2019-02-06 Thread Ian Jackson
Jan Beulich writes ("Re: [Xen-devel] [xen-unstable test] 132932: regressions - FAIL"): > >>> On 06.02.19 at 17:10, wrote: > > flight 132932 xen-unstable real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/132932/ > > > > Regressions :-( > > > > Tests which did not succeed and are

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-02-06 Thread Jan Beulich
>>> On 06.02.19 at 17:37, wrote: > Jan Beulich writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL"): >> - it marks problem sites clearly (one of Stefano's goals), >> - it isolates future changes to how exactly the comparisons >> are to be done to the comparison macro(s) >> - it doesn'

Re: [Xen-devel] [PATCH] SVM: make nested page-fault tracing and logging consistent

2019-02-06 Thread Boris Ostrovsky
On 2/6/19 6:22 AM, Jan Beulich wrote: > Don't call __get_gfn_type_access() more than once, to make sure data > recorded for xentrace matches up with what gets logged in case of the > domain getting crashed. > > As a side effect this also eliminates a type mismatch reported by > Norbert Manthey, as

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-02-06 Thread Ian Jackson
Jan Beulich writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL"): > On 06.02.19 at 17:37, wrote: > > Jan Beulich writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL"): > >> - it allows the end-of-whatever symbols to also be handed to > >> functions in a type-safe manner > >

Re: [Xen-devel] [PATCH 7/8] x86/mm: handle foreign mappings in p2m_entry_modify

2019-02-06 Thread Jan Beulich
>>> On 30.01.19 at 11:36, wrote: > --- a/xen/include/asm-x86/p2m.h > +++ b/xen/include/asm-x86/p2m.h > @@ -933,9 +933,12 @@ struct hvm_ioreq_server *p2m_get_ioreq_server(struct > domain *d, >unsigned int *flags); > > static inline void p2m_entry_

Re: [Xen-devel] [PATCH] x86/shadow: adjust minimum allocation calculations

2019-02-06 Thread Roger Pau Monné
On Wed, Feb 06, 2019 at 05:53:16AM -0700, Jan Beulich wrote: > >>> On 06.02.19 at 12:52, wrote: > > On Wed, Feb 06, 2019 at 03:56:49AM -0700, Jan Beulich wrote: > >> @@ -1373,9 +1377,15 @@ static unsigned int sh_min_allocation(co > >> { > >> /* > >> * Don't allocate less than the minim

Re: [Xen-devel] [PATCH v7 02/15] argo: introduce the argo_op hypercall boilerplate

2019-02-06 Thread Julien Grall
Hi Stefano, On 2/5/19 9:34 PM, Stefano Stabellini wrote: On Tue, 5 Feb 2019, Julien Grall wrote: Sorry for the formatting. On Tue, 5 Feb 2019, 20:04 Stefano Stabellini, wrote: On Tue, 5 Feb 2019, Jan Beulich wrote: But I am afraid this is not correct. Upper 32-bit of the register wi

Re: [Xen-devel] [PATCH v8 for-4.12 10/17] argo: implement the notify op

2019-02-06 Thread Julien Grall
Hi, On 2/6/19 8:55 AM, Christopher Clark wrote: +/* + * XEN_ARGO_OP_notify + * + * Asks Xen for information about other rings in the system. + * + * ent->ring is the xen_argo_addr_t of the ring you want information on. + * Uses the same ring matching rules as XEN_ARGO_OP_sendv. + * + * ent->spac

[Xen-devel] [xen-4.11-testing test] 132938: tolerable FAIL - PUSHED

2019-02-06 Thread osstest service owner
flight 132938 xen-4.11-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/132938/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 10 debian-hvm-install fail never pass test-amd64-i386-xl

Re: [Xen-devel] [PATCH for-4.12] arm/p2m: do not invalidate p2m root if it is shared with IOMMU

2019-02-06 Thread Stefano Stabellini
On Wed, 6 Feb 2019, Andrii Anisov wrote: > Hello Stefano, > > On 05.02.19 11:17, Andrii Anisov wrote: > > Thank you. > > I already referred this thread in the email to the vendor as the first step. > > But have no answer yet :( > > We've got an answer from the vendor. They agree with arguments an

Re: [Xen-devel] [PATCH v7 02/15] argo: introduce the argo_op hypercall boilerplate

2019-02-06 Thread Stefano Stabellini
On Wed, 6 Feb 2019, Julien Grall wrote: > Hi Stefano, > > On 2/5/19 9:34 PM, Stefano Stabellini wrote: > > On Tue, 5 Feb 2019, Julien Grall wrote: > > > Sorry for the formatting. > > > > > > On Tue, 5 Feb 2019, 20:04 Stefano Stabellini, > > > wrote: > > >On Tue, 5 Feb 2019, Jan Beulich w

[Xen-devel] [qemu-mainline baseline-only test] 83603: regressions - trouble: broken/fail/pass

2019-02-06 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 83603 qemu-mainline real [real] http://osstest.xensource.com/osstest/logs/83603/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl broken

Re: [Xen-devel] RT Xen on ARM - R-Car series

2019-02-06 Thread Andrii Anisov
Hello, On 05.02.19 10:40, Andrii Anisov wrote: On 04.02.19 23:58, Julien Grall wrote: Thank you for writing a patch. I am back in France this week for family reason and will not have time properly give a spin this week. Stefano, Andrii, can you test it? I'll do that today. I actually did i

[Xen-devel] [libvirt test] 132941: tolerable all pass - PUSHED

2019-02-06 Thread osstest service owner
flight 132941 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/132941/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 132776 test-armhf-armhf-libvirt-raw 13 saveresto

[Xen-devel] [PATCH] x86/pv: Fix construction of 32bit dom0's

2019-02-06 Thread Andrew Cooper
dom0_construct_pv() has logic to transition dom0 into a compat domain when booting an ELF32 image. One aspect which is missing is the CPUID policy recalculation, meaning that a 32bit dom0 sees a 64bit policy, which differ by the Long Mode feature flag in particular. Another missing item is the x8

Re: [Xen-devel] RT Xen on ARM - R-Car series

2019-02-06 Thread Stefano Stabellini
On Wed, 6 Feb 2019, Andrii Anisov wrote: > Hello, > > On 05.02.19 10:40, Andrii Anisov wrote: > > On 04.02.19 23:58, Julien Grall wrote: > > > Thank you for writing a patch. I am back in France this week for family > > > reason and will not have time properly give a spin this week. Stefano, > > >

[Xen-devel] [freebsd-master test] 132959: all pass - PUSHED

2019-02-06 Thread osstest service owner
flight 132959 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/132959/ Perfect :-) All tests in this flight passed as required version targeted for testing: freebsd 31147537ec123ed5f5eb12260430f1ef5f906324 baseline version: freebsd f2704b103eb

[Xen-devel] [xen-unstable-smoke test] 132977: tolerable all pass - PUSHED

2019-02-06 Thread osstest service owner
flight 132977 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/132977/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-02-06 Thread Stefano Stabellini
On Wed, 6 Feb 2019, Ian Jackson wrote: > Jan Beulich writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL"): > > On 06.02.19 at 17:37, wrote: > > > Jan Beulich writes ("Re: [Xen-devel] [PATCH v6 1/4] xen: introduce > > > SYMBOL"): > > >> - it allows the end-of-whatever symbols to also be

[Xen-devel] [PATCH v4 2/6] libxl: attach PCI device to qemu only after setting pciback/pcifront

2019-02-06 Thread Marek Marczykowski-Górecki
When qemu is running in stubdomain, handling "pci-ins" command will fail if pcifront is not initialized already. Fix this by sending such command only after confirming that pciback/front is running. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Wei Liu --- Changes in v2: - Fixed code style

[Xen-devel] [PATCH v4 3/6] libxl: don't try to manipulate json config for stubdomain

2019-02-06 Thread Marek Marczykowski-Górecki
Stubdomain do not have it's own config file - its configuration is derived from target domains. Do not try to manipulate it when attaching PCI device. This bug prevented starting HVM with stubdomain and PCI passthrough device attached. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3:

[Xen-devel] [PATCH v4 5/6] xen/x86: add PHYSDEVOP_msi_set_enable

2019-02-06 Thread Marek Marczykowski-Górecki
Allow device model running in stubdomain to enable/disable MSI(-X), bypassing pciback. While pciback is still used to access config space from within stubdomain, it refuse to write to PCI_MSI_FLAGS_ENABLE/PCI_MSIX_FLAGS_ENABLE in non-permissive mode. Which is the right thing to do for PV domain (th

[Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-06 Thread Marek Marczykowski-Górecki
From: Simon Gaiser Stubdomains need to be given sufficient privilege over the guest which it provides emulation for in order for PCI passthrough to work correctly. When a HVM domain try to enable MSI, QEMU in stubdomain calls PHYSDEVOP_map_pirq, but later it needs to call XEN_DOMCTL_bind_pt_irq a

[Xen-devel] [PATCH v4 0/6] Fix PCI passthrough for HVM with stubdomain

2019-02-06 Thread Marek Marczykowski-Górecki
In this version, I add PHYSDEVOP_msi_set_enable to allow stubdomain enabling MSI after mapping it. Related article: https://www.qubes-os.org/news/2017/10/18/msi-support/ Changes in v2: - new "xen/x86: Allow stubdom access to irq created for msi" patch - applied review comments from v1 Changes i

[Xen-devel] [PATCH v4 1/6] libxl: do not attach xen-pciback to HVM domain, if stubdomain is in use

2019-02-06 Thread Marek Marczykowski-Górecki
HVM domains use IOMMU and device model assistance for communicating with PCI devices, xen-pcifront/pciback isn't directly needed by HVM domain. But pciback serve also second function - it reset the device when it is deassigned from the guest and for this reason pciback needs to be used with HVM dom

[Xen-devel] [PATCH v4 6/6] tools/libxc: add wrapper for PHYSDEVOP_msi_set_enable

2019-02-06 Thread Marek Marczykowski-Górecki
Add libxc wrapper for PHYSDEVOP_msi_set_enable introduced in previous commit. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - new patch Changes in v4: - adjust for updated previous patch --- tools/libxc/include/xenctrl.h | 7 +++ tools/libxc/xc_physdev.c | 21 +

[Xen-devel] [linux-3.18 bisection] complete test-amd64-i386-xl-raw

2019-02-06 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-raw testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tr

  1   2   >