[Xen-devel] an assertion triggered when running Xen on a HSW desktop

2019-01-15 Thread Chao Gao
The output of lscpu is: Architecture: x86_64 CPU op-mode(s):32-bit, 64-bit Byte Order:Little Endian CPU(s):8 On-line CPU(s) list: 0-7 Thread(s) per core:2 Core(s) per socket:4 Socket(s): 1 NUMA node(s): 1 Vendor ID:

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-15 Thread Christopher Clark
On Mon, Jan 14, 2019 at 7:31 AM Andrew Cooper wrote: > > On 07/01/2019 07:42, Christopher Clark wrote: > > diff --git a/docs/misc/xen-command-line.pandoc > > b/docs/misc/xen-command-line.pandoc > > index aea13eb..68d4415 100644 > > --- a/docs/misc/xen-command-line.pandoc > > +++ b/docs/misc/xen-c

Re: [Xen-devel] [PATCH v3 08/15] argo: implement the unregister op

2019-01-15 Thread Christopher Clark
On Thu, Jan 10, 2019 at 3:40 AM Roger Pau Monné wrote: > > On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark > wrote: > > > > Takes a single argument: a handle to the ring unregistration struct, > > which specifies the port and partner domain id or wildcard. > > > > The ring's entry is removed fro

Re: [Xen-devel] [PATCH v3 10/15] argo: implement the notify op

2019-01-15 Thread Roger Pau Monné
On Mon, Jan 14, 2019 at 10:53:54PM -0800, Christopher Clark wrote: > On Thu, Jan 10, 2019 at 4:22 AM Roger Pau Monné wrote: > > > > On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark > > wrote: > > > + > > > +argo_dprintk("fill_ring_data: ent.ring.domain=%u,ent.ring.port=%x\n", > > > +

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-15 Thread Jan Beulich
>>> On 14.01.19 at 18:24, wrote: > On 14/01/2019 16:44, Jan Beulich wrote: >> >> extern struct my_struct __start[]; >> extern struct my_struct __end[]; >> >> void test(const struct my_struct *); >> >> void foo(int i) { >> test(i ? __start : __end); >> } > > Your example doesn't contain an

Re: [Xen-devel] [PATCH v3 08/15] argo: implement the unregister op

2019-01-15 Thread Christopher Clark
On Mon, Jan 14, 2019 at 7:06 AM Jan Beulich wrote: > > >>> On 07.01.19 at 08:42, wrote: > > @@ -666,6 +667,105 @@ ring_find_info(const struct domain *d, const struct > > argo_ring_id *id) > > return NULL; > > } > > > > +static struct argo_send_info * > > +send_find_info(const struct domain

Re: [Xen-devel] an assertion triggered when running Xen on a HSW desktop

2019-01-15 Thread Roger Pau Monné
On Tue, Jan 15, 2019 at 04:04:40PM +0800, Chao Gao wrote: [...] > (XEN) Xen version 4.12-unstable (root@) (gcc (Ubuntu 7.3.0-27ubuntu1~18.04) > 7.3.0) debug=y Tue Jan 15 07:25:29 UTC 2019 > (XEN) Latest ChangeSet: Mon Dec 17 09:22:59 2018 + git:a5b0eb3636 [...] > (XEN) *** Building a PVH Dom0

Re: [Xen-devel] [PATCH v6 2/2] xen/blkback: rework connect_ring() to avoid inconsistent xenstore 'ring-page-order' set by malicious blkfront

2019-01-15 Thread Roger Pau Monné
On Tue, Jan 15, 2019 at 12:41:44AM +0800, Dongli Zhang wrote: > The xenstore 'ring-page-order' is used globally for each blkback queue and > therefore should be read from xenstore only once. However, it is obtained > in read_per_ring_refs() which might be called multiple times during the > initiali

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-15 Thread Jan Beulich
>>> On 14.01.19 at 22:18, wrote: > Hi Jan, > > One question below to make a decision on the way forward. > > On Mon, 14 Jan 2019, Jan Beulich wrote: >> >>> On 14.01.19 at 04:45, wrote: >> > So let's keep the linker-accessible variable as a type that works for the >> > linker (which really could

Re: [Xen-devel] [PATCH] x86emul: fix test harness and fuzzer build dependencies

2019-01-15 Thread Jan Beulich
>>> On 14.01.19 at 17:59, wrote: > Jan Beulich writes ("Re: [Xen-devel] [PATCH] x86emul: fix test harness and > fuzzer build dependencies"): >> So how do we make progress here? For the two changes that >> you dislike I don't formally need your ack, and I have Andrew's. >> I would (have to) respec

Re: [Xen-devel] [PATCH v3 10/15] argo: implement the notify op

2019-01-15 Thread Christopher Clark
On Tue, Jan 15, 2019 at 12:06 AM Roger Pau Monné wrote: > > On Mon, Jan 14, 2019 at 10:53:54PM -0800, Christopher Clark wrote: > > On Thu, Jan 10, 2019 at 4:22 AM Roger Pau Monné wrote: > > > > > > On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark > > > wrote: > > > > + > > > > +argo_dprintk

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 08:56, wrote: > On Mon, Jan 14, 2019 at 6:19 AM Jan Beulich wrote: >> >>> On 07.01.19 at 08:42, wrote: >> > +/* >> > + * A ring must be large enough to transmit messages, so requires >> > space for: >> > + * * 1 message header, plus >> > + * * 1 payload slot (

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-15 Thread Christopher Clark
On Tue, Jan 15, 2019 at 12:36 AM Jan Beulich wrote: > > >>> On 15.01.19 at 08:56, wrote: > > On Mon, Jan 14, 2019 at 6:19 AM Jan Beulich wrote: > >> >>> On 07.01.19 at 08:42, wrote: > >> > +/* > >> > + * A ring must be large enough to transmit messages, so requires > >> > space for: >

Re: [Xen-devel] PING ARM [PATCH v2] xen/cmdline: Fix buggy strncmp(s, LITERAL, ss - s) construct

2019-01-15 Thread Jan Beulich
>>> On 14.01.19 at 18:16, wrote: > Hi Andrew, > > On 14/01/2019 16:59, Andrew Cooper wrote: >> On 14/01/2019 16:07, Julien Grall wrote: >>> On 14/01/2019 15:17, Andrew Cooper wrote: > diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h > index ca655ff..22a86ec 100644 >>

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 08:21, wrote: > On Mon, Jan 14, 2019 at 6:58 AM Andrew Cooper > wrote: >> On 07/01/2019 07:42, Christopher Clark wrote: >> > --- a/docs/misc/xen-command-line.pandoc >> > +++ b/docs/misc/xen-command-line.pandoc >> > @@ -182,6 +182,17 @@ Permit Xen to use "Always Running APIC Ti

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-15 Thread Andrew Cooper
On 15/01/2019 09:01, Jan Beulich wrote: On 15.01.19 at 08:21, wrote: >> On Mon, Jan 14, 2019 at 6:58 AM Andrew Cooper >> wrote: >>> On 07/01/2019 07:42, Christopher Clark wrote: --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -182,6 +182,17

Re: [Xen-devel] an assertion triggered when running Xen on a HSW desktop

2019-01-15 Thread Chao Gao
On Tue, Jan 15, 2019 at 09:18:25AM +0100, Roger Pau Monné wrote: >On Tue, Jan 15, 2019 at 04:04:40PM +0800, Chao Gao wrote: >[...] >> (XEN) Xen version 4.12-unstable (root@) (gcc (Ubuntu 7.3.0-27ubuntu1~18.04) >> 7.3.0) debug=y Tue Jan 15 07:25:29 UTC 2019 >> (XEN) Latest ChangeSet: Mon Dec 17 09

Re: [Xen-devel] an assertion triggered when running Xen on a HSW desktop

2019-01-15 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 15 January 2019 08:18 > To: Chao Gao > Cc: xen-devel@lists.xenproject.org; Paul Durrant > Subject: Re: [Xen-devel] an assertion triggered when running Xen on a HSW > desktop > > On Tue, Jan 15, 2019 at 04:04:40PM +0800, Chao Gao wrote:

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 10:06, wrote: > On 15/01/2019 09:01, Jan Beulich wrote: > On 15.01.19 at 08:21, wrote: >>> On Mon, Jan 14, 2019 at 6:58 AM Andrew Cooper > wrote: On 07/01/2019 07:42, Christopher Clark wrote: > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-com

[Xen-devel] xen-commandline document

2019-01-15 Thread Juergen Gross
Recently there have been several requests to add disclaimers like "only applicable if CONFIG_xyz defined" to docs/misc/xen-command-line.pandoc. As that file will be used as source for the installed file /usr/share/doc/xen/html/misc/xen-command-line.html there might be a better alternative instead

[Xen-devel] [PATCH v4 02/14] argo: introduce the argo_op hypercall boilerplate

2019-01-15 Thread Christopher Clark
Presence is gated upon CONFIG_ARGO. Registers the hypercall previously reserved for this. Takes 5 arguments, does nothing and returns -ENOSYS. Will be avoiding a compat ABI by using fixed-size types in hypercall ops so HYPERCALL, rather than COMPAT_CALL, is the correct macro for the hypercall tab

[Xen-devel] [PATCH v4 03/14] argo: define argo_dprintk for subsystem debugging

2019-01-15 Thread Christopher Clark
A convenience for working on development of the argo subsystem: setting a #define variable enables additional debug messages. Signed-off-by: Christopher Clark Acked-by: Jan Beulich Reviewed-by: Roger Pau Monné --- v3 added Roger's Reviewed-by v3 added Jan's Ack v2 #03 feedback, Jan: fix ifdef/d

[Xen-devel] [PATCH v4 00/14] Argo: hypervisor-mediated interdomain communication

2019-01-15 Thread Christopher Clark
Version four of this patch series. * Changes are primarily addressing feedback from the v3 series reviews. Many points noted on the invididual commit posts. * Register ring interfaces uses Xen gfns as page identifiers, and the arguments no longer specify page granularity. * Multi-level lock

[Xen-devel] [PATCH v4 01/14] argo: Introduce the Kconfig option to govern inclusion of Argo

2019-01-15 Thread Christopher Clark
Defines CONFIG_ARGO when enabled. Default: disabled. When the Kconfig option is enabled, the Argo hypercall implementation will be included, allowing use of the hypervisor-mediated interdomain communication mechanism. Argo is implemented for x86 and ARM hardware platforms. Availability of the op

[Xen-devel] [PATCH v4 11/14] xsm, argo: XSM control for argo register

2019-01-15 Thread Christopher Clark
XSM controls for argo ring registration with two distinct cases, where the ring being registered is: 1) Single source: registering a ring for communication to receive messages from a specified single other domain. Default policy: allow. 2) Any source: registering a ring

[Xen-devel] [PATCH v4 14/14] xsm, argo: notify: don't describe rings that cannot be sent to

2019-01-15 Thread Christopher Clark
Signed-off-by: Christopher Clark Acked-by: Daniel De Graaf --- v3 #10 Roger: drop out label, use return -EFAULT in fill_ring_data v3: Add Daniel's Acked-by xen/common/argo.c | 12 1 file changed, 12 insertions(+) diff --git a/xen/common/argo.c b/xen/common/argo.c index 23b61bf..ce

[Xen-devel] [PATCH v4 04/14] argo: init, destroy and soft-reset, with enable command line opt

2019-01-15 Thread Christopher Clark
Initialises basic data structures and performs teardown of argo state for domain shutdown. Inclusion of the Argo implementation is dependent on CONFIG_ARGO. Introduces a new Xen command line parameter 'argo': bool to enable/disable the argo hypercall. Defaults to disabled. New headers: public/

[Xen-devel] [PATCH v4 06/14] xen/arm: introduce guest_handle_for_field()

2019-01-15 Thread Christopher Clark
ARM port of c/s bb544585: "introduce guest_handle_for_field()" This helper turns a field of a GUEST_HANDLE into a GUEST_HANDLE. Signed-off-by: Christopher Clark Reviewed-by: Paul Durrant Reviewed-by: Stefano Stabellini --- v3: Added Stefano's Reviewed-by v2: Added Paul's Reviewed-by xen/incl

[Xen-devel] [PATCH v4 13/14] xsm, argo: XSM control for any access to argo by a domain

2019-01-15 Thread Christopher Clark
Will inhibit initialization of the domain's argo data structure to prevent receiving any messages or notifications and access to any of the argo hypercall operations. Signed-off-by: Christopher Clark Acked-by: Daniel De Graaf --- v3 Daniel/Jan: add to the default xsm policy for enable v3 Add Dan

[Xen-devel] [PATCH v4 07/14] argo: implement the register op

2019-01-15 Thread Christopher Clark
The register op is used by a domain to register a region of memory for receiving messages from either a specified other domain, or, if specifying a wildcard, any domain. This operation creates a mapping within Xen's private address space that will remain resident for the lifetime of the ring. In s

[Xen-devel] [PATCH v4 09/14] argo: implement the sendv op; evtchn: expose send_guest_global_virq

2019-01-15 Thread Christopher Clark
sendv operation is invoked to perform a synchronous send of buffers contained in iovs to a remote domain's registered ring. It takes: * A destination address (domid, port) for the ring to send to. It performs a most-specific match lookup, to allow for wildcard. * A source address, used to inf

[Xen-devel] [PATCH v4 10/14] argo: implement the notify op

2019-01-15 Thread Christopher Clark
Queries for data about space availability in registered rings and causes notification to be sent when space has become available. The hypercall op populates a supplied data structure with information about ring state, and if insufficient space is currently available in a given ring, the hypervisor

[Xen-devel] [PATCH v4 05/14] errno: add POSIX error codes EMSGSIZE, ECONNREFUSED to the ABI

2019-01-15 Thread Christopher Clark
EMSGSIZE: Argo's sendv operation will return EMSGSIZE when an excess amount of data, across all iovs, has been supplied, exceeding either the statically configured maximum size of a transmittable message, or the (variable) size of the ring registered by the destination domain. ECONNREFUSED: Argo's

[Xen-devel] [PATCH v4 12/14] xsm, argo: XSM control for argo message send operation

2019-01-15 Thread Christopher Clark
Default policy: allow. Signed-off-by: Christopher Clark Reviewed-by: Paul Durrant Acked-by: Daniel De Graaf --- v3 Daniel/Jan: add to the default xsm policy for the send op v3 Add Daniel's Acked-by v2: reordered commit sequence to after sendv implementation v1 feedback Jan #16: apply const to

[Xen-devel] [PATCH v4 08/14] argo: implement the unregister op

2019-01-15 Thread Christopher Clark
Takes a single argument: a handle to the ring unregistration struct, which specifies the port and partner domain id or wildcard. The ring's entry is removed from the hashtable of registered rings; any entries for pending notifications are removed; and the ring is unmapped from Xen's address space.

[Xen-devel] [PATCH v4 0/1] cameraif: add ABI for para-virtual camera

2019-01-15 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Hello! At the moment Xen [1] already supports some virtual multimedia features [2] such as virtual display, sound. It supports keyboards, pointers and multi-touch devices all allowing Xen to be used in automotive appliances, In-Vehicle Infotainment (IVI) systems and

[Xen-devel] [PATCH v4 1/1] cameraif: add ABI for para-virtual camera

2019-01-15 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko This is the ABI for the two halves of a para-virtualized camera driver which extends Xen's reach multimedia capabilities even farther enabling it for video conferencing, In-Vehicle Infotainment, high definition maps etc. The initial goal is to support most needed fu

Re: [Xen-devel] xen-commandline document

2019-01-15 Thread Andrew Cooper
On 15/01/2019 09:23, Juergen Gross wrote: > Recently there have been several requests to add disclaimers > like "only applicable if CONFIG_xyz defined" to > docs/misc/xen-command-line.pandoc. > > As that file will be used as source for the installed file > /usr/share/doc/xen/html/misc/xen-command-l

Re: [Xen-devel] an assertion triggered when running Xen on a HSW desktop

2019-01-15 Thread Paul Durrant
> -Original Message- [snip] > >> (XEN) Xen call trace: > >> (XEN)[] iommu_map+0xba/0x176 > >> (XEN)[] iommu_hwdom_init+0xef/0x220 > >> (XEN)[] dom0_construct_pvh+0x189/0x129e > >> (XEN)[] construct_dom0+0xd4/0xb14 > >> (XEN)[] __start_xen+0x2710/0x2830 > >> (XEN)[] _

Re: [Xen-devel] xen-commandline document

2019-01-15 Thread Andrew Cooper
On 15/01/2019 09:38, Andrew Cooper wrote: > On 15/01/2019 09:23, Juergen Gross wrote: >> Recently there have been several requests to add disclaimers >> like "only applicable if CONFIG_xyz defined" to >> docs/misc/xen-command-line.pandoc. >> >> As that file will be used as source for the installed

Re: [Xen-devel] [RFC v2 0/4] QEMU changes to do PVH boot

2019-01-15 Thread Liam Merwick
Hi Stefano, On 10/01/2019 15:12, Stefano Garzarella wrote: On Wed, Jan 09, 2019 at 01:18:12PM -0800, Maran Wilson wrote: On 1/9/2019 11:53 AM, Boris Ostrovsky wrote: On 1/9/19 6:53 AM, Stefano Garzarella wrote: Hi Liam, On Tue, Jan 8, 2019 at 3:47 PM Liam Merwick wrote: QEMU sets the hvm_m

Re: [Xen-devel] xen-commandline document

2019-01-15 Thread Juergen Gross
On 15/01/2019 10:38, Andrew Cooper wrote: > On 15/01/2019 09:23, Juergen Gross wrote: >> Recently there have been several requests to add disclaimers >> like "only applicable if CONFIG_xyz defined" to >> docs/misc/xen-command-line.pandoc. >> >> As that file will be used as source for the installed

Re: [Xen-devel] Hikey: Enable Xen + Mainline Linux Kernel

2019-01-15 Thread Leo Yan
Hi all, On Tue, Jan 15, 2019 at 10:49:58AM +0800, Leo Yan wrote: [...] > [1.807591] Modules linked in: > [1.810717] CPU: 4 PID: 1 Comm: swapper/0 Not tainted > 5.0.0-rc2-1-g5b47dea3757c #3 > [1.818691] Hardware name: HiKey Development Board (DT) > [1.823983] pstate: 4005

Re: [Xen-devel] an assertion triggered when running Xen on a HSW desktop

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 10:44, wrote: >> -Original Message- > [snip] >> >> (XEN) Xen call trace: >> >> (XEN)[] iommu_map+0xba/0x176 >> >> (XEN)[] iommu_hwdom_init+0xef/0x220 >> >> (XEN)[] dom0_construct_pvh+0x189/0x129e >> >> (XEN)[] construct_dom0+0xd4/0xb14 >> >> (XEN)[]

Re: [Xen-devel] xen-commandline document

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 10:38, wrote: > On 15/01/2019 09:23, Juergen Gross wrote: >> Recently there have been several requests to add disclaimers >> like "only applicable if CONFIG_xyz defined" to >> docs/misc/xen-command-line.pandoc. >> >> As that file will be used as source for the installed file >>

Re: [Xen-devel] xen-commandline document

2019-01-15 Thread Andrew Cooper
On 15/01/2019 09:59, Juergen Gross wrote: > On 15/01/2019 10:38, Andrew Cooper wrote: >> On 15/01/2019 09:23, Juergen Gross wrote: >>> Recently there have been several requests to add disclaimers >>> like "only applicable if CONFIG_xyz defined" to >>> docs/misc/xen-command-line.pandoc. >>> >>> As t

Re: [Xen-devel] xen-commandline document

2019-01-15 Thread Andrew Cooper
On 15/01/2019 10:19, Jan Beulich wrote: On 15.01.19 at 10:38, wrote: >> On 15/01/2019 09:23, Juergen Gross wrote: >>> Recently there have been several requests to add disclaimers >>> like "only applicable if CONFIG_xyz defined" to >>> docs/misc/xen-command-line.pandoc. >>> >>> As that file wi

Re: [Xen-devel] an assertion triggered when running Xen on a HSW desktop

2019-01-15 Thread Roger Pau Monné
On Tue, Jan 15, 2019 at 03:16:01AM -0700, Jan Beulich wrote: > >>> On 15.01.19 at 10:44, wrote: > >> -Original Message- > > [snip] > >> >> (XEN) Xen call trace: > >> >> (XEN)[] iommu_map+0xba/0x176 > >> >> (XEN)[] iommu_hwdom_init+0xef/0x220 > >> >> (XEN)[] dom0_construct_pvh+

Re: [Xen-devel] xen-commandline document

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 11:25, wrote: > On 15/01/2019 10:19, Jan Beulich wrote: > On 15.01.19 at 10:38, wrote: >>> On 15/01/2019 09:23, Juergen Gross wrote: Recently there have been several requests to add disclaimers like "only applicable if CONFIG_xyz defined" to docs/misc/xen-com

Re: [Xen-devel] xen-commandline document

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 11:22, wrote: > On 15/01/2019 09:59, Juergen Gross wrote: >> On 15/01/2019 10:38, Andrew Cooper wrote: >>> On 15/01/2019 09:23, Juergen Gross wrote: Recently there have been several requests to add disclaimers like "only applicable if CONFIG_xyz defined" to docs/m

Re: [Xen-devel] xen-commandline document

2019-01-15 Thread Juergen Gross
On 15/01/2019 11:22, Andrew Cooper wrote: > On 15/01/2019 09:59, Juergen Gross wrote: >> On 15/01/2019 10:38, Andrew Cooper wrote: >>> On 15/01/2019 09:23, Juergen Gross wrote: Recently there have been several requests to add disclaimers like "only applicable if CONFIG_xyz defined" to >>>

Re: [Xen-devel] an assertion triggered when running Xen on a HSW desktop

2019-01-15 Thread Andrew Cooper
On 15/01/2019 10:27, Roger Pau Monné wrote: > On Tue, Jan 15, 2019 at 03:16:01AM -0700, Jan Beulich wrote: > On 15.01.19 at 10:44, wrote: -Original Message- >>> [snip] >> (XEN) Xen call trace: >> (XEN)[] iommu_map+0xba/0x176 >> (XEN)[] iommu_hwdom_init+0xef/0x

Re: [Xen-devel] [PATCH v3] xen: Fix x86 sched_clock() interface for xen

2019-01-15 Thread Thomas Gleixner
On Mon, 14 Jan 2019, Juergen Gross wrote: > Commit f94c8d11699759 ("sched/clock, x86/tsc: Rework the x86 'unstable' > sched_clock() interface") broke Xen guest time handling across > migration: > > [ 187.249951] Freezing user space processes ... (elapsed 0.001 seconds) done. > [ 187.251137] OOM

Re: [Xen-devel] an assertion triggered when running Xen on a HSW desktop

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 11:27, wrote: > On Tue, Jan 15, 2019 at 03:16:01AM -0700, Jan Beulich wrote: >> >>> On 15.01.19 at 10:44, wrote: >> >> -Original Message- >> > [snip] >> >> >> (XEN) Xen call trace: >> >> >> (XEN)[] iommu_map+0xba/0x176 >> >> >> (XEN)[] iommu_hwdom_init+0xef/0x2

Re: [Xen-devel] an assertion triggered when running Xen on a HSW desktop

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 11:42, wrote: > On 15/01/2019 10:27, Roger Pau Monné wrote: >> On Tue, Jan 15, 2019 at 03:16:01AM -0700, Jan Beulich wrote: >> On 15.01.19 at 10:44, wrote: > -Original Message- [snip] >>> (XEN) Xen call trace: >>> (XEN)[] iommu_map+0xba/0x176 >

Re: [Xen-devel] an assertion triggered when running Xen on a HSW desktop

2019-01-15 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 15 January 2019 10:53 > To: Andrew Cooper > Cc: Paul Durrant ; Roger Pau Monne > ; Chao Gao ; xen-devel de...@lists.xenproject.org> > Subject: Re: [Xen-devel] an assertion triggered when running Xen on a HSW > des

Re: [Xen-devel] [PATCH v3] xen: Fix x86 sched_clock() interface for xen

2019-01-15 Thread Juergen Gross
On 15/01/2019 11:43, Thomas Gleixner wrote: > On Mon, 14 Jan 2019, Juergen Gross wrote: > >> Commit f94c8d11699759 ("sched/clock, x86/tsc: Rework the x86 'unstable' >> sched_clock() interface") broke Xen guest time handling across >> migration: >> >> [ 187.249951] Freezing user space processes ..

Re: [Xen-devel] [PATCH] drm: Split out drm_probe_helper.h

2019-01-15 Thread Jani Nikula
On Tue, 15 Jan 2019, Daniel Vetter wrote: > Having the probe helper stuff (which pretty much everyone needs) in > the drm_crtc_helper.h file (which atomic drivers should never need) is > confusing. Split them out. > > To make sure I actually achieved the goal here I went through all > drivers. And

Re: [Xen-devel] an assertion triggered when running Xen on a HSW desktop

2019-01-15 Thread Roger Pau Monné
On Tue, Jan 15, 2019 at 03:49:07AM -0700, Jan Beulich wrote: > >>> On 15.01.19 at 11:27, wrote: > > On Tue, Jan 15, 2019 at 03:16:01AM -0700, Jan Beulich wrote: > >> >>> On 15.01.19 at 10:44, wrote: > >> >> -Original Message- > >> > [snip] > >> >> >> (XEN) Xen call trace: > >> >> >> (XEN

[Xen-devel] [PATCH] tools: only call git when necessary in OVMF Makefile

2019-01-15 Thread Wei Liu
Users may choose to export a snapshot of OVMF and build it with xen.git supplied ovmf-makefile. In that case we don't need to call `git submodule`. Fixes b16281870e. Reported-by: Olaf Hering Signed-off-by: Wei Liu --- tools/firmware/ovmf-makefile | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [Xen-devel] PING ARM [PATCH v2] xen/cmdline: Fix buggy strncmp(s, LITERAL, ss - s) construct

2019-01-15 Thread Julien Grall
Hi Jan, On 1/15/19 8:47 AM, Jan Beulich wrote: On 14.01.19 at 18:16, wrote: Hi Andrew, On 14/01/2019 16:59, Andrew Cooper wrote: On 14/01/2019 16:07, Julien Grall wrote: On 14/01/2019 15:17, Andrew Cooper wrote: diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index c

Re: [Xen-devel] [PATCH] tools: only call git when necessary in OVMF Makefile

2019-01-15 Thread Anthony PERARD
On Tue, Jan 15, 2019 at 11:09:40AM +, Wei Liu wrote: > Users may choose to export a snapshot of OVMF and build it > with xen.git supplied ovmf-makefile. In that case we don't > need to call `git submodule`. > > Fixes b16281870e. > > Reported-by: Olaf Hering > Signed-off-by: Wei Liu Reviewe

[Xen-devel] [linux-next test] 131954: regressions - trouble: blocked/broken/fail/pass

2019-01-15 Thread osstest service owner
flight 131954 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/131954/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm broken test-amd64-amd64-xl-qemuu-debianhvm-amd64-x

Re: [Xen-devel] [PATCH] tools: only call git when necessary in OVMF Makefile

2019-01-15 Thread Andrew Cooper
On 15/01/2019 11:09, Wei Liu wrote: > Users may choose to export a snapshot of OVMF and build it > with xen.git supplied ovmf-makefile. In that case we don't > need to call `git submodule`. > > Fixes b16281870e. > > Reported-by: Olaf Hering > Signed-off-by: Wei Liu > --- > tools/firmware/ovmf-ma

Re: [Xen-devel] [PATCH] tools: only call git when necessary in OVMF Makefile

2019-01-15 Thread Wei Liu
On Tue, Jan 15, 2019 at 11:27:12AM +, Andrew Cooper wrote: > On 15/01/2019 11:09, Wei Liu wrote: > > Users may choose to export a snapshot of OVMF and build it > > with xen.git supplied ovmf-makefile. In that case we don't > > need to call `git submodule`. > > > > Fixes b16281870e. > > > > Repo

Re: [Xen-devel] [PATCH] tools: only call git when necessary in OVMF Makefile

2019-01-15 Thread Andrew Cooper
On 15/01/2019 11:29, Wei Liu wrote: > On Tue, Jan 15, 2019 at 11:27:12AM +, Andrew Cooper wrote: >> On 15/01/2019 11:09, Wei Liu wrote: >>> Users may choose to export a snapshot of OVMF and build it >>> with xen.git supplied ovmf-makefile. In that case we don't >>> need to call `git submodule`.

Re: [Xen-devel] [PATCH] tools: only call git when necessary in OVMF Makefile

2019-01-15 Thread Anthony PERARD
On Tue, Jan 15, 2019 at 11:29:38AM +, Wei Liu wrote: > On Tue, Jan 15, 2019 at 11:27:12AM +, Andrew Cooper wrote: > > On 15/01/2019 11:09, Wei Liu wrote: > > > Users may choose to export a snapshot of OVMF and build it > > > with xen.git supplied ovmf-makefile. In that case we don't > > > n

[Xen-devel] [PATCH] doc: correct default scheduler in xen-command-line.pandoc

2019-01-15 Thread Juergen Gross
We have switched to credit2. Let the documentation reflect that. Signed-off-by: Juergen Gross --- docs/misc/xen-command-line.pandoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index d39bcee928..e24e3a4

Re: [Xen-devel] [PATCH] doc: correct default scheduler in xen-command-line.pandoc

2019-01-15 Thread Wei Liu
On Tue, Jan 15, 2019 at 12:35:10PM +0100, Juergen Gross wrote: > We have switched to credit2. Let the documentation reflect that. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lis

Re: [Xen-devel] PING ARM [PATCH v2] xen/cmdline: Fix buggy strncmp(s, LITERAL, ss - s) construct

2019-01-15 Thread Julien Grall
Hi Andrew, On 1/14/19 5:43 PM, Andrew Cooper wrote: On 14/01/2019 17:16, Julien Grall wrote: Hi Andrew, On 14/01/2019 16:59, Andrew Cooper wrote: On 14/01/2019 16:07, Julien Grall wrote: On 14/01/2019 15:17, Andrew Cooper wrote: diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/ef

Re: [Xen-devel] [PATCH] tools: only call git when necessary in OVMF Makefile

2019-01-15 Thread Wei Liu
On Tue, Jan 15, 2019 at 11:36:42AM +, Anthony PERARD wrote: > On Tue, Jan 15, 2019 at 11:29:38AM +, Wei Liu wrote: > > On Tue, Jan 15, 2019 at 11:27:12AM +, Andrew Cooper wrote: > > > On 15/01/2019 11:09, Wei Liu wrote: > > > > Users may choose to export a snapshot of OVMF and build it

Re: [Xen-devel] [PATCH] doc: correct default scheduler in xen-command-line.pandoc

2019-01-15 Thread Juergen Gross
On 15/01/2019 12:35, Juergen Gross wrote: > We have switched to credit2. Let the documentation reflect that. > > Signed-off-by: Juergen Gross And just for the records: Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@l

Re: [Xen-devel] [PATCH] doc: correct default scheduler in xen-command-line.pandoc

2019-01-15 Thread Andrew Cooper
On 15/01/2019 11:35, Juergen Gross wrote: > We have switched to credit2. Let the documentation reflect that. > > Signed-off-by: Juergen Gross > --- > docs/misc/xen-command-line.pandoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/misc/xen-command-line.pandoc > b/d

Re: [Xen-devel] [PATCH] tools: only call git when necessary in OVMF Makefile

2019-01-15 Thread Juergen Gross
On 15/01/2019 12:40, Wei Liu wrote: > Forgot to CC Juergen. Now done. > > On Tue, Jan 15, 2019 at 11:09:40AM +, Wei Liu wrote: >> Users may choose to export a snapshot of OVMF and build it >> with xen.git supplied ovmf-makefile. In that case we don't >> need to call `git submodule`. >> >> Fixe

Re: [Xen-devel] [PATCH] doc: correct default scheduler in xen-command-line.pandoc

2019-01-15 Thread Juergen Gross
On 15/01/2019 12:38, Andrew Cooper wrote: > On 15/01/2019 11:35, Juergen Gross wrote: >> We have switched to credit2. Let the documentation reflect that. >> >> Signed-off-by: Juergen Gross >> --- >> docs/misc/xen-command-line.pandoc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> d

Re: [Xen-devel] [PATCH] tools: only call git when necessary in OVMF Makefile

2019-01-15 Thread Wei Liu
Forgot to CC Juergen. Now done. On Tue, Jan 15, 2019 at 11:09:40AM +, Wei Liu wrote: > Users may choose to export a snapshot of OVMF and build it > with xen.git supplied ovmf-makefile. In that case we don't > need to call `git submodule`. > > Fixes b16281870e. > > Reported-by: Olaf Hering >

Re: [Xen-devel] [PATCH] doc: correct default scheduler in xen-command-line.pandoc

2019-01-15 Thread Andrew Cooper
On 15/01/2019 11:40, Juergen Gross wrote: > On 15/01/2019 12:38, Andrew Cooper wrote: >> On 15/01/2019 11:35, Juergen Gross wrote: >>> We have switched to credit2. Let the documentation reflect that. >>> >>> Signed-off-by: Juergen Gross >>> --- >>> docs/misc/xen-command-line.pandoc | 2 +- >>> 1

Re: [Xen-devel] [PATCH] doc: correct default scheduler in xen-command-line.pandoc

2019-01-15 Thread Juergen Gross
On 15/01/2019 12:41, Andrew Cooper wrote: > On 15/01/2019 11:40, Juergen Gross wrote: >> On 15/01/2019 12:38, Andrew Cooper wrote: >>> On 15/01/2019 11:35, Juergen Gross wrote: We have switched to credit2. Let the documentation reflect that. Signed-off-by: Juergen Gross --- >>>

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-15 Thread Julien Grall
Hi Stefano, On 1/11/19 9:37 PM, Stefano Stabellini wrote: On Fri, 11 Jan 2019, Stewart Hildebrand wrote: On Friday, January 11, 2019 3:36 PM, Julien Grall wrote: On Fri, 11 Jan 2019, 12:53 Stewart Hildebrand wrote: Why don't we change the type of _start so it's not a pointer type? Can you

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-15 Thread Julien Grall
Hi Jan, On 1/15/19 8:21 AM, Jan Beulich wrote: On 14.01.19 at 22:18, wrote: Hi Jan, One question below to make a decision on the way forward. On Mon, 14 Jan 2019, Jan Beulich wrote: On 14.01.19 at 04:45, wrote: So let's keep the linker-accessible variable as a type that works for the link

Re: [Xen-devel] an assertion triggered when running Xen on a HSW desktop

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 11:55, wrote: > I guess the question is whether we want to allow arbitrary alignment of the > memory passed into iommu_map() or not. If we do then I think a count > parameter makes more sense. Agreed. Till now I simply don't see the use case. Jan _

Re: [Xen-devel] an assertion triggered when running Xen on a HSW desktop

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 12:07, wrote: > On Tue, Jan 15, 2019 at 03:49:07AM -0700, Jan Beulich wrote: >> >>> On 15.01.19 at 11:27, wrote: >> > On Tue, Jan 15, 2019 at 03:16:01AM -0700, Jan Beulich wrote: >> >> >>> On 15.01.19 at 10:44, wrote: >> >> >> -Original Message- >> >> > [snip] >> >> >

Re: [Xen-devel] an assertion triggered when running Xen on a HSW desktop

2019-01-15 Thread Andrew Cooper
On 15/01/2019 11:50, Jan Beulich wrote: > >>> And even >>> if I re-phrased your reply to mean an arbitrary alignment / order >>> less than 9, then populating this with such a smaller order is still >>> fine, and requesting the IOMMU mapping with that smaller order >>> is still not going to trip the

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 12:51, wrote: > Hi Jan, > > On 1/15/19 8:21 AM, Jan Beulich wrote: > On 14.01.19 at 22:18, wrote: >>> Hi Jan, >>> >>> One question below to make a decision on the way forward. >>> >>> On Mon, 14 Jan 2019, Jan Beulich wrote: >>> On 14.01.19 at 04:45, wrote: > So le

[Xen-devel] [PATCH v3 0/4] QEMU changes to do PVH boot

2019-01-15 Thread Liam Merwick
For certain applications it is desirable to rapidly boot a KVM virtual machine. In cases where legacy hardware and software support within the guest is not needed, QEMU should be able to boot directly into the uncompressed Linux kernel binary with minimal firmware involvement. There already exists

[Xen-devel] [PATCH v3 2/5] elf-ops.h: Add get_elf_note_type()

2019-01-15 Thread Liam Merwick
Introduce a routine which, given a pointer to a range of ELF Notes, searches through them looking for a note matching the type specified and returns a pointer to the matching ELF note. get_elf_note_type() is used by elf_load[32|64]() to find the specified note type required by the 'elf_note_fn' pa

[Xen-devel] [PATCH v3 1/5] elf: Add optional function ptr to load_elf() to parse ELF notes

2019-01-15 Thread Liam Merwick
This patch adds an optional function pointer, 'elf_note_fn', to load_elf() which causes load_elf() to additionally parse any ELF program headers of type PT_NOTE and check to see if the ELF Note is of the type specified by the 'translate_opaque' arg. If a matching ELF Note is found then the specfied

[Xen-devel] [PATCH v3 4/5] pvh: Boot uncompressed kernel using direct boot ABI

2019-01-15 Thread Liam Merwick
These changes (along with corresponding Linux kernel and qboot changes) enable a guest to be booted using the x86/HVM direct boot ABI. This commit adds a load_elfboot() routine to pass the size and location of the kernel entry point to qboot (which will fill in the start_info struct information ne

[Xen-devel] [PATCH v3 3/5] pvh: Add x86/HVM direct boot ABI header file

2019-01-15 Thread Liam Merwick
From: Liam Merwick The x86/HVM direct boot ABI permits Qemu to be able to boot directly into the uncompressed Linux kernel binary with minimal firmware involvement. https://xenbits.xen.org/docs/unstable/misc/pvh.html This commit adds the header file that defines the start_info struct th

[Xen-devel] [PATCH v3 5/5] pvh: load initrd and expose it through fw_cfg

2019-01-15 Thread Liam Merwick
From: Stefano Garzarella When initrd is specified, load and expose it to the guest firmware through fw_cfg. The firmware will fill the hvm_start_info for the kernel. Signed-off-by: Stefano Garzarella Based-on: <1545422632-2-5-git-send-email-liam.merw...@oracle.com> Signed-off-by: Liam Merwi

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-15 Thread Julien Grall
Hi, On 1/15/19 12:04 PM, Jan Beulich wrote: On 15.01.19 at 12:51, wrote: Hi Jan, On 1/15/19 8:21 AM, Jan Beulich wrote: On 14.01.19 at 22:18, wrote: Hi Jan, One question below to make a decision on the way forward. On Mon, 14 Jan 2019, Jan Beulich wrote: On 14.01.19 at 04:45, wrote: S

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-15 Thread Julien Grall
Hi, On 1/15/19 11:46 AM, Julien Grall wrote: Hi Stefano, On 1/11/19 9:37 PM, Stefano Stabellini wrote: On Fri, 11 Jan 2019, Stewart Hildebrand wrote: On Friday, January 11, 2019 3:36 PM, Julien Grall wrote: On Fri, 11 Jan 2019, 12:53 Stewart Hildebrand wrote: Why don't we change the type o

Re: [Xen-devel] [PATCH] drm: Split out drm_probe_helper.h

2019-01-15 Thread Neil Armstrong
On 15/01/2019 11:41, Daniel Vetter wrote: > Having the probe helper stuff (which pretty much everyone needs) in > the drm_crtc_helper.h file (which atomic drivers should never need) is > confusing. Split them out. > > To make sure I actually achieved the goal here I went through all > drivers. And

Re: [Xen-devel] [PATCH v4 04/14] argo: init, destroy and soft-reset, with enable command line opt

2019-01-15 Thread Roger Pau Monné
On Tue, Jan 15, 2019 at 01:27:36AM -0800, Christopher Clark wrote: > Initialises basic data structures and performs teardown of argo state > for domain shutdown. > > Inclusion of the Argo implementation is dependent on CONFIG_ARGO. > > Introduces a new Xen command line parameter 'argo': bool to e

Re: [Xen-devel] [PATCH v4 04/14] argo: init, destroy and soft-reset, with enable command line opt

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 13:29, wrote: > On Tue, Jan 15, 2019 at 01:27:36AM -0800, Christopher Clark wrote: >> long >> do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1, >> XEN_GUEST_HANDLE_PARAM(void) arg2, unsigned long arg3, >> unsigned long arg4) >> { >> -

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 13:23, wrote: > Hi, > > On 1/15/19 12:04 PM, Jan Beulich wrote: > On 15.01.19 at 12:51, wrote: >>> Hi Jan, >>> >>> On 1/15/19 8:21 AM, Jan Beulich wrote: >>> On 14.01.19 at 22:18, wrote: > Hi Jan, > > One question below to make a decision on the way forwar

Re: [Xen-devel] [PATCH 2/5] xen/arm: assign devices to boot domains

2019-01-15 Thread Julien Grall
Hi, On 1/3/19 10:07 PM, Stefano Stabellini wrote: On Mon, 24 Dec 2018, Julien Grall wrote: Hi Stefano, On 12/5/18 5:28 PM, Stefano Stabellini wrote: Scan the user provided dtb fragment at boot. For each device node, map memory to guests, and route interrupts and setup the iommu. Device memor

Re: [Xen-devel] [PATCH 03/15] x86/cpu/vpmu: Add Hygon Dhyana support for vPMU

2019-01-15 Thread Pu Wen
On 2019/1/15 0:47, Jan Beulich wrote: On 20.12.18 at 14:12, wrote: >> --- a/xen/arch/x86/cpu/vpmu.c >> +++ b/xen/arch/x86/cpu/vpmu.c >> @@ -473,6 +473,7 @@ static int vpmu_arch_initialise(struct vcpu *v) >> >> switch ( vendor ) >> { >> +case X86_VENDOR_HYGON: >> case

Re: [Xen-devel] [PATCH 04/15] x86/cpu/mce: Add Hygon Dhyana support to the MCA infrastructure

2019-01-15 Thread Pu Wen
On 2019/1/15 0:47, Jan Beulich wrote: On 20.12.18 at 14:12, wrote: >> --- a/xen/arch/x86/cpu/mcheck/mce_amd.c >> +++ b/xen/arch/x86/cpu/mcheck/mce_amd.c >> @@ -162,7 +162,8 @@ mcequirk_lookup_amd_quirkdata(struct cpuinfo_x86 *c) >> { >> int i; >> >> -BUG_ON(c->x86_vendor != X86

Re: [Xen-devel] [PATCH 4/5] xen/arm: use the physical number of gic lines for boot domains

2019-01-15 Thread Julien Grall
Hi Stefano, On 1/3/19 7:07 PM, Stefano Stabellini wrote: On Mon, 24 Dec 2018, Julien Grall wrote: Hi, On 12/5/18 5:28 PM, Stefano Stabellini wrote: We don't have a clear way to know how many virtual SPIs we need for the boot domains. For simplicity, allocate as many as natively supported, jus

  1   2   >