[Xen-devel] [ovmf test] 130750: regressions - FAIL

2018-11-26 Thread osstest service owner
flight 130750 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/130750/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 129475 build-i386

[Xen-devel] [xen-4.9-testing test] 130745: regressions - trouble: blocked/broken/fail/pass

2018-11-26 Thread osstest service owner
flight 130745 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/130745/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-pvops

Re: [Xen-devel] [PATCH v5 6/6] amd/iommu: skip bridge devices when updating IOMMU page tables

2018-11-26 Thread Jan Beulich
>>> On 23.11.18 at 15:36, wrote: > On Thu, Nov 22, 2018 at 06:20:46AM -0700, Jan Beulich wrote: >> >>> On 22.11.18 at 13:47, wrote: >> > I think the is_hardware_domain part can be dropped from the >> > conditional I'm adding. update_paging_mode shouldn't be used to decide >> > whether a domain ca

[Xen-devel] [xen-unstable-smoke test] 130805: regressions - trouble: blocked/broken/fail/pass

2018-11-26 Thread osstest service owner
flight 130805 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130805/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-amd64 6 xen

[Xen-devel] [PATCH] CODING_STYLE: explicitly call out label indentation

2018-11-26 Thread Jan Beulich
Since the behavior of "diff -p" to use an unindented label as context identifier often makes it harder to review patches, make explicit the requirement for labels to be indented. Signed-off-by: Jan Beulich --- a/CODING_STYLE +++ b/CODING_STYLE @@ -31,6 +31,10 @@ void fun(void) } } +Due t

[Xen-devel] [PATCH 2/2] amd-iommu: replace occurrences of u with uint_t...

2018-11-26 Thread Paul Durrant
...for N in {8, 16, 32, 64}. Bring the coding style up to date. No functional change. Also, while in the neighbourhood, fix some tabs. Signed-off-by: Paul Durrant --- Cc: Suravee Suthikulpanit Cc: Brian Woods --- xen/drivers/passthrough/amd/iommu_map.c | 115

[Xen-devel] [PATCH 1/2] amd-iommu: replace occurrences of bool_t with bool

2018-11-26 Thread Paul Durrant
Bring the coding style up to date. No functional change. Signed-off-by: Paul Durrant --- Cc: Suravee Suthikulpanit Cc: Brian Woods --- xen/drivers/passthrough/amd/iommu_map.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/xen/drivers/passthrough/

Re: [Xen-devel] [PATCH 03/14] AMD/IOMMU: Fix multiple reference counting errors

2018-11-26 Thread Jan Beulich
>>> On 23.11.18 at 17:03, wrote: > On 23/11/2018 08:23, Jan Beulich wrote: > On 22.11.18 at 18:46, wrote: >>> On 22/11/2018 14:51, Jan Beulich wrote: > @@ -220,12 +219,18 @@ void guest_iommu_add_ppr_log(struct domain *d, u32 > entry[]) > unmap_domain_page(log_base); >

[Xen-devel] [PATCH 0/2] amd-iommu: cosmetic fixes

2018-11-26 Thread Paul Durrant
No functional change. Paul Durrant (2): amd-iommu: replace occurrences of bool_t with bool amd-iommu: replace occurrences of u with uint_t... xen/drivers/passthrough/amd/iommu_map.c | 137 1 file changed, 70 insertions(+), 67 deletions(-) --- Cc: Suravee Su

[Xen-devel] [PATCH v2] CODING_STYLE: document intended usage of types

2018-11-26 Thread Jan Beulich
Signed-off-by: Jan Beulich --- v2: Drop signed-ness requirement. --- a/CODING_STYLE +++ b/CODING_STYLE @@ -88,6 +88,19 @@ Braces should be omitted for blocks with if ( condition ) single_statement(); +Types +- + +Use basic C types and C standard mandated typedef-s where possible (and

Re: [Xen-devel] [PATCH 1/2] amd-iommu: replace occurrences of bool_t with bool

2018-11-26 Thread Jan Beulich
>>> On 26.11.18 at 10:05, wrote: > @@ -123,13 +123,13 @@ static bool_t set_iommu_pde_present(u32 *pde, unsigned > long next_mfn, > return need_flush; > } > > -static bool_t set_iommu_pte_present(unsigned long pt_mfn, unsigned long dfn, > -unsigned long

Re: [Xen-devel] [PATCH 1/2] amd-iommu: replace occurrences of bool_t with bool

2018-11-26 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 26 November 2018 09:39 > To: Paul Durrant > Cc: Brian Woods ; Suravee Suthikulpanit > ; xen-devel de...@lists.xenproject.org> > Subject: Re: [Xen-devel] [PATCH 1/2] amd-iommu: replace occurrences of > bool_t with

Re: [Xen-devel] [PATCH 2/2] amd-iommu: replace occurrences of u with uint_t...

2018-11-26 Thread Jan Beulich
>>> On 26.11.18 at 10:05, wrote: > @@ -127,24 +127,25 @@ static bool set_iommu_pte_present(unsigned long pt_mfn, > unsigned long dfn, >unsigned long next_mfn, int pde_level, >bool iw, bool ir) > { > -u64 *table; > -u

Re: [Xen-devel] [PATCH 1/2] amd-iommu: replace occurrences of bool_t with bool

2018-11-26 Thread Jan Beulich
>>> On 26.11.18 at 10:40, wrote: > Thanks. Are you happy to fix up on commit or would you like a v2? To be honest in this case I'd prefer a v2. Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listin

Re: [Xen-devel] [PATCH 1/2] amd-iommu: replace occurrences of bool_t with bool

2018-11-26 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 26 November 2018 09:51 > To: Paul Durrant > Cc: Brian Woods ; Suravee Suthikulpanit > ; xen-devel de...@lists.xenproject.org> > Subject: RE: [Xen-devel] [PATCH 1/2] amd-iommu: replace occurrences of > bool_t with

Re: [Xen-devel] [PATCH 2/2] amd-iommu: replace occurrences of u with uint_t...

2018-11-26 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 26 November 2018 09:46 > To: Paul Durrant > Cc: Brian Woods ; Suravee Suthikulpanit > ; xen-devel de...@lists.xenproject.org> > Subject: Re: [Xen-devel] [PATCH 2/2] amd-iommu: replace occurrences of > u with uint_

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-26 Thread Jan Beulich
>>> On 23.11.18 at 15:30, wrote: > LLVM code generation can attempt to load from a variable in the next > condition of an expression under certain circumstances, thus turning > the following condition: > > if ( system_state < SYS_STATE_active && opt_bootscrub == BOOTSCRUB_IDLE ) > > Into: > > 0

Re: [Xen-devel] [PATCH v3] tools: set Dom0 UUID if requested

2018-11-26 Thread Wei Liu
On Fri, Nov 23, 2018 at 06:35:18PM +0100, Roger Pau Monné wrote: > On Fri, Nov 23, 2018 at 04:25:00PM +, Wei Liu wrote: > > On Fri, Nov 23, 2018 at 04:18:41PM +, Wei Liu wrote: > > > On Fri, Nov 23, 2018 at 03:28:49PM +, Anthony PERARD wrote: > > > > > diff --git a/tools/hotplug/Linux/s

Re: [Xen-devel] [PATCH v1] Increase framebuffer size to todays standards

2018-11-26 Thread Jan Beulich
>>> On 25.11.18 at 20:14, wrote: > My notebook reports a display size of 1920x1080: > > (XEN) vesafb: framebuffer at 0xd000, mapped to 0x82c000201000, using > 8128k, total 8128k > (XEN) vesafb: mode is 1920x1080x32, linelength=7680, font 8x16 > (XEN) vesafb: Truecolor: size=8:8:8:8, shif

[Xen-devel] [PATCH v4] tools: set Dom0 UUID if requested

2018-11-26 Thread Wei Liu
Introduce XEN_DOM0_UUID in Xen's global configuration file. Make xen-init-dom0 accept an extra argument for UUID. Also switch xs_open error message to use perror. Signed-off-by: Wei Liu Reviewed-by: Juergen Gross Reviewed-by: Sergey Dyasli --- v4: 1. use perror 2. added Rb from Juergen and Se

[Xen-devel] [distros-debian-sid test] 75621: tolerable FAIL

2018-11-26 Thread Platform Team regression test user
flight 75621 distros-debian-sid real [real] http://osstest.xensource.com/osstest/logs/75621/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-i386-sid-netboot-pvgrub 10 debian-di-install fail like 75589 test-armhf-armhf-armhf-sid-netboot-pygr

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-26 Thread Jan Beulich
>>> On 23.11.18 at 14:25, wrote: > In debug builds the hypervisor will deliberately clobber processed > elements of the multicall structure. In order to ease diagnostic data > printout in the affected guest only clobber elements which didn't > return an error. Besides what Andrew has said such a

Re: [Xen-devel] [PATCH v5 1/6] vpci: fix updating the command register

2018-11-26 Thread Jan Beulich
>>> On 20.11.18 at 17:01, wrote: > When switching the memory decoding bit in the command register the > rest of the changes where dropped, leading to only the memory decoding > bit being updated. > > Fix this by writing the command register once the guest physmap > manipulations are done if there

Re: [Xen-devel] [osstest test] 130741: regressions - FAIL

2018-11-26 Thread Ian Jackson
osstest service owner writes ("[osstest test] 130741: regressions - FAIL"): > flight 130741 osstest real [real] > http://logs.test-lab.xenproject.org/osstest/logs/130741/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-

Re: [Xen-devel] [PATCH v5 2/6] vpci: fix deferral of long operations

2018-11-26 Thread Jan Beulich
>>> On 20.11.18 at 17:01, wrote: > Current logic to handle long running operations is flawed because it > doesn't prevent the guest vcpu from running. Fix this by raising a > scheduler softirq when preemption is required, so that the do_softirq > call in the guest entry path performs a reschedulin

[Xen-devel] [xen-unstable-smoke test] 130808: regressions - trouble: blocked/broken/fail/pass

2018-11-26 Thread osstest service owner
flight 130808 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130808/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-amd64 6 xen

Re: [Xen-devel] [PATCH v5 4/6] pci: add a segment parameter to pci_hide_device

2018-11-26 Thread Jan Beulich
>>> On 20.11.18 at 17:01, wrote: > No functional change expected. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH v2 0/2] amd-iommu: cosmetic fixes

2018-11-26 Thread Paul Durrant
Paul Durrant (2): amd-iommu: replace occurrences of bool_t with bool amd-iommu: replace occurrences of u with uint_t... xen/drivers/passthrough/amd/iommu_map.c | 148 +- xen/include/asm-x86/hvm/svm/amd-iommu-proto.h | 2 +- 2 files changed, 77 insertions(+), 73

[Xen-devel] [PATCH v2 2/2] amd-iommu: replace occurrences of u with uint_t...

2018-11-26 Thread Paul Durrant
...for N in {8, 16, 32, 64}. Bring the coding style up to date. Also, while in the neighbourhood, fix some tabs and remove use of uint64_t values where it leads to the need for explicit casting. Signed-off-by: Paul Durrant --- Cc: Suravee Suthikulpanit Cc: Brian Woods v2: - Remove some uses

[Xen-devel] [PATCH v2 1/2] amd-iommu: replace occurrences of bool_t with bool

2018-11-26 Thread Paul Durrant
Bring the coding style up to date. No functional change (except for removal of some pointless initializers). Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich --- Cc: Suravee Suthikulpanit Cc: Brian Woods --- xen/drivers/passthrough/amd/iommu_map.c | 26 +- 1 file c

Re: [Xen-devel] [PATCH v5 2/6] vpci: fix deferral of long operations

2018-11-26 Thread Jan Beulich
>>> On 20.11.18 at 17:01, wrote: > Current logic to handle long running operations is flawed because it > doesn't prevent the guest vcpu from running. Fix this by raising a > scheduler softirq when preemption is required, so that the do_softirq > call in the guest entry path performs a reschedulin

Re: [Xen-devel] [PATCH v2 2/2] amd-iommu: replace occurrences of u with uint_t...

2018-11-26 Thread Jan Beulich
>>> On 26.11.18 at 12:32, wrote: > @@ -306,7 +307,8 @@ void iommu_dte_set_guest_cr3(u32 *dte, u16 dom_id, u64 > gcr3, > uint64_t amd_iommu_get_address_from_pte(void *pte) > { > uint32_t *entry = pte; > -uint64_t addr_lo, addr_hi, ptr; > +uint32_t addr_lo, addr_hi; > +uint64_t p

Re: [Xen-devel] [PATCH v2 2/2] amd-iommu: replace occurrences of u with uint_t...

2018-11-26 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 26 November 2018 11:49 > To: Paul Durrant > Cc: Brian Woods ; Suravee Suthikulpanit > ; xen-devel de...@lists.xenproject.org> > Subject: Re: [Xen-devel] [PATCH v2 2/2] amd-iommu: replace occurrences of > u with ui

Re: [Xen-devel] [PATCH v5 2/6] vpci: fix deferral of long operations

2018-11-26 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 26 November 2018 11:42 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; Roger Pau Monne ; Wei > Liu ; George Dunlap ; Ian > Jackson ; Stefano Stabellini > ; xen-devel ; > Konrad Rzeszutek Wilk ; Tim (Xen.o

[Xen-devel] [PATCH] xen/tools: Fix gen-cpuid.py's ability to report errors

2018-11-26 Thread Andrew Cooper
c/s 18596903 "xen/tools: support Python 2 and Python 3" unfortunately introduced a TypeError when changing how Fail exceptions were printed: /local/xen.git/xen/../xen/tools/gen-cpuid.py:Traceback (most recent call last): File "/local/xen.git/xen/../xen/tools/gen-cpuid.py", line 483, in

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-26 Thread Roger Pau Monné
On Mon, Nov 26, 2018 at 03:06:16AM -0700, Jan Beulich wrote: > >>> On 23.11.18 at 15:30, wrote: > > LLVM code generation can attempt to load from a variable in the next > > condition of an expression under certain circumstances, thus turning > > the following condition: > > > > if ( system_state

Re: [Xen-devel] [PATCH V9 6/7] p2m: Always use hostp2m when clipping rangesets

2018-11-26 Thread Jan Beulich
>>> On 22.11.18 at 12:40, wrote: > The logdirty rangesets of the altp2ms need to be kept in sync with the > hostp2m. This means when iterating through the altp2ms, we need to > use the host p2m to clip the rangeset, not the indiviual altp2m's > value. > > This change also: > > - Documents that

Re: [Xen-devel] [PATCH V9 5/7] x86/altp2m: fix display frozen when switching to a new view early

2018-11-26 Thread Jan Beulich
>>> On 22.11.18 at 12:40, wrote: > @@ -956,18 +1003,14 @@ int p2m_change_type_one(struct domain *d, unsigned > long gfn_l, > } > > /* Modify the p2m type of a range of gfns from ot to nt. */ > -void p2m_change_type_range(struct domain *d, > - unsigned long start, un

[Xen-devel] drm_gem_get_pages and proper flushing/coherency

2018-11-26 Thread Oleksandr Andrushchenko
Hello, all! My driver (Xen para-virtualized frontend) in some scenarios uses drm_gem_get_pages for allocating backing storage for dumb buffers. There are use-cases which showed some artifacts on the screen (modetest, other) which were worked around by flushing pages of the buffer on page flip wit

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-26 Thread Jan Beulich
>>> On 26.11.18 at 13:04, wrote: > On Mon, Nov 26, 2018 at 03:06:16AM -0700, Jan Beulich wrote: >> >>> On 23.11.18 at 15:30, wrote: >> > LLVM code generation can attempt to load from a variable in the next >> > condition of an expression under certain circumstances, thus turning >> > the followin

Re: [Xen-devel] [PATCH] xen/tools: Fix gen-cpuid.py's ability to report errors

2018-11-26 Thread Wei Liu
On Mon, Nov 26, 2018 at 12:03:07PM +, Andrew Cooper wrote: > c/s 18596903 "xen/tools: support Python 2 and Python 3" unfortunately > introduced a TypeError when changing how Fail exceptions were printed: > > /local/xen.git/xen/../xen/tools/gen-cpuid.py:Traceback (most recent call > last): >

Re: [Xen-devel] [PATCH v2 4/5] x86/msr: Handle MSR_TSC_AUX consistently for PV and HVM guests

2018-11-26 Thread Jan Beulich
>>> On 20.11.18 at 15:37, wrote: > With PVRDTSCP mode removed, handling of MSR_TSC_AUX can move into the common > code. Move its storage into struct vcpu_msrs (dropping the HVM-specific > msr_tsc_aux), and add an RDPID feature check as this bit also enumerates the > presence of the MSR. > > Intr

Re: [Xen-devel] [PATCH v4] tools: set Dom0 UUID if requested

2018-11-26 Thread Anthony PERARD
On Mon, Nov 26, 2018 at 10:40:44AM +, Wei Liu wrote: > Introduce XEN_DOM0_UUID in Xen's global configuration file. Make > xen-init-dom0 accept an extra argument for UUID. > > Also switch xs_open error message to use perror. > > Signed-off-by: Wei Liu > Reviewed-by: Juergen Gross > Reviewed

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-26 Thread Julien Grall
Hi Jan, On 26/11/2018 12:18, Jan Beulich wrote: On 26.11.18 at 13:04, wrote: On Mon, Nov 26, 2018 at 03:06:16AM -0700, Jan Beulich wrote: On 23.11.18 at 15:30, wrote: LLVM code generation can attempt to load from a variable in the next condition of an expression under certain circumstances,

Re: [Xen-devel] [PATCH RFC] mm/memory_hotplug: Introduce memory block types

2018-11-26 Thread David Hildenbrand
On 23.11.18 19:06, Michal Suchánek wrote: > On Fri, 23 Nov 2018 12:13:58 +0100 > David Hildenbrand wrote: > >> On 28.09.18 17:03, David Hildenbrand wrote: >>> How to/when to online hotplugged memory is hard to manage for >>> distributions because different memory types are to be treated different

[Xen-devel] [xen-4.11-testing test] 130752: trouble: blocked/broken/fail/pass

2018-11-26 Thread osstest service owner
flight 130752 xen-4.11-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/130752/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken build-arm64-xsm

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-26 Thread Jan Beulich
>>> On 26.11.18 at 13:25, wrote: > May I ask what are the downsides? Do you expect a lot of false positive? Having to split code paths, to introduce redundancy, or to move code/data out of .init.* that could in fact live there are all possible issues. Plus the __ref{,data} annotation that Linux h

Re: [Xen-devel] [PATCH] xen/tools: Fix gen-cpuid.py's ability to report errors

2018-11-26 Thread Jan Beulich
>>> On 26.11.18 at 13:17, wrote: > On Mon, Nov 26, 2018 at 12:03:07PM +, Andrew Cooper wrote: >> c/s 18596903 "xen/tools: support Python 2 and Python 3" unfortunately >> introduced a TypeError when changing how Fail exceptions were printed: >> >> /local/xen.git/xen/../xen/tools/gen-cpuid.py

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-26 Thread Roger Pau Monné
On Mon, Nov 26, 2018 at 05:18:20AM -0700, Jan Beulich wrote: > >>> On 26.11.18 at 13:04, wrote: > > On Mon, Nov 26, 2018 at 03:06:16AM -0700, Jan Beulich wrote: > >> >>> On 23.11.18 at 15:30, wrote: > >> > LLVM code generation can attempt to load from a variable in the next > >> > condition of an

Re: [Xen-devel] [PATCH V9 7/7] p2m: change_range_type: Only invalidate mapped gfns

2018-11-26 Thread Jan Beulich
>>> On 22.11.18 at 12:40, wrote: > change_range_type() invalidates gfn ranges to lazily change the type Would you mind correcting the function name here? > of a range of gfns, and also modifies the logdirty rangesets of that > p2m. At the moment, it clips both down by the hostp2m. > > While thi

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-26 Thread Jan Beulich
>>> On 26.11.18 at 13:49, wrote: > On Mon, Nov 26, 2018 at 05:18:20AM -0700, Jan Beulich wrote: >> Furthermore I doubt writing this down would help, because for >> such apparently simple things no-one goes hunt for related >> documentation. I think the only future proof course of action >> would b

Re: [Xen-devel] [PATCH 1/4] xen/arch: Switch local_*_is_enabled() predicates to return bool

2018-11-26 Thread Jan Beulich
>>> On 23.11.18 at 17:52, wrote: > No functional change, as the value returned was previously always 0 or 1. > While altering these, insert blank lines where appropriate and drop the > now-redundant !! from x86's local_irq_is_enabled(). > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

[Xen-devel] x86_emulator distclean failing

2018-11-26 Thread Paul Durrant
Anyone else seeing this, or is it just me? This was on a fresh pull of staging about 5 mins ago... make -C x86_emulator distclean make[5]: Entering directory '/local/scratch/pauldu/xen/tools/tests/x86_emulator' make -C 32 clean make[6]: Entering directory '/local/scratch/pauldu/xen/tools/tests/x

Re: [Xen-devel] [PATCH 2/4] xen/arch: Switch local_save_flags() to being a static inline helper

2018-11-26 Thread Jan Beulich
>>> On 23.11.18 at 17:52, wrote: > --- a/xen/include/asm-x86/system.h > +++ b/xen/include/asm-x86/system.h > @@ -253,14 +253,18 @@ static inline unsigned long > array_index_mask_nospec(unsigned long index, > /* used when interrupts are already enabled or to shutdown the processor */ > #define h

Re: [Xen-devel] [PATCH for-3.2 v3 10/14] qdev-props: call object_apply_global_props()

2018-11-26 Thread Igor Mammedov
On Wed, 7 Nov 2018 16:36:48 +0400 Marc-André Lureau wrote: > It's now possible to use the common function. > > Teach object_apply_global_props() to warn if Error argument is NULL. > > Signed-off-by: Marc-André Lureau > --- > hw/core/qdev-properties.c | 24 ++-- > qom/obje

[Xen-devel] [PATCH] tools/xenstore: domain can sometimes disappear when destroying connection

2018-11-26 Thread Petre Eftime
There is a circular link formed between domain and a connection. In certain circustances, when conn is freed, domain is also freed, which leads to use after free when trying to set the conn field in domain to null. Signed-off-by: Petre Eftime --- tools/xenstore/xenstored_domain.c | 9 -

Re: [Xen-devel] [PATCH 3/4] xen/arch: Switch local_irq_save() to being a static inline helper

2018-11-26 Thread Jan Beulich
>>> On 23.11.18 at 17:52, wrote: > ... rather than a macro which writes to its parameter by name. Take the > opportunity to fold the assignment into the flags declaraion where > appropriate. Do you really? Why not ... > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -401,7 +401,7 @@ voi

Re: [Xen-devel] [PATCH 4/4] xen/arch: Switch local_irq_restore() to being a static inline helper

2018-11-26 Thread Jan Beulich
>>> On 23.11.18 at 17:52, wrote: > RFC, as I expect this patch to get some objection for removing the IRQ safety > check, but the only reasons that change was made in e5fc6434d7 was because I > talk talked into doing it while trying to clean up some unnecessary use of > magic numbers. > > No user

Re: [Xen-devel] [PATCH RFC] mm/memory_hotplug: Introduce memory block types

2018-11-26 Thread David Hildenbrand
On 26.11.18 13:30, David Hildenbrand wrote: > On 23.11.18 19:06, Michal Suchánek wrote: >> On Fri, 23 Nov 2018 12:13:58 +0100 >> David Hildenbrand wrote: >> >>> On 28.09.18 17:03, David Hildenbrand wrote: How to/when to online hotplugged memory is hard to manage for distributions because

Re: [Xen-devel] x86_emulator distclean failing

2018-11-26 Thread Jan Beulich
>>> On 26.11.18 at 14:04, wrote: > Anyone else seeing this, or is it just me? This was on a fresh pull of > staging about 5 mins ago... I don't think I ever ran distclean, but I think I can see the issue. Would you mind trying --- a/tools/tests/x86_emulator/Makefile +++ b/tools/tests/x86_emulat

Re: [Xen-devel] x86_emulator distclean failing

2018-11-26 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Jan Beulich > Sent: 26 November 2018 13:41 > To: Paul Durrant > Cc: xen-devel > Subject: Re: [Xen-devel] x86_emulator distclean failing > > >>> On 26.11.18 at 14:04, wrote: > > Anyone e

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-26 Thread Juergen Gross
On 26/11/2018 11:58, Jan Beulich wrote: On 23.11.18 at 14:25, wrote: >> In debug builds the hypervisor will deliberately clobber processed >> elements of the multicall structure. In order to ease diagnostic data >> printout in the affected guest only clobber elements which didn't >> return an

Re: [Xen-devel] [Qemu-devel] [PATCH for-3.2 v3 00/14] Generalize machine compatibility properties

2018-11-26 Thread Igor Mammedov
On Wed, 7 Nov 2018 16:36:38 +0400 Marc-André Lureau wrote: > Hi, > > During "[PATCH v2 05/10] qom/globals: generalize > object_property_set_globals()" review, Eduardo suggested to rework the > GlobalProperty handling, so that -global is limited to QDev only and > we avoid mixing the machine com

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-26 Thread Jan Beulich
>>> On 26.11.18 at 14:52, wrote: > I don't think the hypervisor should explicitly try to make it as hard as > possible for the guest to find problems in the code. That's indeed not the hypervisor's goal. Instead it tries to make it as hard as possible for the guest (developer) to make wrong assum

[Xen-devel] [PATCH] x86emul: fix test harness 32-bit "clean" target handling

2018-11-26 Thread Jan Beulich
When preparing what is now 52c37f7ab9 ("x86emul: also allow running the 32-bit harness on a 64-bit distro") I first wrongly used XEN_TARGET_ARCH instead of XEN_COMPILE_ARCH. When realizing the mistake I forgot to also switch around the use in the expression controlling the rule dependencies, causin

Re: [Xen-devel] [PATCH] x86emul: fix test harness 32-bit "clean" target handling

2018-11-26 Thread Andrew Cooper
On 26/11/2018 14:13, Jan Beulich wrote: > When preparing what is now 52c37f7ab9 ("x86emul: also allow running the > 32-bit harness on a 64-bit distro") I first wrongly used XEN_TARGET_ARCH > instead of XEN_COMPILE_ARCH. When realizing the mistake I forgot to also > switch around the use in the expr

Re: [Xen-devel] [PATCH RFC] mm/memory_hotplug: Introduce memory block types

2018-11-26 Thread Michal Suchánek
On Mon, 26 Nov 2018 14:33:29 +0100 David Hildenbrand wrote: > On 26.11.18 13:30, David Hildenbrand wrote: > > On 23.11.18 19:06, Michal Suchánek wrote: > >> > >> If we are going to fake the driver information we may as well add the > >> type attribute and be done with it. > >> > >> I think the

[Xen-devel] [xen-unstable-smoke test] 130811: regressions - FAIL

2018-11-26 Thread osstest service owner
flight 130811 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130811/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 130289 Tests which

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-26 Thread Juergen Gross
On 26/11/2018 15:01, Jan Beulich wrote: On 26.11.18 at 14:52, wrote: >> I don't think the hypervisor should explicitly try to make it as hard as >> possible for the guest to find problems in the code. > > That's indeed not the hypervisor's goal. Instead it tries to make > it as hard as possi

Re: [Xen-devel] [PATCH] x86emul: fix test harness 32-bit "clean" target handling

2018-11-26 Thread Wei Liu
On Mon, Nov 26, 2018 at 07:13:33AM -0700, Jan Beulich wrote: > When preparing what is now 52c37f7ab9 ("x86emul: also allow running the > 32-bit harness on a 64-bit distro") I first wrongly used XEN_TARGET_ARCH > instead of XEN_COMPILE_ARCH. When realizing the mistake I forgot to also > switch aroun

Re: [Xen-devel] [PATCH v2 20/21] xen_backend: remove xen_sysdev_init() function

2018-11-26 Thread Anthony PERARD
On Fri, Nov 23, 2018 at 11:30:39PM +0800, Mao Zhongyi wrote: > The init function doesn't do anything at all, so we > just omit it. > > Cc: sstabell...@kernel.org > Cc: anthony.per...@citrix.com > Cc: xen-devel@lists.xenproject.org > Cc: peter.mayd...@linaro.org > > Signed-off-by: Mao Zhongyi > S

Re: [Xen-devel] qemu assert in staging during HVM live migration

2018-11-26 Thread Anthony PERARD
On Fri, Nov 23, 2018 at 04:57:08PM +0100, Olaf Hering wrote: > Am Fri, 23 Nov 2018 15:54:49 + > schrieb Anthony PERARD : > > > Is your toolstack runs the QMP command 'query-block' or some other > > command related to block behind libxl's back? > > This is plain xl create + xl migrate from sta

[Xen-devel] [PATCH] viridian: fix assertion failure

2018-11-26 Thread Paul Durrant
Whilst attempting to crash an apparently wedged Windows domain using 'xen-hvmcrash' I managed to trigger the following ASSERT: (XEN) Assertion '!vp->ptr' failed at viridian.c:607 with stack: (XEN)[] viridian_map_guest_page+0x1b4/0x1b6 (XEN)[] viridian_synic_load_vcpu_ctxt+0x39/0x3b (XEN)

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-26 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH] xen: only clobber multicall elements without error"): > On 23.11.18 at 14:25, wrote: > > In debug builds the hypervisor will deliberately clobber processed > > elements of the multicall structure. In order to ease diagnostic data > > printout in the affected guest

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-26 Thread Jan Beulich
>>> On 26.11.18 at 15:23, wrote: > On 26/11/2018 15:01, Jan Beulich wrote: > On 26.11.18 at 14:52, wrote: >>> I don't think the hypervisor should explicitly try to make it as hard as >>> possible for the guest to find problems in the code. >> >> That's indeed not the hypervisor's goal. Inste

[Xen-devel] [PATCH v1] xl: free bitmaps on exit

2018-11-26 Thread Olaf Hering
Every invocation of xl via valgrind will show three leaks. Since libxl_bitmap_alloc uses NOGC, the caller has to free the memory after use. Signed-off-by: Olaf Hering --- tools/xl/xl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/xl/xl.c b/tools/xl/xl.c index 7d2142f16f..9756a835

Re: [Xen-devel] [PATCH v1] xl: free bitmaps on exit

2018-11-26 Thread Olaf Hering
Am Mon, 26 Nov 2018 15:58:22 +0100 schrieb Olaf Hering : > +++ b/tools/xl/xl.c > @@ -229,6 +229,9 @@ static void parse_global_config(const char *configfile, Actually I think that should go to xl_ctx_free() instead. I moved it down to parse_global_config() by accident. Olaf pgptRsIXARFmB.pgp D

Re: [Xen-devel] [PATCH] viridian: fix assertion failure

2018-11-26 Thread Roger Pau Monné
On Mon, Nov 26, 2018 at 02:54:54PM +, Paul Durrant wrote: > Whilst attempting to crash an apparently wedged Windows domain using > 'xen-hvmcrash' I managed to trigger the following ASSERT: > > (XEN) Assertion '!vp->ptr' failed at viridian.c:607 > > with stack: > > (XEN)[] viridian_map_gu

Re: [Xen-devel] [PATCH for-3.1] hw/xen/xen_pt_graphics: Don't trust the BIOS ROM contents so much

2018-11-26 Thread Anthony PERARD
On Mon, Nov 19, 2018 at 04:26:58PM +, Peter Maydell wrote: > Coverity (CID 796599) points out that xen_pt_setup_vga() trusts > the rom->size field in the BIOS ROM from a PCI passthrough VGA > device, and uses it as an index into the memory which contains > the BIOS image. A corrupt BIOS ROM cou

Re: [Xen-devel] [PATCH] viridian: fix assertion failure

2018-11-26 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 26 November 2018 15:04 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Jan Beulich ; > Andrew Cooper ; Wei Liu > Subject: Re: [PATCH] viridian: fix assertion failure > > On Mon, Nov 26, 2018 at 02:54:54PM +, Paul Durrant w

Re: [Xen-devel] qemu assert in staging during HVM live migration

2018-11-26 Thread Olaf Hering
Am Mon, 26 Nov 2018 14:32:05 + schrieb Anthony PERARD : > Also, a backtrace of the original problem would be nice. There is no backtrace, all the data I could grab was sent to this list. I was unable to reproduce it as well. Olaf pgpL73JOm72zk.pgp Description: Digitale Signatur von OpenPGP

Re: [Xen-devel] [PATCH v1] xl: free bitmaps on exit

2018-11-26 Thread Wei Liu
On Mon, Nov 26, 2018 at 04:04:08PM +0100, Olaf Hering wrote: > Am Mon, 26 Nov 2018 15:58:22 +0100 > schrieb Olaf Hering : > > > +++ b/tools/xl/xl.c > > @@ -229,6 +229,9 @@ static void parse_global_config(const char *configfile, > > Actually I think that should go to xl_ctx_free() instead. I moved

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-26 Thread Juergen Gross
On 26/11/2018 15:54, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH] xen: only clobber multicall elements without > error"): >> On 23.11.18 at 14:25, wrote: >>> In debug builds the hypervisor will deliberately clobber processed >>> elements of the multicall structure. In order to ease diagn

Re: [Xen-devel] [PATCH 3/4] x86/msr: Handle MSR_TSC_AUX consistently for PV and HVM guests

2018-11-26 Thread Woods, Brian
On Thu, Nov 15, 2018 at 09:47:17PM +, Andy Cooper wrote: > With PVRDTSCP mode removed, handling of MSR_TSC_AUX can move into the common > code. Move its storage into struct vcpu_msrs (dropping the HVM-specific > msr_tsc_aux), and add an RDPID feature check as this bit also enumerates the > pre

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-26 Thread Juergen Gross
On 26/11/2018 15:58, Jan Beulich wrote: On 26.11.18 at 15:23, wrote: >> On 26/11/2018 15:01, Jan Beulich wrote: >> On 26.11.18 at 14:52, wrote: I don't think the hypervisor should explicitly try to make it as hard as possible for the guest to find problems in the code. >>> >>>

Re: [Xen-devel] [PATCH 1/2] amd-iommu: replace occurrences of bool_t with bool

2018-11-26 Thread Woods, Brian
On Mon, Nov 26, 2018 at 09:05:25AM +, Paul Durrant wrote: > Bring the coding style up to date. No functional change. > > Signed-off-by: Paul Durrant Acked-by: Brian Woods -- Brian Woods ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH] viridian: fix assertion failure

2018-11-26 Thread Roger Pau Monné
On Mon, Nov 26, 2018 at 03:08:50PM +, Paul Durrant wrote: > > -Original Message- > > From: Roger Pau Monne > > Sent: 26 November 2018 15:04 > > To: Paul Durrant > > Cc: xen-devel@lists.xenproject.org; Jan Beulich ; > > Andrew Cooper ; Wei Liu > > Subject: Re: [PATCH] viridian: fix ass

Re: [Xen-devel] [PATCH 1/2] amd-iommu: replace occurrences of bool_t with bool

2018-11-26 Thread Woods, Brian
On Mon, Nov 26, 2018 at 09:35:26AM -0600, Brian Woods wrote: > On Mon, Nov 26, 2018 at 09:05:25AM +, Paul Durrant wrote: > > Bring the coding style up to date. No functional change. > > > > Signed-off-by: Paul Durrant > > Acked-by: Brian Woods > > -- > Brian Woods Meant for another patch

Re: [Xen-devel] [PATCH] viridian: fix assertion failure

2018-11-26 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 26 November 2018 15:32 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Jan Beulich ; > Andrew Cooper ; Wei Liu > Subject: Re: [PATCH] viridian: fix assertion failure > > On Mon, Nov 26, 2018 at 03:08:50PM +, Paul Durrant w

Re: [Xen-devel] [Qemu-devel] [PATCH v5 15/24] hw: i386: Export the i386 ACPI SRAT build method

2018-11-26 Thread Igor Mammedov
On Thu, 22 Nov 2018 00:27:33 +0100 Samuel Ortiz wrote: > On Thu, Nov 15, 2018 at 02:28:54PM +0100, Igor Mammedov wrote: > > On Mon, 5 Nov 2018 02:40:38 +0100 > > Samuel Ortiz wrote: > > > > > This is the standard way of building SRAT on x86 platfoms. But future > > > machine types could deci

[Xen-devel] [PATCH] x86emul: suppress default test harness build with incapable assembler

2018-11-26 Thread Jan Beulich
A top level "make build", as used e.g. by osstest, wants to build all "all" targets in enabled tools subdirectories, which by default also includes the emulator test harness. The use of, in particular, {evex} insn pseudo-prefixes in, again in particular, test_x86_emulator.c causes this build to fai

[Xen-devel] [PATCH v2] viridian: fix assertion failure

2018-11-26 Thread Paul Durrant
Whilst attempting to crash an apparently wedged Windows domain using 'xen-hvmcrash' I managed to trigger the following ASSERT: (XEN) Assertion '!vp->ptr' failed at viridian.c:607 with stack: (XEN)[] viridian_map_guest_page+0x1b4/0x1b6 (XEN)[] viridian_synic_load_vcpu_ctxt+0x39/0x3b (XEN)

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-26 Thread Ian Jackson
Juergen Gross writes ("Re: [PATCH] xen: only clobber multicall elements without error"): > On 26/11/2018 15:54, Ian Jackson wrote: > > Maybe they could be clobbered losslessly ? Eg, by xoring with 0xaa or > > something. > > This would be rather hacky: I'd need to find out if clobbering was > per

Re: [Xen-devel] [PATCH 10/14] x86/mm: Switch {get, put}_gfn() infrastructure to using gfn_t

2018-11-26 Thread Woods, Brian
On Wed, Nov 21, 2018 at 01:21:18PM +, Andy Cooper wrote: > Seemingly, a majority of users either override the helpers anyway, or have an > gfn_t in their hands. > > Update the API, and adjust all users to match. > > Doing this highlighted a gaping altp2m security hole in > vmx_vcpu_update_vmf

Re: [Xen-devel] [PATCH RFC] mm/memory_hotplug: Introduce memory block types

2018-11-26 Thread David Hildenbrand
On 26.11.18 15:20, Michal Suchánek wrote: > On Mon, 26 Nov 2018 14:33:29 +0100 > David Hildenbrand wrote: > >> On 26.11.18 13:30, David Hildenbrand wrote: >>> On 23.11.18 19:06, Michal Suchánek wrote: > If we are going to fake the driver information we may as well add the type a

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-26 Thread Julien Grall
On 26/11/2018 15:29, Juergen Gross wrote: On 26/11/2018 15:58, Jan Beulich wrote: On 26.11.18 at 15:23, wrote: On 26/11/2018 15:01, Jan Beulich wrote: On 26.11.18 at 14:52, wrote: I don't think the hypervisor should explicitly try to make it as hard as possible for the guest to find probl

Re: [Xen-devel] [PATCH v1] Increase framebuffer size to todays standards

2018-11-26 Thread Olaf Hering
Am Mon, 26 Nov 2018 03:31:27 -0700 schrieb "Jan Beulich" : > And I think a change like this should (a) address the more general > case rather than just your laptop (or laptops in general) and (b) > actually add some headroom. Hence at the very least I'd see us > go to 4096x3072. WHUXGA would even

Re: [Xen-devel] [PATCH v2] viridian: fix assertion failure

2018-11-26 Thread Roger Pau Monné
On Mon, Nov 26, 2018 at 03:38:52PM +, Paul Durrant wrote: > Whilst attempting to crash an apparently wedged Windows domain using > 'xen-hvmcrash' I managed to trigger the following ASSERT: > > (XEN) Assertion '!vp->ptr' failed at viridian.c:607 > > with stack: > > (XEN)[] viridian_map_gu

Re: [Xen-devel] [PATCH v1] Increase framebuffer size to todays standards

2018-11-26 Thread Jan Beulich
>>> On 26.11.18 at 17:03, wrote: > Am Mon, 26 Nov 2018 03:31:27 -0700 > schrieb "Jan Beulich" : > >> And I think a change like this should (a) address the more general >> case rather than just your laptop (or laptops in general) and (b) >> actually add some headroom. Hence at the very least I'd s

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-26 Thread Juergen Gross
On 26/11/2018 17:01, Julien Grall wrote: > > > On 26/11/2018 15:29, Juergen Gross wrote: >> On 26/11/2018 15:58, Jan Beulich wrote: >> On 26.11.18 at 15:23, wrote: On 26/11/2018 15:01, Jan Beulich wrote: On 26.11.18 at 14:52, wrote: >> I don't think the hypervisor should e

  1   2   >