Re: [Xen-devel] [alsa-devel] [PATCH 3/3] ALSA: xen-front: Use Xen common shared buffer implementation

2018-11-23 Thread Oleksandr Andrushchenko
On 11/22/18 5:47 PM, Takashi Iwai wrote: On Thu, 22 Nov 2018 11:02:30 +0100, Oleksandr Andrushchenko wrote: @@ -214,12 +221,19 @@ static void stream_clear(struct xen_snd_front_pcm_stream_info *stream) stream->out_frames = 0; atomic_set(&stream->hw_ptr, 0); xen_snd_front_

Re: [Xen-devel] [PATCH 03/14] AMD/IOMMU: Fix multiple reference counting errors

2018-11-23 Thread Jan Beulich
>>> On 22.11.18 at 18:46, wrote: > On 22/11/2018 14:51, Jan Beulich wrote: >>> @@ -220,12 +219,18 @@ void guest_iommu_add_ppr_log(struct domain *d, u32 >>> entry[]) >>> unmap_domain_page(log_base); >>> >>> guest_iommu_deliver_msi(d); >>> + >>> +out: >> Please indent by at least one bl

Re: [Xen-devel] [PATCH 2/3] drm/xen-front: Use Xen common shared buffer implementation

2018-11-23 Thread Juergen Gross
On 22/11/2018 15:33, Daniel Vetter wrote: > On Thu, Nov 22, 2018 at 12:02:29PM +0200, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko >> >> Use page directory based shared buffer implementation >> now available as common code for Xen frontend drivers. >> >> Signed-off-by: Oleksandr

[Xen-devel] [PATCH 4.9 and older] VMX: allow migration of guests with SSBD enabled

2018-11-23 Thread Jan Beulich
The backport of cd53023df9 ("x86/msr: Virtualise MSR_SPEC_CTRL.SSBD for guests to use") did not mirror the PV side change into the HVM (VMX- specific) code path. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -978,7 +981,8 @@ static int vmx_load_m

[Xen-devel] [linux-3.18 test] 130643: regressions - trouble: blocked/broken/fail/pass

2018-11-23 Thread osstest service owner
flight 130643 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/130643/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 broken build-arm64-xsm

Re: [Xen-devel] [PATCH v1] x86/hvm: Generic instruction re-execution mechanism for execute faults

2018-11-23 Thread Roger Pau Monné
On Thu, Nov 22, 2018 at 08:24:52PM +0200, Razvan Cojocaru wrote: > On 11/22/18 7:08 PM, Roger Pau Monné wrote: > > On Thu, Nov 22, 2018 at 06:52:07PM +0200, Razvan Cojocaru wrote: > >> On 11/22/18 5:37 PM, Roger Pau Monné wrote: > >>> I don't think you are supposed to try to pause other vcpus while

Re: [Xen-devel] [PATCH v1] x86/hvm: Generic instruction re-execution mechanism for execute faults

2018-11-23 Thread Jan Beulich
>>> On 22.11.18 at 19:24, wrote: > _However_, please picture an instruction that both writes into a page P1 > we're interested in, _and_ causes a write into a read-only page-walk > related page P2. Emulating the current instruction, as the upstream > patch does, does eliminate the vm_event caused

Re: [Xen-devel] [PATCH v1] x86/hvm: Generic instruction re-execution mechanism for execute faults

2018-11-23 Thread Jan Beulich
>>> On 23.11.18 at 09:54, wrote: > On Thu, Nov 22, 2018 at 08:24:52PM +0200, Razvan Cojocaru wrote: >> What this patch attempts to do is to mark P1 rwx (so allow the write), >> then put the faulting VCPU into singlestep mode, then restore the >> restrictions after it has finished single stepping.

[Xen-devel] [xen-unstable-smoke test] 130712: regressions - trouble: blocked/broken/fail/pass

2018-11-23 Thread osstest service owner
flight 130712 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130712/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-amd64 6 xen

Re: [Xen-devel] [Qemu-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP

2018-11-23 Thread Samuel Ortiz
On Thu, Nov 22, 2018 at 05:26:52PM +0100, Igor Mammedov wrote: > On Wed, 21 Nov 2018 15:42:11 +0100 > Samuel Ortiz wrote: > > > Hi Igor, > > > > On Thu, Nov 08, 2018 at 03:16:23PM +0100, Igor Mammedov wrote: > > > On Mon, 5 Nov 2018 02:40:28 +0100 > > > Samuel Ortiz wrote: > > > > > > > XSD

Re: [Xen-devel] [xen-unstable-smoke test] 130708: regressions - trouble: blocked/broken/fail/pass

2018-11-23 Thread Jan Beulich
>>> On 23.11.18 at 07:20, wrote: > flight 130708 xen-unstable-smoke real [real] > http://logs.test-lab.xenproject.org/osstest/logs/130708/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-arm64-xsm

[Xen-devel] [PATCH v2] mm: disallow MEMF_no_refcount to be passed for domain-owned allocations

2018-11-23 Thread Jan Beulich
When such pages get assigned to domains (and hence their ->tot_pages not incremented accordingly) we would otherwise also need to suppress decrementing the count when freeing those pages. Signed-off-by: Jan Beulich --- v2: Add ASSERT_UNREACHABLE(). --- a/xen/common/page_alloc.c +++ b/xen/common/

Re: [Xen-devel] [PATCH 1/4] xen/arm: gic: Ensure we have an ISB between ack and do_IRQ()

2018-11-23 Thread Andrii Anisov
Hello Julien, On 22.11.18 19:22, Julien Grall wrote: My biggest worry is you are doing optimization on a vGIC that is not fully compliant with how a GIC should behave (e.g edge vs level) and with very fragile locking. Yep, old VGIC locking looks pretty terrible. If you are interested, Andre

Re: [Xen-devel] [PATCH] common: make sure symbols-dummy.o gets rebuilt when needed

2018-11-23 Thread Jan Beulich
>>> On 22.11.18 at 16:30, wrote: > On Thu, Nov 22, 2018 at 03:47:41AM -0700, Jan Beulich wrote: >> --- a/xen/arch/arm/Makefile >> +++ b/xen/arch/arm/Makefile >> @@ -100,9 +100,6 @@ prelink.o: $(ALL_OBJS) >> $(LD) $(LDFLAGS) -r -o $@ $^ >> endif >> >> -$(BASEDIR)/common/symbols-dummy.o: >>

[Xen-devel] [distros-debian-jessie test] 75618: regressions - FAIL

2018-11-23 Thread Platform Team regression test user
flight 75618 distros-debian-jessie real [real] http://osstest.xensource.com/osstest/logs/75618/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-i386-jessie-netboot-pvgrub 19 guest-start/debian.repeat fail REGR. vs. 75596 Tes

Re: [Xen-devel] [Qemu-devel] [PATCH] Xen PCI passthrough: fix passthrough failure when irq map failure

2018-11-23 Thread Roger Pau Monné
Adding Jan in case he has an opinion on my reply below. On Fri, Nov 23, 2018 at 12:04:51AM -0500, Zhao Yan wrote: > On Thu, Nov 22, 2018 at 03:18:05PM +0100, Roger Pau Monné wrote: > > On Thu, Nov 22, 2018 at 08:11:20AM -0500, Zhao Yan wrote: > > > On Thu, Oct 18, 2018 at 03:56:36PM +0100, Roger P

Re: [Xen-devel] [Qemu-devel] [PATCH] Xen PCI passthrough: fix passthrough failure when irq map failure

2018-11-23 Thread Jan Beulich
>>> On 23.11.18 at 11:19, wrote: > Adding Jan in case he has an opinion on my reply below. I agree, fwiw. Jan > On Fri, Nov 23, 2018 at 12:04:51AM -0500, Zhao Yan wrote: >> On Thu, Nov 22, 2018 at 03:18:05PM +0100, Roger Pau Monné wrote: >> > On Thu, Nov 22, 2018 at 08:11:20AM -0500, Zhao Yan w

Re: [Xen-devel] [PATCH v2] mm: disallow MEMF_no_refcount to be passed for domain-owned allocations

2018-11-23 Thread Andrew Cooper
On 23/11/2018 09:45, Jan Beulich wrote: > When such pages get assigned to domains (and hence their ->tot_pages > not incremented accordingly) we would otherwise also need to suppress > decrementing the count when freeing those pages. > > Signed-off-by: Jan Beulich > --- > v2: Add ASSERT_UNREACHABL

Re: [Xen-devel] [PATCH 4.9 and older] VMX: allow migration of guests with SSBD enabled

2018-11-23 Thread Andrew Cooper
On 23/11/2018 08:29, Jan Beulich wrote: > The backport of cd53023df9 ("x86/msr: Virtualise MSR_SPEC_CTRL.SSBD for > guests to use") did not mirror the PV side change into the HVM (VMX- > specific) code path. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper Sorry - I definitely tested t

Re: [Xen-devel] remove the ->mapping_error method from dma_map_ops V2

2018-11-23 Thread Joerg Roedel
On Thu, Nov 22, 2018 at 05:52:15PM +, Robin Murphy wrote: > Unfortunately, with things like the top-down IOVA allocator, and 32-bit > systems in general, "the top 4095" values may well still be valid addresses > - we're relying on a 1-byte mapping of the very top byte of memory/IOVA > space bei

Re: [Xen-devel] [PATCH v2] mm: disallow MEMF_no_refcount to be passed for domain-owned allocations

2018-11-23 Thread Jan Beulich
>>> On 23.11.18 at 11:28, wrote: > On 23/11/2018 09:45, Jan Beulich wrote: >> When such pages get assigned to domains (and hence their ->tot_pages >> not incremented accordingly) we would otherwise also need to suppress >> decrementing the count when freeing those pages. >> >> Signed-off-by: Jan B

Re: [Xen-devel] [PATCH v2] mm: disallow MEMF_no_refcount to be passed for domain-owned allocations

2018-11-23 Thread Andrew Cooper
On 23/11/2018 10:49, Jan Beulich wrote: On 23.11.18 at 11:28, wrote: >> On 23/11/2018 09:45, Jan Beulich wrote: >>> When such pages get assigned to domains (and hence their ->tot_pages >>> not incremented accordingly) we would otherwise also need to suppress >>> decrementing the count when fr

Re: [Xen-devel] [Qemu-devel] [PATCH v5 10/24] hw: acpi: Export the PCI host and holes getters

2018-11-23 Thread Igor Mammedov
On Wed, 21 Nov 2018 16:43:12 +0100 Samuel Ortiz wrote: > On Tue, Nov 13, 2018 at 04:59:18PM +0100, Igor Mammedov wrote: > > On Mon, 5 Nov 2018 02:40:33 +0100 > > Samuel Ortiz wrote: > > > > > This is going to be needed by the hardware reduced implementation, so > > > let's export it. > > > O

Re: [Xen-devel] remove the ->mapping_error method from dma_map_ops V2

2018-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 11:49:18AM +0100, Joerg Roedel wrote: > On Thu, Nov 22, 2018 at 05:52:15PM +, Robin Murphy wrote: > > Unfortunately, with things like the top-down IOVA allocator, and 32-bit > > systems in general, "the top 4095" values may well still be valid addresses > > - we're relyi

Re: [Xen-devel] [Qemu-devel] [PATCH v5 11/24] hw: acpi: Export and generalize the PCI host AML API

2018-11-23 Thread Igor Mammedov
On Thu, 22 Nov 2018 00:12:17 +0100 Samuel Ortiz wrote: > Hi Igor, > > On Wed, Nov 14, 2018 at 11:55:37AM +0100, Igor Mammedov wrote: > > On Mon, 5 Nov 2018 02:40:34 +0100 > > Samuel Ortiz wrote: > > > > > From: Yang Zhong > > > > > > The AML build routines for the PCI host bridge and the

Re: [Xen-devel] [PATCH v6 05/11] libxl_qmp: Implementation of libxl__ev_qmp_*

2018-11-23 Thread Anthony PERARD
On Thu, Nov 22, 2018 at 08:04:53PM +0100, Marek Marczykowski-Górecki wrote: > On Mon, Nov 12, 2018 at 04:49:24PM +, Anthony PERARD wrote: > > +static int qmp_ev_callback_readable(libxl__egc *egc, > > +libxl__ev_qmp *ev, int fd) > > +{ > > +EGC_GC; > > + >

Re: [Xen-devel] [PATCH RFC] mm/memory_hotplug: Introduce memory block types

2018-11-23 Thread David Hildenbrand
On 28.09.18 17:03, David Hildenbrand wrote: > How to/when to online hotplugged memory is hard to manage for > distributions because different memory types are to be treated differently. > Right now, we need complicated udev rules that e.g. check if we are > running on s390x, on a physical system or

Re: [Xen-devel] [PATCH] mm: fix LLVM code-generation issue

2018-11-23 Thread Roger Pau Monné
On Thu, Nov 22, 2018 at 05:46:19PM +, Julien Grall wrote: > > > On 11/22/18 5:04 PM, George Dunlap wrote: > > On 11/22/18 4:45 PM, Julien Grall wrote: > > > Hi Roger, > > > > > > On 11/22/18 4:39 PM, Roger Pau Monné wrote: > > > > On Thu, Nov 22, 2018 at 04:22:34PM +, Andrew Cooper wrote

Re: [Xen-devel] [PATCH] mm: fix LLVM code-generation issue

2018-11-23 Thread Jan Beulich
>>> On 23.11.18 at 12:23, wrote: > Image an AP reads system_state < SYS_STATE_active, then BSP sets > system_state = SYS_STATE_active and clears the init mappings, then > when the AP tries to read an init variable it would get a page fault. As said before - APs are supposed to be quiescent during

[Xen-devel] [PATCH v2] common: make sure symbols-dummy.o gets rebuilt when needed

2018-11-23 Thread Jan Beulich
The per-arch top level make files don't record any dependencies for the file, so its mere existence is enough for make to consider it up-to- date. As of ab3e5f5ff9 ("xsplice, symbols: Implement fast symbol names -> virtual addresses lookup") the file, however, depends on the FAST_SYMBOL_LOOKUP conf

Re: [Xen-devel] [PATCH] mm: fix LLVM code-generation issue

2018-11-23 Thread Julien Grall
On 23/11/2018 11:23, Roger Pau Monné wrote: On Thu, Nov 22, 2018 at 05:46:19PM +, Julien Grall wrote: On 11/22/18 5:04 PM, George Dunlap wrote: On 11/22/18 4:45 PM, Julien Grall wrote: Hi Roger, On 11/22/18 4:39 PM, Roger Pau Monné wrote: On Thu, Nov 22, 2018 at 04:22:34PM +, And

[Xen-devel] [PATCH] EFI: don't repeatedly replace symlinks

2018-11-23 Thread Jan Beulich
Once created there's no point re-creating them on every incremental make. This in particular prevents them from becoming root-owned during e.g. "sudo make install-xen", but it also allows (during development) to replace them there (instead of in common/efi/) by actual files with perhaps slightly ch

Re: [Xen-devel] [PATCH] mm: fix LLVM code-generation issue

2018-11-23 Thread Julien Grall
Hi Jan, On 23/11/2018 11:33, Jan Beulich wrote: On 23.11.18 at 12:23, wrote: Image an AP reads system_state < SYS_STATE_active, then BSP sets system_state = SYS_STATE_active and clears the init mappings, then when the AP tries to read an init variable it would get a page fault. As said befor

[Xen-devel] [linux-linus bisection] complete test-amd64-amd64-xl-multivcpu

2018-11-23 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-multivcpu testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.g

Re: [Xen-devel] [PATCH v2] common: make sure symbols-dummy.o gets rebuilt when needed

2018-11-23 Thread Andrew Cooper
On 23/11/2018 11:36, Jan Beulich wrote: > The per-arch top level make files don't record any dependencies for the > file, so its mere existence is enough for make to consider it up-to- > date. As of ab3e5f5ff9 ("xsplice, symbols: Implement fast symbol names > -> virtual addresses lookup") the file,

Re: [Xen-devel] [PATCH] EFI: don't repeatedly replace symlinks

2018-11-23 Thread Andrew Cooper
On 23/11/2018 11:37, Jan Beulich wrote: > Once created there's no point re-creating them on every incremental > make. This in particular prevents them from becoming root-owned during > e.g. "sudo make install-xen", but it also allows (during development) > to replace them there (instead of in commo

[Xen-devel] Xen and Inter-VM-Communications

2018-11-23 Thread Ben Clewett
Hi Guys, I am interested in using Inter-VM-Communications (IVMC) to enhance performance between TCP server/applications running on the same Hypervisor. For instance, XenLoop seems like the magic silver bullet to solve our requirements. Can I please

Re: [Xen-devel] [PATCH] mm: fix LLVM code-generation issue

2018-11-23 Thread Roger Pau Monné
On Fri, Nov 23, 2018 at 11:39:32AM +, Julien Grall wrote: > Hi Jan, > > On 23/11/2018 11:33, Jan Beulich wrote: > > > > > On 23.11.18 at 12:23, wrote: > > > Image an AP reads system_state < SYS_STATE_active, then BSP sets > > > system_state = SYS_STATE_active and clears the init mappings, the

Re: [Xen-devel] [PATCH 1/4] xen/arm: gic: Ensure we have an ISB between ack and do_IRQ()

2018-11-23 Thread Andre Przywara
On Fri, 23 Nov 2018 12:09:41 +0200 Andrii Anisov wrote: Hi, > On 22.11.18 19:22, Julien Grall wrote: > > My biggest worry is you are doing optimization on a vGIC that is > > not fully compliant with how a GIC should behave (e.g edge vs > > level) and with very fragile locking. > Yep, old VGIC

Re: [Xen-devel] [PATCH] mm: fix LLVM code-generation issue

2018-11-23 Thread Wei Liu
On Fri, Nov 23, 2018 at 11:36:48AM +, Julien Grall wrote: > > > On 23/11/2018 11:23, Roger Pau Monné wrote: > > On Thu, Nov 22, 2018 at 05:46:19PM +, Julien Grall wrote: > > > > > > > > > On 11/22/18 5:04 PM, George Dunlap wrote: > > > > On 11/22/18 4:45 PM, Julien Grall wrote: > > > >

Re: [Xen-devel] Xen and Inter-VM-Communications

2018-11-23 Thread Roger Pau Monné
On Fri, Nov 23, 2018 at 11:57:10AM +, Ben Clewett wrote: >Hi Guys, > >I am interested in using Inter-VM-Communications (IVMC) to enhance >performance between TCP server/applications running on the same >Hypervisor. > >For instance, XenLoop seems like the magic silver bulle

Re: [Xen-devel] [PATCH v2] common: make sure symbols-dummy.o gets rebuilt when needed

2018-11-23 Thread Wei Liu
On Fri, Nov 23, 2018 at 04:36:44AM -0700, Jan Beulich wrote: > The per-arch top level make files don't record any dependencies for the > file, so its mere existence is enough for make to consider it up-to- > date. As of ab3e5f5ff9 ("xsplice, symbols: Implement fast symbol names > -> virtual address

[Xen-devel] [PATCH v1] mm/memory_hotplug: drop "online" parameter from add_memory_resource()

2018-11-23 Thread David Hildenbrand
User space should always be in charge of how to online memory and if memory should be onlined automatically in the kernel. Let's drop the parameter to overwrite this - XEN passes memhp_auto_online, just like add_memory(), so we can directly use that instead internally. Cc: Boris Ostrovsky Cc: Jue

Re: [Xen-devel] [PATCH v1] mm/memory_hotplug: drop "online" parameter from add_memory_resource()

2018-11-23 Thread Michal Hocko
On Fri 23-11-18 13:37:40, David Hildenbrand wrote: > User space should always be in charge of how to online memory and > if memory should be onlined automatically in the kernel. Let's drop the > parameter to overwrite this - XEN passes memhp_auto_online, just like > add_memory(), so we can directly

Re: [Xen-devel] [PATCH v1] mm/memory_hotplug: drop "online" parameter from add_memory_resource()

2018-11-23 Thread David Hildenbrand
On 23.11.18 13:54, Michal Hocko wrote: > On Fri 23-11-18 13:37:40, David Hildenbrand wrote: >> User space should always be in charge of how to online memory and >> if memory should be onlined automatically in the kernel. Let's drop the >> parameter to overwrite this - XEN passes memhp_auto_online,

Re: [Xen-devel] [PATCH 1/4] xen/arm: gic: Ensure we have an ISB between ack and do_IRQ()

2018-11-23 Thread Andrii Anisov
Hello Andre, On 22.11.18 20:04, Andre Przywara wrote: Is that benchmark chosen to put some interrupt load on the system? Or is that what the customer actually uses and she is really suffering from Xen's interrupt handling and emulation? That it the 3D benchmark used by customer to compare virtu

[Xen-devel] [xen-unstable-smoke test] 130720: regressions - trouble: blocked/broken/fail/pass

2018-11-23 Thread osstest service owner
flight 130720 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130720/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-amd64 6 xen

Re: [Xen-devel] remove the ->mapping_error method from dma_map_ops V2

2018-11-23 Thread Joerg Roedel
On Fri, Nov 23, 2018 at 11:01:55AM +, Russell King - ARM Linux wrote: > Yuck. So, if we have a 4GB non-PAE 32-bit system, or a PAE system > where we have valid memory across the 4GB boundary and no IOMMU, > we have to reserve the top 4K page in the first 4GB of RAM? But that is only needed wh

Re: [Xen-devel] [PATCH 1/4] xen/arm: gic: Ensure we have an ISB between ack and do_IRQ()

2018-11-23 Thread Andrii Anisov
On 23.11.18 14:18, Andre Przywara wrote: Fundamentally there is a semantic difference between edge and level triggered IRQs: When the guest has handled an *edge* IRQ (EOIed so the LR's state goes to 0), this is done and dusted, and Xen doesn't need to care about this anymore until the next IRQ

Re: [Xen-devel] [PATCH v1] mm/memory_hotplug: drop "online" parameter from add_memory_resource()

2018-11-23 Thread Michal Hocko
On Fri 23-11-18 13:58:16, David Hildenbrand wrote: > On 23.11.18 13:54, Michal Hocko wrote: > > On Fri 23-11-18 13:37:40, David Hildenbrand wrote: > >> User space should always be in charge of how to online memory and > >> if memory should be onlined automatically in the kernel. Let's drop the > >>

Re: [Xen-devel] [PATCH v1] mm/memory_hotplug: drop "online" parameter from add_memory_resource()

2018-11-23 Thread David Hildenbrand
On 23.11.18 14:05, Michal Hocko wrote: > On Fri 23-11-18 13:58:16, David Hildenbrand wrote: >> On 23.11.18 13:54, Michal Hocko wrote: >>> On Fri 23-11-18 13:37:40, David Hildenbrand wrote: User space should always be in charge of how to online memory and if memory should be onlined automa

Re: [Xen-devel] [PATCH v1] mm/memory_hotplug: drop "online" parameter from add_memory_resource()

2018-11-23 Thread Oscar Salvador
On Fri, 2018-11-23 at 13:37 +0100, David Hildenbrand wrote: > Signed-off-by: David Hildenbrand Thanks ;-) Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE L3 ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/m

Re: [Xen-devel] remove the ->mapping_error method from dma_map_ops V2

2018-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 02:03:13PM +0100, Joerg Roedel wrote: > On Fri, Nov 23, 2018 at 11:01:55AM +, Russell King - ARM Linux wrote: > > Yuck. So, if we have a 4GB non-PAE 32-bit system, or a PAE system > > where we have valid memory across the 4GB boundary and no IOMMU, > > we have to reserv

Re: [Xen-devel] [PATCH v1] mm/memory_hotplug: drop "online" parameter from add_memory_resource()

2018-11-23 Thread Juergen Gross
On 23/11/2018 13:37, David Hildenbrand wrote: > User space should always be in charge of how to online memory and > if memory should be onlined automatically in the kernel. Let's drop the > parameter to overwrite this - XEN passes memhp_auto_online, just like > add_memory(), so we can directly use

[Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-23 Thread Juergen Gross
In debug builds the hypervisor will deliberately clobber processed elements of the multicall structure. In order to ease diagnostic data printout in the affected guest only clobber elements which didn't return an error. Signed-off-by: Juergen Gross --- xen/common/multicall.c | 1 + 1 file change

Re: [Xen-devel] [PATCH 1/4] xen/arm: gic: Ensure we have an ISB between ack and do_IRQ()

2018-11-23 Thread Julien Grall
On 23/11/2018 12:58, Andrii Anisov wrote: Hello Andre, On 22.11.18 20:04, Andre Przywara wrote: Is that benchmark chosen to put some interrupt load on the system? Or is that what the customer actually uses and she is really suffering from Xen's interrupt handling and emulation? That it the 3

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-23 Thread Andrew Cooper
On 23/11/2018 13:25, Juergen Gross wrote: > In debug builds the hypervisor will deliberately clobber processed > elements of the multicall structure. In order to ease diagnostic data > printout in the affected guest only clobber elements which didn't > return an error. > > Signed-off-by: Juergen Gr

Re: [Xen-devel] [Minios-devel] FOSDEM Devrooms (CfP deadlines for relevant DevRooms from Dec 1-10) and Xen Project Stand

2018-11-23 Thread Lars Kurth
FYI: no Xen Project booth at FOSDEM this year > Begin forwarded message: > > From: Alasdair G Kergon > Subject: FOSDEM 2019 stand applications > Date: 22 November 2018 at 14:58:21 GMT-6 > To: FOSDEM 2019 Stands Team > > You are receiving this message (bcc) because your email address was > list

Re: [Xen-devel] [PATCH] xen: only clobber multicall elements without error

2018-11-23 Thread Juergen Gross
On 23/11/2018 14:28, Andrew Cooper wrote: > On 23/11/2018 13:25, Juergen Gross wrote: >> In debug builds the hypervisor will deliberately clobber processed >> elements of the multicall structure. In order to ease diagnostic data >> printout in the affected guest only clobber elements which didn't >

Re: [Xen-devel] [PATCH v2 4/8] xen/balloon: mark inflated pages PG_offline

2018-11-23 Thread Juergen Gross
On 22/11/2018 11:06, David Hildenbrand wrote: > Mark inflated and never onlined pages PG_offline, to tell the world that > the content is stale and should not be dumped. > > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: Stefano Stabellini > Cc: Andrew Morton > Cc: Matthew Wilcox > Cc: Michal

Re: [Xen-devel] [PATCH] mm: fix LLVM code-generation issue

2018-11-23 Thread Julien Grall
On 23/11/2018 12:26, Wei Liu wrote: On Fri, Nov 23, 2018 at 11:36:48AM +, Julien Grall wrote: On 23/11/2018 11:23, Roger Pau Monné wrote: On Thu, Nov 22, 2018 at 05:46:19PM +, Julien Grall wrote: On 11/22/18 5:04 PM, George Dunlap wrote: On 11/22/18 4:45 PM, Julien Grall wrote:

[Xen-devel] [PATCH v7 00/14] libxl: Enable save/restore/migration of a restricted QEMU + libxl__ev_qmp_*

2018-11-23 Thread Anthony PERARD
Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.libxl-ev-qmp-v Changes in v7: plenty, with new patches Changes in v6: Implementation of libxl__ev_qmp_* functions have been squashed to a single patch. And with that, a lot

[Xen-devel] [PATCH v7 02/14] libxl_qmp: Separate QMP message generation from qmp_send_prepare

2018-11-23 Thread Anthony PERARD
.. to be able to re-use qmp_prepare_cmd with libxl__ev_qmp. This patch also add the QMP end of command '\r\n' into the generated string as every caller will needs this. There should be no functional change. Signed-off-by: Anthony PERARD --- Notes: v7: got rid of len_r in qmp_prepar

[Xen-devel] [PATCH v7 06/14] libxl_qmp: Implementation of libxl__ev_qmp_*

2018-11-23 Thread Anthony PERARD
This patch implement the API libxl__ev_qmp documented in the previous patch, "libxl: Design of an async API to issue QMP commands to QEMU". Since this API is to interact with QEMU via the QMP protocol, it also implement a QMP client. The specification for the QEMU Machine Protocol (QMP) can be fou

[Xen-devel] [PATCH v7 07/14] libxl_exec: Add libxl__spawn_initiate_failure

2018-11-23 Thread Anthony PERARD
This function can be used by user of libxl__spawn_* when they setup a notification other than xenstore. The parent can already report success via libxl__spawn_initiate_detach(), this new function can be used for failure instead of waiting for the timeout. Signed-off-by: Anthony PERARD --- Notes:

[Xen-devel] [PATCH v7 04/14] libxl: Add wrapper around libxl__json_object_to_json JSON

2018-11-23 Thread Anthony PERARD
That wrapper is going to be used to safely log a json_object, as libxl__json_object_to_json return NULL on error. In the error case, JSON() will return an invalid json string. Signed-off-by: Anthony PERARD --- Notes: v7: new patch There are no user yet because the first users

[Xen-devel] [PATCH v7 03/14] libxl_qmp: Change qmp_qemu_check_version to compare version

2018-11-23 Thread Anthony PERARD
This patch makes the function simpler to read. It also add the ability for a caller to tell if QEMU is newer or have the exact version. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- Notes: v6: new patch tools/libxl/libxl_qmp.c | 28 +--- 1 file ch

[Xen-devel] [PATCH v7 08/14] libxl: Add init/dispose of for libxl__domain_build_state

2018-11-23 Thread Anthony PERARD
These two new functions libxl__domain_build_state_{init,dispose} should be called every time a new libxl__domain_build_state comes to existance. There seems to be two of them, one with the domain creation machinery, and one in the stub_dm_spawn. Signed-off-by: Anthony PERARD --- Notes: v7:

[Xen-devel] [PATCH v7 09/14] libxl_dm: Pre-open QMP socket for QEMU

2018-11-23 Thread Anthony PERARD
This patch moves the creation of the QMP unix socket from QEMU to libxl. But libxl doesn't rely on this yet. When starting QEMU with dm_restrict=1, pre-open the QMP socket before exec QEMU. That socket will be useful to find out if QEMU is ready, and pre-opening it means that libxl can connect to

[Xen-devel] [PATCH v7 05/14] libxl: Design of an async API to issue QMP commands to QEMU

2018-11-23 Thread Anthony PERARD
All the functions will be implemented in later patches. This patch includes the API that libxl can use to send QMP commands to QEMU. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- Notes: v7: acked, but with: fd field renamed to payload_fd libxl__ao

[Xen-devel] [PATCH v7 01/14] libxl: Enhance libxl__sendmsg_fds to deal with EINTR and EWOULDBLOCK

2018-11-23 Thread Anthony PERARD
This patch change the behavior of libxl__sendmsg_fds to retry sendmsg on EINTR error. This patch also allow a caller of libxl__sendmsg_fds to deal with EWOULDBLOCK. The function now requires to send only 1 byte of data so that when dealing with non-blocking fds a EWOULDBLOCK error would mean that

Re: [Xen-devel] [PATCH v7 00/14] libxl: Enable save/restore/migration of a restricted QEMU + libxl__ev_qmp_*

2018-11-23 Thread Anthony PERARD
On Fri, Nov 23, 2018 at 01:53:41PM +, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git > br.libxl-ev-qmp-v That should have read: br.libxl-ev-qmp-v7 -- Anthony PERARD __

[Xen-devel] [PATCH v7 10/14] libxl: Add dmss_init/dispose for libxl__dm_spawn_state

2018-11-23 Thread Anthony PERARD
These two functions, dmss_init and dmss_dispose, need to be called to initialise the private parts of a libxl__dm_spawn_state (dmss) as well as dispose of them before giving back control to a caller. There are 3 functions that can start using a dmss, the classic libxl__spawn_local_dm, the one for

[Xen-devel] [PATCH v7 13/14] libxl: Change libxl__domain_suspend_device_model() to be async

2018-11-23 Thread Anthony PERARD
This create an extra step for the two call sites of the function. libxl__domain_suspend_device_model() in this patch gets an extra error variable (there is ret and rc), but ret goes away in the next patch. Signed-off-by: Anthony PERARD --- libxl_domain_soft_reset() haven't been tested, as it do

[Xen-devel] [PATCH v7 14/14] libxl: Re-implement domain_suspend_device_model using libxl__ev_qmp

2018-11-23 Thread Anthony PERARD
The re-implementation is done because we want to be able to send the file description that QEMU can use to save its state. When QEMU is restricted, it would not be able to write to a path. This replace both libxl__qmp_stop() and libxl__qmp_save(). qmp_qemu_check_version() was only used by libxl__

[Xen-devel] [PATCH v7 12/14] libxl_qmp: Store advertised QEMU version in libxl__ev_qmp

2018-11-23 Thread Anthony PERARD
This will be used in a later patch. Signed-off-by: Anthony PERARD --- Notes: v7: Add do{}while around the MACRO. formating nits changes. v6: new local macro GRAB_VERSION better definition of qemu_version field in libxl_internal.h v5:

[Xen-devel] [PATCH v7 11/14] libxl: QEMU startup sync based on QMP

2018-11-23 Thread Anthony PERARD
This is only activated when dm_restrict=1, as explained in a previous patch "libxl_dm: Pre-open QMP socket for QEMU" Signed-off-by: Anthony PERARD Reviewed-by: Roger Pau Monné --- Notes: v7: fixed _dispose call in device_model_spawn_outcome move qmp field in libxl__dm_spawn_

Re: [Xen-devel] [PATCH for-3.2 v3 06/14] qdev: do not mix compat props with global props

2018-11-23 Thread Igor Mammedov
On Wed, 7 Nov 2018 16:36:44 +0400 Marc-André Lureau wrote: > Machine & Accel props are not provided by user. Let's not mix them > with the global properties. > > Call a new helper function object_apply_global_props() during > device_post_init(). > > Add a stub for current_machine, so qemu-user

Re: [Xen-devel] [Qemu-devel] [PATCH for-3.2 v3 02/14] qom: make interface types abstract

2018-11-23 Thread Igor Mammedov
On Wed, 7 Nov 2018 16:36:40 +0400 Marc-André Lureau wrote: > Interfaces don't have instance, let's make the interface type really > abstract to avoid confusion. > > Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov > --- > include/hw/acpi/acpi_dev_interface.h | 6 +- > includ

Re: [Xen-devel] [PATCH for-3.2 v3 07/14] qdev: all globals are now user-provided

2018-11-23 Thread Igor Mammedov
On Wed, 7 Nov 2018 16:36:45 +0400 Marc-André Lureau wrote: > Considering that CPU features are provided via command line, the I can guess what it is about once I recall how -cpu foo,+-feat works, but without that knowledge I don't get meaning behind the sentence. Could you rephrase it? > global

Re: [Xen-devel] [PATCH for-3.2 v3 08/14] qdev-props: convert global_props to GArray

2018-11-23 Thread Igor Mammedov
On Wed, 7 Nov 2018 16:36:46 +0400 Marc-André Lureau wrote: > A step towards being able to call object_apply_global_props(). it also makes code more uniform as we don't have to deal with type inform of GList. maybe move it at the beginning of series and include accel part as well? otherwise loo

Re: [Xen-devel] [Minios-devel] FOSDEM Devrooms (CfP deadlines for relevant DevRooms from Dec 1-10) and Xen Project Stand

2018-11-23 Thread Sander Eikelenboom
On 23/11/18 14:34, Lars Kurth wrote: > FYI: no Xen Project booth at FOSDEM this year Bummer, no fresh T-shirt :(. -- Sander ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-23 Thread Roger Pau Monne
LLVM code generation can attempt to load from a variable in the next condition of an expression under certain circumstances, thus turning the following condition: if ( system_state < SYS_STATE_active && opt_bootscrub == BOOTSCRUB_IDLE ) Into: 0x82d080223967 <+103>: cmpl $0x3,0x37b032(%rip)

Re: [Xen-devel] [PATCH v5 6/6] amd/iommu: skip bridge devices when updating IOMMU page tables

2018-11-23 Thread Roger Pau Monné
On Thu, Nov 22, 2018 at 06:20:46AM -0700, Jan Beulich wrote: > >>> On 22.11.18 at 13:47, wrote: > > I think the is_hardware_domain part can be dropped from the > > conditional I'm adding. update_paging_mode shouldn't be used to decide > > whether a domain can or cannot have bridges attached. Wheth

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-23 Thread Julien Grall
On 23/11/2018 14:30, Roger Pau Monne wrote: LLVM code generation can attempt to load from a variable in the next condition of an expression under certain circumstances, thus turning the following condition: if ( system_state < SYS_STATE_active && opt_bootscrub == BOOTSCRUB_IDLE ) Into: 0xfff

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-23 Thread Andrew Cooper
On 23/11/2018 14:30, Roger Pau Monne wrote: > LLVM code generation can attempt to load from a variable in the next > condition of an expression under certain circumstances, thus turning > the following condition: > > if ( system_state < SYS_STATE_active && opt_bootscrub == BOOTSCRUB_IDLE ) > > Into

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: cleanup to reduce compiler warnings [and 1 more messages]

2018-11-23 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 1/1] tools/ocaml: cleanup to reduce compiler warnings"): > On Wed, Nov 14, 2018 at 11:06:49AM +, Christian Lindig wrote: > > This commit cleans up code to reduce compiler warnings: ... > Acked-by: Wei Liu > > Very nice! Christian Lindig writes ("Re: [PATCH 1/1] t

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: cleanup to reduce compiler warnings [and 1 more messages]

2018-11-23 Thread Wei Liu
On Fri, Nov 23, 2018 at 02:57:03PM +, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH 1/1] tools/ocaml: cleanup to reduce compiler > warnings"): > > On Wed, Nov 14, 2018 at 11:06:49AM +, Christian Lindig wrote: > > > This commit cleans up code to reduce compiler warnings: > ... > > Acked-

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: cleanup to reduce compiler warnings [and 1 more messages]

2018-11-23 Thread Andrew Cooper
On 23/11/2018 14:57, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH 1/1] tools/ocaml: cleanup to reduce compiler > warnings"): >> On Wed, Nov 14, 2018 at 11:06:49AM +, Christian Lindig wrote: >>> This commit cleans up code to reduce compiler warnings: > ... >> Acked-by: Wei Liu >> >> Very n

Re: [Xen-devel] [PATCH v5 13/20] xen: setup Xen specific data for PVH

2018-11-23 Thread Roger Pau Monné
On Wed, Nov 21, 2018 at 03:28:48PM +0100, Juergen Gross wrote: > Initialize the needed Xen specific data. This is: > > - the Xen start of day page containing the console and Xenstore ring > page PFN and event channel > - the grant table > - the shared info page > > Write back the possibly modif

[Xen-devel] [PATCH] tools/libs: Make xenforeignmemory_unmap_resource() idempotent

2018-11-23 Thread Andrew Cooper
Most other close/unmap functions are. Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Paul Durrant This ideally wants backporting to 4.11 to hit 4.11.1 I got an unexpected shock while trying to diagnose why GVT-g is still broken (differently!) on staging. --- tools/libs/for

Re: [Xen-devel] [PATCH v5 11/20] xen: setup hypercall page for PVH

2018-11-23 Thread Roger Pau Monné
On Wed, Nov 21, 2018 at 03:28:46PM +0100, Juergen Gross wrote: > Add the needed code to setup the hypercall page for calling into the > Xen hypervisor. > > Import the XEN_HVM_DEBUGCONS_IOPORT define from Xen unstable into > include/xen/arch-x86/xen.h > > Signed-off-by: Juergen Gross Reviewed-by

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: cleanup to reduce compiler warnings [and 1 more messages]

2018-11-23 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 1/1] tools/ocaml: cleanup to reduce compiler warnings [and 1 more messages]"): > This patch is already applied. Oh, that would explain it. I did check git-log but not thoroughly enough. Sorry for the noise. Ian. ___ Xen-d

Re: [Xen-devel] [PATCH v3] tools: set Dom0 UUID if requested

2018-11-23 Thread Anthony PERARD
On Tue, Nov 20, 2018 at 06:09:41PM +, Wei Liu wrote: > diff --git a/tools/helpers/xen-init-dom0.c b/tools/helpers/xen-init-dom0.c > index 09bc0027f9..a2f31fe9bf 100644 > --- a/tools/helpers/xen-init-dom0.c > +++ b/tools/helpers/xen-init-dom0.c [..] > xsh = xs_open(0); > if (!xsh) { >

[Xen-devel] [PATCH v2 00/21] QOM'ify SysBusDeviceClass->init

2018-11-23 Thread Mao Zhongyi
The SysBusDeviceClass::init() interface is considered as a legacy interface and there are currently some efforts going on to get rid of it. Thus convert SysBusDeviceClass::init to DeviceClass::realize. v2 -> v1: - SYS_BUS_DEVICE(dev) was used in a function several times, so use a variable 'sbd

[Xen-devel] [PATCH v2 20/21] xen_backend: remove xen_sysdev_init() function

2018-11-23 Thread Mao Zhongyi
The init function doesn't do anything at all, so we just omit it. Cc: sstabell...@kernel.org Cc: anthony.per...@citrix.com Cc: xen-devel@lists.xenproject.org Cc: peter.mayd...@linaro.org Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju --- hw/xen/xen_backend.c | 7 --- 1 file change

Re: [Xen-devel] [PATCH] mm: make opt_bootscrub non-init

2018-11-23 Thread Sergey Dyasli
On 23/11/2018 14:30, Roger Pau Monne wrote: > LLVM code generation can attempt to load from a variable in the next > condition of an expression under certain circumstances, thus turning > the following condition: > > if ( system_state < SYS_STATE_active && opt_bootscrub == BOOTSCRUB_IDLE ) > > In

[Xen-devel] [xen-unstable-smoke test] 130725: regressions - trouble: blocked/broken/fail/pass

2018-11-23 Thread osstest service owner
flight 130725 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/130725/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm broken build-amd64 6 xen

Re: [Xen-devel] [PATCH 00/14] XSA-277 followup

2018-11-23 Thread Roger Pau Monné
On Wed, Nov 21, 2018 at 09:22:25PM +, Andrew Cooper wrote: [...] > The only way I see of fixing this to teach Xen about the guests gfn > layout (as chosen by the domainbuilder), and include within that "space > which definitely doesn't have anything in, and is safe to put shared > mappings into

Re: [Xen-devel] qemu assert in staging during HVM live migration

2018-11-23 Thread Anthony PERARD
On Thu, Nov 22, 2018 at 11:03:45AM +0100, Olaf Hering wrote: > While debugging something else, it turned out that staging and/or qemu > can not migrate HVM domUs. qemu runs into an assert when the domU is > about to be migrated with 'xl migrate domU dom0': > > qemu-system-i386: block/block-backend

  1   2   >