Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-13 Thread Andrew Cooper
On 12/11/2018 19:56, Julien Grall wrote: > Hi Andrew, > > On 11/12/18 4:41 PM, Andrew Cooper wrote: >> On 12/11/18 16:35, Mirela Simonovic wrote: > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index e594b48d81..7f8105465c 100644 > --- a/xen/arch/arm/domain.c > +++ b/

[Xen-devel] [ovmf test] 129932: regressions - FAIL

2018-11-13 Thread osstest service owner
flight 129932 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129932/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

[Xen-devel] [xen-unstable-smoke test] 129927: regressions - FAIL

2018-11-13 Thread osstest service owner
flight 129927 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129927/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 129852 Tests which

Re: [Xen-devel] [Patch v3 2/2] x86/microcode: Synchronize late microcode loading

2018-11-13 Thread Chao Gao
On Wed, May 09, 2018 at 06:01:33AM +0800, Gao, Chao wrote: >This patch ports microcode improvement patches from linux kernel. > >Before you read any further: the early loading method is still the >preferred one and you should always do that. The following patch is >improving the late loading mechan

Re: [Xen-devel] [Patch v3 2/2] x86/microcode: Synchronize late microcode loading

2018-11-13 Thread Andrew Cooper
On 13/11/2018 09:08, Chao Gao wrote: > On Wed, May 09, 2018 at 06:01:33AM +0800, Gao, Chao wrote: >> This patch ports microcode improvement patches from linux kernel. >> >> Before you read any further: the early loading method is still the >> preferred one and you should always do that. The followi

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-13 Thread Julien Grall
Hi Stefano, On 13/11/2018 01:53, Stefano Stabellini wrote: On Mon, 12 Nov 2018, Andrew Cooper wrote: On 12/11/18 16:35, Mirela Simonovic wrote: Hi Julien, Thanks for your feedback, I'll need to answer in iterations. On Mon, Nov 12, 2018 at 4:27 PM Julien Grall wrote: Hi Mirela, On 11/12/1

Re: [Xen-devel] [PATCH] x86/badpage: Fix badpage->order overflow

2018-11-13 Thread Jan Beulich
>>> On 12.11.18 at 20:01, wrote: > On 12/11/18 09:54, Jan Beulich wrote: > On 09.11.18 at 15:42, wrote: >>> For order 32 or more, the shift will truncate. Spotted by Coverity. >> I find this pretty absurd. What about order 64 or more? Are you >> suggesting you expect 16Tb or larger bad page

Re: [Xen-devel] [PATCH 05/18] xen/arm: Trigger Xen suspend when Dom0 completes suspend

2018-11-13 Thread Julien Grall
Hi Stefano, On 12/11/2018 23:46, Stefano Stabellini wrote: On Mon, 12 Nov 2018, Julien Grall wrote: Hi, On 11/12/18 11:30 AM, Mirela Simonovic wrote: When Dom0 finalizes its suspend procedure the suspend of Xen is triggered by calling system_suspend(). Dom0 finalizes the suspend from its boot

[Xen-devel] [ovmf test] 129937: regressions - FAIL

2018-11-13 Thread osstest service owner
flight 129937 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129937/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

Re: [Xen-devel] [PATCH 15/18] xen/arm: Resume memory management on Xen resume

2018-11-13 Thread Julien Grall
Hi, On 13/11/2018 01:36, Stefano Stabellini wrote: On Mon, 12 Nov 2018, Julien Grall wrote: On 11/12/18 11:30 AM, Mirela Simonovic wrote: We can turn this assembly code into a .macro, so that at least when we get around to it, we just need to fix it one place. In fact, I noticed that the code

Re: [Xen-devel] [PATCH 00/18] xen/arm64: Suspend to RAM support for Xen

2018-11-13 Thread Julien Grall
Hi Stefano, On 13/11/2018 02:22, Stefano Stabellini wrote: On Mon, 12 Nov 2018, Julien Grall wrote: Hi Mirela, Thank you for posting the series. Could you provide a branch with the patch applied? On 11/12/18 11:30 AM, Mirela Simonovic wrote: -

[Xen-devel] [PATCH 0/3] x86/HVM: honor r/o p2m types, in particular during emulation

2018-11-13 Thread Jan Beulich
1: __hvm_copy() should not write to p2m_ioreq_server pages 2: make hvmemul_map_linear_addr() honor p2m_ioreq_server 3: hvmemul_cmpxchg() should also use known_gla() Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject

[Xen-devel] [PATCH 2/3] x86/HVM: make hvmemul_map_linear_addr() honor p2m_ioreq_server

2018-11-13 Thread Jan Beulich
Write accesses to p2m_ioreq_server pages should get redirected to the emulator also when using the mapping approach. Extend the p2m_is_discard_write() check there, and restrict both to the write access case (this is just a latent bug as currently we go this route only for write accesses). Signed-o

[Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Jan Beulich
Commit 3bdec530a5 ("x86/HVM: split page straddling emulated accesses in more cases") introduced a hvm_copy_to_guest_linear() attempt before falling back to hvmemul_linear_mmio_write(). This is wrong for the p2m_ioreq_server special case. That change widened a pre-existing issue though: Other writes

[Xen-devel] [PATCH 3/3] x86/HVM: hvmemul_cmpxchg() should also use known_gla()

2018-11-13 Thread Jan Beulich
To be consistent with the write and rmw cases the mapping approach should not be used when the guest linear address translation is known. This in particular excludes the discard-write case from bypassing the emulation path. This also means that now EFLAGS should actually get properly updated, despi

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-13 Thread Julien Grall
Hi, On 12/11/2018 11:30, Mirela Simonovic wrote: +/* + * This function sets the context of current VCPU to the state which is expected + * by the guest on resume. The expected VCPU state is: + * 1) pc to contain resume entry point (1st argument of PSCI SYSTEM_SUSPEND) + * 2) r0/x0 to contain co

Re: [Xen-devel] [PATCH v7 00/25] dom0less step1: boot multiple domains from device tree

2018-11-13 Thread Julien Grall
Hi, On 12/11/2018 22:59, Stefano Stabellini wrote: The following changes since commit 359970fd8b781fac2ddcbc84dd5b890075fa08ef: tools/libxl: Switch Arm guest type to PVH (2018-10-03 15:58:02 +0100) The Arm code has changed quite a bit in a month. Please resend a series based on the latest

Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 November 2018 10:14 > To: xen-devel > Cc: Andrew Cooper ; Paul Durrant > ; Wei Liu > Subject: [PATCH 1/3] x86/HVM: __hvm_copy() should not write to > p2m_ioreq_server pages > > Commit 3bdec530a5 ("x86/HVM: spl

Re: [Xen-devel] [PATCH 2/3] x86/HVM: make hvmemul_map_linear_addr() honor p2m_ioreq_server

2018-11-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 November 2018 10:14 > To: xen-devel > Cc: Andrew Cooper ; Paul Durrant > ; Wei Liu > Subject: [PATCH 2/3] x86/HVM: make hvmemul_map_linear_addr() honor > p2m_ioreq_server > > Write accesses to p2m_ioreq_server

Re: [Xen-devel] [PATCH 3/3] x86/HVM: hvmemul_cmpxchg() should also use known_gla()

2018-11-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 November 2018 10:15 > To: xen-devel > Cc: Andrew Cooper ; Paul Durrant > ; Wei Liu > Subject: [PATCH 3/3] x86/HVM: hvmemul_cmpxchg() should also use > known_gla() > > To be consistent with the write and rmw ca

[Xen-devel] [xen-unstable-smoke test] 129934: regressions - FAIL

2018-11-13 Thread osstest service owner
flight 129934 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129934/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 129852 Tests which

Re: [Xen-devel] [PATCH 3/3] x86/HVM: hvmemul_cmpxchg() should also use known_gla()

2018-11-13 Thread Jan Beulich
>>> On 13.11.18 at 11:34, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 13 November 2018 10:15 >> To: xen-devel >> Cc: Andrew Cooper ; Paul Durrant >> ; Wei Liu >> Subject: [PATCH 3/3] x86/HVM: hvmemul_cmpxchg() should also use >> known_gla() >>

[Xen-devel] [PATCH 4/3] x86/HVM: hvm_map_guest_frame_rw() should respect p2m_ioreq_server

2018-11-13 Thread Jan Beulich
Writes to such pages would need to be handed to the emulator, which we're not prepared to do at this point. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -2556,7 +2556,8 @@ static void *_hvm_map_guest_frame(unsign if ( writable ) { -i

[Xen-devel] [ovmf test] 129941: regressions - FAIL

2018-11-13 Thread osstest service owner
flight 129941 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129941/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

[Xen-devel] [PATCH 5/3] x86/shadow: emulate_gva_to_mfn() should respect p2m_ioreq_server

2018-11-13 Thread Jan Beulich
Writes to such pages would need to be handed to the emulator, which we're not prepared to do at this point. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/shadow/hvm.c +++ b/xen/arch/x86/mm/shadow/hvm.c @@ -338,7 +338,7 @@ static mfn_t emulate_gva_to_mfn(struct v { return _mfn(BA

Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Andrew Cooper
On 13/11/18 10:13, Jan Beulich wrote: > Commit 3bdec530a5 ("x86/HVM: split page straddling emulated accesses in > more cases") introduced a hvm_copy_to_guest_linear() attempt before > falling back to hvmemul_linear_mmio_write(). This is wrong for the > p2m_ioreq_server special case. That change wid

Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 13 November 2018 10:47 > To: Jan Beulich ; xen-devel de...@lists.xenproject.org> > Cc: Paul Durrant ; Wei Liu > Subject: Re: [PATCH 1/3] x86/HVM: __hvm_copy() should not write to > p2m_ioreq_server pages > > On 13/11/18 10:13, Jan Beulic

Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Jan Beulich
>>> On 13.11.18 at 11:47, wrote: > On 13/11/18 10:13, Jan Beulich wrote: >> Commit 3bdec530a5 ("x86/HVM: split page straddling emulated accesses in >> more cases") introduced a hvm_copy_to_guest_linear() attempt before >> falling back to hvmemul_linear_mmio_write(). This is wrong for the >> p2m_io

Re: [Xen-devel] [PATCH 4/3] x86/HVM: hvm_map_guest_frame_rw() should respect p2m_ioreq_server

2018-11-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 November 2018 10:47 > To: xen-devel ; Jan Beulich > > Cc: Andrew Cooper ; Paul Durrant > ; Wei Liu > Subject: [PATCH 4/3] x86/HVM: hvm_map_guest_frame_rw() should respect > p2m_ioreq_server > > Writes to such

Re: [Xen-devel] [PATCH 5/3] x86/shadow: emulate_gva_to_mfn() should respect p2m_ioreq_server

2018-11-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 November 2018 10:47 > To: xen-devel > Cc: Andrew Cooper ; Paul Durrant > ; Wei Liu ; Tim (Xen.org) > > Subject: [PATCH 5/3] x86/shadow: emulate_gva_to_mfn() should respect > p2m_ioreq_server > > Writes to such

Re: [Xen-devel] [PATCH v6 02/11] libxl_qmp: Separate QMP message generation from qmp_send_prepare

2018-11-13 Thread Anthony PERARD
On Mon, Nov 12, 2018 at 05:20:53PM +, Ian Jackson wrote: > Thanks for the repost. I feel I am going to make some comments which > could perhaps have been made earlier, so sorry for that: > > Anthony PERARD writes ("[PATCH v6 02/11] libxl_qmp: Separate QMP message > generation from qmp_send_p

Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Andrew Cooper
On 13/11/2018 10:53, Paul Durrant wrote: >> -Original Message- >> From: Andrew Cooper >> Sent: 13 November 2018 10:47 >> To: Jan Beulich ; xen-devel > de...@lists.xenproject.org> >> Cc: Paul Durrant ; Wei Liu >> Subject: Re: [PATCH 1/3] x86/HVM: __hvm_copy() should not write to >> p2m_iore

Re: [Xen-devel] [PATCH v4 06/44] x86emul: test for correct EVEX Disp8 scaling

2018-11-13 Thread Jan Beulich
>>> On 12.11.18 at 18:42, wrote: > On 25/09/18 14:29, Jan Beulich wrote: >> Besides the already existing tests (which are going to be extended once >> respective ISA extension support is complete), let's also ensure for >> every individual insn that their Disp8 scaling (and memory access width) >>

Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Jan Beulich
>>> On 13.11.18 at 12:08, wrote: > On 13/11/2018 10:53, Paul Durrant wrote: >>> -Original Message- >>> From: Andrew Cooper >>> Sent: 13 November 2018 10:47 >>> To: Jan Beulich ; xen-devel >> de...@lists.xenproject.org> >>> Cc: Paul Durrant ; Wei Liu >>> Subject: Re: [PATCH 1/3] x86/HVM: _

Re: [Xen-devel] [PATCH 4/3] x86/HVM: hvm_map_guest_frame_rw() should respect p2m_ioreq_server

2018-11-13 Thread Jan Beulich
>>> On 13.11.18 at 11:54, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 13 November 2018 10:47 >> To: xen-devel ; Jan Beulich >> >> Cc: Andrew Cooper ; Paul Durrant >> ; Wei Liu >> Subject: [PATCH 4/3] x86/HVM: hvm_map_guest_frame_rw() should resp

Re: [Xen-devel] [PATCH 5/3] x86/shadow: emulate_gva_to_mfn() should respect p2m_ioreq_server

2018-11-13 Thread Jan Beulich
>>> On 13.11.18 at 11:59, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 13 November 2018 10:47 >> To: xen-devel >> Cc: Andrew Cooper ; Paul Durrant >> ; Wei Liu ; Tim (Xen.org) >> >> Subject: [PATCH 5/3] x86/shadow: emulate_gva_to_mfn() should res

Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 November 2018 11:15 > To: Andrew Cooper ; Paul Durrant > > Cc: Wei Liu ; xen-devel de...@lists.xenproject.org> > Subject: Re: [PATCH 1/3] x86/HVM: __hvm_copy() should not write to > p2m_ioreq_server pages > >

Re: [Xen-devel] [PATCH 05/18] xen/arm: Trigger Xen suspend when Dom0 completes suspend

2018-11-13 Thread Mirela Simonovic
Hi, On Tue, Nov 13, 2018 at 10:43 AM Julien Grall wrote: > > Hi Stefano, > > On 12/11/2018 23:46, Stefano Stabellini wrote: > > On Mon, 12 Nov 2018, Julien Grall wrote: > >> Hi, > >> > >> On 11/12/18 11:30 AM, Mirela Simonovic wrote: > >>> When Dom0 finalizes its suspend procedure the suspend of

Re: [Xen-devel] [PATCH v6 05/11] libxl_qmp: Implementation of libxl__ev_qmp_*

2018-11-13 Thread Ian Jackson
Anthony PERARD writes ("[PATCH v6 05/11] libxl_qmp: Implementation of libxl__ev_qmp_*"): > Signed-off-by: Anthony PERARD I started reviewing this in detail but I got bogged down in the main implementation details because none of the internal functions like qmp_ev_connect have doc comments saying

Re: [Xen-devel] [PATCH 05/18] xen/arm: Trigger Xen suspend when Dom0 completes suspend

2018-11-13 Thread Julien Grall
On 13/11/2018 11:26, Mirela Simonovic wrote: Hi, On Tue, Nov 13, 2018 at 10:43 AM Julien Grall wrote: Hi Stefano, On 12/11/2018 23:46, Stefano Stabellini wrote: On Mon, 12 Nov 2018, Julien Grall wrote: Hi, On 11/12/18 11:30 AM, Mirela Simonovic wrote: When Dom0 finalizes its suspend pr

Re: [Xen-devel] [PATCH v4 07/44] x86emul: also allow running the 32-bit harness on a 64-bit distro

2018-11-13 Thread Jan Beulich
>>> On 12.11.18 at 18:50, wrote: > On 25/09/18 14:29, Jan Beulich wrote: >> In order to be able to verify the 32-bit variant builds and runs, >> introduce a respective target (and the necessary other adjustments). >> >> Signed-off-by: Jan Beulich > > I tried this, but got: > > make: Entering di

[Xen-devel] [ovmf test] 129946: regressions - FAIL

2018-11-13 Thread osstest service owner
flight 129946 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129946/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

[Xen-devel] [PATCH] libx86: Fix 32bit stubdom build of x86_cpuid_policy_fill_native()

2018-11-13 Thread Andrew Cooper
With -m32, GCC generates a warning for &size_t == &unsigned long, which is the typecheck hidden inside the min() macro. Switch to using explicitly typed versions instead. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu --- xen/lib/x86/cpuid.c | 15 --- 1 file changed,

Re: [Xen-devel] [PATCH v6 02/11] libxl_qmp: Separate QMP message generation from qmp_send_prepare

2018-11-13 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH v6 02/11] libxl_qmp: Separate QMP message generation from qmp_send_prepare"): > On Mon, Nov 12, 2018 at 05:20:53PM +, Ian Jackson wrote: > > Previously this function returned memory allocated from malloc, and > > this was not documented. I think it should be

Re: [Xen-devel] [PATCH 1/3] x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

2018-11-13 Thread Igor Druzhinin
On 13/11/2018 10:27, Paul Durrant wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 13 November 2018 10:14 >> To: xen-devel >> Cc: Andrew Cooper ; Paul Durrant >> ; Wei Liu >> Subject: [PATCH 1/3] x86/HVM: __hvm_copy() should not write to >> p2m_ioreq_s

Re: [Xen-devel] [PATCH] libx86: Fix 32bit stubdom build of x86_cpuid_policy_fill_native()

2018-11-13 Thread Jan Beulich
>>> On 13.11.18 at 12:59, wrote: > --- a/xen/lib/x86/cpuid.c > +++ b/xen/lib/x86/cpuid.c > @@ -7,8 +7,8 @@ void x86_cpuid_policy_fill_native(struct cpuid_policy *p) > unsigned int i; > > cpuid_leaf(0, &p->basic.raw[0]); > -for ( i = 1; i < min(ARRAY_SIZE(p->basic.raw), > -

Re: [Xen-devel] [PATCH] libx86: Fix 32bit stubdom build of x86_cpuid_policy_fill_native()

2018-11-13 Thread Wei Liu
On Tue, Nov 13, 2018 at 11:59:15AM +, Andrew Cooper wrote: > With -m32, GCC generates a warning for &size_t == &unsigned long, which is the > typecheck hidden inside the min() macro. > > Switch to using explicitly typed versions instead. > > Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu

[Xen-devel] [ovmf test] 129950: regressions - FAIL

2018-11-13 Thread osstest service owner
flight 129950 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129950/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

[Xen-devel] [PATCH v6.1 05/11] libxl_qmp: Implementation of libxl__ev_qmp_*

2018-11-13 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- tools/libxl/libxl_internal.h | 35 ++ tools/libxl/libxl_qmp.c | 683 +++ tools/libxl/libxl_types.idl | 6 + 3 files changed, 724 insertions(+) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index

[Xen-devel] [distros-debian-snapshot test] 75591: regressions - FAIL

2018-11-13 Thread Platform Team regression test user
flight 75591 distros-debian-snapshot real [real] http://osstest.xensource.com/osstest/logs/75591/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-i386-daily-netboot-pygrub 10 debian-di-install fail REGR. vs. 75575 Tests whi

Re: [Xen-devel] [PATCH v9] arch/x86: Add registers to vm_event

2018-11-13 Thread Wei Liu
On Fri, Nov 09, 2018 at 11:33:58AM +, Alexandru Stefan ISAILA wrote: > This patch adds a couple of regs to the vm_event that are used by > the introspection. The base, limit and ar > bits are compressed into a uint64_t union so as not to enlarge the > vm_event. > > Signed-off-by: Alexandru Isa

Re: [Xen-devel] [PATCH v4 2/2] xen: use SYMBOL when required

2018-11-13 Thread Jan Beulich
>>> On 13.11.18 at 00:06, wrote: > --- a/xen/arch/x86/alternative.c > +++ b/xen/arch/x86/alternative.c > @@ -194,7 +194,7 @@ void init_or_livepatch apply_alternatives(struct > alt_instr *start, > * So be careful if you want to change the scan order to any other > * order. > */ >

Re: [Xen-devel] [PATCH 0/3] automation: build Xen on Arm64

2018-11-13 Thread Wei Liu
Doug? (Sorry you weren't CC'ed on the cover letter) On Wed, Nov 07, 2018 at 12:31:46PM +, Wei Liu wrote: > Hi all > > This is my first attempt to quickly get something useful for Arm in Gitlab CI > with a machine borrowed from Packet.net. > > The runner is configured manually at the moment

Re: [Xen-devel] [PATCH v6.1 05/11] libxl_qmp: Implementation of libxl__ev_qmp_*

2018-11-13 Thread Ian Jackson
Anthony PERARD writes ("[PATCH v6.1 05/11] libxl_qmp: Implementation of libxl__ev_qmp_*"): ... I think this was intended to satisfy my request for comments about legal states: > +/* helpers */ > + > +static void qmp_ev_ensure_reading_writing(libxl__gc *gc, libxl__ev_qmp *ev) > +{ > +bool ena

[Xen-devel] [ovmf test] 129952: regressions - FAIL

2018-11-13 Thread osstest service owner
flight 129952 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129952/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

Re: [Xen-devel] [PATCH v4 2/2] xen: use SYMBOL when required

2018-11-13 Thread Julien Grall
Hi, On 13/11/2018 12:56, Jan Beulich wrote: On 13.11.18 at 00:06, wrote: >> --- a/xen/arch/x86/alternative.c >> +++ b/xen/arch/x86/alternative.c >> @@ -194,7 +194,7 @@ void init_or_livepatch apply_alternatives(struct >> alt_instr *start, >>* So be careful if you want to change the s

[Xen-devel] [xen-unstable-smoke test] 129944: regressions - FAIL

2018-11-13 Thread osstest service owner
flight 129944 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129944/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 129852 Tests which

Re: [Xen-devel] [PATCH v4 2/2] xen: use SYMBOL when required

2018-11-13 Thread Jan Beulich
>>> On 13.11.18 at 14:17, wrote: > On 13/11/2018 12:56, Jan Beulich wrote: > On 13.11.18 at 00:06, wrote: >>> --- a/xen/arch/x86/alternative.c >>> +++ b/xen/arch/x86/alternative.c >>> @@ -194,7 +194,7 @@ void init_or_livepatch apply_alternatives(struct >>> alt_instr *start, >>>* So b

Re: [Xen-devel] [PATCH 4/3] x86/HVM: hvm_map_guest_frame_rw() should respect p2m_ioreq_server

2018-11-13 Thread Igor Druzhinin
On 13/11/2018 10:46, Jan Beulich wrote: > Writes to such pages would need to be handed to the emulator, which we're > not prepared to do at this point. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -2556,7 +2556,8 @@ static void *_hvm_map_gue

Re: [Xen-devel] [PATCH 0/3] automation: build Xen on Arm64

2018-11-13 Thread Doug Goldstein
> On Nov 7, 2018, at 6:31 AM, Wei Liu wrote: > > Hi all > > This is my first attempt to quickly get something useful for Arm in Gitlab CI > with a machine borrowed from Packet.NET Thanks for getting this done Wei! For the whole series: Acked-by: Doug Goldstein __

Re: [Xen-devel] [PATCH] libx86: Fix 32bit stubdom build of x86_cpuid_policy_fill_native()

2018-11-13 Thread Roger Pau Monné
On Tue, Nov 13, 2018 at 11:59:15AM +, Andrew Cooper wrote: > With -m32, GCC generates a warning for &size_t == &unsigned long, which is the > typecheck hidden inside the min() macro. > > Switch to using explicitly typed versions instead. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger P

Re: [Xen-devel] [PATCH 4/3] x86/HVM: hvm_map_guest_frame_rw() should respect p2m_ioreq_server

2018-11-13 Thread Jan Beulich
>>> On 13.11.18 at 14:39, wrote: > On 13/11/2018 10:46, Jan Beulich wrote: >> Writes to such pages would need to be handed to the emulator, which we're >> not prepared to do at this point. >> >> Signed-off-by: Jan Beulich >> >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@

Re: [Xen-devel] [PATCH v2 1/5] xen/domain: Introduce a new sanitise_domain_config() helper

2018-11-13 Thread Jan Beulich
>>> On 12.11.18 at 17:16, wrote: > Call it from the head of domain_create() (before doing any memory > allocations), which will apply the checks to dom0 as well as domU's. > > For now, just subsume the XEN_DOMCTL_CDF_* check from > XEN_DOMCTL_createdomain. And the needless assignment of a domai

Re: [Xen-devel] [PATCH v2 3/5] xen/domain: Stricter configuration checking

2018-11-13 Thread Jan Beulich
>>> On 12.11.18 at 17:16, wrote: > Currently, a number of options passed for domain creation are ignored, or have > implicit fallback behaviour. This is bad for forwards compatibility, and for > end users to be certain that they got the configuration they asked for. > > With this change: > * AR

[Xen-devel] [ovmf test] 129957: regressions - FAIL

2018-11-13 Thread osstest service owner
flight 129957 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129957/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

Re: [Xen-devel] [PATCH v2 4/5] xen/domain: Allocate d->vcpu[] earlier during domain_create()

2018-11-13 Thread Jan Beulich
>>> On 12.11.18 at 17:16, wrote: > The ARM code has a chicken-and-egg problem. One of the vGIC_v3 emulations > wants to know d->max_vcpus to be able to size itself appropriately, but the > current order of initialisation requires the vGIC to be set up before the > requested number of vcpus can be

Re: [Xen-devel] [PATCH v2 3/5] xen/domain: Stricter configuration checking

2018-11-13 Thread Wei Liu
On Tue, Nov 13, 2018 at 07:14:24AM -0700, Jan Beulich wrote: > >>> On 12.11.18 at 17:16, wrote: > > Currently, a number of options passed for domain creation are ignored, or > > have > > implicit fallback behaviour. This is bad for forwards compatibility, and > > for > > end users to be certain

Re: [Xen-devel] [PATCH v2 3/5] xen/domain: Stricter configuration checking

2018-11-13 Thread Andrew Cooper
On 13/11/2018 14:36, Wei Liu wrote: > On Tue, Nov 13, 2018 at 07:14:24AM -0700, Jan Beulich wrote: > On 12.11.18 at 17:16, wrote: >>> Currently, a number of options passed for domain creation are ignored, or >>> have >>> implicit fallback behaviour. This is bad for forwards compatibility, an

Re: [Xen-devel] [PATCH v2 3/5] xen/domain: Stricter configuration checking

2018-11-13 Thread Wei Liu
On Tue, Nov 13, 2018 at 02:39:43PM +, Andrew Cooper wrote: > On 13/11/2018 14:36, Wei Liu wrote: > > On Tue, Nov 13, 2018 at 07:14:24AM -0700, Jan Beulich wrote: > > On 12.11.18 at 17:16, wrote: > >>> Currently, a number of options passed for domain creation are ignored, or > >>> have > >

[Xen-devel] [linux-4.9 test] 129763: regressions - FAIL

2018-11-13 Thread osstest service owner
flight 129763 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/129763/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 7 xen-boot fail REGR. vs. 128925 test-armhf-armhf-xl-c

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-13 Thread Julien Grall
On 13/11/2018 10:23, Julien Grall wrote: Hi, On 12/11/2018 11:30, Mirela Simonovic wrote: +/* + * This function sets the context of current VCPU to the state which is expected + * by the guest on resume. The expected VCPU state is: + * 1) pc to contain resume entry point (1st argument of PSC

Re: [Xen-devel] [PATCH v2 3/5] xen/domain: Stricter configuration checking

2018-11-13 Thread Andrew Cooper
On 13/11/2018 14:14, Jan Beulich wrote: On 12.11.18 at 17:16, wrote: >> Currently, a number of options passed for domain creation are ignored, or >> have >> implicit fallback behaviour. This is bad for forwards compatibility, and for >> end users to be certain that they got the configuratio

[Xen-devel] [linux-linus bisection] complete test-amd64-i386-qemut-rhel6hvm-amd

2018-11-13 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-qemut-rhel6hvm-amd testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditio

[Xen-devel] [ovmf test] 129963: regressions - FAIL

2018-11-13 Thread osstest service owner
flight 129963 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129963/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

Re: [Xen-devel] [PATCH v6.1 05/11] libxl_qmp: Implementation of libxl__ev_qmp_*

2018-11-13 Thread Anthony PERARD
On Tue, Nov 13, 2018 at 01:14:30PM +, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH v6.1 05/11] libxl_qmp: Implementation of > libxl__ev_qmp_*"): > ... > > I think this was intended to satisfy my request for comments about > legal states: > > > +/* helpers */ > > + > > +static void qmp

Re: [Xen-devel] [PATCH v4 06/44] x86emul: test for correct EVEX Disp8 scaling

2018-11-13 Thread Andrew Cooper
On 13/11/2018 11:12, Jan Beulich wrote: On 12.11.18 at 18:42, wrote: >> On 25/09/18 14:29, Jan Beulich wrote: >>> Besides the already existing tests (which are going to be extended once >>> respective ISA extension support is complete), let's also ensure for >>> every individual insn that the

Re: [Xen-devel] [PATCH v4 07/44] x86emul: also allow running the 32-bit harness on a 64-bit distro

2018-11-13 Thread Andrew Cooper
On 13/11/2018 11:42, Jan Beulich wrote: On 12.11.18 at 18:50, wrote: >> On 25/09/18 14:29, Jan Beulich wrote: >>> In order to be able to verify the 32-bit variant builds and runs, >>> introduce a respective target (and the necessary other adjustments). >>> >>> Signed-off-by: Jan Beulich >> I

Re: [Xen-devel] [Qemu-devel] [PATCH v5 10/24] hw: acpi: Export the PCI host and holes getters

2018-11-13 Thread Igor Mammedov
On Mon, 5 Nov 2018 02:40:33 +0100 Samuel Ortiz wrote: > This is going to be needed by the hardware reduced implementation, so > let's export it. > Once the ACPI builder methods and getters will be implemented, the > acpi_get_pci_host() implementation will become hardware agnostic. > > Signed-of

Re: [Xen-devel] [PATCH v6.1 05/11] libxl_qmp: Implementation of libxl__ev_qmp_*

2018-11-13 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH v6.1 05/11] libxl_qmp: Implementation of libxl__ev_qmp_*"): > On Tue, Nov 13, 2018 at 01:14:30PM +, Ian Jackson wrote: > > This one is probably an asisstant for transitioning between states so > > the pre- and post-conditions may not be pure. Whatever it is

[Xen-devel] [xen-unstable-smoke test] 129960: tolerable all pass - PUSHED

2018-11-13 Thread osstest service owner
flight 129960 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129960/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[Xen-devel] [linux-3.18 bisection] complete test-amd64-i386-xl-raw

2018-11-13 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-raw testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tr

Re: [Xen-devel] [PATCH v2 3/5] xen/domain: Stricter configuration checking

2018-11-13 Thread Jan Beulich
>>> On 13.11.18 at 16:07, wrote: > On 13/11/2018 14:14, Jan Beulich wrote: > On 12.11.18 at 17:16, wrote: >>> --- a/xen/arch/x86/domain.c >>> +++ b/xen/arch/x86/domain.c >>> @@ -420,6 +420,46 @@ void arch_vcpu_destroy(struct vcpu *v) >>> >>> int arch_sanitise_domain_config(struct xen_domct

[Xen-devel] [ovmf test] 129969: regressions - FAIL

2018-11-13 Thread osstest service owner
flight 129969 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129969/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

Re: [Xen-devel] [PATCH v2 3/5] xen/domain: Stricter configuration checking

2018-11-13 Thread Jan Beulich
>>> On 13.11.18 at 15:39, wrote: > On 13/11/2018 14:36, Wei Liu wrote: >> On Tue, Nov 13, 2018 at 07:14:24AM -0700, Jan Beulich wrote: >> On 12.11.18 at 17:16, wrote: Currently, a number of options passed for domain creation are ignored, or have implicit fallback behaviour. T

Re: [Xen-devel] [PATCH v4 05/44] x86emul: support basic AVX512 moves

2018-11-13 Thread Andrew Cooper
On 25/09/2018 14:28, Jan Beulich wrote: > +#define avx512_vlen_check(lig) do { \ > +switch ( evex.lr ) \ > +{ \ > +default: \ > +generate_exception(EXC_UD); \ > +case 2: \ > +break; \ > +case 0: case 1: \ > +if (!(lig)) \ if ( !(lig) ) > +ho

[Xen-devel] [PATCH v7b 17/25] xen/arm: generate a simple device tree for domUs

2018-11-13 Thread Stefano Stabellini
Introduce functions to generate a basic domU device tree, similar to the existing functions in tools/libxl/libxl_arm.c. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v5: - use d->arch.vgic.version Changes in v4: - code style - two separate functions for gicv2 and gicv3

[Xen-devel] [PATCH v7b 24/25] xen/arm: move kernel.h to asm-arm/

2018-11-13 Thread Stefano Stabellini
It will be #included by a file in a xen/arch/arm subdirectory. Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall --- xen/arch/arm/domain_build.c | 2 +- xen/arch/arm/kernel.c| 3 +- xen/arch/arm/kernel.h| 86 xen/include/

[Xen-devel] [PATCH v7b 10/25] xen/arm: rename get_11_allocation_size to get_allocation_size

2018-11-13 Thread Stefano Stabellini
No functional changes. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v3: - no change in print messages - do not remove BUG_ON Changes in v2: - new patch --- xen/arch/arm/domain_build.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/

[Xen-devel] [PATCH v7b 21/25] xen/arm: refactor vpl011_data_avail

2018-11-13 Thread Stefano Stabellini
Move the code to calculate in_fifo_level and out_fifo_level out of vpl011_data_avail, to the caller. This change will make it possible to reuse vpl011_data_avail with different ring structures in a later patch. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v3: - remove

[Xen-devel] [PATCH v7b 12/25] xen/arm: introduce allocate_memory

2018-11-13 Thread Stefano Stabellini
Introduce an allocate_memory function able to allocate memory for DomUs and map it at the right guest addresses, according to the guest memory map: GUEST_RAM0_BASE and GUEST_RAM1_BASE. This is under #if 0 as not used for now. Signed-off-by: Julien Grall Signed-off-by: Stefano Stabellini --- Cha

[Xen-devel] [PATCH v7b 23/25] xen/arm: Allow vpl011 to be used by DomU

2018-11-13 Thread Stefano Stabellini
Make vpl011 being able to be used without a userspace component in Dom0. In that case, output is printed to the Xen serial and input is received from the Xen serial one character at a time. Call domain_vpl011_init during construct_domU if vpl011 is enabled. Introduce a new ring struct with only t

[Xen-devel] [PATCH v7b 07/25] xen/arm: don't add duplicate boot modules, introduce domU flag

2018-11-13 Thread Stefano Stabellini
Don't add duplicate boot modules (same kind and same start address), they are freed later, we don't want to introduce double-free errors. Introduce a domU flag in struct bootmodule and struct bootcmdline. Set it for kernels and ramdisks of "xen,domain" nodes to avoid getting confused in kernel_pro

[Xen-devel] [PATCH v7b 05/25] xen/arm: check for multiboot nodes only under /chosen

2018-11-13 Thread Stefano Stabellini
Make sure to only look for multiboot compatible nodes only under /chosen, not under any other paths (depth <= 3). Signed-off-by: Stefano Stabellini --- Changes in v7: - set path size to 92, treat -FDT_ERR_NOSPACE as erro Changes in v6: - do not proceed if fdt_get_path returns error != -FDT_ERR

[Xen-devel] [PATCH v7b 18/25] xen/arm: make set_interrupt_ppi able to handle non-PPI

2018-11-13 Thread Stefano Stabellini
also rename it to set_interrupt. Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall --- xen/arch/arm/domain_build.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 882291

[Xen-devel] [PATCH v7b 19/25] xen/arm: generate vpl011 node on device tree for domU

2018-11-13 Thread Stefano Stabellini
Introduce vpl011 support to guests started from Xen: it provides a simple way to print output from a guest, as most guests come with a pl011 driver. It is also able to provide a working console with interrupt support. The UART exposed to the guest is a SBSA compatible UART and not a PL011. SBSA UA

[Xen-devel] [PATCH v7b 14/25] xen/arm: move unregister_init_virtual_region to init_done

2018-11-13 Thread Stefano Stabellini
Move unregister_init_virtual_region to init_done. Follow the same path as x86. It is also useful to move it later so that create_domUs can be called before that in following patches. Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall --- xen/arch/arm/setup.c | 6 +++--- 1 file changed,

[Xen-devel] [PATCH v7b 03/25] xen/arm: document dom0less

2018-11-13 Thread Stefano Stabellini
Add a new document to provide information on how to use dom0less related features and their current limitations. Signed-off-by: Stefano Stabellini --- Changes in v5: - convert to markdown - move to docs/features - add entry to docs/INDEX Changes in v4: - rename to .txt - improve wording Change

[Xen-devel] [PATCH v7b 04/25] xen/arm: increase MAX_MODULES

2018-11-13 Thread Stefano Stabellini
Xen boot modules need to account not just for Dom0 but also for a few potential DomUs, each of them coming with their own kernel and initrd. Increase MAX_MODULES to 32 to allow for more DomUs. Signed-off-by: Stefano Stabellini Reviewed-by: Doug Goldstein --- xen/include/asm-arm/setup.h | 2 +-

[Xen-devel] [PATCH v7b 13/25] xen/arm: refactor construct_dom0

2018-11-13 Thread Stefano Stabellini
Move generic initializations out of construct_dom0 so that they can be reused. Rename prepare_dtb to prepare_dtb_hwdom to avoid confusion. No functional changes in this patch. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v5: - rename __construct_domain to construct_

[Xen-devel] [PATCH v7b 25/25] xen/arm: split domain_build.c

2018-11-13 Thread Stefano Stabellini
domain_build.c is too large. Move all the ACPI specific device tree generating functions from domain_build.c to acpi/domain_build.c. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v7: - build domain_build.init.o - remove "static" from prepare_acpi implementation Chang

  1   2   >