Re: [Xen-devel] Interrupt injection with ISR set on Intel hardware

2018-10-30 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Thursday, October 25, 2018 9:58 PM > > >>> On 25.10.18 at 15:02, wrote: > > On 25/10/18 13:51, Jan Beulich wrote: > > On 15.10.18 at 14:06, wrote: > >>> From the debugging, we see that PPR/IRR/ISR appear to retain their > state > >>> acr

Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Juergen Gross
On 29/10/2018 19:31, Manjunath Patil wrote: > info->nr_rings isn't adjusted in case of ENOMEM error from > negotiate_mq(). This leads to kernel panic in error path. > > Typical call stack involving panic - > #8 page_fault at 8175936f > [exception RIP: blkif_free_ring+33] > RIP: ff

Re: [Xen-devel] [PATCH 1/4] x86/vvmx: Unconditionally initialise vmxon_region_pa during vcpu construction

2018-10-30 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, October 25, 2018 11:37 PM > > This is a stopgap solution until the toolstack side of initialisation can be > sorted out, but it does result in the nvmx_vcpu_in_vmx() predicate working > correctly even when nested virt hasn'

Re: [Xen-devel] [Xen-users] [XEN][ARM] WiFi bridge creation

2018-10-30 Thread Vladimir Botka
On Tue, 30 Oct 2018 10:03:22 +0530 Vikram K wrote: > Hello, > We are using Hikey960 with Debian as Dom0 and DomU. This board has only > WiFi interface. We want to create bridge between Dom0 and DomU so that DomU > has internet access. We tried to create bridge using brtcl command, but it > is not

Re: [Xen-devel] [PATCH 2/4] x86/vvmx: Drop the now-obsolete vmx_inst_check_privilege()

2018-10-30 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, October 25, 2018 11:39 PM > > Now that nvmx_handle_vmx_insn() performs all VT-x instruction checks, > there is > no need for redundant checking in vmx_inst_check_privilege(). Remove it, > and > take out the vmxon_check boo

Re: [Xen-devel] [PATCH 3/4] x86/vvmx: INVVPID instructions should be handled at by L1

2018-10-30 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, October 25, 2018 11:39 PM > > Signed-off-by: Andrew Cooper Acked-by: Kevin Tian ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/

Re: [Xen-devel] [PATCH 4/4] x86/vvmx: Don't handle unknown nested vmexit reasons at L0

2018-10-30 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, October 25, 2018 11:39 PM > > This is very dangerous from a security point of view, because a missing > entry > will cause L2's action to be interpreted as L1's action. > > Signed-off-by: Andrew Cooper Acked-by: Kevin Ti

[Xen-devel] [linux-next test] 129127: tolerable FAIL

2018-10-30 Thread osstest service owner
flight 129127 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/129127/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-boot fail like 129105 test-amd64-i386-xl-qemut-stubdom-debia

Re: [Xen-devel] [PATCH v2 5/5] x86: Reorganise and rename debug register fields in struct vcpu

2018-10-30 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Monday, October 15, 2018 6:36 PM > > Reusing debugreg[5] for the PV emulated IO breakpoint information is > confusing > to read. Instead, introduce a dr7_emul field in pv_vcpu for the pupose. > > With the PV emulation out of the wa

Re: [Xen-devel] Interrupt injection with ISR set on Intel hardware

2018-10-30 Thread Jan Beulich
>>> On 29.10.18 at 18:06, wrote: > On 29/10/18 16:58, Jan Beulich wrote: > On 29.10.18 at 17:44, wrote: >>> On 29/10/18 16:33, Jan Beulich wrote: >>> On 15.10.18 at 12:30, wrote: > (XEN) [22641] PUSH {sp 0, irq 30, vec 0x21} This is the last push or pop. > (XEN)

Re: [Xen-devel] [PATCH v1 1/6] x86/vvmx: introduce vvmcx_valid()

2018-10-30 Thread Tian, Kevin
> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] > Sent: Friday, October 12, 2018 11:28 PM > > As a convenient helper function and refactor the code to use it. > > No functional change. > > Signed-off-by: Sergey Dyasli since vmcx is hvm abstracted term, what about using this helper in s

Re: [Xen-devel] [PATCH v1 2/6] x86/vvmx: correct vmfail() usage for vmptrld and vmclear

2018-10-30 Thread Tian, Kevin
> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] > Sent: Friday, October 12, 2018 11:28 PM > > Calling vmfail_valid() is correct only if vvmcx is valid. Modify > functions to use vmfail() instead which performs the necessary check. > > Signed-off-by: Sergey Dyasli Acked-by: Kevin Tian .

[Xen-devel] [GIT PULL] xen: fixes for 4.20-rc1

2018-10-30 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.20a-rc1-tag xen: fixes for 4.20-rc1 It contains only several small fixes and cleanups this time. Thanks. Juergen MAINTAINERS| 1 + arch/x86/xen/platfor

Re: [Xen-devel] [PATCH v1 3/6] x86/vvmx: add VMX_INSN_VMPTRLD_WITH_VMXON_PTR errno

2018-10-30 Thread Tian, Kevin
> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] > Sent: Friday, October 12, 2018 11:28 PM > > And make nvmx_handle_vmptrld() return the new errno in case the > provided > address is the same as vmxon region address. > > While at it, correct the return value for not-4KB-aligned case. > >

Re: [Xen-devel] [PATCH v1 4/6] x86/vvmx: add VMX_INSN_VMCLEAR_WITH_VMXON_PTR errno

2018-10-30 Thread Tian, Kevin
> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] > Sent: Friday, October 12, 2018 11:28 PM > > And make nvmx_handle_vmclear() return the new errno in case the > provided > address is the same as vmxon region address. > > While at it, correct the return value for not-4KB-aligned case and fo

[Xen-devel] [ovmf test] 129171: all pass - PUSHED

2018-10-30 Thread osstest service owner
flight 129171 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129171/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4222e8e7e421e9c8d2c2f319a3860dd3332d6255 baseline version: ovmf c87ac38cf280fa969f103

Re: [Xen-devel] [PATCH v1 5/6] x86/vvmx: correctly report vvmcs size

2018-10-30 Thread Tian, Kevin
> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] > Sent: Friday, October 12, 2018 11:28 PM > > The size of Xen's virtual vmcs region is 4096 bytes. Correctly report > it to the guest in case when VMCS shadowing is not available instead of > providing H/W value (which is usually smaller). w

Re: [Xen-devel] [PATCH 1/4] xen/arm: gic: Ensure we have an ISB between ack and do_IRQ()

2018-10-30 Thread Andrii Anisov
Hi, On 29.10.18 18:22, Julien Grall wrote: > What is the issue? Is it just your print or there a latent bug in > current vGIC? Ah, OK, that was the issue for me. > I actually prefer if we re-enable interrupts after > entry_hypervisor_head(). This makes the code working the same way > everyw

[Xen-devel] [qemu-mainline test] 129131: tolerable FAIL - PUSHED

2018-10-30 Thread osstest service owner
flight 129131 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/129131/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 129079 test-armhf-armhf-libvirt 14 sav

Re: [Xen-devel] [PATCH] xen-swiotlb: exchange memory with Xen only when pages are contiguous

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Joe Jin > Sent: 30 October 2018 02:52 > To: Boris Ostrovsky ; Konrad Rzeszutek Wilk > > Cc: John Sobecki ; DONGLI.ZHANG > ; linux-ker...@vger.kernel.org" ker...@vger.kernel.org>; kon...@k

[Xen-devel] [ovmf baseline-only test] 75543: tolerable FAIL

2018-10-30 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75543 ovmf real [real] http://osstest.xensource.com/osstest/logs/75543/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: build-amd64-libvirt 6 libvirt-buildfail like 75537 buil

Re: [Xen-devel] [PATCH v2] arm, smmu: backport "Disable stalling faults for all endpoints"

2018-10-30 Thread Jan Beulich
>>> On 29.10.18 at 22:14, wrote: > From: Stefano Stabellini > > Backport commit 3714ce1d6655098ee69ede632883e5874d67e4ab > "iommu/arm-smmu: Disable stalling faults for all endpoints" from the > Linux kernel. This works-around Erratum #842869. Btw, seeing this having gone in a few hours ago I go

Re: [Xen-devel] [PATCH 1/8] viridian: move the code into its own sub-directory

2018-10-30 Thread Jan Beulich
>>> On 29.10.18 at 19:02, wrote: > Subsequent patches will introduce support for more viridian enlightenments > which will make a single source module quite lengthy. > > This patch therefore creates a new arch/x86/hvm/viridian sub-directory and > moves viridian.c into that. > > The patch also fi

Re: [Xen-devel] [Xen-users] [XEN][ARM] WiFi bridge creation

2018-10-30 Thread Vikram K
Hi, As per below link, it is possible to share Internet via WiFi between Dom0 and DomU,. https://wiki.xenproject.org/wiki/Xen_in_WiFi_networks Tried the suggested solution using ebtables, but it did not work. * ebtables -t nat -A POSTROUTING -s 00:60:00:00:00:01 \ -j snat -

[Xen-devel] [PATCH v5] arch/x86: Add registers to vm_event

2018-10-30 Thread Alexandru Stefan ISAILA
This patch adds a couple of regs to the vm_event that are used by the introspection. The base, limit and ar bits are compressed into a uint64_t union so as not to enlarge the vm_event. Signed-off-by: Alexandru Isaila --- Changes since V4: - Change the comment into one line - Pull

[Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise

2018-10-30 Thread Christian Lindig
The type of Xsraw.sync is made more precise: from val sync : (Xenbus.Xb.t -> 'a) -> con -> string to val sync : (Xenbus.Xb.t -> unit) -> con -> string The first argument is enforced to return unit rather than a value that is not used anyway. Signed-off-by: Christian Lindig --- tools/ocaml/li

Re: [Xen-devel] [Xen-users] [XEN][ARM] WiFi bridge creation

2018-10-30 Thread Vladimir Botka
> On Tue, Oct 30, 2018 at 12:39 PM Vladimir Botka wrote: > > On Tue, 30 Oct 2018 10:03:22 +0530 > > Vikram K wrote: > > > Hello, > > > We are using Hikey960 with Debian as Dom0 and DomU. This board has only > > > WiFi interface. We want to create bridge between Dom0 and DomU so that > > > DomU

Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 11:31:56AM -0700, Manjunath Patil wrote: > info->nr_rings isn't adjusted in case of ENOMEM error from > negotiate_mq(). This leads to kernel panic in error path. > > Typical call stack involving panic - > #8 page_fault at 8175936f > [exception RIP: blkif_free_r

[Xen-devel] [OSSTEST PATCH] production-config-cambridge: Use squid cache, not local apt proxy

2018-10-30 Thread Ian Jackson
debian.uk.xensource.com is no more (and the service name seems to have been discarded). There is repo.citrite.net instead but it is a proprietary appliance which - although it claims to be able to handle apt repositories - is not compatible with debian-installer; at least, jessie's d-i. Swap to f

Re: [Xen-devel] [PATCH v2 7/7] amd/pvh: enable ACPI C1E disable quirk on PVH Dom0

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 08:19:20AM -0600, Jan Beulich wrote: > >>> On 19.10.18 at 17:20, wrote: > > --- a/xen/arch/x86/hvm/svm/svm.c > > +++ b/xen/arch/x86/hvm/svm/svm.c > > @@ -1272,6 +1272,24 @@ void svm_host_osvw_init() > > spin_unlock(&osvw_lock); > > } > > > > +static int acpi_c1e_qui

Re: [Xen-devel] [RFC 07/16] xen/arm: p2m: Introduce p2m_is_valid and use it

2018-10-30 Thread Julien Grall
Hi, On 30/10/2018 00:21, Stefano Stabellini wrote: On Mon, 8 Oct 2018, Julien Grall wrote: The LPAE format allows to store information in an entry even with the valid bit unset. In a follow-up patch, we will take advantage of this feature to re-purpose the valid bit for generating a translation

Re: [Xen-devel] [PATCH v2 2/7] x86/hvm: introduce a define for the debug output IO port

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 10:51:07AM -0600, Jan Beulich wrote: > >>> On 19.10.18 at 17:20, wrote: > > No functional change intended. > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Jan Beulich > with one remark: > > > --- a/xen/include/public/arch-x86/xen.h > > +++ b/xen/include/public/

Re: [Xen-devel] [PATCH v5 22/25] xen/arm: Allow vpl011 to be used by DomU

2018-10-30 Thread Oleksandr Tyshchenko
On Mon, Oct 29, 2018 at 10:03 PM Stefano Stabellini wrote: > > On Wed, 24 Oct 2018, Oleksandr Tyshchenko wrote: > > Hi, Stefano > > > > On Tue, Oct 23, 2018 at 5:04 AM Stefano Stabellini > > wrote: > > > > > > Make vpl011 being able to be used without a userspace component in Dom0. > > > In that

Re: [Xen-devel] [PATCH v2 3/7] x86/pvh: allow PVH Dom0 to use the debug IO port console

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 11:03:37AM -0600, Jan Beulich wrote: > >>> On 29.10.18 at 17:53, wrote: > > On 19/10/18 16:20, Roger Pau Monne wrote: > >> Add an option to allow trapping accesses to IO port 0xe9 for a PVH > >> Dom0, so it can print to the HVM debug console. Note this is not > >> enabled b

Re: [Xen-devel] [PATCH v8 0/8] Allow setting up shared memory areas between VMs from xl config files

2018-10-30 Thread Oleksandr Tyshchenko
Hi, Julien. On Wed, Oct 24, 2018 at 5:25 PM Julien Grall wrote: > > > > On 10/24/18 3:15 PM, Oleksandr Tyshchenko wrote: > > Hi, Stefano > > > > On Sat, Oct 20, 2018 at 12:07 AM Stefano Stabellini > > wrote: > >> > >> Hi Wei, > >> > >> Any chances you can review this series soon? I would love fo

[Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

2018-10-30 Thread Christian Lindig
Commit 81946a73dc975a7dafe9017a8e61d1e64fdbedbf removed Xenctrl.with_intf based on its undesirable behaviour of opening and closing a Xenctrl connection with every invocation. This commit re-introduces with_intf but with an updated behaviour: it maintains a global Xenctrl connection which is opened

Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 03:19:34PM +0100, Juergen Gross wrote: > On 29/10/2018 13:57, Roger Pau Monné wrote: > > On Fri, Oct 19, 2018 at 06:39:50PM +0200, Juergen Gross wrote: > >> On 19/10/2018 18:10, Roger Pau Monné wrote: > >>> On Tue, Oct 09, 2018 at 01:03:11PM +0200, Juergen Gross wrote: > >>>

[Xen-devel] [PULL v2 01/20] configs/alpha: Remove unused CONFIG_PARALLEL_ISA switch

2018-10-30 Thread Laurent Vivier
From: Thomas Huth We don't use CONFIG_PARALLEL_ISA in any of our Makefiles, so this is just a dead config option which can be removed. Fixes: a4cb773928e047b137c6998209cf2eec857fac6b Signed-off-by: Thomas Huth Acked-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <154037

[Xen-devel] [PULL v2 16/20] tests/bios-tables-test: Remove an useless cast

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/typecast.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by: M

[Xen-devel] [PULL v2 13/20] configure: Support pkg-config for zlib

2018-10-30 Thread Laurent Vivier
From: Stefan Weil This is needed for builds with the mingw64-* packages from Cygwin, but also works for Linux. Move the zlib test also more to the end because users should get information on the really important missing packages (which also require zlib) first. Signed-off-by: Stefan Weil Revie

[Xen-devel] [PULL v2 03/20] memory.h: fix typos in comments

2018-10-30 Thread Laurent Vivier
From: Li Qiang Signed-off-by: Li Qiang Reviewed-by: Peter Maydell Message-Id: <1539080467-2976-1-git-send-email-liq...@gmail.com> [lv: s/types/typos/] Signed-off-by: Laurent Vivier --- include/exec/memory.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/exec

[Xen-devel] [PULL v2 12/20] tests: Fix typos in comments and help message (found by codespell)

2018-10-30 Thread Laurent Vivier
From: Stefan Weil Fix also a grammar issue. Signed-off-by: Stefan Weil Reviewed-by: Alex Bennée Message-Id: <20180713054755.23323-1...@weilnetz.de> Signed-off-by: Laurent Vivier --- tests/bios-tables-test.c | 2 +- tests/docker/Makefile.include | 2 +- tests/docker/docke

[Xen-devel] [PULL v2 04/20] tests/tcg/README: fix location for lm32 tests

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa Point to the right and obvious location for lm32 tests. Signed-off-by: Cleber Rosa Reviewed-by: Thomas Huth Acked-by: Alex Bennée Message-Id: <20181004161852.11673-3-cr...@redhat.com> Signed-off-by: Laurent Vivier --- tests/tcg/README | 2 +- 1 file changed, 1 insertion(+)

[Xen-devel] [PULL v2 05/20] qemu-iotests: fix filename containing checks

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa Commit cce293a2945 moved some functions from common.config to common.rc, but the error messages still reference the old file location. Signed-off-by: Cleber Rosa Reviewed-by: Max Reitz Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181004161852.11673-5-cr...@redhat.com>

[Xen-devel] [PULL v2 02/20] vga_int: remove unused function protype

2018-10-30 Thread Laurent Vivier
From: yuchenlin Signed-off-by: yuchenlin Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181022080053.9379-1-yuchen...@synology.com> Signed-off-by: Laurent Vivier --- hw/display/vga_int.h | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h index 6

[Xen-devel] [PULL v2 08/20] scripts/qemu.py: remove trailing quotes on docstring

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181004161852.11673-11-cr...@redhat.com> Signed-off-by: Laurent Vivier --- scripts/qemu.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qemu.py b/scripts/qemu.py index

[Xen-devel] [PULL v2 11/20] cpu.h: fix a typo in comment

2018-10-30 Thread Laurent Vivier
From: Li Qiang Found by reading the code. Signed-off-by: Li Qiang Message-Id: <1536150548-2797-1-git-send-email-liq...@gmail.com> Signed-off-by: Laurent Vivier --- include/qom/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index

[Xen-devel] [PULL v2 14/20] qobject: Catch another straggler for use of qdict_put_str()

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/qobject.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by: Mi

[Xen-devel] [PULL v2 17/20] hw/pci-host: Remove useless parenthesis around DIV_ROUND_UP macro

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/round.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by: Mich

[Xen-devel] [PULL v2 15/20] xen: Use the PCI_DEVICE macro

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé TYPE_XEN_PT_DEVICE is a subclass of TYPE_PCI_DEVICE, the clean way to access the PCIDevice pointer is using the PCI_DEVICE() macro. Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by: Anthony PERARD Acked-by:

[Xen-devel] [PULL v2 10/20] linux-user: fix comment s/atomic_write/atomic_set/

2018-10-30 Thread Laurent Vivier
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Message-Id: <20180811211011.6277-1-c...@braap.org> Signed-off-by: Laurent Vivier --- linux-user/qemu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h index 1beb6a2cfc..dde3f26f5a 100

[Xen-devel] [PULL v2 06/20] docs/devel/testing.rst: add missing newlines after code block

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa The line immediate following a ".. code::" block is considered to contains arguments to the "code directive". The lack of a new line gives me during at parse time: testing.rst:63: (ERROR/3) Error in "code" directive: maximum 1 argument(s) allowed, 3 supplied. .. code

[Xen-devel] [PULL v2 00/20] Qemu trivial for 3.1 patches

2018-10-30 Thread Laurent Vivier
The following changes since commit 808ebd66e467f77c0d1f8c6346235f81e9c99cf2: Merge remote-tracking branch 'remotes/riscv/tags/riscv-for-master-3.1-sf0' into staging (2018-10-25 17:41:03 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/qemu-trivial-for-3.1

[Xen-devel] [PULL v2 09/20] qemu-iotests: make 218 executable

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa Commit 990dc39c made all tests executable at the time, but 218 came in later, and missing those permissions. Signed-off-by: Cleber Rosa Message-Id: <20181004161852.11673-4-cr...@redhat.com> Signed-off-by: Laurent Vivier --- tests/qemu-iotests/218 | 0 1 file changed, 0 inser

Re: [Xen-devel] [RFC 08/16] xen/arm: p2m: Handle translation fault in get_page_from_gva

2018-10-30 Thread Julien Grall
On 30/10/2018 00:47, Stefano Stabellini wrote: On Mon, 8 Oct 2018, Julien Grall wrote: +return NULL; +} + +/* + * Check permission that are assumed by the caller. For instance + * in case of guestcopy, the caller assumes that the translated +

[Xen-devel] [PULL v2 18/20] hw/intc/gicv3: Remove useless parenthesis around DIV_ROUND_UP macro

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/round.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Message-Id: <201

[Xen-devel] [PULL v2 07/20] scripts/decodetree.py: remove unused imports

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181004161852.11673-8-cr...@redhat.com> Signed-off-by: Laurent Vivier --- scripts/decodetree.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/decodetree.py b/scripts/decodetree.py ind

[Xen-devel] [PULL v2 19/20] ppc: move at24c to its own CONFIG_ symbol

2018-10-30 Thread Laurent Vivier
From: Paolo Bonzini AT24c EEPROM is currently gated by CONFIG_I2C, and as such it is being included in all emulators that use I2C, even if they do not really need it. Separate it and, since it was added for the e500 machines, add it to qemu-system-ppc and qemu-system-ppc64. Signed-off-by: Paolo

[Xen-devel] [PULL v2 20/20] milkymist-minimac2: Use qemu_log_mask(GUEST_ERROR) instead of error_report

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé qemu_log_mask(GUEST_ERROR) is more appropriate: $ qemu -d help Log items (comma separated): guest_errorslog when the guest OS does something invalid (eg accessing a non-existent register) Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael Walle Mes

Re: [Xen-devel] [PATCH v5] arch/x86: Add registers to vm_event

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 11:07, wrote: > --- a/xen/include/public/vm_event.h > +++ b/xen/include/public/vm_event.h > @@ -29,7 +29,7 @@ > > #include "xen.h" > > -#define VM_EVENT_INTERFACE_VERSION 0x0003 > +#define VM_EVENT_INTERFACE_VERSION 0x0004 > > #if defined(__XEN__) || defined(__XE

[Xen-devel] [PATCH] x86/pv: Fix crash when using `xl set-parameter pcid=...`

2018-10-30 Thread Andrew Cooper
"pcid=" is registered as a runtime parameter, which means that parse_pcid() must not reside in .init, or the following happens when parse_params() tries to call an unmapped function pointer. (XEN) [ Xen-4.12-unstable x86_64 debug=y Not tainted ] (XEN) CPU:0 (XEN) RIP:e008

Re: [Xen-devel] [PATCH v2 7/7] amd/pvh: enable ACPI C1E disable quirk on PVH Dom0

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 12:00, wrote: > On Mon, Oct 29, 2018 at 08:19:20AM -0600, Jan Beulich wrote: >> >>> On 19.10.18 at 17:20, wrote: >> > --- a/xen/arch/x86/hvm/svm/svm.c >> > +++ b/xen/arch/x86/hvm/svm/svm.c >> > @@ -1272,6 +1272,24 @@ void svm_host_osvw_init() >> > spin_unlock(&osvw_lock);

Re: [Xen-devel] [PATCH] x86/pv: Fix crash when using `xl set-parameter pcid=...`

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 12:35, wrote: > "pcid=" is registered as a runtime parameter, which means that parse_pcid() > must not reside in .init, or the following happens when parse_params() tries > to call an unmapped function pointer. > > (XEN) [ Xen-4.12-unstable x86_64 debug=y Not tainted

Re: [Xen-devel] [PATCH v5 07/25] xen/arm: don't add duplicate boot modules, introduce domU flag

2018-10-30 Thread Julien Grall
Hi Stefano, On 23/10/2018 03:02, Stefano Stabellini wrote: Don't add duplicate boot modules (same kind and same start address), they are freed later, we don't want to introduce double-free errors. Introduce a domU flag in struct bootmodule and struct bootcmdline. Set it for kernels and ramdisks

[Xen-devel] [distros-debian-snapshot test] 75544: trouble: broken/fail/pass

2018-10-30 Thread Platform Team regression test user
flight 75544 distros-debian-snapshot real [real] http://osstest.xensource.com/osstest/logs/75544/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-i386-current-netinst-pygrubbroken Tests w

Re: [Xen-devel] [PATCH v5 08/25] xen/arm: probe domU kernels and initrds

2018-10-30 Thread Julien Grall
Hi Stefano, On 23/10/2018 03:02, Stefano Stabellini wrote: Find addresses, sizes on device tree from kernel_probe. Find the cmdline from the bootcmdlines array. Introduce a new boot_module_find_by_addr_and_kind function to match not just on boot module kind, but also by address so that we can s

Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

2018-10-30 Thread Juergen Gross
On 30/10/2018 12:23, Roger Pau Monné wrote: > On Mon, Oct 29, 2018 at 03:19:34PM +0100, Juergen Gross wrote: >> On 29/10/2018 13:57, Roger Pau Monné wrote: >>> On Fri, Oct 19, 2018 at 06:39:50PM +0200, Juergen Gross wrote: On 19/10/2018 18:10, Roger Pau Monné wrote: > On Tue, Oct 09, 2018

Re: [Xen-devel] [PATCH v5 11/25] xen/arm: introduce allocate_memory

2018-10-30 Thread Julien Grall
Hi, On 23/10/2018 03:02, Stefano Stabellini wrote: Introduce an allocate_memory function able to allocate memory for DomUs and map it at the right guest addresses, according to the guest memory map: GUEST_RAM0_BASE and GUEST_RAM1_BASE. This is under #if 0 as not used for now. Signed-off-by: St

Re: [Xen-devel] [PATCH v5] arch/x86: Add registers to vm_event

2018-10-30 Thread Razvan Cojocaru
On 10/30/18 1:33 PM, Jan Beulich wrote: On 30.10.18 at 11:07, wrote: >> --- a/xen/include/public/vm_event.h >> +++ b/xen/include/public/vm_event.h >> @@ -29,7 +29,7 @@ >> >> #include "xen.h" >> >> -#define VM_EVENT_INTERFACE_VERSION 0x0003 >> +#define VM_EVENT_INTERFACE_VERSION 0x000

Re: [Xen-devel] [PATCH v1 5/6] x86/vvmx: correctly report vvmcs size

2018-10-30 Thread Sergey Dyasli
On 30/10/2018 08:06, Tian, Kevin wrote: >> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] >> Sent: Friday, October 12, 2018 11:28 PM >> >> The size of Xen's virtual vmcs region is 4096 bytes. Correctly report >> it to the guest in case when VMCS shadowing is not available instead of >> provi

Re: [Xen-devel] [PATCH v1 1/6] x86/vvmx: introduce vvmcx_valid()

2018-10-30 Thread Sergey Dyasli
On 30/10/2018 07:41, Tian, Kevin wrote: >> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] >> Sent: Friday, October 12, 2018 11:28 PM >> >> As a convenient helper function and refactor the code to use it. >> >> No functional change. >> >> Signed-off-by: Sergey Dyasli > > since vmcx is hvm a

Re: [Xen-devel] [PATCH v5] arch/x86: Add registers to vm_event

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 13:26, wrote: > On 10/30/18 1:33 PM, Jan Beulich wrote: > On 30.10.18 at 11:07, wrote: >>> --- a/xen/include/public/vm_event.h >>> +++ b/xen/include/public/vm_event.h >>> @@ -29,7 +29,7 @@ >>> >>> #include "xen.h" >>> >>> -#define VM_EVENT_INTERFACE_VERSION 0x0003

Re: [Xen-devel] [PATCH] xen-swiotlb: exchange memory with Xen only when pages are contiguous

2018-10-30 Thread Joe Jin
On 10/30/18 1:59 AM, Paul Durrant wrote: >> On 10/25/18 11:56 AM, Joe Jin wrote: >>> I just discussed this patch with Boris in private, his opinions(Boris, >>> please correct me if any misunderstood) are: >>> >>> 1. With/without the check, both are incorrect, he thought we need to >>>prevented

Re: [Xen-devel] [Xen-users] [XEN][ARM] WiFi bridge creation

2018-10-30 Thread Vikram K
Thanks Vladimir. Can some one provide pointer/reference on how to use NAT to share WiFi between Dom0 and DomU. Followed the instruction provided in the below link, but no success. https://wiki.debian.org/BridgeNetworkConnections#Bridging_with_a_wireless_NIC On Tue, Oct 30, 2018 at 4:04 PM Vlad

Re: [Xen-devel] [PATCH] xen-swiotlb: exchange memory with Xen only when pages are contiguous

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Joe Jin > Sent: 30 October 2018 14:13 > To: Paul Durrant ; Boris Ostrovsky > ; Konrad Rzeszutek Wilk > > Cc: John Sobecki ; DONGLI.ZHANG > ; linux-ker...@vger.kernel.org" ker...@vger.kern

[Xen-devel] [PATCH] use consistent values when consuming runtime-changeable parameters

2018-10-30 Thread Jan Beulich
There's no guarantee that e.g. a switch() control expression's memory operand(s) get(s) read just once. Guard against the compiler producing "unexpected" code by sprinkling around some ACCESS_ONCE(). I'm leaving alone opt_conswitch[]: It gets accessed in quite a few places anyway, and an intermedi

[Xen-devel] [ovmf baseline-only test] 75546: regressions - FAIL

2018-10-30 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75546 ovmf real [real] http://osstest.xensource.com/osstest/logs/75546/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REG

Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 01:29:28PM +, Paul Durrant wrote: > The P2M code currently contains many loops to deal with the fact that, > while it may be require to handle page orders greater than 4k, the > IOMMU map and unmap functions do not. > This patch adds a page_order parameter to those funct

Re: [Xen-devel] [PATCH] xen-swiotlb: exchange memory with Xen only when pages are contiguous

2018-10-30 Thread Joe Jin
On 10/30/18 7:21 AM, Paul Durrant wrote: >> -Original Message- >> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf >> Of Joe Jin >> Sent: 30 October 2018 14:13 >> To: Paul Durrant ; Boris Ostrovsky >> ; Konrad Rzeszutek Wilk >> >> Cc: John Sobecki ; DONGLI.ZHANG >>

Re: [Xen-devel] [PATCH] xen-swiotlb: exchange memory with Xen only when pages are contiguous

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Joe Jin > Sent: 30 October 2018 14:48 > To: Paul Durrant ; Boris Ostrovsky > ; Konrad Rzeszutek Wilk > > Cc: John Sobecki ; DONGLI.ZHANG > ; linux-ker...@vger.kernel.org" ker...@vger.kern

Re: [Xen-devel] [Xen-users] [XEN][ARM] WiFi bridge creation

2018-10-30 Thread Vladimir Botka
> > > > > Hello, > > > > > We are using Hikey960 with Debian as Dom0 and DomU. This board has > > > > > only WiFi interface. We want to create bridge between Dom0 and DomU > > > > > so that DomU has internet access. We tried to create bridge using > > > > > brtcl > > > > > command, but it is not w

Re: [Xen-devel] [PATCH] use consistent values when consuming runtime-changeable parameters

2018-10-30 Thread Andrew Cooper
On 30/10/18 14:44, Jan Beulich wrote: > There's no guarantee that e.g. a switch() control expression's memory > operand(s) get(s) read just once. Guard against the compiler producing > "unexpected" code by sprinkling around some ACCESS_ONCE(). > > I'm leaving alone opt_conswitch[]: It gets accessed

Re: [Xen-devel] dom0/pvh: Dom0 PVH with PCI passthrough support status

2018-10-30 Thread Roger Pau Monné
On Tue, Oct 30, 2018 at 01:32:38PM +0200, Alexandru Vasile wrote: > Hello, > > > > There is some low-hanging fruit, both in Xen and the Linux kernel, > > which can really be worked in parallel by different parties, so let me > > know if you have some capacity and we can speak about sharing the >

Re: [Xen-devel] [PATCH v5] arch/x86: Add registers to vm_event

2018-10-30 Thread Tamas K Lengyel
On Tue, Oct 30, 2018 at 7:19 AM Jan Beulich wrote: > > >>> On 30.10.18 at 13:26, wrote: > > On 10/30/18 1:33 PM, Jan Beulich wrote: > > On 30.10.18 at 11:07, wrote: > >>> --- a/xen/include/public/vm_event.h > >>> +++ b/xen/include/public/vm_event.h > >>> @@ -29,7 +29,7 @@ > >>> > >>> #inclu

Re: [Xen-devel] [PATCH v8 6/8] docs: documentation about static shared memory regions

2018-10-30 Thread Ian Jackson
Stefano Stabellini writes ("[PATCH v8 6/8] docs: documentation about static shared memory regions"): > Author: Zhongze Liu > > Add docs to document the motivation, usage, use cases and other > relevant information about the static shared memory feature. > > This is for the proposal "Allow setti

Re: [Xen-devel] dom0/pvh: Dom0 PVH with PCI passthrough support status

2018-10-30 Thread Wei Liu
On Tue, Oct 30, 2018 at 01:32:38PM +0200, Alexandru Vasile wrote: > Hello, > > > > There is some low-hanging fruit, both in Xen and the Linux kernel, > > which can really be worked in parallel by different parties, so let me > > know if you have some capacity and we can speak about sharing the >

Re: [Xen-devel] [PATCH v8 2/8] libxl: introduce a new structure to represent static shared memory regions

2018-10-30 Thread Ian Jackson
Stefano Stabellini writes ("[PATCH v8 2/8] libxl: introduce a new structure to represent static shared memory regions"): > From: Zhongze Liu > > Author: Zhongze Liu > > Add a new structure to the IDL family to represent static shared memory > regions > as proposed in the proposal "Allow setti

Re: [Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-30 Thread Wei Liu
On Fri, Oct 26, 2018 at 09:21:03AM -0600, Jan Beulich wrote: > >>> On 22.10.18 at 14:58, wrote: > > --- a/xen/common/efi/boot.c > > +++ b/xen/common/efi/boot.c > > @@ -487,6 +487,7 @@ static EFI_FILE_HANDLE __init > > get_parent_handle(EFI_LOADED_IMAGE *loaded_image, > >

Re: [Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-30 Thread Wei Liu
On Mon, Oct 22, 2018 at 01:58:02PM +0100, Andrew Cooper wrote: > With almost all users of keyhandler_scratch gone, clean up the 3 remaining > users and drop the buffer. > > Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH v8 3/8] libxl: support mapping static shared memory areas during domain creation

2018-10-30 Thread Ian Jackson
Stefano Stabellini writes ("[PATCH v8 3/8] libxl: support mapping static shared memory areas during domain creation"): > +_hidden > +bool libxl__arch_domain_support_sshm(const libxl_domain_build_info *b_info); > + > +_hidden > +int libxl__arch_domain_sshm_cachepolicy_setdefault(libxl_static_shm *s

Re: [Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 16:32, wrote: > On Fri, Oct 26, 2018 at 09:21:03AM -0600, Jan Beulich wrote: >> >>> On 22.10.18 at 14:58, wrote: >> > --- a/xen/common/efi/boot.c >> > +++ b/xen/common/efi/boot.c >> > @@ -487,6 +487,7 @@ static EFI_FILE_HANDLE __init >> > get_parent_handle(EFI_LOADED_IMAGE *lo

[Xen-devel] [PATCH v3 3/7] x86/pvh: allow PVH Dom0 to use the debug IO port console

2018-10-30 Thread Roger Pau Monne
Force trapping accesses to IO port 0xe9 for a PVH Dom0, so it can print to the HVM debug console. Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu --- Changes since v2: - Always enable the E9 debug console. Changes since v1: - Use a define for 0xe9. - Expand

[Xen-devel] [PATCH v3 5/7] vpci: fix execution of long running operations

2018-10-30 Thread Roger Pau Monne
BAR map/unmap is a long running operation that needs to be preempted in order to avoid overrunning the assigned vCPU time (or even triggering the watchdog). Current logic for this preemption is wrong, and won't work at all for AMD since only Intel makes use of hvm_io_pending (and even in that case

[Xen-devel] [PATCH v3 2/7] x86/hvm: introduce a define for the debug output IO port

2018-10-30 Thread Roger Pau Monne
No functional change intended. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu Cc: George Dunlap Cc: Ian Jackson Cc: Julien Grall Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan --- xen/arch/x86/hvm/hvm.c

[Xen-devel] [PATCH v3 0/7] x86/pvh: fix fixes for PVH Dom0

2018-10-30 Thread Roger Pau Monne
Hello, The following series contain miscellaneous fixes for a PVH Dom0. I've found out this issues while trying to boot on an AMD EPYC box. The series can be found on my git repo: git://xenbits.xen.org/people/royger/xen.git fixes-pvh-v3 Roger Pau Monne (7): x86/pvh: fix TSC mode setup for PVH

[Xen-devel] [PATCH v3 1/7] x86/pvh: fix TSC mode setup for PVH Dom0

2018-10-30 Thread Roger Pau Monne
A PVH Dom0 might use TSC scaling or other HVM specific TSC adjustments, so only short-circuit the TSC setup for a classic PV Dom0. Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu --- xen/arch/x86/time.c | 2 +- 1 file changed, 1 insertio

[Xen-devel] [PATCH v3 7/7] amd/pvh: enable ACPI C1E disable quirk on PVH Dom0

2018-10-30 Thread Roger Pau Monne
PV Dom0 has a quirk for some AMD processors, where enabling ACPI can also enable C1E mode. Apply the same workaround as done on PV for a PVH Dom0, which consist on trapping accesses to the SMI command IO port and disabling C1E if ACPI is enabled. Reported-by: Jan Beulich Signed-off-by: Roger Pau

[Xen-devel] [PATCH v3 4/7] vpci: fix updating the command register

2018-10-30 Thread Roger Pau Monne
When switching the memory decoding bit in the command register the rest of the changes where dropped, leading to only the memory decoding bit being updated. Fix this by unconditionally writing the guest-requested command except for the memory decoding bit, which will be updated once the p2m change

[Xen-devel] [PATCH v3 6/7] vpci/msix: carve p2m hole for MSIX MMIO regions

2018-10-30 Thread Roger Pau Monne
Make sure the MSIX MMIO regions don't have p2m entries setup, so that accesses to them trap into the hypervisor and can be handled by vpci. This is a side-effect of commit 042678762 for PVH Dom0, which added mappings for all the reserved regions into the Dom0 p2m. Signed-off-by: Roger Pau Monné

Re: [Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-30 Thread Wei Liu
On Tue, Oct 30, 2018 at 09:40:17AM -0600, Jan Beulich wrote: > >>> On 30.10.18 at 16:32, wrote: > > On Fri, Oct 26, 2018 at 09:21:03AM -0600, Jan Beulich wrote: > >> >>> On 22.10.18 at 14:58, wrote: > >> > --- a/xen/common/efi/boot.c > >> > +++ b/xen/common/efi/boot.c > >> > @@ -487,6 +487,7 @@ s

  1   2   >