Re: [Xen-devel] [PATCH 1/3] xen/xsm: remove unnecessary #define

2018-10-09 Thread Jan Beulich
>>> On 09.10.18 at 02:28, wrote: > this #define is unnecessary since XSM_INLINE is redefined in > xsm/dummy.h, it's a risk of build breakage, so remove it. > > Signed-off-by: Xin Li > > --- > CC: Daniel De Graaf > CC: George Dunlap > CC: Jan Beulich > CC: Konrad Rzeszutek Wilk > CC: Stefano

Re: [Xen-devel] [RFC 16/16] xen/arm: Track page accessed between batch of Set/Way operations

2018-10-09 Thread Jan Beulich
>>> On 08.10.18 at 20:33, wrote: > At the moment, the implementation of Set/Way operations will go through > all the entries of the guest P2M and flush them. However, this is very > expensive and may render unusable a guest OS using them. > > For instance, Linux 32-bit will use Set/Way operations

Re: [Xen-devel] [PATCH v8 1/8] xen: xsm: flask: introduce XENMAPSPACE_gmfn_share for memory sharing

2018-10-09 Thread Jan Beulich
>>> On 09.10.18 at 01:37, wrote: > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -535,6 +535,20 @@ static XSM_INLINE int > xsm_map_gmfn_foreign(XSM_DEFAULT_ARG struct domain *d, str > return xsm_default_action(action, d, t); > } > > +/* > + * Be aware that this is not

Re: [Xen-devel] [PATCH 1/3] xen/xsm: remove unnecessary #define

2018-10-09 Thread Xin Li (Talons)
> >>> On 09.10.18 at 02:28, wrote: > > v5: > > 1. move the removal of #define to this new patch. > > 2. fix wrong git author > > Thanks, but one more formal request: Would you please include the version of > a patch/series in side the square brackets of the mail subject, like everyone > else does

Re: [Xen-devel] [PATCH 1/3] xen/xsm: remove unnecessary #define

2018-10-09 Thread Xin Li (Talons)
> > --- > > CC: Daniel De Graaf > > CC: George Dunlap > > CC: Jan Beulich > > CC: Konrad Rzeszutek Wilk > > CC: Stefano Stabellini > > CC: Tim Deegan > > CC: Wei Liu > > CC: Sergey Dyasli > > CC: Andrew Cooper > > CC: Ming Lu > > > > v5: > > 1. move the removal of #define to this new patc

[Xen-devel] [linux-next test] 128496: regressions - FAIL

2018-10-09 Thread osstest service owner
flight 128496 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/128496/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-boot fail REGR. vs. 128476 test-amd64-i386-xl-q

[Xen-devel] [xen-unstable test] 128498: tolerable FAIL

2018-10-09 Thread osstest service owner
flight 128498 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/128498/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-examine4 memdisk-try-append fail in 128478 pass in 128498 test-amd64-i386-libvirt-pair 24

[Xen-devel] [PATCH v2] x86/hvm/ioreq: allow ioreq servers to use HVM_PARAM_[BUF]IOREQ_PFN

2018-10-09 Thread Paul Durrant
Since commit 2c257bd6 "x86/hvm: remove default ioreq server (again)" the GFNs allocated by the toolstack and set in HVM_PARAM_IOREQ_PFN and HVM_PARAM_BUFIOREQ_PFN have been unused. This patch allows them to be used by (non-default) ioreq servers. While in the area, also make sure HVM_PARAM_[BUF]IO

Re: [Xen-devel] preparations for 4.11.1 and 4.8.5

2018-10-09 Thread Pasi Kärkkäinen
On Mon, Oct 08, 2018 at 07:06:10AM -0600, Jan Beulich wrote: > All, > > both releases are due in about a month's time. Please point out > backports you find missing from their respective staging branches, > but which you consider relevant. On top of what I've just pushed > there I have > > 2fb57e

Re: [Xen-devel] Xen boot failure on QEMU (WAS: Re: [PATCH v3] xen:arm: Populate arm64 image header)

2018-10-09 Thread Peter Maydell
On 8 October 2018 at 19:00, Julien Grall wrote: > Per the Linux arm64 booting protocol [1], the load offset can definitely be > 0. The bootloader (here QEMU) should not assume a specific text offset, > Linux actually provides an option to randomize the text offset in order to > test that assumptio

Re: [Xen-devel] [PATCH 1/3] xen/xsm: remove unnecessary #define

2018-10-09 Thread Jan Beulich
>>> On 09.10.18 at 09:50, wrote: >> > --- >> > CC: Daniel De Graaf >> > CC: George Dunlap >> > CC: Jan Beulich >> > CC: Konrad Rzeszutek Wilk >> > CC: Stefano Stabellini >> > CC: Tim Deegan >> > CC: Wei Liu >> > CC: Sergey Dyasli >> > CC: Andrew Cooper >> > CC: Ming Lu >> > >> > v5: >> >

Re: [Xen-devel] preparations for 4.11.1 and 4.8.5

2018-10-09 Thread Jan Beulich
>>> On 09.10.18 at 10:38, wrote: > On Mon, Oct 08, 2018 at 07:06:10AM -0600, Jan Beulich wrote: >> All, >> >> both releases are due in about a month's time. Please point out >> backports you find missing from their respective staging branches, >> but which you consider relevant. On top of what I'

Re: [Xen-devel] Xen boot failure on QEMU (WAS: Re: [PATCH v3] xen:arm: Populate arm64 image header)

2018-10-09 Thread Andre Przywara
On Tue, 9 Oct 2018 09:58:14 +0100 Peter Maydell wrote: Hi, > On 8 October 2018 at 19:00, Julien Grall wrote: > > Per the Linux arm64 booting protocol [1], the load offset can > > definitely be 0. The bootloader (here QEMU) should not assume a > > specific text offset, Linux actually provides an

Re: [Xen-devel] [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-10-09 Thread Michal Hocko
On Fri 05-10-18 13:40:05, Arun KS wrote: > When free pages are done with higher order, time spend on > coalescing pages by buddy allocator can be reduced. With > section size of 256MB, hot add latency of a single section > shows improvement from 50-60 ms to less than 1 ms, hence > improving the hot

Re: [Xen-devel] [PATCH v5 2/2] mm/page_alloc: remove software prefetching in __free_pages_core

2018-10-09 Thread Michal Hocko
On Fri 05-10-18 13:40:06, Arun KS wrote: > They not only increase the code footprint, they actually make things > slower rather than faster. Remove them as contemporary hardware doesn't > need any hint. I agree with the change but it is much better to add some numbers whenever arguing about perfor

[Xen-devel] [PATCH v5 1/3] xen/xsm: remove unnecessary #define

2018-10-09 Thread Xin Li
this #define is unnecessary since XSM_INLINE is redefined in xsm/dummy.h, it's a risk of build breakage, so remove it. Signed-off-by: Xin Li Reviewed-by: Jan Beulich --- CC: Daniel De Graaf CC: George Dunlap CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan C

[Xen-devel] [PATCH v5 3/3] xen/xsm: Add new SILO mode for XSM

2018-10-09 Thread Xin Li
When SILO is enabled, there would be no page-sharing or event notifications between unprivileged VMs (no grant tables or event channels). Signed-off-by: Xin Li Acked-by: Daniel De Graaf --- CC: Daniel De Graaf CC: George Dunlap CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellin

[Xen-devel] [PATCH v5 2/3] xen/xsm: Introduce new boot parameter xsm

2018-10-09 Thread Xin Li
Introduce new boot parameter xsm to choose which xsm module is enabled, and set default to dummy. And add new option in Kconfig to choose the default XSM implementation. Signed-off-by: Xin Li Acked-by: Daniel De Graaf --- CC: Daniel De Graaf CC: George Dunlap CC: Jan Beulich CC: Konrad Rzesz

Re: [Xen-devel] [PATCH 0/8] xen: add pvh guest support

2018-10-09 Thread Juergen Gross
On 15/02/2018 13:02, Daniel Kiper wrote: > Hi Juergen, > > Sorry for huge delay. It looks that I am recovering slowly and > probably I will have more time for reviews. > > On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: >> This patch series adds support for booting Linux as PVH gue

[Xen-devel] [PATCH 4/6] vpci: fix updating the command register

2018-10-09 Thread Roger Pau Monne
When switching the memory decoding bit in the command register the rest of the changes where dropped, leading to only the memory decoding bit being updated. Fix this by unconditionally writing the guest-requested command except for the memory decoding bit, which will be updated once the p2m change

[Xen-devel] [PATCH 2/6] x86/dom0: switch parse_dom0_param to use parse_boolean

2018-10-09 Thread Roger Pau Monne
No functional change expected. Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu --- xen/arch/x86/dom0_build.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 86eb7db1da..dc

[Xen-devel] [PATCH 5/6] vpci: fix execution of long running operations

2018-10-09 Thread Roger Pau Monne
BAR map/unmap is a long running operation that needs to be preempted in order to avoid overrunning the assigned vCPU time (or even triggering the watchdog). Current logic for this preemption is wrong, and won't work at all for AMD since only Intel makes use of hvm_io_pending (and even in that case

[Xen-devel] [PATCH 1/6] x86/pvh: fix TSC mode setup for PVH Dom0

2018-10-09 Thread Roger Pau Monne
A PVH Dom0 might use TSC scaling or other HVM specific TSC adjustments, so only short-circuit the TSC setup for a classic PV Dom0. Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu --- xen/arch/x86/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[Xen-devel] [PATCH 6/6] vpci/msix: carve p2m hole for MSIX MMIO regions

2018-10-09 Thread Roger Pau Monne
Make sure the MSIX MMIO regions don't have p2m entries setup, so that accesses to them trap into the hypervisor and can be handled by vpci. This is a side-effect of commit 042678762 for PVH Dom0, which added mappings for all the reserved regions into the Dom0 p2m. Signed-off-by: Roger Pau Monné

[Xen-devel] [PATCH 3/6] x86/pvh: allow PVH Dom0 to use the debug IO port console

2018-10-09 Thread Roger Pau Monne
Add an option to allow trapping accesses to IO port 0xe9 for a PVH Dom0, so it can print to the HVM debug console. Note this is not enabled by default in order to prevent clashes with hardware on the system using 0xe9. Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei

[Xen-devel] [PATCH 0/6] x86/pvh: fix fixes for PVH Dom0

2018-10-09 Thread Roger Pau Monne
Hello, The following series contain miscellaneous fixes for a PVH Dom0. I've found out this issues while trying to boot on an AMD EPYC box. The series can be found on my git repo on top of "x86/vtd: fix iommu_share_p2m_table": git://xenbits.xen.org/people/royger/xen.git fixes_pvh Thanks, Roger.

[Xen-devel] [distros-debian-snapshot test] 75377: trouble: blocked/broken

2018-10-09 Thread Platform Team regression test user
flight 75377 distros-debian-snapshot real [real] http://osstest.xensource.com/osstest/logs/75377/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-i386

Re: [Xen-devel] [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-10-09 Thread Arun KS
On 2018-10-09 14:59, Michal Hocko wrote: On Fri 05-10-18 13:40:05, Arun KS wrote: When free pages are done with higher order, time spend on coalescing pages by buddy allocator can be reduced. With section size of 256MB, hot add latency of a single section shows improvement from 50-60 ms to less

Re: [Xen-devel] [RFC 16/16] xen/arm: Track page accessed between batch of Set/Way operations

2018-10-09 Thread Julien Grall
Hi Jan, On 09/10/2018 08:04, Jan Beulich wrote: On 08.10.18 at 20:33, wrote: At the moment, the implementation of Set/Way operations will go through all the entries of the guest P2M and flush them. However, this is very expensive and may render unusable a guest OS using them. For instance, Li

Re: [Xen-devel] [PATCH] libxl: Restore scheduling parameters after migrate in best-effort fashion

2018-10-09 Thread Dario Faggioli
On Wed, 2018-10-03 at 12:53 +0200, Juergen Gross wrote: > On 02/10/2018 17:49, George Dunlap wrote: > > Commit 3b4adba ("tools/libxl: include scheduler parameters in the > > output of xl list -l") added scheduling parameters to the set of > > information collected by libxl_retrieve_domain_configura

Re: [Xen-devel] [RFC PATCH 2/2] xen/arm: Add MESON UART driver for Amlogic S905 SoC

2018-10-09 Thread Julien Grall
Hi, On 04/10/2018 08:11, Amit Tomer wrote: +reg = meson_s905_read(uart, UART_CONTROL); +reg &= ~(UART_RX_RST | UART_TX_RST | UART_CLEAR_ERR); I am not sure why you are clearing those bits. AFAIU, init_preirq will reset the serials, so you want to set thoses bits. This seems to be conf

[Xen-devel] [PATCH] xen/pvh: increase early stack size

2018-10-09 Thread Roger Pau Monne
While booting on an AMD EPYC box the stack canary would detect stack overflows when using the current PVH early stack size (256). Switch to using the value defined by BOOT_STACK_SIZE, which prevents the stack overflow. Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc:

[Xen-devel] [PATCH] x86/vtd: fix IOMMU share PT destruction path

2018-10-09 Thread Wei Liu
Commit 2916951c1 ("mm / iommu: include need_iommu() test in iommu_use_hap_pt()") included need_iommu() in iommu_use_hap_pt and 91d4eca7add (" mm / iommu: split need_iommu() into has_iommu_pt() and need_iommu_pt_sync()") made things finer grain by spliting need_iommu into three states. The destruct

[Xen-devel] [PATCH v4 3/3] x86/acpi: take rsdp address for boot params if available

2018-10-09 Thread Juergen Gross
In case the rsdp address in struct boot_params is specified don't try to find the table by searching, but take the address directly as set by the boot loader. Signed-off-by: Juergen Gross --- V3: use a generic retrieval function with a __weak annotated default function (Ingo Molnar) V4: chec

[Xen-devel] [PATCH v4 1/3] x86/xen: fix boot loader version reported for pvh guests

2018-10-09 Thread Juergen Gross
The boot loader version reported via sysfs is wrong in case of the kernel being booted via the Xen PVH boot entry. it should be 2.12 (0x020c), but it is reported to be 2.18 (0x0212). As the current way to set the version is error prone use the more readable variant (2 << 8) | 12. Cc: # 4.12 Sign

[Xen-devel] [PATCH v4 2/3] x86/boot: add acpi rsdp address to setup_header

2018-10-09 Thread Juergen Gross
Xen PVH guests receive the address of the RSDP table from Xen. In order to support booting a Xen PVH guest via Grub2 using the standard x86 boot entry we need a way for Grub2 to pass the RSDP address to the kernel. For this purpose expand the struct setup_header to hold the physical address of the

[Xen-devel] [PATCH v4 0/3] x86: make rsdp address accessible via boot params

2018-10-09 Thread Juergen Gross
In the non-EFI boot path the ACPI RSDP table is currently found via either EBDA or by searching through low memory for the RSDP magic. This requires the RSDP to be located in the first 1MB of physical memory. Xen PVH guests, however, get the RSDP address via the start of day information block. In

Re: [Xen-devel] [PATCH 2/5] xen/domain: Introduce a new arch_check_domain_config() helper

2018-10-09 Thread Julien Grall
Hi Andrew, On 05/10/2018 15:54, Andrew Cooper wrote: On the ARM side, lift the code to select the appropriate GIC version when NATIVE is requested. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall Regardless the decision on the hook nam

[Xen-devel] Xen optimization

2018-10-09 Thread Milan Boberic
Hi, I'm testing Xen Hypervisor 4.10 performance on UltraZed-EG board with carrier card. I created bare-metal application in Xilinx SDK. In bm application I: - start triple timer counter (ttc) which generates interrupt every 1us - turn on PS LED - call function 100 t

Re: [Xen-devel] [PATCH] x86: put_page_from_l2e() should honor _PAGE_RW

2018-10-09 Thread Andrew Cooper
On 09/10/18 07:43, Jan Beulich wrote: > 56fff3e5e9 ("x86: nuke PV superpage option and code") has introduced a > (luckily latent only) bug here, in that it didn't make reference > dropping dependent on whether the page was mapped writable. The only > current source of large page mappings for PV dom

Re: [Xen-devel] [PATCH] xen/pvh: increase early stack size

2018-10-09 Thread Juergen Gross
On 09/10/2018 12:32, Roger Pau Monne wrote: > While booting on an AMD EPYC box the stack canary would detect stack > overflows when using the current PVH early stack size (256). Switch to > using the value defined by BOOT_STACK_SIZE, which prevents the stack > overflow. > > Signed-off-by: Roger Pa

[Xen-devel] [PATCH v2 11/18] xen: get memory map from hypervisor for PVH

2018-10-09 Thread Juergen Gross
Retrieve the memory map from the hypervisor and normalize it to contain no overlapping entries and to be sorted by address. Signed-off-by: Juergen Gross --- grub-core/kern/i386/xen/pvh.c | 98 +++ 1 file changed, 98 insertions(+) diff --git a/grub-core/ke

[Xen-devel] [PATCH v2 06/18] xen: rearrange xen/init.c to prepare it for Xen PVH mode

2018-10-09 Thread Juergen Gross
Rearrange grub-core/kern/xen/init.c to prepare adding PVH mode support to it. This includes putting some code under #ifdef GRUB_MACHINE_XEN as it will not be used when running as PVH. Signed-off-by: Juergen Gross --- grub-core/kern/xen/init.c | 60 +++

[Xen-devel] [PATCH v2 03/18] xen: carve out grant tab initialization into dedicated function

2018-10-09 Thread Juergen Gross
Initialize the grant tab in a dedicated function. This will enable using it for PVH guests, too. Call the new function from grub_machine_init() as this will later be common between Xen PV and Xen PVH mode. Signed-off-by: Juergen Gross --- V2: update commit message (Daniel Kiper) --- grub-core/k

[Xen-devel] [PATCH v2 10/18] xen: setup hypercall page for PVH

2018-10-09 Thread Juergen Gross
Add the needed code to setup the hypercall page for calling into the Xen hypervisor. Signed-off-by: Juergen Gross --- grub-core/kern/i386/xen/pvh.c | 70 +++ 1 file changed, 70 insertions(+) diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern/i386

[Xen-devel] [PATCH v2 13/18] xen: init memory regions for PVH

2018-10-09 Thread Juergen Gross
Add all usable memory regions to grub memory management and add the needed mmap iterate code. As we are running in 32-bit mode don't add memory above 4GB. Signed-off-by: Juergen Gross --- grub-core/kern/i386/xen/pvh.c | 35 +++ 1 file changed, 35 insertions(+) d

[Xen-devel] [PATCH v2 09/18] xen: add PVH boot entry code

2018-10-09 Thread Juergen Gross
Add the code for the Xen PVH mode boot entry. Signed-off-by: Juergen Gross --- grub-core/kern/i386/xen/startup_pvh.S | 50 +++ 1 file changed, 50 insertions(+) diff --git a/grub-core/kern/i386/xen/startup_pvh.S b/grub-core/kern/i386/xen/startup_pvh.S index e18ee

[Xen-devel] [PATCH v2 00/18] xen: add pvh guest support

2018-10-09 Thread Juergen Gross
This patch series adds support for booting Linux as PVH guest. Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen. For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux

[Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-09 Thread Juergen Gross
Add the hooks to current code needed for Xen PVH. Signed-off-by: Juergen Gross --- grub-core/kern/i386/xen/pvh.c | 36 +++ grub-core/kern/i386/xen/startup_pvh.S | 29 grub-core/kern/xen/init.c | 6 ++ include/g

[Xen-devel] [PATCH v2 07/18] xen: add PVH specific defines to offset.h

2018-10-09 Thread Juergen Gross
include/grub/offsets.h needs some defines for Xen PVH mode. Add them. While at it line up the values in the surrounding lines to start at the same column. Signed-off-by: Juergen Gross --- include/grub/offsets.h | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff -

[Xen-devel] [PATCH v2 18/18] xenpvh: add support to configure

2018-10-09 Thread Juergen Gross
Support platform i386/xenpvh in configure. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 5e63c4af3..96d81a3f2 100644 --- a/configure.ac +++ b/configure.ac @@ -151,6 +151,7 @@ case

[Xen-devel] [PATCH v2 04/18] xen: prepare common code for Xen PVH support

2018-10-09 Thread Juergen Gross
Some common code needs to be special cased for Xen PVH mode. This hits mostly Xen PV mode specific areas. Signed-off-by: Juergen Gross --- grub-core/kern/i386/tsc.c | 2 +- include/grub/i386/pc/int.h| 3 +++ include/grub/i386/tsc.h | 2 +- include/grub/i386/xen/hypercal

[Xen-devel] [PATCH v2 05/18] xen: add some dummy headers for PVH mode

2018-10-09 Thread Juergen Gross
Xen PVH mode needs some headers including the common i386 headers. Add those to the tree. Signed-off-by: Juergen Gross --- include/grub/i386/xenpvh/boot.h| 1 + include/grub/i386/xenpvh/console.h | 1 + include/grub/i386/xenpvh/int.h | 1 + include/grub/i386/xenpvh/memory.h | 1 + inclu

[Xen-devel] [PATCH v2 17/18] xenpvh: support grub-install for xenpvh

2018-10-09 Thread Juergen Gross
Add xenpvh support to grub-install. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- include/grub/util/install.h | 1 + util/grub-install-common.c | 1 + util/grub-install.c | 7 +++ 3 files changed, 9 insertions(+) diff --git a/include/grub/util/install.h b/include/grub

[Xen-devel] [PATCH v2 02/18] loader/linux: support passing rsdp address via boot params

2018-10-09 Thread Juergen Gross
Xen PVH guests will have the RSDP at an arbitrary address. Support that by passing the RSDP address via the boot parameters to Linux. The new protocol version 2.14 requires to set version to 0x8000 ored with the actually use protocol version (the minimum of the kernel supplied protocol version and

[Xen-devel] [xen-4.10-testing test] 128505: regressions - FAIL

2018-10-09 Thread osstest service owner
flight 128505 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/128505/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 128108 build-arm64

[Xen-devel] [PATCH v2 14/18] xenpvh: add build runes for grub-core

2018-10-09 Thread Juergen Gross
Add the modifications to the build system needed to build a xenpvh grub. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- gentpl.py | 4 ++-- grub-core/Makefile.am | 12 grub-core/Makefile.core.def | 35 +++ 3 files

[Xen-devel] [PATCH v2 01/18] xen: add some xen headers

2018-10-09 Thread Juergen Gross
In order to support grub2 in Xen PVH environment some additional Xen headers are needed as grub2 will be started in PVH mode requiring to use several HVM hypercalls and structures. Add the needed headers from Xen 4.10 being the first Xen version with full (not only experimental) PVH guest support.

[Xen-devel] [PATCH v2 15/18] grub-module-verifier: Ignore all_video for xenpvh

2018-10-09 Thread Juergen Gross
From: Hans van Kranenburg This solves the build failing with "Error: no symbol table and no .moddeps section" Also see: - 6371e9c10433578bb236a8284ddb9ce9e201eb59 - https://savannah.gnu.org/bugs/?49012 Signed-off-by: Hans van Kranenburg --- V2: new patch Signed-off-by: Juergen Gross --- util

[Xen-devel] [PATCH v2 16/18] xenpvh: support building a standalone image

2018-10-09 Thread Juergen Gross
Support mkimage for xenpvh. In order to avoid using plain integers for the ELF notes use the available Xen include instead. While at it replace the plain numbers for Xen PV mode, too. Signed-off-by: Juergen Gross --- V2: some style adjustments (Daniel Kiper) use defines for elf-notes (Daniel

[Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

2018-10-09 Thread Juergen Gross
Initialize the needed Xen specific data. This is: - the Xen start of day page containing the console and Xenstore ring page PFN and event channel - the grant table - the shared info page Set the RSDP address for the guest from the start_info page passed as boot parameter. Signed-off-by: Juerge

Re: [Xen-devel] [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-10-09 Thread Michal Hocko
On Tue 09-10-18 15:24:13, Arun KS wrote: > On 2018-10-09 14:59, Michal Hocko wrote: > > On Fri 05-10-18 13:40:05, Arun KS wrote: > > > When free pages are done with higher order, time spend on > > > coalescing pages by buddy allocator can be reduced. With > > > section size of 256MB, hot add latenc

Re: [Xen-devel] [PATCH] x86/vtd: fix IOMMU share PT destruction path

2018-10-09 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 09 October 2018 11:42 > To: xen-devel@lists.xenproject.org > Cc: Jan Beulich ; Roger Pau Monne > ; Paul Durrant ; Wei Liu > ; Kevin Tian > Subject: [PATCH] x86/vtd: fix IOMMU share PT destruction path > > Commit 291

Re: [Xen-devel] [PATCH 3/5] xen/domain: Audit config->max_vcpus during {, arch_}check_domain_config()

2018-10-09 Thread Julien Grall
Hi Andrew, On 05/10/2018 15:54, Andrew Cooper wrote: The purpose of this is to move the auduting to be earlier than arch_domain_create(). Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall The max_vcpus setting for GIC_V3 is somewhat confu

Re: [Xen-devel] [PATCH 5/5] Revert "xen/arm: vgic-v3: Delay the initialization of the domain information"

2018-10-09 Thread Julien Grall
Hi Andrew, On 05/10/2018 15:54, Andrew Cooper wrote: This reverts commit 703d9d5ec13a0f487e7415174ba54e0e3ca158db. The domain creation logic has been adjusted to set up d->max_vcpus early enough to be usable in vgic_v3_domain_init(). Signed-off-by: Andrew Cooper --- CC: Stefano Stabellini CC

Re: [Xen-devel] [PATCH] x86/vtd: fix IOMMU share PT destruction path

2018-10-09 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 09 October 2018 12:23 > To: Wei Liu ; xen-devel@lists.xenproject.org > Cc: Kevin Tian ; Wei Liu ; Jan > Beulich ; Roger Pau Monne > Subject: Re: [Xen-devel] [PATCH] x8

Re: [Xen-devel] [RFC 16/16] xen/arm: Track page accessed between batch of Set/Way operations

2018-10-09 Thread Jan Beulich
>>> On 09.10.18 at 12:16, wrote: > On 09/10/2018 08:04, Jan Beulich wrote: > On 08.10.18 at 20:33, wrote: >>> This patch adds a new per-arch helper is introduced to perform actions just >>> before the guest is first unpaused. This will be used to invalidate the >>> P2M to track access from th

Re: [Xen-devel] [PATCH v4 03/23] xen/arm: document dom0less

2018-10-09 Thread Julien Grall
Hi Stefano, On 05/10/2018 19:47, Stefano Stabellini wrote: Add a new document to provide information on how to use dom0less related features and their current limitations. Signed-off-by: Stefano Stabellini --- Changes in v4: - rename to .txt - improve wording Changes in v3: - add patch ---

Re: [Xen-devel] [RFC 16/16] xen/arm: Track page accessed between batch of Set/Way operations

2018-10-09 Thread Julien Grall
Hi Jan, On 09/10/2018 12:43, Jan Beulich wrote: On 09.10.18 at 12:16, wrote: On 09/10/2018 08:04, Jan Beulich wrote: On 08.10.18 at 20:33, wrote: This patch adds a new per-arch helper is introduced to perform actions just before the guest is first unpaused. This will be used to invalidate t

Re: [Xen-devel] [PATCH 0/8] xen: add pvh guest support

2018-10-09 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 11:35:28AM +0200, Juergen Gross wrote: > On 15/02/2018 13:02, Daniel Kiper wrote: > > Hi Juergen, > > > > Sorry for huge delay. It looks that I am recovering slowly and > > probably I will have more time for reviews. > > > > On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen

Re: [Xen-devel] [PATCH] x86/vtd: fix IOMMU share PT destruction path

2018-10-09 Thread Roger Pau Monné
On Tue, Oct 09, 2018 at 12:22:34PM +0100, Paul Durrant wrote: > > -Original Message- > > From: Wei Liu [mailto:wei.l...@citrix.com] > > Sent: 09 October 2018 11:42 > > To: xen-devel@lists.xenproject.org > > Cc: Jan Beulich ; Roger Pau Monne > > ; Paul Durrant ; Wei Liu > > ; Kevin Tian > >

Re: [Xen-devel] [PATCH] x86/vtd: fix IOMMU share PT destruction path

2018-10-09 Thread Wei Liu
On Tue, Oct 09, 2018 at 12:38:41PM +0100, Paul Durrant wrote: > > -Original Message- > > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > > Of Paul Durrant > > Sent: 09 October 2018 12:23 > > To: Wei Liu ; xen-devel@lists.xenproject.org > > Cc: Kevin Tian ; Wei Li

[Xen-devel] [xen-4.11-testing test] 128503: tolerable FAIL - PUSHED

2018-10-09 Thread osstest service owner
flight 128503 xen-4.11-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/128503/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 10 debian-hvm-install fail never pass test-amd64-i386-xl

Re: [Xen-devel] [PATCH] x86/vtd: fix IOMMU share PT destruction path

2018-10-09 Thread Jan Beulich
>>> On 09.10.18 at 14:57, wrote: > On Tue, Oct 09, 2018 at 12:22:34PM +0100, Paul Durrant wrote: >> > -Original Message- >> > From: Wei Liu [mailto:wei.l...@citrix.com] >> > Sent: 09 October 2018 11:42 >> > To: xen-devel@lists.xenproject.org >> > Cc: Jan Beulich ; Roger Pau Monne >> > ; P

Re: [Xen-devel] [PATCH v4 3/3] x86/acpi: take rsdp address for boot params if available

2018-10-09 Thread Boris Ostrovsky
On 10/9/18 6:54 AM, Juergen Gross wrote: > + > +u64 x86_default_get_root_pointer(void) > +{ > + return boot_params.hdr.acpi_rsdp_addr; > +} Should we then update init_pvh_bootparams() with     pvh_bootparams.hdr.acpi_rsdp_addr = pvh_start_info.rsdp_paddr; (and drop x86_init.acpi.get_root_po

Re: [Xen-devel] [PATCH v4 05/23] xen/arm: introduce bootcmdlines

2018-10-09 Thread Julien Grall
On 05/10/2018 19:47, Stefano Stabellini wrote: Introduce a new array to store the cmdline of each boot module. It is separate from struct bootmodules. Remove the cmdline field from struct boot_module. This way, kernels and initrds with the same address in memory can share struct bootmodule (imp

Re: [Xen-devel] [PATCH v4 3/3] x86/acpi: take rsdp address for boot params if available

2018-10-09 Thread Juergen Gross
On 09/10/2018 15:22, Boris Ostrovsky wrote: > On 10/9/18 6:54 AM, Juergen Gross wrote: >> + >> +u64 x86_default_get_root_pointer(void) >> +{ >> +return boot_params.hdr.acpi_rsdp_addr; >> +} > > > Should we then update init_pvh_bootparams() with > >     pvh_bootparams.hdr.acpi_rsdp_addr = pvh

Re: [Xen-devel] [PATCH] x86: put_page_from_l2e() should honor _PAGE_RW

2018-10-09 Thread Wei Liu
On Tue, Oct 09, 2018 at 12:43:05AM -0600, Jan Beulich wrote: > 56fff3e5e9 ("x86: nuke PV superpage option and code") has introduced a > (luckily latent only) bug here, in that it didn't make reference It seems that the bug was from the original superpage code -- see put_spage_pages. > dropping de

Re: [Xen-devel] [PATCH] x86/vtd: fix IOMMU share PT destruction path

2018-10-09 Thread Wei Liu
On Tue, Oct 09, 2018 at 01:58:14PM +0100, Wei Liu wrote: > On Tue, Oct 09, 2018 at 12:38:41PM +0100, Paul Durrant wrote: > > > -Original Message- > > > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > > > Of Paul Durrant > > > Sent: 09 October 2018 12:23 > > > To:

Re: [Xen-devel] [PATCH v4 06/23] xen/arm: don't add duplicate boot modules, introduce domU flag

2018-10-09 Thread Julien Grall
Hi Stefano, On 05/10/2018 19:47, Stefano Stabellini wrote: Don't add duplicate boot modules (same kind and same start address), they are freed later, we don't want to introduce double-free errors. Introduce a domU flag in struct bootmodule and struct bootcmdline. Set it for kernels and ramdisks

Re: [Xen-devel] x86 Community Call: Wed Oct 10, 14:00 - 15:00 UTC - Call for agenda items

2018-10-09 Thread Lars Kurth
Hi all, ## Agenda The agenda can be found at https://docs.google.com/document/d/1ZfZ1SJRauLrISiTLXzM0DPxQL8beNkAQS5MwLLNtRKc/edit?usp=sharing The document is R/W already But in a nutshell * Admin Items: When to have winter meetings (DST effect) * Open / Closed Actions from Previous c

Re: [Xen-devel] [PATCH qemu-xen-traditional] xen/pt: allow QEMU to request MSI unmasking at bind time

2018-10-09 Thread Ian Jackson
> >Ian, any objections? Sorry for dropping this. It's been a while! > >> > When a MSI interrupt is bound to a guest using > >> > xc_domain_update_msi_irq (XEN_DOMCTL_bind_pt_irq) the interrupt > >> > is left masked by default. > >> > > >> > This causes problems with guests that first configure >

Re: [Xen-devel] [PATCH] xen/balloon: Support xend-based toolstack

2018-10-09 Thread Juergen Gross
On 07/10/2018 22:05, Boris Ostrovsky wrote: > Xend-based toolstacks don't have static-max entry in xenstore. The > equivalent node for those toolstacks is memory_static_max. > > Fixes: 5266b8e4445c (xen: fix booting ballooned down hvm guest) > Signed-off-by: Boris Ostrovsky > Cc: # 4.13 Reviewe

Re: [Xen-devel] [PATCH 13/18] tools/xenstat: Fix shared library version

2018-10-09 Thread Andrew Cooper
On 05/10/18 18:29, Ian Jackson wrote: > From: Bastian Blank > > libxenstat does not have a stable ABI. Set its version to the current > Xen release version. > > Signed-off-by: Ian Jackson > --- > tools/xenstat/libxenstat/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[Xen-devel] [PATCH] tools/libxenstat: Fix SONAME following c/s 57077cc42

2018-10-09 Thread Andrew Cooper
The unstable ABI version is 4.12, not 4.11 Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu --- tools/xenstat/libxenstat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstat/libxenstat/Makefile b/tools/xenstat/libxenstat/Makefile index 8c6ddf8

Re: [Xen-devel] [PATCH] tools/libxenstat: Fix SONAME following c/s 57077cc42

2018-10-09 Thread Wei Liu
On Tue, Oct 09, 2018 at 03:06:32PM +0100, Andrew Cooper wrote: > The unstable ABI version is 4.12, not 4.11 > > Signed-off-by: Andrew Cooper Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mail

Re: [Xen-devel] [PATCH] x86/vtd: fix IOMMU share PT destruction path

2018-10-09 Thread Wei Liu
On Tue, Oct 09, 2018 at 11:42:17AM +0100, Wei Liu wrote: > Commit 2916951c1 ("mm / iommu: include need_iommu() test in > iommu_use_hap_pt()") included need_iommu() in iommu_use_hap_pt and > 91d4eca7add (" mm / iommu: split need_iommu() into has_iommu_pt() and > need_iommu_pt_sync()") made things fi

Re: [Xen-devel] [PATCH] x86/vtd: fix IOMMU share PT destruction path

2018-10-09 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 09 October 2018 14:38 > To: Paul Durrant > Cc: Wei Liu ; xen-devel@lists.xenproject.org; Kevin > Tian ; Jan Beulich ; Roger Pau > Monne > Subject: Re: [PATCH] x86/vtd: fix IOMMU share PT destruction path > > On Tue

Re: [Xen-devel] [PATCH] x86/vtd: fix IOMMU share PT destruction path

2018-10-09 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 09 October 2018 15:26 > To: xen-devel@lists.xenproject.org > Cc: Jan Beulich ; Roger Pau Monne > ; Paul Durrant ; Wei Liu > ; Kevin Tian > Subject: Re: [PATCH] x86/vtd: fix IOMMU share PT destruction path > > On Tue

Re: [Xen-devel] [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling

2018-10-09 Thread David Woodhouse
On Mon, 2018-10-01 at 09:16 +0200, Juergen Gross wrote: > The Xen specific queue spinlock wait function has two issues which > could result in a hanging system. > > They have a similar root cause of clearing a pending wakeup of a > waiting vcpu and later going to sleep waiting for the just cleared

Re: [Xen-devel] [PATCH] x86/vtd: fix IOMMU share PT destruction path

2018-10-09 Thread Wei Liu
On Tue, Oct 09, 2018 at 03:32:51PM +0100, Paul Durrant wrote: > > -Original Message- > > From: Wei Liu [mailto:wei.l...@citrix.com] > > Sent: 09 October 2018 15:26 > > To: xen-devel@lists.xenproject.org > > Cc: Jan Beulich ; Roger Pau Monne > > ; Paul Durrant ; Wei Liu > > ; Kevin Tian > >

Re: [Xen-devel] [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling

2018-10-09 Thread Juergen Gross
On 09/10/2018 16:40, David Woodhouse wrote: > On Mon, 2018-10-01 at 09:16 +0200, Juergen Gross wrote: >> The Xen specific queue spinlock wait function has two issues which >> could result in a hanging system. >> >> They have a similar root cause of clearing a pending wakeup of a >> waiting vcpu and

Re: [Xen-devel] x86 Community Call: Wed Oct 10, 14:00 - 15:00 UTC - Call for agenda items

2018-10-09 Thread Tamas K Lengyel
On Tue, Oct 9, 2018 at 7:41 AM Lars Kurth wrote: > > Hi all, > > ## Agenda > The agenda can be found at > https://docs.google.com/document/d/1ZfZ1SJRauLrISiTLXzM0DPxQL8beNkAQS5MwLLNtRKc/edit?usp=sharing > The document is R/W already I've added a last minute item I would like to discuss if po

Re: [Xen-devel] [PATCH] x86/vtd: fix IOMMU share PT destruction path

2018-10-09 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 09 October 2018 15:41 > To: Paul Durrant > Cc: Wei Liu ; xen-devel@lists.xenproject.org; Jan > Beulich ; Roger Pau Monne ; Kevin > Tian > Subject: Re: [PATCH] x86/vtd: fix IOMMU share PT destruction path > > On Tue

[Xen-devel] [PATCH v2] x86/vtd: fix IOMMU share PT destruction path

2018-10-09 Thread Wei Liu
Commit 2916951c1 ("mm / iommu: include need_iommu() test in iommu_use_hap_pt()") included need_iommu() in iommu_use_hap_pt and 91d4eca7add ("mm / iommu: split need_iommu() into has_iommu_pt() and need_iommu_pt_sync()") made things finer grain by spliting need_iommu into three states. The destructi

[Xen-devel] Ill-advised use of xs_open flag 1UL<<2 by Debian

2018-10-09 Thread Ian Jackson
tl;dr The Debian Xen packages have had a very bad patch which I propose to simply drop, with minor compatibility implications, unless someone can explain what it is for and why it is still needed, and/or has a better plan. I have been going through delta queue in the Debian Xen package.

[Xen-devel] [ovmf test] 128519: all pass - PUSHED

2018-10-09 Thread osstest service owner
flight 128519 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/128519/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a7ab1c315c3cf5e804897471e992655c9b5baa0f baseline version: ovmf d20ae95a13e851d56c661

Re: [Xen-devel] [PATCH v2] x86/vtd: fix IOMMU share PT destruction path

2018-10-09 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 09 October 2018 15:57 > To: xen-devel@lists.xenproject.org > Cc: Paul Durrant ; Jan Beulich > ; Roger Pau Monne ; Wei Liu > ; Kevin Tian > Subject: [PATCH v2] x86/vtd: fix IOMMU share PT destruction path > > Commit

Re: [Xen-devel] [PATCH] libxl: Restore scheduling parameters after migrate in best-effort fashion

2018-10-09 Thread Wei Liu
On Tue, Oct 02, 2018 at 04:49:26PM +0100, George Dunlap wrote: > Commit 3b4adba ("tools/libxl: include scheduler parameters in the > output of xl list -l") added scheduling parameters to the set of > information collected by libxl_retrieve_domain_configuration(), in > order to report that informati

Re: [Xen-devel] ARM64: PCIe in DOM0

2018-10-09 Thread Julien Grall
On 09/10/2018 12:25, Bharat Bhushan wrote: Hi, Hi Bharat, -Original Message- From: Julien Grall Sent: Friday, October 5, 2018 6:51 PM To: Bharat Bhushan ; Xen- de...@lists.xenproject.org Subject: Re: [Xen-devel] ARM64: PCIe in DOM0 Hi, On 05/10/2018 12:06, Bharat Bhushan wrote:

  1   2   >